On 03/07/2010 01:00 AM, Ian Romanick wrote: > Török Edwin wrote: >> Hi Andre, > >> I've been using your patch that enables pbo on r600: >> http://cgit.freedesktop.org/~andrem/mesa/commit/?h=r600-test&id=6ee755760d124c85bdfd121fd491f68fccca84f7 > >> Are you considering enabling it in Mesa 7.8? > > At this point the 7.8 branch is open for bug fixes *only*. The > announcement that the 7.8 branch would be created on March 5th went out > on February 23th, and the release plan was discussed quite a few times > before that. That was plenty of time to nominate patches for inclusion. > > It's probably okay to just enable ARB_pixel_buffer_object, but I'd be a > bit nervous about the rest. OpenGL 2.1 is more than just PBOs and GLSL > 1.20. Do the piglit and glean PBO tests pass on r600 with this patch?
I've run the piglit tests using tests/r500.tests, with glean in quick mode. With patch: 620/686 pass Without patch: 614/679 pass (I opened a bugreport about these failures here: https://bugs.freedesktop.org/show_bug.cgi?id=26933) The pbo tests results are: glean/pbo: fail general/pbo-teximage-tiling: pass general/pbo-read-argb8888: pass general/pbo-teximage-tiling-2: pass general/pbo-drawpixels: pass general/pbo-readpixels-small: pass general/object_purgeable-api-pbo: skip general/pbo-teximage: pass fbo/fbo-pbo-readpixels-small: pass The glean/fbo fail looks like some FP tolerance being too strict (1.0 vs 1.00000). Is there a way to accept 1.00000 for 1.0 in the piglit tests? pbo test: Test OpenGL Extension GL_ARB_pixel_buffer_object FAILURE: glGetPolygonStipple failed (at tpbo.cpp:1028) (1, 0) = [1.000000, 1.000000, 1.000000], should be [1.0, 1.0, 1.0] pbo: NOTE perf[0] = 372.891 MB/s, which is in normal mode pbo: NOTE perf[1] = 261.088 MB/s, which is using PBO pbo: FAIL rgba8, db, z24, s8, win+pmap, id 33 9 tests passed, 1 tests failed. I've also run piglit w/o the patch applied, the pbo test were the only ones that changed to skip (except for glean/pbo which was pass due to extension not present). So the rest of the piglit tests are unaffected by this patch (they pass/fail the same way). > >> Some games won't even start without pbo support (for example Heroes of >> Newerth). > >> Even if gameplay isn't perfect (there are some rendering artifacts[1], >> and some effects are slow [2]) at least the game starts with that patch. > >> [1] which is not related to your pbo patch, I see artifacts w/o it too >> in other games, and blender: >> https://bugs.freedesktop.org/show_bug.cgi?id=26735 >> [2] which can be turned off, like refraction Best regards, --Edwin ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
