-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Török Edwin wrote:
> I've run the piglit tests using tests/r500.tests, with glean in quick mode. > > With patch: 620/686 pass > Without patch: 614/679 pass (I opened a bugreport about these failures > here: https://bugs.freedesktop.org/show_bug.cgi?id=26933) > > The pbo tests results are: > glean/pbo: fail > general/pbo-teximage-tiling: pass > general/pbo-read-argb8888: pass > general/pbo-teximage-tiling-2: pass > general/pbo-drawpixels: pass > general/pbo-readpixels-small: pass > general/object_purgeable-api-pbo: skip > general/pbo-teximage: pass > fbo/fbo-pbo-readpixels-small: pass Okay. I'm convinced. I'll leave it up to the r600 maintainers to make the final call. However, they really need to do it before RC1 (March 12th). > The glean/fbo fail looks like some FP tolerance being too strict (1.0 vs > 1.00000). Is there a way to accept 1.00000 for 1.0 in the piglit tests? > > pbo test: Test OpenGL Extension GL_ARB_pixel_buffer_object > > FAILURE: glGetPolygonStipple failed (at tpbo.cpp:1028) > (1, 0) = [1.000000, 1.000000, 1.000000], should be [1.0, 1.0, 1.0] > pbo: NOTE perf[0] = 372.891 MB/s, which is in normal mode > pbo: NOTE perf[1] = 261.088 MB/s, which is using PBO > pbo: FAIL rgba8, db, z24, s8, win+pmap, id 33 > 9 tests passed, 1 tests failed. That's pretty weird. I was pretty sure that glean checked for equality by making sure the difference was below some threshold. As far as I can tell, fabs(1.000000 - 1.0) should be below any reasonable threshold. There's clearly something else going wrong. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkuUJLYACgkQX1gOwKyEAw/MPQCfZ8b/sSBRR8yN8z9u6tQrlY7J +4sAnRKvgpboQ8D3ObcNwW5lEUKudPPv =5D6f -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
