Thanks Christian. Adrian and I found out that the SSH key works fine. The problem was that when RB checks the validity of the repo (GitClient.is_valid_repository) it actually does Popen in core.py to run a command 'git ls-remote [email protected]:/repo.git HEAD', however, the child process doesn't have the same environment as the parent: it is missing rbssh. Looking into the code, I see you did register the rbssh environment in sshutils.py. But that didn't work for us. We found this solution: http://code.google.com/p/reviewboard/issues/detail?id=2108#c0, instead of making a symlink, we created a wrapper that explicitly lists all necessary environments.
It works now! Thanks a lot! /Eric On Nov 8, 12:38 pm, Christian Hammond <[email protected]> wrote: > You still need .reviewboardrc so post-review knows which server to talk to > in the first place. It's actually the recommended setup. > > You shouldn't have to rely on NFS. > > Looking over your previous e-mail, I noticed the ssh:// URL. Git actually > doesn't use this format. Rather, if you just do [email protected]:path/to/git, > it'll understand that that's SSH, and do the appropriate things. Clearly in > your case, something else is failing here. Executing the ls-remote command > with that path appeared to work for you, but it's not working when Review > Board does it? That smells like an SSH key configuration problem. > > Can you show me exactly what happens when Review Board does it? And are you > 100% certain that Review Board lists the proper SSH key in the Admin UI's > SSH page? > > Christian > > -- > Christian Hammond - [email protected] > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > > > > > On Tue, Nov 8, 2011 at 9:35 AM, adrian <[email protected]> wrote: > > I have no doubt that the ".reviweboardrc" mechanism will make post- > > review work... but it's still a work-around to the actual problem. It > > is kind of cumbersome to have to rely on NFS plus the .reviewboardrc. > > We would rather connect directly via ssh:// but we can't get this to > > work properly. > > > //adrian > > > On Nov 7, 2:59 pm, Christian Hammond <[email protected]> wrote: > > > Hi Adrian, > > > > post-review will try to compare the repository paths by default. However, > > > you can tell it explicitly which repository to use by specifying > > REPOSITORY > > > = '<name>' in a .reviewboardrc file committed in the base of the > > repository. > > > > This goes into some detail: > > > >http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#r... > > > > So long as the repositories referenced are identical, you should be good. > > > > Christian > > > > -- > > > Christian Hammond - [email protected] > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Fri, Nov 4, 2011 at 6:25 PM, adrian <[email protected]> wrote: > > > > Hello again -- > > > > > We just tried using the NFS method suggested by Maciek. While > > > > ReviewBoard is happy with this configuration, it breaks "post- > > > > review". The post-review tool uses origin.url and ReviewBoard > > > > complains that this repository does not exist. Because of this, it's > > > > not really a workable solution. Any other ideas? > > > > > //adrian > > > > > On Nov 4, 12:29 pm, adrian <[email protected]> wrote: > > > > > On Nov 4, 11:16 am, Christian Hammond <[email protected]> wrote: > > > > > > > SSH is supposed to work. We use it (for repo verification, though > > you > > > > still > > > > > > need the cgit, etc. method for getting files). > > > > > > > You'd need to go into RB and generate a new SSH key and then > > configure > > > > it > > > > > > for access on the git server. Should in theory work then. > > > > > > Hi Christian et al -- thanks for the responses. > > > > > > Note that this isn't an issue with the SSH keys -- that part works > > > > > fine. We've tried both using pre-existing keys and letting > > > > > ReviewBoard create its own. Both work. The issue is when the "git > > ls- > > > > > remote" command is issued. > > > > > > path = "ssh://[email protected]/gitolite.git" => "A repository was > > not > > > > > found at the specified path." > > > > > path = "ssh://[email protected]:gitolite.git" => "(-2, 'Name or > > > > > service not known')" > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~----------~----~----~----~------~----~------~--~--- > > > > To unsubscribe from this group, send email to > > > > [email protected] > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~----------~----~----~----~------~----~------~--~--- > > To unsubscribe from this group, send email to > > [email protected] > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
