My understanding from the allowing-changes-to-a-pull-request-branch-created-from-a-fork documentation <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork> is that only users who have push permission on the repository will be able to make edits to a pull request. I think the consequence is that we want active Sage developers to have Write access <https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-roles-for-an-organization> to the repository, and then use branch protection rules <https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches> on develop and master. David
On Tue, Sep 13, 2022 at 10:46 PM Matthias Koeppe <matthiaskoe...@gmail.com> wrote: > On Tuesday, September 13, 2022 at 7:15:10 PM UTC-7 Nils Bruin wrote: > >> >> Perhaps it's nice to address how to "make a friendly amendment" to >> someone else's "pr" or "issue", or how to collaborate on >> tickets/issues/pr's . In my work on trac tickets that happened quite a bit >> and "git trac checkout/push" makes the workflow superconvenient for that. >> It would be nice to have a convenient convention on how to replicate that >> on github. >> > > Yes, we should add some detail about this to > https://github.com/sagemath/sage/wiki/migration-from-trac-to-Git**b#proposed-workflow-on-github-with-transition-guide-from-trac > > A related question is regarding roles for developers and permissions in > our main repository. That's something in the document that still needs to > be fleshed out ( > https://github.com/sagemath/sage/wiki/migration-from-trac-to-Git**b#proposed-permissions-and-protections). > Any help / discussion of this is very welcome. > > > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/2c9d8ce6-315b-415c-96d2-a47e89949456n%40googlegroups.com > <https://groups.google.com/d/msgid/sage-devel/2c9d8ce6-315b-415c-96d2-a47e89949456n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAChs6_kUkQZHSACf052yHsLKP9kA02w9yfopViReqSrTS3wJFA%40mail.gmail.com.
