I think we need also another branch "merge-queue" which serves as the target for pull requests, with branch protection rules linear history, require positive review and checks.
Also "Release Manager @vbraun merges positively reviewed tickets into his branch https://github.com/vbraun/sage"; should then be replaced by "Release Manager @vbraun merges positively reviewed tickets into the branch merge-queue". You cannot really "merge" pull requests against one repo into another one. Moreover, I propose to realize "To make a beta or stable release, Release Manager merges (fast-forward) his branch into the develop branch and creates a tag" by a pull-request from "merge-queue" into "develop". This PR could then trigger the corresponding github action checks that should pass before a beta is released. On Wednesday, 14 September 2022 at 07:50:48 UTC+2 Matthias Koeppe wrote: > On Tuesday, September 13, 2022 at 10:26:04 PM UTC-7 David Roe wrote: > >> My understanding from the >> allowing-changes-to-a-pull-request-branch-created-from-a-fork >> documentation >> <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork> >> is >> that only users who have push permission on the repository will be able to >> make edits to a pull request. I think the consequence is that we want >> active Sage developers to have Write access >> <https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-roles-for-an-organization> >> >> to the repository, and then use branch protection rules >> <https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches> >> >> on develop and master. >> >>> >>> > Yes, please take a look at > https://github.com/sagemath/sage/wiki/migration-from-trac-to-Git**b#proposed-permissions-and-protections, > > where I have started to write something like this. > > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/2b08b01b-6220-4efd-8dfa-06f47a95868dn%40googlegroups.com.
