Re: [OpenJDK 2D-Dev] RFR: 8145019: Exceptions from TIFFImageReader.read() when loading bit depth test images

What's with the empty loop ? 2851 for (int band = 0; band < numBands; band++) { 2852 2853 } -phil. On 12/28/16, 2:17 PM, Brian Burkhalter wrote: The problems were that in some cases an incorrect ImageTypeSpecifier was being created for the layou

Re: [OpenJDK 2D-Dev] Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

I'm sorry about that. There will be merge :-(. We cannot push this buggy test to master: jtreg may stop the whole run. -yan Regards, Prem *From:*Philip Race *Sent:* Thursday, January 12, 2017 12:09 PM *To:* Prem Balakrishnan; Jonathan Gibbons *Cc:* Ajit Ghaisas; Prasanta Sadhukha

Re: [OpenJDK 2D-Dev] Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

This sounds like a jtreg bug since I don't see this specified. http://openjdk.java.net/jtreg/tag-spec.html -phil On 1/11/17, 10:04 PM, Prem Balakrishnan wrote: Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-8172559 Webrev: http://cr.openjdk.java.net/~pkbalak

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range From in print dialog is disabled

I am looking at this and the hold up is I can't remember the protocol readIPPResponse() is trying to follow. Without that understanding it is hard to say much .. so I need to go read up and remember .. Two comments : There is an extra space in if (responseMap.length> 1) { The test update i

[OpenJDK 2D-Dev] RFR: 6232267: TrueType Fonts which have only Apple platform names cannot be loaded

Bug : https://bugs.openjdk.java.net/browse/JDK-6232267 Webrev : http://cr.openjdk.java.net/~prr/6232267/ Fonts such as "Menlo" on OS X have no Microsoft names (see https://www.microsoft.com/typography/otspec/name.htm) so historically we rejected these. Now that we support OS X, this is more of

Re: [OpenJDK 2D-Dev] [9] Review Request: 8140266 Performance loss between jdk8 and jdk9 on Maskfill

make/lib/Awt2dLibraries.gmk.sdiff.html> Build change looks ok, but I too think a comment explaining why is a good idea. /Erik On 2016-12-23 15:49, Philip Race wrote: Looks OK to me although it is a very cryptic option so maybe include a comment that it is for performance with some versions of gcc ... -phil.

Re: [OpenJDK 2D-Dev] [9] Review Request: 8140266 Performance loss between jdk8 and jdk9 on Maskfill

Looks OK to me although it is a very cryptic option so maybe include a comment that it is for performance with some versions of gcc ... -phil. On 12/23/16, 3:15 AM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. The change add an additional gcc option to the libawt lib to

[OpenJDK 2D-Dev] RFR: 8130737: AffineTransformOp can't handle child raster with non-zero x-offset

Bug: https://bugs.openjdk.java.net/browse/JDK-8130737 Webrev : http://cr.openjdk.java.net/~prr/8130737/ If a child raster is created with a non-zero x-offset then subsequently in the code that validates the raster for imaging operations we may incorrectly calculate that the image exceeds the d

Re: [OpenJDK 2D-Dev] RFR(XXS): 8170954: non-ASCII characters in lcms and harfbuzz break Windows builds on some locales

This is fine by me. These are imported libraries so we just disable the warnings rather than fix them. The only question I had is that US English is the only supported build environment and RE builds will always use that .. everything else is "good luck", Unless something changed to affect that.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169725: cannot use TIFFField(TIFFTag tag, int value) for TIFF_LONG values greater than Integer.MAX_VALUE

expecting that; will update. Thanks, Brian On Dec 7, 2016, at 5:03 PM, Philip Race wrote: Looks OK except for the same question about using 0x. -phil. On 12/6/16, 12:31 PM, Brian Burkhalter wrote: Continuing from thread [1]. Pursuant to comments from the CCC, the patch [2] has been

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169725: cannot use TIFFField(TIFFTag tag, int value) for TIFF_LONG values greater than Integer.MAX_VALUE

nks, Brian [1] http://mail.openjdk.java.net/pipermail/2d-dev/2016-November/007963.html [2] http://cr.openjdk.java.net/~bpb/8169725/webrev.01/ [3] http://cr.openjdk.java.net/~bpb/8169725/webrev.00/ On Nov 23, 2016, at 8:03 AM, Philip Race wrote: +1 -phil

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169728: Missing sign checks in TIFFField(TIFFTag tag, int type, int count, Object data) for TIFFTag.TIFF_LONG

One "PS" why say 4294967295 in the spec where 0x is probably more immediately to most programmers that it is not a random choice of number ? -phil On 12/7/16, 4:56 PM, Philip Race wrote: +1 Yes, it needs a CCC update. A quick "bug fix" one. -phil. On 12/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169728: Missing sign checks in TIFFField(TIFFTag tag, int type, int count, Object data) for TIFFTag.TIFF_LONG

+1 Yes, it needs a CCC update. A quick "bug fix" one. -phil. On 12/6/16, 2:03 PM, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8169728 Patch: http://cr.openjdk.java.net/~bpb/8169728/webrev.00/ To the primary constructor TIFFFiel

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

I didn't eyeball what you changed but JPRT is now happy. The build passes on all platforms... -phil. On 12/5/16, 2:47 PM, Lindenmaier, Goetz wrote: Hi Phil, sorry for that! I fixed it, there is an other occurrence, too. I double checked all the casts, there was also a mp_flags<-> mp_sign wron

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105

in jtreg @bug tag before pushing. Regards, Ajit *From:*Prasanta Sadhukhan *Sent:* Wednesday, November 16, 2016 11:55 AM *To:* Ajit Ghaisas; Philip Race; 2d-dev *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR JDK-8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly s

Re: [OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

rrorCopyDescription(_ err: CFError!)]||, so that we can know the reason for failure better. Regards Prasanta | On 11/22/2016 8:15 AM, Philip Race wrote: On 11/21/16, 4:17 PM, Sergey Bylokhov wrote: Looks fine, but are you sure that we need such mix of logging in the debug build? Do you mean

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169725: cannot use TIFFField(TIFFTag tag, int value) for TIFF_LONG values greater than Integer.MAX_VALUE

+1 -phil On 11/16/16, 12:22 PM, Brian Burkhalter wrote: Here’s an updated version of the proposed changes. Thanks, Brian --- a/src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFImageMetadata.java +++ b/src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFImageMetad

Re: [OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

tsfontactivatefromfilereference?language=objc Not sure exactly what you mean there but if you mean that the Apple docs seem to have "deleted" the specification, yes, and that was one reason to upgrade .. I didn't even know what the limitations were on the old method. -ph

[OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

Bug: https://bugs.openjdk.java.net/browse/JDK-8167103 Webrev: http://cr.openjdk.java.net/~prr/8167103/ This bug is a deadlock in MacOS platform font code when JavaFX and Java2D are both calling platform font APIs. This can happen in the context of Swing inter-op for FX. It was previously seen whe

Re: [OpenJDK 2D-Dev] RFR: 8169202: [macos] Font substitution does not work for supplementary characters

Uint .. but it looks like UniChar is also unsigned. That header file looks like it *is* the documentation. Fine if you already know where to look but .. Anyway based on the report that you've used this for months in production I can give this a "+1" Sergey already reviewed too. Who is going to

Re: [OpenJDK 2D-Dev] [9] RFR 8160888: [PIT] What to expect of updated java/awt/print/PrinterJob/Margins.java

+1 although ... * ie ix=72 iy=72 iw=451 ih=697 and paper wid=595 that's an "eg" not an "ie" -phil. On 11/7/16, 2:28 AM, Prasanta Sadhukhan wrote: Please find the modified webrev taking care of the suggested changes http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.02/ Regards Prasanta

Re: [OpenJDK 2D-Dev] [PATCH] Make automatic font substitution on macOS work for surrogate pairs

Hi, I can file a bug on this if I can't find one. If you can email me the test it will help even if it is not checked in. -phil. On 10/26/16, 6:28 AM, Dmitry Batrak wrote: Hello, I'd like to propose a patch to make automatic font substitution on macOS work for surrogate pairs. I have a Contr

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

+1 -phil. On 10/25/16, 11:01 PM, Prasanta Sadhukhan wrote: Please find the webrev with modified testcase http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.03/ Regards Prasanta On 10/26/2016 2:45 AM, Philip Race wrote: Hi, This looks to work properly although I have a couple of nits and

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

Prasanta Sadhukhan wrote: On 10/22/2016 4:50 AM, Philip Race wrote: Well it is confusing since in particular this exact change is in both webrevs :- http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.01/src/java.desktop/macosx/native/libawt_lwawt/awt/QuartzSurfaceData.m.sdiff.html Yes.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

Oct 24, 2016, at 9:34 AM, Philip Race <mailto:philip.r...@oracle.com>> wrote: I think I saw that one but the weird final part of the name put me off. For comparison here's how they reference the OpenType (font) spec :- https://www.microsoft.com/en-us/Typography/OpenTypeSpecificati

Re: [OpenJDK 2D-Dev] RFR: 8168364: [macosx] Delete unused class NSPrintinfo

Can I get a 2nd reviewer on this one ? -phil. On 10/20/16, 3:52 AM, Sergey Bylokhov wrote: Looks fine. On 20.10.16 2:35, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8168364 webrev : http://cr.openjdk.java.net/~prr/8168364/ NSPrintInfo is an Attribute so it can

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

ec is https://msdn.microsoft.com/en-us/library/dd183391(v=vs.85).aspx which is where we point from JavaFX docs. Vadim On 24.10.2016 18:57, Philip Race wrote: I've poked around the Microsoft website and didn't turn up a location I am sure we could rely on. A top-level link to microso

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

spected as much. Could be that for BMP we are out of luck as there is no “real” specification AFAIK. Brian On Oct 24, 2016, at 8:30 AM, Philip Race <mailto:philip.r...@oracle.com>> wrote: Do not point to wikipedia. If we must point to external links we want to point to a specif

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

Do not point to wikipedia. If we must point to external links we want to point to a specification in the most "official" place that exists .. one maintained by the owner of that spec. Strictly that even becomes a part of the SE spec. Wikipedia is not a place we'd ever want to say Java SE relies

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

annot handle REPEAT/REFLECT. http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.01/ Have tested with different fractions, stops, color. Regards Prasanta On 9/28/2016 2:06 AM, Philip Race wrote: Hi, LinearGradientPaint has three options as to how it is extended beyond the end point

[OpenJDK 2D-Dev] RFR: 8168364: [macosx] Delete unused class NSPrintinfo

bug: https://bugs.openjdk.java.net/browse/JDK-8168364 webrev : http://cr.openjdk.java.net/~prr/8168364/ NSPrintInfo is an Attribute so it can presumably be stuffed in an AttributeSet. Apart from being inaccessible to apps and unused it is not a good idea. It was perhaps once used to (re-?)initi

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

I guess you could reorder the calls for CFRelease(font); and CFRelease(desc); so the desc gets released first in two locations under family == NULL and name == NULL. Just for the sake of consistency. Other than that, +1. Vadim On 16.10.2016 19:09, Philip Race wrote: Anyone ? I'd like to get

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

sake of consistency. Other than that, +1. Vadim On 16.10.2016 19:09, Philip Race wrote: Anyone ? I'd like to get this backported to 8u this week so it can the 8u122 release which will enter RDP2 soon http://openjdk.java.net/projects/jdk8u/releases/8u122.html Although I have failed to fin

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

date so it could be as early as a week from now .. -phil. On 10/12/16, 1:06 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8089573 Webrev : http://cr.openjdk.java.net/~prr/8089573/ See the bug for some images showing the problem of scrambled text when printing. Although

[OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

Bug: https://bugs.openjdk.java.net/browse/JDK-8089573 Webrev : http://cr.openjdk.java.net/~prr/8089573/ See the bug for some images showing the problem of scrambled text when printing. Although only JavaFX is affected the solution is entirely on the JDK side. JavaFX looks up some UI "system" fo

[OpenJDK 2D-Dev] RFR: 8166034: [macosx] Non-AA Serif font always displays as regular - no bold or oblique.

https://bugs.openjdk.java.net/browse/JDK-8166034 Non-AA fonts aren't always being bolded on OS X. FWIW I believe this is in part a platform (OS) bug since it is terribly inconsistent across fonts and in some cases even sizes. So we need to look into why but it definitely isn't something that c

Re: [OpenJDK 2D-Dev] [8u] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

I have verified JCK, jtreg and JPRT for updated changes in JDK8u. Thanks, Jay *From:*Philip Race *Sent:* Friday, September 23, 2016 10:10 PM *To:* Jayathirth D V *Cc:* 2d-dev *Subject:* Re: [OpenJDK 2D-Dev] [8u] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock. You ca

Re: [OpenJDK 2D-Dev] Regression test failures - could not find entries in JDK Bug System

This seems to be a question that is not specific to the client tests even if the examples are. And I have no idea about these testresults files So I think that you should instead raise this question on quality-disc...@openjdk.java.net .. -phil. On 10/3/16, 1:18 AM, Vitaly Provodin wrote: Hell

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

that means this is bad hardware .. seems Dmitri added this from the beginning. I overlooked this in the past because I was focused on the system property settings. -phil. On 9/9/16, 8:14 AM, Philip Race wrote: No .. that would be an incompatible change that might surprise a lot of people.

Re: [OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

webrev is still the same. http://cr.openjdk.java.net/~aghaisas/8158356/8u_backport/webrev.00/ Request you to approve this 8u backport. Regards, Ajit -Original Message- From: Jim Graham Sent: Friday, September 02, 2016 1:16 AM To: Ajit Ghaisas; Philip Race; 2d-dev Subject: Re

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8166685: We should unpin stream and pixel buffer in case of setjmp during writeImage in JPEG.

+1 -phil. On 9/26/16, 12:35 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8166685 Webrev : http://cr.openjdk.java.net/~jdv/8166685/webrev.00/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

Hi, LinearGradientPaint has three options as to how it is extended beyond the end point https://docs.oracle.com/javase/8/docs/api/java/awt/MultipleGradientPaint.CycleMethod.html So far as I can see this code (and perhaps quartz) can only handle NO_CYCLE .. If REFLECT or REPEAT are specifie

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8164931 : Verify if writer.abort() works properly for all writers in IIOWriteProgressListener.

2016 11:00 AM To: Jayathirth D V; Sergey Bylokhov; Philip Race; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8164931 : Verify if writer.abort() works properly for all writers in IIOWriteProgressListener. Is it not required to call abortRequested() after

Re: [OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems

On 9/26/16, 12:50 PM, Clemens Eisserer wrote: Thanks a lot for the feedback. The fix seems fine .. is there a possibility to have a regression test? Perhaps based on the code in the bug ? Please find an automated regression test at: http://93.83.133.214/8162591/HugeGradientTest.java OK ..

Re: [OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems

Clemens, The fix seems fine .. is there a possibility to have a regression test? Perhaps based on the code in the bug ? -phil. On 9/26/16, 8:48 AM, Clemens Eisserer wrote: Hello, The cause of JDK-8162591 is Java2D's gradient implementation allowing for coordinates to be specified using floati

Re: [OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

, 8:17 AM, Sergey Bylokhov wrote: The changes looks fine, should we increment version=1 to other version or it is not used? Unrelated question is how we validate all these paths if some of them are absent? On 23.09.16 8:08, Philip Race wrote: PING .. any takers on this two week old RFR ? -phil

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

+1 -phil. On 9/23/16, 10:24 AM, Prasanta Sadhukhan wrote: Yes, sorry. Done http://cr.openjdk.java.net/~psadhukhan/8165947/webrev.03/ Regards Prasanta On 9/23/2016 10:44 PM, Philip Race wrote: 77 throw new RuntimeException("Banner page is printed"); that messag

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

16 9:47 PM, Philip Race wrote: The JDK changes are fine but I don't think the test is. It assumes that the system default is no banner page. You need to update the test to check what the system default is (banner or no banner) and have the tester "expect" whatever that happens to b

Re: [OpenJDK 2D-Dev] [8u] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

reate a new Bug and add the RELEASE_ARRAY() call in writeImage() or I have to check-in this change under JDK-8162461 only? After check-in of this modification I will raise new webrev for 8u backport. Thanks, Jay *From:*Philip Race *Sent:* Thursday, September 22, 2016 9:51 PM *To:* Jayathirt

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

30 AM, Prasanta Sadhukhan wrote: Hi Phil, Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/8165947/webrev.01/ Regards Prasanta On 9/22/2016 11:10 PM, Prasanta Sadhukhan wrote: On 9/22/2016 11:09 PM, Philip Race wrote: OK I see now. The comment should be updated to remove

Re: [OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

PING .. any takers on this two week old RFR ? -phil. On 9/8/16, 1:12 PM, Philip Race wrote: [Fix i18n-dev address] -phil. On 9/8/16, 1:10 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8162531 Webrev: http://cr.openjdk.java.net/~prr/8162531/ Solaris 10 is not

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

h the suffixes is needed, that's another question... ...jim On 9/22/16 10:56 AM, Philip Race wrote: The method getImageUsingNamingSchemes(String fileName, MediaResolutionNamingScheme... namingSchemes) works for any scheme not only for the default one. I'm sure it does. M

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

.5f), new Toolkit.MediaResolutionNamingScheme("foo", 2f) to load files "img.png", "imgabc.png", and "imgfoo.png" That doesn't look like a consistent scheme at all ... so give up on that and just have them list the full names and get rid of the unneeded AP

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

/21/2016 9:47 PM, Philip Race wrote: Hi, When the application is specifying the set of images from which to build the MRI you ask the app to specify a "schema" (probably not the right name given that it is per-file), and a floating point scale. I don't see why we need to ask the app

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

th trying to figure out how to notify an observer of incoming information. So, lazy loading may make this approach infeasible. Alexandr? ...jim On 9/21/16 11:47 AM, Philip Race wrote: Hi, When the application is specifying the set of images from which to build the MRI you ask

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

OK I see now. The comment should be updated to remove mention of the dialog and explain that instead. But in that case do you still need the "else" in setAttributes? -phil. On 9/22/16, 10:32 AM, Prasanta Sadhukhan wrote: On 9/22/2016 10:59 PM, Philip Race wrote: Your comment r

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

() so that user's selection is not overridden. I put a comment regarding that in the fix. Regards Prasanta On 9/22/2016 10:38 PM, Philip Race wrote: What happens if the application does not display a dialog but instead the application code explicitly does this: aset.add(JobSheets.STANDARD); pri

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

PrintService.getDefaultAttributeValue(JobSheets.class) and if IPP returns "none", I change the default noJobSheet to true so that no banner page is printed (to honor system default). Regards Prasanta On 9/22/2016 10:16 PM, Philip Race wrote: This looks wrong to me. Shouldn't the logic look like the one you have

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

This looks wrong to me. Shouldn't the logic look like the one you have earlier in the file ? ie this : 1271 JobSheets jobSheets = (JobSheets)attributes.get(JobSheets.class); 1272 if (jobSheets != null) { 1273 noJobSheet = jobSheets == JobSheets.NONE; 1274 }

Re: [OpenJDK 2D-Dev] [8u] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

I see this is mostly what I approved for JDK9 but I noticed you made a change after I approved it and I did not see or approve the updated version. I am concerned about this comment you posted for the JDK 9 webrev : >Regarding "2856 RELEASE_ARRAYS(env, data, (const JOCTET *)(dest->next

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

3854/webrev.01 The fix includes support for resolution variants loading by getImage() method for built-in toolkits using the following media resolution naming scheme (qualifier, scale): ("@125pct", 1.25), ("@150pct", 1.5), ("@200pct" or "@2x", 2), ("@2

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

Sorry, right that won't work .. this is an expression evaluation and the compiler needs to determine the return type which is going to end up back as Window as the most-specific super-type. Details in 15.25.3 http://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.25 So it won't hel

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

I think this bug should be downgraded to P4 and deferred. Put a link in the bug report to the fix so we can revive it later. -phil. On 9/9/16, 6:55 AM, Semyon Sadetsky wrote: On 9/9/2016 4:08 PM, Vadim Pakhnushev wrote: On 09.09.2016 15:58, Semyon Sadetsky wrote: On 09.09.2016 14:45, Vadim

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

ation, neither in JIRA nor in the review on the alias, for the 803944 resolution that d3d should be disabled for all Intel video cards. Why? It may be disabled by default, but at least the sun.java2d.d3d=true option could enable it, no? --Semyon On 9/9/2016 4:58 AM, Philip Race wrote: Please con

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

rking with d3d normally. Some visual defects will be corrected after this fix. And I didn't get why d3d is disabled for all Intel without possibility to switch it on? --Semyon On 09.09.2016 02:10, Philip Race wrote: The following is just for testing right ? It should not be in this webrev

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

adetsky/8146042/webrev.05/ --Semyon On 9/9/2016 12:20 AM, Semyon Sadetsky wrote: On 08.09.2016 22:57, Philip Race wrote: Can you provide something like a rationale for why these particular values might work ? Otherwise this seems like a fix that can't be reviewed, only tested. So

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

ge() or we can use http://cr.openjdk.java.net/~jdv/8162461/webrev.01/ having RELEASE/GET_ARRAYS change in sun_jpeg_output_message() for future proofing. Thanks, Jay -Original Message- From: Jayathirth D V Sent: Thursday, September 08, 2016 7:21 PM To: Philip Race; 2d-dev Subject: Re: [OpenJDK 2D

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

e. Also I have removed processImageProgress(0.0f) call which I feel is not needed as we have processImageStarted() which will take care of it(Also to maintain callbacks at same intervals as they are in other readers). Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, Septem

Re: [OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

[Fix i18n-dev address] -phil. On 9/8/16, 1:10 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8162531 Webrev: http://cr.openjdk.java.net/~prr/8162531/ Solaris 10 is not supported by JDK 9. This updates the fontconfig file to focus on the default set of fonts installed on

[OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

Bug: https://bugs.openjdk.java.net/browse/JDK-8162531 Webrev: http://cr.openjdk.java.net/~prr/8162531/ Solaris 10 is not supported by JDK 9. This updates the fontconfig file to focus on the default set of fonts installed on Solaris 11 as part its desktop. Preference is given to the Arial, Times

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

Can you provide something like a rationale for why these particular values might work ? Otherwise this seems like a fix that can't be reviewed, only tested. So that testing will be important. If you can be sure it passes on ATI, Nvidia, and Intel then we can take it .. otherwise we should defe

[OpenJDK 2D-Dev] RFR: 8165345: JDK macro definition re-defined by MacOS core framework

Bug: https://bugs.openjdk.java.net/browse/JDK-8165345 Webrev: http://cr.openjdk.java.net/~prr/8165345/ MacOS has its own definition of FloatToFixed, so changing the name of the JDK one. More details in the bug. -phil.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

riginal Message- From: Sergey Bylokhov Sent: Wednesday, August 31, 2016 4:22 PM To: Jayathirth D V; Philip Race Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG I have only one question: should

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160327: Support for thumbnails present in APP1 marker for JPEG

imageCreationTime = LocalDateTime.parse(dateTime, formatter); Seems like it may throw DateTimeParseException - a subtype of RuntimeException https://docs.oracle.com/javase/8/docs/api/java/time/LocalDateTime.html#parse-java.lang.CharSequence-java.time.format.DateTimeFormatter- I think in the ca

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

should be left alone. -phil. > > /Erik >> -phil. >> >>> Luckily we have the workaround of setting --disable-warnings-as-errors >>> when this situation occurs. >>> >>> For reference, the compilers Oracle uses are listed in >>> README-builds.md in

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

;> In this particular case is shift-negative-value a new warning in GCC >> 6? If that's the case it doesn't actually hurt adding it since GCC is >> nice enough to not complain about unknown warning tags. If we do, >> just make sure to specify in a comment that it's spe

[OpenJDK 2D-Dev] RFR: 8164818: Reg. test java/awt/font/TextLayout/VisibleAdvance.java fails

bug: https://bugs.openjdk.java.net/browse/JDK-8164818 webrev: http://cr.openjdk.java.net/~prr/8164818/ 26.6 fixed point was being used in harfbuzz interface code and 16.16 elsewhere so we had a precision mismatch. More details in the bug report. -phil.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

t; out="+out2); } } On 8/18/2016 11:20 PM, Prasanta Sadhukhan wrote: On 8/19/2016 3:36 AM, Philip Race wrote: Oh .. right under the covers the map is just a HashMap and the key to the map is the class so just decides if these are equal class objects. Hmm .. I don't know an

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

:24 PM, Philip Race wrote: Alexander, Were the existing Toolkit.getImage(String/URL) APIs not enhanced to do this for you automatically ? I suppose I thought they were but they can't be since you are using getImage(String) here. IMO that would be more important than this. And in any c

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

Alexander, Were the existing Toolkit.getImage(String/URL) APIs not enhanced to do this for you automatically ? I suppose I thought they were but they can't be since you are using getImage(String) here. IMO that would be more important than this. And in any case I don't see why this is solved o

Re: [OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be populated based on Pageable

change it back. Regards Prasanta On 8/24/2016 10:26 PM, Philip Race wrote: Why does the test look like this ? 157 @Override 158 public int getNumberOfPages() { 159 return 0; 160 } -phil. On 8/23/16, 5:05 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix

Re: [OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be populated based on Pageable

Why does the test look like this ? 157 @Override 158 public int getNumberOfPages() { 159 return 0; 160 } -phil. On 8/23/16, 5:05 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix whereby it is seen that Page Ranges fields in the "cross-platform" dialog does n

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154218: Non-usage of owner Frame when Frame object is passed to getPrintJob()

+1 Some day we should still consider an API that lets the application pass in an owner. -phil. On 8/24/16, 3:39 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that the Frame object passed to Toolkit.getPrintJob() is not used when cross platform pri

Re: [OpenJDK 2D-Dev] [9]Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

Please note that, this fix fixes the crash. The behavioral change in AffineTransformOp for such inputs will be fixed under JDK-8164729. Please review the updated webrev. http://cr.openjdk.java.net/~aghaisas/8158356/webrev.01/ Regards, Ajit -Original Message----- From: Philip

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

Still fine with me. -phil. On 8/23/16, 4:18 PM, Brian Burkhalter wrote: Hi Sergey, I have added some comments in both the source and the test: http://cr.openjdk.java.net/~bpb/8149562/webrev.03/ Please indicate whether you think this is

Re: [OpenJDK 2D-Dev] RFR: JDK-8164628: update copyright header in java.awt.font.JavaAWTFontAccessImpl class

Approved -phil. On 8/23/16, 3:08 PM, Yuka Kamiya wrote: Hi, https://bugs.openjdk.java.net/browse/JDK-8164628 Please review the following fix in JDK9. A comma was missing in the fix for https://bugs.openjdk.java.net/browse/JDK-8163362. --- a/src/java.desktop/share/classes/java/awt/font/Jav

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

Erik .. please chime in if you disagree with the following The goal here is to have no warnings with the *official* compilers. If you are using something else and get warnings then either fix the *source* or else you need to use --disable-warning-as-errors. Otherwise we'll be suppressing the warni

Re: [OpenJDK 2D-Dev] RFR: JDK-8163362-Reconsider reflection usage in java.awt.font.JavaAWTFontAccessImpl class

This looks fine. I am just puzzled why reflection was used to begin with. What am I missing ? Was this future proofing against new constants being added ? -phil. On 8/22/16, 7:40 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8163362. https://bugs.openjdk.java.net/browse/JDK-8163362

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

Thanks Sergey .. I am still waiting for a 2nd +1 from someone else. -phil. On 8/12/16, 12:28 PM, Sergey Bylokhov wrote: Looks fine. On 12.08.16 20:15, Philip Race wrote: Updated test : http://cr.openjdk.java.net/~prr/8139176.1/ -phil. On 8/12/16, 10:11 AM, Philip Race wrote: On 8/12/16

Re: [OpenJDK 2D-Dev] RFR: 8145901: Printed content is overlapping.

Anyone ? -phil. On 8/11/16, 3:27 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8145901 Webrev: http://cr.openjdk.java.net/~prr/8145901/ As per the evaluation in the bug this is an issue with the device scale being applied to the kerning adjustments made by the layout

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

va.desktop/share/classes/sun/print/RasterPrinterJob.java#l688 http://cr.openjdk.java.net/~psadhukhan/6574279/webrev.01/ That does not seem to be the same case as this. -phil. Regards Prasanta Regards Prasanta On 8/4/2016 2:32 AM, Philip Race wrote: High-

Re: [OpenJDK 2D-Dev] [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

On 8/17/16, 6:33 AM, Sergey Bylokhov wrote: Tested on solarisX64/solarisSparc/linuxX64 no issues were found(SwingSet2/Java2Demo). Sounds good. +1 But I wonder why the text on solarissparc filled by yellow shadow(Is it a known issue)? Yes there is an open bug. I believe it is a SPARC (or mor

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

anta On 8/17/2016 9:09 PM, Philip Race wrote: This all looks fine although this can be a simple call to attributes.get(CustomMediaTray.class) can't it ? 502 for (int i=0; i< attrs.length; i++) { 503 Attribute attr = attrs[i]; 504 try { 505 if

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

+1 -phil On 8/18/16, 9:12 AM, Jayathirth D V wrote: Hi Prasanta, Changes are working fine. Thanks, Jay *From:*Prasanta Sadhukhan *Sent:* Thursday, August 18, 2016 5:30 PM *To:* Jayathirth D V; Philip Race; 2d-dev *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163258 : Getting NullPointerException from ImageIO.getReaderWriterInfo due to failure to check for null

+1 -phil On 8/18/16, 9:04 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8163258 Webrev : http://cr.openjdk.java.net/~jdv/8163258/webrev.00/ I

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

This all looks fine although this can be a simple call to attributes.get(CustomMediaTray.class) can't it ? 502 for (int i=0; i< attrs.length; i++) { 503 Attribute attr = attrs[i]; 504 try { 505 if (attr instanceof CustomMediaTray) { 506

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

+1 with the caveat that I am assuming you tested this did not regress anything else .. -phil. On 8/11/16, 10:22 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that Print-to-File option is disabled even for SERVICE_FORMATTED DocFlavor after JDK-504901

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

Updated test : http://cr.openjdk.java.net/~prr/8139176.1/ -phil. On 8/12/16, 10:11 AM, Philip Race wrote: On 8/12/16, 5:48 AM, Sergey Bylokhov wrote: Hi, Phil. A few comments about the test: - jtreg can stop the test at the end of the main, before invokeLater will start/complete.(on my

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

on-essential if I make the above change - Probably the correct location of the test is java/awt/font/TextLayout/? OK. I will tweak the test and resubmit shortly. On 11.08.16 0:15, Philip Race wrote: Equals was returning true because the full name is the same for all members of the family.

[OpenJDK 2D-Dev] RFR: 8145901: Printed content is overlapping.

Bug: https://bugs.openjdk.java.net/browse/JDK-8145901 Webrev: http://cr.openjdk.java.net/~prr/8145901/ As per the evaluation in the bug this is an issue with the device scale being applied to the kerning adjustments made by the layout engine. The fix builds cleanly in JPRT and has been tested wi

<    1   2   3   4   5   6   7   8   >