[chromium-dev] Re: OS X Sandbox design doc updated

2010-01-14 Thread Mike Pinkerton
Awesome! Thanks! On Thu, Jan 14, 2010 at 3:13 AM, Jeremy Moskovich wrote: > Hi, > I've updated the OS X Sandboxing design doc to better reflect the current > state of affairs. > Edits/corrections are welcome. > Best regards, > Jeremy -- Mike Pinkerton Mac Ween

[chromium-dev] Re: [Chrome-team] Re: [Mac] Something is eating the right mouse button events in the Toolbar. Help!

2010-01-11 Thread Mike Pinkerton
ing is eating them up >> and I don't know what's going on. >> >> A >> > > -- > You received this message because you are subscribed to the Google Groups > "Chrome-team" group. > To post to this group, send email to chrome-t...@google.com. >

Re: [chromium-dev] Core Text

2009-12-14 Thread Mike Pinkerton
ATSUI crashes on 10.6. How do we know there won't be a perf regression on 10.6.2? We haven't measured it, so we may still be slowing things down, correct? -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View ar

Re: [chromium-dev] Extensions and the Mac

2009-12-11 Thread Mike Pinkerton
will be far fewer people that install it when it explicitly says it won't run for them and then leave a 1-star comment than people who install it with no warning and then expect it to work. You're right there will still be some, but -- Mike Pinkerton Mac Weenie pinker...@google.co

Re: [chromium-dev] Extensions and the Mac

2009-12-11 Thread Mike Pinkerton
//groups.google.com/group/chromium-dev > > -- > Chromium Developers mailing list: chromium-dev@googlegroups.com > View archives, change email options, or unsubscribe: > http://groups.google.com/group/chromium-dev -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

[chromium-dev] sheriff swap Dec 18/21?

2009-12-10 Thread Mike Pinkerton
Hey everyone, I noticed I'm on the hook for sheriff duty on Dec 18/21 (Friday/Monday) but I was hoping to be taking vacation during that time. Does someone want to swap with me? Thanks in advance! -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chr

Re: [chromium-dev] Need a linux-views build buddy.

2009-12-03 Thread Mike Pinkerton
Yes, except it's down and hasn't worked in days. On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow wrote: > Isn't "gcl try -b linux_view" what you want? > > On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton > wrote: >> >> I've got a cl that builds

Re: [chromium-dev] Need a linux-views build buddy.

2009-12-03 Thread Mike Pinkerton
The same is true of view_chromeos, FWIW. On Thu, Dec 3, 2009 at 5:45 PM, Mike Pinkerton wrote: > Yes, except it's down and hasn't worked in days. > > On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow wrote: >> Isn't "gcl try -b linux_view" what you want? &g

[chromium-dev] Need a linux-views build buddy.

2009-12-03 Thread Mike Pinkerton
05/show for me with linux views and see if it's all ok? The only tricky part is that there's an svn move on 2 files in there, but the trybots seem able to figure it out. Would be much appreciated, thanks! -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Develop

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-03 Thread Mike Pinkerton
the last week, I've been making some changes to how threads are used in > the browser process, with the goal of simplifying cross-thread access and > improving stability. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Deve

[chromium-dev] [Mac] Make sure you're working on M4 P1 bugs

2009-11-02 Thread Mike Pinkerton
know ASAP so that we can get you some help. Letting us know on Friday doesn't do much good. Email if you have any questions! -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups

[chromium-dev] Improving our documentation

2009-10-28 Thread Mike Pinkerton
ly, we'll add all of these docs to dev.chromium.org. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Mike Pinkerton
is helping here?  Can > we pre-render the NTP on other platforms? > > 3) Startup time is faster than calculator. > > Adam > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: c

[chromium-dev] Re: Code Yellow: Dev Channel Release On-Hold This Week

2009-10-27 Thread Mike Pinkerton
P1 or lower to me. > P0 is supposed to mean "blocks work until it's fixed".  Things like crashes > and regressions are generally P1 unless they're things like "100% crash on > start". > PK > > > -- Mike Pinkerton Mac Weenie pinker...

[chromium-dev] Re: Tab Thumbnails and Aero Peek (of Windows 7)

2009-10-23 Thread Mike Pinkerton
s fast as possible, > so the actual thumbnails aren't guaranteed to be any particular size. > > I would just use the default size for now. If it doesn't look OK, we > can add a future enhancement to request the size, so the ones it > generates on-demand (the ones where there is

[chromium-dev] Re: RFC: AutoFill++ Design Document

2009-10-20 Thread Mike Pinkerton
chanism to allow us to recognize and provide this info to the form instead of requiring the user to fill out the form completely? On Tue, Oct 20, 2009 at 1:13 PM, James Hawkins wrote: > > Hi, please read the inlined proposed design for AutoFill++.  Any feedback and > comments are ap

[chromium-dev] Re: Who owns crash...@chromium.org and why is there so many updates from it?

2009-10-12 Thread Mike Pinkerton
gt;> wrote: >>>> > It's the role account that manages crashes and crash related bugs. >>>> > Kind Regards, >>>> > >>>> > Anthony Laforge >>>> > Technical Program Manager >>>> > Mountain View, CA >>>> > >>>> > >>>> > On Tue, Oct 6, 2009 at 7:26 PM, Patrick Johnson >>>> > wrote: >>>> >> >>>> >> [+laforge] >>>> >> >>>> >> On Tue, Oct 6, 2009 at 6:51 PM, John Abd-El-Malek >>>> >> wrote: >>>> >> > I got 21 emails in the last day >>>> >> > for http://code.google.com/p/chromium/issues/detail?id=20915 >>>> >> > >> > >>>> >> > >>>> > >>>> > >>> >> >> >> > >> > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Mike Pinkerton
said, I do try to get to code reviews as soon as possible. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Mike Pinkerton
r than that. Wow, you guys are really on top of things :-) I think a half day is a bit too soon. Code reviews shouldn't be a priority 0 interrupt, even though they are quite important. I think it's ok to let it go a day or two before contacting, but I agree it's not rude to do so

[chromium-dev] [Mac] Tab animation "improvements" under heavy stress

2009-10-07 Thread Mike Pinkerton
and then go remove it later if anyone complained. What do people think? -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: Question about linux pixel tests

2009-10-06 Thread Mike Pinkerton
oking > at http://build.chromium.org/buildbot/layout_test_results/webkit-rel-linux/28080/layout-test-results.zip and > trying to find fast/css/last-of-type-pseudoclass-expected.png (it's not in > there). > -atw > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com

[chromium-dev] OCMock landed in third_party

2009-09-29 Thread Mike Pinkerton
uot; One big advantage is that we are now able to mock areas of Cocoa (such as global singletons) in unit tests without disturbing the surrounding machine. Please take advantage of it when writing unit tests for Mac OS X. Thanks to Paul Wicks for providing the CLs to get it building in our infrastructu

[chromium-dev] Re: Is that unimpossible to add a progress bar of page loading with webkit?

2009-09-28 Thread Mike Pinkerton
gainst > being lost in the dark in some way. > Do you not agree? I do not agree. I doubt most users care that there are 37 images remaining to load, or 17 scripts. It's just more information to overload them with that they don't understand. -- Mike Pinker

[chromium-dev] Re: gclient hang

2009-09-25 Thread Mike Pinkerton
 rm -rf src/third_party/WebKit/WebKit/chromium > or >  rd /q /s src\third_party\WebKit\WebKit\chromium > > before syncing. > > Sorry for the trouble, > > M-A > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---

[chromium-dev] Re: Pasteboards and the mac valgrind builder

2009-09-24 Thread Mike Pinkerton
ly and on the test > bots, but fail on the valgrind bot? > > Thanks, > Nico > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives

[chromium-dev] Re: Webkit merges and tree closures

2009-09-23 Thread Mike Pinkerton
ardeners are not webkit committers (for example, the entire mac group). I don't understand your point. Are you saying that only webkit committers should be on the webkit sheriff rotation? -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~

[chromium-dev] Re: Webkit merges and tree closures

2009-09-23 Thread Mike Pinkerton
> WebKit gardening occurs more often than sheriff duties. > afaik all WebKit gardeners also have sheriff duties. This implies there are people on the team who don't have gardening duties. We need to fix that ASAP. Nobody should get special dispensation. -- Mike Pinkerton Mac We

[chromium-dev] Re: OSX cocoa_test_helper.mm and the like in browser.lib.

2009-09-21 Thread Mike Pinkerton
nce the file is in chrome/browser/, that would not be > appropriate for my file.  [cocoa_test_helper.mm doesn't have any > dependencies w/in browser, that I can see, so it could maybe move > there.] > > Any thoughts? > > -s

[chromium-dev] Re: Seeing a grey bar at the bottom of the 211 mac dev release? Read on.

2009-09-21 Thread Mike Pinkerton
t;> >> """Bug 19073 landed prematurely and has been backed out. >> Unfortunately, the 211 build >> came from the tiny window when it was checked in.""" >> >> Nico >> > > > > -- Mike Pinkerton Mac Weenie pinker...@goog

[chromium-dev] Re: Verdict: Menu string casing

2009-09-16 Thread Mike Pinkerton
. > > To be clear, that means splitting along platform conventions for stuff > like Preferences vs Options is out?  (Don't have a strong opinion, > just curious.) > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~--

[chromium-dev] Re: icu was upgraded to 4.2.1 : you want to clobber on Windows

2009-09-09 Thread Mike Pinkerton
rather than > icuNN.gyp) to avoid having to track down them all and change next time we > upgrade ICU.  I haven't yet done the same with 'icudtNN.dll' on Windows, but > perhaps I have to do that, too. > > Once again, sorry if this email is too late to

[chromium-dev] Re: Windows trybot issue.

2009-09-09 Thread Mike Pinkerton
n_tests - 1 error(s), 0 warning(s) >> >> 1 build system warning(s): >>- PDB instance limit is enabled >> >> -- Done -- >> >> Build: 219 succeeded, 1 failed, 0 skipped >> program finished with exit code 1 >> >> >>

[chromium-dev] Re: Why scrollbars don't match on the Mac pixel tests

2009-09-08 Thread Mike Pinkerton
splayIfNeeded] > #12    0x00011ab4 in -[FrameLoadDelegate webView:didFinishLoadForFrame:] at > FrameLoadDelegate.mm:207 > > That's why the scrollbars are different. I thought that they'd moved from > using the Cocoa scroll code in WebCore, but it doesn't seem so. > &

[chromium-dev] Re: Chrome has started crashing like CRAZY since 4.0.203.2

2009-08-31 Thread Mike Pinkerton
gt; > > > place to come for debugging and instant advice. >> >> > > > On Aug 29, 11:17 pm, Marc-Antoine Ruel wrote: >> > > >> Still, we are getting a lot of sqlite3 crashes in this revision, you >> > > >> may want

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Mike Pinkerton
;t recall how this test works, but it seems logical to test NTP >> performance you'd want some data that the NTP would make use of...) >> >> On Wed, Aug 26, 2009 at 9:23 AM, Mike Pinkerton >> wrote: >>> >>> If you look at >>> >>>  h

[chromium-dev] Major tab cold regression on mac around r24415

2009-08-26 Thread Mike Pinkerton
tml&range=24415:24419 Anyone know what's going on? This is a very serious regression and there were no Mac-specific changes anywhere in the vicinity that I could see. I filed http://code.google.com/p/chromium/issues/detail?id=20312 to cover the regression. -- Mike Pinkerton

[chromium-dev] Re: Chromium / Google Summer of Code

2009-08-24 Thread Mike Pinkerton
g code > review for all changes made was a new to me, and line by line review > is great at ensuring I got detailed feedback. > > Dean's mentoring was the most valuable part of the experience. He was > great at answering

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-20 Thread Mike Pinkerton
have a bug filed to provide one (as it's also an affordance for dragging the page URL and Title to other applications, which I sorely miss). This puts Chromium slightly behind in the click-to-select wars that the other browsers provide as an alternative. -- Mike Pinkerton Mac Wee

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-20 Thread Mike Pinkerton
ox, the cursor should be placed. The >> > contents of the omnibox should not be selected. >> >> We violate this convention on Windows too. > > Yep, and so does every other browser in the universe.  There's a convention > that a single click in a browser

[chromium-dev] Mac Debug is hosed, needs an owner

2009-08-17 Thread Mike Pinkerton
::RenderObject*, const WebCore::IntSize&)) Discussions in IRC this morning have linked it to WebKit merge r23527. This appears to only hit Mac debug, but it makes it impossible to do any work with a trunk debug build. I think we should hold the tree closed until we can get this resolved. -- Mike Pinke

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Mike Pinkerton
. Agreed that there's some > overlap in usage, though. > - Pam > > On Wed, Aug 12, 2009 at 12:59 PM, Mike Pinkerton > wrote: >> >> The few times I've needed to use the history menu (gak, i just closed >> something by accident, let me get it back), re-using the

[chromium-dev] Re: Mac History Menu

2009-08-12 Thread Mike Pinkerton
own tab, sure. But when someone picks an item from the history >>> menu, where does it go? I think current foreground tab is right, with >>> command for background tabs. >> >> Yes, I was confused. I think clobbering is OK in that case. My new & >> improve

[chromium-dev] Re: Design Doc: out of process (v8) proxy resolving

2009-07-29 Thread Mike Pinkerton
46 >> >> >> http://sites.google.com/a/chromium.org/dev/developers/design-documents/out-of-process-v8-pac >> >> Feedback welcome. >> >> > > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~---

[chromium-dev] Re: How to attach to Renderer Process in XCode

2009-07-29 Thread Mike Pinkerton
t;>> >>> >>> [460:11783:4914670085769:ERROR:/Users/n179911/chromium/src/ipc/ipc_channel_posix.cc(649)] >>> pipe error on 3: Broken pipe >>> >>> Thank you for any help. >>> >>> >>> > >

[chromium-dev] Re: Duplicate expectations?

2009-07-28 Thread Mike Pinkerton
. >> -Darin >> >> On Tue, Jul 28, 2009 at 11:01 AM, Mike Pinkerton >> wrote: >>> >>> We used to have to run: >>> >>>  run_webkit_tests.sh --lint-test-files >>> >>> in order to check for duplicate WebKit layout test expect

[chromium-dev] Duplicate expectations?

2009-07-28 Thread Mike Pinkerton
up by this. What happened? Did it get lost, or did we change our minds? -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubs

[chromium-dev] 2000 errors building WebCore bindings!

2009-07-06 Thread Mike Pinkerton
hrows XCode for a loop. This was introduced at r19816. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.g

[chromium-dev] New new tab page questions

2009-07-01 Thread Mike Pinkerton
fine for this, we shouldn't be using text if it's not necessary. Let me know if I should start filing bugs or keep emailing comments. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev

[chromium-dev] Clobber probably needed

2009-06-30 Thread Mike Pinkerton
I had to do a full clobber this morning after last night's tree activity. Otherwise I got errors building V8. This is on Mac, but I assume other platforms would be similar. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chr

[chromium-dev] Re: middle click on home

2009-06-29 Thread Mike Pinkerton
> Middle-click always opens a new tab in the background and making > exceptions is just likely to confuse users. Except when middle-clicking on a tab means "close the tab". So it means both open and close, depending on the context. -- Mike Pinkerton Mac Weenie pink

[chromium-dev] Re: Important: Porting bits of UI by subclassing is now banned.

2009-06-23 Thread Mike Pinkerton
anted to make nearly as flexibly as composition would have. > (For the curious, this is why I spent the last week rewriting the > cross-platform WebKit ICO and BMP decoders I just checked in.) > PK > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~

[chromium-dev] Re: Conventions and patterns for multi-platform development

2009-06-19 Thread Mike Pinkerton
d(FOO)" over "#ifdef FOO", > e.g. because you can add "|| defined(BAR)" to the former later. > PK This is already documented in our Chromium coding style guide. Do we need to replicate it? -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~-

[chromium-dev] Re: Conventions and patterns for multi-platform development

2009-06-19 Thread Mike Pinkerton
follow these guidelines. It can't possibly cover every case, so > you'll have to use your best judgement. > > Feedback from people who have done a lot of this stuff would be great. > Ideally it would be easy to follow and cover most

[chromium-dev] Re: Login name auto-fill code

2009-06-12 Thread Mike Pinkerton
he beginning (after i first > install), then it stopd working (i have to type in my login name every > time). -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archive

[chromium-dev] Re: Resurrecting the JSC build.

2009-06-11 Thread Mike Pinkerton
some help from the infrastructure gods. > > So, do you think that resurrecting the JSC build is a: > > a) terrible idea > b) great idea > c) whatcha talking bout, Willis? > > :DG< > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~--

[chromium-dev] Re: Naming things _views

2009-06-11 Thread Mike Pinkerton
; gtk: gtk/info_bubble_gtk.cc and class name InfoBubbleGtk >>> > >>> > On Thu, Jun 11, 2009 at 7:45 AM, Ben Goodger (Google) >>> > wrote: >>> >> >>> >> If you're porting a file in

[chromium-dev] Re: Adding Mac OS X Spellchecker to Chromium

2009-06-10 Thread Mike Pinkerton
ly easy >> > >> to >> > >> modify the spellchecking code for any one platform without breaking >> > >> any >> > >> other. >> > >> The main downside that I can see for doing it this way is that for >> > >> languages that ar

[chromium-dev] Re: Where is the code to pop up dialog

2009-06-03 Thread Mike Pinkerton
pointers tor the code which pop up dialog in chromium? > e.g. JavaScript alert dialog or confirm dialog? > I am specifically looking how that is done on MacOS. > Thank you. > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--

[chromium-dev] Re: Where is the code which chromium display the loading status

2009-06-01 Thread Mike Pinkerton
i load chromium on MacOS, it has 'Waiting...', 'Contacting..' status > displayed at the bottom of the browser. > Can you please tell me where is the code which display that? > Thank you. > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-

[chromium-dev] Re: Mac History Menu Implementation

2009-05-26 Thread Mike Pinkerton
On Tue, May 26, 2009 at 12:59 AM, Ben Goodger (Google) wrote: > Wash your mouth out with soap. The availability of real estate is > never an excuse to use it in Chrome :-P Ok, we'll just go without because it doesn't exist in windows. :P -- Mike Pinkerton Mac Weenie pink

[chromium-dev] Re: Mac History Menu Implementation

2009-05-25 Thread Mike Pinkerton
people stand on this? >> >> I actively dislike long and hierarchical menus--for extended browsing, >> we have a "History" link off of the new tab page for history browsing >> & searching. >> >> However, a history menu with, say, the 10-1

[chromium-dev] Re: Is there any way to profile chromium on MacOS?

2009-05-25 Thread Mike Pinkerton
ach page > load? or can i run chromium with some profiling tool on MacOS to > understand the bottleneck? > > Thank you. > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chrom

[chromium-dev] Re: Renderers "Not Responding"

2009-05-22 Thread Mike Pinkerton
ve a >> separate bundle for the renderer and 2) I don't know if that fixes our >> problem. >> >> The only thing I can think of now is to create the MessageLoopForIO in >> renderer_main in a non-main thread and m

[chromium-dev] Re: Help needed for Chromium on the Mac refresh problem...

2009-05-14 Thread Mike Pinkerton
ectangles in the bitmap... >> >    But this code works fine on Windows and is not done in a Windows >> > specific >> > way... So I'm kind of lost and don't know where to look... Anybody has a >> > clue

[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Mike Pinkerton
m >> http://cia.vc/stats/project/WebKit >> >> There would be about 25 minutes (on average) between messages, but of >> course clustered during US business hours. >> >> Adam >> >> > > > > > -- Mike Pinkerton Mac Weenie pinker...@goog

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-07 Thread Mike Pinkerton
ac/like. >>> >>> As I type this I wonder if we can get a sheet to come down under the tab >>> bar and hide/show it with the tab. Would that be good UI-wise? >>> >>> And of course, I'd probably retrofit the file picker to do that too. >>> >>> Thoughts? >>> >>> Avi >> >> > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: Need help in finding a performance problem...

2009-05-05 Thread Mike Pinkerton
. >> >> If you get performance improvements, please do commit :) >> >> Evan is correct that Darin needs to check this over, but I'll happy >> code review everything where I can. >> >> >> AGL > > -- Mike Pinkerton Mac Weenie pinker...@go

[chromium-dev] Re: Why are pref keys wchar_t's?

2009-05-01 Thread Mike Pinkerton
xist, and none of them >> are correct. I think this isn't particular instance isn't likely to b >> *that* much waste but it definitely would be nice to fix. >> >> I fixed command line switch names to be ASCII on the train into work >> once just 'cause it was

[chromium-dev] Why are pref keys wchar_t's?

2009-05-01 Thread Mike Pinkerton
Why are our internal pref keys all wchar_t strings? That's pretty wasteful for something the user never sees and doesn't need to be localized. It's really wasteful on Mac and Linux (32bit wchar_t). Is this on anyone's radar to fix? Should I file a bug? -- Mike Pinkert

[chromium-dev] Re: Discussion to take over #chrome on irc

2009-05-01 Thread Mike Pinkerton
Spiro wrote: > We don't need to make people to look on the Web to find out what > channel to join. We should make #chrome Just Work, especially since > it is so easy to do. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chr

[chromium-dev] Re: How can I run TestShell in Xcode on MacOS

2009-04-30 Thread Mike Pinkerton
src/webkit/tools/test_shell/test_shell.xcodeproj On Wed, Apr 29, 2009 at 9:53 PM, daniel wrote: > How can I run TestShell in Xcode on MacOS? Which xcode project I > should use? -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Ch

[chromium-dev] Re: Need help in finding a performance problem...

2009-04-29 Thread Mike Pinkerton
fore actually painting so that (a) your layout info is up to date and (b) any additional rects added by the layouts can become part of that current paint. You'll probably want to study the Windows WebView for this." Again, I'm ignorant of what we do here, though I'm pretty sure w

[chromium-dev] Re: chromium resources always rebuilding

2009-04-28 Thread Mike Pinkerton
doesn't matter either way for me, but if > we're trying to speed up the mac try slaves, this probably isn't going > to help (this change has been in for almost a month). > > tony > > On Tue, Apr 28, 2009 at 8:46 AM, Mike Pinkerton > wrote: >> Yes, this is ce

[chromium-dev] Re: chromium resources always rebuilding

2009-04-28 Thread Mike Pinkerton
wrote: > > You really should take a look ASAP because yesterday, the mac try > slaves were like 35+ jobs being. That makes mac testing inexistent and > will just cause more mac breakage. I assume today, tomorrow, etc will > be as bad. -- Mike Pinkerton M

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-04-27 Thread Mike Pinkerton
consolidating code may not be warranted, but to jump all over it because a file has to be written seems like premature optimization in light of everything else that happens on the disk at app startup. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~-

[chromium-dev] Re: Please use BUG and TEST in changelists

2009-04-23 Thread Mike Pinkerton
think we've still got plenty of "big rocks" on each platform to keep us busy without everything being a bug. Spreadsheets aren't always 4-letter words, and they can have pretty colors!!! :-) -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~--

[chromium-dev] Re: URLRequestMockHTTPJob?

2009-04-22 Thread Mike Pinkerton
33 AM, Mike Pinkerton wrote: > The problem I'm seeing is that this is getting called before the > ChromePathProvider has been registered with the path service in the > browser, so it doesn't get any path. > > I'll keep digging as to why. > > On Tue, Apr 21, 2009 at 6

[chromium-dev] Re: URLRequestMockHTTPJob?

2009-04-22 Thread Mike Pinkerton
m PathService::Get(chrome::DIR_TEST_DATA). Is that > variable set for mac? > (see chrome/browser/automation/automation_provider.cc:2117) > > On Tue, Apr 21, 2009 at 2:49 PM, Mike Pinkerton > wrote: >> >> Anyone familiar with how URLRequestMockHTTPJob is supposed to

[chromium-dev] URLRequestMockHTTPJob?

2009-04-21 Thread Mike Pinkerton
sn't going to find the Debug directory. It's looking for things in chrome/test/data. How does this extra mapping get done? Am I missing something obvious? -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailin

[chromium-dev] [Mac] chrome/browser/cocoa UI and writing unit tests

2009-04-17 Thread Mike Pinkerton
butors to help out. Tests are something small that can be good first bugs for people wanting to get involved. Let me know if you have any questions about what to do when writing a unit test or how to use the helpers. Happy testing! -- Mike Pinkerton Mac We

[chromium-dev] Re: [Mac] Use scoped_ptr and scoped_nsobject

2009-04-10 Thread Mike Pinkerton
the bug I discovered earlier). So these classes are still wonderful and self-documenting and full of goodness, but you should make double-sure you understand what's going on when you do a conversion. -- Mike Pinkerton Mac Weenie pinke

[chromium-dev] [Mac] Use scoped_ptr and scoped_nsobject

2009-04-10 Thread Mike Pinkerton
deed both dtors and deallocs are correctly called. It took like 2 minutes. Let me know if you have any questions, and be sure to remind your fellow coders about these classes when doing code reviews. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~

[chromium-dev] Re: Lots of IPC errors this morning

2009-04-09 Thread Mike Pinkerton
FYI: This was resolved earlier this morning. I guess I got unlucky and sync'd at a bad time. It was an issue with the devtools_agent_filter. On Thu, Apr 9, 2009 at 11:24 AM, Mike Pinkerton wrote: > I sync'd my tree this morning and all i have to do is click a page off > NTP to

[chromium-dev] Lots of IPC errors this morning

2009-04-09 Thread Mike Pinkerton
Users/pinkerton/src/trunk/src/chrome/common/ipc_channel_proxy.cc(158)] Check failed: false. filter to be removed not found errors. Things aren't really happy. Anyone touching stuff that might be IPC related yesterday? -- Mike Pinkerton Mac Weenie pinker...@

[chromium-dev] Moving to single toolbar instance (per window) on mac

2009-04-03 Thread Mike Pinkerton
hood up to this point), this should actually be a simplification. It will mean that we'll need to use more of the OmniBox code for stashing/retrieving state on tab switches, but again that code should hopefully be factored for cross-platform use anyway. Let me know if you have any issues or complain

[chromium-dev] Re: Mac work plan - Implementing about:memory etc tasks

2009-04-02 Thread Mike Pinkerton
need to get > tracked as a bug, as well as any comments on getting started with work > on the feature - perhaps design discussions through email or IRC, or > pointers to relevant parts of code? > > (I've got source trees compiled on both OS X and Linux, so I'm good to

[chromium-dev] Mac Work Plan

2009-03-31 Thread Mike Pinkerton
tasks into the buglist, though we will continue to keep our dogfood bugs there (and referenced as an on-going line-item in the doc). Feel free to email me with questions or find us on IRC. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--

[chromium-dev] Re: Omnibox q around Mac+Chromium best-practices.

2009-03-20 Thread Mike Pinkerton
eate Objective-C >> methods solely to be called from C++, nor C++ methods solely to be >> called from Objective-C, except for cases where either would need to >> poke through the encapsulation boundary. >> >> Thanks, >> scott >> >> > >> > >

[chromium-dev] Re: Mac Dogfood Planning

2009-03-16 Thread Mike Pinkerton
I've been adding more things to the "label:dogfood" query that prevent me from using Chromium as my primary browser. We should try to get things off that list that aren't really dogfood. On Wed, Mar 4, 2009 at 6:05 PM, Mike Pinkerton wrote: > On Mon, Mar 2, 2009 at

[chromium-dev] Re: Copy/Paste, Cocoa, and you

2009-03-11 Thread Mike Pinkerton
ML >> flavor and decides that it wants to turn it into an attributed string. > > Couldn't you just tell the URL box to only accept the plain text > clipboard format? -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Ch

[chromium-dev] Mac builds crash on every page

2009-03-05 Thread Mike Pinkerton
nyone? Anyone know something that went in that might affect IPC channels? None of that code appears to have changed in at least a week. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromiu

[chromium-dev] Re: Mac Dogfood Planning

2009-03-04 Thread Mike Pinkerton
On Mon, Mar 2, 2009 at 2:27 PM, Mike Pinkerton wrote: > Let's hold off picking what we're working on until we've agreed this > is the right list. I've turned this list into bugs in our bugtracker with a label of "Dogfood" http://code.google.co

[chromium-dev] Re: What's the deal temp_scaffolding_subs ?

2009-03-04 Thread Mike Pinkerton
2009 at 9:41 AM, Mike Pinkerton wrote: > Well, its not *verbatim*, but it is starting to converge on the real > thing. Here's the history: > > When we started porting the front-ends, we just stubbed the big > classes enough to get it limping, filling in empty declarations

[chromium-dev] Re: What's the deal temp_scaffolding_subs ?

2009-03-04 Thread Mike Pinkerton
batim into stubs, etc. Totally confused. > > Thanks > -- dean > > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: Mac Dogfood Planning

2009-03-02 Thread Mike Pinkerton
ing w/ NOTIMP() and/or > DCHECKs? Seems like anything that shows up loading basic pages should also > go on the list for close out (either do it, or remove the log and open a bug > for follow up like the linux folks have done). -- Mike Pinkerton Mac Weeni

[chromium-dev] Mac Dogfood Planning

2009-03-02 Thread Mike Pinkerton
o what the linux folks did, and triage the bugs (P1 = blocking dogfood, P2 = important for later, P3 = we'll get to it one day). Let's hold off picking what we're working on until we've agreed this is the right list. -- Mike Pinkerton Mac Weenie pinker...@google.com --~

[chromium-dev] Mac Dogfood Planning

2009-03-02 Thread Mike Pinkerton
o what the linux folks did, and triage the bugs (P1 = blocking dogfood, P2 = important for later, P3 = we'll get to it one day). Let's hold off picking what we're working on until we've agreed this is the right list. -- Mike Pinkerton Mac Weenie pinker...@google.com --~

[chromium-dev] Re: Mac chrome from the tree

2009-02-25 Thread Mike Pinkerton
ree can now > render http://dev.chromium.org without crashing. > MacChromeTastic! > jrg > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, chan

[chromium-dev] Re: Google Chrome's Most visited page is inferior to Apple Safari 4 (beta) Top Sites page

2009-02-25 Thread Mike Pinkerton
BAD > PLEASE TO BE FIX THIS NOW I CANOT TELL ALL MY FREIND TO SWITCH FROM FOXFIRE > PK > > > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View arch

[chromium-dev] Mac/Linux & blank tabs (or "don't panic!")

2009-02-25 Thread Mike Pinkerton
7;t want anyone to freak out and think rendering was broken. If you type a page into the url bar, everything is still fully functional. -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googleg

  1   2   >