Quoting Tvrtko Ursulin (2018-02-08 07:04:37)
> From: Tvrtko Ursulin
>
> We can implement limited RC6 counter wrap-around protection under the
> assumption that clients will be reading this value more frequently than
> the wrap period on a given platform.
>
> With the typical wrap-around period b
From: Tvrtko Ursulin
We can implement limited RC6 counter wrap-around protection under the
assumption that clients will be reading this value more frequently than
the wrap period on a given platform.
With the typical wrap-around period being ~90 minutes, even with the
exception of Baytrail which
== Series Details ==
Series: drm/i915: add schedule out notification of completed request during
unwind
URL : https://patchwork.freedesktop.org/series/37860/
State : success
== Summary ==
Warning: bzip CI_DRM_3739/shard-glkb6/results17.json.bz2 wasn't in correct JSON
format
Test kms_sysfs_ed
-Original Message-
From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
Sent: Thursday, February 8, 2018 3:37 PM
To: Li, Weinan Z ; intel-gfx@lists.freedesktop.org
Cc: intel-gvt-...@lists.freedesktop.org; Li, Weinan Z ;
Zhenyu Wang
Subject: Re: [PATCH] drm/i915: add schedule out notifica
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Mahesh Kumar
DDB allocation optimization algorithm requires/assumes ddb allocation for
any memory C-state level DDB value to be as high as level below.
this line / statement can be more clear, "DDB value to be as high as
leve
== Series Details ==
Series: drm/i915/cnl: Sync PCI ID with Spec.
URL : https://patchwork.freedesktop.org/series/37873/
State : success
== Summary ==
Series 37873v1 drm/i915/cnl: Sync PCI ID with Spec.
https://patchwork.freedesktop.org/api/1.0/series/37873/revisions/1/mbox/
Test debugfs_test:
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Mahesh Kumar
Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A)
Hardware sometimes fails to wake memory from pkg C states fetching the
last few lines of planar YUV 420 (NV12) planes. This causes
intermittent underflow a
Quoting Chris Wilson (2018-02-07 15:13:50)
> Reduce the window of opportunity for set-wedged being called
> concurrently with reset (after i915_reset() has performed the
> i915_gem_unset_wedged()) by moving the set_bit(I915_WEDGED) to before we
> complete the inflight requests. When i915_reset() is
Hi,
On 2/8/2018 2:01 PM, Sharma, Shashank wrote:
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Mahesh Kumar
Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A)
Hardware sometimes fails to wake memory from pkg C states fetching the
last few lines of planar YUV 420
== Series Details ==
Series: drm/i915: Improve PSR activation timing (rev2)
URL : https://patchwork.freedesktop.org/series/37693/
State : warning
== Summary ==
Series 37693v2 drm/i915: Improve PSR activation timing
https://patchwork.freedesktop.org/api/1.0/series/37693/revisions/2/mbox/
Test
On 08/02/2018 08:00, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-02-08 07:04:37)
From: Tvrtko Ursulin
We can implement limited RC6 counter wrap-around protection under the
assumption that clients will be reading this value more frequently than
the wrap period on a given platform.
With t
Userspace provides a 64b value for the priority, we need to be careful
to preserve the full range before validation to prevent truncation (and
letting an illegal value pass).
Reported-by: Antonio Argenziano
Fixes: ac14fbd460d0 ("drm/i915/scheduler: Support user-defined priorities")
Signed-off-by:
References: https://bugs.freedesktop.org/show_bug.cgi?id=104975
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_sprite.c | 16
Quoting Tvrtko Ursulin (2018-02-08 08:50:58)
>
> On 08/02/2018 08:00, Chris Wilson wrote:
> > The other part of the puzzle was perhaps just using a timer to read the
> > registers every 1/2 wrap period, but there was no clear picture on when
> > to start and stop that timer for sysfs. However, wit
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Chandra Konduru
This patch sets appropriate scaler mode for NV12 format.
In this mode, skylake scaler does either chroma-upsampling or
chroma-upsampling and resolution scaling
v2: Review comments from Ville addressed
NV12 cas
Quoting Maarten Lankhorst (2018-02-08 08:55:38)
> References: https://bugs.freedesktop.org/show_bug.cgi?id=104975
> Signed-off-by: Maarten Lankhorst
> ---
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 707406d1bf57..81087722bc49 100644
> --- a
== Series Details ==
Series: drm/i915: Handle RC6 counter wrap (rev3)
URL : https://patchwork.freedesktop.org/series/37824/
State : success
== Summary ==
Series 37824v3 drm/i915: Handle RC6 counter wrap
https://patchwork.freedesktop.org/api/1.0/series/37824/revisions/3/mbox/
Test debugfs_test
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Chandra Konduru
This patch adds NV12 to format_is_yuv() function
for sprite planes.
v2:
-Use intel_ prefix for format_is_yuv (Ville)
v3: Rebased (me)
v4: Rebased and addressed review comments from Clinton A Taylor.
"static
== Series Details ==
Series: drm/i915: Avoid truncation before clamping userspace's priority value
URL : https://patchwork.freedesktop.org/series/37878/
State : success
== Summary ==
Series 37878v1 drm/i915: Avoid truncation before clamping userspace's priority
value
https://patchwork.freedes
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Chandra Konduru
This patch updates scaler max limit support for NV12
v2: Rebased (me)
v3: Rebased (me)
v4: Missed the Tested-by/Reviewed-by in the previous series
Adding the same to commit message in this version.
v5: Addr
== Series Details ==
Series: drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for GEN9+.
URL : https://patchwork.freedesktop.org/series/37879/
State : success
== Summary ==
Series 37879v1 drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for
GEN9+.
https://patchwork.freedeskt
drivers/gpu/drm/i915/i915_oa_cnl.c: In function
‘i915_perf_load_test_config_cnl’:
drivers/gpu/drm/i915/i915_oa_cnl.c:99:2: error: ‘strncpy’ output truncated
before terminating nul copying 36 bytes from a string of the same length
[-Werror=stringop-truncation]
Fixes: 95690a02fb5d ("drm/i915/perf
drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function
‘i915_perf_load_test_config_cflgt3’:
drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated
before terminating nul copying 36 bytes from a string of the same length
[-Werror=stringop-truncation]
Fixes: 4407eaa9b0cc ("drm/
Arg... I don't know how this happened.
I thought we agreed upon using strlcpy()?
On 08/02/18 10:09, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function
‘i915_perf_load_test_config_cflgt3’:
drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated
before t
Quoting Lionel Landwerlin (2018-02-08 10:18:05)
> Arg... I don't know how this happened.
> I thought we agreed upon using strlcpy()?
The others are using sizeof() + strlcpy. I missed the strlcpy
difference.
char uuid[sizeof(test_config.uuid)] = "...";
memcpy(test_config.uuid, uuid, sizeof(uuid));
drivers/gpu/drm/i915/i915_oa_cnl.c: In function
‘i915_perf_load_test_config_cnl’:
drivers/gpu/drm/i915/i915_oa_cnl.c:99:2: error: ‘strncpy’ output truncated
before terminating nul copying 36 bytes from a string of the same length
[-Werror=stringop-truncation]
v2: strlcpy
Fixes: 95690a02fb5d ("
drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function
‘i915_perf_load_test_config_cflgt3’:
drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated
before terminating nul copying 36 bytes from a string of the same length
[-Werror=stringop-truncation]
v2: strlcpy
Fixes: 4407ea
On 08/02/18 10:24, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_oa_cflgt3.c: In function
‘i915_perf_load_test_config_cflgt3’:
drivers/gpu/drm/i915/i915_oa_cflgt3.c:87:2: error: ‘strncpy’ output truncated
before terminating nul copying 36 bytes from a string of the same length
[-Werror=stringo
On 08/02/18 10:24, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_oa_cnl.c: In function
‘i915_perf_load_test_config_cnl’:
drivers/gpu/drm/i915/i915_oa_cnl.c:99:2: error: ‘strncpy’ output truncated
before terminating nul copying 36 bytes from a string of the same length
[-Werror=stringop-truncat
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Chandra Konduru
This patch adds NV12 to list of supported formats for
primary plane
v2: Rebased (Chandra Konduru)
v3: Rebased (me)
v4: Review comments by Ville addressed
Removed the skl_primary_formats_with_nv12 and
added N
== Series Details ==
Series: series starting with [1/2] drm/i915/perf: Fix compiler warning for
string truncation
URL : https://patchwork.freedesktop.org/series/37890/
State : failure
== Summary ==
Series 37890v1 series starting with [1/2] drm/i915/perf: Fix compiler warning
for string trunc
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Chandra Konduru
This patch adds NV12 to list of supported formats for sprite plane.
v2: Rebased (me)
v3: Review comments by Ville addressed
- Removed skl_plane_formats_with_nv12 and added
NV12 case in existing skl_plane_form
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
From: Chandra Konduru
This patch adds NV12 as supported format
to intel_framebuffer_init and performs various checks.
v2:
-Fix an issue in checks added (Chandra Konduru)
v3: rebased (me)
v4: Review comments by Ville addressed
Add
drivers/gpu/drm/i915/i915_syncmap.c:92: warning: No description found for
parameter 'root'
drivers/gpu/drm/i915/i915_syncmap.c:155: warning: No description found for
parameter 'root'
drivers/gpu/drm/i915/i915_syncmap.c:155: warning: No description found for
parameter 'id'
drivers/gpu/drm/i915/i9
drivers/gpu/drm/i915/i915_drv.c:891: warning: No description found for
parameter 'ent'
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 143b9d5438d2..cd57f9
== Series Details ==
Series: series starting with [v2] drm/i915: Be paranoid and post the writes to
stop the rings (rev4)
URL : https://patchwork.freedesktop.org/series/37801/
State : failure
== Summary ==
Warning: bzip CI_DRM_3739/shard-glkb6/results17.json.bz2 wasn't in correct JSON
format
On Wed, Feb 07, 2018 at 03:13:36PM +, Chris Wilson wrote:
> Since we depending upon the runtime powermanagement to providing timing
> information in lieu of HW counters when the device is asleep, we can
> only provide the rc6 PMU event when CONFIG_PM is enabled.
>
> Fixes: 1fe699e30113 ("drm/i
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/perf: Fix compiler warning for
string truncation
URL : https://patchwork.freedesktop.org/series/37892/
State : success
== Summary ==
Series 37892v1 series starting with [v2,1/2] drm/i915/perf: Fix compiler
warning for string
drivers/gpu/drm/i915/i915_gpu_error.c:1815: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i915_gpu_error.c:1815: warning: No description found for
parameter 'engine_mask'
drivers/gpu/drm/i915/i915_gpu_error.c:1815: warning: No description found for
parameter 'error_
drivers/gpu/drm/i915/intel_ringbuffer.c:179: warning: No description found for
parameter 'req'
drivers/gpu/drm/i915/intel_ringbuffer.c:741: warning: No description found for
parameter 'req'
drivers/gpu/drm/i915/intel_ringbuffer.c:741: warning: No description found for
parameter 'cs'
Signed-off-
drivers/gpu/drm/i915/i915_gem_userptr.c:761: warning: No description found for
parameter 'dev'
drivers/gpu/drm/i915/i915_gem_userptr.c:761: warning: No description found for
parameter 'data'
drivers/gpu/drm/i915/i915_gem_userptr.c:761: warning: No description found for
parameter 'file'
Signed-o
drivers/gpu/drm/i915/i915_gem_request.c:941: warning: No description found for
parameter 'write'
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_request.c
b/drivers/gpu/drm
The comment is very old and quite misleading now.
drivers/gpu/drm/i915/i915_gem_context.c:349: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i915_gem_context.c:349: warning: No description found for
parameter 'file_priv'
Signed-off-by: Chris Wilson
---
drivers/gp
Quoting Patchwork (2018-02-08 11:05:25)
> == Series Details ==
>
> Series: series starting with [v2,1/2] drm/i915/perf: Fix compiler warning for
> string truncation
> URL : https://patchwork.freedesktop.org/series/37892/
> State : success
>
> == Summary ==
>
> Series 37892v1 series starting w
FORCEWAKE_ACK is depricated by BSpec at least starting from BDW,
referring to the multi-threaded version of it instead. Accessing
FORCEWAKE_ACK triggers an unclaimed register access error - at
least on GLK - see the Reference: below.
The correct registers to use would be FORCEWAKE_MT_ACK on IVB+ a
== Series Details ==
Series: series starting with [1/2] drm/i915: Add missing kerneldoc for 'ent' in
i915_driver_init_early
URL : https://patchwork.freedesktop.org/series/37893/
State : success
== Summary ==
Series 37893v1 series starting with [1/2] drm/i915: Add missing kerneldoc for
'ent'
On Tue, Feb 06, 2018 at 02:31:37PM +, Chris Wilson wrote:
> We only need to wake up the RPS worker once when initially enabling the
> client boost, it remains in effect then until the last client no longer
> requires the boost.
Reviewed-by: Michał Winiarski
-Michał
>
> References: https://
Quoting Imre Deak (2018-02-08 11:23:31)
> FORCEWAKE_ACK is depricated by BSpec at least starting from BDW,
> referring to the multi-threaded version of it instead. Accessing
> FORCEWAKE_ACK triggers an unclaimed register access error - at
> least on GLK - see the Reference: below.
>
> The correct
Quoting Michał Winiarski (2018-02-08 11:24:46)
> On Tue, Feb 06, 2018 at 02:31:37PM +, Chris Wilson wrote:
> > We only need to wake up the RPS worker once when initially enabling the
> > client boost, it remains in effect then until the last client no longer
> > requires the boost.
>
> Reviewe
Quoting Chris Wilson (2018-02-08 10:39:05)
> Quoting Chris Wilson (2018-02-07 15:13:50)
> > Reduce the window of opportunity for set-wedged being called
> > concurrently with reset (after i915_reset() has performed the
> > i915_gem_unset_wedged()) by moving the set_bit(I915_WEDGED) to before we
> >
Quoting Joonas Lahtinen (2018-02-08 11:25:38)
> Quoting Chris Wilson (2018-02-08 10:51:51)
> > Userspace provides a 64b value for the priority, we need to be careful
> > to preserve the full range before validation to prevent truncation (and
> > letting an illegal value pass).
> >
> > Reported-by:
Quoting Chris Wilson (2018-02-08 10:51:51)
> Userspace provides a 64b value for the priority, we need to be careful
> to preserve the full range before validation to prevent truncation (and
> letting an illegal value pass).
>
> Reported-by: Antonio Argenziano
> Fixes: ac14fbd460d0 ("drm/i915/sche
Chris Wilson writes:
> Reduce the window of opportunity for set-wedged being called
> concurrently with reset (after i915_reset() has performed the
> i915_gem_unset_wedged()) by moving the set_bit(I915_WEDGED) to before we
> complete the inflight requests. When i915_reset() is being blocked on a
drivers/gpu/drm/i915/i915_gem_execbuffer.c:1983: warning: No description found
for parameter 'dev_priv'
drivers/gpu/drm/i915/i915_gem_execbuffer.c:1983: warning: No description found
for parameter 'file'
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
1 file
Chris Wilson writes:
> Although the mmio are uncached and so should be flushed on every write,
> be paranoid and do a mmio read after setting the ring head/tail to be
> sure they have taken effect before moving on.
>
> v2: post tail to be pleasing to the eye
>
> Signed-off-by: Chris Wilson
> Cc:
drivers/gpu/drm/i915/i915_gem_internal.c:183: warning: No description found for
parameter 'i915'
drivers/gpu/drm/i915/i915_gem_internal.c:183: warning: No description found for
parameter 'size'
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_internal.c | 4
1 file changed, 4
Chris Wilson writes:
> After we assert the reset request (and wait for 20us), when the device
> has been fully reset it asserts the reset-status bit. Before we stop
> requesting the reset and allow the device to return to normal, we should
> wait for the reset to be completed. (Similar to how we
Quoting Mika Kuoppala (2018-02-08 11:35:09)
> Chris Wilson writes:
>
> > Reduce the window of opportunity for set-wedged being called
> > concurrently with reset (after i915_reset() has performed the
> > i915_gem_unset_wedged()) by moving the set_bit(I915_WEDGED) to before we
> > complete the inf
Quoting Mika Kuoppala (2018-02-08 11:43:50)
> Any thoughts of starting to log the reset attempts
> with timeout, even if the subsequent reset succeeds?
If it succeeds, do we care? Capturing why it fails, sure.
The question being what do we want to gain from it? Faster reset by
removing timeout lo
== Series Details ==
Series: drm/i915/cnl: Sync PCI ID with Spec.
URL : https://patchwork.freedesktop.org/series/37873/
State : warning
== Summary ==
Test drv_suspend:
Subgroup fence-restore-untiled:
pass -> DMESG-WARN (shard-snb)
Test kms_vblank:
Subgroup
Regards
Shashank
On 2/6/2018 6:28 PM, Vidya Srinivas wrote:
If the fb format is YUV, enable the plane CSC mode bits
for the conversion.
Signed-off-by: Vidya Srinivas
---
drivers/gpu/drm/i915/i915_reg.h | 6 ++
drivers/gpu/drm/i915/intel_display.c | 2 ++
2 files changed, 8 inser
== Series Details ==
Series: drm/i915: Fix kerneldoc warnings for i915_gpu_error
URL : https://patchwork.freedesktop.org/series/37895/
State : warning
== Summary ==
Series 37895v1 drm/i915: Fix kerneldoc warnings for i915_gpu_error
https://patchwork.freedesktop.org/api/1.0/series/37895/revisio
Collecting CRC may result in a modeset and extra vblank waits. On some
tests this will increase the runtime a lot, so it makes sense to
keep it enabled, and only collect the most recent CRC when needed.
Changes since v1:
- Fix read_crc semantics. (Ville)
Changes since v2:
- Remove EAGAIN assert, c
Chris Wilson writes:
> Quoting Mika Kuoppala (2018-02-08 11:43:50)
>> Any thoughts of starting to log the reset attempts
>> with timeout, even if the subsequent reset succeeds?
>
> If it succeeds, do we care? Capturing why it fails, sure.
>
> The question being what do we want to gain from it? Fa
Regards
Shashank
On 2/6/2018 4:36 PM, Vidya Srinivas wrote:
From: Chandra Konduru
Display WA #0827:
Switching the plane format from NV12 to RGB and leaving system idle results
in display underrun and corruption. WA: Set the bit 15 & bit 19 to 1b
in the CLKGATE_DIS_PSL register for the pipe i
== Series Details ==
Series: drm/i915: Fix kerneldoc warnings for intel_ringbuffer
URL : https://patchwork.freedesktop.org/series/37896/
State : success
== Summary ==
Series 37896v1 drm/i915: Fix kerneldoc warnings for intel_ringbuffer
https://patchwork.freedesktop.org/api/1.0/series/37896/rev
== Series Details ==
Series: drm/i915: Handle RC6 counter wrap (rev3)
URL : https://patchwork.freedesktop.org/series/37824/
State : success
== Summary ==
Test kms_cursor_legacy:
Subgroup cursor-vs-flip-legacy:
pass -> FAIL (shard-apl) fdo#103355
Test gem_eio
Regards
Shashank
On 2/6/2018 4:36 PM, Vidya Srinivas wrote:
Signed-off-by: Vidya Srinivas
No need for any commit message :P ?
---
drivers/gpu/drm/i915/intel_atomic.c | 5 ++---
drivers/gpu/drm/i915/intel_display.c | 7 ++-
drivers/gpu/drm/i915/intel_sprite.c | 4
3 files cha
From: Tvrtko Ursulin
For Joonas basically. :)
Rough goal - add Kconfig options to turn off supported platforms and count on
compiler DCE to make the driver smaller.
Tested as so much that it boots and renders on Skylake with all platforms/gens
older than Gen8 turned off.
textdata bs
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig | 5 +
drivers/gpu/drm/i915/Kconfig.platforms | 6 ++
drivers/gpu/drm/i915/i915_drv.h| 5 -
drivers/gpu/drm/i915/i915_pci.c| 4
4 files changed, 19 insertions(+), 1 del
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 51 ++
drivers/gpu/drm/i915/i915_drv.h| 22 +--
drivers/gpu/drm/i915/i915_pci.c| 28 +--
3 files changed, 90 insertions(+),
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 7 +++
drivers/gpu/drm/i915/i915_drv.h| 2 +-
drivers/gpu/drm/i915/i915_pci.c| 4
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 7 +++
drivers/gpu/drm/i915/i915_drv.h| 2 +-
drivers/gpu/drm/i915/i915_pci.c| 4
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.
From: Tvrtko Ursulin
By adding a hidden Kconfig option selected by all Gen2 platforms, we can
eliminate more code when none of those is selected.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 7 +++
drivers/gpu/drm/i915/i915_drv.h| 4 +++-
2 files chang
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 35 ++
drivers/gpu/drm/i915/i915_drv.h| 12 +++-
drivers/gpu/drm/i915/i915_pci.c| 16
3 files changed, 58 insertions(+), 5 del
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 7 +++
drivers/gpu/drm/i915/i915_drv.h| 2 +-
drivers/gpu/drm/i915/i915_pci.c| 4
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 12
drivers/gpu/drm/i915/i915_drv.h| 4 +++-
drivers/gpu/drm/i915/i915_pci.c| 6 ++
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i
== Series Details ==
Series: drm/i915: Fix kerneldoc warnings for i915_gem_userptr
URL : https://patchwork.freedesktop.org/series/37897/
State : success
== Summary ==
Series 37897v1 drm/i915: Fix kerneldoc warnings for i915_gem_userptr
https://patchwork.freedesktop.org/api/1.0/series/37897/rev
From: Tvrtko Ursulin
Replace INTEL_GEN equals with IS_GENx for more optimisation opportunities.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_device_info.c | 4 ++--
drivers/gpu/drm/i915/intel_fbc.c | 2 +-
drivers/gpu/drm/i915/intel_ringbuffer.h | 4 ++--
3 files chang
From: Tvrtko Ursulin
Coccinelle patch:
@@
identifier p;
@@
-INTEL_INFO(p)->gen
+INTEL_GEN(p)
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gem.c | 4 ++--
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +-
drivers/gpu/
From: Tvrtko Ursulin
Instead of INTEL_GEN != x use !IS_GENx for more optimisation
opportunities.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_pm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/in
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 11 +++
drivers/gpu/drm/i915/i915_drv.h| 7 +--
drivers/gpu/drm/i915/i915_pci.c| 4
3 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig.platforms | 26 ++
drivers/gpu/drm/i915/i915_drv.h| 10 ++
drivers/gpu/drm/i915/i915_pci.c| 14 ++
3 files changed, 46 insertions(+), 4 deletions(-)
d
From: Tvrtko Ursulin
Add IS_GEN_GT(E) and IS_GEN_LT(E) helpers.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 49 +
1 file changed, 49 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
ind
I'm not super familiar with all the documentation stuff, but this looks
good to me.
Reviewed-by: Lionel Landwerlin
On 08/02/18 11:11, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_gpu_error.c:1815: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i915_gpu_error.c:1
On 08/02/18 11:13, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_gem_userptr.c:761: warning: No description found for
parameter 'dev'
drivers/gpu/drm/i915/i915_gem_userptr.c:761: warning: No description found for
parameter 'data'
drivers/gpu/drm/i915/i915_gem_userptr.c:761: warning: No descript
On 08/02/18 11:12, Chris Wilson wrote:
drivers/gpu/drm/i915/intel_ringbuffer.c:179: warning: No description found for
parameter 'req'
drivers/gpu/drm/i915/intel_ringbuffer.c:741: warning: No description found for
parameter 'req'
drivers/gpu/drm/i915/intel_ringbuffer.c:741: warning: No descripti
On 08/02/18 11:15, Chris Wilson wrote:
The comment is very old and quite misleading now.
drivers/gpu/drm/i915/i915_gem_context.c:349: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i915_gem_context.c:349: warning: No description found for
parameter 'file_priv'
Sig
Quoting Tvrtko Ursulin (2018-02-08 13:05:52)
> From: Tvrtko Ursulin
>
> Signed-off-by: Tvrtko Ursulin
> ---
> drivers/gpu/drm/i915/Kconfig | 5 +
> drivers/gpu/drm/i915/Kconfig.platforms | 6 ++
> drivers/gpu/drm/i915/i915_drv.h| 5 -
> drivers/gpu/drm/i915/i915_pc
On 08/02/18 11:14, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_gem_request.c:941: warning: No description found for
parameter 'write'
Signed-off-by: Chris Wilson
Reviewed-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_gem_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
== Series Details ==
Series: drm/i915: Fix kerneldoc warnings for i915_gem_request
URL : https://patchwork.freedesktop.org/series/37898/
State : success
== Summary ==
Series 37898v1 drm/i915: Fix kerneldoc warnings for i915_gem_request
https://patchwork.freedesktop.org/api/1.0/series/37898/rev
Quoting Tvrtko Ursulin (2018-02-08 13:05:51)
> From: Tvrtko Ursulin
>
> For Joonas basically. :)
>
> Rough goal - add Kconfig options to turn off supported platforms and count on
> compiler DCE to make the driver smaller.
>
> Tested as so much that it boots and renders on Skylake with all platf
Em Ter, 2018-02-06 às 19:54 +, Patchwork escreveu:
> == Series Details ==
>
> Series: ICL display initialization, selected patches (rev3)
> URL : https://patchwork.freedesktop.org/series/37668/
> State : warning
>
> == Summary ==
>
> Series 37668v3 ICL display initialization, selected patc
== Series Details ==
Series: drm/i915: Remove lost comment from i915_gem_context
URL : https://patchwork.freedesktop.org/series/37900/
State : success
== Summary ==
Series 37900v1 drm/i915: Remove lost comment from i915_gem_context
https://patchwork.freedesktop.org/api/1.0/series/37900/revisio
Quoting Mika Kuoppala (2018-02-08 12:34:08)
> Chris Wilson writes:
>
> > Quoting Mika Kuoppala (2018-02-08 11:43:50)
> >> Any thoughts of starting to log the reset attempts
> >> with timeout, even if the subsequent reset succeeds?
> >
> > If it succeeds, do we care? Capturing why it fails, sure.
Quoting Mika Kuoppala (2018-02-08 11:43:50)
> Chris Wilson writes:
>
> > After we assert the reset request (and wait for 20us), when the device
> > has been fully reset it asserts the reset-status bit. Before we stop
> > requesting the reset and allow the device to return to normal, we should
> >
== Series Details ==
Series: drm/i915: Use DOUBLE_BUFFER_CTL instead of vblank evasion for GEN9+.
URL : https://patchwork.freedesktop.org/series/37879/
State : success
== Summary ==
Test gem_exec_suspend:
Subgroup basic-s4:
fail -> SKIP (shard-hsw) fdo#10337
== Series Details ==
Series: drm/i915/snb+: Remove incorrect forcewake check in
debugfs/i915_drpc_info
URL : https://patchwork.freedesktop.org/series/37901/
State : success
== Summary ==
Series 37901v1 drm/i915/snb+: Remove incorrect forcewake check in
debugfs/i915_drpc_info
https://patchwor
On Thu, Feb 08, 2018 at 08:18:42AM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> We can implement limited RC6 counter wrap-around protection under the
> assumption that clients will be reading this value more frequently than
> the wrap period on a given platform.
>
> With the typical w
On 08/02/2018 13:26, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-02-08 13:05:51)
From: Tvrtko Ursulin
For Joonas basically. :)
Rough goal - add Kconfig options to turn off supported platforms and count on
compiler DCE to make the driver smaller.
Tested as so much that it boots and rend
1 - 100 of 192 matches
Mail list logo
