---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47869/#review135245
---
Ship it!
Ship It!
- Joshua Cohen
On May 26, 2016, 8:57 p.m
ev list and
they're open to the idea of adding a subcommand to mesos-containerizer that
would be responsible for isolating a task's filesystem.
We hope to work on and contribute this patch next week during Mesoscon.
Given that, I'm going to hold off on this rev
lt;https://reviews.apache.org/r/48082/#comment201087>
Should fit on one line?
- Joshua Cohen
On May 31, 2016, 7:02 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48216/#review136096
---
Ship it!
Ship It!
- Joshua Cohen
On June 3, 2016, 6:30 p.m
)
<https://reviews.apache.org/r/48218/#comment201106>
Might be worth mentioning the other log levels for mesos? Problems are
often found in the WARN logs, right?
- Joshua Cohen
On June 3, 2016, 7:20 p.m., Stephan Erb
t line.
src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java
(lines 384 - 385)
<https://reviews.apache.org/r/48082/#comment201371>
extract `entry.getValue()` to a var.
- Joshua Cohen
On June 6, 2016, 7:
ine 69)
<https://reviews.apache.org/r/47998/#comment201576>
s/global//
- Joshua Cohen
On June 6, 2016, 11:22 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
ormation/information
docs/operations/configuration.md (line 218)
<https://reviews.apache.org/r/48360/#comment201626>
move this up to the previous line?
- Joshua Cohen
On June 7, 2016, 9 p.m., Renan DelValle wrote:
>
> ---
> This
e 200)
<https://reviews.apache.org/r/48360/#comment201734>
Can you surround this block with ``` so it's rendered as code?
- Joshua Cohen
On June 7, 2016, 11:26 p.m., Renan DelValle wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48360/#review136665
---
Ship it!
Ship It!
- Joshua Cohen
On June 8, 2016, 5:29 p.m
https://reviews.apache.org/r/48492/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests.
Thanks,
Joshua Cohen
ommon/sandbox.py
be1deba6219462c9fdaaf07a583851b85fe974bf
src/test/python/apache/aurora/executor/common/test_sandbox.py
e47d9b8822deb36cb9cfa0554ef89d6cda80f3e9
Diff: https://reviews.apache.org/r/48492/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests.
Thanks,
Joshua Cohen
ommon/sandbox.py
be1deba6219462c9fdaaf07a583851b85fe974bf
src/test/python/apache/aurora/executor/common/test_sandbox.py
e47d9b8822deb36cb9cfa0554ef89d6cda80f3e9
Diff: https://reviews.apache.org/r/48492/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests.
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48492/#review136824
---
@ReviewBot retry
- Joshua Cohen
On June 9, 2016, 3:55 p.m
serts more
explict. E.g. `test_get_config_production_and_tier_unset_is_preemptible` and
`test_get_config_production_set_is_preferred`, etc.?
- Joshua Cohen
On June 23, 2016, 10:35 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
views.apache.org/r/49218/#comment204658>
This should be `u_id` not `m_id`.
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
(lines 408 - 411)
<https://reviews.apache.org/r/49218/#comment204659>
Indent 2
- Joshua Cohen
On June 24, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139923
---
Ship it!
- Joshua Cohen
On June 28, 2016, 11:57 p.m
/#comment205265>
It's hard to tell from looking at the review, do we have the inverse of
this scenario covered as well (i.e. mesos fetcher is disabled and task config
has no mesos fetcher uris set)? If not, would you mind adding coverage for that?
- Joshua Cohen
On June 28, 2016, 9:
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140006
---
@ReviewBot retry
- Joshua Cohen
On June 29, 2016, 4:33 p.m
oshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140007
-------
On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49384/#review140012
---
@ReviewBot retry
- Joshua Cohen
On June 29, 2016, 4:33 p.m
o reply, visit:
https://reviews.apache.org/r/49384/#review140022
---
On June 29, 2016, 4:33 p.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49478/#review140289
---
Ship it!
Ship It!
- Joshua Cohen
On June 30, 2016, 11:29
> On July 7, 2016, 2:33 a.m., John Sirois wrote:
> > I am slightly worried the tests only seem to work after this change ...
> > IIUC Aurora 0.15.0 should work with mesos 0.27.2 (Aurora should work with
> > the mesos its developed against +/- 1).
>
> John Sirois wrote:
> Oh, now I understa
depends on what we change in Aurora
> to bump up the Mesos version. In 0.15.0, we upgraded Mesos to 0.28.2 that
> required us to treat the new Mesos task state (KILLING). This means 0.15.0
> cannot rely on 0.27.2 anymore and >= 0.28.2 seems the only logical constraint
> there.
&
> On June 29, 2016, 3:39 a.m., Joshua Cohen wrote:
> >
>
> Mehrdad Nurolahzade wrote:
> Should this be merged with upstream now that 0.15 is released?
Yes, we can land this now. Would you mind rebasing? Then I can com
This is why I haven't commented on the review as well. I'm close to
updating my patch to take advantage of some upstream changes to Mesos that
allows us to rely on their logic for isolating a filesystem (
https://reviews.apache.org/r/49569/), hopefully will have something out by
EOW. That said, it
`
function returns)
- Joshua Cohen
On July 14, 2016, 11:08 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
o I'm ok with shipping this.
If others feel strongly that they're problematic then we can investigate a
custom jackson serializer to clean them up.
- Joshua Cohen
On July 20, 2016, 4:26 p.m., Mehrdad Nurolahzade wrote:
>
> ---
c/main/python/apache/aurora/client/cli/update.py#L61-L76
src/main/python/apache/aurora/client/cli/update.py (line 332)
<https://reviews.apache.org/r/50168/#comment208800>
Maybe something like "Rollback the latest in-progress or co
matically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> ---
>
> (Updated July 20, 2016, 5:56 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Bugs: AURORA-1710
> https://issues.apache.org/jira/bro
(line 20)
<https://reviews.apache.org/r/49048/#comment209161>
Given that tier names are configurable by Aurora operators, should we word
this differently?
- Joshua Cohen
On July 25, 2016, 3:30 p.m., Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review143388
---
@ReviewBot retry
- Joshua Cohen
On July 25, 2016, 3:30 p.m
> On July 25, 2016, 3:55 p.m., Joshua Cohen wrote:
> > RELEASE-NOTES.md, line 20
> > <https://reviews.apache.org/r/49048/diff/7-8/?file=1440195#file1440195line20>
> >
> > Given that tier names are configurable by Aurora operators, should we
> &
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review143393
---
Ship it!
Ship It!
- Joshua Cohen
On July 25, 2016, 4:25 p.m
this up with a
test case if possible?
- Joshua Cohen
On July 26, 2016, 2:36 a.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On July 26, 2016, 2:36 p.m., Joshua Cohen wrote:
> > I know this is already landed, but it would be nice to follow this up with
> > a test case if possible?
>
> Mehrdad Nurolahzade wrote:
> The logic has two test cases:
> (https://gi
up a much slimmer filesystem image that explicitly does not include python
to ensure that the executor's filesystem is truly isolated.
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50478/#review143663
---
Ship it!
Ship It!
- Joshua Cohen
On July 27, 2016, 1:25 a.m
executor config exists here? The previous branch
is checking if executorConfig is set and that the config exists, but won't we
fall into this branch if executorConfig is not set?
- Joshua Cohen
On July 27, 2016, 2:04 a.m., Renan DelValle wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50530/#review143793
---
Ship it!
Ship It!
- Joshua Cohen
On July 27, 2016, 7:32 p.m
://reviews.apache.org/r/50584/diff/
Testing
---
./build-support/jenkins/build.sh
ran e2e tests.
Thanks,
Joshua Cohen
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50584/#review144164
-------
On July 28, 2016, 9:18 p.m., Joshua Cohen wrote:
>
> ---
> Th
tps://reviews.apache.org/r/50432/#comment210196>
Isn't this undoing the bug fix to compare w/ `Empty` instead of `None`?
- Joshua Cohen
On July 29, 2016, 9 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50617/#review144223
---
Ship it!
Ship It!
- Joshua Cohen
On July 29, 2016, 10:46
96e99
src/test/sh/org/apache/aurora/e2e/Dockerfile
6fdea3d28760f59235c51c5b6913d2ee0172ef1a
Diff: https://reviews.apache.org/r/50584/diff/
Testing
---
./build-support/jenkins/build.sh
ran e2e tests.
Thanks,
Joshua Cohen
ot include python
to ensure that the executor's filesystem is truly isolated.
Thanks,
Joshua Cohen
/ubuntu-trusty/provision.sh 8105f6ec122f29db8cb039957a79a8c2b758066f
test/rpm/centos-7/provision.sh ae1fe693131bebaee0818c61ab022ad3cc244075
Diff: https://reviews.apache.org/r/50669/diff/
Testing
---
Built local packages for ubuntu, debian and centos.
Thanks,
Joshua Cohen
pache.org/r/50685/#comment210463>
This could use HTTP 415?
- Joshua Cohen
On Aug. 2, 2016, 1:29 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
ts up a much slimmer filesystem image that explicitly does not include python
to ensure that the executor's filesystem is truly isolated.
Thanks,
Joshua Cohen
nother appropriate
> > place) if we are supposed to use a filesystem image without a containerizer
> > path.
Added some code to fail fast if task is using an image but path to
mesos-containerizer is not provided.
- Joshua
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50716/#review144529
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 2, 2016, 9:13 p.m
e for the response
type to be dictated by the `Content-Type` of the request. We should probably
use the `Accept` header instead? I don't necessarily know if the use case
exists to send json yet want to receive binary, but it's more idiomatic HTTP to
support that possibility.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50480/#review144578
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 2, 2016, 11:38 p.m
a big change, I'd be ok with shipping it in a follow up review.
- Joshua Cohen
On Aug. 2, 2016, 11:38 p.m., Renan DelValle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
#x27;s filesystem is truly isolated.
Thanks,
Joshua Cohen
> On Aug. 3, 2016, 2:36 a.m., Joshua Cohen wrote:
> > I was about to push this change, but in the process of running e2e tests
> > locally after applying your patch, it occurs to me that perhaps this is
> > something we should have e2e coverage for.
> >
> >
> On Aug. 3, 2016, 2:36 a.m., Joshua Cohen wrote:
> > I was about to push this change, but in the process of running e2e tests
> > locally after applying your patch, it occurs to me that perhaps this is
> > something we should have e2e coverage for.
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50685/#review144685
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 3, 2016, 9:36 p.m
means the
warning about the field being deprecated causes a build failure.
- Joshua Cohen
On Aug. 5, 2016, 12:34 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Aug. 5, 2016, 12:50 a.m., Joshua Cohen wrote:
> > This does not compile. We have -Werror set on our builds which means the
> > warning about the field being deprecated causes a build failure.
If we do want to maintain this across a release boundary for compatibility sake
We should extract sourceName to a var here just like we do in the test.
- Joshua Cohen
On Aug. 5, 2016, 1:05 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
desperately trying to
roll back an update.
We could update `JobUpdateStateMachine` to allow for the transition from
`ROLL_FORWARD_AWAITING_PULSE` to `ROLLING_BACK`.
- Joshua Cohen
On Aug. 3, 2016, 10:16 p.m., Igor Morozov wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50931/#review145300
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 9, 2016, 7:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50937/#review145301
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 9, 2016, 9:57 p.m
me, but I want Maxim to
take another quick pass before shipping, as he expressed concerns about testing
the new transition.
- Joshua Cohen
On Aug. 9, 2016, 10:41 p.m., Igor Morozov wrote:
>
> ---
> This is an automatically ge
/configuration.md
<https://reviews.apache.org/r/51192/#comment212458>
I'd say leave something along these lines this in this file with a link to
the full documentation?
- Joshua Cohen
On Aug. 17, 2016, 10:52 p.m., Renan Del
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51264/#review146364
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 21, 2016, 1:28 a.m
51298/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51301/#review146536
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 22, 2016, 9:05 p.m
rly as
far as bind mounting the sandbox directory into the taskfs.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51298/#review146449
-------
On Aug. 22, 2016, 8:25 p.m., Joshua Cohen wrote:
rg/r/51298/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51307/#review146573
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 23, 2016, 9:12 p.m
think we're exposing ourselves to
anything terrible by doing this.
- Joshua Cohen
On Aug. 23, 2016, 8:45 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51366/#review146658
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 24, 2016, 12:07
apache.org/r/51298/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
ra/e2e/run-server.sh
76939888bed2e8138671d97f7bc56fd5641008e4
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
0404d0e0a1a1054a5ed0c0b9f5f5be9fb3ecc113
Diff: https://reviews.apache.org/r/51298/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
016, 11:21 a.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/common/sandbox.py, line 36
> > <https://reviews.apache.org/r/51298/diff/1-2/?file=1481195#file1481195line36>
> >
> > Please extend this doc string slightly to mention that this
-server.sh
76939888bed2e8138671d97f7bc56fd5641008e4
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
0404d0e0a1a1054a5ed0c0b9f5f5be9fb3ecc113
Diff: https://reviews.apache.org/r/51298/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
style didn't pick this up.
src/test/python/apache/aurora/client/cli/test_supdate.py (line 156)
<https://reviews.apache.org/r/51384/#comment213594>
Looks like there's a lot of lines beyond 100 chars here as well, can you
fix?
We'll have to figure out why checksty
)
<https://reviews.apache.org/r/51438/#comment213602>
Would you mind also fixing this in the actual hello_docker.aurora file
mentioned here?
https://github.com/apache/aurora/blob/master/examples/jobs/docker/hello_docker.aurora
- Joshua Cohen
On Aug. 25, 2016, 8:25 p.m.,
th within the
> > container, but we use it before the pivot root is completed. This is a
> > problem similar to the thermos_profile issue mentioned above.
>
> Joshua Cohen wrote:
> I'm not sure what you're getting at here? The `cwd` arg is passed on to
>
org/apache/aurora/e2e/run-server.sh
76939888bed2e8138671d97f7bc56fd5641008e4
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
0404d0e0a1a1054a5ed0c0b9f5f5be9fb3ecc113
Diff: https://reviews.apache.org/r/51298/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
diff/5/?file=1486012#file1486012line482>
> >
> > We are now sourcing the thermos profile twice: Once within the
> > container image and once on the outside.
> >
> > Probably does no harm.
I've cleaned this up so that we only source it
-server.sh
76939888bed2e8138671d97f7bc56fd5641008e4
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
0404d0e0a1a1054a5ed0c0b9f5f5be9fb3ecc113
Diff: https://reviews.apache.org/r/51298/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51438/#review146999
---
Ship it!
Thanks!
- Joshua Cohen
On Aug. 26, 2016, 6:14 p.m
> On Aug. 29, 2016, 4:39 p.m., John Sirois wrote:
> > I'm taking a look presently. The seperate script call-out should no longer
> > be needed since `./pants test...` implies `./pants compile...` which is all
> > the seperate script does.
>
> John Sirois wrote:
> Aha - yes, the compile de
te:
> Aha - yes, the compile dependency was historically leeched from the jvm
> stack which is now not installed. LGTM.
>
> John Sirois wrote:
> Filed pants issue to fix this:
> https://github.com/pantsbuild/pants/issues/3819
>
> Joshua Cohen wrote:
> I was
of `Metadata` structs?
rather than a set of strings which is what this will currently pass?
- Joshua Cohen
On Aug. 28, 2016, 3:58 a.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> This is an automatically generated e-mail. To repl
vagrant environment.
Thanks,
Joshua Cohen
h/org/apache/aurora/e2e/test_end_to_end.sh
7c32c94edf88d6dc0fbd7f838bea2b8077da0235
Diff: https://reviews.apache.org/r/51502/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
urora/executor/common/test_sandbox.py
2ba3341273efe54d1a79fe48be50d4253530dcbc
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
7c32c94edf88d6dc0fbd7f838bea2b8077da0235
Diff: https://reviews.apache.org/r/51502/diff/
Testing
---
./build-support/jenkins/build.sh
e2e tests
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/#review147208
---
@ReviewBot retry
- Joshua Cohen
On Aug. 29, 2016, 8:28 p.m
> On Aug. 29, 2016, 6:52 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 193
> > <https://reviews.apache.org/r/51384/diff/4/?file=1487511#file1487511line193>
> >
> > Am I missing something? Shouldn't this be a set o
given that the goal here is to
optimize for the case where responses are large enough that sending them on the
wire and processing them on the client side is causing a perf problem)?
At the very least, perhaps we should only buffer the response if the
`If-None-Match` header is set?
- J
> On Aug. 29, 2016, 6:52 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 193
> > <https://reviews.apache.org/r/51384/diff/4/?file=1487511#file1487511line193>
> >
> > Am I missing something? Shouldn't this be a set o
ted e-mail. To reply, visit:
> https://reviews.apache.org/r/51506/
> ---
>
> (Updated Aug. 29, 2016, 11:37 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51531/#review147329
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 30, 2016, 5:45 p.m
> On Aug. 30, 2016, 1:32 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java,
> > lines 139-142
> > <https://reviews.apache.org/r/51513/diff/1/?file=1488357#file1488357line139>
> >
> > Am I readi
1 - 100 of 746 matches
Mail list logo
