Re: [VOTE] Release Apache Roller 6.1.3 based on rc1

[Greg Huber]

Looks great. Database upgrade no problems.

One thing there are alot of these log messages from the war deploy:

DEBUG 2024-06-03 08:51:11 [ajp-nio-127.0.0.1-8009-exec-2] 
UISecurityInterceptor - Entering UISecurityInterceptor


DEBUG 2024-06-03 08:51:11 [ajp-nio-127.0.0.1-8009-exec-2] 
UISecurityInterceptor - action is UISecurityEnforced ... enforcing 
security rules


DEBUG 2024-06-03 08:51:12 [ajp-nio-127.0.0.1-8009-exec-7] 
UISecurityInterceptor - Entering UISecurityInterceptor


DEBUG 2024-06-03 08:51:17 [ajp-nio-127.0.0.1-8009-exec-1] 
UISecurityInterceptor - Entering UISecurityInterceptor


DEBUG 2024-06-03 08:51:17 [ajp-nio-127.0.0.1-8009-exec-1] 
UISecurityInterceptor - action is UISecurityEnforced ... enforcing 
security rules


Is there a de-register page for a user. There is the remove weblog but 
not the actual user registration.


On 02/06/2024 21:17, Dave wrote:

Hi Roller folks,


I propose that we release Roller 6.1.3 based on the release candidate #1
(rc1) files already available.


https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.3/


This new release of Roller will add:

- Input validation/sanitization for Profile full name, name, timezone
and locale fields
- Input sanitization for Bookmark and Bookmark folder name and
description fields
- Fix to embedded Jetty (used in tests and mvn jetty:run)
- Many fixes for various warnings in tests
- Dependency updates:
   - ant
   - asm
   - commons-validator
   - commons-codec
   - commons-text
   - commons-lang3
   - guice
   - log4j2
   - lucene
   - maven-war
   - maven-surefire
   - spring
   - spring-security
   - jquery
   - struts2-bootstrap-plugin
   - mokito-core
   - instancio-junit
   - maven-antrun-plugin
   - selenium-firefox-driver


These PRs capture most if not all of the changes:

https://github.com/apache/roller/pull/135

https://github.com/apache/roller/pull/134

https://github.com/apache/roller/pull/132

https://github.com/apache/roller/pull/131


Please test and review the release files if you have a chance.


Please vote -1 with reasons, 0 or +1 to release.


Thanks!

Dave

Re: Upgrade to latest struts

[Greg Huber]

OK, a lot of white space, although I did not use format (eclipse) so not
sure what happened. (Although there is some strange formatting going on
that will never match any standard formatting, probably done manually).

I will tidy it up, and try again.

Cheers Greg

On Fri, 6 Oct 2023 at 11:42, Michael Bien  wrote:

> Hi Greg,
>
> you could open a PR which will let tests run against it. This produces a
> dev build too for manual testing.
>
> on first glance:
>
> app/tools/roller.xml is probably not intended on the commit
>
> there are also a lot of whitespace changes in the commit. PR diffs can
> filter some of them out, but automated formatting changes in the javadoc
> for example should be avoided to make diffs smaller. Its probably an IDE
> setting somewhere. It is often better to separate cleanup and actual
> changes.
>
> -mbien
>
> On 06.10.23 11:51, Greg Huber wrote:
> > Struts devs have updated the 4.0.x struts2-bootstrap-plugin to work on
> > the latest version of struts
> >
> > dependency>
> > com.jgeppert.struts2.bootstrap
> > struts2-bootstrap-plugin
> > 4.0.2-SNAPSHOT
> > 
> >
> > It will be maintained also going forward (hopefully).
> >
> >
> > Here is an upgraded version that I have done, only a few changes are
> > needed.
> >
> > https://github.com/gregh3269/roller/tree/Upgrade_to_Struts-6.3.0.1
> >
> >
> > I have tested it and looks the same.  Can you have a look?  Need to
> > get off the 2.5.x branch.
> >
> >
> > Cheers Greg
> >
> >
>
>

Upgrade to latest struts

[Greg Huber]

Struts devs have updated the 4.0.x struts2-bootstrap-plugin to work on 
the latest version of struts


dependency>
com.jgeppert.struts2.bootstrap
struts2-bootstrap-plugin
    4.0.2-SNAPSHOT


It will be maintained also going forward (hopefully).


Here is an upgraded version that I have done, only a few changes are needed.

https://github.com/gregh3269/roller/tree/Upgrade_to_Struts-6.3.0.1


I have tested it and looks the same.  Can you have a look?  Need to get 
off the 2.5.x branch.



Cheers Greg

Re: Release rc2 as Roller v6.1.2

[Greg Huber]

OK on the TODO.  (Seen this...possibly weblog timestamp not being updated?)

+1 (b)

On Sat, 29 Jul 2023 at 22:19, Dave  wrote:

> Yeah, it's a cache issue. I did some experimentation and I found this:
>
> - Create an entry
> - See it on blog page
> - Change entry to a draft
> - It still appears on blog page
> - Switch to a different web browser (but do not login to Roller) and see
> that entry does not appear on blog page
> - Login with different web browser and see that entry does appear on blog
> page
>
> Seems like a cache invalidation problem for logged in users, but I do not
> see the problem in the code. I'm glad the draft entry gets removed from the
> search index tho, and thanks for testing search functionality Greg
> because it did change recently.
>
> I'm +1 on this release despite this glitch.
>
> Dave
>
>
>
> On Sat, Jul 29, 2023 at 4:33 PM Michael Bien  wrote:
>
> > Hi Greg,
> >
> > I could reproduce it, this seems to be a cache invalidation issue.
> >
> > the entry will disappear if you clear the cache via the Maintenance UI.
> > Roller has also various cache settings which can be set in roller
> > properties, e.g age based eviction which would further mitigate this.
> >
> > This is probably a bug but not a show stopper IMHO - updating entries
> > works fine for example,
> >
> > best regards,
> > michael
> >
> >
> > On 24.07.23 10:55, Greg Huber wrote:
> > > If I have a published entry, and then change the status to draft it
> > > does not update the front page/weblog and the entry still shows.
> > >
> > > If I publish another entry, the draft entry now does not so.
> > >
> > > Also how do I get it to show other weblog entries on the front page
> now?
> > >
> > > On 23/07/2023 21:10, Dave wrote:
> > >> This release of Roller includes dependency updates, minor fixes and
> some
> > >> input validation fixes. This new RC removes an unnecessary Solr
> > >> dependency,
> > >> makes some small docs fixes and removes an unnecessary error message.
> > >> Thanks for the reviews!
> > >>
> > >> You can find the convenience binaries and the source code of the
> release
> > >> here:
> https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/
> > >>
> > >> Please take it for a spin and vote:
> > >> +1 to release
> > >> -1 not to release (with reasons)
> > >>
> > >> Thanks,
> > >> Dave
> > >>
> >
> >
>

Re: [VOTE] Release rc2 as Roller v6.1.2

[Greg Huber]

I was testing the search index changes.

Add and entry, go to the Site page "All" category and do a test search.  
Then click the "edit" link on the entry, then click draft.  Go back to 
the Site page "All" category the entry shows, but the search does not 
find it any more.


On 23/07/2023 21:10, Dave wrote:

This release of Roller includes dependency updates, minor fixes and some
input validation fixes. This new RC removes an unnecessary Solr dependency,
makes some small docs fixes and removes an unnecessary error message.
Thanks for the reviews!

You can find the convenience binaries and the source code of the release
here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/

Please take it for a spin and vote:
+1 to release
-1 not to release (with reasons)

Thanks,
Dave

Re: [VOTE] Release rc2 as Roller v6.1.2

[Greg Huber]

If I have a published entry, and then change the status to draft it does 
not update the front page/weblog and the entry still shows.


If I publish another entry, the draft entry now does not so.

Also how do I get it to show other weblog entries on the front page now?

On 23/07/2023 21:10, Dave wrote:

This release of Roller includes dependency updates, minor fixes and some
input validation fixes. This new RC removes an unnecessary Solr dependency,
makes some small docs fixes and removes an unnecessary error message.
Thanks for the reviews!

You can find the convenience binaries and the source code of the release
here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/

Please take it for a spin and vote:
+1 to release
-1 not to release (with reasons)

Thanks,
Dave

Re: [VOTE] Release rc1 as Roller v6.1.2

[Greg Huber]

Is there a change log so I can test specific changes?

From a new install everything worked well.

Observations:



From the docs is there a reason for the incorrect quote ` rather than ' 
as I have to change it to grant all.


mysql> create database rollerdb DEFAULT CHARACTER SET utf8 DEFAULT
COLLATE utf8_general_ci;
mysql> grant all on rollerdb.* to scott@`%' identified by `tiger';
mysql> grant all on rollerdb.* to scott@localhost identified by `tiger';



Create weblog, possibly unnecessary log message when handle is invalid?

http://www/roller/roller-ui/createWeblog!save.rol

 * The handle you specified is not valid
 * Unexpected error validating weblog -- check Roller logs

URL: http://www.devbox/roller/test-another

org.apache.roller.weblogger.WebloggerException: Invalid handle: 
'test-another'


at 
org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:370) 
~[classes/:?]


at 
org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:358) 
~[classes/:?]


at 
org.apache.roller.weblogger.ui.struts2.core.CreateWeblog.myValidate(CreateWeblog.java:183) 
~[classes/:?]


On 20/07/2023 00:45, Dave wrote:

This release of Roller includes dependency updates, minor fixes and some
input validation fixes.

You can find the convenience binaries and the source code of the release
here:https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/

Please take it for a spin and vote:
+1 to release
-1 not to release (with reasons)

Thanks,
Dave

Re: Apache tiles

[Greg Huber]

Michael

It's worth upgrading as there are many improvements and also a setting 
that will speed up Roller UI:


struts.i18n.search.defaultbundles.first=true

As roller mainly uses ApplicationResources.properties for its i18n 
properties, the flag makes Struts check this file first, and then if it 
does not find the property do its extensive package search.  It brings 
back Struts1 performance (if you can remember that far back!).


The default is to do its extensive package search first (why it is slow).


On 21/03/2023 07:19, Michael Bien wrote:

roller would need some updates before it can go beyond struts 2.5.29:

https://github.com/apache/roller/pull/119#issuecomment-1344814362


probably easy to do but I never got to it. (bump the version and you 
should see failing integration tests)


the bootstrap dependency is also locked to 3.4.x AFAIR due to breaking 
changes which may or may not prevent other updates in future.


other then that I tried to keep the dependencies somewhat up2date, i 
think jakarta.persistence is already in use via eclipse link etc.


best regards,

michael


On 21.03.23 07:58, Greg Huber wrote:

Dave,

BTW, Struts devs are planning to merge the tiles code base into the 
Struts Tiles Plugin to eliminate the dependency on the now Attic 
project.


https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles


On 20/03/2023 21:38, Dave wrote:

Hi Laurent and PJ,

The Apache Roller project still uses Struts, Tiles and Velocity and 
I would
like to see the projects continue and move into Jakarta land. I have 
some

limited time to help out. What do y'all need help with?

Dave

On Sun, Mar 19, 2023 at 8:01 AM PJ Fanning  
wrote:



Hi Laurent,
I don't want to write off the possibility of a Jakarta variant of
Tiles joining the Apache Incubator - but the fact that Apache Tiles
doesn't have an active community around it is going to be a major
impediment. For Apache projects and podlings to succeed, they need a
number of contributors to get involved.
Could you start by putting your code up on Github or somewhere similar
and adding documentation that highlights that you are looking for
collaborators? Maybe there are some forums where some remaining users
of Tiles can be contacted?

There is no impediment to you simply releasing your Jakarta variant of
Tiles yourself or via some organisation that you are involved with
(e.g. a company that you work with). If you go this route, the ASF
would look like to see that you remove all the ASF branding and
ideally, change the package names.

If you want to avoid having to do all the branding changes and see the
new project join/rejoin the ASF, then I think that you'll need to come
back to us with more collaborators and probably some indication that
they are bought into keeping the project going over the foreseeable
future.

Regards,
PJ


On Sat, 18 Mar 2023 at 06:32, Laurent Schoelens
 wrote:

Hi everyone,

I’m working on Apache Tiles porting to Jakarta EE (without support of
freemarker and velocity, since both of them are still going with 
javax API)
and my work is going to reach it’s end – all builds are successful, 
jdk17
baseline and updated dependencies (as far as I know) – but still 
uncommited

to my personal github account.
I know Tiles is in Attic land of Apache but I’d which to make this 
first

step (Jakarta migration) go to open-source world, without creating new
projects out of the box.
Tiles is a framework I use on a project, with Spring and since 
Spring 6
has migrated to Jakarta API, I’m stuck to Spring 5.X if I stay on 
this.
Changing technology is an option for frontend application but not 
until a
good rework that may take months (or years, depending on time we 
have to do

that migration).
Having a Tiles Jakarta port would be great since the technology 
itself

is working well on my project.

Do you know what can I do to make this properly, according to Apache

work ?

Thanks in advance for your help.

Regards.
L. SCHOELENS

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: Apache tiles

[Greg Huber]

Dave,

BTW, Struts devs are planning to merge the tiles code base into the 
Struts Tiles Plugin to eliminate the dependency on the now Attic project.


https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles


On 20/03/2023 21:38, Dave wrote:

Hi Laurent and PJ,

The Apache Roller project still uses Struts, Tiles and Velocity and I would
like to see the projects continue and move into Jakarta land. I have some
limited time to help out. What do y'all need help with?

Dave

On Sun, Mar 19, 2023 at 8:01 AM PJ Fanning  wrote:


Hi Laurent,
I don't want to write off the possibility of a Jakarta variant of
Tiles joining the Apache Incubator - but the fact that Apache Tiles
doesn't have an active community around it is going to be a major
impediment. For Apache projects and podlings to succeed, they need a
number of contributors to get involved.
Could you start by putting your code up on Github or somewhere similar
and adding documentation that highlights that you are looking for
collaborators? Maybe there are some forums where some remaining users
of Tiles can be contacted?

There is no impediment to you simply releasing your Jakarta variant of
Tiles yourself or via some organisation that you are involved with
(e.g. a company that you work with). If you go this route, the ASF
would look like to see that you remove all the ASF branding and
ideally, change the package names.

If you want to avoid having to do all the branding changes and see the
new project join/rejoin the ASF, then I think that you'll need to come
back to us with more collaborators and probably some indication that
they are bought into keeping the project going over the foreseeable
future.

Regards,
PJ


On Sat, 18 Mar 2023 at 06:32, Laurent Schoelens
 wrote:

Hi everyone,

I’m working on Apache Tiles porting to Jakarta EE (without support of

freemarker and velocity, since both of them are still going with javax API)
and my work is going to reach it’s end – all builds are successful, jdk17
baseline and updated dependencies (as far as I know) – but still uncommited
to my personal github account.

I know Tiles is in Attic land of Apache but I’d which to make this first

step (Jakarta migration) go to open-source world, without creating new
projects out of the box.

Tiles is a framework I use on a project, with Spring and since Spring 6

has migrated to Jakarta API, I’m stuck to Spring 5.X if I stay on this.
Changing technology is an option for frontend application but not until a
good rework that may take months (or years, depending on time we have to do
that migration).

Having a Tiles Jakarta port would be great since the technology itself

is working well on my project.

Do you know what can I do to make this properly, according to Apache

work ?

Thanks in advance for your help.

Regards.
L. SCHOELENS

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: VOTE: Release Roller 6.1.1

[Greg Huber]

Good job, on a fresh install.

+1 b

On 03/04/2022 14:44, Dave wrote:

Roller 6.1.1 is a minor bug fix and dependency update release that upgrades
Spring, Struts, Lucene, Log4J, Guice and Bouncy Castle to the latest
versions.

A release candidate build is available here:
 https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.1

Please vote to release.

Thanks,
Dave

Re: VOTE: Release RC #2 as Apache Roller 6.1.0

[Greg Huber]

Still a +1

...for some reason it does not shutdown the thread correctly, maybe its 
logging something when shutdown is called?


On 21/12/2021 22:34, Dave wrote:

Greg, did you mean to change your vote to -1 or are you still good with the
release?

Dave

On Mon, Dec 20, 2021 at 1:05 AM Greg Huber  wrote:


It was a tomcat start and stop, no deploy/redeploy.  Seems to do it all
the time.

On 19/12/2021 10:46, Michael Bien wrote:

this looks like you redeployed or undeployed roller?

App/web servers don't like it when unmanaged threads are started,
AsyncAppender uses its own thread and the server noticed this i suppose.

see config:


https://github.com/apache/roller/blob/master/app/src/main/resources/log4j2.xml#L62-L65

If you remove this part and replace "asyncRoller" with "roller" you
shouldn't see the warning anymore.

The eclipse persistence error is probably caused by the undeployment too.

This is most likely harmless, unless you want to constantly redeploy
roller. Most web/app servers these days are used like a runtime in a
1:1 manner and are started/stopped with the application (in a container).

-michael


On 19.12.21 10:28, Greg Huber wrote:

Although I now see this in the logs (17 was a maintenance release?)


WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by
org.apache.catalina.loader.WebappClassLoaderBase
(file:/../apache-tomcat-9.0.56/lib/catalina.jar) to field
java.io.ObjectStreamClass$Caches.localDescs
WARNING: Please consider reporting this to the maintainers of
org.apache.catalina.loader.WebappClassLoaderBase
WARNING: Use --illegal-access=warn to enable warnings of further
illegal reflective access operations
WARNING: All illegal access operations will be denied in a future
release
WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
application [roller] appears to have started a thread named
[Log4j2-AsyncAppenderEventDispatcher-1-asyncRoller] but has failed to
stop it. This is very likely to create a memory leak. Stack trace of
thread:
  java.base@11.0.12/jdk.internal.misc.Unsafe.park(Native Method)
  
java.base@11.0.12/java.util.concurrent.locks.LockSupport.park(LockSupport.java:194)
  
java.base@11.0.12/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2081)
  
java.base@11.0.12/java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:417)


  
org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.dispatchAll(AsyncAppenderEventDispatcher.java:71)




  
org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.run(AsyncAppenderEventDispatcher.java:63)


WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
application [roller] appears to have started a thread named
[HttpClient-1-SelectorManager] but has failed to stop it. This is
very likely to create a memory leak. Stack trace of thread:
  java.base@11.0.12/sun.nio.ch.EPoll.wait(Native Method)
  
java.base@11.0.12/sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:120)
  
java.base@11.0.12/sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:124)
  java.base@11.0.12/sun.nio.ch

.SelectorImpl.select(SelectorImpl.java:136)

  
platform/java.net.http@11.0.12/jdk.internal.net.http.HttpClientImpl$SelectorManager.run(HttpClientImpl.java:867)
ERROR 2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
application [roller] created a ThreadLocal with key of type
[java.lang.ThreadLocal] (value [java.lang.ThreadLocal@1135abda]) and
a value of type
[org.eclipse.persistence.internal.jpa.EntityManagerImpl] (value
[org.eclipse.persistence.internal.jpa.EntityManagerImpl@74502929])
but failed to remove it when the web application was stopped. Threads
are going to be renewed over time to try and avoid a probable memory
leak.
INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Stopping
ProtocolHandler ["http-nio-8080"]
INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Stopping
ProtocolHandler ["ajp-nio-127.0.0.1-8009"]
INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Destroying
ProtocolHandler ["http-nio-8080"]
INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Destroying
ProtocolHandler ["ajp-nio-127.0.0.1-8009"]

On 18/12/2021 20:48, Dave wrote:

I propose that we release Roller v6.1.0 based on the code that is
currently
in the master branch. I have prepared a release candidate and some
release
notes, below.

Please vote in the next 72 hours to approve this release.
+1 to release
-1 not to release (with reasons)

Thanks to Michael Bien for all his work since the 6.0.1 release on bug
fixes, general improvements and dependency updates like the
important one
he made today to upgrade Log4j to 2.17.0.

The release candidate files are here:
https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/

Release notes

This is a bug fix and dependency update release that includes all
changes
made to the m

Re: VOTE: Release RC #2 as Apache Roller 6.1.0

[Greg Huber]

It was a tomcat start and stop, no deploy/redeploy.  Seems to do it all 
the time.


On 19/12/2021 10:46, Michael Bien wrote:

this looks like you redeployed or undeployed roller?

App/web servers don't like it when unmanaged threads are started, 
AsyncAppender uses its own thread and the server noticed this i suppose.


see config:
https://github.com/apache/roller/blob/master/app/src/main/resources/log4j2.xml#L62-L65 

If you remove this part and replace "asyncRoller" with "roller" you 
shouldn't see the warning anymore.


The eclipse persistence error is probably caused by the undeployment too.

This is most likely harmless, unless you want to constantly redeploy 
roller. Most web/app servers these days are used like a runtime in a 
1:1 manner and are started/stopped with the application (in a container).


-michael


On 19.12.21 10:28, Greg Huber wrote:

Although I now see this in the logs (17 was a maintenance release?)


WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by 
org.apache.catalina.loader.WebappClassLoaderBase 
(file:/../apache-tomcat-9.0.56/lib/catalina.jar) to field 
java.io.ObjectStreamClass$Caches.localDescs
WARNING: Please consider reporting this to the maintainers of 
org.apache.catalina.loader.WebappClassLoaderBase
WARNING: Use --illegal-access=warn to enable warnings of further 
illegal reflective access operations
WARNING: All illegal access operations will be denied in a future 
release
WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
application [roller] appears to have started a thread named 
[Log4j2-AsyncAppenderEventDispatcher-1-asyncRoller] but has failed to 
stop it. This is very likely to create a memory leak. Stack trace of 
thread:

 java.base@11.0.12/jdk.internal.misc.Unsafe.park(Native Method)
 java.base@11.0.12/java.util.concurrent.locks.LockSupport.park(LockSupport.java:194) 

 java.base@11.0.12/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2081) 

 java.base@11.0.12/java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:417) 

 org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.dispatchAll(AsyncAppenderEventDispatcher.java:71) 

 org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.run(AsyncAppenderEventDispatcher.java:63) 

WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
application [roller] appears to have started a thread named 
[HttpClient-1-SelectorManager] but has failed to stop it. This is 
very likely to create a memory leak. Stack trace of thread:

 java.base@11.0.12/sun.nio.ch.EPoll.wait(Native Method)
 java.base@11.0.12/sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:120) 

 java.base@11.0.12/sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:124) 


 java.base@11.0.12/sun.nio.ch.SelectorImpl.select(SelectorImpl.java:136)
 platform/java.net.http@11.0.12/jdk.internal.net.http.HttpClientImpl$SelectorManager.run(HttpClientImpl.java:867) 

ERROR 2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
application [roller] created a ThreadLocal with key of type 
[java.lang.ThreadLocal] (value [java.lang.ThreadLocal@1135abda]) and 
a value of type 
[org.eclipse.persistence.internal.jpa.EntityManagerImpl] (value 
[org.eclipse.persistence.internal.jpa.EntityManagerImpl@74502929]) 
but failed to remove it when the web application was stopped. Threads 
are going to be renewed over time to try and avoid a probable memory 
leak.
INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Stopping 
ProtocolHandler ["http-nio-8080"]
INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Stopping 
ProtocolHandler ["ajp-nio-127.0.0.1-8009"]
INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Destroying 
ProtocolHandler ["http-nio-8080"]
INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Destroying 
ProtocolHandler ["ajp-nio-127.0.0.1-8009"]


On 18/12/2021 20:48, Dave wrote:
I propose that we release Roller v6.1.0 based on the code that is 
currently
in the master branch. I have prepared a release candidate and some 
release

notes, below.

Please vote in the next 72 hours to approve this release.
+1 to release
-1 not to release (with reasons)

Thanks to Michael Bien for all his work since the 6.0.1 release on bug
fixes, general improvements and dependency updates like the 
important one

he made today to upgrade Log4j to 2.17.0.

The release candidate files are here:
https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/

Release notes

This is a bug fix and dependency update release that includes all 
changes
made to the master branch since August 16, 2021. It also includes 
the new
patched Log4j release. This release should be a drop-in replacement 
of the

previous v6.0.2 release.

Here is a summary of the changes.

All Pull Requests that were merged since August 16, 2021
https://github.com/a

Re: VOTE: Release RC #2 as Apache Roller 6.1.0

[Greg Huber]

Although I now see this in the logs (17 was a maintenance release?)


WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by 
org.apache.catalina.loader.WebappClassLoaderBase 
(file:/../apache-tomcat-9.0.56/lib/catalina.jar) to field 
java.io.ObjectStreamClass$Caches.localDescs
WARNING: Please consider reporting this to the maintainers of 
org.apache.catalina.loader.WebappClassLoaderBase
WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations

WARNING: All illegal access operations will be denied in a future release
WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
application [roller] appears to have started a thread named 
[Log4j2-AsyncAppenderEventDispatcher-1-asyncRoller] but has failed to 
stop it. This is very likely to create a memory leak. Stack trace of thread:

 java.base@11.0.12/jdk.internal.misc.Unsafe.park(Native Method)
 
java.base@11.0.12/java.util.concurrent.locks.LockSupport.park(LockSupport.java:194)
 
java.base@11.0.12/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2081)
 
java.base@11.0.12/java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:417)
 
org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.dispatchAll(AsyncAppenderEventDispatcher.java:71)
 
org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.run(AsyncAppenderEventDispatcher.java:63)
WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
application [roller] appears to have started a thread named 
[HttpClient-1-SelectorManager] but has failed to stop it. This is very 
likely to create a memory leak. Stack trace of thread:

 java.base@11.0.12/sun.nio.ch.EPoll.wait(Native Method)
 
java.base@11.0.12/sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:120)
 
java.base@11.0.12/sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:124)
 java.base@11.0.12/sun.nio.ch.SelectorImpl.select(SelectorImpl.java:136)
 
platform/java.net.http@11.0.12/jdk.internal.net.http.HttpClientImpl$SelectorManager.run(HttpClientImpl.java:867)
ERROR 2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
application [roller] created a ThreadLocal with key of type 
[java.lang.ThreadLocal] (value [java.lang.ThreadLocal@1135abda]) and a 
value of type [org.eclipse.persistence.internal.jpa.EntityManagerImpl] 
(value 
[org.eclipse.persistence.internal.jpa.EntityManagerImpl@74502929]) but 
failed to remove it when the web application was stopped. Threads are 
going to be renewed over time to try and avoid a probable memory leak.
INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Stopping 
ProtocolHandler ["http-nio-8080"]
INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Stopping 
ProtocolHandler ["ajp-nio-127.0.0.1-8009"]
INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Destroying 
ProtocolHandler ["http-nio-8080"]
INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Destroying 
ProtocolHandler ["ajp-nio-127.0.0.1-8009"]


On 18/12/2021 20:48, Dave wrote:

I propose that we release Roller v6.1.0 based on the code that is currently
in the master branch. I have prepared a release candidate and some release
notes, below.

Please vote in the next 72 hours to approve this release.
+1 to release
-1 not to release (with reasons)

Thanks to Michael Bien for all his work since the 6.0.1 release on bug
fixes, general improvements and dependency updates like the important one
he made today to upgrade Log4j to 2.17.0.

The release candidate files are here:
https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/

Release notes

This is a bug fix and dependency update release that includes all changes
made to the master branch since August 16, 2021. It also includes the new
patched Log4j release. This release should be a drop-in replacement of the
previous v6.0.2 release.

Here is a summary of the changes.

All Pull Requests that were merged since August 16, 2021
https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged

Bug resolved since August 16, 2021
https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27

And there is one database change: in the weblog table, the column blacklist
has been renamed to bannedwordslist.

Re: VOTE: Release RC #2 as Apache Roller 6.1.0

[Greg Huber]

+1 b

Cheers Greg

On 18/12/2021 20:48, Dave wrote:

I propose that we release Roller v6.1.0 based on the code that is currently
in the master branch. I have prepared a release candidate and some release
notes, below.

Please vote in the next 72 hours to approve this release.
+1 to release
-1 not to release (with reasons)

Thanks to Michael Bien for all his work since the 6.0.1 release on bug
fixes, general improvements and dependency updates like the important one
he made today to upgrade Log4j to 2.17.0.

The release candidate files are here:
https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/

Release notes

This is a bug fix and dependency update release that includes all changes
made to the master branch since August 16, 2021. It also includes the new
patched Log4j release. This release should be a drop-in replacement of the
previous v6.0.2 release.

Here is a summary of the changes.

All Pull Requests that were merged since August 16, 2021
https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged

Bug resolved since August 16, 2021
https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27

And there is one database change: in the weblog table, the column blacklist
has been renamed to bannedwordslist.

Re: VOTE: Release Roller v6.1.0

[Greg Huber]

Had to do a complete reinstall. Good work.

+1 b


Cheers Greg



may be worth checking:

From the docs:

The quotes are wrong ie ` possibly make users check the script??:

grant all on rollerdb.* to scott@`%' identified by `tiger';

grant all on rollerdb.* to scott@localhost identified by `tiger';


roller-custom.properties

Does not seem to work, defaults to tomcat home /logs:

log4j.appender.roller.File=/usr/local/rollerdata/roller.log



When doing a search, and logged, we get a login url on the bottom of 
search page.


http://localhost:8080/roller/mainpage/search?q=test

 * Front Page 
 * Weblog 
 * Login 




http://localhost:8080/roller/roller-ui/authoring/categories.rol?weblog=mainpage

When creating a category, if the url is invalid it does not create the 
entry.  Might be the correct behaviour? but there is no validation 
warning on save, just goes back to the categories page.





On 14/12/2021 22:09, Dave wrote:

I propose that we release Roller v6.1.0 based on the code that is currently
in the master branch. I have prepared a release candidate and some release
notes, below.

Please vote in the next 72 hours to approve this release.
+1 to release
-1 not to release (with reasons)

Thanks to Michael Bien for all his work since the 6.0.1 release on bug
fixes, general improvements and dependency updates like the important one
he made today to upgrade Log4j.

The release candidate files are here:
https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/

Release notes

This is a bug fix and dependency update release that includes all changes
made to the master branch since Dev 27, 2019. It also includes the new
patched Log4j release. This release should be a drop-in replacement of the
previous v6.0.1 release.

Here is a summary of the changes.

All Pull Requests that were merged since Dec 27, 2019
https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged

Bug resolved since Dec 27, 2019
https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27

And there is one database change: in the weblog table, the column blacklist
has been renamed to bannedwordslist.

Re: MediaFileView.jsp

[Greg Huber]

...Sorry, sent too soon,

Below comes from the 
http://127.0.0.1:8080/roller/roller-ui/authoring/bookmarks.rol?weblog=testuser 
menu.


08:06:25.493 [http-nio-8080-exec-9] WARN 
org.apache.struts2.util.TextProviderHelper - The first TextProvider in 
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks) 
could not locate the message resource with key 'default'
08:06:25.493 [http-nio-8080-exec-9] WARN 
org.apache.struts2.util.TextProviderHelper - The first TextProvider in 
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks) 
could not locate the message resource with key 'default'
08:06:25.494 [http-nio-8080-exec-9] WARN 
org.apache.struts2.util.TextProviderHelper - The default value 
expression 'default' was evaluated and did not match a property. The 
literal value 'default' will be used.
08:06:25.494 [http-nio-8080-exec-9] WARN 
org.apache.struts2.util.TextProviderHelper - The default value 
expression 'default' was evaluated and did not match a property. The 
literal value 'default' will be used.



Cheers Greg

On 09/08/2021 17:46, Michael Bien wrote:

On 09.08.21 09:51, Greg Huber wrote:

Spotted this one when deleting a folder:

MediaFileView.jsp

function onDeleteFolder() {
    if (confirm("/>")) {
    document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';

    document.bookmarks.submit();
    }
    }

guess it should be: document.mediaFileViewForm.action and 
document.mediaFileViewForm.submit();


looks like a copy and paste bug on first glance. However deleting 
folders actually works, right? I ran a quick test and the folder is gone.





Also where is the bookmarks page link now?  editor-menu.xml, for 
weblogPerms="admin"


 
    subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport" 
/>


Its called Blogroll in the menu 
(/roller-ui/authoring/bookmarks.rol?weblog=blog)


the admin user might not have this menu unless the admin has a blog too.

best regards,

michael

Re: MediaFileView.jsp

[Greg Huber]

> looks like a copy and paste bug on first glance. However deleting 
folders actually works, right? I ran a quick test and the folder is gone.


Yes it works, but I get this error in the console (forgot to add this to 
the first email) after delete:


Uncaught TypeError: document.bookmarks is undefined
    onDeleteFolder 
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:956
    onclick 
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:1


##

>Its called Blogroll...

OK name change.

Cheers Greg

On 09/08/2021 17:46, Michael Bien wrote:

On 09.08.21 09:51, Greg Huber wrote:

Spotted this one when deleting a folder:

MediaFileView.jsp

function onDeleteFolder() {
    if (confirm("/>")) {
    document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';

    document.bookmarks.submit();
    }
    }

guess it should be: document.mediaFileViewForm.action and 
document.mediaFileViewForm.submit();


looks like a copy and paste bug on first glance. However deleting 
folders actually works, right? I ran a quick test and the folder is gone.





Also where is the bookmarks page link now?  editor-menu.xml, for 
weblogPerms="admin"


 
    subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport" 
/>


Its called Blogroll in the menu 
(/roller-ui/authoring/bookmarks.rol?weblog=blog)


the admin user might not have this menu unless the admin has a blog too.

best regards,

michael

Re: VOTE: Release Apache Roller 6.0.2

[Greg Huber]

From the listed changes, seems OK +1(b)



Spotted this one when deleting a folder:

MediaFileView.jsp

function onDeleteFolder() {
    if (confirm("")) {
    document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';

    document.bookmarks.submit();
    }
    }

guess it should be: document.mediaFileViewForm.action and 
document.mediaFileViewForm.submit();


Possibly related??


08:16:23.977 [http-nio-8080-exec-2] WARN 
org.apache.struts2.util.TextProviderHelper - The first TextProvider in 
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks) 
could not locate the message resource with key 'default'
08:16:23.977 [http-nio-8080-exec-2] WARN 
org.apache.struts2.util.TextProviderHelper - The first TextProvider in 
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks) 
could not locate the message resource with key 'default'
08:16:23.999 [http-nio-8080-exec-2] WARN 
org.apache.struts2.util.TextProviderHelper - The default value 
expression 'default' was evaluated and did not match a property. The 
literal value 'default' will be used.
08:16:23.999 [http-nio-8080-exec-2] WARN 
org.apache.struts2.util.TextProviderHelper - The default value 
expression 'default' was evaluated and did not match a property. The 
literal value 'default' will be used.




Also where is the bookmarks page link now?  editor-menu.xml, for 
weblogPerms="admin"


 
    subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport" 
/>


Cheers Greg

On 08/08/2021 20:57, Dave wrote:

Please vote to release the release candidate (RC2) at the link below as
Apache Roller 6.0.2
The release candidate is here
https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.2/

Please vote +1 to release or -1 with reasons not to release.


This release includes the minor changes listed below:

Parse referrer URL instead of using string value directly
https://github.com/apache/roller/pull/90

Improved: the UI for the blog entries page
https://github.com/apache/roller/pull/87

Improved: tooltip content on the registration form
https://github.com/apache/roller/pull/89

Updated: the main menu to have proper space when displaying permission
message
https://github.com/apache/roller/pull/95

Updated: the header to show the tagline only when it's available
https://github.com/apache/roller/pull/99


UI fixes are thanks to new contributor Yash Maheshwari.

Best regards,
Dave

Re: [GitHub] [roller] mbien opened a new pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support

[Greg Huber]

Probably guarantee streams will become the defacto way and their 
overuse.  Personally prefer the standard way, understanding loops etc 
which would be common to other languages.  The silly syntax is just 
something else we have to remember.


I have seen some really complex one liners, with the arrow function, and 
no explanation on what its doing.  Clever? not.



Cheers Greg

On 11/07/2021 15:13, Michael Bien wrote:
no worries. I remember the first time i heard of java getting streams 
my first thought was io too.


Streams are great as long you don't overuse them.

-michael

On 11.07.21 10:09, Greg Huber wrote:


Sorry you are right, was thinking more of io streams, rather than 
java.util.Collection.stream.  Says it closes it once read, and should 
maintain the order.


too many ways of doing the same stuff.

On 11/07/2021 08:36, Michael Bien wrote:

Hi Greg,

those are java 8 functional streams* - not IO streams. So they don't 
really have to be closed, the method collect() "runs" the stream in 
this example by putting all results into a list. There are no system 
resources involved which would have to be freed.


this code snipped creates a stream from the list, wraps each element 
into a WeblogEntryWrapper, then creates a list again. In future the 
pojo could directly return a stream instead of a list, so the method 
would only add a step to the stream like a pipeline (and return a 
stream too).


does this answer your question?

thanks for reviewing :)

best regards,
michael

* 
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/stream/package-summary.html


- - - -
https://mbien.dev

On 11.07.21 08:45, Greg Huber wrote:
Maybe more of a java question, how do these streams get closed as 
wrappers are in used in the templates?


org.apache.roller.weblogger.pojos.wrapper;

public List retrieveWeblogEntries(boolean 
publishedOnly) throws WebloggerException {

    return this.pojo.retrieveWeblogEntries(publishedOnly).stream()
    .map(entry -> WeblogEntryWrapper.wrap(entry, 
urlStrategy))

    .collect(Collectors.toList());

}

I always use a try-with-resources on these.


On 10/07/2021 11:03, GitBox wrote:

mbien opened a new pull request #96:
URL: https://github.com/apache/roller/pull/96


    Worked myself though the compiler warnings. This looks like a 
lot of changes, but the individual changes are all very local.
        * since most of the rawtype warnings were on Collections, 
I updated a lot of the code to use more modern APIs instead of 
only fixing the warnings (e.g List.of, streams, ...)

    * extracted common reflection code to a utility class
    * got rid of some deprecations
    * some cleanup and improvements (~400 lines less code)
    * JDK 17 support (runs still on 11)

Re: [GitHub] [roller] mbien opened a new pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support

[Greg Huber]

Maybe more of a java question, how do these streams get closed as 
wrappers are in used in the templates?


org.apache.roller.weblogger.pojos.wrapper;

public List retrieveWeblogEntries(boolean 
publishedOnly) throws WebloggerException {

    return this.pojo.retrieveWeblogEntries(publishedOnly).stream()
    .map(entry -> WeblogEntryWrapper.wrap(entry, urlStrategy))
    .collect(Collectors.toList());

}

I always use a try-with-resources on these.


On 10/07/2021 11:03, GitBox wrote:

mbien opened a new pull request #96:
URL: https://github.com/apache/roller/pull/96


Worked myself though the compiler warnings. This looks like a lot of 
changes, but the individual changes are all very local.

* since most of the rawtype warnings were on Collections, I updated a lot of the code to use more modern APIs instead of only fixing the warnings (e.g List.of, streams, ...)

* extracted common reflection code to a utility class
* got rid of some deprecations
* some cleanup and improvements (~400 lines less code)
* JDK 17 support (runs still on 11)

Re: [VOTE] Release rc-2 as Roller 6.0.1

[Greg Huber]

+1 (b)

Cheers Greg

##

For page : 
http://127.0.0.1:8080/roller/roller-ui/admin/globalCommentManagement!update.rol


it might be worth adding the ajax comment edit from main weblog? ( 
http://127.0.0.1:8080/roller/roller-ui/authoring/comments.rol )


On 03/05/2020 21:16, Dave wrote:

Roller 6.0.1 is a bug fix release that fixes bugs in the Server Admin,
Create New User, Weblog Config and comments pages.

Thanks to all who helped out with 6.0. Also, thanks to the work of Swapnil
Mane, all of the Roller docs have now been updated for the new Roller 6 UI
and converted to AsciiDoc. They are included in the binary release as PDFs.

Release candidate files are here:
https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1

Release Notes - Apache Roller - Version 6.0.1
** Bug
 * [ROL-2160] - Server admin page fails to display properly
 * [ROL-2161] - Create New user error
 * [ROL-2164] - Incorrect key`createWebsite.timeZone` in WeblogConfig.jsp
 * [ROL-2165] - Fix poor formatting caused by word-wrapping in
CommentDataServlet.java

Please vote to release Roller 6.0.1.

Thanks,
Dave

Re: [VOTE] Release rc-1 as Roller 6.0.1

[Greg Huber]

+1 with some notes below.

Cheers Greg

##

http://127.0.0.1:8080/roller/roller-ui/authoring/weblogConfig.rol?weblog=testuser

Missing value for createWebsite.timeZone

##

Remember me seems to have gone?

##

http://127.0.0.1:8080/roller/roller-ui/admin/globalConfig.rol

Editor Pages are these still valid?

Editor Pages : editor-text.jsp,editor-rte.jsp,editor-xinha.jsp

##

Duplicate /n when editing a comment

org.apache.roller.weblogger.ui.struts2.ajax.CommentDataServlet

String content = Utilities.escapeHTML(c.getContent());
content = WordUtils.wrap(content, 72);
content = StringEscapeUtils.escapeEcmaScript(content);

It would be better to leave the wrapping to the ui.  ie remove 
WordUtils.wrap(content, 72);



On 10/04/2020 21:42, Dave wrote:

I have prepared a release candidate for a Roller 6.0.1 release based on
latest code in the roller-6.0.x branch.  This release will be a minor bug
fix release. It fixes two bugs, which you can see here:

https://issues.apache.org/jira/projects/ROL/versions/12347761

A release candidate files for this release are available here:

https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1/

Please vote +1 to release or -1 with reason(s) not to release.

I plan to leave this vote open until April 19 to allow folks time to test.

Thanks,
Dave

Re: [VOTE] to release candidate #3 as Apache Roller 6.0.0

[Greg Huber]

Dave,

Something strange on the save comment link, if I have a large string of 
text, when I save the entry is seems to add carriage returns to the 
saved content.  Repeat saves adds more carriage returns.


Otherwise it looks good.

+1(b)

Cheers Greg

On 15/12/2019 17:23, Dave wrote:

I made fixes for the problems identified in the previous release candidate
(JavaScript length instead of size and the template remove breakage). Now
would like to call a vote to release candidate #3 as Roller 6.0.0.
Release candidate files are here:

 https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.0/

Please vote +1 to release or -1 with reason(s) not to release.

Thanks,
Dave

Below are the proposed release notes (thanks to Swapnil for the edits):

=
The Apache Roller community is pleased to announce the release for
Apache Roller 6.0.0.

Apache Roller is a Java-based, full-featured, multi-user and
group-blog server suitable for blog sites large and small.

"Apache Roller 6.0.0" is the latest and greatest release of Roller; for
more details of the changes introduced with this new version please refer to
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310906=12344884

Apache Roller is available on the download page:
https://roller.apache.org/downloads/downloads.html

In summary, Roller 6 is a new version of Roller with these features:
* Web interface has been rewritten to use Twitter bootstrap
via the Struts 2 Bootstrap tags.
* Most dependencies have been upgraded to the latest version.
* Compiled with Java 11 and requires Java 11.
* The installation guide has been converted from OpenOffice to AsciiDocs.

It should be relatively easy to upgrade from Roller 5.2.4 to Roller 6
because there are no changes to the database schema (that means you can
easily roll back if you find problems). The user interface is different and
we hope you'll find it better, easier to use, more intuitive and with a
more modern feel.

Thanks to the many contributors to Roller for this new release.
We hope you'll enjoy and find it useful.

For more information on Apache Roller, visit the project website:
https://roller.apache.org/

Re: [VOTE] Release Apache Roller 6.0.0

[Greg Huber]

sorry, more logging on the template remove

09:00:00.058 [http-nio-8080-exec-7] WARN
org.apache.struts2.components.ServletUrlRenderer - No configuration found
for the specified action: 'templateRemove' in namespace:
'/roller-ui/authoring'. Form action defaulting to 'action' attribute's
literal value.


On Mon, 9 Dec 2019 at 23:49, Dave  wrote:

> Please vote to release RC2 as Apache Roller 6.0.0. Release candidate files
> are here:
> https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.0/
>
> Please vote +1 to release or -1 with reason(s) not to release.
>
> Thanks,
> Dave
>
>
> PS. This is the proposed release announcement:
>
> The Apache Roller project is pleased to announce the release of Roller
> 6.0.0.
>
> You can find a list of the issues resolved in Roller 6 here:
> https://issues.apache.org/jira/projects/ROL/versions/12344884
>
> In summary, Roller 6 is a new version of Roller with these features:
> * Web interface has been rewritten to use Twitter bootstrap via the Struts
> 2 Bootstrap tags.
> * Most dependencies have been upgraded to latest version.
> * Compiled with Java 11 and requires Java 11.
> * The installation giude has been converted from OpenOffice to AsciiDocs.
>
> It should be relatively easy to ugrade from Roller 5.2.4 to Roller 6
> because there are no changes to the database schema (that means you can
> easily roll back if you find problems). The user interface is different and
> we hope you'll find it better, easier to use, more intuitive and with a
> more modern feel.
>
> Thanks to the many contributors to Roller for this new release. We hope
> you'll enjoy and find it useful.
>

Re: [VOTE] Release Apache Roller 6.0.0

[Greg Huber]

Dave,

Looks great!

Can these be checked?

1. Comment edit onclick, does not like the size(), .length works though
(ff).

roller/roller-ui/authoring/comments.rol on the edit comment

function editComment(id) {
// make sure we have the full comment
//if ($("#link-" + id).size() > 0) readMoreComment(id, editComment);
if ($("#link-" + id).length > 0) readMoreComment(id, editComment);

// save the original comment value
comments[id] = $("#comment-" + id).html();

$("#editlink-" + id).hide();
$("#savelink-" + id).show();
$("#cancellink-" + id).show();

// put comment in a textarea for editing
$("#comment-" + id).html(""
+ comments[id] + "");
}

2. Template delete does not work

roller/roller-ui/authoring/templates page delete template click

TypeError: document.templateRemove is undefined

Cheers Greg


On Mon, 9 Dec 2019 at 23:49, Dave  wrote:

> Please vote to release RC2 as Apache Roller 6.0.0. Release candidate files
> are here:
> https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.0/
>
> Please vote +1 to release or -1 with reason(s) not to release.
>
> Thanks,
> Dave
>
>
> PS. This is the proposed release announcement:
>
> The Apache Roller project is pleased to announce the release of Roller
> 6.0.0.
>
> You can find a list of the issues resolved in Roller 6 here:
> https://issues.apache.org/jira/projects/ROL/versions/12344884
>
> In summary, Roller 6 is a new version of Roller with these features:
> * Web interface has been rewritten to use Twitter bootstrap via the Struts
> 2 Bootstrap tags.
> * Most dependencies have been upgraded to latest version.
> * Compiled with Java 11 and requires Java 11.
> * The installation giude has been converted from OpenOffice to AsciiDocs.
>
> It should be relatively easy to ugrade from Roller 5.2.4 to Roller 6
> because there are no changes to the database schema (that means you can
> easily roll back if you find problems). The user interface is different and
> we hope you'll find it better, easier to use, more intuitive and with a
> more modern feel.
>
> Thanks to the many contributors to Roller for this new release. We hope
> you'll enjoy and find it useful.
>

Re: [VOTE] Release Roller 5.2.4

[Greg Huber]

+1 (b).  Xinha editor works ok.

On Mon, 15 Jul 2019 at 23:36, Dave  wrote:

> The Apache Roller 5.2.3 release included an upgrade to the Xinha rich text
> editor which causes the Roller editor to fail to load (for Xinha users
> only). We have not yet determined the root cause of this problem so, for
> now, we have decided to revert the Xinha upgrade.
>
> You can find a release candidate for Apache Roller 5.2.4 here:
>  https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.4/
>
> Please vote to release Roller 5.2.4.
>
> Thanks,
> Dave
>

Re: [VOTE] Release Apache Roller 5.2.3

[Greg Huber]

+1 (b).

Cheers Greg

On Sun, 30 Jun 2019 at 14:43, Dave  wrote:

> Please vote to release Apache Roller 5.2.3.
>
> I've prepared a third release candidate for 5.2.3 that corrects the
> LICENSE and NOTICE files, thanks to Aditya and Sebb.
> You can find the full list of fixes and improvements in the release notes
> below.
>
> IMPORTANT NOTE: for users of Remember-Me. Due to security concerns,
> Remember-Me is now disabled by default. If you want to use it, you will
>  need to enable it and provide a secret key for it in your Roller
>  properties file, for example:
>
> rememberme.enabled=true
> rememberme.key=reallyreallysecretsecret
>
> Release Candidate #3 files are here:
>  https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/
>
> Please take a look and cast your vote. I plan to hold this vote open until
> next weekend.
>
> Thanks,
> Dave
>
>
> Release notes:
>
> Bug
> [ROL-2100] - HTTPS Scheme Enforcement feature removed
> [ROL-2127] - Automatic database upgrade fails
> [ROL-2129] - duplicate index on roller_oauthconsumer as Primary Key
> [ROL-2132] - Remember-me fails when LDAP used for auth
> [ROL-2135] - Comment Authenticator fix
> [ROL-2138] - NOTICE file does not have standard content
> [ROL-2143] - Fix mvn jetty:run
>
> Improvement
> [ROL-2137] - Require rememberme.key to be set
>
> Test
> [ROL-2142] - Skip RSS/Atom feed fetcher tests on Java 1.7
>

Re: [CANCELLED] [VOTE] Release Roller v5.2.3

[Greg Huber]

Dave,

My issue, just noticed I had roller running on IBM jdk
(ibm-java-x86_64-sdk-8.0-5.30), which seemed to cause the problem.  When I
switched to zulu8.36.0.1-ca-jdk8.0.202-linux_x64 roller now works OK.

I remember now, there are differences in the xml parser where the IBM does
not like certain statements
which must be enclose in 

Re: [VOTE] Release Roller v5.2.3

[Greg Huber]

I am getting for

http://127.0.0.1:8080/roller/roller-ui/authoring/entryAdd.rol

Method saveDraft for action entryAdd is not allowed!
Method publish for action entryAdd is not allowed!

also on other actions
Method saveDraft for action entryEdit is not allowed!

they are in the namespace:
namespace /roller-ui/authoring  

So not sure why it is not working now?

Cheers Greg

##
although its better to add them to the action rather than globals
eg

...
save, saveDraft,...




On Sun, 2 Jun 2019 at 22:13, Dave  wrote:

> I have prepared a release candidate for Roller 5.2.3, a minor bug-fix
> release. You can find the list of fixes and improvements JIRA here:
>
> https://issues.apache.org/jira/projects/ROL/versions/12344883
>
> IMPORTANT NOTE: for users of Remember-Me. Due to security concerns,
> Remember-Me is now disabled by default. If you want to use it, you will
> need to enable it and provide a secret key for it in your Roller properties
> file, for example:
>
> rememberme.enabled=true
> rememberme.key=reallyreallysecretsecret
>
> Release Candidate #1 files are here:
> https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/
>
> Please take a look and cast your vote. I plan to hold this vote open for 7
> days.
>
> Thanks,
> Dave
>

Re: Moving Roller master to Java 11

[Greg Huber]

for java11 email was troublesome as jaf was removed, also now its morphed :
https://eclipse-ee4j.github.io/javamail/

com.sun.mail
jakarta.mail
1.6.3
provided


Cheers Greg

On Sun, 12 May 2019 at 19:26, Dave  wrote:

> We've got a Pull Request that adds support for Java 11 in Roller.
>https://github.com/apache/roller/pull/14
>
> Is anybody opposed to merging this PR and moving Roller's master branch to
> Java 11?
>
> I think the next major release of Roller (6.0) should include the new
> Bootstrap based UI and should run on Java 11. Java 8 has been EOLed and
> Java 11 is the current LTS version, so IMO it makes sense to upgrade.
>
> I plan to continue to maintain Roller 5.x on Java 8 for the foreseeable
> future.
>
> Dave
>

Re: Moving Roller master to Java 11

[Greg Huber]

+1
...java8 is LTS till 2023! is struts java11?  I get some warnings on
startup last time I looked.

On Sun, 12 May 2019 at 19:26, Dave  wrote:

> We've got a Pull Request that adds support for Java 11 in Roller.
>https://github.com/apache/roller/pull/14
>
> Is anybody opposed to merging this PR and moving Roller's master branch to
> Java 11?
>
> I think the next major release of Roller (6.0) should include the new
> Bootstrap based UI and should run on Java 11. Java 8 has been EOLed and
> Java 11 is the current LTS version, so IMO it makes sense to upgrade.
>
> I plan to continue to maintain Roller 5.x on Java 8 for the foreseeable
> future.
>
> Dave
>

Re: [VOTE] Release Apache Roller 5.2.3 bug fix release

[Greg Huber]

Checking the logs, did not get any errors (or previous) on the upgrade.

Testing with
510-to-520-migration.sql

I changed roller.database.version to 510 and restarted, roller changed it
to 523.

INFO  2019-01-29 08:11:53,972 DatabaseInstaller:upgradeDatabase - Database
is old, beginning upgrade to version 523

Not sure how to check if it has actually run (mariadb)
alter table weblogentry modify updatetime datetime(3) not null;
Reduces the time stamps to milliseconds?

if I dump the table:
CREATE TABLE IF NOT EXISTS `weblogentry` (
  `pubtime` datetime DEFAULT NULL,
  `updatetime` datetime NOT NULL,
) ENGINE=MyISAM DEFAULT CHARSET=latin1;

+1 (b)

Cheers Greg

On Sun, 27 Jan 2019 at 17:01, Dave  wrote:

> Hi Roller community,
>
> I propose that we release the current contents of the Roller 5.2.x branch
> as Roller 5.2.3 because database upgrade (via web UI auto-upgrade) is
> broken. This is the fix:
>
>Database upgrading does not work
>https://issues.apache.org/jira/browse/ROL-2127
>
> Here's are the release files:
>https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/
>
> Please vote +1 to release or -1 with reasons not to release.
>
> Thanks,
> Dave
>

Re: Try Roller's new web UI

[Greg Huber]

All I have


Which branch could be used for prs?

https://github.com/apache/roller/tree/bootstrap-ui

On Mon, 21 Jan 2019 at 17:37, Dave  wrote:

> Thanks Greg.  I'll fix that. I do think your way of doing this is better,
> and less prone to errors.
>
> Dave
>
> On Mon, Jan 21, 2019 at 11:36 AM Greg Huber  wrote:
>
> > Dave,
> >
> > http://127.0.0.1/roller/roller-ui/authoring/entryAdd.rol
> >
> > When I click on the save draft / publish
> >
> > Method saveDraft for action entryAdd is not allowed!
> > Method publish for action entryAdd is not allowed!
> >
> > Seems to be ignoring the  entries.
> >
> > I add do mine like this, rather than globals:
> >
> >  >
> > class="org.apache.roller.weblogger.ui.struts2.editor.EntryEdit">
> > entryAdd
> > weblogEdit.title.newEntry
> > .EntryEdit
> > 
> > entryEdit!firstSave
> > ${weblog}
> > ${bean.id}
> > 
> > saveDraft,publish
> > 
> >
> >
> > On Mon, 21 Jan 2019 at 16:01, Dave  wrote:
> >
> > > I tried to make it really easy to try Roller's new Bootstrap-based web
> UI
> > > by using Docker Compose. You can read about it here:
> > >
> > >https://rollerweblogger.org/roller/entry/roller-6-snapshot
> > >
> > > I hope you'll give it a try.
> > >
> > > Dave
> > >
> >
>

Re: Try Roller's new web UI

[Greg Huber]

Dave,

http://127.0.0.1/roller/roller-ui/authoring/entryAdd.rol

When I click on the save draft / publish

Method saveDraft for action entryAdd is not allowed!
Method publish for action entryAdd is not allowed!

Seems to be ignoring the  entries.

I add do mine like this, rather than globals:


entryAdd
weblogEdit.title.newEntry
.EntryEdit

entryEdit!firstSave
${weblog}
${bean.id}

saveDraft,publish



On Mon, 21 Jan 2019 at 16:01, Dave  wrote:

> I tried to make it really easy to try Roller's new Bootstrap-based web UI
> by using Docker Compose. You can read about it here:
>
>https://rollerweblogger.org/roller/entry/roller-6-snapshot
>
> I hope you'll give it a try.
>
> Dave
>

Re: Reminder please [VOTE] to release Roller 5.2.2

[Greg Huber]

+1 (b)


On Sat, 5 Jan 2019 at 21:36, Dave  wrote:

> On Thu, Dec 27, 2018 at 5:02 PM Dave  wrote:
>
> > Hi Roller community,
> >
> > I propose that we release the current contents of the Roller 5.2.x branch
> > as Roller 5.2.1 so that we can release two small fixes to Roller. These
> are
> > the fixes:
> >
> >Disable DOCTYPE handling in SAX Parser
> >https://issues.apache.org/jira/browse/ROL-2124
> >
> >Workaround Firefox feed stylesheet issue
> >https://issues.apache.org/jira/browse/ROL-2125
> >
> > I have prepared a release candidate, which you can find here:
> >https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.2
> >
> > Please vote +1 to release or -1 with reasons not to release.
> >
> > Thanks,
> > Dave
> >
> >
> >
> >
>

Re: rss feeds mozilla

[Greg Huber]

Dave,

In the end I just created a macro with a content of



as I thought it was much longer, rather than the foreach.

Cheers Greg



On Sun, 2 Dec 2018 at 15:54, Dave  wrote:

> Thanks, I'll take a look at that today along with the Struts/XML thing.
>
> Dave
>
> On Fri, Nov 30, 2018 at 9:48 AM Greg Huber  wrote:
>
> > Dave,
> >
> > BIF.  With the pending removal of feed reader and live bookmarks support
> > from Firefox:
> >
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1477667
> >
> > To make the roller feeds work again in firefox, it needs a workaround:
> >
> >
> >
> https://developer.mozilla.org/en-US/docs/Web/API/XSLTProcessor/XSL_Transformations_in_Mozilla_FAQ
> >
> > Just add this to the templates, it creates the 512 bytes comment (various
> > ways of doing it!)
> >
> > 
> >
> > eg
> >
> > *#
> > #if($config.feedStyle) > href="$url.absoluteSite/roller-ui/styles/rss.xsl" media="screen"?>#end
> >  > ...
> >
> > Cheers Greg
> >
>

rss feeds mozilla

[Greg Huber]

Dave,

BIF.  With the pending removal of feed reader and live bookmarks support
from Firefox:

https://bugzilla.mozilla.org/show_bug.cgi?id=1477667

To make the roller feeds work again in firefox, it needs a workaround:

https://developer.mozilla.org/en-US/docs/Web/API/XSLTProcessor/XSL_Transformations_in_Mozilla_FAQ

Just add this to the templates, it creates the 512 bytes comment (various
ways of doing it!)



eg

*#
#if($config.feedStyle)#end

Re: [RESULTS] Release Roller 5.2.1 - Reminder

[Greg Huber]

Sorry, thought I had already voted, +1(b).

Cheers

On Sun, 14 Oct 2018 at 18:39, Dave  wrote:

> We have the votes to release v5.2.1 and I will do so today.
>
>Dave +1
>Matt +1
>Kohei +1
>
> Thanks!
> Dave
>
>
>
>
>
> On Sun, Oct 7, 2018 at 10:27 PM Kohei Nozaki  wrote:
>
> > Hi Dave,
> >
> > I've quickly checked the changes and they look good to me. Thank you for
> > your work on this release. +1
> >
> > Regards,
> > Kohei
> >
> > > On Oct 8, 2018, at 6:15, Dave  wrote:
> > >
> > > We need one more plus one to get this minor release out the door, so I
> > > would like to hold this vote open. PMC members, please take a look when
> > you
> > > get a chance and weigh-in.
> > >
> > > Thanks,
> > > Dave
> > >
> > >
> > > On Mon, Oct 1, 2018 at 12:26 PM Matt Raible 
> > wrote:
> > >
> > >> +1
> > >>
> > >>> On Sep 30, 2018, at 4:08 PM, Dave  wrote:
> > >>>
> > >>> The proposed Roller 5.2.1 release is a security release, but not to
> fix
> > >> any
> > >>> specific known vulnerability. Roller 5.2.1 is being release simply to
> > >>> upgrade to the latest Struts 2 release, 2.5.17, which contains some
> > >>> security releated fixes.
> > >>>
> > >>> This vote is to release Roller 5.2.1-rc-2 as Roller 5.2.1. You can
> find
> > >> the
> > >>> release files here:
> > >>>
> https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.1-rc-2/
> > >>>
> > >>> I plan to hold this vote open until Friday Oct 5 to give folks time
> to
> > >> take
> > >>> a look and vote.
> > >>>
> > >>> Thanks,
> > >>> Dave
> > >>
> > >>
> >
> >
>

Re: Apache Roller 5.2.1-rc-1 ready for review

[Greg Huber]

Rechecking, cannot get it to show incorrectly again.  Maybe the cache was
out of date as re-saving as draft does not seem to trigger a refresh the
main weblog page.


On Sat, 8 Sep 2018 at 14:57, Dave  wrote:

> On Sun, Sep 2, 2018 at 6:41 PM Dave  wrote:
>
> > Thanks Greg. I'll check that out.
> >
> > Dave
> >
> >
> > On Sun, Sep 2, 2018 at 4:40 AM Greg Huber  wrote:
> >
> >> Upgrade looks ok. Database upgrade went OK also.  +1 (b)
> >>
> >> ##
> >>
> >> Noticed that the pager links look strange on the main weblog page.
> >>
> >> http://localhost:8080/roller/testuser/
> >>
> >> If I have three entries
> >> Test1
> >> Test2
> >> Test3
> >>
> >> If I click on Test1  :
> http://localhost:8080/roller/testuser/entry/test1
> >>
> >> The pager link at the top of the page is : « Test1 | Main
> >>
> >> Should be:  Main | Test2 »   as we are paging down the entries?
> >>
> >
>
> Oddly enough, I am getting a different result. I created a blog with the
> Basic theme and added three entries. On entry test1 I see Main | Test2 »
> which is correct.
>
> Dave
>
>
>
> >
> >> also these don't look correct:
> >>
> >> http://localhost:8080/roller/testuser/entry/test2
> >>
> >> « Test2 | Main | Test1 »   >>  « Test1 | Main | Test3 »
> >>
> >> http://localhost:8080/roller/testuser/entry/test3
> >>
> >> « Test3 | Main | Test2 »  >> « Test2 | Main
> >>
> >> Cheers Greg
> >>
> >>
> >> On Sat, 1 Sep 2018 at 13:57, Dave  wrote:
> >>
> >> > I have prepared a release candidate #1 for a new release Roller
> v.5.2.1.
> >> >
> >> > The purpose of this release is to upgrade to Struts 2.5.17 which
> >> includes
> >> > some security fixes. That is the only change in this release.
> >> >
> >> > You can find the release files here:
> >> > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.1-rc-1/
> >> >
> >> > I've done some smoke-testing and will upgrade my site over the next
> day
> >> or
> >> > two.
> >> > Please take a look, try it out if you have time and I will call a vote
> >> > probably tomorrow.
> >> >
> >> > Thanks,
> >> > Dave
> >> >
> >>
> >
>

Re: Apache Roller 5.2.1-rc-1 ready for review

[Greg Huber]

Upgrade looks ok. Database upgrade went OK also.  +1 (b)

##

Noticed that the pager links look strange on the main weblog page.

http://localhost:8080/roller/testuser/

If I have three entries
Test1
Test2
Test3

If I click on Test1  : http://localhost:8080/roller/testuser/entry/test1

The pager link at the top of the page is : « Test1 | Main

Should be:  Main | Test2 »   as we are paging down the entries?

also these don't look correct:

http://localhost:8080/roller/testuser/entry/test2

« Test2 | Main | Test1 »   >>  « Test1 | Main | Test3 »

http://localhost:8080/roller/testuser/entry/test3

« Test3 | Main | Test2 »  >> « Test2 | Main

Cheers Greg


On Sat, 1 Sep 2018 at 13:57, Dave  wrote:

> I have prepared a release candidate #1 for a new release Roller v.5.2.1.
>
> The purpose of this release is to upgrade to Struts 2.5.17 which includes
> some security fixes. That is the only change in this release.
>
> You can find the release files here:
> https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.1-rc-1/
>
> I've done some smoke-testing and will upgrade my site over the next day or
> two.
> Please take a look, try it out if you have time and I will call a vote
> probably tomorrow.
>
> Thanks,
> Dave
>

Re: where can i find the controller class or package

[Greg Huber]

>(2) Then, as you said, WeblogRequestMapper is the overall entry for
>processing all request.  WeblogRequestMapper.handleRequest() will parse the
>requesting url, then find the corresponding "Action name" to process the
>request.

WeblogRequestMapper will map all requests looking for the front tier,  if
no match does a chain.doFilter(..).  If the request ends in .rol (aka
.action) will be picked up by the struts application.  The struts .action
as been replaced by .rol.

>(b) Another question is that, in class BookmarkEdit, there is "save()"
>method besides "myPrepare()" and "execute()".
>From the code,* I cannot clearly see how the save() method is called, or
>who will call save() method?*

from bookmarkEdit.jsp the save method is called via Dynamic Method
Invocation (DMI)

https://cwiki.apache.org/confluence/display/WW/Action+Configuration#ActionConfiguration-DynamicMethodInvocation

eg save is called via !save on the submit:




Cheers Greg


On 24 February 2018 at 19:02, x86 wj <wj86...@gmail.com> wrote:

> hi Greg,
>
> *1. According to your explanation, I try to express the request
> processing. *
> When a request comes in:
> (1) Firstly, several filterings will filter the request.
> (2) Then, as you said, WeblogRequestMapper is the overall entry for
> processing all request.  WeblogRequestMapper.handleRequest() will parse
> the
> requesting url, then find the corresponding "Action name" to process the
> request.
> (3) After finding the "Action name", then corresponding Action Class will
> really process the business function.  while the mapping from "action name'
> to "action class" is specified in Struts.xml.
> (4) The 'Action class' will process the logic. It firstly runs
> its myPrepare() method, then call the execution() method.
> (5)After processing the execute() method, then continue the pass the
> several filterings.
>
> The processing of an incoming request is right as what I said?
>
> *2. From the structs, each "action" corresponds to a "action class".  Aslo,
> There is more than one action is processed by the same action class.*
> For example,
>
>  class="org.apache.roller.weblogger.ui.struts2.editor.
> BookmarkEdit">
> bookmarkAdd
> bookmarkForm.add.title
> .BookmarkEdit
> bookmarks
> bookmarks
> 
>
>  class="org.apache.roller.weblogger.ui.struts2.editor.
> BookmarkEdit">
> bookmarkEdit
> bookmarkForm.edit.title
> .BookmarkEdit
> bookmarks
> 
> bookmarks
> ${weblog}
> ${folderId}
> 
> bookmarkEdit
> 
>
> (a) we can see "bookmarkAdd" and "bookmarkEdit' the two actions are both
> processed by "org.apache.roller.weblogger.ui.struts2.editor.BookmarkEdit".
> But there is only one execute() method in class BookmarkEdit. It means
> "bookmarkAdd' and "bookmarkEdit" are processed by the same execution()
> method?
> If so, *how does execute() distinguish the two different actions to process
> differently?*
>
> (b) Another question is that, in class BookmarkEdit, there is "save()"
> method besides "myPrepare()" and "execute()".
> From the code,* I cannot clearly see how the save() method is called, or
> who will call save() method?*
>
>
>
> I am new to structs and roller. A lot of details I would like to ask and
> hope make it clear.
> Thank you for your help.
> Best regards,
> Wuxia Jin
>
>
> On Sat, Feb 24, 2018 at 12:07 PM, Greg Huber <gregh3...@gmail.com> wrote:
>
> > .should be WeblogRequestMapper
> >
> > Cheers Greg
> >
> > On 24 February 2018 at 04:39, x86 wj <wj86...@gmail.com> wrote:
> >
> > > Roller is in a web architecture of "presentation -> business logic ->
> > > persistent layer". But the project is complex. From the source code, I
> > have
> > > no idea which packages(or classes) are responsible for the controller.
> > The
> > > following will list an example to express my meaning.
> > >
> > > For example, Jpetstore is a small project with only 24 classes.
> > > https://github.com/mybatis/jpetstore-6/blob/master/src/
> > > main/java/org/mybatis/jpetstore/web/actions/OrderActionBean.java
> > >
> > > This link shows that OrderActionBean is one of the controller class in
> > > web.action package.  OrderActionBean.listOrders is one function entry
> > > provided by system.
> > >
> > > So, I would like to know, in roller,* where can I find the similar
> > > 'controllerClass.method()' that clearly present function's entry*. Can
> > you
> > > give me some example?
> > >
> > > Thanks a lot for your time. I really need your help.
> > > Best regards,
> > > Wuxia Jin
> > >
> >
>

Re: where can i find the controller class or package

[Greg Huber]

.should be WeblogRequestMapper

Cheers Greg

On 24 February 2018 at 04:39, x86 wj  wrote:

> Roller is in a web architecture of "presentation -> business logic ->
> persistent layer". But the project is complex. From the source code, I have
> no idea which packages(or classes) are responsible for the controller.  The
> following will list an example to express my meaning.
>
> For example, Jpetstore is a small project with only 24 classes.
> https://github.com/mybatis/jpetstore-6/blob/master/src/
> main/java/org/mybatis/jpetstore/web/actions/OrderActionBean.java
>
> This link shows that OrderActionBean is one of the controller class in
> web.action package.  OrderActionBean.listOrders is one function entry
> provided by system.
>
> So, I would like to know, in roller,* where can I find the similar
> 'controllerClass.method()' that clearly present function's entry*. Can you
> give me some example?
>
> Thanks a lot for your time. I really need your help.
> Best regards,
> Wuxia Jin
>

Re: where can i find the controller class or package

[Greg Huber]

The back office is a struts application (struts.xml), whilst on the front
presentation tier is custom implementation.  The nearest thing to a
controller I guess would be
org/apache/roller/weblogger/ui/rendering/WebsiteRequestMapper class.

Cheers Greg

On 24 February 2018 at 04:39, x86 wj  wrote:

> Roller is in a web architecture of "presentation -> business logic ->
> persistent layer". But the project is complex. From the source code, I have
> no idea which packages(or classes) are responsible for the controller.  The
> following will list an example to express my meaning.
>
> For example, Jpetstore is a small project with only 24 classes.
> https://github.com/mybatis/jpetstore-6/blob/master/src/
> main/java/org/mybatis/jpetstore/web/actions/OrderActionBean.java
>
> This link shows that OrderActionBean is one of the controller class in
> web.action package.  OrderActionBean.listOrders is one function entry
> provided by system.
>
> So, I would like to know, in roller,* where can I find the similar
> 'controllerClass.method()' that clearly present function's entry*. Can you
> give me some example?
>
> Thanks a lot for your time. I really need your help.
> Best regards,
> Wuxia Jin
>

Re: [VOTE] Release Roller 5.2

[Greg Huber]

+1 thanks.

On 4 November 2017 at 16:03, Dave  wrote:

> Thanks Kohei.
>
> We only need one more +1 vote from a PMC member to get this release of the
> door.
>
> Greg or Matt: if you have time please weigh in!
>
> Dave
>
>
> On Thu, Nov 2, 2017 at 7:53 PM Kohei Nozaki  wrote:
>
> > Hi Dave,
> >
> > I've checked the candidate and looks fine. +1 to release.
> >
> > Thank you for your work to make this release happen!
> >
> > Kohei
> >
> > > On Oct 28, 2017, at 22:36, Dave  wrote:
> > >
> > > Thanks to Kohei and Greg for the reviews and testing! I fixed the most
> > > recent
> > > problem identified (missing method disable for action pings).
> > >
> > > And I've prepared a sixth release candidate for Roller 5.2.0. The first
> > RC
> > > depended on Struts 2.3 and this new RC-2 release depends on Struts
> > 2.5.10.1
> > > and no longer uses Dynamic Method Invocation (DMI). Because of this
> > change,
> > > a significant number of JSP pages were changed.
> > >
> > > Apart from the Struts upgrade, Roller 5.2.0 is primarily a bug fix
> > release,
> > > with lots of fixes from Kohei.
> > >
> > > You can find the release candidate here:
> > >https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.
> 2.0-rc-6/
> > >
> > > And the list of issues resolved is here:
> > >
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310906=12340980
> > >
> > > Please take a look at the release and vote this week.
> > >
> > > My vote is +1 to release.
> > >
> > > Thanks,
> > > Dave
> >
> >
>

Re: Roller 5.2.0-rc-4 available for review

[Greg Huber]

 Dave,

Went through and rechecked the allows as may have missed some from your
email on the re blog roll.  Just one more:


Method disable for action pings is not allowed!


Otherwise +1

Cheers Greg

On 15 October 2017 at 23:38, Dave <snoopd...@gmail.com> wrote:

> Thanks Greg!
>
> There is now a fifth release candiate with these changes since the last:
>- Correct Struts2 syntax for displaying currentDirectory.name on media
> file view page
>- Add missing allowed-action for blog membership "accept" action
>- Several fixes to Planet Group save, edit and delete
>- Commented out @AllowedActions annotations since they don't work
>
> You can find rc-5 here:
> https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-5/
>
> Please take a look if you have a chance. I plan to call for a vote next
> weekend.
>
> Cheers,
> Dave
>
>
> On Sun, Oct 15, 2017 at 5:58 AM Greg Huber <gregh3...@gmail.com> wrote:
>
> > Dave,
> >
> > Looks good.  The only thing are these errors in the log files :
> >
> >
> > 10:51:04.724 [http-nio-8080-exec-9] WARN
> > org.apache.struts2.util.TextProviderHelper - The first TextProvider in
> the
> > ValueStack (org.apache.roller.weblogger.ui.struts2.editor.MediaFileView)
> > could not locate the message resource with key 'currentDirectory.name'
> > 10:51:04.724 [http-nio-8080-exec-9] WARN
> > org.apache.struts2.util.TextProviderHelper - The first TextProvider in
> the
> > ValueStack (org.apache.roller.weblogger.ui.struts2.editor.MediaFileView)
> > could not locate the message resource with key 'currentDirectory.name'
> > 10:51:04.728 [http-nio-8080-exec-9] WARN
> > org.apache.struts2.util.TextProviderHelper - The default value
> expression
> > 'currentDirectory.name' was evaluated and did not match a property. The
> > literal value 'currentDirectory.name' will be used.
> >
> > Cheers Greg
> >
> >
> > On 14 October 2017 at 22:04, Dave <snoopd...@gmail.com> wrote:
> >
> > > I've prepared a fourth release candidate for Roller 5.2.0. This release
> > is
> > > primarily a bug fix release, with lots of fixes from Kohei and others.
> I
> > > have created a release candidate which you can find here:
> > >
> > >
> > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-4/
> > >
> > > And the list of issues resolved in 5.2.0 is here:
> > >
> > >
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > projectId=12310906=12340980
> > >
> > > Thanks again to Greg and Kohei for finding some issues in the previous
> > RCs.
> > > I believe I have fixed all the problems found so far. Here's what has
> > > changed since rc-3:
> > >
> > >1. Added missing Struts action names to struts.xml
> > >2. Explicity list directories to be included in release (removes
> > >extraneous files)
> > >3. Removed duplicate ROME fetcher dependency
> > >4. Fixed Maven Resource "filtering" problem in roller.properties
> > >5. Add missing log4j-core dependency, needed by Log4J2
> > >6. Reduce Log4j2 logging level to "warn" for Struts2
> > >
> > >
> > > I'm currently running this code on rollerweblogger.org and it seems to
> > be
> > > working well.
> > >
> > > Please take a look when you get a chance and I will call for a vote in
> > 3-4
> > > days.
> > >
> > > Thanks,
> > > Dave
> > >
> >
>

Re: [VOTE] Release rc-3 as Roller 5.2.0

[Greg Huber]

Dave,

Looks ok, but found some new items.

##

Needs some more allowed methods.

 eg createNewDirectory for the meda files create action.  btw, rather than
creating global-allowed-methods you can add them to the action itself in a
 :


.MediaFileView
/WEB-INF/jsps/editor/MediaFileViewLight.jsp

deleteFolder,..,createNewDirectory


Also these are needed:

Method flushCache for action maintenance is not allowed!
Method reset for action maintenance is not allowed!
Method enable for action pings is not allowed!
Method pingNow for action pings is not allowed!

##

The roller.properties in the war has hard coded stuff

mediafiles.storage.dir=/Users/dave/roller_data/mediafiles
search.index.dir=/Users/dave/roller_data/search-index

but checking the source its

mediafiles.storage.dir=${user.home}/roller_data/mediafiles
search.index.dir=${user.home}/roller_data/search-index

so not sure on this.

###

Checking the logs, other than the had coded roller.properties, no errors.


Cheers Greg


On 6 October 2017 at 13:07, Dave  wrote:

> I'm going to extend the vote over the weekend.
>
> Please review and vote!
>
> Dave
>
>
> On Sun, Oct 1, 2017 at 10:47 AM Dave  wrote:
>
> > I've prepared a third release candidate for Roller 5.2.0. This release is
> > primarily a bug fix release, with lots of fixes from Kohei. I have
> created
> > a release candidate which you can find here:
> >
> > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.
> 2.0-rc-3/
> >
> > And the list of issues resolved is here:
> >
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310906=12340980
> >
> > Thanks to Greg for finding some issues in rc-2. I believe I have fixed
> all
> > the problems that he found plus a couple more. Here's what has changed
> > since rc-2:
> >
> >1. roller.log location now default to the Catalina Base logs directory
> >2. Added cache "clear" to list of allowed Struts DMI methods
> >3. Use namespace not name in struts.xml Chained Actions
> >4. Use "var" instead of "id" for some s:iterator tags
> >5. Now shows Media File URL correctly in Media File View modal
> >
> > I'm currently running this code on rollerweblogger.org and it seems to
> be
> > working well.
> >
> > Please take a look and vote.
> >
> > Thanks,
> > Dave
> >
>

Re: [VOTE] Release rc-2 as Roller 5.2.0

[Greg Huber]

Dave,

Thinking about the logging some more, roller should expand system
properties from the roller.properties file, if you modify the entry to below


log4j.appender.roller.File=${catalina.home}/logs/roller.log

it should work.  I have tested it from the war and will log correctly to
the /opt/apache-tomcat/apache-tomcat-roller-8.5.16/logs/roller.log for me.

Cheers Greg


On 31 August 2017 at 15:23, Dave <snoopd...@gmail.com> wrote:

> On Thu, Aug 31, 2017 at 3:12 AM Greg Huber <gregh3...@gmail.com> wrote:
>
> > The logging is a bit messy nowadays with all the different distros.  We
> > could still use org.apache.commons.logging for simplicity and the use
> > log4j-jcl bridge to redirect to Log4j 2.  Just need to have have a
> > log4j2.xml file (with the jars).  Maybe I could do look at this to
> separate
> > the logging from the roller config?
> >
>
> That would be great, if you've got some time.
>
> Dave
>
>
> >
>

Re: [VOTE] Release rc-2 as Roller 5.2.0

[Greg Huber]

OK will have a go at a PR on https://github.com/apache/roller.

Cheers Greg

On 31 August 2017 at 15:23, Dave <snoopd...@gmail.com> wrote:

> On Thu, Aug 31, 2017 at 3:12 AM Greg Huber <gregh3...@gmail.com> wrote:
>
> > The logging is a bit messy nowadays with all the different distros.  We
> > could still use org.apache.commons.logging for simplicity and the use
> > log4j-jcl bridge to redirect to Log4j 2.  Just need to have have a
> > log4j2.xml file (with the jars).  Maybe I could do look at this to
> separate
> > the logging from the roller config?
> >
>
> That would be great, if you've got some time.
>
> Dave
>
>
> >
>

Re: [VOTE] Release rc-2 as Roller 5.2.0

[Greg Huber]

The logging is a bit messy nowadays with all the different distros.  We
could still use org.apache.commons.logging for simplicity and the use
log4j-jcl bridge to redirect to Log4j 2.  Just need to have have a
log4j2.xml file (with the jars).  Maybe I could do look at this to separate
the logging from the roller config?

Cheers Greg

On 31 August 2017 at 03:08, Dave <snoopd...@gmail.com> wrote:

> Thanks for taking a look Greg! I really appreciate it.
>
> I'll try to address those issues this weekend at the latest, and any other
> issues you uncover.
>
> I did look at moving to Log4j2 but it looked like too large of an effort
> (but mainly because of the way Roller expects Log4j properties to be in the
> Roller config file).
>
> Dave
>
>
> On Wed, Aug 30, 2017 at 4:12 AM Greg Huber <gregh3...@gmail.com> wrote:
>
> > Did a quick test from the war (will set up a dev environment so can do
> some
> > more testing!),  here is what i found:
> >
> > Hard coded stuff :
> >
> > roller.properties
> >
> >
> > log4j.appender.roller.File=/Applications/Java/apache-
> tomcat-8.5.9/logs/roller.log
> >
> > (maybe switch to log4j2?
> > ${sys:catalina.home}/logs)
> >
> > ##
> >
> > Media upload gives this error (but works):
> >
> > SEVERE: Servlet.service() for servlet [jsp] threw exception
> > org.apache.jasper.JasperException:
> > /WEB-INF/jsps/editor/MediaFileAddSuccess.jsp (line: [83], column: [12])
> > Attribute [id] invalid for tag [iterator] according to TLD
> >
> > 
> >
> > id="newFile" two of these!
> >
> > ###
> >
> > Menu preferences/maintenance
> >
> > Flush cache and Reset Hitcount
> >
> > >> Method flushCache for action maintenance is not allowed!
> >
> > Possibly strict-method-invocation="true" is on, so could try to add
> > allowed-methods to your struts.xml for the class
> >
> >  > Class="org.apache.roller.weblogger.ui.struts2.editor.Maintenance">
> > .Maintenance
> > flushCache,reset
> >  
> >
> > (btw your previous dmi would have worked, so there was no need to change
> > it!)
> >
> > ##
> >
> > Cheers Greg
> >
> > On 29 August 2017 at 02:10, Dave <snoopd...@gmail.com> wrote:
> >
> > > I've prepared a second release candidate for Roller 5.2.0. The first RC
> > > depended on Struts 2.3 and this new RC-2 release depends on Struts
> > 2.5.10.1
> > > and no longer uses Dynamic Method Invocation (DMI). Because of this
> > change,
> > > a significant number of JSP pages were changed.
> > >
> > > I've been testing this RC-2 release locally and on rollerweblogger.org
> > > for the past week and so far it seems stable.
> > >
> > > Apart from the Struts upgrade, Roller 5.2.0 is primarily a bug fix
> > release,
> > > with lots of fixes from Kohei.
> > >
> > > You can find the release candidate here:
> > > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.
> 2.0-rc-2
> > >
> > > And the list of issues resolved is here:
> > >
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > projectId=12310906=12340980
> > >
> > > Please take a look at the release and vote within the next 72 hours.
> > >
> > > My vote is +1 to release.
> > >
> > > Thanks,
> > > Dave
> > >
> >
>

Re: [VOTE] Release rc-2 as Roller 5.2.0

[Greg Huber]

Did a quick test from the war (will set up a dev environment so can do some
more testing!),  here is what i found:

Hard coded stuff :

roller.properties

log4j.appender.roller.File=/Applications/Java/apache-tomcat-8.5.9/logs/roller.log

(maybe switch to log4j2?
${sys:catalina.home}/logs)

##

Media upload gives this error (but works):

SEVERE: Servlet.service() for servlet [jsp] threw exception
org.apache.jasper.JasperException:
/WEB-INF/jsps/editor/MediaFileAddSuccess.jsp (line: [83], column: [12])
Attribute [id] invalid for tag [iterator] according to TLD



id="newFile" two of these!

###

Menu preferences/maintenance

Flush cache and Reset Hitcount

>> Method flushCache for action maintenance is not allowed!

Possibly strict-method-invocation="true" is on, so could try to add
allowed-methods to your struts.xml for the class


.Maintenance
flushCache,reset
 

(btw your previous dmi would have worked, so there was no need to change
it!)

##

Cheers Greg

On 29 August 2017 at 02:10, Dave  wrote:

> I've prepared a second release candidate for Roller 5.2.0. The first RC
> depended on Struts 2.3 and this new RC-2 release depends on Struts 2.5.10.1
> and no longer uses Dynamic Method Invocation (DMI). Because of this change,
> a significant number of JSP pages were changed.
>
> I've been testing this RC-2 release locally and on rollerweblogger.org
> for the past week and so far it seems stable.
>
> Apart from the Struts upgrade, Roller 5.2.0 is primarily a bug fix release,
> with lots of fixes from Kohei.
>
> You can find the release candidate here:
> https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-2
>
> And the list of issues resolved is here:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310906=12340980
>
> Please take a look at the release and vote within the next 72 hours.
>
> My vote is +1 to release.
>
> Thanks,
> Dave
>

Re: The Roller code base has been migrated to git

[Greg Huber]

Dave,

before I forget (no git setup...) Every now and then I get pages with no
colour, login/error pages etc, it seems to be the s:url where it appends
the jsession id to the url, hence it does not find the css, it needs
encode="false" to be set on the tag which seems to fix it.

/colors.css" />

/roller-ui/theme/;jsessionid=58B8826F05539500B717CF15A0599045blue/colors.css

s:url value="/roller-ui/theme/" encode="false" />

Cheers Greg.



On 10 February 2016 at 14:22, Dave  wrote:

> From Geoffrey:
>
> The Roller code base has been migrated to git:
> https://git-wip-us.apache.org/repos/asf/roller.git
>
> Both the svn tree and the git repo are currently set to read-only until you
> verify the git version looks as expected. Also, git git repo is currently
> set to send commit emails to commits@roller. If this is not the correct
> mailing list, let me know and I'll update it to the correct one.
>
> Once you verify the git repo looks as expected, I'll update the mirroring
> system on git.a.o (which will update the GitHub mirror) and I'll fix up the
> svn tree so that roller can still edit their website.
>
> See also:
> https://issues.apache.org/jira/browse/INFRA-11155
>
>
> I'll take a look later today. Let me know if you see anything wrong.
>
> Thanks,
> Dave
>

Re: Move to Git?

[Greg Huber]

Dave,

I am not really against using git, probably the way to go, just not on my
own projects.  Just prefere the svn way, tend to use the view svn compare
alot and never really got to grips with git, the compare, switching
branches etc.  Its a different way of working, too complicated/much for my
needs.

Yes the develop branch is the flow process to release.

Cheers Greg.


On 30 December 2015 at 14:42, Dave <snoopd...@gmail.com> wrote:

> On Tue, Dec 29, 2015 at 2:39 AM Greg Huber <gregh3...@gmail.com> wrote:
>
> > Don't use it my self, have tried but made just made a mess, so went back
> > to svn.  So -1 for me.
> >
> > btw, worth checking out what Struts are doing, using a develop branch,
> > beforehand.
> >
>
> How strongly do you feel about that -1 Greg?
>
> I took a quick look at Struts. They use ASF Git repo and is also able to
> accept Pull Requests via Git.
> https://struts.apache.org/submitting-patches.html.
>
> I'm not why they use a branch called "develop" instead of master, maybe
> that is part of the "Git Flow" process they are using?
>
> Dave
>
>
> On 28 December 2015 at 15:59, Dave <snoopd...@gmail.com> wrote:
> >
> > > Now that Git is officially supported by the ASF, would anybody be
> opposed
> > > to moving Roller to Git?  All we have to do is to ask the INFRA team to
> > > switch us over.
> > >
> > > My reasons for this move are mostly selfish: I prefer Git, find it
> easier
> > > to use and use it on all other projects. Also, a move to Git would make
> > it
> > > possible for us to accept GitHub pull-requests.
> > >
> > > Thoughts?
> > >
> > > Dave
> > >
> >
>

Re: Move to Git?

[Greg Huber]

+1 and thanks for the info.

Cheers Greg

On 30 December 2015 at 16:11, Nicholas Padilla <
nicho...@monstersoftwarellc.com> wrote:

> Last thing,
>
> Here is a write up by the originator of the "Git Flow" idea.
> http://nvie.com/posts/a-successful-git-branching-model/  Just to be clear,
> you end up having a master and develop branches.  The master only contains
> the approved production releases.  Features are managed in their own
> branches, using the create feature "feature", this can mean any change set
> gets a new feature branch.  When done, you finish feature and it is merged
> into develop branch.  After you are done with the versions features, they
> are all merged with develop, you can do a Release.  The Release process
> just takes the remote develop and tags it, with your provided version, and
> then merges develop with master.  That is a really quick summary of the
> process.  I am sure everyone can see the benefit behind using such a
> process.
>
>
> Thanks!
>
> Nicholas Padilla
> www.monstersoftwarellc.com
>
> “Problems cannot be solved by the same level of thinking that created
> them.”
> “Learn from yesterday, live for today, hope for tomorrow. The important
> thing is not to stop questioning.
> <
> http://thinkexist.com/quotation/learn_from_yesterday-live_for_today-hope_for/222120.html
> >
> ”
>
> Albert Einstein <http://thinkexist.com/quotes/albert_einstein/>
>
> On Wed, Dec 30, 2015 at 9:04 AM, Nicholas Padilla <
> nicho...@monstersoftwarellc.com> wrote:
>
> > Hello All!
> >
> > Been a long while since I was active in the Roller community.  Since my
> > time with Roller, I have used Git heavily.  I do believe it is the right
> > solution to managing a code base.  If you use Source Tree, a Git client
> > provided by Atlassian, you will see the Git Flow button that allows you
> to
> > manage releases, feature branches, and hot fixes.  This process was first
> > outlined by this, http://datasift.github.io/gitflow/  It was intuitive
> > and easy to use, source tree just went a step further.  I use this
> > functionality daily to manage all my versioned projects, with the GUI
> > interface it makes it hard for noobs to make mistakes (Source Tree really
> > is one of the best Git clients).
> >
> > If you choose not to use Git Flow, that is fine, but using Git is the
> > right direction.
> >
> > Theres my two cents.
> > Happy New Year!
> >
> >
> > Thanks!
> >
> > Nicholas Padilla
> > www.monstersoftwarellc.com
> >
> > “Problems cannot be solved by the same level of thinking that created
> > them.”
> > “Learn from yesterday, live for today, hope for tomorrow. The important
> > thing is not to stop questioning.
> > <
> http://thinkexist.com/quotation/learn_from_yesterday-live_for_today-hope_for/222120.html
> >
> > ”
> >
> > Albert Einstein <http://thinkexist.com/quotes/albert_einstein/>
> >
> > On Wed, Dec 30, 2015 at 7:42 AM, Dave <snoopd...@gmail.com> wrote:
> >
> >> On Tue, Dec 29, 2015 at 2:39 AM Greg Huber <gregh3...@gmail.com> wrote:
> >>
> >> > Don't use it my self, have tried but made just made a mess, so went
> back
> >> > to svn.  So -1 for me.
> >> >
> >> > btw, worth checking out what Struts are doing, using a develop branch,
> >> > beforehand.
> >> >
> >>
> >> How strongly do you feel about that -1 Greg?
> >>
> >> I took a quick look at Struts. They use ASF Git repo and is also able to
> >> accept Pull Requests via Git.
> >> https://struts.apache.org/submitting-patches.html.
> >>
> >> I'm not why they use a branch called "develop" instead of master, maybe
> >> that is part of the "Git Flow" process they are using?
> >>
> >> Dave
> >>
> >>
> >> On 28 December 2015 at 15:59, Dave <snoopd...@gmail.com> wrote:
> >> >
> >> > > Now that Git is officially supported by the ASF, would anybody be
> >> opposed
> >> > > to moving Roller to Git?  All we have to do is to ask the INFRA team
> >> to
> >> > > switch us over.
> >> > >
> >> > > My reasons for this move are mostly selfish: I prefer Git, find it
> >> easier
> >> > > to use and use it on all other projects. Also, a move to Git would
> >> make
> >> > it
> >> > > possible for us to accept GitHub pull-requests.
> >> > >
> >> > > Thoughts?
> >> > >
> >> > > Dave
> >> > >
> >> >
> >>
> >
> >
>

Re: Is it possible to invoke weblog thro' webservice

[Greg Huber]

Think the only way is via the rss feed.  I use zrssfeed.

Might want to check java/org/apache/roller/weblogger/webservices package as
there may be something there of interest.

On 20 May 2015 at 19:01, Elavarasan Muthusamy 
elavarasan.muthus...@unilogcorp.com wrote:

 Hi,

 We have requirement to show part of the blog on the home page of our
 website. We have installed Roller and configured. I am looking for some
 sort of webservice to call and get the weblog. Is it possible? If yes,
 please guide me.

 Thanks and Regards,
 Elavarasan Muthusamy (Elsan)
 Lead Software Architect
 Mobile: +1 (610) 203-3033  Work: +1 (484) 254-6623
 Email:elavarasan.muthus...@unilogcorp.commailto:
 elavarasan.muthus...@unilogcorp.com?subject=Email
 Unilog Content Solutions LLC (http://www.unilogcorp.com)


 DISCLAIMER: This communication (including any attachments) is intended
 solely for the recipient(s) named above and may contain information that is
 confidential, privileged or legally protected. Any unauthorized use or
 dissemination of this communication is strictly prohibited. If you have
 received this communication in error, please immediately notify the sender
 by return e-mail message and delete all copies of the original
 communication. Thank you for your cooperation.

Re: [VOTE] Release Roller 5.1.2

[Greg Huber]

Dave,

Looks good from general testing (crud) but the link does not show any
particular fixes that I would check for (everything is blank?).

https://issues.apache.org/jira/issues/?jql=project%20%

+1

Cheers Greg

On 19 March 2015 at 11:32, Dave snoopd...@gmail.com wrote:

 I'm going to hold the vote open for another 72 hours.

 Folks, please vote when you get a chance.

 - Dave


 On Sun, Mar 15, 2015 at 5:38 PM, Glen Mazza glen.ma...@gmail.com wrote:

  My blog's been humming along fine with it.  +1.
 
  Thanks for getting this release together.
 
  Glen
 
 
  On 03/15/2015 04:56 PM, Dave wrote:
 
  Hi Roller fans,
 
  I'm re-opening the voting on RC1. I thought there were enough issues to
  hold back the release but I think I was wrong. So...
 
  I would like to propose that we release Roller 5.1.2 based on the code
 at
  Subversion tag roller_5.1.2-rc1. You can download the source release,
  convenience binaries and signatures for the release here:
 
  https://dist.apache.org/repos/dist/dev/roller/roller-5.1/v5.1.2/
 
  The release contains a variety of mostly minor fixes which you can find
  listed here:
 
  https://issues.apache.org/jira/issues/?jql=project%20%
  3D%20ROL%20AND%20fixVersion%20%3D%205.1.2%20AND%20updated%
  20%3E%3D%20-20w%20ORDER%20BY%20updated%20DESC
 
  Please vote within the next 72 hours.
 
  I'm voting  +1
 
  Thanks,
  Dave
 
 
 

Re: [VOTE] Release Roller 5.1.2

[Greg Huber]

On my local version, I have not seen this access denied in ages.  I also
cannot remember doing any particular fixes.  If it is still happening on
roller I could do a comparison to see if there are any differences.
Although I think they are pretty much the same.


Cheers Greg.

On 4 March 2015 at 15:10, Glen Mazza glen.ma...@gmail.com wrote:

 If I could be given this weekend to test the build before voting that
 would be very helpful for me, I'm busy at work this week.  I just want to
 test locally, and then deploy my blog using the RC, and that will be enough
 for my +1.  I created a skeleton draft entry on the team blog announcing
 5.1.2 a couple of months ago, normally it has a table listing the fixed
 JIRA items, I'll go ahead and update that table this weekend, and Dave can
 use that (adding whatever blurb above it) when he does the announcement
 blog entry.

 I'm hoping that Kohei's recent change to the salt code will fix
 https://issues.apache.org/jira/browse/ROL-1818.  Greg/Kohei, could there
 be a relation?  With my blog, I'll start a draft entry, wait 20 minutes,
 and try to save it, if the problem exists with 5.1.1 but not with 5.1.2-RC1
 I think we can close the matter as resolved.

 Glen


 On 03/01/2015 08:04 PM, Kohei Nozaki wrote:

 Sorry I just found a problem to my patch which accepted in
 https://issues.apache.org/jira/browse/ROL-2063 . could you take a look
 at my new patch ROL-2063_update1.patch and comment in that JIRA?

 ROL-2063_update1.patch


 On Mar 2, 2015, at 4:56, Dave snoopd...@gmail.com wrote:

  Hi Roller fans,

 I would like to propose that we release Roller 5.1.2 based on the code at
 Subversion tag roller_5.1.2-rc1. You can download the source release,
 convenience binaries and signatures for the release here:

https://dist.apache.org/repos/dist/dev/roller/roller-5.1/v5.1.2/

 The release contains a variety of mostly minor fixes which you can find
 listed here:

 https://issues.apache.org/jira/issues/?jql=project%20%
 3D%20ROL%20AND%20fixVersion%20%3D%205.1.2%20AND%20updated%
 20%3E%3D%20-20w%20ORDER%20BY%20updated%20DESC

 Please vote within the next 72 hours.

 I'm voting  +1

 Thanks,
 Dave

Fwd: Jenkins build is back to normal : Roller #1498

[Greg Huber]

Can we not poll the SCM and if there are changes do the build, rather than
running it every day regardless of changes?

Cheers Greg.


-- Forwarded message --
From: Apache Jenkins Server jenk...@builds.apache.org
Date: 23 January 2015 at 08:55
Subject: Jenkins build is back to normal : Roller #1498
To: dev@roller.apache.org, glen.ma...@gmail.com


See https://builds.apache.org/job/Roller/1498/

Re: Fwd: Jenkins build is back to normal : Roller #1498

[Greg Huber]

I was more thinking of saving resources, and unnecessary emails, rebuilding
a project that has not changed (for weeks) is just an unnecessary
overhead.  Doing a SCM pole is much less.

Cheers Greg.

On 23 January 2015 at 10:32, Glen Mazza glen.ma...@gmail.com wrote:

 I'm unsure what the other projects do but I think the status quo is OK.
 We only get a message that everything is OK after a failure, and sometimes
 it's good to get failures because they point to problems outside of the
 code but in the Jenkins process.  We may go another three weeks with no
 emails due to consecutive success builds.

 Glen

 On 01/23/2015 03:59 AM, Greg Huber wrote:

 Can we not poll the SCM and if there are changes do the build, rather than
 running it every day regardless of changes?

 Cheers Greg.


 -- Forwarded message --
 From: Apache Jenkins Server jenk...@builds.apache.org
 Date: 23 January 2015 at 08:55
 Subject: Jenkins build is back to normal : Roller #1498
 To: dev@roller.apache.org, glen.ma...@gmail.com


 See https://builds.apache.org/job/Roller/1498/

Re: Jenkins build is still unstable: Roller » Roller webapp #1484

[Greg Huber]

Dave,

Can you update my authority?  Infra says its the PMC chair who does it.

this is the link they gave me:

http://wiki.apache.org/general/Jenkins#How_do_I_get_an_account


Cheers Greg



On 15 January 2015 at 01:14, Glen Mazza glen.ma...@gmail.com wrote:

 Greg, thanks for looking into this.  You may wish to ask Infra for
 configuration access to the Roller project at: https://builds.apache.org
 (Dave and I both have it already) so you can immediately check our
 configuration.  I can't see a user.dir there either, but there may be other
 issues, we've configured Jenkins to use Maven 3.0.5 for example, but I have
 3.1.1 on my machine.

 What you have below is excellent debugging to send off to the infra@
 mailing list or add as an Infra JIRA ticket for somebody, either Roller or
 Infra to track and fix someday.

 (Hmm, I had updated some Roller dependencies recently, I wonder if this is
 related to it...)

 Glen


 On 01/14/2015 08:49 AM, Greg Huber wrote:

 There does not seem to be any thing wrong with the roller itself, but
 there
 is a difference between the two builds:

 user.dir=/x1/jenkins/jenkins-slave/workspace/Roller
 user.dir=/home/jenkins/jenkins-slave/workspace/Roller


 last successful build:

 main:
 /home/jenkins/jenkins-slave/workspace/Roller/app/src/main/resources/sql
  [texen] Using contextProperties file:
 /home/jenkins/jenkins-slave/workspace/Roller/app/src/main/
 resources/sql/dbscripts.properties
  [texen] Generating to file
 /x1/jenkins/jenkins-slave/workspace/Roller/app/target/
 dbscripts/README.txt
 [INFO] Executed tasks
 ..
 user.dir=/x1/jenkins/jenkins-slave/workspace/Roller

 latest build:

 main:
 /home/jenkins/jenkins-slave/workspace/Roller/app/src/main/resources/sql
  [texen] Using contextProperties file:
 /home/jenkins/jenkins-slave/workspace/Roller/app/src/main/
 resources/sql/dbscripts.properties
  [texen] Generating to file
 /home/jenkins/jenkins-slave/workspace/Roller/app/target/
 dbscripts/README.txt
 [INFO] Executed tasks
 ..
 user.dir=/home/jenkins/jenkins-slave/workspace/Roller


 I had a look at my local jenkins but could not find any user.dir property.

 On 14 January 2015 at 11:36, Apache Jenkins Server 
 jenk...@builds.apache.org wrote:

  See 
 https://builds.apache.org/job/Roller/org.apache.roller$
 roller-webapp/changes

Re: Jenkins build is still unstable: Roller » Roller webapp #1484

[Greg Huber]

Glen,

Thinking about this, I think it the fact that the directory is too big or
has too many files.  If you download the target.zip all the files have a
date before 2015.

We need to add a clean to the Jenkins build:

mvn clean install

or find out why it is not clearing the target directory.

Cheers Greg


On 15 January 2015 at 01:14, Glen Mazza glen.ma...@gmail.com wrote:

 Greg, thanks for looking into this.  You may wish to ask Infra for
 configuration access to the Roller project at: https://builds.apache.org
 (Dave and I both have it already) so you can immediately check our
 configuration.  I can't see a user.dir there either, but there may be other
 issues, we've configured Jenkins to use Maven 3.0.5 for example, but I have
 3.1.1 on my machine.

 What you have below is excellent debugging to send off to the infra@
 mailing list or add as an Infra JIRA ticket for somebody, either Roller or
 Infra to track and fix someday.

 (Hmm, I had updated some Roller dependencies recently, I wonder if this is
 related to it...)

 Glen


 On 01/14/2015 08:49 AM, Greg Huber wrote:

 There does not seem to be any thing wrong with the roller itself, but
 there
 is a difference between the two builds:

 user.dir=/x1/jenkins/jenkins-slave/workspace/Roller
 user.dir=/home/jenkins/jenkins-slave/workspace/Roller


 last successful build:

 main:
 /home/jenkins/jenkins-slave/workspace/Roller/app/src/main/resources/sql
  [texen] Using contextProperties file:
 /home/jenkins/jenkins-slave/workspace/Roller/app/src/main/
 resources/sql/dbscripts.properties
  [texen] Generating to file
 /x1/jenkins/jenkins-slave/workspace/Roller/app/target/
 dbscripts/README.txt
 [INFO] Executed tasks
 ..
 user.dir=/x1/jenkins/jenkins-slave/workspace/Roller

 latest build:

 main:
 /home/jenkins/jenkins-slave/workspace/Roller/app/src/main/resources/sql
  [texen] Using contextProperties file:
 /home/jenkins/jenkins-slave/workspace/Roller/app/src/main/
 resources/sql/dbscripts.properties
  [texen] Generating to file
 /home/jenkins/jenkins-slave/workspace/Roller/app/target/
 dbscripts/README.txt
 [INFO] Executed tasks
 ..
 user.dir=/home/jenkins/jenkins-slave/workspace/Roller


 I had a look at my local jenkins but could not find any user.dir property.

 On 14 January 2015 at 11:36, Apache Jenkins Server 
 jenk...@builds.apache.org wrote:

  See 
 https://builds.apache.org/job/Roller/org.apache.roller$
 roller-webapp/changes

build fails

[Greg Huber]

Can someone please check this directory as it seems to be getting larger on
each build.  I have no access to the project configuration.

https://builds.apache.org/job/Roller/org.apache.roller$roller-webapp/ws/target/

It would be easier to check for errors if we had a clean target each time,
and also will reduce the disk.

Cheers Greg

Re: Jenkins build is still unstable: Roller » Roller webapp #1484

[Greg Huber]

There does not seem to be any thing wrong with the roller itself, but there
is a difference between the two builds:

user.dir=/x1/jenkins/jenkins-slave/workspace/Roller
user.dir=/home/jenkins/jenkins-slave/workspace/Roller


last successful build:

main:
/home/jenkins/jenkins-slave/workspace/Roller/app/src/main/resources/sql
[texen] Using contextProperties file:
/home/jenkins/jenkins-slave/workspace/Roller/app/src/main/resources/sql/dbscripts.properties
[texen] Generating to file
/x1/jenkins/jenkins-slave/workspace/Roller/app/target/dbscripts/README.txt
[INFO] Executed tasks
..
user.dir=/x1/jenkins/jenkins-slave/workspace/Roller

latest build:

main:
/home/jenkins/jenkins-slave/workspace/Roller/app/src/main/resources/sql
[texen] Using contextProperties file:
/home/jenkins/jenkins-slave/workspace/Roller/app/src/main/resources/sql/dbscripts.properties
[texen] Generating to file
/home/jenkins/jenkins-slave/workspace/Roller/app/target/dbscripts/README.txt
[INFO] Executed tasks
..
user.dir=/home/jenkins/jenkins-slave/workspace/Roller


I had a look at my local jenkins but could not find any user.dir property.

On 14 January 2015 at 11:36, Apache Jenkins Server 
jenk...@builds.apache.org wrote:

 See 
 https://builds.apache.org/job/Roller/org.apache.roller$roller-webapp/changes
 

Re: [ANNOUNCE] Apache Roller 5.1.1 released

[Greg Huber]

This is an entry?
http://rollerweblogger.org/project/entry/apache-roller-5-1-1, possibly this
webapp has not been updated to 5.1.1?

This should be fixed in 5.1.1.


On 2 October 2014 14:22, Matt Raible m...@raibledesigns.com wrote:

 The link below renders as a blank page on my iPhone. Is this a known issue?



  On Oct 1, 2014, at 22:03, Glen Mazza glen.ma...@gmail.com wrote:
 
  Blog article listing improvements over Version 5.1:
 http://rollerweblogger.org/project/entry/apache-roller-5-1-1 .
 
  It will take up to a half day though for all Apache mirrors to have this
 new version available.
 
  Regards,
  Glen
  Apache Roller Team

Re: [VOTE RESUMED] Re: [VOTE] Release Roller 5.1.1

[Greg Huber]

+1

The only thing is on ROL-2052
https://issues.apache.org/jira/browse/ROL-2052 #2 switching back to a
shared theme now overwrites your custom style sheet without any warnings,
if you have not made a backup your changes will be lost.  Automatically
overwriting against having to manually delete it, the latter seems the
safest way.   Possibly add a warning message saying to delete your custom
style sheet?


On 30 September 2014 01:48, Glen Mazza glen.ma...@gmail.com wrote:

 I'll look into those issues for the current trunk but, absent any negative
 votes for the next three hours, will go ahead and release Roller 5.1.1,
 probably on Thursday.

 Thanks,
 Glen

 On 09/29/2014 04:14 PM, Dave wrote:

 I was able to download the release files, validate the signatures and run
 the tests successfully. I did notice that there is a script copy.sh in
 the root directory of the source release, that may have been committed
 accidentally. Also, the mvn jetty:run command did start Roller properly
 as it once did. I don't think either of those things should hold back the
 release.

 - Dave


 On Fri, Sep 26, 2014 at 6:04 PM, Glen Mazza glen.ma...@gmail.com wrote:

  OK, team, I'm happy to report that ROL-2051 has been fixed also for
 custom
 themes, so we're good to go to vote again.  The link below to the
 distributions are the same, except they now have RC2 in them.

 To test the blogs with mobile/tablet devices, try your own smartphone or
 hit F12 from Google Chrome.  Some sample blogs using RC2:

 http://web-gmazza.rhcloud.com/blog/
 http://web-gmazza.rhcloud.com/frontpage/
 http://web-gmazza.rhcloud.com/fauxcoly/
 http://web-gmazza.rhcloud.com/testdual/
 http://web-gmazza.rhcloud.com/gaurav/
 http://web-gmazza.rhcloud.com/basic/

 Here's my +1.  Vote will be held through the end of Monday Eastern USA
 time.

 Regards,
 Glen


 On 09/26/2014 09:12 AM, Glen Mazza wrote:

  Hi team, I think I've figured out the problem in ROL-2051, if the theme
 is custom it will still have problems rendering on smart phones, shared
 themes work fine now but custom still needs fixing. So I'll have to -1
 this, fix the problem and get an RC2 out.   :(

 Please be careful/conservative with any commits you make in the interim
 as they will end up going into the upcoming Roller 5.1.1.

 Glen

 On 09/26/2014 09:04 AM, Glen Mazza wrote:

  Hi Team, this is a vote to release Roller 5.1.1.  Binaries and source
 are here:

 https://dist.apache.org/repos/dist/dev/roller/roller-5.1/v5.1.1/

 This patch release fixes the following problems:

 lia href=https://issues.apache.org/jira/browse/ROL-1387;ROL-
 1387/a
 - In creating tag aggregate counts (for tag clouds, etc.), count tags
 only
 from published blog entries/li
 lia href=https://issues.apache.org/jira/browse/ROL-1620;ROL-
 1620/a
 - Plus signs in Category names result in 404s for Atom and RSS
 feeds/li
 lia href=https://issues.apache.org/jira/browse/ROL-2050?
 focusedCommentId=14116588page=com.atlassian.jira.
 plugin.system.issuetabpanels:comment-tabpanel#comment-
 14116588ROL-2050/a
 - Have Design Tab default to Templates page when custom themes are
 being
 used (speeds up template customization)/li
 lia href=https://issues.apache.org/jira/browse/ROL-2051;ROL-
 2051/a
 - Themes not falling back to standard templates when mobile ones
 undefined
 (affecting ability for Roller to be read from tablets and
 smartphones.)/li
 lia href=https://issues.apache.org/jira/browse/ROL-2052;ROL-
 2052/a
 - Custom stylesheets not being updated correctly when user switches
 between
 shared and custom themes./li
 lia href=https://issues.apache.org/jira/browse/ROL-2054;ROL-
 2054/a
 - Newly saved categories not appearing on blog/li
 lia href=https://issues.apache.org/jira/browse/ROL-2055;ROL-
 2055/a
 - Comment search should be case-insensitive/li

 For ROL-2051, I confirmed with my blog that all themes that ship with
 Roller are working on smart phones, I tested using Google Chrome's
 developer tools and my own smartphone.  However, my particular
 non-packaged
 theme (Rolling from Roller extras) is working only off-and-on.  It may
 be
 related to the theme's CSS rules, I haven't investigated.  What we
 have is
 at least a radical improvement though over 5.1.0 when *none* of the
 themes
 (except the dual theme, basic-mobile) were working on non-standard
 displays.

 Dave, as mentioned in the preceding email, don't forget to update
 rollerweblogger with alter table weblog add defaultplugins
 varchar(255);
 to get you up to the official 5.1.0 database, 5.1.1 will not work
 without
 that addition.

 For the few upgrading from Roller 5.1.0 to 5.1.1, Roller is coded to
 ask
 if you want to update your database tables, still hit yes, it won't
 make
 any changes because there are none coded, it will just upgrade your
 Roller
 db version in the roller_properties table to 511.

 Note I just copied over the documentation from the 5.1.0 to 5.1.1, as
 it's undergone no changes.

 Here's my +1.  Vote will be held for 72 

Re: blogs using single-rendition themes not showing on smartphones

[Greg Huber]

ok, will look into a more reliable method of remembering the device type,
the request attribute is not good.  Possibly use something like the
SaltCache to store the value via the ip address eg 127.0.0.1 == standard.
Kind of how spring does it.

Cheers Greg.


On 5 September 2014 14:29, Dave snoopd...@gmail.com wrote:

 On Fri, Sep 5, 2014 at 3:18 AM, Greg Huber gregh3...@gmail.com wrote:

  Ok, will look into the integration / documentation.
 
  Can we drop the cookie switching?  Although nice to have, switch manually
  from standard to mobile is too troublesome to get working reliably, and
 it
  was not easy to adopt the spring logic to control this (I may have
 another
  look at the spring code to see if it is possible, think it uses too much
 of
  spring, annotation stuff, from what I remember).  Its better to use an
  agent switcher for development/viewing.
 
  Cheers Greg



 That's a *very* nice to have feature. I hate it when I'm stuck in a limited
 mobile version of a website when my tablet's screen is more than enough
 for the regular version of the site.

 - Dave

Re: blogs using single-rendition themes not showing on smartphones

[Greg Huber]

The only dependant spring class is
org.springframework.web.filter.OncePerRequestFilter on the
DeviceResolverRequestFilter which can be dropped, but does reduce the
overhead of the filter.

Tablet defaults currently to mobile.  Roller could be enhanced to use more
rendering views (standard, mobile, tablet, etc) which does make managing
the design easier (less csmess) but a whole lot more work/duplication.  I
guess why frameworks are switching to mobile first (Foundation, Bootstrap)
which makes supporting multiple devices easier (based on viewport size
rather than the actual device.

Cheers Greg


On 4 September 2014 18:43, Dave snoopd...@gmail.com wrote:

 On Wed, Sep 3, 2014 at 3:14 AM, Greg Huber gregh3...@gmail.com wrote:

  Checking the spring-mobile license it uses
  http://www.apache.org/licenses/LICENSE-2.0.
 
  So it looks ok to use, I will add a version which uses
  DeviceResolverRequestFilter and LiteDeviceResolver to determine the
 browser
  type (also its easily maintained by spring! ;) ) and which we can easily
  switch to.
 
  I have added the code Committed revision 1622172.  If it is OK I will
  update roller accordingly.


 Hi Greg,

 Seems like a good idea, despite the fact that it means more Spring ;-)

 Does this solution or your design for using it require a theme author to
 create a mobile, table-size and desktop version of every template or can an
 author just choose to provide mobile and desktop?

 - Dave

Re: blogs using single-rendition themes not showing on smartphones

[Greg Huber]

We will need to check with the original committer where the code came
from.  I could not find anything similar so rather than not be supported
I switched locally to a spring based solution.  It also is far superior
code than was previously supplied.

The tablet renders currently as a mobile, which we can change if needed to
render normal.

Cheers Greg


On 3 September 2014 14:41, Glen Mazza glen.ma...@gmail.com wrote:

 I'm not comfortable with this change at the present, I think it is too
 soon for us to move to three device support (now including tablets) and not
 a good allocation of resources, at a time that multiple device checking is
 nicely going out the window due to responsive themes and usage of media
 queries.   What we presently have, i.e., check for Mobile in the UA
 string, then check a device listing, and then fallback to standard theme if
 mobile unavailable will work for the vast majority of blogs today.  And
 such simplicity saves us time, allowing us to add more important features
 that grab more bloggers than we'd lose by not separately supporting
 tablets. Three-device support is going to require code changes throughout
 the system to support, it's not just bringing in these few classes.

 I was hoping we could just update our list of devices we presently have
 and just go with that--update one file alone.  (Where did that original
 source come from?)  There are many sources for this information, even
 JQuery will probably work because it's MIT-licensed.  Let's consider
 whether we need three-device support later, once we get user demand for it
 (and your solution looks fine for it), but I'd rather we not be maintaining
 something that our present user base isn't asking for.

 Glen

 On 09/03/2014 03:14 AM, Greg Huber wrote:

 Checking the spring-mobile license it uses
 http://www.apache.org/licenses/LICENSE-2.0.

 So it looks ok to use, I will add a version which uses
 DeviceResolverRequestFilter and LiteDeviceResolver to determine the
 browser
 type (also its easily maintained by spring! ;) ) and which we can easily
 switch to.

 I have added the code Committed revision 1622172.  If it is OK I will
 update roller accordingly.

 Cheers Greg



 On 2 September 2014 10:57, Glen Mazzaglen.ma...@gmail.com  wrote:

  No, we still support multiple renditions (i.e., basic-mobile) to be
 defined if that's what the blogger wants, for single-rendition the
 blogger
 can use either a responsive theme or even a non-responsive one (my
 smartphone just shrinks the image if it's non responsive, I can enlarge
 it
 and view chunks of the blog page.)

 The older code, if there was just the standard rendition defined, would
 make a copy of it and make the copy the mobile rendition, requiring the
 theme user to have to maintain two sets of templates even if they were
 desired to stay identical (e.g., a responsive theme).  When I took that
 out
 -- no copies unless two renditions are defined in the theme.xml -- I
 apparently didn't get the code right for the standard theme to be the
 default one.  I'll get it fixed.

 As for the browser user agent, I'm not sure if that deviceType
 parameter is something that a Roller page creates once in a browser or
 something all browsers supply regardless of the website that they are on,
 Googling isn't bringing up much on that parameter so I'm assuming the
 former.  I'm pretty much new to this particular topic.

 Glen

 On 09/02/2014 02:45 AM, Greg Huber wrote:

  If there is no mobile on the theme.xml for the theme it used to show
 the
 default, so maybe something has changed.

 The browser user agent is used to determine if its a mobile device.
 What
 I
 do is to use the jquery mobile logic i.e. LiteDeviceResolver, I can
 update
 roller but am not sure on the licensing etc on copying jquery code.  As
 you
 mentioned previously the preferred method now would be to use a
 responsive
 design, rather than a separate theme, so this is kind of parked?

 Cheers Greg


 On 2 September 2014 01:49, Glen Mazzaglen.ma...@gmail.com  wrote:

   Hi Team, I noticed today with Roller 5.1 the blogs are not rendering
 on

 smartphones (at least mine, I have a Windows 8 smartphone that uses IE
 as
 its browser) except for the combo basic-mobile theme, the only one that
 provides explicit mobile rendition types.  For the others, Roller
 just
 returns a blank screen or a 404 or similar error page.  To test, for my
 website I created 5 empty blogs, one for each theme we offer:

 https://web-gmazza.rhcloud.com/frontpage/
 https://web-gmazza.rhcloud.com/gaurav/
 https://web-gmazza.rhcloud.com/testdual/(basic-mobile).
 https://web-gmazza.rhcloud.com/frontpage/
 https://web-gmazza.rhcloud.com/fauxcoly/

 What I would like to have Roller do -- and I had incorrectly assumed
 was
 already being done -- was for Roller to fall back to the standard
 rendition type when the mobile rendition was not available, correct
 anyway if you're using a responsive theme. Searching through the code I
 think

Re: blogs using single-rendition themes not showing on smartphones

[Greg Huber]

Checking the spring-mobile license it uses
http://www.apache.org/licenses/LICENSE-2.0.

So it looks ok to use, I will add a version which uses
DeviceResolverRequestFilter and LiteDeviceResolver to determine the browser
type (also its easily maintained by spring! ;) ) and which we can easily
switch to.

I have added the code Committed revision 1622172.  If it is OK I will
update roller accordingly.

Cheers Greg



On 2 September 2014 10:57, Glen Mazza glen.ma...@gmail.com wrote:

 No, we still support multiple renditions (i.e., basic-mobile) to be
 defined if that's what the blogger wants, for single-rendition the blogger
 can use either a responsive theme or even a non-responsive one (my
 smartphone just shrinks the image if it's non responsive, I can enlarge it
 and view chunks of the blog page.)

 The older code, if there was just the standard rendition defined, would
 make a copy of it and make the copy the mobile rendition, requiring the
 theme user to have to maintain two sets of templates even if they were
 desired to stay identical (e.g., a responsive theme).  When I took that out
 -- no copies unless two renditions are defined in the theme.xml -- I
 apparently didn't get the code right for the standard theme to be the
 default one.  I'll get it fixed.

 As for the browser user agent, I'm not sure if that deviceType
 parameter is something that a Roller page creates once in a browser or
 something all browsers supply regardless of the website that they are on,
 Googling isn't bringing up much on that parameter so I'm assuming the
 former.  I'm pretty much new to this particular topic.

 Glen

 On 09/02/2014 02:45 AM, Greg Huber wrote:

 If there is no mobile on the theme.xml for the theme it used to show the
 default, so maybe something has changed.

 The browser user agent is used to determine if its a mobile device.  What
 I
 do is to use the jquery mobile logic i.e. LiteDeviceResolver, I can update
 roller but am not sure on the licensing etc on copying jquery code.  As
 you
 mentioned previously the preferred method now would be to use a responsive
 design, rather than a separate theme, so this is kind of parked?

 Cheers Greg


 On 2 September 2014 01:49, Glen Mazza glen.ma...@gmail.com wrote:

  Hi Team, I noticed today with Roller 5.1 the blogs are not rendering on
 smartphones (at least mine, I have a Windows 8 smartphone that uses IE as
 its browser) except for the combo basic-mobile theme, the only one that
 provides explicit mobile rendition types.  For the others, Roller just
 returns a blank screen or a 404 or similar error page.  To test, for my
 website I created 5 empty blogs, one for each theme we offer:

 https://web-gmazza.rhcloud.com/frontpage/
 https://web-gmazza.rhcloud.com/gaurav/
 https://web-gmazza.rhcloud.com/testdual/   (basic-mobile).
 https://web-gmazza.rhcloud.com/frontpage/
 https://web-gmazza.rhcloud.com/fauxcoly/

 What I would like to have Roller do -- and I had incorrectly assumed was
 already being done -- was for Roller to fall back to the standard
 rendition type when the mobile rendition was not available, correct
 anyway if you're using a responsive theme. Searching through the code I
 think the only change I need to do is in class RollerVelocity[1], for
 those
 getTemplate() methods that take a deviceType parameter, to attempt to get
 the standard rendition type as a fallback if the mobile deviceType was
 requested and is not available.  I'll test it.  Until a Roller 5.1.1 is
 out, users should be able to duplicate renditions in their theme.xml,
 defining the standard one as also the mobile one.

 Couple of other concerns, in our MobileDeviceRepository class, our device
 listing[2] used as a backup to determine if mobile is necessary may be
 out-of-date, I think I can Google something more recent.  Also, just to
 confirm, line #88 of that same file, checks the user agent deviceType
 parameter for standard or mobile to determine the type, but that
 parameter is not normally sent by a browser, correct?

 Regards,
 Glen

 [1] http://svn.apache.org/viewvc/roller/trunk/app/src/main/
 java/org/apache/roller/weblogger/ui/rendering/
 velocity/RollerVelocity.java?revision=1583506view=markup#l96
 [2] http://svn.apache.org/viewvc/roller/trunk/app/src/main/
 java/org/apache/roller/weblogger/ui/rendering/mobile/
 MobileDeviceRepository.java?revision=1611764view=markup#l34

Re: blogs using single-rendition themes not showing on smartphones

[Greg Huber]

Oops, sorry, the LiteDeviceResolver is Spring Mobile not jquery!

Cheers Greg


On 2 September 2014 01:49, Glen Mazza glen.ma...@gmail.com wrote:

 Hi Team, I noticed today with Roller 5.1 the blogs are not rendering on
 smartphones (at least mine, I have a Windows 8 smartphone that uses IE as
 its browser) except for the combo basic-mobile theme, the only one that
 provides explicit mobile rendition types.  For the others, Roller just
 returns a blank screen or a 404 or similar error page.  To test, for my
 website I created 5 empty blogs, one for each theme we offer:

 https://web-gmazza.rhcloud.com/frontpage/
 https://web-gmazza.rhcloud.com/gaurav/
 https://web-gmazza.rhcloud.com/testdual/   (basic-mobile).
 https://web-gmazza.rhcloud.com/frontpage/
 https://web-gmazza.rhcloud.com/fauxcoly/

 What I would like to have Roller do -- and I had incorrectly assumed was
 already being done -- was for Roller to fall back to the standard
 rendition type when the mobile rendition was not available, correct
 anyway if you're using a responsive theme. Searching through the code I
 think the only change I need to do is in class RollerVelocity[1], for those
 getTemplate() methods that take a deviceType parameter, to attempt to get
 the standard rendition type as a fallback if the mobile deviceType was
 requested and is not available.  I'll test it.  Until a Roller 5.1.1 is
 out, users should be able to duplicate renditions in their theme.xml,
 defining the standard one as also the mobile one.

 Couple of other concerns, in our MobileDeviceRepository class, our device
 listing[2] used as a backup to determine if mobile is necessary may be
 out-of-date, I think I can Google something more recent.  Also, just to
 confirm, line #88 of that same file, checks the user agent deviceType
 parameter for standard or mobile to determine the type, but that
 parameter is not normally sent by a browser, correct?

 Regards,
 Glen

 [1] http://svn.apache.org/viewvc/roller/trunk/app/src/main/
 java/org/apache/roller/weblogger/ui/rendering/
 velocity/RollerVelocity.java?revision=1583506view=markup#l96
 [2] http://svn.apache.org/viewvc/roller/trunk/app/src/main/
 java/org/apache/roller/weblogger/ui/rendering/mobile/
 MobileDeviceRepository.java?revision=1611764view=markup#l34

Re: [VOTE RESTARTED - RC3] Release Apache Roller 5.1

[Greg Huber]

 +1

btw to reinstate zapped column:

#addColumnNull(weblog defaultplugins varchar(255))
alter table weblog add column defaultplugins varchar(255) default null;


On 21 August 2014 21:46, Glen Mazza glen.ma...@gmail.com wrote:

 OK team, vote has restarted, the binaries at the link below now have RC#3
 in them.

 Code freeze has been lifted but please be very conservative about what you
 put in (ideally fixes only).

 Changes made: the default plugins option for each weblog has been restored
 (users on the settings page can designate which of the pre-installed
 plugins they want activated by default.), install guide updated in section
 10.2 to add caution on running the migration script manually, also some GUI
 changes done by Greg to handle the clearfix issue (
 http://stackoverflow.com/questions/8554043/what-is-clearfix).

 Here's my +1.  Voting will end at the end of Sunday Eastern US time.

 Regards,
 Glen


 On 08/20/2014 07:05 PM, Glen Mazza wrote:

 Hi Team,

 Here's a happy email I've been looking forward to send, a vote to release
 Roller 5.1.  The release notes below detail much of what was changed from
 Roller 5.0.x.

 Binaries for release candidate #2 are here:
 https://dist.apache.org/repos/dist/dev/roller/roller-5.1/v5.1.0/. (RC #1
 didn't last very long.)

 I'll be holding the voting through the end of Sunday to give people the
 full weekend to test if they wish, however, if you're aware of problems
 that shouldn't be postponed to a future 5.1.1 please report back as soon as
 you're aware of them.

 Please be careful with commits to trunk until the vote is closed and the
 artifacts are released; whatever you commit becomes part of 5.1.

 The user community is also encouraged to test this release candidate and
 let us know of problems that they find, but make sure to do a backup first
 of your Roller database if you wish to test against a current blog as
 Roller 5.1 makes significant nonreversable database modifications as part
 of the upgrade. Alternatively, and more safely, RC #2 can be tested with a
 new database and a test blog.

 To start the voting, here is my +1.

 Regards,
 Glen

 

 Release Notes - Apache Roller - Version 5.1

 ** Bug
 * [ROL-1118] - Problems submitting Swedish characters over the xmlrpc
 interface
 * [ROL-1241] - some items in ApplicationResources.properties
 Duplicated
 * [ROL-1273] - resource item error
 * [ROL-1346] - Weblog Calendar incorrectly assuming Sunday is first
 day of week for every locale.
 * [ROL-1414] - Email scrambler not detecting hyphens in email
 addresses
 * [ROL-1421] - Minor typos in ApplicationResources.properties
 * [ROL-1479] - Create Weblog screen only allows 30 chars in
 description
 * [ROL-1571] - missing graphic alt text
 * [ROL-1592] - Limited blogger is still able to post a group weblog
 * [ROL-1596] - Frontpage  theme lose record!
 * [ROL-1597] - Comment email notification to a user who has
 previously left a comment on the same blog (and checked the box) is not
 functioning
 * [ROL-1615] - textual errors on ApplicationResources.properties
 * [ROL-1616] - Input fields not emptied after creating a new user
 * [ROL-1638] - Problem with themes on case sensitive file systems
 * [ROL-1715] - SiteModel's getWeblogsByLetterPager not documented
 correctly
 * [ROL-1716] - a bug found when call getPopularTags with the limit=-1
 (v4 m1)
 * [ROL-1737] - The settings tab in roller does not show the email
 comments option as shown in the install document
 * [ROL-1738] - Charset of E-Mail Subject Needs to be configurable
 * [ROL-1739] - Missing constraint on weblogentrytagagg table
 * [ROL-1746] - Uploaded file names are lower-cased with AtomPub.
 * [ROL-1778] - Blog entry preview before first publish not working
 with Derby database
 * [ROL-1792] - Hit count increments with link rel=stylesheet
 type=text/css media=all href=$model.weblog.stylesheet
 * [ROL-1794] - file uploads with spaces in their names are 404ing
 (incorrect URL escaping?)
 * [ROL-1795] - Posting comments with SchemeEnforcementFilter in
 operation.
 * [ROL-1817] - login.jsp remember me check box
 * [ROL-1870] - Duplicate bookmarks not showing
 * [ROL-1925] - Patch for the bug of OpenID only authentication
 * [ROL-1927] - Roller 5 MSSQL Issues/Fixes
 * [ROL-1928] - Missing 500-to-510-migration.vm file in Roller Mobile
 branch
 * [ROL-1929] - reindexing fails if one of authors is disabled
 * [ROL-1930] - Saving Template causes Null Pointer Exception
 * [ROL-1936] - Special characters are converted to ?? when editing
 comments
 * [ROL-1952] - Roller 5.0.1 does not work with PostgreSQL 9.1
 * [ROL-1953] - mysql roller_permission insert statements not defined
 correctly in 400-to-500-migration.vm and 400-to-500-migration.sql file
 * [ROL-1954] - user weblogs cannot be managed when admin 

Re: svn commit: r1619327 - in /roller/trunk/app/src/main: java/org/apache/roller/weblogger/ui/struts2/editor/ resources/ webapp/WEB-INF/jsps/editor/ webapp/roller-ui/styles/

[Greg Huber]

It does not render correctly when there are no left hand buttons,  ie the
folder is empty.  The right div is floated so it is no longer in the box
anymore, so the div collapses not showing the background.

firefox esr 24.7.0.


On 22 August 2014 12:07, Glen Mazza glen.ma...@gmail.com wrote:

 On 08/22/2014 04:44 AM, Greg Huber wrote:

 ##

 Floating divs arbitrarily can cause errors (see has layout csmess), the
 right float causes the div background colour not to show on ff.  Why I
 removed the float previously to avoid the clearfix clug.


 Have you tested that recently to confirm this is still an issue in 2014?
 Like I said, testing my current blog (which was uploaded before you put in
 the clearfix fix) on Windows (IE, FF, and Chrome) and Ubuntu (FF and
 Chrome), I simpIy can't see the issue, the right-side buttons render all
 fine, as they also do after your clearfix fix.  I couldn't understand from
 your JSP comment why you removed the float last time as I can't reproduce
 the problem (I'm relatively new to CSS and also didn't understand the
 clearfix thing), but even if clearfix were an issue today, it's more
 important to do that hack that you put in (thanks) as IMO it makes sense
 and looks nicer for certain, more destructive buttons like delete to be on
 the right side.  This is not a functionality issue (where we may need to
 make adjustments for older browsers to get them to work) but an UI design
 one, meaning we can put more weight on having Roller look sharp on modern
 browsers than to have it look suboptimal on the current ones in order to
 improve appearance on older ones.

 Glen

Re: svn commit: r1619327 - in /roller/trunk/app/src/main: java/org/apache/roller/weblogger/ui/struts2/editor/ resources/ webapp/WEB-INF/jsps/editor/ webapp/roller-ui/styles/

[Greg Huber]

Glen,

OK, will try to remember the cancel() in UIAction.

##

Floating divs arbitrarily can cause errors (see has layout csmess), the
right float causes the div background colour not to show on ff.  Why I
removed the float previously to avoid the clearfix clug.

Cheers Greg.


On 21 August 2014 17:45, Glen Mazza glen.ma...@gmail.com wrote:


 On 08/21/2014 05:39 AM, ghu...@apache.org wrote:

 Modified: roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/MediaFileAdd.java
 URL:http://svn.apache.org/viewvc/roller/trunk/app/src/
 main/java/org/apache/roller/weblogger/ui/struts2/editor/
 MediaFileAdd.java?rev=1619327r1=1619326r2=1619327view=diff
 
 ==
 --- roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/MediaFileAdd.java (original)
 +++ roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/MediaFileAdd.java Thu Aug 21 09:39:05 2014
 @@ -19,11 +19,11 @@ package org.apache.roller.weblogger.ui.s
 import java.io.File;
   import java.io.FileInputStream;
 -
   import java.util.ArrayList;
   import java.util.Arrays;
   import java.util.Iterator;
   import java.util.List;
 +
   import org.apache.commons.lang3.StringUtils;
   import org.apache.commons.logging.Log;
   import org.apache.commons.logging.LogFactory;
 @@ -248,6 +248,15 @@ public class MediaFileAdd extends MediaF
   addError(error.upload.disabled);
   }
   }
 +
 +/**
 + * Cancel.
 + *
 + * @return the string
 + */
 +public String cancel() {
 +return CANCEL;
 +}



 Just FYI, not necessary, as cancel() is defined as above in UIAction, for
 any action needing it.



 Modified: roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/
 Bookmarks.jsp
 URL:http://svn.apache.org/viewvc/roller/trunk/app/src/
 main/webapp/WEB-INF/jsps/editor/Bookmarks.jsp?rev=
 1619327r1=1619326r2=1619327view=diff
 
 ==
 --- roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/Bookmarks.jsp
 (original)
 +++ roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/Bookmarks.jsp
 Thu Aug 21 09:39:05 2014
 @@ -153,7 +153,7 @@ function onMove()
   /s:else
   /table
   -div class=control
 +div class=control group
   s:if test=folder.bookmarks.size  0
   %-- Delete-selected button --%
   input type=button value=s:text
 name=bookmarksForm.delete/ onclick=onDelete();return false; /
 @@ -168,6 +168,7 @@ function onMove()
   /s:if
 s:if test=folder.name != 'default'
 +!-- need a group (above) clearfix to use this float
 correctly --
   span style=float:right
   s:submit value=%{getText('bookmarksForm.deleteFolder')}
 action=bookmarks!deleteFolder onclick=onDeleteFolder();return
 false;/
   /span


 Boo Hiss. group is way too generic a name for a class, call it
 clearfix or something.  I'll fix it...

 I never heard of the clearfix problem until googling it this morning, the
 latest Firefox and Chrome browsers have no problem with it.  Which browsers
 are you using that require the clearfix hack?

 Cheers,
 Glen

Re: code freeze...

[Greg Huber]

oops sorry, made a commit.


On 20 August 2014 17:42, Glen Mazza glen.ma...@gmail.com wrote:

 If people could refrain from svn commits today, I'm making the 1st rc
 right now.

 Thanks,
 Glen

Re: [VOTE] Release Apache Roller 5.1

[Greg Huber]

Glen,

On upgrading/testing.

##

One of my databases failed on this statement on the upgrade. The index did
not exist.

ALTER TABLE bookmark_folder DROP INDEX folder_namefolderid_uq;

Its does mention it may not exist.

##

Formatting section on preference | settings

Not sure on this now, maybe needs to be removed from WeblogConfig.jsp as
bean.defaultPluginsArray has been removed.

s:if test=!pluginsList.isEmpty
tr
td class=labels:text name=websiteSettings.label1 / br
/s:text name=websiteSettings.label2 //td
td class=field
s:checkboxlist theme=roller list=pluginsList
name=bean.defaultPluginsArray listKey=name listValue=name /

/td
td class=description%-- s:text
name=websiteSettings.tip. / --%/td
/tr
/s:if
s:else
s:hidden name=defaultPlugins /
/s:else



On 21 August 2014 00:05, Glen Mazza glen.ma...@gmail.com wrote:

 Hi Team,

 Here's a happy email I've been looking forward to send, a vote to release
 Roller 5.1.  The release notes below detail much of what was changed from
 Roller 5.0.x.

 Binaries for release candidate #2 are here: https://dist.apache.org/repos/
 dist/dev/roller/roller-5.1/v5.1.0/. (RC #1 didn't last very long.)

 I'll be holding the voting through the end of Sunday to give people the
 full weekend to test if they wish, however, if you're aware of problems
 that shouldn't be postponed to a future 5.1.1 please report back as soon as
 you're aware of them.

 Please be careful with commits to trunk until the vote is closed and the
 artifacts are released; whatever you commit becomes part of 5.1.

 The user community is also encouraged to test this release candidate and
 let us know of problems that they find, but make sure to do a backup first
 of your Roller database if you wish to test against a current blog as
 Roller 5.1 makes significant nonreversable database modifications as part
 of the upgrade.  Alternatively, and more safely, RC #2 can be tested with a
 new database and a test blog.

 To start the voting, here is my +1.

 Regards,
 Glen

 

 Release Notes - Apache Roller - Version 5.1

 ** Bug
 * [ROL-1118] - Problems submitting Swedish characters over the xmlrpc
 interface
 * [ROL-1241] - some items in ApplicationResources.properties
 Duplicated
 * [ROL-1273] - resource item error
 * [ROL-1346] - Weblog Calendar incorrectly assuming Sunday is first
 day of week for every locale.
 * [ROL-1414] - Email scrambler not detecting hyphens in email addresses
 * [ROL-1421] - Minor typos in ApplicationResources.properties
 * [ROL-1479] - Create Weblog screen only allows 30 chars in description
 * [ROL-1571] - missing graphic alt text
 * [ROL-1592] - Limited blogger is still able to post a group weblog
 * [ROL-1596] - Frontpage  theme lose record!
 * [ROL-1597] - Comment email notification to a user who has previously
 left a comment on the same blog (and checked the box) is not functioning
 * [ROL-1615] - textual errors on ApplicationResources.properties
 * [ROL-1616] - Input fields not emptied after creating a new user
 * [ROL-1638] - Problem with themes on case sensitive file systems
 * [ROL-1715] - SiteModel's getWeblogsByLetterPager not documented
 correctly
 * [ROL-1716] - a bug found when call getPopularTags with the limit=-1
 (v4 m1)
 * [ROL-1737] - The settings tab in roller does not show the email
 comments option as shown in the install document
 * [ROL-1738] - Charset of E-Mail Subject Needs to be configurable
 * [ROL-1739] - Missing constraint on weblogentrytagagg table
 * [ROL-1746] - Uploaded file names are lower-cased with AtomPub.
 * [ROL-1778] - Blog entry preview before first publish not working
 with Derby database
 * [ROL-1792] - Hit count increments with link rel=stylesheet
 type=text/css media=all href=$model.weblog.stylesheet
 * [ROL-1794] - file uploads with spaces in their names are 404ing
 (incorrect URL escaping?)
 * [ROL-1795] - Posting comments with SchemeEnforcementFilter in
 operation.
 * [ROL-1817] - login.jsp remember me check box
 * [ROL-1870] - Duplicate bookmarks not showing
 * [ROL-1925] - Patch for the bug of OpenID only authentication
 * [ROL-1927] - Roller 5 MSSQL Issues/Fixes
 * [ROL-1928] - Missing 500-to-510-migration.vm file in Roller Mobile
 branch
 * [ROL-1929] - reindexing fails if one of authors is disabled
 * [ROL-1930] - Saving Template causes Null Pointer Exception
 * [ROL-1936] - Special characters are converted to ?? when editing
 comments
 * [ROL-1952] - Roller 5.0.1 does not work with PostgreSQL 9.1
 * [ROL-1953] - mysql roller_permission insert statements not defined
 correctly in 400-to-500-migration.vm and 400-to-500-migration.sql file
 * [ROL-1954] - user weblogs cannot be managed when admin logs in and
 select any user via Server 

ampersand on search text

[Greg Huber]

Glen,

When I do a search containing and ampersand, roller does not show correctly
the returned text.

eg

bz

actually returns :bamp;amp;z

which renders  as bamp;z

It should return bamp;z with no second ampersand for it to render
correctly.

Checking the method getTerm() it does a double escape, where the
StringEscapeUtils.escapeXml(..) adds the extra  amp; causing it not to show
correctly :

SearchResultsModel():

public String getTerm() {
String query = searchRequest.getQuery();
return (query == null)
?  : StringEscapeUtils.escapeXml(Utilities.escapeHTML(query));
}

Do we need the double escape? For XSS?  StringEscapeUtils.escapeXml() or
how do we make it render correctly?


Cheers Greg.

Re: More theme ideas for Roller 5.1...

[Greg Huber]

If you are embedding html elements in entries, jqm might try to enhance
them, and you will need to experiment some what, you could try to disable
the enhancement on the embeded html using something like data-enhance=false.


On 5 July 2014 23:22, Glen Mazza glen.ma...@gmail.com wrote:

 Problem mentioned below reproduced with both Chrome and Firefox, BTW.

 Glen

 On 07/05/2014 06:16 PM, Glen Mazza wrote:

 Both good and bad HTML work fine, as mentioned earlier, but the real
 problem is that the paragraph at the top ends up getting truncated after
 the first line, there's no word wrapping, text is lost.  If I remove the
 enclosing p element around the paragraph the text renders fine in mobile
 though. So that's the only thing I can see needing fixing with Mobile.

 Regards,
 Glen

Re: Roller UI Ideas (Was Re: ApacheCon CFP closes June 25)

[Greg Huber]

What I could will do is add an element into the theme.xml to control
whether there is a second theme available for the templating engine, and
update the theme/stylesheet edit classes accordingly to not show the mobile
tab.

I think these edit programs use the YUI css tab.  Are we sticking with YUI?


On 4 July 2014 02:05, Glen Mazza glen.ma...@gmail.com wrote:

 On 07/03/2014 04:07 AM, Greg Huber wrote:

 The mobile theme will switch automatically if you view with a mobile
 device, the button is there as a preview and example.  Use an user agent
 switcher.


 Thanks, I did not realize that, and it would be nice for Roller to
 architecturally maintain that functionality for users who would that
 capability.  I also like how its theme.xml shows how multiple themes can be
 bundled together.

 Glen

Re: Roller UI Ideas (Was Re: ApacheCon CFP closes June 25)

[Greg Huber]

5.) Shelan, another contributor around 2010 created a mobile weblog view
for a blog, as you can see in the upper-right corner here:
http://www.nailedtothex.org/roller/kyle/entry/nested-list-element-issue-of1
.  The mobile theme doesn't seem to work right today (that blog entry at
that link shows the problems with it, the blogger had to make changes
basically making it a standard blog anyway, and even with those changes I
saw further errors with it.)  What Shelan did was very nice circa 2010
(before Bootstrap existed) but might be frowned upon today, I think one is
expected to use a responsive theme today when you want to support all types
of devices, rather than have (antiquated?) click here for mobile and
click here for standard buttons.  Unsure, but we may wish to pull this
out of the basic theme once fauxcoly and gaurav are better established.

The mobile theme will switch automatically if you view with a mobile
device, the button is there as a preview and example.  Use an user agent
switcher.

I guess mobile first will become the standard, but what I like about the
separate theme you can still use your investment in your existing design
(desktop) and then a responsive design for the mobile/tablets, where you
can target more the mobile devices rather than one fits all design (which
tend to be more mobile centric than desktop).  Yes more work but for roller
the themes are quite simple.

Surfing an a mobile?  hmm, think apps are the way to go as you get more
lockin and a much better user experience.  ...a whole lot more work and
complexity however.


On 3 July 2014 02:49, Glen Mazza glen.ma...@gmail.com wrote:

 Hi Gaurav, I've been working heavily on the backend and am thankfully
 getting to a point where I can look more at the frontend.  We may need to
 release Roller 5.1 just to get retire the 5.0.x series -- front-end looks
 very similar, but back-end is much cleaner and faster to build, lower
 maintenance, etc.  So Roller 5.1 is at least standing on a good foundation,
 even if the UI themes need some work.

 Some of the UI things I'd like to see done (some may get into 5.1, some
 may in a subsequent patch release), regardless of who does them, are as
 follows:

 1.) Both the gaurav and fauxcoly themes OOTB say here's the top 30 tags
 for this blog, but that doesn't help a starting blogger who has just one
 or two blog entries and next to no tags--the blog looks bad that way.  A
 blog theme should look good from day one even if the blogger has just a few
 blog entries.  I'd like to see the tag stuff removed and have it replaced
 with either the blogroll, ATOM feeds, or something else.  One idea is to
 move the top horizontal menu line providing archives, login, buttons to the
 side and include categories in the top horizontal line instead.

 2.) The fauxcoly theme uses YUI (Yahoo User Interface) stored in
 webapp/roller-ui/yui, but the YUI is from 2009.  I'd like to have it
 replaced with the latest release YUI.  The YUI we ship with Roller is not
 just for fauxcoly, but for any YUI-based custom theme a user may wish to
 create (by keeping it in roller-ui/yui a new theme creator doesn't have to
 bother importing all the YUI files with his theme.)  Also, if the theme can
 be tweaked a bit to be responsive while using YUI still that would be good.

 3.) The gaurav theme of course uses Bootstrap and JQuery.  Likewise,
 rather than directly incorporate that stuff in the gaurav theme, I'd like
 to have it placed under webapp/roller-ui/bootstrap and have the gaurav
 theme reference those files from there.  That way, again, anyone can come
 up with their own Bootstrap-based theme without needing to upload all the
 Bootstrap files.

 4.) Both the gaurav and fauxcoly themes duplicate an icons folder having
 all the social media bitmaps for Facebook, Twitter, LinkedIn, etc.  I'd
 like to see those icons stored in one place, maybe roller-ui/icons or
 /socialmedia or whatever, so themes can reference those icons without
 needing to duplicate them into their themes.

 5.) Shelan, another contributor around 2010 created a mobile weblog view
 for a blog, as you can see in the upper-right corner here:
 http://www.nailedtothex.org/roller/kyle/entry/nested-list-
 element-issue-of1 .  The mobile theme doesn't seem to work right today
 (that blog entry at that link shows the problems with it, the blogger had
 to make changes basically making it a standard blog anyway, and even with
 those changes I saw further errors with it.)  What Shelan did was very nice
 circa 2010 (before Bootstrap existed) but might be frowned upon today, I
 think one is expected to use a responsive theme today when you want to
 support all types of devices, rather than have (antiquated?) click here
 for mobile and click here for standard buttons.  Unsure, but we may wish
 to pull this out of the basic theme once fauxcoly and gaurav are better
 established.

 6.) Our website is old-fashioned, perhaps about 50% of Apache websites are
 now using 

Re: [VOTE] Release Roller 5.0.4 - rc2

[Greg Huber]

Depreciated here would mean not supported, hence the warning messages, on
this version of struts.


On 23 June 2014 13:51, Glen Mazza glen.ma...@gmail.com wrote:

 Deprecation is OK, I'll see if I can take care of that if we have a future
 5.0.5, I'm also a bit concerned about making a change that might break
 parts of 5.0.x, and hence would need massive coding to fix (lots of
 libraries in 5.0.x are old).  I want to be coding and releasing 5.1, and
 5.0.x keeps me from that.

 Glen

 On 06/23/2014 03:32 AM, Greg Huber wrote:

 +1
 Struts upgrade works ok.


 

 Might be worth having a check on the templates on
 /resources/template/roller/*.ftl.  (copy from trunk)

 

 There are some warnings on the web.xml entries for struts:

  FilterDispatcher  is deprecated! Please use the new filters!

 ie change from:

 filter
  filter-namestruts2/filter-name

 filter-classorg.apache.struts2.dispatcher.FilterDispatcher/filter-
 class
 /filter

 to:

 filter
  filter-namestruts2/filter-name

 filter-classorg.apache.struts2.dispatcher.ng.filter.
 StrutsPrepareAndExecuteFilter/filter-class
 /filter

  ActionContextCleanUp  is deprecated! Please use the new filters!

 remove:

 filter
  filter-namestruts2-cleanup/filter-name

 filter-classorg.apache.struts2.dispatcher.ActionContextCleanUp/filter-
 class
 /filter



 On 22 June 2014 04:12, Glen Mazza glen.ma...@gmail.com wrote:

  OK, team, second attempt, fixing the problems Greg noted from the last
 vote.  I tested the Tomcat version again and it seemed to work all well,
 validation also working this time.

 Here is my +1.  Vote for another 72 hours.

 Binaries:  people.apache.org/~gmazza/roller/rc2

 SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/

 Regards,
 Glen


    Original Message 

 On 6/7/2014 11:44 PM, Glen Mazza wrote:

  Hi Team,

 This is a vote to release Roller 5.0.4, it upgrades its Struts library
 to 2.3.16.3 to fix some important issues with it; also, some of the
 LDAP configuration was fixed based on comments from a user.

 Binaries are here:  http://people.apache.org/~gmazza/roller/

 I tested the Tomcat version, it looks good.

 Here's my +1.  Voting will be for 72 hours.

 Regards,
 Glen

Re: Updates to 5.0.4... (Was svn commit: r1602793 - in /roller/branches/roller_5.0/weblogger-web/src/main/resources: ./ org/apache/roller/weblogger/ui/struts2/core/ org/apache/roller/weblogger/ui/stru

[Greg Huber]

Glen,

If you download the latest source for 2.3.16.3, (or somehow find it in the
git ) you can see its:

!-- Basic stack --
interceptor-stack name=basicStack
interceptor-ref name=exception/
interceptor-ref name=servletConfig/
interceptor-ref name=prepare/
interceptor-ref name=checkbox/
interceptor-ref name=multiselect/
interceptor-ref name=actionMappingParams/
interceptor-ref name=params
param
name=excludeParams^action:.*,^method:.*/param
/interceptor-ref
interceptor-ref name=conversionError/
interceptor-ref name=deprecation/
/interceptor-stack

I will download and do another test.

Greg


On 16 June 2014 04:22, Glen Mazza glen.ma...@gmail.com wrote:

 Hi Greg (and anyone else), I updated 5.0.4 per your comments last week,
 note the struts.xml (viewable at the bottom here) was updated using the
 full params string in the Struts' default struts.xml (
 http://struts.apache.org/release/2.3.x/docs/struts-defaultxml.html), as
 you wrote As we have our own default struts xml, its best to copy the
 settings from the default xml supplied with the latest version of struts.
 The parameter interceptor was the reason for the security upgrade.

 The app seems to run fine and the validators are working again. Is there
 anything visually you see wrong below?  If not, I'll go ahead and make new
 ZIPs and hold another vote.

 (Also the struts.xml change will probably need to go into the
 5.1-SNAPSHOT.  We may be due for a full struts.xml overhaul, but I'd like
 to keep that in the 5.1.0-SNAPSHOT branch if I can.)

 Regards,
 Glen


 On 06/15/2014 11:13 PM, gma...@apache.org wrote:

 Author: gmazza
 Date: Mon Jun 16 03:13:27 2014
 New Revision: 1602793

 URL: http://svn.apache.org/r1602793
 Log:
 Updated validators, struts.xml per Greg's last comments.

 Modified:
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/
 CreateWeblog-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/
 Profile-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 BookmarkAdd-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 BookmarkEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 CategoryAdd-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 CategoryEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 EntryAdd-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 EntryEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 FolderAdd-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 FolderEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 MediaFileEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 TemplateEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 WeblogConfig-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/struts.xml

 Modified: roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/
 CreateWeblog-validation.xml
 URL: http://svn.apache.org/viewvc/roller/branches/roller_5.0/
 weblogger-web/src/main/resources/org/apache/roller/
 weblogger/ui/struts2/core/CreateWeblog-validation.xml?
 rev=1602793r1=1602792r2=1602793view=diff
 
 ==
 --- roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/CreateWeblog-validation.xml
 (original)
 +++ roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/CreateWeblog-validation.xml
 Mon Jun 16 03:13:27 2014
 @@ -1,5 +1,6 @@
 -!DOCTYPE validators PUBLIC -//OpenSymphony Group//XWork Validator
 1.0.2//EN
 -   http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd;
 +!DOCTYPE validators PUBLIC
 +-//Apache Struts//XWork Validator 1.0.3//EN
 +http://struts.apache.org/dtds/xwork-validator-1.0.3.dtd;
   

Re: Updates to 5.0.4... (Was svn commit: r1602793 - in /roller/branches/roller_5.0/weblogger-web/src/main/resources: ./ org/apache/roller/weblogger/ui/struts2/core/ org/apache/roller/weblogger/ui/stru

[Greg Huber]

Glen,

The download seems to have the same date?

 roller-weblogger-5.0.4-for-tomcat.tar.gz
http://people.apache.org/%7Egmazza/roller/roller-weblogger-5.0.4-for-tomcat.tar.gz
08-Jun-2014 02:48   31M


Is there another test build?

Greg


On 16 June 2014 04:22, Glen Mazza glen.ma...@gmail.com wrote:

 Hi Greg (and anyone else), I updated 5.0.4 per your comments last week,
 note the struts.xml (viewable at the bottom here) was updated using the
 full params string in the Struts' default struts.xml (
 http://struts.apache.org/release/2.3.x/docs/struts-defaultxml.html), as
 you wrote As we have our own default struts xml, its best to copy the
 settings from the default xml supplied with the latest version of struts.
 The parameter interceptor was the reason for the security upgrade.

 The app seems to run fine and the validators are working again. Is there
 anything visually you see wrong below?  If not, I'll go ahead and make new
 ZIPs and hold another vote.

 (Also the struts.xml change will probably need to go into the
 5.1-SNAPSHOT.  We may be due for a full struts.xml overhaul, but I'd like
 to keep that in the 5.1.0-SNAPSHOT branch if I can.)

 Regards,
 Glen


 On 06/15/2014 11:13 PM, gma...@apache.org wrote:

 Author: gmazza
 Date: Mon Jun 16 03:13:27 2014
 New Revision: 1602793

 URL: http://svn.apache.org/r1602793
 Log:
 Updated validators, struts.xml per Greg's last comments.

 Modified:
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/
 CreateWeblog-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/
 Profile-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 BookmarkAdd-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 BookmarkEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 CategoryAdd-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 CategoryEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 EntryAdd-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 EntryEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 FolderAdd-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 FolderEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 MediaFileEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 TemplateEdit-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/editor/
 WeblogConfig-validation.xml
  roller/branches/roller_5.0/weblogger-web/src/main/
 resources/struts.xml

 Modified: roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/
 CreateWeblog-validation.xml
 URL: http://svn.apache.org/viewvc/roller/branches/roller_5.0/
 weblogger-web/src/main/resources/org/apache/roller/
 weblogger/ui/struts2/core/CreateWeblog-validation.xml?
 rev=1602793r1=1602792r2=1602793view=diff
 
 ==
 --- roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/CreateWeblog-validation.xml
 (original)
 +++ roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/CreateWeblog-validation.xml
 Mon Jun 16 03:13:27 2014
 @@ -1,5 +1,6 @@
 -!DOCTYPE validators PUBLIC -//OpenSymphony Group//XWork Validator
 1.0.2//EN
 -   http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd;
 +!DOCTYPE validators PUBLIC
 +-//Apache Struts//XWork Validator 1.0.3//EN
 +http://struts.apache.org/dtds/xwork-validator-1.0.3.dtd;
   validators
 field name=bean.handle

 Modified: roller/branches/roller_5.0/weblogger-web/src/main/
 resources/org/apache/roller/weblogger/ui/struts2/core/
 Profile-validation.xml
 URL: http://svn.apache.org/viewvc/roller/branches/roller_5.0/
 weblogger-web/src/main/resources/org/apache/roller/
 weblogger/ui/struts2/core/Profile-validation.xml?rev=
 1602793r1=1602792r2=1602793view=diff
 
 ==
 --- roller/branches/roller_5.0/weblogger-web/src/main/
 

Re: [WITHDRAWN][BOO HISS]Re: [VOTE] Release Roller 5.0.4

[Greg Huber]

struts.xml :

from:
interceptor-ref name=params
  param name=excludeParamsdojo\..*/param
/interceptor-ref

to:
interceptor-ref name=params
  param name=excludeParams^action:.*,^method:.*/param
/interceptor-ref

As we have our own default struts xml, its best to copy the settings from
the default xml supplied with the latest version of struts.  The parameter
interceptor was the reason for the security upgrade.


On 10 June 2014 01:56, Glen Mazza glen.ma...@gmail.com wrote:

 OK, I'll get the validation files fixed, re-release and hold another vote.
  Unless it's an immediate, clear fix I'll skip the deprecated warnings you
 mention at the bottom, it's a given that 5.0.4 has old libraries but the
 solution is to get 5.1 out rather than spend time trying to make 5.0.4 the
 same as 5.1.

 BTW, between the ## signs below you mention struts.xml -- I'm unsure what
 you're trying to say there--do I need to update the struts.xml as well?

 Thanks,
 Glen

 On 6/9/2014 10:23 AM, Greg Huber wrote:

 Glen,

 The validator does not work,

 ERROR 2014-06-09 13:55:47,277 CommonsLogger:error - Caught exception while
 loading file
 org/apache/roller/weblogger/ui/struts2/editor/EntryAdd-validation.xml
 http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd - Class:
 sun.net.www.protocol.http.HttpURLConnection

 the dtd on the struts validation.xml files needs to be changed to match
 the
 one on the version of struts uses ie

 !DOCTYPE validators PUBLIC
  -//Apache Struts//XWork Validator 1.0.3//EN
  http://struts.apache.org/dtds/xwork-validator-1.0.3.dtd;

 ##

 struts.xml :

 interceptor-ref name=params
param name=excludeParamsdojo\..*/param
  /interceptor-ref

 interceptor-ref name=params
  param
 name=excludeParams^action:.*,^method:.*/param
  /interceptor-ref

 

 There are some other warnings also, but not that important,

  ActionContextCleanUp  is deprecated! Please use the new filters!
 FilterDispatcher  is deprecated! Please use the new filters!



 On 9 June 2014 11:37, Glen Mazza glen.ma...@gmail.com wrote:

  OK, apparently voting is done on DEV and not the private list (not that
 the latter emailing system appeared to be accepting my emails anyway...)
   Vote is below and I'm resetting the 72 hour clock to zero.

 Thanks,
 Glen


  Original Message 

 On 6/7/2014 11:44 PM, Glen Mazza wrote:

  Hi Team,

 This is a vote to release Roller 5.0.4, it upgrades its Struts library
 to 2.3.16.3 to fix some important issues with it; also, some of the
 LDAP configuration was fixed based on comments from a user.

 Binaries are here:  http://people.apache.org/~gmazza/roller/

 I tested the Tomcat version, it looks good.

 Here's my +1.  Voting will be for 72 hours.

 Regards,
 Glen

Re: Remaining JIRAs for Roller 5.1

[Greg Huber]

Glen,

How do I edit the page to remove completed ROL's? as per instructions.


On 9 June 2014 01:53, Glen Mazza glen.ma...@gmail.com wrote:

 Hi team, I made a list of the 16 (of the presently 84 open) JIRAs I'd like
 to see done before we release Roller 5.1:

 https://cwiki.apache.org/confluence/display/ROLLER/
 Apache+Roller+5.1+Release

 None of them involve any further database changes, so the 5.1 Roller DB
 appears good to go as-is.  Feel free to add additional JIRA items or other
 comments to the above page.  I'll be working on these but any
 patches/commits from others would also be great.  Note no commits, please,
 until Dave is finished merging the new Propono into trunk.

 Regards,
 Glen

Re: Remaining JIRAs for Roller 5.1

[Greg Huber]

I was waiting for the OK to commit stuff.I try and fix some more.


On 9 June 2014 10:40, Glen Mazza glen.ma...@gmail.com wrote:

 Actually we should still wait on commits until Dave is finished merging
 branch into trunk.  Hopefully he can import your small commit fixing
 ROL-2002.

 Glen

 On 6/9/2014 5:28 AM, Glen Mazza wrote:

 Awesome, one less bug.  :)  If logging in doesn't give you write access,
 enter the problem in the Infra JIRA, maybe giving a link to our people page
 to show you're a PMC member.  (That happened to me also recently and it
 took them a day or so to give me write access again--I think we all lost
 our write access at that point.)

 Glen

 On 6/9/2014 5:18 AM, Greg Huber wrote:

 Glen,

 How do I edit the page to remove completed ROL's? as per instructions.


 On 9 June 2014 01:53, Glen Mazza glen.ma...@gmail.com wrote:

  Hi team, I made a list of the 16 (of the presently 84 open) JIRAs I'd
 like
 to see done before we release Roller 5.1:

 https://cwiki.apache.org/confluence/display/ROLLER/
 Apache+Roller+5.1+Release

 None of them involve any further database changes, so the 5.1 Roller DB
 appears good to go as-is.  Feel free to add additional JIRA items or
 other
 comments to the above page.  I'll be working on these but any
 patches/commits from others would also be great.  Note no commits,
 please,
 until Dave is finished merging the new Propono into trunk.

 Regards,
 Glen

Re: [VOTE] Release Roller 5.0.4

[Greg Huber]

Glen,

The validator does not work,

ERROR 2014-06-09 13:55:47,277 CommonsLogger:error - Caught exception while
loading file
org/apache/roller/weblogger/ui/struts2/editor/EntryAdd-validation.xml
http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd - Class:
sun.net.www.protocol.http.HttpURLConnection

the dtd on the struts validation.xml files needs to be changed to match the
one on the version of struts uses ie

!DOCTYPE validators PUBLIC
-//Apache Struts//XWork Validator 1.0.3//EN
http://struts.apache.org/dtds/xwork-validator-1.0.3.dtd;

##

struts.xml :

interceptor-ref name=params
  param name=excludeParamsdojo\..*/param
/interceptor-ref

interceptor-ref name=params
param
name=excludeParams^action:.*,^method:.*/param
/interceptor-ref



There are some other warnings also, but not that important,

 ActionContextCleanUp  is deprecated! Please use the new filters!
 FilterDispatcher  is deprecated! Please use the new filters!



On 9 June 2014 11:37, Glen Mazza glen.ma...@gmail.com wrote:

 OK, apparently voting is done on DEV and not the private list (not that
 the latter emailing system appeared to be accepting my emails anyway...)
  Vote is below and I'm resetting the 72 hour clock to zero.

 Thanks,
 Glen


  Original Message 

 On 6/7/2014 11:44 PM, Glen Mazza wrote:

 Hi Team,

 This is a vote to release Roller 5.0.4, it upgrades its Struts library
 to 2.3.16.3 to fix some important issues with it; also, some of the
 LDAP configuration was fixed based on comments from a user.

 Binaries are here:  http://people.apache.org/~gmazza/roller/

 I tested the Tomcat version, it looks good.

 Here's my +1.  Voting will be for 72 hours.

 Regards,
 Glen

Re: Jenkins build is still unstable: Roller #1229

[Greg Huber]

.Was reading on the struts dev list and

Reconfigured job to 'package' instead 'install'

fixed a build issue.

Maybe here also?

Cheers Greg.



On 18 April 2014 05:52, Apache Jenkins Server jenk...@builds.apache.orgwrote:

 See https://builds.apache.org/job/Roller/1229/

Re: Boo Hiss. (Re: svn commit: r1581353 - in /roller/trunk/app/src/main: java/org/apache/roller/weblogger/ui/struts2/editor/ resources/ webapp/WEB-INF/jsps/editor/)

[Greg Huber]

good idea..

Will test the calendar also.


On 25 March 2014 21:33, Glen Mazza glen.ma...@gmail.com wrote:

 Greg, me no like, instead of just using the cancel string in umpteen
 JSPs, why not define a constant CANCEL in the parent UIAction class like we
 do for the others like INPUT, LIST, SUCCESS, etc. and use that?

 +public String cancel() {
 +return cancel;
 +}


 Cheers,
 Glen

 On 03/25/2014 10:41 AM, ghu...@apache.org wrote:

 Author: ghuber
 Date: Tue Mar 25 14:41:11 2014
 New Revision: 1581353

 URL: http://svn.apache.org/r1581353
 Log:
 Tidy interceptors in struts.xml.
 Don't chain on cancel requests, otherwise parameter issues.
 Testing changes!!

 Modified:
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/BookmarkAdd.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/BookmarkEdit.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/CategoryAdd.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/CategoryEdit.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/CategoryRemove.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/EntryRemove.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/FolderAdd.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/FolderEdit.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/MembersInvite.java
  roller/trunk/app/src/main/java/org/apache/roller/
 weblogger/ui/struts2/editor/TemplateRemove.java
  roller/trunk/app/src/main/resources/struts.xml
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/BookmarkAdd.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/
 BookmarkEdit.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/Bookmarks.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/CategoryAdd.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/
 CategoryEdit.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/
 CategoryRemove.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/EntryRemove.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/
 EntryRemoveViaList.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/FolderAdd.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/FolderEdit.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/
 MembersInvite.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/
 TemplateRemove.jsp
  roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/
 WeblogConfig.jsp

Re: website error

[Greg Huber]

hmm, the null[Read More], after the roller needs you

$entry.displayContent($url.entry($entry.anchor))

Roller needs YOU!
07.18.2010 | 0 Comments
null[Read More]

somewhere in the render method, would have thought there would be plugin
messages though.



On 25 February 2014 12:55, Dave snoopd...@gmail.com wrote:

 The only thing I see in the rollerweblogger.org logs is a series of
 database connection errors, which include the advice to use the
 autoConnect=true property in my JDBC URL -- but I'm already using that (and
 have been for many years).

 - Dave



 On Tue, Feb 25, 2014 at 6:23 AM, Greg Huber gregh3...@gmail.com wrote:

  Need to grab the roller.log file and see if there are any exceptions, ie
  npe.
 
 
  On 25 February 2014 08:43, nicolas muller zepo...@gmail.com wrote:
 
   Hello,
  
   Just to notify there are errors on website
  
   $entry.displayContent($url.entry($entry.anchor))
  
   http://rollerweblogger.org/project/
  
   Thanks a lot.
   Best regards,
  
 

Re: Spring password encoder depreciated

[Greg Huber]

Glen, I was not intending to do it as it would involve a lot of work for
existing blogs.  We would need some kind of password change screen from old
to new when signing on, to help the migration.

I don't think there will be a compatible replacement as the hashing is
based on the username/password rather than just the password, ie it stops
copying/sql the password from user to user.

I guess it would be good to have two versions, legacy and username/password
based, so newer sites can adopt best practice.

I could see if I can add it via properties if needed.


Cheers Greg.


On 26 February 2014 00:30, Glen Mazza glen.ma...@gmail.com wrote:

 Greg, you haven't made this change yet, correct?  Please hold off on this
 for the 5.1 series, we can do it in a later release.  For one thing,
 there's a good chance if and when Spring finally removes this encoding
 option they'll put a similar, compatible option back in someplace else.
  But much more importantly, we want everyone to be able to upgrade as
 smoothly as possible to the new 5.1 when it's available so we won't have to
 maintain both 5.0.x and 5.1.  As you know, 5.1 is significantly smaller 
 simpler than 5.0.x, and everyone's going to be glad if we can retire the
 5.0.x series.

 Regards,
 Glen

  On 01/27/2014 09:00 AM, Greg Huber wrote:

 Gen,

 PasswordEncoder has been depreciated for some time now, but whether it
 will
 be removed I am unsure.  If passwords have been hashed its never going to
 be an easy change as its a one way encryption. The changes if I remember
 are mainly in the java classes so we could leave the old code and use
 properties to control which one is in use.

 ie changes are

 from:

 DaoAuthenticationProvider provider = (DaoAuthenticationProvider)
 ctx.getBean(org.springframework.security.authentication.dao.DaoAuthenticationProvider#0);

  String algorithm =
 WebloggerConfig.getProperty(passwds.encryption.algorithm);
  PasswordEncoder encoder = null;
  if (algorithm.equalsIgnoreCase(SHA)) {
  encoder = new ShaPasswordEncoder();
  } else if (algorithm.equalsIgnoreCase(MD5)) {
  encoder = new Md5PasswordEncoder();
  } else {
  log.error(Encryption algorithm ' + algorithm + ' not
 supported, disabling encryption.);
  }
  if (encoder != null) {
  provider.setPasswordEncoder(encoder);
  log.info(Password Encryption Algorithm set to ' +
 algorithm + ');
  }
 ..

 to:

 DaoAuthenticationProvider springProvider = (DaoAuthenticationProvider)
 ctx

 .getBean(org.springframework.security.authentication.dao.DaoAuthenticationProvider#0);

 if (springProvider != null) {
  String theEncoder =
 WebloggerConfig.getProperty(passwds.encryption.encoder);
  if (theEncoder.equalsIgnoreCase(Standard)) {
  encoder = new StandardPasswordEncoder();
  } else if (theEncoder.equalsIgnoreCase(BCrypt)) {
  encoder = new BCryptPasswordEncoder();
  } else {
  log.error(Failed to locate encoder using :  +
 theEncoder
  + , not supported, disabling encryption.);
  }
  if (encoder == null) {
  encoder = NoOpPasswordEncoder.getInstance();
  }
 ...
 }

 I guess if we have both they will never want to change.

 Cheers Greg.


 On 27 January 2014 11:52, Glen Mazza glen.ma...@gmail.com wrote:

  If this configuration is done in XML: http://mprabhat.wordpress.com/
 2012/07/20/spring-security-3-1-password-encoder-with-
 custom-database-and-jsf-2-0/, it may be sufficient to provide two XML
 blocks, one using the deprecated and one using the new, with the
 deprecated
 one commented-out.  Then the install guide would tell people to
 uncomment
 the one and comment the other if they're upgrading from 5.0.x or
 earlier?

 Glen

 On 01/27/2014 06:44 AM, Glen Mazza wrote:

  If we have to, we have to--but how will people be able to upgrade from
 5.0.x to 5.1 without everyone's password being lost and hence locked
 out
 (i.e., if blogs.oracle.com tried this all users would be locked out,
 right?)  Perhaps we can support both algorithms in 5.1 (
 http://stackoverflow.com/a/17450276).

 But if we have to break it, let's use moving forward the best
 algorithm,
 from the above link the BCCrypt() one apparently (unless you know
 otherwise).  Also, we don't have to use Spring here if plain Java
 offers
 corresponding libraries (less likely to deprecate).

 Also, Greg, please answer this question I put in the comments (if you
 know it), in case you missed it: https://issues.apache.org/
 jira/browse/ROL-1795, we have the closing of a JIRA issue (always a
 good
 thing :) on the line...

 Glen

 On 01/27/2014 05:23 AM, Greg Huber wrote:

  Gentlemen,

 The class

Fwd: Jenkins build became unstable: Roller #1149

[Greg Huber]

Hm, I wonder what could be different in running it locally and with running
in Jenkins...

Results :

Tests run: 129, Failures: 0, Errors: 0, Skipped: 0

[INFO]

[INFO] BUILD SUCCESS
[INFO]

[INFO] Total time: 2:45.763s
[INFO] Finished at: Thu Jan 30 08:06:10 GMT 2014
[INFO] Final Memory: 35M/325M
[INFO]



-- Forwarded message --
From: Apache Jenkins Server jenk...@builds.apache.org
Date: 30 January 2014 04:52
Subject: Jenkins build became unstable: Roller #1149
To: dev@roller.apache.org, glen.ma...@gmail.com


See https://builds.apache.org/job/Roller/1149/

Spring password encoder depreciated

[Greg Huber]

Gentlemen,

The class
org.springframework.security.authentication.encoding.PasswordEncoder SHA
and MD5 in RollerContext has been depreciated, it can be replaced by
StandardPasswordEncoder(), BCryptPasswordEncoder() and NoOpPasswordEncoder.

The down side is the encryption is based on the username and password
(rather than just the password), so all passwords will need to be reset.
Any objections on doing this upgrade?

Cheers Greg.

Re: Spring password encoder depreciated

[Greg Huber]

Gen,

PasswordEncoder has been depreciated for some time now, but whether it will
be removed I am unsure.  If passwords have been hashed its never going to
be an easy change as its a one way encryption. The changes if I remember
are mainly in the java classes so we could leave the old code and use
properties to control which one is in use.

ie changes are

from:

DaoAuthenticationProvider provider = (DaoAuthenticationProvider)
ctx.getBean(org.springframework.security.authentication.dao.DaoAuthenticationProvider#0);
String algorithm =
WebloggerConfig.getProperty(passwds.encryption.algorithm);
PasswordEncoder encoder = null;
if (algorithm.equalsIgnoreCase(SHA)) {
encoder = new ShaPasswordEncoder();
} else if (algorithm.equalsIgnoreCase(MD5)) {
encoder = new Md5PasswordEncoder();
} else {
log.error(Encryption algorithm ' + algorithm + ' not
supported, disabling encryption.);
}
if (encoder != null) {
provider.setPasswordEncoder(encoder);
log.info(Password Encryption Algorithm set to ' +
algorithm + ');
}
..

to:

DaoAuthenticationProvider springProvider = (DaoAuthenticationProvider) ctx

.getBean(org.springframework.security.authentication.dao.DaoAuthenticationProvider#0);
if (springProvider != null) {
String theEncoder =
WebloggerConfig.getProperty(passwds.encryption.encoder);
if (theEncoder.equalsIgnoreCase(Standard)) {
encoder = new StandardPasswordEncoder();
} else if (theEncoder.equalsIgnoreCase(BCrypt)) {
encoder = new BCryptPasswordEncoder();
} else {
log.error(Failed to locate encoder using :  +
theEncoder
+ , not supported, disabling encryption.);
}
if (encoder == null) {
encoder = NoOpPasswordEncoder.getInstance();
}
...
}

I guess if we have both they will never want to change.

Cheers Greg.


On 27 January 2014 11:52, Glen Mazza glen.ma...@gmail.com wrote:

 If this configuration is done in XML: http://mprabhat.wordpress.com/
 2012/07/20/spring-security-3-1-password-encoder-with-
 custom-database-and-jsf-2-0/, it may be sufficient to provide two XML
 blocks, one using the deprecated and one using the new, with the deprecated
 one commented-out.  Then the install guide would tell people to uncomment
 the one and comment the other if they're upgrading from 5.0.x or
 earlier?

 Glen

 On 01/27/2014 06:44 AM, Glen Mazza wrote:

 If we have to, we have to--but how will people be able to upgrade from
 5.0.x to 5.1 without everyone's password being lost and hence locked out
 (i.e., if blogs.oracle.com tried this all users would be locked out,
 right?)  Perhaps we can support both algorithms in 5.1 (
 http://stackoverflow.com/a/17450276).

 But if we have to break it, let's use moving forward the best algorithm,
 from the above link the BCCrypt() one apparently (unless you know
 otherwise).  Also, we don't have to use Spring here if plain Java offers
 corresponding libraries (less likely to deprecate).

 Also, Greg, please answer this question I put in the comments (if you
 know it), in case you missed it: https://issues.apache.org/
 jira/browse/ROL-1795, we have the closing of a JIRA issue (always a good
 thing :) on the line...

 Glen

 On 01/27/2014 05:23 AM, Greg Huber wrote:

 Gentlemen,

 The class
 org.springframework.security.authentication.encoding.PasswordEncoder SHA
 and MD5 in RollerContext has been depreciated, it can be replaced by
 StandardPasswordEncoder(), BCryptPasswordEncoder() and
 NoOpPasswordEncoder.

 The down side is the encryption is based on the username and password
 (rather than just the password), so all passwords will need to be reset.
 Any objections on doing this upgrade?

 Cheers Greg.

maven tests still do not work on centos 6.5

[Greg Huber]

Glen,

I still cannot run the tests due to this error.  There is some other port
that  inmemdb uses in the background.

I have had a look at the source but I think it may be in
com.btmatthews.utils package which is not included in the git download.

Do you have the source for this?   com.btmatthews.utils

port 4224 is not in use:

[INFO] --- inmemdb-maven-plugin:1.3.0:run (run) @ roller-webapp ---
[INFO] Configured database port: 4224
[INFO] Configured database username: APP
[INFO] Configured database password: APP
[INFO] Configured database name: rollerdb
[INFO]
[INFO] --- maven-surefire-plugin:2.16:test (default-test) @ roller-webapp
---
[ERROR] Error starting or stopping the monitor
java.net.BindException: Cannot assign requested address
at java.net.PlainSocketImpl.socketBind(Native Method)
at
java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:376)
at java.net.ServerSocket.bind(ServerSocket.java:376)
at java.net.ServerSocket.init(ServerSocket.java:237)
at com.btmatthews.utils.monitor.Monitor.runMonitor(Monitor.java:82)
at com.btmatthews.utils.monitor.Monitor$1.run(Monitor.java:108)
at java.lang.Thread.run(Thread.java:722)
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-war-plugin:2.3:war (default-war) @ roller-webapp ---
[INFO] Packaging webapp
[INFO] Assembling webapp [roller-webapp] in
[/home/ghuber/eclipse43roller/workspace/roller-project/app/target/roller]
[INFO] Processing war project
[INFO] Copying webapp resources
[/home/ghuber/eclipse43roller/workspace/roller-project/app/src/main/webapp]
[INFO] Webapp assembled in [3761 msecs]
[INFO] Building war:
/home/ghuber/eclipse43roller/workspace/roller-project/app/target/roller.war
[INFO] Packaging classes
[INFO] Building jar:
/home/ghuber/eclipse43roller/workspace/roller-project/app/target/roller-classes.jar
[INFO]
[INFO] --- inmemdb-maven-plugin:1.3.0:stop (stop) @ roller-webapp ---
[INFO] Sending command stop to monitor
[ERROR] Error sending command to monitor
java.net.NoRouteToHostException: No route to host
at java.net.PlainSocketImpl.socketConnect(Native Method)
at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:391)
at java.net.Socket.connect(Socket.java:579)
at java.net.Socket.connect(Socket.java:528)
at java.net.Socket.init(Socket.java:425)
at java.net.Socket.init(Socket.java:241)
at com.btmatthews.utils.monitor.Monitor.sendCommand(Monitor.java:190)
at
com.btmatthews.utils.monitor.mojo.AbstractStopMojo.execute(AbstractStopMojo.java:40)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:318)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:153)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:555)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:214)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:158)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357)

Cheers Greg

Re: maven tests still do not work on centos 6.5

[Greg Huber]

https://github.com/bmatthews68/inmemdb-maven-plugin/issues/15


On 8 January 2014 02:43, Glen Mazza glen.ma...@gmail.com wrote:

 https://github.com/bmatthews68/monitor/tree/master/src/main/java/com/
 btmatthews/utils maybe...  Brian Matthews was very responsive on prior
 suggestions I had for him, so if you find something that he can do to make
 Centos work just let him know.  Also, if you can find a working
 configuration for your machine I can test that it works on Ubuntu.

 Regards,
 Glen


 On 01/07/2014 09:36 AM, Greg Huber wrote:

 Glen,

 I still cannot run the tests due to this error.  There is some other port
 that  inmemdb uses in the background.

 I have had a look at the source but I think it may be in
 com.btmatthews.utils package which is not included in the git download.

 Do you have the source for this?   com.btmatthews.utils

 port 4224 is not in use:

 [INFO] --- inmemdb-maven-plugin:1.3.0:run (run) @ roller-webapp ---
 [INFO] Configured database port: 4224
 [INFO] Configured database username: APP
 [INFO] Configured database password: APP
 [INFO] Configured database name: rollerdb
 [INFO]
 [INFO] --- maven-surefire-plugin:2.16:test (default-test) @ roller-webapp
 ---
 [ERROR] Error starting or stopping the monitor
 java.net.BindException: Cannot assign requested address
  at java.net.PlainSocketImpl.socketBind(Native Method)
  at
 java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:376)
  at java.net.ServerSocket.bind(ServerSocket.java:376)
  at java.net.ServerSocket.init(ServerSocket.java:237)
  at com.btmatthews.utils.monitor.Monitor.runMonitor(Monitor.java:82)
  at com.btmatthews.utils.monitor.Monitor$1.run(Monitor.java:108)
  at java.lang.Thread.run(Thread.java:722)
 [INFO] Tests are skipped.
 [INFO]
 [INFO] --- maven-war-plugin:2.3:war (default-war) @ roller-webapp ---
 [INFO] Packaging webapp
 [INFO] Assembling webapp [roller-webapp] in
 [/home/ghuber/eclipse43roller/workspace/roller-project/app/target/roller]
 [INFO] Processing war project
 [INFO] Copying webapp resources
 [/home/ghuber/eclipse43roller/workspace/roller-project/app/
 src/main/webapp]
 [INFO] Webapp assembled in [3761 msecs]
 [INFO] Building war:
 /home/ghuber/eclipse43roller/workspace/roller-project/app/
 target/roller.war
 [INFO] Packaging classes
 [INFO] Building jar:
 /home/ghuber/eclipse43roller/workspace/roller-project/app/
 target/roller-classes.jar
 [INFO]
 [INFO] --- inmemdb-maven-plugin:1.3.0:stop (stop) @ roller-webapp ---
 [INFO] Sending command stop to monitor
 [ERROR] Error sending command to monitor
 java.net.NoRouteToHostException: No route to host
  at java.net.PlainSocketImpl.socketConnect(Native Method)
  at
 java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:
 339)
  at
 java.net.AbstractPlainSocketImpl.connectToAddress(
 AbstractPlainSocketImpl.java:200)
  at
 java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:
 182)
  at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:391)
  at java.net.Socket.connect(Socket.java:579)
  at java.net.Socket.connect(Socket.java:528)
  at java.net.Socket.init(Socket.java:425)
  at java.net.Socket.init(Socket.java:241)
  at com.btmatthews.utils.monitor.Monitor.sendCommand(Monitor.
 java:190)
  at
 com.btmatthews.utils.monitor.mojo.AbstractStopMojo.execute(
 AbstractStopMojo.java:40)
  at
 org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(
 DefaultBuildPluginManager.java:106)
  at
 org.apache.maven.lifecycle.internal.MojoExecutor.execute(
 MojoExecutor.java:208)
  at
 org.apache.maven.lifecycle.internal.MojoExecutor.execute(
 MojoExecutor.java:153)
  at
 org.apache.maven.lifecycle.internal.MojoExecutor.execute(
 MojoExecutor.java:145)
  at
 org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(
 LifecycleModuleBuilder.java:84)
  at
 org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(
 LifecycleModuleBuilder.java:59)
  at
 org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(
 LifecycleStarter.java:183)
  at
 org.apache.maven.lifecycle.internal.LifecycleStarter.
 execute(LifecycleStarter.java:161)
  at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:318)
  at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:153)
  at org.apache.maven.cli.MavenCli.execute(MavenCli.java:555)
  at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:214)
  at org.apache.maven.cli.MavenCli.main(MavenCli.java:158)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at
 sun.reflect.NativeMethodAccessorImpl.invoke(
 NativeMethodAccessorImpl.java:57)
  at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(
 DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:601)
  at
 org.codehaus.plexus.classworlds.launcher.Launcher.
 launchEnhanced(Launcher.java:290

Re: media file crud not working again

[Greg Huber]

Glen/Gaurav,

I have done a fix where roller manages the relationship of the parent using
the entity manager refresh() method on the parent.  I was going to use
media manager methods to get the children, but it seems so reliant on the
entity relationships it would need considerable work to rewrite it.  The db
media file does not store the file path, only the parent id, so the queries
would always involve joining files.  .Not really a fan of id's linking
stuff together, reminds me too much of the days of relative record numbers,
and just makes querying the database unpleasant.

If this way causes issues, I will go back and look at rewriting it.

Cheers Greg.


On 20 December 2013 22:56, Glen Mazza glen.ma...@gmail.com wrote:

 I don't have any objections, Gaurav's hands will be full enough with
 ROL-1981 so let him take a break from 1942 and Greg can go in and get done
 what he needs to get done.  (Gaurav this headache has been popping up
 multiple times in the past several months once we left Apache OpenJPA for
 Hibernate  Eclipselink.)

 Glen

 On 12/20/2013 08:51 AM, Greg Huber wrote:

 Gaurav,

 Restarting the server flushes the cache inside eclipselink and hence next
 time the list is retrieved (once server is restarted) it will get a new
 copy the pojo with an new one to many relationship.  In hibernate you can
 flush the cache with primary key and the pojo object class, but it becomes
 a real pain as systems get more complicated to track where these flushes
 are required.

 Its not really worth spending any time on this, the design needs
 modifying,
 which I could do if there are no objections.

 Cheers Greg.




 On 20 December 2013 12:52, Gaurav gauravsain...@gmail.com wrote:

  Hello,

   I yesterday spent 2-3 hours on this issue ROL-1942 and tested it two
 three times, as mentioned in the bug we have to restart the server for
 getting the images, rather if we move any of the images then also that
 image appear in media view. The search is working fine and displaying the
 media files correctly. MediaFileView class make list of childFiles which
 is
 iterated in jsp. I was unable to track anything till now, as the search
 show correct results, I was wondering that can we use the same steps used
 to iterate list for search, although I am still working on this issue and
 debugging it by placing logs and studying the code for this, If anyone
 can
 give me some help or idea to go into this it will be very thankful ?

 Thanks
 Gaurav

 On Friday 20 December 2013 04:16 PM, Greg Huber wrote:

  Glen,

 Looking more into this, its probably better to remove the associations
 and
 use a straight forward queries for the resources.  I have had trouble in
 the past with these types of associations and they only work really for
 lists that do not change.  If we ever want to use any sort of caching
 (ie
 on the parent pojo) these pojo's will need to be removed from the cache
 on
 each update, which can be a truly hair greying experience.

 If nobody has any obs probably just a few line fix,
 hopefully it will get fixed as part of ROL-1942.  Please be patient (or
 use Hibernate in the interim.)
 jections I will replace the associations with queries.

 Cheers Greg.



 On 20 December 2013 00:55, Glen Mazza glen.ma...@gmail.com wrote:

   Yes, I'm aware of the headache, it's probably just a few line fix,

 hopefully it will get fixed as part of ROL-1942.  Please be patient (or
 use
 Hibernate in the interim.)

 Glen

 On 12/19/2013 07:02 AM, Greg Huber wrote:

   Glen,

 It looks like the crud (add/delete) on the media file child
 association
 is
 not working again:

 MediaFileDirectory directory;
 ..
 this.childFiles.addAll(directory.getMediaFiles());

 what technique do we now have to use with eclipselink to successfully
 flush
 these associations?

 Cheers Greg.

Re: media file crud not working again

[Greg Huber]

Gaurav,

I did start to look at what is required, but then got side tracked onto
something else.  Hopefully I will be able to get some time later in the
week.  Unfortunately the relationships are rather embedded in the code, but
the plan will be to remove these and replace them with media manager method
lookups.

Cheers Greg



On 24 December 2013 04:54, Gaurav gauravsain...@gmail.com wrote:

 Hello Greg,

 I just want a favour from your side, As I previously go through this
 issue, If you can reply here with files you changed for solving this bus so
 I can go through and learn more about this, as soon as you are done with
 this. It will be good learning experience for me.

 Thanks in Advance :)

 Gaurav


 On Saturday 21 December 2013 04:26 AM, Glen Mazza wrote:

 I don't have any objections, Gaurav's hands will be full enough with
 ROL-1981 so let him take a break from 1942 and Greg can go in and get done
 what he needs to get done.  (Gaurav this headache has been popping up
 multiple times in the past several months once we left Apache OpenJPA for
 Hibernate  Eclipselink.)

 Glen

 On 12/20/2013 08:51 AM, Greg Huber wrote:

 Gaurav,

 Restarting the server flushes the cache inside eclipselink and hence next
 time the list is retrieved (once server is restarted) it will get a new
 copy the pojo with an new one to many relationship.  In hibernate you can
 flush the cache with primary key and the pojo object class, but it
 becomes
 a real pain as systems get more complicated to track where these flushes
 are required.

 Its not really worth spending any time on this, the design needs
 modifying,
 which I could do if there are no objections.

 Cheers Greg.




 On 20 December 2013 12:52, Gaurav gauravsain...@gmail.com wrote:

  Hello,

   I yesterday spent 2-3 hours on this issue ROL-1942 and tested it two
 three times, as mentioned in the bug we have to restart the server for
 getting the images, rather if we move any of the images then also that
 image appear in media view. The search is working fine and displaying
 the
 media files correctly. MediaFileView class make list of childFiles
 which is
 iterated in jsp. I was unable to track anything till now, as the search
 show correct results, I was wondering that can we use the same steps
 used
 to iterate list for search, although I am still working on this issue
 and
 debugging it by placing logs and studying the code for this, If anyone
 can
 give me some help or idea to go into this it will be very thankful ?

 Thanks
 Gaurav

 On Friday 20 December 2013 04:16 PM, Greg Huber wrote:

  Glen,

 Looking more into this, its probably better to remove the associations
 and
 use a straight forward queries for the resources.  I have had trouble
 in
 the past with these types of associations and they only work really for
 lists that do not change.  If we ever want to use any sort of caching
 (ie
 on the parent pojo) these pojo's will need to be removed from the
 cache on
 each update, which can be a truly hair greying experience.

 If nobody has any obs probably just a few line fix,
 hopefully it will get fixed as part of ROL-1942.  Please be patient (or
 use Hibernate in the interim.)
 jections I will replace the associations with queries.

 Cheers Greg.



 On 20 December 2013 00:55, Glen Mazza glen.ma...@gmail.com wrote:

   Yes, I'm aware of the headache, it's probably just a few line fix,

 hopefully it will get fixed as part of ROL-1942.  Please be patient
 (or
 use
 Hibernate in the interim.)

 Glen

 On 12/19/2013 07:02 AM, Greg Huber wrote:

   Glen,

 It looks like the crud (add/delete) on the media file child
 association
 is
 not working again:

 MediaFileDirectory directory;
 ..
 this.childFiles.addAll(directory.getMediaFiles());

 what technique do we now have to use with eclipselink to successfully
 flush
 these associations?

 Cheers Greg.

Re: media file crud not working again

[Greg Huber]

Gaurav,

Restarting the server flushes the cache inside eclipselink and hence next
time the list is retrieved (once server is restarted) it will get a new
copy the pojo with an new one to many relationship.  In hibernate you can
flush the cache with primary key and the pojo object class, but it becomes
a real pain as systems get more complicated to track where these flushes
are required.

Its not really worth spending any time on this, the design needs modifying,
which I could do if there are no objections.

Cheers Greg.




On 20 December 2013 12:52, Gaurav gauravsain...@gmail.com wrote:

 Hello,

  I yesterday spent 2-3 hours on this issue ROL-1942 and tested it two
 three times, as mentioned in the bug we have to restart the server for
 getting the images, rather if we move any of the images then also that
 image appear in media view. The search is working fine and displaying the
 media files correctly. MediaFileView class make list of childFiles which is
 iterated in jsp. I was unable to track anything till now, as the search
 show correct results, I was wondering that can we use the same steps used
 to iterate list for search, although I am still working on this issue and
 debugging it by placing logs and studying the code for this, If anyone can
 give me some help or idea to go into this it will be very thankful ?

 Thanks
 Gaurav

 On Friday 20 December 2013 04:16 PM, Greg Huber wrote:

 Glen,

 Looking more into this, its probably better to remove the associations and
 use a straight forward queries for the resources.  I have had trouble in
 the past with these types of associations and they only work really for
 lists that do not change.  If we ever want to use any sort of caching (ie
 on the parent pojo) these pojo's will need to be removed from the cache on
 each update, which can be a truly hair greying experience.

 If nobody has any obs probably just a few line fix,
 hopefully it will get fixed as part of ROL-1942.  Please be patient (or
 use Hibernate in the interim.)
 jections I will replace the associations with queries.

 Cheers Greg.



 On 20 December 2013 00:55, Glen Mazza glen.ma...@gmail.com wrote:

  Yes, I'm aware of the headache, it's probably just a few line fix,
 hopefully it will get fixed as part of ROL-1942.  Please be patient (or
 use
 Hibernate in the interim.)

 Glen

 On 12/19/2013 07:02 AM, Greg Huber wrote:

  Glen,

 It looks like the crud (add/delete) on the media file child association
 is
 not working again:

 MediaFileDirectory directory;
 ..
 this.childFiles.addAll(directory.getMediaFiles());

 what technique do we now have to use with eclipselink to successfully
 flush
 these associations?

 Cheers Greg.

media file crud not working again

[Greg Huber]

Glen,

It looks like the crud (add/delete) on the media file child association is
not working again:

MediaFileDirectory directory;
..
this.childFiles.addAll(directory.getMediaFiles());

what technique do we now have to use with eclipselink to successfully flush
these associations?

Cheers Greg.

Re: FrontPage theme not working

[Greg Huber]

Gaurav,

following through the logic:

#set($pinnedEntries = $site.getPinnedWeblogEntries(5))
 #foreach($pinnedEntry in $pinnedEntries)


$site == org.apache.roller.weblogger.ui.rendering.model.SiteModel

So if you check getPinnedWeblogEntries(..) of SiteModel:

/**
 * Get pinned entries.
 * @param sinceDays Only consider weblogs updated in the last sinceDays
 * @param lengthMax number of results to return
 */
public List getPinnedWeblogEntries(int length) {
List results = new ArrayList();
try {
Weblogger roller = WebloggerFactory.getWeblogger();
WeblogEntryManager wmgr = roller.getWeblogEntryManager();
List weblogs = wmgr.getWeblogEntriesPinnedToMain(length);
for (Iterator it = weblogs.iterator(); it.hasNext();) {
WeblogEntry entry = (WeblogEntry) it.next();
results.add(WeblogEntryWrapper.wrap(entry, urlStrategy));
}
} catch (Exception e) {
log.error(ERROR: fetching pinned weblog entries, e);
}
return results;
}

It retrieves a list worf weblogs:

List weblogs = wmgr.getWeblogEntriesPinnedToMain(length);

from method getWeblogEntriesPinnedToMain of

org.apache.roller.weblogger.business.jpa.JPAWeblogEntryManagerImpl


public List getWeblogEntriesPinnedToMain(Integer max)
throws WebloggerException {
Query query = strategy.getNamedQuery(
WeblogEntry.getByPinnedToMainstatusOrderByPubTimeDesc);
query.setParameter(1, Boolean.TRUE);
query.setParameter(2, WeblogEntry.PUBLISHED);
if (max != null) {
query.setMaxResults(max);
}
return query.getResultList();
}

it will execute a named query:

WeblogEntry.getByPinnedToMainstatusOrderByPubTimeDesc

from:
app/src/main/resources/org/apache/roller/weblogger/pojos/WeblogEntry.orm.xml

named-query
name=WeblogEntry.getByPinnedToMainamp;statusOrderByPubTimeDesc
querySELECT w FROM WeblogEntry w WHERE w.pinnedToMain = ?1
AND w.status = ?2 ORDER BY w.pubTime DESC/query
/named-query

Is this OK?

Cheers Greg




On 17 December 2013 13:33, Gaurav gauravsain...@gmail.com wrote:

 Hello,

 I am still not able to populate the results in frontpage theme. The
 condition I see in this theme is different from other is this
 [#foreach($pinnedEntry in $pinnedEntries)]. Can any one explain me what is
 pinnedEntry here ? As in that theme we still use #foreach($entry in
 $entries) for the search results, that is why I was saying search results
 are coming fine.

 Thanks
 Gaurav

 On Tuesday 17 December 2013 03:29 PM, Greg Huber wrote:

 It should work ok, the front page theme is for the initial front page
 weblog, right?

 Cheers Greg.


 On 17 December 2013 09:38, Gaurav gauravsain...@gmail.com wrote:

  Hello,

 I tried using the frontpage theme of roller, but it seems like this theme
 has some issue as It did not show up any data (no blogs, hottags, hot
 blogs
 etc.)
 But when I tried searching in the search of that theme, then it shows the
 blogs. I am looking into this, just want to know Is anyone out there for
 whom this theme is working perfectly fine ?

 --
 Regards,
 *Gaurav Saini*
 /Developer, Digital Marketing and Pursuing B.Tech/
 /Email: gauravsain...@gmail.com/

Re: All heck is breaking loose... (Re: meta tags, description and keyword missing)

[Greg Huber]

Glen,

You can only use the $entry when you are in a #foreach loop as the $entry
refers to the current weblog item iteration:

#foreach( $entry in $entries )
.
#end

I do not think you can easily use blog entries in the head section
without changing the logic some what.


I have checked the code and within #foreach( $entry in $entries ) the
$entry.searchDescription works as expected.

Cheers Greg.



On 1 December 2013 17:53, Glen Mazza glen.ma...@gmail.com wrote:

 Actually, I don't see how that can have anything to do with it.

 Glen

 On 12/01/2013 12:43 PM, Glen Mazza wrote:

 BTW, JSPWiki upgraded to Lucene 4.6 a few days ago, could that be it?

 Glen

 On 12/01/2013 12:24 PM, Dave wrote:

 On Sun, Dec 1, 2013 at 12:04 PM, Glen Mazza glen.ma...@gmail.com
 wrote:

  (on second thought, switching back to dev@...   :)

 Also, the Roller blog itself which is on SNAPSHOT is no longer having
 its
 blog articles expanded: http://rollerweblogger.org/project/, that was
 working fine just a week or so ago.  I'm not sure what the problem is, I
 don't think I was working in this area.

  Very strange. I *know* that I checked and rechecked the Roller project
 blog
 last week after the upgrade because I had to do so much work on the
 JSPWiki
 plugin to get the project blog to render correctly.

 - Dave