Re: Review request for JDK-8193295: Remove no longer used COMMALEFT

[Michael Haupt]

Hi Attila,

thumbs up. :-)

Best,

Michael

> Am 13.01.2018 um 11:02 schrieb Attila Szegedi :
> 
> Can I get another review?
> 
>> On Dec 25, 2017, at 10:59 AM, Attila Szegedi  wrote:
>> 
>> Yeah, JDK 11. There’s no visible changes, so it doesn’t really make sense 
>> pushing it into JDK 10.
>> 
>>> On Dec 21, 2017, at 9:37 PM, Hannes Wallnöfer 
>>>  wrote:
>>> 
>>> Interesting. I bet the answer is in the commits from before we went open 
>>> source.
>>> 
>>> +1
>>> 
>>> I assume this is for JDK 11?
>>> 
>>> Hannes
>>> 
 Am 21.12.2017 um 19:20 schrieb Attila Szegedi :
 
 Please review JDK-8193295 "Remove no longer used COMMALEFT" at 
  for 
 
 
 I love deleting code :-)
 
 COMMALEFT was an odd duck, as there’s not really anything in the ES 
 specification that’d require it, and we really don’t even use it for 
 anything. I had a memory that we used to use it for some behavior around 
 object literals, but I can’t find any traces of that… I run:
 
hg log --template "{ifcontains('COMMALEFT', diff(), '{node} {desc}\n', 
 '')}”
 
 and trawled through the diffs for all changesets it brought up, but I 
 haven’t found a single use of COMMALEFT ever.
 
 Thanks,
 Attila.
>>> 
>> 
> 

Re: RFR 8166298: 3 nashorn ant tests fail with latest jdk9-dev tip

[Michael Haupt]

Hi Sundar,

thumbs up.

Best,

Michael

> Am 20.09.2016 um 14:51 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8166298/webrev.01/ for
> https://bugs.openjdk.java.net/browse/JDK-8166298
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8166296:add documentation for Date,RegExp,Error,JSON objects

[Michael Haupt]

Hi Srini,

> Am 19.09.2016 um 19:43 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> Please review http://cr.openjdk.java.net/~sdama/8166296/webrev.00/  for 
> https://bugs.openjdk.java.net/browse/JDK-8166296 

thumbs up, provided these changes are applied:

+Date.parse=returns a number, the UTC time value corresponding to the date and 
time interpreted from given string argument, returns NAN if the argument is 
unrecognisable string

... from the given string argument, returns NaN if the argument is not 
recognized

+Date.UTC=returns number of milliseconds in the given date object since january 
1,1970,00:00:00 universal time

returns the number ... since January 1, 1970, 00:00:00 universal time

(returns *the* number / string value / year ... - please apply in all other 
places)
(month names are written in upper case, please apply in all other places)
(spaces after commas, please apply in all other places)

+Date.prototype.toString=returns string value representing given date object

... representing the given date object

+Date.prototype.toDateString=returns string value representing date portion of 
the given date object

... representing the date portion ...

(also ... representing *the* time portion ... etc., please apply accordingly 
elsewhere)

+Date.prototype.valueOf=returns number of milliseconds between 1 january 1970 
00:00:00 UTC and the given date

Please use a consistent date formatting. "1. January 1970" or "January 1, 1970" 
in all places.

+Date.prototype.getDay=returns the day of the week for the given date according 
to local time, 0 represents sunday

Sunday (day names begin with upper case - please apply in all places)

+Date.prototype.getSeconds=returns the seconds in the given date, according to 
locale time

Is it "local time" or "locale time"? (I think "local" is right.) Please be 
consistent in all places.

+Date.prototype.toUTCString=converts given date to a string using UTC time zone

converts the given date ...


Best,

Michael


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR: 8077149: __noSuchProperty__ and __noSuchMethod__ invocations are not properly guarded

[Michael Haupt]

Hi Hannes,

thumbs up!

Best,

Michael

> Am 07.09.2016 um 17:58 schrieb Hannes Wallnöfer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review 8077149: __noSuchProperty__ and __noSuchMethod__ invocations 
> are not properly guarded.
> 
> Webrev: http://cr.openjdk.java.net/~hannesw/8077149/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8077149
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR: 8163945: Honor Number type hint in toPrimitive on Numbers

[Michael Haupt]

Hi Hannes,

thumbs up.

Best,

Michael

> Am 16.08.2016 um 14:51 schrieb Hannes Wallnöfer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review 8163945: Honor Number type hint in toPrimitive on Numbers:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8163945
> Webrev: http://cr.openjdk.java.net/~hannesw/8163945/
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR: 8134304: NPE in initialization of OptimisticTypesPersistence

[Michael Haupt]

Hi Srini,

thumbs up, and I'll be happy to sponsor the push.

Best,

Michael

> Am 10.08.2016 um 06:30 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> 
> Hi,
> 
> Please review http://cr.openjdk.java.net/~sdama/8134304/webrev.01/ 
> for https://bugs.openjdk.java.net/browse/JDK-8134304 
> 
> Localized fix only to OptimisticTypesPersistence.java.
> 
> Regards,
> Srinivas
> 
> -Original Message-
> From: Srinivas Dama 
> Sent: Wednesday, August 10, 2016 2:40 PM
> To: Nashorn-dev
> Subject: RFR: 8134304: NPE in initialization of OptimisticTypesPersistence
> 
> Hi,
> 
> Please review http://cr.openjdk.java.net/~sdama/8134304/webrev.00/ 
> for https://bugs.openjdk.java.net/browse/JDK-8134304 
> 
> Regards,
> Srinivas

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8160801 :add documentation for NativeString

[Michael Haupt]

Hi Srini,

thumbs up, with conditions (see below). I'll be happy to sponsor the push.

+String.prototype.concat=returns string value which is mix of calling object 
string value and string value given as argument

A mix would be fun. :-) How about this: returns the string resulting from 
appending the argument string value to the calling object

+String.prototype.indexOf=returns the index of first occurrence of specified 
string, starting the search from position given as argument.returns -1 if the 
string is not found
+
+String.prototype.lastIndexOf=returns the index of last occurrence of specified 
string, searching backwards from position given as argument.returns -1 if the 
string is not found

Please replace ".returns" with ", returns" (note the extra space).

Best,

Michael

> Am 26.07.2016 um 13:57 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> 
> Hello,
> 
> Please review http://cr.openjdk.java.net/~sdama/8160801/webrev.00/ 
> for https://bugs.openjdk.java.net/browse/JDK-8160801 
> 
> Regards,
> Srinivas

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8142969:Nashorn logging API requires testing

[Michael Haupt]

Hi Srini,

it turns out I accidentally pushed under my user ID. Sorry about that.

Best,

Michael

> Am 21.07.2016 um 10:55 schrieb Michael Haupt <michael.ha...@oracle.com>:
> 
> Hi Srini,
> 
> thumbs up; I've sponsored the push.
> 
> Best,
> 
> Michael
> 
>> Am 20.07.2016 um 16:54 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
>> 
>> Hi,
>> 
>> Please review http://cr.openjdk.java.net/~sdama/8142969/webrev.00/ 
>> for https://bugs.openjdk.java.net/browse/JDK-8142969 
>> 
>> Fixed the existing test case and moved it from test/script/currently-failing 
>> to test/script/nosecurity directory.
>> 
>> Regards,
>> Srinivas


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8142969:Nashorn logging API requires testing

[Michael Haupt]

Hi Srini,

thumbs up; I've sponsored the push.

Best,

Michael

> Am 20.07.2016 um 16:54 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> 
> Hi,
> 
> Please review http://cr.openjdk.java.net/~sdama/8142969/webrev.00/ 
> for https://bugs.openjdk.java.net/browse/JDK-8142969 
> 
> Fixed the existing test case and moved it from test/script/currently-failing 
> to test/script/nosecurity directory.
> 
> Regards,
> Srinivas

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8149929: Nashorn Parser API needs to be updated for ES6

[Michael Haupt]

Hi Sundar,

congratulations on a titanic achievement. :-) Thumbs up, with one really minor 
remark.

In ParserImpl, the two first lines here ...

+String[] newArgs = new String[args.length + 1];
+System.arraycopy(args, 0, newArgs, 0, args.length);
+newArgs[args.length] = "--parse-only";

... could be replaced with ...

String[] newArgs = Arrays.copyOf(args.length + 1);

... just to make the code look a bit less like assembler. :-)

Best,

Michael

> Am 12.07.2016 um 07:31 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8149929/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8149929
> 
> Nashorn Parser JEP (http://openjdk.java.net/jeps/236) added Parser API
> for ECMAScript ES5.1 version. The current fix is to update the Parser
> API for ECMAScript 6.
> 
> Specdiff for specification changes is here:
> http://cr.openjdk.java.net/~sundar/8149929/specdiff/overview-summary.html
> 
> Thanks,
> 
> -Sundar
> 
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR: 8137240: Negative lookahead in RegEx breaks backreference

[Michael Haupt]

Hi Hannes,

thumbs up.

Best,

Michael

> Am 23.06.2016 um 13:42 schrieb Hannes Wallnöfer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review: 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8137240
> Webrev: http://cr.openjdk.java.net/~hannesw/8137240/webrev/
> 
> Thanks, 
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8160141: removed deprecated method calls in nashorn code

[Michael Haupt]

Hi Sundar,

thumbs up.

Best,

Michael

> Am 23.06.2016 um 06:28 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8160141/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8160141
> 
> Thanks,
> 
> Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8156614: Lazy parsing of ES6 shorthand method syntax is broken

[Michael Haupt]

Hi Hannes,

lower-case thumbs up.

Best,

Michael

> Am 17.06.2016 um 11:16 schrieb Hannes Wallnöfer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review JDK-8156614: Lazy parsing of ES6 shorthand method syntax is 
> broken:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8156614
> Webrev: http://cr.openjdk.java.net/~hannesw/8156614/webrev.00/
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR:8158817

[Michael Haupt]

Hi Srini,

lower-case thumbs up, with these corrections:
* Math.ceil, Math.floor: ... returns argument it self ... -> ... returns 
argument itself ...
* Math.random, Math.sin: insert space after comma

Best,

Michael

> Am 15.06.2016 um 08:54 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> 
> Hi,
> 
> Please review
> http://cr.openjdk.java.net/~sdama/8158817/webrev.00/ 
> for https://bugs.openjdk.java.net/browse/JDK-8158817 
> 
> Regards,
> Srinivas

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR: 8159031: jjs throws NoSuchFileException if ~/.jjs.history does not exist

[Michael Haupt]

Hi Hannes,

lower-case thumbs up for both the JDK and Nashorn changes.

Best,

Michael

> Am 08.06.2016 um 13:18 schrieb Hannes Wallnöfer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review the following changes:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8159031
> JDK webrev: http://cr.openjdk.java.net/~hannesw/8159031/jdk/webrev.00/
> Nashorn webrev: http://cr.openjdk.java.net/~hannesw/8159031/nashorn/webrev.00/
> 
> These are two one-liners that add a file existence check in Nashorn and a 
> null check in jline.
> 
> Thanks, 
> Hannes
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: approval request for JDK-8138906:Test test/script/trusted/JDK-8087292.js intermittently fails

[Michael Haupt]

Hi all,

I'll sponsor the push.

Best,

Michael

> Am 06.06.2016 um 18:21 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Hi Srini,
> 
> backport looks good.
> 
> Hannes
> 
> 
> Am 2016-06-06 um 17:41 schrieb Srinivas Dama:
>> Hi,
>> 
>> 
>> There are some 8u specific changes, Please do a backport review.
>> 
>> Here are the links.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8138906
>> Jdk9 review thread:
>> http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-March/006022.html
>> Jdk9 webrev :
>> http://cr.openjdk.java.net/~sdama/8138906/webrev.00/
>> 
>> Jdk8u webrev:
>> http://cr.openjdk.java.net/~sdama/8138906/8u/webrev.01/
>> 
>> Regards,
>> Srinivas
>> 
>> -Original Message-
>> From: Seán Coffey
>> Sent: Monday, May 30, 2016 6:56 PM
>> To: Srinivas Dama
>> Subject: Re: approval request for JDK-8138906:Test 
>> test/script/trusted/JDK-8087292.js intermittently fails
>> 
>> Approved for jdk8u-dev. If the code differs from the JDK 9 fix, please 
>> obtain a code review before pushing.
>> 
>> Regards,
>> Sean.
>> 
>> On 26/05/16 17:30, Srinivas Dama wrote:
>>> Hi,
>>> 
>>> Please approve.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8138906
>>> Jdk9 review thread :
>>> http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-February/00599
>>> 1.html Jdk8u-webrev :
>>> http://cr.openjdk.java.net/~sdama/8138906/8u/webrev.00/
>>> 
>>> Regards,
>>> Srinivas
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8158736: Adapter class loaders can avoid creating named dynamic modules

[Michael Haupt]

Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 06.06.2016 um 11:38 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review: http://cr.openjdk.java.net/~sundar/8158736/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8158736
> 
> Nashorn creates named, dynamic modules for java adapter classes. This
> can be avoided and we can use the default, unnamed module created for
> the adapter class loader. Nashorn allows only subtyping of public,
> exported supertypes be implemented in scripts.  The only package used in
> adapter module is exported and the adapter type is public as well.
> 
> There is no need for named dynamic module - as there is nothing to
> encapsulate.  Nashorn module can still selectively export packages to
> adapter module [ so that generated adapter class can access nashorn
> internals as needed].
> 
> This avoids having to generate read-links to the modules of the
> reference types used by the adapter class - because unnamed adapter
> module has read edges to all the modules.
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR:DK-8148457(Remove jdk.nashorn.tools.FXShell class and associated build.xml cruft)

[Michael Haupt]

Hi Srini,

> Am 03.06.2016 um 15:05 schrieb Michael Haupt <michael.ha...@oracle.com>:
> lower-case thumbs up, and I'll be happy to sponsor the push.

I accidentally used my user ID for the push. Sorry about that.

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR:DK-8148457(Remove jdk.nashorn.tools.FXShell class and associated build.xml cruft)

[Michael Haupt]

Hi Srini,

lower-case thumbs up, and I'll be happy to sponsor the push.

Best,

Michael

> Am 03.06.2016 um 14:39 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> 
> Hi,
> 
> Please review:
> http://cr.openjdk.java.net/~sdama/8148457/webrev.00/ 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8148457 
> 
> I have verified all debug logs generated out of make targets for jdk9 forest 
> build and 
> nashorn ant targets.
> 
> Regards,
> Srinivas

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8158467: AccessControlException is thrown on public Java class access if "script app loader" is set to null

[Michael Haupt]

Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 02.06.2016 um 07:10 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8158467/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8158467
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8158250: nashorn ant javadoc targets are broken

[Michael Haupt]

Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 31.05.2016 um 17:00 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review  http://cr.openjdk.java.net/~sundar/8158250/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8158250
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8158131: Nashorn should not use jdk.internal.module.Modules API

[Michael Haupt]

Hi Sundar,

lower-case thumbs up for both the jdk and nashorn changes, with remarks:

== ModuleGraphManipulator.java ==

* please add a @see or @link to the place where the bytes are read and code is 
dynamically generated, or used, and vice versa.

== JavaAdapterBytecodeGenerator.java ==
 
+private static final Module nashornModule = 
JavaAdapterBytecodeGenerator.class.getModule();

This borders on the emerging discipline of Jigsaw idioms and patterns ... 
assuming this class moves, at some point in the future, to another (internal?) 
module. This will itch. How about having one central authority saying "I 
represent the Nashorn module", rather than implicitly assuming the class at 
hand will be in that module forever? One line below, Object.class.getModule() 
looks like a waterproof representative for the java.base module.

+private static byte[] MODULES_READ_ADDER_BYRES;

If it cannot be final, how about @Stable? It would help, if not in terms of 
performance, so at least to document that this is an array that will be 
populated *once* and never change thereafter.

+// private static final Module myModule;
+{
+FieldVisitor fv = cw.visitField(ACC_PRIVATE | ACC_FINAL | 
ACC_STATIC,
+"myModule", "Ljava/lang/reflect/Module;", null, null);
+fv.visitEnd();
+}

Suggestion: adhere to Java coding style even in generated code and spell this 
as MY_MODULE.

Best,

Michael

> Am 30.05.2016 um 10:24 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8158131/ for
> https://bugs.openjdk.java.net/browse/JDK-8158131
> 
> This code cleanup is to avoid Nashorn's use of JDK internal class
> jdk.internal.module.Modules.
> 
> With this change, nashorn uses java.lang.reflect.Layer public API to
> create single Module layers as needed.  And nashorn generates/loads code
> into appropriate modules (which calls java.lang.reflect.Module.addReads,
> .addExports public APIs) to add module export/read edges as needed.
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8157819: TypeError when a java.util.Comparator object is invoked as a function

[Michael Haupt]

Hi Sundar,

lower-case thumbs up, with remarks.

* "is this a overridable" -> "... an overridable"

* My feeling: the name isOverridableObjectMethod would describe the method's 
intent more clearly.

* How about comparing the method types to statically initialised MethodType 
instances obtained from the methods in question?

Best,

Michael

> Am 25.05.2016 um 12:49 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8157819/webrev.00 for
> https://bugs.openjdk.java.net/browse/JDK-8157819
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8157680: Callback parameter of any JS builtin implementation should accept any Callable

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 24.05.2016 um 15:52 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8157680/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8157680
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(XXS): 8157444: exclude jjs shebang handling test from runs

[Michael Haupt]

Dear all,

please review this fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8157444
Webrev: http://cr.openjdk.java.net/~mhaupt/8157444/webrev.00/

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8066229: Fuzzing bug: Can't find scope depth

[Michael Haupt]

Hi Hannes,

lower-case thumbs up.

Best,

Michael

> Am 18.05.2016 um 18:36 schrieb Hannes Wallnöfer <hann...@gmail.com>:
> 
> Please review JDK-8066229: Fuzzing bug: Can't find scope depth
> 
> http://cr.openjdk.java.net/~hannesw/8066229/webrev/
> 
> This adds a test case for bug that is already fixed. It also removes the 
> EXPECTED file added in the previous commit (JDK-8157250).
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8157263: Octane svn repository no longer exists

[Michael Haupt]

Hi Hannes,

lower-case thumbs up.

Best,

Michael

> Am 18.05.2016 um 19:50 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review JDK-8157263: Octane svn repository no longer exists:
> 
> http://cr.openjdk.java.net/~hannesw/8157263/webrev/
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8157250: BeanLinker assumes fixed array type linkage

[Michael Haupt]

Dear all,

please review this fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8157250
Webrev: http://cr.openjdk.java.net/~mhaupt/8157250/webrev.00/

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR(S): 8157225: adopt method handle for array length getter in BeanLinker

[Michael Haupt]

Hi Attila,

thanks for your comments.

> Am 18.05.2016 um 16:11 schrieb Attila Szegedi <szege...@gmail.com>:
> There’s a bit of an issue with this. Namely, the old GET_ARRAY_LENGTH being 
> the unreflection of j.l.reflect.Array.getLength() worked for any array type, 
> so it was always accompanied with ValidationType.IS_ARRAY. I believe this is 
> wrong now and can cause ClassCastException at runtime (I say “believe” as I 
> can’t currently build jdk 9 so can’t confirm). This could be caught by a test 
> that handles two arrays of different types in the same call site, e.g. with 
> Nashorn:
> 
>  var intArray = Java.type(“int[]”)
>  var doubleArray = Java.type(“double[]”)
>  var arrs = [new intArray(0), new doubleArray(0)]
>  for (var i in arrs) arrs[i].length

Confirmed:

$ jjs
jjs> var intArray = Java.type("int[]")
jjs> var doubleArray = Java.type("double[]")
jjs> var arrs = [new intArray(0), new doubleArray(0)]
jjs> for (var i in arrs) arrs[i].length
java.lang.ClassCastException: Cannot cast [D to [I

> Since the MethodHandles.arrayLength is typed to the concrete array class, it 
> should be used with ValidationType.EXACT_CLASS.

Also confirmed:

$ jjs
jjs> var intArray = Java.type("int[]")
jjs> var doubleArray = Java.type("double[]")
jjs> var arrs = [new intArray(0), new doubleArray(0)]
jjs> for (var i in arrs) arrs[i].length
0

> This will obviously cause call sites taking length of different kinds of 
> arrays more polymorphic… FWIW, the IS_ARRAY validation type is probably 
> obsolete now as it was only used for array length getters anyway.

Yes; there are two uses of IS_ARRAY that can be replaced with EXACT_CLASS ...

> The polymorphism could be somewhat alleviated by having stable validation for 
> all arrays of reference types. Maybe have one 
> MethodHandles.arrayLength(Object[].class) handle cached to use with all 
> arrays of reference types, and use a Validator(Object[].class, 
> ValidationType.INSTANCE_OF) with it. Then you’d have stable linkage that can 
> take the length of any reference-typed array, but you’d still trigger 
> relinking for primitive-typed arrays.

... but shouldn't, right.

I've filed a bug to adopt the quick fix with EXACT_CLASS [1], and another to 
deal with the relinking problem [2]. The solution you suggest should be 
possible; maybe the IS_ARRAY abstraction can be reused for this in a way that 
avoids relinking for primitive arrays by having a PIC-like structure.

Best,

Michael

[1] https://bugs.openjdk.java.net/browse/JDK-8157250
[2] https://bugs.openjdk.java.net/browse/JDK-8157251


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8157241: Remove javac warnings of Nashorn "ant clean test"

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 18.05.2016 um 14:01 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8157241/ for
> https://bugs.openjdk.java.net/browse/JDK-8157241
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8157225: adopt method handle for array length getter in BeanLinker

[Michael Haupt]

Dear all,

please review this change.
RFE: https://bugs.openjdk.java.net/browse/JDK-8157225
Webrev: http://cr.openjdk.java.net/~mhaupt/8157225/webrev.00/

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8157160: JSON.stringify does not work on ScriptObjectMirror objects

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 18.05.2016 um 08:50 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8157160/ for
> https://bugs.openjdk.java.net/browse/JDK-8157160
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8144711: (x) => x + 1 causes Assertion failure instead of SyntaxError

[Michael Haupt]

Hi Hannes,

hang on; one note: the test will "succeed" if the parser throws no exception. 
It should probably verify that there is an exception in the first place:

caught = false
try {
  ...
} catch (e) {
  assert ...
  caught = true
}
Assert.assertTrue(caught)

Best,

Michael

> Am 04.05.2016 um 11:05 schrieb Michael Haupt <michael.ha...@oracle.com>:
> 
> Hi Hannes,
> 
> lower-case thumbs up!
> 
> Best,
> 
> Michael
> 
>> Am 04.05.2016 um 10:49 schrieb Hannes Wallnoefer 
>> <hannes.wallnoe...@oracle.com <mailto:hannes.wallnoe...@oracle.com>>:
>> 
>> Please review JDK-8144711: (x) => x + 1 causes Assertion failure instead of 
>> SyntaxError:
>> 
>> http://cr.openjdk.java.net/~hannesw/8144711/ 
>> <http://cr.openjdk.java.net/~hannesw/8144711/>
>> 
>> Thanks,
>> Hannes


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8144711: (x) => x + 1 causes Assertion failure instead of SyntaxError

[Michael Haupt]

Hi Hannes,

lower-case thumbs up!

Best,

Michael

> Am 04.05.2016 um 10:49 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review JDK-8144711: (x) => x + 1 causes Assertion failure instead of 
> SyntaxError:
> 
> http://cr.openjdk.java.net/~hannesw/8144711/
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8155944: ant build/test of nashorn is broken with the latest jdk9-dev build

[Michael Haupt]

Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 03.05.2016 um 17:24 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Hi,
> 
> Please review http://cr.openjdk.java.net/~sundar/8155944/webrev/ for
> https://bugs.openjdk.java.net/browse/JDK-8155944
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8134503: support ES6 parsing in Nashorn

[Michael Haupt]

Hi Hannes,

that's a really significant improvement, thanks for taking this on!

There is one thing that I think needs to be addressed. Several occurrences of 
throw error(...) pass a plain English string, rather than passing the result of 
a call to AbstractParser.message(...), which stands in the path of message 
internationalisation. Some invocations of String.format() in this setting pass 
only a String but no arguments (these will go away automatically when the 
messages are converted to retrieval).

Nits:

* Block.java - this (in the first chunk) can go away, or should not be 
commented out:
+// assert start <= finish;

* Parser.java - the label here should be indented:
+private void statementList() {
+// Accumulate statements until end of list. */
+loop:
+while (type != EOF) {
+switch (type) {
+case EOF:

Best,

Michael


> Am 25.04.2016 um 13:49 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review JDK-8134503: support ES6 parsing in Nashorn
> 
> http://cr.openjdk.java.net/~hannesw/8134503/webrev/
> 
> The original patch was contributed by Andreas Woess, I just did the 
> integration into Nashorn tip.
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8137149: add tests for issues closed during Nashorn issue cleanup

[Michael Haupt]

Dear all,

please review this change.
RFE: https://bugs.openjdk.java.net/browse/JDK-8137149
Webrev: http://cr.openjdk.java.net/~mhaupt/8137149/webrev.00/

The change adds tests for two issues that were previously not covered by tests, 
and that were closed as already fixed by other changes.

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR: JDK-8075550 - Error "JavaFX runtime not found" in nashorn when load predefines scripts to import JavaFX packages

[Michael Haupt]

Hi Jim,

lower-case thumbs up!

Best,

Michael

> Am 08.04.2016 um 19:05 schrieb Jim Laskey (Oracle) <james.las...@oracle.com>:
> 
> The code was reworked to use jrtfs: instead of reading from javafx.jar.
> 
> http://cr.openjdk.java.net/~jlaskey/8075550/webrev/index.html
> https://bugs.openjdk.java.net/browse/JDK-8075550
> 
> 
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8147613

[Michael Haupt]

Hi Srini,

lower-case thumbs up. Running the jjs tests on Windows is excellent progress. 
I'll sponsor the push.

Best,

Michael

> Am 18.03.2016 um 15:01 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> 
> Hi,
> 
> Please review :
> Webrev : http://cr.openjdk.java.net/~sdama/8147613/webrev.00/
> It covers fix for both:
> https://bugs.openjdk.java.net/browse/JDK-8147613
> https://bugs.openjdk.java.net/browse/JDK-8147788
> 
> Regards,
> Srinivas
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8151809: ES6 Map/Set insertion with existing keys changes iteration order

[Michael Haupt]

Hi Hannes,

lower-case thumbs up.

Best,

Michael

> Am 14.03.2016 um 17:09 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review:
> 
> Webrev: http://cr.openjdk.java.net/~hannesw/8151809/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8151809
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8138906

[Michael Haupt]

Hi Srinivas,

this has already been reviewed; here's the thread: 
http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-February/005991.html

I'll sponsor the push.

Best,

Michael

> Am 11.03.2016 um 10:08 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> 
> Hi,
> 
> Please review http://cr.openjdk.java.net/~sdama/8138906/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8138906
> 
> I did testing with recent $EXEC changes from Michael and very small code 
> cleanup.
> 
> Regards,
> Srinivas

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

[Michael Haupt]

Hi Sundar,

lower-case thumbs up, with one remark about the test. It seems the lower part 
of the test method is independent of the upper part; separate aspects should 
IMHO be tested separetely, i.e., in two different methods.

Best,

Michael

> Am 10.03.2016 um 10:06 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.01/ for
> https://bugs.openjdk.java.net/browse/JDK-8150731
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(XS): 8151518: relax test requirements to reduce dependency on directory contents

[Michael Haupt]

Dear all,

please review this fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8151518
Webrev: http://cr.openjdk.java.net/~mhaupt/8151518/webrev.00/

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

[Michael Haupt]

All,

the updated webrev is at http://cr.openjdk.java.net/~mhaupt/8151291/webrev.01/ 
- please review.

The issue is a bit deeper. The way the current working directory is initialised 
and subsequently handled was the root cause of the observed problems. Cygwin 
being a unixy environment somewhat forcefully inflicted on Windows, and Java 
assuming that the underlying platform is, after all, Windows and consequently 
using Windows path conventions did not coexist too well.

The gist of the fix is to unconditionally initialise $ENV.PWD to the Java 
property user.dir, which is always in a form that the underlying platform can 
understand.

Thanks,

Michael

> Am 08.03.2016 um 15:50 schrieb Michael Haupt <michael.ha...@oracle.com>:
> 
> All,
> 
> I revoke the RFR for the time being; there is another issue with invoking 
> $EXEC from within a Cygwin directory that does not have a /cygdrive prefix 
> (e.g., /home/...). This will require some deeper investigation.
> 
> Once a solution is in place, I will post another RFR in this thread.
> 
> Best,
> 
> Michael
> 
>> Am 08.03.2016 um 11:35 schrieb Michael Haupt <michael.ha...@oracle.com>:
>> 
>> Hi Srini,
>> 
>>> Am 07.03.2016 um 19:36 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
>>> Few limitations with absolute paths.
>>> On cmd.exe:
>>> jjs -scripting
>>> $EXEC("D:\work\nashorn-dev\dev\build\windows-x86_64-normal-server-release\images\jdk\bin\java.exe")
>>>  
>> 
>> I assume you meant to say this fails - using double backslashes helps. :-)
>> 
>>> Good thing is on cygwin if we give mixed path like:
>>> $EXEC("D:/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe"),it
>>>  works.
>>> But 
>>> $EXEC("/cygdrive/d/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe")
>>>  fails.
>> 
>> Yes, that's not right. I've addressed that. I need another round of reviews 
>> please: http://cr.openjdk.java.net/~mhaupt/8151291/webrev.00 (note that I 
>> accidentally deleted the previous webrev).
>> 
>> Thanks,
>> 
>> Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

[Michael Haupt]

All,

I revoke the RFR for the time being; there is another issue with invoking $EXEC 
from within a Cygwin directory that does not have a /cygdrive prefix (e.g., 
/home/...). This will require some deeper investigation.

Once a solution is in place, I will post another RFR in this thread.

Best,

Michael

> Am 08.03.2016 um 11:35 schrieb Michael Haupt <michael.ha...@oracle.com>:
> 
> Hi Srini,
> 
>> Am 07.03.2016 um 19:36 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
>> Few limitations with absolute paths.
>> On cmd.exe:
>> jjs -scripting
>> $EXEC("D:\work\nashorn-dev\dev\build\windows-x86_64-normal-server-release\images\jdk\bin\java.exe")
>>  
> 
> I assume you meant to say this fails - using double backslashes helps. :-)
> 
>> Good thing is on cygwin if we give mixed path like:
>> $EXEC("D:/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe"),it
>>  works.
>> But 
>> $EXEC("/cygdrive/d/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe")
>>  fails.
> 
> Yes, that's not right. I've addressed that. I need another round of reviews 
> please: http://cr.openjdk.java.net/~mhaupt/8151291/webrev.00 (note that I 
> accidentally deleted the previous webrev).
> 
> Thanks,
> 
> Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

[Michael Haupt]

Hi Srini,

> Am 07.03.2016 um 19:36 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> Few limitations with absolute paths.
> On cmd.exe:
> jjs -scripting
> $EXEC("D:\work\nashorn-dev\dev\build\windows-x86_64-normal-server-release\images\jdk\bin\java.exe")
>  

I assume you meant to say this fails - using double backslashes helps. :-)

> Good thing is on cygwin if we give mixed path like:
> $EXEC("D:/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe"),it
>  works.
> But 
> $EXEC("/cygdrive/d/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe")
>  fails.

Yes, that's not right. I've addressed that. I need another round of reviews 
please: http://cr.openjdk.java.net/~mhaupt/8151291/webrev.00 (note that I 
accidentally deleted the previous webrev).

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

[Michael Haupt]

Hi Jim,

thanks -

> Am 07.03.2016 um 13:36 schrieb Jim Laskey (Oracle) <james.las...@oracle.com>:
> 1. use a final static for "/cygdrive"

I've added that.

> 2. Are you sure you want the ex.printStackTrace(); left in

No; that's a leftover from investigating.

I'll push with these changes applied once the second review comes in.

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

[Michael Haupt]

Dear all,

please review this change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8151291
Webrev: http://cr.openjdk.java.net/~mhaupt/8151291/webrev.00/

For Cygwin, paths need special attention as the /cygdrive/x/... format is not 
recognised by Windows.

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8138906

[Michael Haupt]

Hi Srinivas,

> Am 29.02.2016 um 17:28 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> Please review :
> Bug : https://bugs.openjdk.java.net/browse/JDK-8138906
> Webrev : http://cr.openjdk.java.net/~sdama/8138906/webrev.01

I've verified this works on Windows. Lower-case thumbs up, with these remarks:

== JDK-util.js ==

Lines 64/65: typos, please use
"Unix cygpath implementation.
Supports only two outputs, windows (C:\dir\) and mixed (C:/dir/)."

== JDK-8087292.js ==

Copyright: convention requires a space after the comma in "2015,2016", and a 
comma after "2016", i.e., please use "2015, 2016, ".

As a matter of personal preference, how about using semicolons consistently, 
i.e., either at the ends of all lines, or never?

> I have added some utility functions(can be added more) which can be used in 
> all nashorn test case to make them work
> Independent of underlying shell.(removed dependency on shell commands like : 
> which)

These look useful and should be adopted by more tests (that's a future RFE).

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8150218: Autoconversion SAM adapters sometimes don't get privileges

[Michael Haupt]

Hi Attila,

> Am 28.02.2016 um 04:37 schrieb Attila Szegedi <szege...@gmail.com>:
> Please review JDK-8150218 "Autoconversion SAM adapters sometimes don't get 
> privileges" at <http://cr.openjdk.java.net/~attila/8150218/webrev.jdk9> for 
> <https://bugs.openjdk.java.net/browse/JDK-8150218>


lower-case thumbs up, with one remark about SecureLookupSupplier, lines 57/58: 
not sure the exact same text is really needed twice. :-)

There also is a little webrev issue: the change for ScriptUtils.java is empty 
in the webrev, but appears in the patch. It seems this is because the change in 
that file is simply the removal of a single space character.

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(XXS): 8150814: correct package declaration in Nashorn test

[Michael Haupt]

Dear all,

please review this very small fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8150814
Webrev: http://cr.openjdk.java.net/~mhaupt/8150814/webrev.00/

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR(S): 8148140: arguments are handled differently in apply for JS functions and AbstractJSObjects

[Michael Haupt]

Hi Attila,

> Am 28.02.2016 um 04:05 schrieb Attila Szegedi <szege...@gmail.com>:
> Sorry, late to the party here, but it seems to me that there’s a discrepancy 
> between the path 
>  and the 
> "package jdk.nashorn.internal.runtime.test" declaration it contains.

whoa, thanks, Attila. Tracked in 
https://bugs.openjdk.java.net/browse/JDK-8150814, fix coming soon.

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8148379: jdk.nashorn.api.scripting spec. adjustments, clarifications

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 25.02.2016 um 03:47 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8148379/webrev.01/ for 
> https://bugs.openjdk.java.net/browse/JDK-8148379
> 
> Specdiff is here -> 
> http://cr.openjdk.java.net/~sundar/8148379/specdiff0.1/overview-summary.html
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8147558: Add support for ES6 collections

[Michael Haupt]

Hi Hannes,

lower-case thumbs up.

Best,

Michael

> Am 12.02.2016 um 13:55 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Hi Attila,
> 
> sorry for the interrupted conversation, I've been on vacation for most of 
> this week.
> 
> Having had some time to think about the synchronization issue I've come to 
> agree with you. Making LinkedMap synchronized was overshooting the mark, and 
> basically meant protecting against wrong use of Nashorn.
> 
> I've uploaded a new webrev that follows most of your suggestions:
> 
> http://cr.openjdk.java.net/~hannesw/8147558/webrev.01/
> 
> I've decided to keep the NativeArray methods in their slightly redundant form 
> as I think the level of repetition is bearable and your distaste of it did 
> not seem too strong :)
> 
> Since the patch is quite large I've also uploaded a patch with just the 
> changes from the first webrev:
> 
> http://cr.openjdk.java.net/~hannesw/8147558/changes-attila
> 
> Thanks,
> Hannes
> 
> 
> Am 2016-02-05 um 16:31 schrieb Attila Szegedi:
>> On Feb 5, 2016, at 3:13 PM, Hannes Wallnoefer <hannes.wallnoe...@oracle.com> 
>> wrote:
>>> Thanks for the review, Attila!
>>> 
>>> Am 2016-02-05 um 14:17 schrieb Attila Szegedi:
>>>> Global.java:
>>>> - Documentation for Global.setWeakSet() is wrong.
>>>> - It’s kinda too bad we can’t generalize those getters with lazy sentinel 
>>>> and builtin getters. I guess we could if they weren’t stored in fields. 
>>>> Sounds like a good future use case for a VarHandle :-)
>>>> - Global.initPrototype uses the “jdk.nashorn.internal.objects." string 
>>>> literal. It’s already used by Global.initConstructor too, maybe extract it 
>>>> into a constant? (FWIW, it also appears without the trailing dot in 
>>>> NashornLoader.java; maybe unify it into a single place somewhere?)
>>> Thanks, will fix the documentation and clean up the string literals.
>>> 
>>>> NativeArray.java:
>>>> - I’d refactor the common idiom in entries, keys, values, and getIterator 
>>>> into a separate method parametrized on iteration kind. FWIW, getIterator 
>>>> and values look exactly the same.
>>> I'm not sure I understand. These are separate methods because each one 
>>> defines a @Function for nasgen. Of course we could extend the @Function 
>>> annotation to allow one Java method to define multiple JS functions. But 
>>> these methods are one-liners anyway, so I doubt it would get much simpler.
>> private static Object createIterator(final Object self, final 
>> AbstractIterator.IterationKind kind) {
>> return new ArrayIterator(Global.toObject(self), kind, Global.instance());
>> }
>> 
>> then
>> 
>> @Function(attributes = Attribute.NOT_ENUMERABLE)
>> public static Object entries(final Object self) {
>> return createIterator(AbstractIterator.IterationKind.KEY_VALUE);
>> }
>> 
>> etc. No big deal, but I like to eliminate all copy-paste code.
>> 
>>>> LinkedMap.java:
>>>> - why does it need to be safe for concurrent use? Seems unnecessary to me.
>>> You're right, it's not a requirement, but I think it's nice to have given 
>>> the ubiquity of multithreading on the Java platform.
>> I’m still in disagreement. For one argument, that makes this class closer to 
>> Java 1.1 Hashtable than to HashMap. The trend in collection classes is to 
>> not make them thread safe unless they’re specifically concurrent. For 
>> another argument, we also consciously don’t make JS classes thread safe 
>> since the JS language is not thread safe, so we don’t want to incur 
>> synchronization overhead in the majority usage single-threaded case. 
>> ScriptObject is not thread safe either. It’s a design principle we followed 
>> so far: JS objects homed in a single global are not thread safe; backing 
>> structures shared across globals in a context (compiled functions etc.) are 
>> thread safe. Having a class that violates this distinction can provide a 
>> misunderstanding in someone reading the code about these design principles.
>> 
>> Of course, if the class would start to be used in a different context too, 
>> then it might be justified to add synchronization to it (or just have it 
>> implement java.util.Map and use Collections.synchronizedMap when this is 
>> desired).
>> 
>>>> WeakMap and WeakSet: didn’t you need the guarantees of LinkedMap with them 
>>>> too? I guess not.
>>> The weak collections do not allow element

Re: Review request for JDK-8149451: Fix bytecode generation issue after 8149186

[Michael Haupt]

Hi Attila,

this may have been lost in the noise, but you have two reviews, and the nightly 
build failure only seemed to have anything to do with your change, so you're 
good to go. :-)

Best,

Michael

> Am 12.02.2016 um 16:30 schrieb Michael Haupt <michael.ha...@oracle.com>:
> 
> Hi Attila,
> 
>> Am 11.02.2016 um 15:38 schrieb Attila Szegedi <szege...@gmail.com>:
>> This is frankly maddening :-)
> 
> 
> rightfully so, as it turns out this code is not the cause of the observed 
> nightly failures. See https://bugs.openjdk.java.net/browse/JDK-8149727. The 
> push for 8149186 merely coincided with the first nightly breaks. Sorry about 
> the fuss.
> 
> So, consider this a lower-case thumbs-up review. :-)
> 
> Best,
> 
> Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

[8u] approval request for 8149744: fix testng.jar delivery in Nashorn build.xml

[Michael Haupt]

Dear all,

please approve the backport of the following patch to 8u.

Bug: https://bugs.openjdk.java.net/browse/JDK-8149744
JDK 9 review thread: 
http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-February/005955.html
8u webrev: http://cr.openjdk.java.net/~mhaupt/8149744-8u/webrev.00/

The patch for 8u differs from the one for 9 as the affected files were 
different.

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8149744: fix testng.jar delivery in Nashorn build.xml

[Michael Haupt]

Dear all,

please review this fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8149744
Webrev: http://cr.openjdk.java.net/~mhaupt/8149744/webrev.00/

Nashorn's build.xml used to download a TestNG ZIP file and extract the required 
testng.jar from that. The URL of the ZIP file is no longer valid. The change 
addresses this by having build.xml download the four required JAR files (TestNG 
and dependencies).

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8149451: Fix bytecode generation issue after 8149186

[Michael Haupt]

Hi Attila,

> Am 11.02.2016 um 15:38 schrieb Attila Szegedi <szege...@gmail.com>:
> This is frankly maddening :-)


rightfully so, as it turns out this code is not the cause of the observed 
nightly failures. See https://bugs.openjdk.java.net/browse/JDK-8149727. The 
push for 8149186 merely coincided with the first nightly breaks. Sorry about 
the fuss.

So, consider this a lower-case thumbs-up review. :-)

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8149451: Fix bytecode generation issue after 8149186

[Michael Haupt]

Hi Attila,

I'm very sorry, but testing this I keep getting - occasionally! - crashes of 
the observed kind (see below).

Best,

Michael

 [java] Test(compile, run): 
test/script/external/test262/test/suite/ch15/15.5/15.5.4/15.5.4.19/S15.5.4.19_A7.js
 [java] java.lang.AssertionError: Failed generating bytecode for 
test/script/external/test262/test/harness/sta.js:-1
 [java] at 
jdk.nashorn.internal.codegen.CompilationPhase$BytecodeGenerationPhase.transform(CompilationPhase.java:436)
 [java] at 
jdk.nashorn.internal.codegen.CompilationPhase.apply(CompilationPhase.java:630)
 [java] at 
jdk.nashorn.internal.codegen.Compiler.compile(Compiler.java:656)
 [java] at 
jdk.nashorn.internal.runtime.RecompilableScriptFunctionData.compileTypeSpecialization(RecompilableScriptFunctionData.java:717)
 [java] at 
jdk.nashorn.internal.runtime.RecompilableScriptFunctionData.getBest(RecompilableScriptFunctionData.java:897)
 [java] at 
jdk.nashorn.internal.runtime.ScriptFunctionData.getBest(ScriptFunctionData.java:392)
 [java] at 
jdk.nashorn.internal.runtime.ScriptFunctionData.getBestInvoker(ScriptFunctionData.java:254)
 [java] at 
jdk.nashorn.internal.runtime.ScriptFunction.findCallMethod(ScriptFunction.java:915)
 [java] at 
jdk.nashorn.internal.runtime.ScriptObject.lookup(ScriptObject.java:1862)
 [java] at 
jdk.nashorn.internal.runtime.linker.NashornLinker.getGuardedInvocation(NashornLinker.java:102)
 [java] at 
jdk.nashorn.internal.runtime.linker.NashornLinker.getGuardedInvocation(NashornLinker.java:94)
 [java] at 
jdk.dynalink.linker.support.CompositeTypeBasedGuardingDynamicLinker.getGuardedInvocation(CompositeTypeBasedGuardingDynamicLinker.java:184)
 [java] at 
jdk.dynalink.linker.support.CompositeGuardingDynamicLinker.getGuardedInvocation(CompositeGuardingDynamicLinker.java:132)
 [java] at 
jdk.dynalink.LinkerServicesImpl.getGuardedInvocation(LinkerServicesImpl.java:146)
 [java] at jdk.dynalink.DynamicLinker.relink(DynamicLinker.java:262)
 [java] at 
jdk.nashorn.internal.scripts.Script$Recompilation$528212$18490D$sta.DaylightSavingTA(test/script/external/test262/test/harness/sta.js:651)
 [java] at 
jdk.nashorn.internal.scripts.Script$Recompilation$528211$sta.:program(test/script/external/test262/test/harness/sta.js:566)
 [java] at 
jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:654)
 [java] at 
jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:511)
 [java] at 
jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)
 [java] at 
jdk.nashorn.internal.test.framework.SharedContextEvaluator.run(SharedContextEvaluator.java:135)
 [java] at 
jdk.nashorn.internal.test.framework.AbstractScriptRunnable.evaluateScript(AbstractScriptRunnable.java:200)
 [java] at 
jdk.nashorn.internal.test.framework.ParallelTestRunner$ScriptRunnable.execute(ParallelTestRunner.java:202)
 [java] at 
jdk.nashorn.internal.test.framework.AbstractScriptRunnable.runTest(AbstractScriptRunnable.java:132)
 [java] at 
jdk.nashorn.internal.test.framework.ParallelTestRunner$ScriptRunnable.call(ParallelTestRunner.java:281)
 [java] at 
jdk.nashorn.internal.test.framework.ParallelTestRunner$ScriptRunnable.call(ParallelTestRunner.java:124)
 [java] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 [java] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1158)
 [java] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:632)
 [java] at java.lang.Thread.run(Thread.java:804)
 [java] Caused by: java.lang.NullPointerException

> Am 11.02.2016 um 13:28 schrieb Attila Szegedi <szege...@gmail.com>:
> 
> Please review JDK-8149451 "Fix bytecode generation issue after 8149186" at 
> <http://cr.openjdk.java.net/~attila/8149451/webrev.jdk9> for 
> <https://bugs.openjdk.java.net/browse/JDK-8149451>
> 
> This changeset is basically identical to JDK-8149186 but it will allow 
> optimistic addition on booleans. I have implemented it by delegating to 
> Type.INT.add instead of copy-pasting the code, but that should not cause 
> issues (famous last words, right?). If you have the opportunity to re-test on 
> Linux, that'd be appreciated (I have no Linux machines around).
> 
> Thanks,
>  Attila.

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE 

Re: RFR - JDK-8141209 $EXEC should allow streaming of output

[Michael Haupt]

Hi Jim,

tested on Mac, Windows (Cygwin), Linux. Lower-case thumbs up, with one remark:

** ScriptingFunctions.java **

In the exec() method, I'd really like to have a check to make sure no illegal 
argument combination goes unnoticed. If arguments are passed that do not 
conform to any of the four forms, there should be an error message.

Best,

Michael

> Am 09.02.2016 um 21:18 schrieb Jim Laskey (Oracle) <james.las...@oracle.com>:
> 
> https://bugs.openjdk.java.net/browse/JDK-8141209
> http://cr.openjdk.java.net/~jlaskey/8141209/webrev/index.html
> 
> Rough documentation can be found at 
> https://community.oracle.com/community/java/javascript-nashorn/blog/2016/02/08/proposal-for-exec-20
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8149462: revert changes for 8149186

[Michael Haupt]

Dear all,

please review this fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8149462
Webrev: http://cr.openjdk.java.net/~mhaupt/8149462/webrev.00

The changes introduced for JDK-8149186 [1] led to nightly build failures and 
reproducible crashes in test262parallel on Linux. A fix is proposed [2] but is 
pending investigation. To stabilise the nightly builds, the changes that 
introduced the errors should be reverted for the time being.

Thanks,

Michael

[1] https://bugs.openjdk.java.net/browse/JDK-8149186
[2] https://bugs.openjdk.java.net/browse/JDK-8149451

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8149334: JSON.parse(JSON.stringify([])).push(10) creates an array containing two elements

[Michael Haupt]

Dear all,

please review this fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8149334
Webrev: http://cr.openjdk.java.net/~mhaupt/8149334/webrev.00

The problem here is that the transition from an immutable empty array (of the 
internal type ArrayData.UntouchedArrayData) to an array containing actual data 
would create an array with one entry before then appending the pushed element. 
The fix is to return an actually empty (if mutable) ArrayData instance in these 
cases.

Tested in 9-dev and 8u. As this was filed against 8u60, it will be backported.

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8149186: Don't use indy for optimistic arithmetic

[Michael Haupt]

Hi Attila,

lower-case thumbs up; please adjust copyright years.

Best,

Michael

> Am 07.02.2016 um 19:18 schrieb Attila Szegedi <szege...@gmail.com>:
> 
> Please review JDK-8149186 "Don't use indy for optimistic arithmetic" at 
> <http://cr.openjdk.java.net/~attila/8149186/webrev.jdk9> for 
> <https://bugs.openjdk.java.net/browse/JDK-8149186>
> 
> Thanks,
>  Attila.

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(M): 8147591: Revisit Collection.toArray(new T[size]) calls in nashorn and dynalink code

[Michael Haupt]

Dear all,

please review this change by Srinivas Dama, which I'm sponsoring.
Bug: https://bugs.openjdk.java.net/browse/JDK-8147591
Webrev: http://cr.openjdk.java.net/~mhaupt/8147591/webrev.00

The change adopts the Collection.toArray(new T[0]) idiom consistently 
throughout the Nashorn code base.

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for backport of JDK-8146274: Thread spinning on WeakHashMap.getEntry() with concurrent use of nashorn

[Michael Haupt]

Hi Hannes,

lower-case thumbs up!

Best,

Michael

> Am 27.01.2016 um 13:43 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review backport of JDK-8146274.
> 
> Webrev: http://cr.openjdk.java.net/~hannesw/8146274/webrev-8u/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146274
> 
> The patch needed a small change because the key type of the listeners map 
> changed. Also, the original patch included jjs documentation, which is not 
> available in 8u.
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8148040 : jjs -fx test does not exit

[Michael Haupt]

Hi Hannes,

the FX option test opens a window and "hangs" when JAVA_HOME is pointed to an 
FX-enabled JDK 9 early access release. It does not show this bad behaviour when 
it is run in the 9-dev context. I confirm the test passes in both cases (on 
Mac) with your fix applied.

Lower-case thumbs up.

Best,

Michael

> Am 22.01.2016 um 11:18 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review JDK-8148040: jjs -fx test does not exit:
> 
> http://cr.openjdk.java.net/~hannesw/8148040/webrev/
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(XXS): 8134933: re-enable LambdaFormEditor assertions in Nashorn testing

[Michael Haupt]

Dear all,

please review this change.
Task: https://bugs.openjdk.java.net/browse/JDK-8134933
Change: http://cr.openjdk.java.net/~mhaupt/8134933/webrev.00

These assertions can be re-enabled, especially given that Nashorn depends on 
JDK 9 to be built.

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR(M): 8144113: enable jjs testing

[Michael Haupt]

Hi Attila,

in addition to Sundar's remark about this only being a @subtest, I can report 
successful execution of "which" on Cygwin. :-)

Best,

Michael

> Am 19.01.2016 um 15:04 schrieb Attila Szegedi <szege...@gmail.com>:
> 
> Wouldn't test/script/nosecurity/jjs-common.js.html also need @runif 
> os.not.windows? It executes “which”, which I seem to remember doesn’t exist 
> on Windows. (Windows has “where” instead, which might or might not be good 
> enough; I don’t know…)
> 
>> On Jan 19, 2016, at 2:56 PM, Michael Haupt <michael.ha...@oracle.com> wrote:
>> 
>> Dear all,
>> 
>> please review this change by Srinivas Dama, which I'm sponsoring.
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8144113
>> Webrev: http://cr.openjdk.java.net/~mhaupt/8144113/webrev.00
>> 
>> The change contains some tests for the jjs executable. They are implemented 
>> in JavaScript themselves and extensively use the scripting capabilities of 
>> Nashorn. 
>> 
>> Thanks,
>> 
>> Michael


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR(M): 8144113: enable jjs testing

[Michael Haupt]

Hi Attila,

indeed the "ant test" task will fail for those tests that rely on Cygwin 
binaries when executed from the cmd.exe shell prompt. The number of tests that 
do so is minuscule. Still, since tests failing in such circumstances is untidy, 
these should be enabled for Win/Cygwin only. Filed as 
https://bugs.openjdk.java.net/browse/JDK-8147788.

Best,

Michael

> Am 20.01.2016 um 12:05 schrieb Attila Szegedi <szege...@gmail.com>:
> Nice. Although, it is obvious Cygwin would provide a “which". Are our Windows 
> tests supposed to run on Cygwin only, not on vanilla Windows?
> 
>> On Jan 20, 2016, at 9:49 AM, Michael Haupt <michael.ha...@oracle.com> wrote:
>> 
>> Hi Attila,
>> 
>> in addition to Sundar's remark about this only being a @subtest, I can 
>> report successful execution of "which" on Cygwin. :-)
>> 
>> Best,
>> 
>> Michael
>> 
>>> Am 19.01.2016 um 15:04 schrieb Attila Szegedi <szege...@gmail.com>:
>>> 
>>> Wouldn't test/script/nosecurity/jjs-common.js.html also need @runif 
>>> os.not.windows? It executes “which”, which I seem to remember doesn’t exist 
>>> on Windows. (Windows has “where” instead, which might or might not be good 
>>> enough; I don’t know…)
>>> 
>>>> On Jan 19, 2016, at 2:56 PM, Michael Haupt <michael.ha...@oracle.com> 
>>>> wrote:
>>>> 
>>>> Dear all,
>>>> 
>>>> please review this change by Srinivas Dama, which I'm sponsoring.
>>>> RFE: https://bugs.openjdk.java.net/browse/JDK-8144113
>>>> Webrev: http://cr.openjdk.java.net/~mhaupt/8144113/webrev.00
>>>> 
>>>> The change contains some tests for the jjs executable. They are 
>>>> implemented in JavaScript themselves and extensively use the scripting 
>>>> capabilities of Nashorn. 
>>>> 
>>>> Thanks,
>>>> 
>>>> Michael


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8146274: Thread spinning on WeakHashMap.getEntry() with concurrent use of nashorn

[Michael Haupt]

Hi Hannes,

lower-case thumbs up, with two remarks on the doc changes:

-Object.prototype.toString=returns a string representing of this object
+Object.prototype.toString=returns a string representation this object
 
... should be "... of this object"

Likewise, for
+Function.prototype.toString=returns a string representation this function

Best,

Michael

> Am 15.01.2016 um 12:49 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review:
> 
> Webrev: http://cr.openjdk.java.net/~hannesw/8146274/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146274
> 
> I was not able to reproduce the issue although I tried my best to follow the 
> instructions. However, it is pretty clear that the issue is that the cause 
> for the concurrent modification exception is the sharing of  
> WeakPropertyMapSets between PropertyMapListeners.
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8144917: Prepare AbstractJavaLinker/BeanLinker codebase for missing member implementation

[Michael Haupt]

Hi Attila,

lower-case thumbs-up, with one remark: 
AbstractJavaLinker.getNextComponent(ComponentLinkRequest) could be rewritten 
like so (matching patterns applied elsewhere in the patch):

GuardedInvocationComponent getNextComponent(final ComponentLinkRequest req) 
throws Exception {
if (!req.operations.isEmpty()) {
final GuardedInvocationComponent gic = 
getGuardedInvocationComponent(req);
return gic != null ? gic : getNextComponent(req.popOperations());
}
return null;
}

Best,

Michael

> Am 23.12.2015 um 21:30 schrieb Attila Szegedi <szege...@gmail.com>:
> 
> Please review JDK-8144917 "Prepare AbstractJavaLinker/BeanLinker codebase for 
> missing member implementation" at 
> <http://cr.openjdk.java.net/~attila/8144917/webrev.jdk9> for 
> <https://bugs.openjdk.java.net/browse/JDK-8144917>
> 
> This change has no functional effects, it's a refactoring for easier 
> introduction of the no-such-member implementation (JDK-8144919), a review for 
> which will immediately follow. I only plan to commit the two together after 
> they have been both reviewed.
> 
> Thanks,
>  Attila.

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8144919: Implement missing member handler for BeansLinker

[Michael Haupt]

Hi Attila,

lower-case thumbs up, with one remark in addition to Sundar's. In 
BeansLinkerTest, related to the comment "No assertion for the setter; we just 
expect it to silently succeed" - if it's expected to succeed, shouldn't success 
be tested by verifying the set value?

Best,

Michael

> Am 11.01.2016 um 05:03 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> * Spec. changes look good.
> 
> * Review comments on code changes:
> 
> Minor: BeansLinker.java - whitespace missing after "if"if(collectionType != 
> CollectionType.MAP && isFixedKey)
> and few other "if" statements too.
> 
> +1
> 
> PS. Not sure if the samples under $nashorn/samples have any dependency on 
> (older) BeansLinker behaviour.
> 
> -Sundar
> 
> On 1/6/2016 5:08 PM, Attila Szegedi wrote:
>> Excellent, thanks for preparing it. It looks good to me.
>> 
>> Attila.
>> 
>>> On Jan 6, 2016, at 12:28 PM, Sundararajan Athijegannathan 
>>> <sundararajan.athijegannat...@oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> specdiff for this API change is here -> 
>>> http://cr.openjdk.java.net/~sundar/8144919/dynalink_specdiff/overview-summary.html
>>> 
>>> Thanks,
>>> -Sundar
>>> 
>>> On 12/24/2015 2:01 AM, Attila Szegedi wrote:
>>>> Please review JDK-8144919 "Implement missing member handler for 
>>>> BeansLinker" at <http://cr.openjdk.java.net/~attila/8144919/webrev.jdk9> 
>>>> for <https://bugs.openjdk.java.net/browse/JDK-8144919>
>>>> 
>>>> This change dependes on JDK-8144917, a review request for which 
>>>> immediately preceded this one. I only plan to commit the two together 
>>>> after they have been both reviewed.
>>>> 
>>>> Note that I need a CCC review for this, as it touches the Dynalink public 
>>>> API (details in the JIRA issue). As such, even if I get 2 reviews on this, 
>>>> I will not be committing either this or 8144917 until CCC approval is 
>>>> obtained.
>>>> 
>>>> Thanks,
>>>>   Attila.
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8145486: jjs should support documentation key shortcut in interactive mode

[Michael Haupt]

Hi Sundar,

very cool. Lower-case thumbs up.

I tested this on the Mac platform, and all the features work, save one little 
thing. Main.openBrowserForJavaDoc does not seem to handle inner classes 
correctly. Entering java.util.HashMap.SimpleEntry in the jjs shell and then 
hitting Shift-Tab will pass the URL 
http://download.java.net/jdk9/docs/api/java/util/AbstractMap$SimpleEntry.html 
to the browser, when 
http://download.java.net/jdk9/docs/api/java/util/AbstractMap.SimpleEntry.html 
is needed. The $->. conversion needs to be added.

Best,

Michael

> Am 16.12.2015 um 05:38 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8145486/ for 
> https://bugs.openjdk.java.net/browse/JDK-8145486
> 
> Note that this enhancement only adds jjs changes to show documentation when 
> available and infrastructure to attach documentation string for JS built-in 
> functions, constructors.
> Actual documentation strings are added only for NativeObject. Adding 
> documentation string for all other built-in functions, constructors will be 
> done in future.
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8145486: jjs should support documentation key shortcut in interactive mode

[Michael Haupt]

Hi Sundar,

thumbs are still up!

Best,

Michael

> Am 16.12.2015 um 11:33 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Thanks for the reviews.
> 
> Updated webrev: http://cr.openjdk.java.net/~sundar/8145486/webrev.01/
> 
> * Fixed documentation for setIndexedPropertiesToExternalArrayData
> * Fixed inner/nested class case ($ - > ".")
> * Added doc for NativeJavaPackage objects
> * Added missing "final" in Console.bind method.
> 
> Incremental changes are only in Main.java and Console.java
> 
> Please review..
> 
> -Sundar
> 
> On 12/16/2015 2:48 PM, Hannes Wallnoefer wrote:
>> Very nice, and works like a charm on Linux.
>> 
>> One nitpick: documentation for 
>> NativeObject.setIndexedPropertiesToExternalArrayData should start with 
>> "sets" rather than "set" to be consistent with the rest.
>> 
>> Hannes
>> 
>> Am 2015-12-16 um 05:38 schrieb Sundararajan Athijegannathan:
>>> Please review http://cr.openjdk.java.net/~sundar/8145486/ for 
>>> https://bugs.openjdk.java.net/browse/JDK-8145486
>>> 
>>> Note that this enhancement only adds jjs changes to show documentation when 
>>> available and infrastructure to attach documentation string for JS built-in 
>>> functions, constructors.
>>> Actual documentation strings are added only for NativeObject. Adding 
>>> documentation string for all other built-in functions, constructors will be 
>>> done in future.
>>> 
>>> Thanks,
>>> -Sundar
>> 
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8144221: fix Nashorn shebang argument handling on Mac/Linux

[Michael Haupt]

Dear all,

please review this change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8144221
Webrev: http://cr.openjdk.java.net/~mhaupt/8144221/webrev.00

The fix for Cygwin is pending and tracked by JDK-8145305.

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8145186: jjs package completion should have a fallback when javac is not available

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 11.12.2015 um 14:31 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8145186/ for 
> https://bugs.openjdk.java.net/browse/JDK-8145186
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: 8144979: Context.fromClass should catch exception from Class.getClassLoader call

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

One remark: I'm a bit concerned about the plethora of files involved with the 
dynalink samples. For each particular sample, there's a Java file, a sample JS 
file, and a linker JS file, where the linker compiles the Java file and 
assembles a JAR. The linkers all look pretty much the same. In my opinion, 
providing one script that takes care of compilation and JARring and is loaded 
from all actual samples would keep the samples more lean.

Best,

Michael

> Am 09.12.2015 um 08:56 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144979/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144979
> This fix is already in jake/nashorn. See also: 
> https://bugs.openjdk.java.net/browse/JDK-8144568
> 
> In addition, I've moved all dynalink samples to $nashorn/samples/dynalink 
> directory and renamed the README.
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144841: Add a sample for pluggable dynalink linker for stream property on arrays and a REAMDE for linker samples

[Michael Haupt]

Hi Sundar,

thumbs are still up.

At some point, I think it would make sense to place the dynalink samples in a 
dedicated place and provide one dedicated JS file for the compilation and JAR 
generation that the various samples can just load() at the beginning. The 
proliferation of ever-similar sample_linker.js files might eventually be 
overwhelming.

Best,

Michael

> Am 08.12.2015 um 09:05 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Hi,
> 
> I've updated webrev to include another sample (treating nio Buffer objects 
> like arrays). Updated webrev is @ 
> http://cr.openjdk.java.net/~sundar/8144841/webrev.01/
> 
> Thanks,
> -Sundar
> 
> On 12/8/2015 1:31 PM, Michael Haupt wrote:
>> Hi Sundar,
>> 
>> lower-case thumbs up!
>> 
>> Best,
>> 
>> Michael
>> 
>>> Am 07.12.2015 um 16:46 schrieb Sundararajan Athijegannathan 
>>> <sundararajan.athijegannat...@oracle.com>:
>>> 
>>> Please review http://cr.openjdk.java.net/~sundar/8144841/ for 
>>> https://bugs.openjdk.java.net/browse/JDK-8144841
>>> 
>>> Adding a README for dynalink samples as Marcus suggested earlier.
>>> 
>>> Thanks,
>>> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144841: Add a sample for pluggable dynalink linker for stream property on arrays and a REAMDE for linker samples

[Michael Haupt]

Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 07.12.2015 um 16:46 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144841/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144841
> 
> Adding a README for dynalink samples as Marcus suggested earlier.
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144519: Add a sample for pluggable dynalink linker that demonstrats beans linker delegation

[Michael Haupt]

Hi Sundar,

lower-case thumbs up. Smalltalk goodness. :-)

Best,

Michael

> Am 02.12.2015 um 18:31 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144519/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144519
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144473: Nashorn code assumes NashornCallSiteDescriptor always

[Michael Haupt]

Hi Sundar,

lower-case thumbs up! Next, please write a Dynalink book. :-)

Best,

Michael

> Am 02.12.2015 um 10:39 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144473/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144473
> 
> Piggybacking a dynalink pluggable linker sample to translate 
> underscore_separated names to CamelCase names.
> The bug in nashorn was found when attempting to use that linker. Nashorn call 
> site descriptors failed (before the current fix)
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144160: Regression: two tests fail on Windows with "ant test" target

[Michael Haupt]

Hi Marcus,

this is tracked here: https://bugs.openjdk.java.net/browse/JDK-8144221

Best,

Michael

> Am 30.11.2015 um 09:28 schrieb Marcus Lagergren <mar...@lagergren.net>:
> 
> +1 for disabling this for now, assuming it gets fixed later. Where is this 
> tracked?
> 
> /M
> 
>> On 27 Nov 2015, at 05:36, Sundararajan Athijegannathan 
>> <sundararajan.athijegannat...@oracle.com> wrote:
>> 
>> Please review http://cr.openjdk.java.net/~sundar/8144160/ for 
>> https://bugs.openjdk.java.net/browse/JDK-8144160
>> 
>> Thanks,
>> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144230: Add a sample for pluggable dynalink linker

[Michael Haupt]

Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 30.11.2015 um 13:18 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144230/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144230
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144186: Update Main.asm sample to use dynalink public API

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 27.11.2015 um 13:12 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144186/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144186
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144189: Turn off Tiered compilation for nashorn test262parallel test run

[Michael Haupt]

Hi Sundar,

lower-case thumbs up, and let's revoke that once hs-comp merges into 9-dev.

Best,

Michael

> Am 27.11.2015 um 15:22 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144189/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144189
> 
> Piggybacking to remove excluded list for test262 tests and also to make test 
> exclusion work properly [though there are no tests excluded now]
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144160: Regression: two tests fail on Windows with "ant test" target

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 27.11.2015 um 05:36 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144160/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144160
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8143642: Nashorn shebang argument handling is broken

[Michael Haupt]

Dear all,

please review this change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8143642
Webrev: http://cr.openjdk.java.net/~mhaupt/8143642/webrev.00

It enables passing arguments to scripts when they are run in shebang mode.

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144051: failing test262parallel run leads to successful build

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 26.11.2015 um 14:22 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144051/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8144051
> 
> 3 currently failing test262 tests are excluded - see also
> 
> * https://bugs.openjdk.java.net/browse/JDK-8144037
> * https://bugs.openjdk.java.net/browse/JDK-8134883
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8144150: test262parallel test exclusion does not work and is incomplete

[Michael Haupt]

Hi Sundar,

lower-case thumbs up.

Best,

Michael

> Am 26.11.2015 um 18:26 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8144150/webrev.00/  for 
> https://bugs.openjdk.java.net/browse/JDK-8144150
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(XS): 8143297: Nashorn compilation time reported in nanoseconds

[Michael Haupt]

Dear all,

please review this fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8143297
Webrev: http://cr.openjdk.java.net/~mhaupt/8143297/webrev.00/

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8142864: Raw types warning in WeakValueCache

[Michael Haupt]

Hi Hannes,

lower-case thumbs up.

Best,

Michael

> Am 12.11.2015 um 16:36 schrieb Hannes Wallnoefer 
> <hannes.wallnoe...@oracle.com>:
> 
> Please review JDK-8142864: Raw types warning in WeakValueCache:
> 
> http://cr.openjdk.java.net/~hannesw/8142864/webrev/
> 
> This removes a warning in WeakValueCache.java, and I also reduced methods by 
> combining code as suggested by Attila.
> 
> Furthermore I renamed method in isWrappedPrimitiveAndObject in 
> ScriptRuntime.java to isPrimitiveAndObject because the primitives are not 
> wrapped (at least not in the JavaScript meaning of the word).
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8142857: Enable all nashorn "api" tests for jtreg test run

[Michael Haupt]

Hi Sundar,

yep, lower-case thumbs up. It's *good* to cover more tests with jtreg.

Best,

Michael

> Am 12.11.2015 um 14:43 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8142857
> 
> Thanks,
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8141524: CompilerTest execution time dominated by Field.setAccessible

[Michael Haupt]

Hi Attila,

lower-case thumbs up.

Best,

Michael

> Am 05.11.2015 um 10:57 schrieb Attila Szegedi <attila.szeg...@oracle.com>:
> 
> Please review JDK-8141524 "CompilerTest execution time dominated by 
> Field.setAccessible" at 
> <http://cr.openjdk.java.net/~attila/8141524/webrev.jdk9> for 
> <https://bugs.openjdk.java.net/browse/JDK-8141524>
> 
> Shaved off 29s (9s instead of 38s) from CompilerTest execution time. Given 
> it’s executed twice in “ant test” (optimistic+pessimistic), this reduces “ant 
> test" run time by a minute.
> 
> Thanks,
>  Attila.

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8141446: Cache Class.forName for permanently loaded classes

[Michael Haupt]

Hi Attila,

lower-case thumbs up.

Best,

Michael

> Am 04.11.2015 um 17:58 schrieb Attila Szegedi <attila.szeg...@oracle.com>:
> 
> Please review JDK-8141446 "Cache Class.forName for permanently loaded 
> classes" at <http://cr.openjdk.java.net/~attila/8141446/webrev.jdk9> for 
> <https://bugs.openjdk.java.net/browse/JDK-8141446>
> 
> This was obtained by profiling the cost of compile-octane.js test, and has an 
> overall benefit on “ant test”. On my machine “ant test” went from 12m30s to 
> 10m30s.
> 
> Thanks,
>  Attila.

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8141285: NameCode should pass tests from BytecodeNameTest.java

[Michael Haupt]

Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 03.11.2015 um 15:31 schrieb Sundararajan Athijegannathan 
> <sundararajan.athijegannat...@oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8141285/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8141285
> 
> NameCodec has similar functionality (with a minor bug in '\' handling) as in 
> sun.invoke.util.BytecodeName.java (which seems to be old code, but unused in 
> jdk repo!). Using code in BytecodeName.java in NameCodec.java now - only 
> minimal subset needed for decode, encode. Also, adding tests for 
> NameCodec.java derived from (older) mlvm test BytecodeNameTest.java
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

RFR(S): 8140759: add ES6 template literal test

[Michael Haupt]

Dear all,

please review this change.
Issue: https://bugs.openjdk.java.net/browse/JDK-8140759
Webrev: http://cr.openjdk.java.net/~mhaupt/8140759/webrev.00

In preparing the push of ES6 template literal support yesterday, I forgot to 
add the test files. Sorry about that.

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: RFR 8134941: Implement ES6 template literal support

[Michael Haupt]

Hi all,

excellent - I'll sponsor the change.

Best,

Michael

> Am 23.10.2015 um 11:28 schrieb Attila Szegedi <attila.szeg...@oracle.com>:
> 
> +1 from me as well. Another apology from me for having to wait even more for 
> the second review.
> 
> Very nice work. I’m sometimes in two minds about RuntimeNode (especially the 
> fact that it currently can’t receive primitive parameters), but I have to 
> admit that in this particular case it made the integration of the feature 
> into the runtime fairly easy; it was really the parser parts that were tricky.
> 
> Attila.
> 
>> On Sep 24, 2015, at 4:44 PM, Hannes Wallnoefer 
>> <hannes.wallnoe...@oracle.com> wrote:
>> 
>> Hi Andreas,
>> 
>> Thanks for the contribution, and sorry for the long time it took to get back 
>> to you.
>> 
>> I like the way you implemented this feature, the code looks very good.  
>> Comments inlined below.
>> 
>> Am 2015-09-03 um 18:49 schrieb Andreas Woess:
>>> Template literals are always scanned as a whole, quote-to-quote (as with 
>>> EditStringLexer). This turned out to be a problem with embedded functions 
>>> in expressions and lazy/optimistic compilation on: Parser#skipFunctionBody 
>>> would skip over the body and restart lexing at the RBRACE, forgetting about 
>>> the embedding string context. I've worked around this in skipFunctionBody 
>>> by skipping over to the RBRACE directly if it is already in the token 
>>> stream (which it is because we've already scanned to the end quote).
>> 
>> It took me some time to figure this out. Maybe some more explanatory 
>> comments would be good. Does this also apply in other cases?
>> 
>>> 
>>> Outstanding correctness issues not dealt with:
>>> * 12.2.9.3 GetTemplateObject stipulates that the returned template object 
>>> be cached and unique. I don't know why you'd want the spec to demand 
>>> caching rather than allow it (functionally it does not make a difference, 
>>> but you could observe it not being cached in a test).
>> 
>> Actually object identity can be observed by the tag function, and that was 
>> the reason for the committee to specify this. They chose caching of objects 
>> for performance reasons. The discussion can be found here:
>> 
>> https://github.com/rwaldron/tc39-notes/blob/master/es6/2014-11/nov-18.md#48-template-literal-call-site-object-caching
>> 
>> Even though it's a minor issue we should follow the spec here.
>> 
>>> * 12.2.9.5 Evaluation: string concatenation using + is slightly off-spec. 
>>> There are two way to solve this: (a) wrap the expressions in a ToString 
>>> UnaryExpression (or RuntimeCall) or (b) generate a call to concat with 
>>> interleaved string and expression arguments.
>>> 
>> 
>> The difference is between ToPrimitive being called with Number hint vs. 
>> String hint. This should not make a difference for the vast share of objects 
>> (all except those having a custom valueOf function I think), but it's 
>> something we should also get right. I've started experimenting with the 
>> solutions you suggested, I think adding a ToString conversion wrapper of 
>> some kind would be best.
>> 
>> All in all I think your patch looks good. We can probably file the issues as 
>> separate bugs and fix them later. One thing I want to do is add some more 
>> tests. Although your test script covers a lot of stuff (for its size) I 
>> would like to add a bit to it.
>> 
>> Thanks,
>> Hannes


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8139884: Use privileged blocks when working with class loaders

[Michael Haupt]

Hi Attila,

lower-case thumbs up, with just the remark that lambdas could make the code 
more concise.

Best,

Michael

> Am 19.10.2015 um 15:53 schrieb Attila Szegedi :
> 
> Please review JDK-8139884 "Use privileged blocks when working with class 
> loaders" at  for 
> 
> 
> Thanks,
>  Attila.

RFR(XS): 8139266: add JSAdapter example with fallthrough

[Michael Haupt]

Dear all,

please review this change - it adds a sample for JSAdapter usage.
RFE: https://bugs.openjdk.java.net/browse/JDK-8139266
Webrev: http://cr.openjdk.java.net/~mhaupt/8139266/webrev.00

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment

Re: Review request for JDK-8139282: Remove @author and @id tags from Dynalink JavaDoc; some minor edits

[Michael Haupt]

Hi Attila,

lower-case thumbs up.

Best,

Michael

> Am 12.10.2015 um 10:36 schrieb Attila Szegedi <attila.szeg...@oracle.com>:
> 
> Thanks. I will go through the documentation and add SecurityException where 
> necessary in a later separate JavaDoc patch. You are right about webrev 
> showing other changes too. I fixed that, updating it in-place.
> 
> Thanks,
>  Attila.
> 
>> On Oct 12, 2015, at 5:42 AM, Sundararajan Athijegannathan 
>> <sundararajan.athijegannat...@oracle.com> wrote:
>> 
>> Wherever SecurityException is thrown, javadoc could have @throws and one 
>> line explanation. Even though it is a RuntimeException, JDK javadoc 
>> elsewhere documents SecurityException explicitly.
>> 
>> Other than that +1
>> 
>> PS. This webrev shows differences due to other patches/fixes as well ...
>> 
>> -Sundar
>> 
>> 
>> On 10/9/2015 6:44 PM, Attila Szegedi wrote:
>>> Please review JDK-8139282 "Remove @author and @id tags from Dynalink 
>>> JavaDoc; some minor edits" at 
>>> <http://cr.openjdk.java.net/~attila/8139282/webrev.jdk9> for 
>>> <https://bugs.openjdk.java.net/browse/JDK-8139282>
>>> 
>>> This is a very trivial and boring change, it’s mostly what it says: 
>>> removing the @author and @id tags; I also made some minor rewording edits 
>>> (that will likely be further changed by later more major JavaDoc edits 
>>> anyway).
>>> 
>>> Thanks,
>>>  Attila.
>> 
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment> Oracle is committed to developing 
practices and products that help protect the environment