Ways to archieve old reviews
Hi: On our reviewboard, we have accumulated more than 65000 reviews. As a result, the index page for everyone is a little bit slow, taking almost 10s to open, the other pages are working just fine. I took a guess that this is because the huge number of reviews. My questions are: 1. If we close all reviews older than, say 3 months, that would left us will about 5000 active reviews. Will this increase the index performance? 2. Is it possible to set the default index page for everyone to incoming reviews that would work around the slow index page problem. Thanks you very much! -Lucas -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Ways to archieve old reviews
Hi Lucas, People should be closing review requests when the accompanying change is submitted. That's your archival process, basically. Education is going to be the most important thing here. People have to get into that habit. #1 is probably what you want to do to start off, and then make sure people get in the habit of closing. I know some companies have custom scripts that help with auto-closing, but I don't have access to them. #2 is not doable today. I know of servers with over 400,000 review requests and no speed issues. The review requests are being closed properly on those. But all that being said, I wouldn't expect it to take that long. What version of Review Board are you using? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Dec 7, 2012 at 1:49 AM, Lucas Wong yanchaow...@gmail.com wrote: Hi: On our reviewboard, we have accumulated more than 65000 reviews. As a result, the index page for everyone is a little bit slow, taking almost 10s to open, the other pages are working just fine. I took a guess that this is because the huge number of reviews. My questions are: 1. If we close all reviews older than, say 3 months, that would left us will about 5000 active reviews. Will this increase the index performance? 2. Is it possible to set the default index page for everyone to incoming reviews that would work around the slow index page problem. Thanks you very much! -Lucas -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Configuring Review Board for GIT
On 2012-12-07 00:08, Krishnan Raghupathi wrote: I tried using the following value for the raw file URL mask - http://gitgrid.unx.coep.com/cgit/Mobile/Commons/tree/Commons/formatters/Constants.cpp?id2=7d8cb5fa13a5985e70300baac4ae09d1be8c37bf Based on that, I would guess your Raw File URL should be: http://gitgrid.unx.coep.com/cgit/Mobile/Commons/filename?id2=revision As previously stated, path and mirror path should match your users' remote fetch URL's. Ideally Path should be something that RB can access (though I'm not sure it actually needs to), and Mirror Path can be something that needs credentials. Git URL's are fine, they don't need to be local paths. (If needed, you can upload an SSH key to the RB server, and/or generate one and add it to the git repo's accepted keys.) This: I tried a value like ssh://g...@gitgrid.unx.coep.com/Mobile/Commons and I still get an error. ...looks reasonable. I would guess the Raw File URL is the issue. (Have you checked the server's logs to see what it is trying to do?) What about the id2 in the raw file URL mask - should I leave it as id2 or should I use just id ? This I don't know... whatever works for cgit... -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.7 RC 1 is released!
We're definitely compatible with Python 2.6. All the entries in the log you provided are just harmless warnings, so it must be something else causing the HTTP 500 error. Is there nothing else after that in the log file? Christian On Dec 7, 2012, at 5:56, Vishal Gautam gautamvis...@gmail.com wrote: Ahh ... that python upgrade caused a lot of damage (being a newbie), spent entire day battling it ... since it was a new install, I recreated the site with new db, got plethora of errors. Thinking Python 2.7 could be an issue I have now downgraded to Python 2.6 and re-installed RB 1.7 and recreated the site. Now i get a 500 with following errors in error_log. Is RB 1.7 not compatible with Python 2.6? [Fri Dec 07 13:39:43 2012] [error] /usr/local/lib/python2.6/site-packages/Djblets-0.7.5-py2.6.egg/djblets/gravatars/__init__.py:26: DeprecationWarning: the md5 module is deprecated; use hashlib instead [Fri Dec 07 13:39:43 2012] [error] from md5 import md5 [Fri Dec 07 13:39:43 2012] [error] /usr/local/lib/python2.6/site-packages/Django-1.4.2-py2.6.egg/django/views/generic/list_detail.py:10: DeprecationWarning: Function-based generic views have been deprecated; use class-based views instead. [Fri Dec 07 13:39:43 2012] [error] DeprecationWarning On Friday, December 7, 2012 12:13:16 PM UTC+5:30, Christian Hammond wrote: Hi, First, do you have a backup of the database? What actions did you take on the database prior to this attempt? For example, did you ever run evolve yourself? Or attempt a downgrade after an upgrade? Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 10:38 AM, Vishal Gautam gautam...@gmail.com wrote: Thanks for the response Chris! I upgrade CentOS to 5.8, manually installed Python 2.7, upgraded setuptools for 2.7, then upgraded RB to 1.7rc1. All this made it fine (after getting bunch of issues those I could look up in Google). Now I am stuck at upgrading the site and my RB instance is down ... Please help! [root@jira ~]# /usr/local/bin/rb-site upgrade /var/www/reviews.xxx..com Rebuilding directory structure Updating database. This may take a while. /usr/local/lib/python2.7/site-packages/Djblets-0.7.5-py2.7.egg/djblets/gravatars/__init__.py:26: DeprecationWarning: the md5 module is deprecated; use hashlib instead from md5 import md5 /usr/local/lib/python2.7/site-packages/pycrypto-2.6-py2.7-linux-x86_64.egg/Crypto/Util/number.py:57: PowmInsecureWarning: Not using mpz_powm_sec. You should rebuild using libgmp = 5 to avoid timing attack vulnerability. Creating tables ... Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model reviews.FileAttachmentComment: Field 'extra_data' has been added In model reviews.ReviewRequest: Field 'last_review_activity_timestamp' has been added Field 'last_review_timestamp' has been deleted In model accounts.Profile: Field 'timezone' has been added Field 'open_an_issue' has been added In model diffviewer.DiffSetHistory: Field 'last_diff_updated' has been added In model diffviewer.FileDiff: Field 'diff_hash' has been added Field 'parent_diff_hash' has been added Field 'diff64' has been added Field 'parent_diff64' has been added Field 'parent_diff' has been deleted Field 'diff' has been deleted The model auth.Message has been deleted Error: Your models contain changes that Django Evolution cannot resolve automatically. On Wednesday, December 5, 2012 8:36:42 PM UTC+5:30, Christian Hammond wrote: Review Board 1.7 requires Python 2.5 or higher. You'll have to upgrade in order for it to work. What I'd recommend is a newer CentOS install, since some of our dependencies will also need to be updated, and you won't hit as many issues with the upgrade. Your best bet is to upgrade to something with Python 2.7. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 5, 2012 at 2:22 AM, Vishal Gautam gautam...@gmail.com wrote: We are trying out RB, we have 1.6.14 installed and running on CentOS 5.5. Tried to upgrade it to 1.7 using following cmd but its failing ... easy_install -f http://downloads.reviewboard.org/releases/ReviewBoard/1.7 -U ReviewBoard Here is the stracktrace, any help will be much appreciated Best match: ReviewBoard 1.7rc1 Downloading http://downloads.reviewboard.org/releases/ReviewBoard/1.7/ReviewBoard-1.7rc1.tar.gz Processing
Re: API question: list of files in requests, filtered by path and request date
Hi Dado, You probably don't want to query the database directly, but you could write a script that uses our Model classes to get what you want. You'll have to spend some time looking at the Django docs on how to do that, and write a script that has your site's conf/ directory in your PYTHONPATH environment variable, and DJANGO_SETTINGS_MODULE set to reviewboard.settings. What I'd recommend, though, is to instead have a pre-commit hook that blocks a commit unless the following conditions are met: 1) The commit message references the review request ID or URL in some standard way. 2) That review request has at least one review marked Ship It. You can make use of the web API to get that information. I believe others on this list have built such scripts. Perhaps someone can provide one. Christian On Dec 6, 2012, at 11:28, Dado Feigenblatt d...@dado.org wrote: Hi Christian, We're using ReviewBoard version 1.6.3 We also using Perforce version P4D/LINUX26X86_64/2012.2/551823 (2012/11/09) We have a few different groups of developers. One of these groups writes mostly one-offs or do local customizations at break neck speeds. These is all in-house code, for their own use. So for that group we never required the highest level of programming best-practices, but we want to start steering them in that direction. Use of reviewboard has been optional but we might make that a requirement. Right now we'd like to get some general stats in terms of how much of their code is being submitted for review, how much feedback people are getting, and that sort of stuff. We want to gauge current level of adoption and what effect it might have if/when we make that a requirement. If we make code review a requirement for them, then I'll have to query reviewboard for each source file being released. I'll have to make sure there's an approved review for that revision of the source file. Or maybe if the file being released is in an approved review just by looking at diffs. I haven't put much thought yet into what kind of checks make sense here. Any advice on that would be greatly appreciated. I thing I saw an email thread about that. I'll look that up. How do you feel about users querying the database directly? Is there any documentation on the schema? Thanks, Dado On Thu, 6 Dec 2012 01:37:52 -0800, Christian Hammond chip...@chipx86.com wrote: Hi Dado, The web API isn't really built to provide this sort of query, unfortunately. What would be needed is a new resource for all modified diffs that let you query such information. I'd be happy to include such a resource, but someone would have to write it. I'm curious what you're working on. Maybe there are other solutions for now. Also, what version of RB? Christian -- Christian Hammond - chip...@chipx86.com [1] Review Board - http://www.reviewboard.org [2] VMware, Inc. - http://www.vmware.com [3] On Wed, Dec 5, 2012 at 6:11 PM, dado wrote: What would be the best way of getting a list of all reviewed files matching a determined perforce path? I also know I'm after the reviews created after 04/01/12. Should I simply get all the reviews after that date and do any additional filtering client-side? If so, what would be the best way to get all reviews after April *and* the list of files in the reviews? I've used the WEB API before, but I'm clearly not very comfortable with it yet. Thanks, Dado -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ [5] Happy user? Let us know at http://www.reviewboard.org/users/ [6] -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com [7] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en [8] -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ [9] Happy user? Let us know at http://www.reviewboard.org/users/ [10] -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en [11] Links: -- [1] mailto:chip...@chipx86.com [2] http://www.reviewboard.org [3] http://www.vmware.com [4] mailto:d...@dado.org [5] http://www.reviewboard.org/donate/ [6] http://www.reviewboard.org/users/ [7] mailto:reviewboard%2bunsubscr...@googlegroups.com [8] http://groups.google.com/group/reviewboard?hl=en [9] http://www.reviewboard.org/donate/ [10] http://www.reviewboard.org/users/ [11] http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this
open issue without code comment?
Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an enhancement request.) The use case I am thinking of is that I go to test a patch and discover that it has e.g. introduced a behavioral regression, but don't know what specific code is the culprit. I think it makes sense for tracking purposes to be able to open an issue describing the problem, rather than just a review stating that a problem exists. Thanks, -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: open issue without code comment?
Hi Matthew, There's no support for that today. This is less an issue thing and more a comment thing. We tie issues to comments, and comments to some part of a file/diff. The exception being that you can leave a general summary comment on a review, but that works differently internally and making it work in such a way where multiple issues could be filed would be a rather large change. I'm not sure what the best solution would be for your needs right now. Any solution would involve conceiving of and implementing a new design. Christian On Dec 7, 2012, at 11:52 AM, Matthew Woehlke mwoehlke.fl...@gmail.com wrote: Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an enhancement request.) The use case I am thinking of is that I go to test a patch and discover that it has e.g. introduced a behavioral regression, but don't know what specific code is the culprit. I think it makes sense for tracking purposes to be able to open an issue describing the problem, rather than just a review stating that a problem exists. Thanks, -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problem in viewing Review Board Diff
HI, i am getting the same error logs:- Could not load amazon's S3 bindings. See http://developer.amazonwebservices.com/connect/entry.jspa?externalID=134 Traceback (most recent call last): File /usr/lib/python2.6/site-packages/Django-1.3.3-py2.6.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.6/site-packages/Django-1.3.3-py2.6.egg/django/contrib/admin/views/decorators.py, line 19, in _checklogin return view_func(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/admin/views.py, line 59, in site_settings 'root_path': settings.SITE_ROOT + admin/db/ File /usr/lib/python2.6/site-packages/Django-1.3.3-py2.6.egg/django/contrib/admin/views/decorators.py, line 19, in _checklogin return view_func(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.6.22-py2.6.egg/djblets/siteconfig/views.py, line 50, in site_settings form = form_class(siteconfig) File /usr/lib/python2.6/site-packages/Djblets-0.6.22-py2.6.egg/djblets/siteconfig/forms.py, line 41, in __init__ self.load() File /usr/lib/python2.6/site-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/admin/forms.py, line 631, in load can_use_amazon_s3, reason = get_can_use_amazon_s3() File /usr/lib/python2.6/site-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/admin/checks.py, line 244, in get_can_use_amazon_s3 from storages.backends.s3 import S3Storage File /usr/lib/python2.6/site-packages/django_storages-1.1.5-py2.6.egg/storages/backends/s3.py, line 18, in module raise ImproperlyConfigured(Could not load amazon's S3 bindings.\nSee ImproperlyConfigured: Could not load amazon's S3 bindings. See http://developer.amazonwebservices.com/connect/entry.jspa?externalID=134 please suggest what to do. Regards, Mukul On Friday, 12 October 2012 17:35:13 UTC+5:30, bincy wrote: Hi All, Please help me to resolve this issue.This is really blocking me. I am facing some issue in viewing DIFF in review board .When I press the view diff button,I am getting the error.I tried to unsinstall install django-storages but it didn't help Also settings-File Storage settings page is giving the error Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. Regards Bincy The patch to 'bin/listtags' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.JP5kwN' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.JP5kwN/tmp7b8GsK Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.JP5kwN/tmp7b8GsK-new.rej Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/views.py, line 152, in view_diff populate_diff_chunks(temp_files, highlighting) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 1131, in populate_diff_chunks large_data=True) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.22-py2.6.egg/djblets/util/misc.py, line 156, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 1130, in lambda enable_syntax_highlighting)), File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 558, in get_chunks new = get_patched_file(old, filediff) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 377, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 246, in patch (filename, tempdir, patch_output)) Exception: The patch to 'bin/listtags' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.JP5kwN' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.JP5kwN/tmp7b8GsK Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.JP5kwN/tmp7b8GsK-new.rej I am getting the server log like this 03:46:35 ERROR Exception thrown for user test at http://10.163.6.3/admin/settings/storage/ Could not load amazon's S3 bindings. See http://developer.amazonwebservices.com/connect/entry.jspa?externalID=134 Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/Django-1.3.3-py2.6.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File
Re: Problem in viewing Review Board Diff
Hi Mukul, Looks like the Amazon S3 bindings changed their behavior. We'll have to work on a patch and a release to fix this properly, but for now, assuming you're not using S3 for storage, delete the django_storages-1.1.5-p2.6.egg directory and reload Apache. See if that fixes it for you. Christian On Dec 6, 2012, at 8:12 AM, MUKUL GARG gargmukk...@gmail.com wrote: HI, i am getting the same error logs:- Could not load amazon's S3 bindings. See http://developer.amazonwebservices.com/connect/entry.jspa?externalID=134 Traceback (most recent call last): File /usr/lib/python2.6/site-packages/Django-1.3.3-py2.6.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.6/site-packages/Django-1.3.3-py2.6.egg/django/contrib/admin/views/decorators.py, line 19, in _checklogin return view_func(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/admin/views.py, line 59, in site_settings 'root_path': settings.SITE_ROOT + admin/db/ File /usr/lib/python2.6/site-packages/Django-1.3.3-py2.6.egg/django/contrib/admin/views/decorators.py, line 19, in _checklogin return view_func(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.6.22-py2.6.egg/djblets/siteconfig/views.py, line 50, in site_settings form = form_class(siteconfig) File /usr/lib/python2.6/site-packages/Djblets-0.6.22-py2.6.egg/djblets/siteconfig/forms.py, line 41, in __init__ self.load() File /usr/lib/python2.6/site-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/admin/forms.py, line 631, in load can_use_amazon_s3, reason = get_can_use_amazon_s3() File /usr/lib/python2.6/site-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/admin/checks.py, line 244, in get_can_use_amazon_s3 from storages.backends.s3 import S3Storage File /usr/lib/python2.6/site-packages/django_storages-1.1.5-py2.6.egg/storages/backends/s3.py, line 18, in module raise ImproperlyConfigured(Could not load amazon's S3 bindings.\nSee ImproperlyConfigured: Could not load amazon's S3 bindings. See http://developer.amazonwebservices.com/connect/entry.jspa?externalID=134 please suggest what to do. Regards, Mukul On Friday, 12 October 2012 17:35:13 UTC+5:30, bincy wrote: Hi All, Please help me to resolve this issue.This is really blocking me. I am facing some issue in viewing DIFF in review board .When I press the view diff button,I am getting the error.I tried to unsinstall install django-storages but it didn't help Also settings-File Storage settings page is giving the error Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. Regards Bincy The patch to 'bin/listtags' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.JP5kwN' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.JP5kwN/tmp7b8GsK Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.JP5kwN/tmp7b8GsK-new.rej Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/views.py, line 152, in view_diff populate_diff_chunks(temp_files, highlighting) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 1131, in populate_diff_chunks large_data=True) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.22-py2.6.egg/djblets/util/misc.py, line 156, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 1130, in lambda enable_syntax_highlighting)), File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 558, in get_chunks new = get_patched_file(old, filediff) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 377, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.11-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 246, in patch (filename, tempdir, patch_output)) Exception: The patch to 'bin/listtags' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.JP5kwN' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.JP5kwN/tmp7b8GsK Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.JP5kwN/tmp7b8GsK-new.rej I am getting the server log like this 03:46:35 ERROR
Re: Configured repository doesn't show on New Review Request page
Hi, I'm not an expert on the Clear Case setups, but going through the code, we do this: cleartool lsview -full -properties -cview If we get an error, we won't show the repository. We then look through the output. If there's no Properties: with dynamic or snapshot, we fail. Otherwise, it should list the repository. Hope that in some way helps. Our Clear Case support is not really a first-class citizen. It's a series of contributions, but unfortunately not one I know a lot about. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 7:36 AM, Géza Kulcsár gesap...@gmail.com wrote: Hi! I checked and it really seems that path will be problem? Could you help me in providing correct path format? Do I only need /vobs/..., or I need a view name on top of it, or any other variation? I'm a bit confused, as your documentation mentions views somewhere, but your on-page hint states absolute path, which, from server point of view, would be /vobs/... Thanks, Géza Kulcsár 2012/12/6 Christian Hammond chip...@chipx86.com: Sorry, yes, cleartool. (It's a bit late here.) If cleartool is there, then yeah, it's probably a repository path problem. I'd see if there's any error information in the reviewboard.log file that indicates what may be going wrong. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 2:43 AM, Géza Kulcsár gesap...@gmail.com wrote: Do you mean cleartool? I assume then, that answer is yes. Unfortunately, I can only assume as I don't have direct access to server, I can only instruct the responsible technician. At first, when I tried to add vobs, there was an error message stating The executable cleartool is not in the path. I asked him to fix it, and it seemed that it works as I became able to add repos. The problem now is that they don't show up in the list. If cleartool is installed, could the cause still be that I'm not providing proper path information? Thanks, Géza Kulcsár 2012/12/6 Christian Hammond chip...@chipx86.com: Hey, Do you have the clearcase command line tool installed on the server? If it's not found, then it won't display. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 1:08 AM, Géza Kulcsár gesap...@gmail.com wrote: Hi! I'm trying to configure Review Board with ClearCase. I have successfully added a repository, but I'm not sure whether I'm giving path information in correct form. Could it affect if the repository showing or not in the list on New Review Request page? As I go there, there is nothing in the list but the default None option. Thanks, Best regards, Géza Kulcsár -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For
Re: open issue without code comment?
On 2012-12-07 14:55, Christian Hammond wrote: On Dec 7, 2012, at 11:52 AM, Matthew Woehlke wrote: Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an enhancement request.) There's no support for that today. This is less an issue thing and more a comment thing. We tie issues to comments, and comments to some part of a file/diff. The exception being that you can leave a general summary comment on a review, but that works differently internally and making it work in such a way where multiple issues could be filed would be a rather large change. Thanks; I opened http://code.google.com/p/reviewboard/issues/detail?id=2817. As a work-around, I suppose one can pick some random code on which to comment. However, it would be good if this could be added at some point. (We're looking at possibly replacing gerrit with RB, and this is sort of a missing-in-RB feature.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Will there be a 1.6.14 release
Hi, Is there any update to switching to a local lesscss compiler? The http://blesscss.cloudfoundry.com service is down, and that is causing the build to fail. Thanks, Derek On Monday, November 26, 2012 3:34:30 PM UTC-5, Christian Hammond wrote: Awesome :) We'll make sure to have our build infrastructure use local less before we ship RC (which will probably be tomorrow). Christian On Nov 26, 2012, at 12:22, Stephen Gallagher ste...@gallagherhome.comjavascript: wrote: On Mon 26 Nov 2012 02:40:24 PM EST, Christian Hammond wrote: Should be less from http://lesscss.org/ I remember we talked before about the node.js challenges surrounding that. Did you guys figure out a solution to that? I took over the packaging of Node.js. It's currently awaiting approval[1] (which I expect to get, since I actually managed to get upstream to accept my patches to unbundle the libraries it was statically linking) With that accepted, it should be fairly simple to get lesscss packaged (especially since there's a review already pending for it.[2]) I'll be reviewing that one, so it'll land fairly quickly. [1] https://bugzilla.redhat.com/show_bug.cgi?id=815018 [2] https://bugzilla.redhat.com/show_bug.cgi?id=857843 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Will there be a 1.6.14 release
Hi Derek, 1.7 RC makes use of a local lessc compiler. Christian On Dec 7, 2012, at 15:00, Derek derek...@gmail.com wrote: Hi, Is there any update to switching to a local lesscss compiler? The http://blesscss.cloudfoundry.com service is down, and that is causing the build to fail. Thanks, Derek On Monday, November 26, 2012 3:34:30 PM UTC-5, Christian Hammond wrote: Awesome :) We'll make sure to have our build infrastructure use local less before we ship RC (which will probably be tomorrow). Christian On Nov 26, 2012, at 12:22, Stephen Gallagher ste...@gallagherhome.com wrote: On Mon 26 Nov 2012 02:40:24 PM EST, Christian Hammond wrote: Should be less from http://lesscss.org/ I remember we talked before about the node.js challenges surrounding that. Did you guys figure out a solution to that? I took over the packaging of Node.js. It's currently awaiting approval[1] (which I expect to get, since I actually managed to get upstream to accept my patches to unbundle the libraries it was statically linking) With that accepted, it should be fairly simple to get lesscss packaged (especially since there's a review already pending for it.[2]) I'll be reviewing that one, so it'll land fairly quickly. [1] https://bugzilla.redhat.com/show_bug.cgi?id=815018 [2] https://bugzilla.redhat.com/show_bug.cgi?id=857843 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.7 RC 1 is released!
Turned Debug=True, now i see this ... any pointers?
Traceback:
File
/usr/local/lib/python2.6/site-packages/Django-1.4.2-py2.6.egg/django/core/handlers/base.py
in get_response
89. response = middleware_method(request)
File
/usr/local/lib/python2.6/site-packages/ReviewBoard-1.7rc1-py2.6.egg/reviewboard/admin/middleware.py
in process_request
44. load_site_config()
File
/usr/local/lib/python2.6/site-packages/ReviewBoard-1.7rc1-py2.6.egg/reviewboard/admin/siteconfig.py
in load_site_config
215. apply_django_settings(siteconfig, settings_map)
File
/usr/local/lib/python2.6/site-packages/Djblets-0.7.5-py2.6.egg/djblets/siteconfig/django_settings.py
in apply_django_settings
210. setter(settings, setting_key, value)
File
/usr/local/lib/python2.6/site-packages/Djblets-0.7.5-py2.6.egg/djblets/siteconfig/django_settings.py
in _set_cache_backend
48. engine, host, params = parse_backend_uri(value)
File
/usr/local/lib/python2.6/site-packages/Django-1.4.2-py2.6.egg/django/core/cache/__init__.py
in parse_backend_uri
58. if backend_uri.find(':') == -1:
Exception Type: AttributeError at /
Exception Value: 'dict' object has no attribute 'find'
On Sat, Dec 8, 2012 at 12:16 AM, Christian Hammond chip...@gmail.comwrote:
We're definitely compatible with Python 2.6. All the entries in the log
you provided are just harmless warnings, so it must be something else
causing the HTTP 500 error. Is there nothing else after that in the log
file?
Christian
On Dec 7, 2012, at 5:56, Vishal Gautam gautamvis...@gmail.com wrote:
Ahh ... that python upgrade caused a lot of damage (being a newbie), spent
entire day battling it ... since it was a new install, I recreated the site
with new db, got plethora of errors. Thinking Python 2.7 could be an issue
I have now downgraded to Python 2.6 and re-installed RB 1.7 and recreated
the site. Now i get a 500 with following errors in error_log. Is RB 1.7 not
compatible with Python 2.6?
[Fri Dec 07 13:39:43 2012] [error]
/usr/local/lib/python2.6/site-packages/Djblets-0.7.5-py2.6.egg/djblets/gravatars/__init__.py:26:
DeprecationWarning: the md5 module is deprecated; use hashlib instead
[Fri Dec 07 13:39:43 2012] [error] from md5 import md5
[Fri Dec 07 13:39:43 2012] [error]
/usr/local/lib/python2.6/site-packages/Django-1.4.2-py2.6.egg/django/views/generic/list_detail.py:10:
DeprecationWarning: Function-based generic views have been deprecated; use
class-based views instead.
[Fri Dec 07 13:39:43 2012] [error] DeprecationWarning
On Friday, December 7, 2012 12:13:16 PM UTC+5:30, Christian Hammond wrote:
Hi,
First, do you have a backup of the database?
What actions did you take on the database prior to this attempt? For
example, did you ever run evolve yourself? Or attempt a downgrade after an
upgrade?
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Dec 6, 2012 at 10:38 AM, Vishal Gautam gautam...@gmail.comwrote:
Thanks for the response Chris!
I upgrade CentOS to 5.8, manually installed Python 2.7, upgraded
setuptools for 2.7, then upgraded RB to 1.7rc1. All this made it fine
(after getting bunch of issues those I could look up in Google). Now I am
stuck at upgrading the site and my RB instance is down ... Please help!
[root@jira ~]# /usr/local/bin/rb-site upgrade /var/www/
reviews.xxx..com
Rebuilding directory structure
Updating database. This may take a while.
/usr/local/lib/python2.7/site-**packages/Djblets-0.7.5-py2.7.**
egg/djblets/gravatars/__init__**.py:26: DeprecationWarning: the md5
module is deprecated; use hashlib instead
from md5 import md5
/usr/local/lib/python2.7/site-**packages/pycrypto-2.6-py2.7-**
linux-x86_64.egg/Crypto/Util/**number.py:57: PowmInsecureWarning: Not
using mpz_powm_sec. You should rebuild using libgmp = 5 to avoid timing
attack vulnerability.
Creating tables ...
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
The stored evolutions do not completely resolve all model changes.
Run `./manage.py evolve --hint` to see a suggestion for the changes
required.
The following are the changes that could not be resolved:
In model reviews.FileAttachmentComment:
Field 'extra_data' has been added
In model reviews.ReviewRequest:
Field 'last_review_activity_**timestamp' has been added
Field 'last_review_timestamp' has been deleted
In model accounts.Profile:
Field 'timezone' has been added
Field 'open_an_issue' has been added
In model diffviewer.DiffSetHistory:
Field 'last_diff_updated' has been added
In model diffviewer.FileDiff:
Field 'diff_hash' has been added
Field 'parent_diff_hash' has been added
Field 'diff64' has been added
Field 'parent_diff64' has been added
Field 'parent_diff'
