[kudu-CR] WIP [tools] first draft of rebalancing in kudu CLI

[Alexey Serbin (Code Review)]

Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10399

to look at the new patch set (#4).

Change subject: WIP [tools] first draft of rebalancing in kudu CLI
..

WIP [tools] first draft of rebalancing in kudu CLI

WIP:
  * needs integration tests with a la ksck-remote
  * address several TODOs
  * needs more testing against real cluster

Change-Id: I269ea1dcb0b528ad9f03308bac6b8769e2141238
---
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/rebalance-algo.cc
A src/kudu/tools/rebalance-test.cc
A src/kudu/tools/rebalance.cc
A src/kudu/tools/rebalance.h
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_tablet.cc
7 files changed, 888 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/10399/4
--
To view, visit http://gerrit.cloudera.org:8080/10399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I269ea1dcb0b528ad9f03308bac6b8769e2141238
Gerrit-Change-Number: 10399
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

[Alexey Serbin (Code Review)]

Hello Will Berkeley, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10438

to look at the new patch set (#2).

Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1
..

[consensus] KUDU-2443 fix replica replacement of RF=1

Fixed bug in the consensus::ShouldEvictReplica() function for the case
when the leader replica of a tablet with replication factor of 1
is marked with the REPLACE attribute and there is an extra voter
replica in the tablet's Raft config.

Prior to this fix, the master would evict the extra voter from the
configuration and then it would add a new non-voter because of the
consensus::ShouldAddReplica() method's behavior.  After the newly
added non-voter replica catches up and becomes a voter, that would
happen again and again, until the REPLACE attribute is removed.

Change-Id: I9da9fe6788f28b40f7adc53e23540bcdf103c1ea
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
2 files changed, 85 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10438/2
--
To view, visit http://gerrit.cloudera.org:8080/10438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9da9fe6788f28b40f7adc53e23540bcdf103c1ea
Gerrit-Change-Number: 10438
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2427: make ksck-test replica order deterministic

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10433 )

Change subject: KUDU-2427: make ksck-test replica order deterministic
..

KUDU-2427: make ksck-test replica order deterministic

On Ubuntu 18.04, the iteration order of std::unordered_map isn't the same as
on other distros. Behavioral changes like this are to be expected as the
iteration order is implementation-specific. However, we had some code in
ksck-test that expected a specific iteration order. Let's fix this by
switching from an std::unordered_map to an std::map.

Change-Id: I5da71f3582257febaccae7f142e5eb3a22548c19
Reviewed-on: http://gerrit.cloudera.org:8080/10433
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley 
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.h
2 files changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Will Berkeley: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5da71f3582257febaccae7f142e5eb3a22548c19
Gerrit-Change-Number: 10433
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2427: make ksck-test replica order deterministic

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10433 )

Change subject: KUDU-2427: make ksck-test replica order deterministic
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da71f3582257febaccae7f142e5eb3a22548c19
Gerrit-Change-Number: 10433
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 17 May 2018 03:27:30 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2427: update to latest version of curl

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10432 )

Change subject: KUDU-2427: update to latest version of curl
..


Patch Set 2: Code-Review+2

Carrying forward Alexey's +2.


--
To view, visit http://gerrit.cloudera.org:8080/10432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 17 May 2018 03:22:17 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2427: update to latest version of curl

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10432 )

Change subject: KUDU-2427: update to latest version of curl
..

KUDU-2427: update to latest version of curl

The existing version of curl doesn't work with OpenSSL 1.1, which is what
ships by default with Ubuntu 18.04.

Without the change to curl_util.cc, SslWebserverTest_TestSSL fails with:

  curl error: SSL peer certificate or SSH remote key was not OK

Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Reviewed-on: http://gerrit.cloudera.org:8080/10432
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M src/kudu/util/curl_util.cc
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
3 files changed, 9 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2443 moving single-replica tablets is broken

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10438


Change subject: KUDU-2443 moving single-replica tablets is broken
..

KUDU-2443 moving single-replica tablets is broken

Fixed bug in the consensus::ShouldEvictReplica() function for the case
when the leader replica of a tablet with replication factor of 1
(i.e. a non-replicated tablet) is marked with the REPLACE attribute
and there is an extra voter replica in the tablet's Raft config.

Prior to this fix, the master would try to evict the new extra voter
from the configuration and then it would add a new non-voter because
of the consensus::ShouldAddReplica() method's behavior.  After the
newly added non-voter replica catches up and is promoted to voter,
that would happen again and again, until the REPLACE attribute
is removed.

Change-Id: I9da9fe6788f28b40f7adc53e23540bcdf103c1ea
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
2 files changed, 85 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10438/1
--
To view, visit http://gerrit.cloudera.org:8080/10438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9da9fe6788f28b40f7adc53e23540bcdf103c1ea
Gerrit-Change-Number: 10438
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10075 )

Change subject: KUDU-2191: Metadata Upgrade Tool
..


Patch Set 14:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10075/12/src/kudu/hms/hms_catalog.h
File src/kudu/hms/hms_catalog.h:

http://gerrit.cloudera.org:8080/#/c/10075/12/src/kudu/hms/hms_catalog.h@100
PS12, Line 100:   const std::string& tb_name,
> OK, but how can this method know the Kudu table name of an HMS table entry?
Done


http://gerrit.cloudera.org:8080/#/c/10075/13/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:

http://gerrit.cloudera.org:8080/#/c/10075/13/src/kudu/tools/tool_action_hms.cc@88
PS13, Line 88: }
> This is the case of a non-Impala legacy table, right?  I thought this tool
I updated the tool to rename the table to be Hive-compatible while upgrade.



--
To view, visit http://gerrit.cloudera.org:8080/10075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3
Gerrit-Change-Number: 10075
Gerrit-PatchSet: 14
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 17 May 2018 02:14:33 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

[Hao Hao (Code Review)]

Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10075

to look at the new patch set (#14).

Change subject: KUDU-2191: Metadata Upgrade Tool
..

KUDU-2191: Metadata Upgrade Tool

This commit introduces an upgrade tool to allows backward compatibility.
It provides support to upgrade the metadata format of existing Impala
managed/external tables in HMS entries, as well as rename the existing
tables in Kudu to adapt to the new naming rules. To run this tool, it
requires to turn off the HMS integration feature. It adds test case
using external mini cluster to ensure the upgrade tool works as
expected.

Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3
---
M 
java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M 
java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/schema.h
M src/kudu/common/common.proto
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action.h
A src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_main.cc
M src/kudu/tools/tool_test_util.cc
M src/kudu/tools/tool_test_util.h
26 files changed, 755 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/10075/14
--
To view, visit http://gerrit.cloudera.org:8080/10075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3
Gerrit-Change-Number: 10075
Gerrit-PatchSet: 14
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [DOCS] Added an info on creating a table in Impala with a custom replication factor

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10411 )

Change subject: [DOCS] Added an info on creating a table in Impala with a 
custom replication factor
..


Patch Set 2:

Hi Mike,
Could you review and approve this change?


--
To view, visit http://gerrit.cloudera.org:8080/10411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1c9ee97497dd62ccc8769428435ba6d5adddae9
Gerrit-Change-Number: 10411
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Thu, 17 May 2018 01:30:53 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 10: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 10
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 23:46:34 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2427: adjust gold linker detection

[Adar Dembo (Code Review)]

Hello Mike Percy, Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10428

to look at the new patch set (#2).

Change subject: KUDU-2427: adjust gold linker detection
..

KUDU-2427: adjust gold linker detection

This patch makes two adjustments to the existing gold linker detection:
1. Ubuntu 18.04's gcc 7 no longer respects a /usr/bin/ld symlink; it is
   hard-wired to use ld.bfd. Instead, we need to pass -fuse-ld=gold to
   choose the gold linker.
2. The old bug that led to tcmalloc being dropped from Kudu's dependency
   list has been fixed, so let's condition the workaround on the appropriate
   version of the gold linker.

Change-Id: Ib1fae9893aaaf4916205d4c5ae6bb5c93e0505d0
---
M CMakeLists.txt
M src/kudu/codegen/CMakeLists.txt
2 files changed, 86 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/10428/2
--
To view, visit http://gerrit.cloudera.org:8080/10428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib1fae9893aaaf4916205d4c5ae6bb5c93e0505d0
Gerrit-Change-Number: 10428
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] build: only call find package on gperftools if we're going to use it

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10429 )

Change subject: build: only call find_package on gperftools if we're going to 
use it
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b6c1244cdd5b901b6c23cb56a5613439113773
Gerrit-Change-Number: 10429
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 16 May 2018 23:40:09 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 10: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 10
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 23:37:22 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 10:

(1 comment)

Thanks!

http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/server/webserver.cc@490
PS9, Line 490:   Status s = zlib::Compress(Slice(full_content), );
 :   if (s.ok()) {
 : full_content = oss.str();
 : is_compressed = true;
 :   } else {
 :
> nit: it might be useful to output information from the error, e.g.
Done



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 10
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 22:20:10 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Fengling Wang (Code Review)]

Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10332

to look at the new patch set (#10).

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..

KUDU-2035 Enable HTTP compression for all webserver's paths

This patch enables HTTP compression when gzip compression is
accepted by the client.

Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
5 files changed, 113 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/10332/10
--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 10
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 9:

> (1 comment)
 >
 > Almost there: just one more nit.

Also, it's necessary to fix IWYU warnings:

http://jenkins.kudu.apache.org/job/kudu-gerrit/13471/BUILD_TYPE=IWYU/artifact/build/latest/test-logs/iwyu.log

Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 9
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 22:02:44 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 9:

(1 comment)

Almost there: just one more nit.

http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/10332/9/src/kudu/server/webserver.cc@490
PS9, Line 490:   if (zlib::Compress(Slice(full_content), ).ok()) {
 : full_content = oss.str();
 : is_compressed = true;
 :   } else {
 : LOG(WARNING) << "Could not compress output";
 :   }
nit: it might be useful to output information from the error, e.g.

Status s = zlib::Compress(...);
if (s.ok()) {
  ...
} else {
  LOG(WARNING) << "could not compress output: " << s.ToString();
}



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 9
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 22:00:42 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2427: update to latest version of curl

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10432 )

Change subject: KUDU-2427: update to latest version of curl
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 16 May 2018 21:42:08 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/2/src/kudu/fs/block_manager_util.cc
File src/kudu/fs/block_manager_util.cc:

http://gerrit.cloudera.org:8080/#/c/10419/2/src/kudu/fs/block_manager_util.cc@155
PS2, Line 155: PathInstanceMetadataFile::Lock
It seems to me this is only used by DataDirManager::LoadInstances



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 21:41:05 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 1:

(1 comment)

After a few ack-greps, I think maybe it's safe to remove the outer "Could not 
lock.." (in data_dirs.cc) and improve the inner "Could not lock.." (in 
block_manager_util.cc). Cuz the these two always come together.

http://gerrit.cloudera.org:8080/#/c/10419/1/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/10419/1/src/kudu/server/server_base.cc@449
PS1, Line 449: Is Kudu already running or are you trying "
 :"to run Kudu with a different user 
than before?
> The Status s comes from fs_manager_->Open, and could be any Status that fun
I see. Thanks.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 21:38:30 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10419

to look at the new patch set (#2).

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..

KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
---
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/2
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2427: adjust gold linker detection

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10428

to review the following change.


Change subject: KUDU-2427: adjust gold linker detection
..

KUDU-2427: adjust gold linker detection

This patch makes two adjustments to the existing gold linker detection:
1. Ubuntu 18.04's gcc 7 no longer respects a /usr/bin/ld symlink; it is
   hard-wired to use ld.bfd. Instead, we need to pass -fuse-ld=gold to
   choose the gold linker.
2. The old bug that led to tcmalloc being dropped from Kudu's dependency
   list has been fixed, so let's condition the workaround on the appropriate
   version of the gold linker.

Change-Id: Ib1fae9893aaaf4916205d4c5ae6bb5c93e0505d0
---
M CMakeLists.txt
M src/kudu/codegen/CMakeLists.txt
2 files changed, 78 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/10428/1
--
To view, visit http://gerrit.cloudera.org:8080/10428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1fae9893aaaf4916205d4c5ae6bb5c93e0505d0
Gerrit-Change-Number: 10428
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10434

to review the following change.


Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr
..

KUDU-2427: relax dlsym call to dl_iterate_phdr

When gcc passes --as-needed to ld by default, dynamically linked test
binaries that don't directly reference symbols in kudu_util may end up
loading libc before loading kudu_util. This causes dlsym(RTLD_NEXT, ...) on
libc symbols to fail because libc falls earlier in the symbol search order.

At first I thought this was a new problem in Ubuntu 18.04, but I was able to
reproduce it in Ubuntu 16.04 too; the only difference is that in Ubuntu
16.04 the failure isn't reported via dlerror() so we never noticed it. Given
that, I figured it'd be okay to make it non-fatal across the board.

Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
---
M src/kudu/util/debug/unwind_safeness.cc
1 file changed, 33 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/10434/1
--
To view, visit http://gerrit.cloudera.org:8080/10434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
Gerrit-Change-Number: 10434
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: fix glog symbolization in certain ASLR environments

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10431

to review the following change.


Change subject: KUDU-2427: fix glog symbolization in certain ASLR environments
..

KUDU-2427: fix glog symbolization in certain ASLR environments

On Ubuntu 18.04, glog is unable to symbolize the stack frames belonging to
a unit test binary itself, leaving them as "(unknown)". This breaks various
unit tests that check the contents of those frames.

There hasn't been a new glog release in some time, but this upstream patch
fixes the problem.

Change-Id: Iba6f715123ddf41ba67b93860caf7041b8e137c4
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-fix-symbolization.patch
2 files changed, 214 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/10431/1
--
To view, visit http://gerrit.cloudera.org:8080/10431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba6f715123ddf41ba67b93860caf7041b8e137c4
Gerrit-Change-Number: 10431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: retry more system calls on EINTR

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10435

to review the following change.


Change subject: KUDU-2427: retry more system calls on EINTR
..

KUDU-2427: retry more system calls on EINTR

In order to collect our own stack traces, we send ourselves a SIGUSR2. The
diagnostics log initiates collection every 60s, as do service queue
overflows. As such, it's really important that we retry every interruptible
system call rather than passing the EINTR up the call stack as a failure.

For whatever reason this happens more frequently on Ubuntu 18.04, though
maybe it's because I've placed my test directory on tmpfs. For example, I
can easily repro a crash due to non-existent retry with the following
command line:

  bin/tablet_server-test --gtest_repeat=1000 --gtest_throw_on_failure \
--diagnostics_log_stack_traces_interval_ms=100 \
--unlock_experimental_flags --gtest_filter=*KUDU_177

I went through env_posix.cc and looked for EINTR in every syscall's manpage.
If I found it, I made sure the call was surrounded by RETRY_ON_EINTR.

Change-Id: I6cce03c4e1b2be32c1910382737526082fc99966
---
M src/kudu/util/env_posix.cc
1 file changed, 33 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/10435/1
--
To view, visit http://gerrit.cloudera.org:8080/10435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cce03c4e1b2be32c1910382737526082fc99966
Gerrit-Change-Number: 10435
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] WIP: KUDU-1889: support openssl 1.1

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10436

to review the following change.


Change subject: WIP: KUDU-1889: support openssl 1.1
..

WIP: KUDU-1889: support openssl 1.1

OpenSSL 1.1 is the default version available in Ubuntu 18.04.

Note that because of KUDU-2439, tests built against OpenSSL 1.1 are still
somewhat unstable. I've seen some TSAN tests occasionally crash, and some
ASAN tests (seemingly those that use the CLI to connect to a remote server)
report memory leaks.

WIP because I have no idea what I'm doing.

Change-Id: If1e1c57b5563d1a4cd926b4c4a9a3c271460be04
---
M build-support/tsan-suppressions.txt
M src/kudu/rpc/reactor.cc
M src/kudu/security/ca/cert_management.cc
M src/kudu/security/ca/cert_management.h
M src/kudu/security/cert.cc
M src/kudu/security/cert.h
M src/kudu/security/crypto.cc
M src/kudu/security/openssl_util.cc
M src/kudu/security/security-test-util.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_handshake.cc
11 files changed, 123 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/10436/1
--
To view, visit http://gerrit.cloudera.org:8080/10436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1e1c57b5563d1a4cd926b4c4a9a3c271460be04
Gerrit-Change-Number: 10436
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: only add -fno-sized-deallocation for C++ files

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10430

to review the following change.


Change subject: KUDU-2427: only add -fno-sized-deallocation for C++ files
..

KUDU-2427: only add -fno-sized-deallocation for C++ files

Ubuntu 18.04 has a gcc that's new enough to support -fsized-deallocation.
But, if -fno-sized-deallocation is added to a C file's compilation flags,
the compiler will emit a warning:

  cc1: warning: command line option ‘-fno-sized-deallocation’ is valid for 
C++/ObjC++ but not for C

The problem is that we want to apply this flag only to "exported" targets,
but we have one such target (gutil_exported) that has both C and C++ files
in it. To address this, we can use a cmake generator expression[1] to
conditionally add the flag only to the C++ files in the target. This means
adding the flag with target_compile_options(), as set_target_properties()
does not support generator expressions.

1. https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html

Change-Id: Ib2fbd94f19495eb48119d8f9ecb6fdceee2387c3
---
M CMakeLists.txt
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/10430/1
--
To view, visit http://gerrit.cloudera.org:8080/10430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2fbd94f19495eb48119d8f9ecb6fdceee2387c3
Gerrit-Change-Number: 10430
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: update breakpad to latest HEAD

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10427

to review the following change.


Change subject: KUDU-2427: update breakpad to latest HEAD
..

KUDU-2427: update breakpad to latest HEAD

It includes a commit that fixes breakpad compilation with a modern gcc, such
as the one found in Ubuntu 18.04.

Change-Id: I83de57c6308605f75a447e6ef908b1335d7c4de3
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/10427/1
--
To view, visit http://gerrit.cloudera.org:8080/10427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83de57c6308605f75a447e6ef908b1335d7c4de3
Gerrit-Change-Number: 10427
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: make ksck-test replica order deterministic

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10433

to review the following change.


Change subject: KUDU-2427: make ksck-test replica order deterministic
..

KUDU-2427: make ksck-test replica order deterministic

On Ubuntu 18.04, the iteration order of std::unordered_map isn't the same as
on other distros. Behavioral changes like this are to be expected as the
iteration order is implementation-specific. However, we had some code in
ksck-test that expected a specific iteration order. Let's fix this by
switching from an std::unordered_map to an std::map.

Change-Id: I5da71f3582257febaccae7f142e5eb3a22548c19
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.h
2 files changed, 10 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/10433/1
--
To view, visit http://gerrit.cloudera.org:8080/10433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5da71f3582257febaccae7f142e5eb3a22548c19
Gerrit-Change-Number: 10433
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: update to latest version of curl

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10432

to review the following change.


Change subject: KUDU-2427: update to latest version of curl
..

KUDU-2427: update to latest version of curl

The existing version of curl doesn't work with OpenSSL 1.1, which is what
ships by default with Ubuntu 18.04.

Without the change to curl_util.cc, SslWebserverTest_TestSSL fails with:

  curl error: SSL peer certificate or SSH remote key was not OK

Change-Id: I804d01a5ed702501223dd4099100153cca412b49
---
M src/kudu/util/curl_util.cc
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
3 files changed, 9 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/10432/1
--
To view, visit http://gerrit.cloudera.org:8080/10432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] build: only call find package on gperftools if we're going to use it

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10429

to review the following change.


Change subject: build: only call find_package on gperftools if we're going to 
use it
..

build: only call find_package on gperftools if we're going to use it

Since commit e0a743d24, TSAN builds emit the following non-fatal warning
when cmake is run:

  -- Could NOT find GOOGLE_PERFTOOLS (missing: TCMALLOC_SHARED_LIB 
TCMALLOC_STATIC_LIB PROFILER_SHARED_LIB PROFILER_STATIC_LIB 
GOOGLE_PERFTOOLS_INCLUDE_DIR)

Moving the find_package() call into the gperftools condition means we won't
try to look for it at all when we're not going to use it.

Change-Id: I76b6c1244cdd5b901b6c23cb56a5613439113773
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/10429/1
--
To view, visit http://gerrit.cloudera.org:8080/10429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76b6c1244cdd5b901b6c23cb56a5613439113773
Gerrit-Change-Number: 10429
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/integration-tests/linked_list-test-util.h
File src/kudu/integration-tests/linked_list-test-util.h:

http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/integration-tests/linked_list-test-util.h@379
PS8, Line 379: Status s;
 : // Switch compression back and forth.
 : s = compression_enabled
> nit: why not to combine declaration with initialization here?
Done


http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/server/webserver.cc@490
PS8, Line 490: zlib::Compress(Slice(full_content), );
> What if it returns non-OK status?  Maybe, then do LOG(WARNING) and return a
Done



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 8
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 21:08:30 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Fengling Wang (Code Review)]

Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10332

to look at the new patch set (#9).

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..

KUDU-2035 Enable HTTP compression for all webserver's paths

This patch enables HTTP compression when gzip compression is
accepted by the client.

Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
5 files changed, 110 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/10332/9
--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 9
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Attila Bukor (Code Review)]

Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10293 )

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..


Patch Set 12:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.h
File src/kudu/tools/ksck.h:

http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.h@284
PS11, Line 284: this class. 'health' must
  :   // not be nullptr.
> Does it output anything with the 'health' out parameter?  I think it's wort
Documented it. Should it be a member of KsckTabletServer instead of an out 
parameter?


http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:

http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.cc@298
PS11, Line 298: return ts->FetchConsensusState();
> Why is it necessary to overwrite health status with FetchConsensusState()?
It can't change between these two calls, but if FetchInfo() sets health to OK 
and FLAGS_consensus is true, then FetchConsensusState() can still set this to 
UNAVAILABLE if it returns a non-OK Status. Does this make sense?


http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:

http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck_remote.cc@156
PS11, Line 156: DCHECK(health
> If you added this check for this method, maybe it's worth keeping the thing
Done



--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 20:35:26 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Attila Bukor (Code Review)]

Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar 
Dembo, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10293

to look at the new patch set (#12).

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..

KUDU-2426 Fix WRONG_SERVER_UUID case in ksck

RemoteKsckTabletServer::FetchInfo() returned a Status::RemoteError since
KUDU-2364 to indicate a UUID mismatch.
Ksck::FetchInfoFromTabletServers() checked for this Status, and this
resulted in any RemoteError showing as a WRONG_SERVER_UUID in the
tablet server health list.

This commit adds KsckServerHealth output argument to FetchInfo() and
FetchConsensusState() which can be used to add further context to a
non-OK Status.

Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tools/ksck_results.cc
7 files changed, 60 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/10293/12
--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 8:

(2 comments)

A couple of nits

http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/integration-tests/linked_list-test-util.h
File src/kudu/integration-tests/linked_list-test-util.h:

http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/integration-tests/linked_list-test-util.h@379
PS8, Line 379: Status s;
 : // Switch compression back and forth.
 : s = compression_enabled
nit: why not to combine declaration with initialization here?

Status s = ...


http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/10332/8/src/kudu/server/webserver.cc@490
PS8, Line 490: zlib::Compress(Slice(full_content), );
What if it returns non-OK status?  Maybe, then do LOG(WARNING) and return at 
this point (like it's done at line 444)?



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 8
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 18:48:16 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10293 )

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..


Patch Set 11:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.h
File src/kudu/tools/ksck.h:

http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.h@284
PS11, Line 284: this class. 'health' must
  :   // not be nullptr.
Does it output anything with the 'health' out parameter?  I think it's worth 
documenting that as well.

BTW, why not to put the 'health' as a member of the class as well?


http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:

http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.cc@298
PS11, Line 298: return ts->FetchConsensusState();
Why is it necessary to overwrite health status with FetchConsensusState()?  
Could it change since call of FetchInfo()?


http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:

http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck_remote.cc@156
PS11, Line 156: CHECK(health)
If you added this check for this method, maybe it's worth keeping the things 
consistent and add corresponding CHECK() into FetchConsensusState() as well?

>From other side, it will crash anyway even without that check at line 158.  
>Maybe, it's worth dropping this check or converting it into DCHECK()?



--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 18:38:58 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Add kudu-client dep to kudu-spark-tools

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10425 )

Change subject: [java] Add kudu-client dep to kudu-spark-tools
..

[java] Add kudu-client dep to kudu-spark-tools

We use the kudu-client APIs in kudu-spark-tools
but don’t define it as an explicit dependency.
Using transitive dependencies is a bad practice
but generally doesn’t break anything. However,
the Gradle Intellij integration seams to not find
the kudu-client project dependnecy if it’s not
explicitly listed here.

Change-Id: I6255bedac9781981ae8a937f0dc72afff0fc5ef0
Reviewed-on: http://gerrit.cloudera.org:8080/10425
Tested-by: Grant Henke 
Reviewed-by: Adar Dembo 
---
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Grant Henke: Verified
  Adar Dembo: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6255bedac9781981ae8a937f0dc72afff0fc5ef0
Gerrit-Change-Number: 10425
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [java] Remove private method usage in kudu-mapreduce

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10424 )

Change subject: [java] Remove private method usage in kudu-mapreduce
..

[java] Remove private method usage in kudu-mapreduce

kudu-mapreduce uses private APIs from KuduPredicate.
This is an issue because the API returns a protobuf
generated class and uses shaded APIs.

This isn’t strictly an issue in the gradle build itself because
calling the shaded methods is ok, but it is an issue in IDEs
like Intellij.

Regardless a shaded dependency is not part of
the public API and should not be exposed/used
because it can cause problems like this.

A follow on patch will work on enforcing that
protobuf is not exposed in the client API so this doesn’t
happen again.

Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a
Reviewed-on: http://gerrit.cloudera.org:8080/10424
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
3 files changed, 38 insertions(+), 12 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a
Gerrit-Change-Number: 10424
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [java] Remove private method usage in kudu-mapreduce

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10424 )

Change subject: [java] Remove private method usage in kudu-mapreduce
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java:

http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java@1106
PS1, Line 1106:   public String toString() {
> I wonder if we'd be better served building a serializer/deserializer around
I agree. The same may be true for scan token serialization.



--
To view, visit http://gerrit.cloudera.org:8080/10424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a
Gerrit-Change-Number: 10424
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 16 May 2018 17:40:23 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Add kudu-client dep to kudu-spark-tools

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10425 )

Change subject: [java] Add kudu-client dep to kudu-spark-tools
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6255bedac9781981ae8a937f0dc72afff0fc5ef0
Gerrit-Change-Number: 10425
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 16 May 2018 17:39:04 +
Gerrit-HasComments: No

[kudu-CR] [java] Remove private method usage in kudu-mapreduce

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10424 )

Change subject: [java] Remove private method usage in kudu-mapreduce
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java:

http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java@1106
PS1, Line 1106:   public String toString() {
I wonder if we'd be better served building a serializer/deserializer around the 
string representation of KuduPredicate.

A project for another time.



--
To view, visit http://gerrit.cloudera.org:8080/10424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a
Gerrit-Change-Number: 10424
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 16 May 2018 17:38:35 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10293 )

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..


Patch Set 11: Code-Review+1

The test failures all seem to be clock sync errors, although it seems IWYU is 
also complaining about the includes in ksck_remote-test.cc


--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 17:37:55 +
Gerrit-HasComments: No

[kudu-CR] [java] Expose the table replication factor on KuduTable

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10382 )

Change subject: [java] Expose the table replication factor on KuduTable
..

[java] Expose the table replication factor on KuduTable

Exposes the numReplicas table property to the KuduTable
API. The numReplicas property already exists in
GetTableSchemaResponsePB.

Change-Id: I18a044717dff1f39f1c9addd290917b8ec5a6f72
Reviewed-on: http://gerrit.cloudera.org:8080/10382
Tested-by: Grant Henke 
Reviewed-by: Adar Dembo 
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
7 files changed, 49 insertions(+), 7 deletions(-)

Approvals:
  Grant Henke: Verified
  Adar Dembo: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I18a044717dff1f39f1c9addd290917b8ec5a6f72
Gerrit-Change-Number: 10382
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [java] Expose the table replication factor on KuduTable

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10382 )

Change subject: [java] Expose the table replication factor on KuduTable
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18a044717dff1f39f1c9addd290917b8ec5a6f72
Gerrit-Change-Number: 10382
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 16 May 2018 17:31:26 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

It's there for both masters and tservers, since it's the same code path for 
both.

If you run that runkudu script once, let it succeed and start 3 masters, 3 
tservers, then run it again, you should see those FATALs on stderr in your 
shell, one per server, unless you've changed the configuration.


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 17:26:34 +
Gerrit-HasComments: No

[kudu-CR] remove logged Kudu URLs

[Andrew Wong (Code Review)]

Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9280 )

Change subject: remove logged Kudu URLs
..

remove logged Kudu URLs

Previously we would log urls like:
http://kudu.apache.org/releases/1.7.0/docs/...

...to link to pages for common-enough problems with complicated fixes
that warranted some documentation. Given how fragile these URLs can be,
this patch removes such messages, particularly since the URLs are
generated based on `version.txt`, which doesn't necessarily reflect a
proper URL (e.g. if on a SNAPSHOT build) and may be changed by
thirdparty vendors of Kudu.

Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Reviewed-on: http://gerrit.cloudera.org:8080/9280
Reviewed-by: Grant Henke 
Tested-by: Kudu Jenkins
---
M src/kudu/server/server_base.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 2 insertions(+), 8 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Gerrit-Change-Number: 9280
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

> > Hi Will. Could you tell me how to do "trying to start up a
 > tserver
 > > on top of the files of a running tservers"? I only saw the double "Could 
 > > not lock.." on master_main.cc when I ran ./runkudu


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 17:23:19 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

> Hi Will. Could you tell me how to do "trying to start up a tserver
 > on top of the files of a running tservers"?

NVM. Just found out it comes with the ./runkudu..


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 17:03:02 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

Hi Will. Could you tell me how to do "trying to start up a tserver on top of 
the files of a running tservers"?


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:58:50 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Attila Bukor (Code Review)]

Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10293 )

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc@296
PS8, Line 296: ts->FetchInfo().AndThen([,]() {
 : if (FLAGS_consensus) {
 :   return ts->FetchConsensusState(
> Sound good. Mind adding it to the commit message as well?
Done


http://gerrit.cloudera.org:8080/#/c/10293/10/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:

http://gerrit.cloudera.org:8080/#/c/10293/10/src/kudu/tools/ksck_remote.cc@209
PS10, Line 209: *health = KsckServerHealth::UNAVAILABLE;
> This never gets set to HEALTHY. I'm surprised that isn't caught somewhere b
nice catch. I looked into it, the tests didn't catch it as ksck-test.cc uses a 
mock FetchConsensusState(KsckServerHealth* health) which always returns 
KsckServerHealth::OK and ksck_remote-test.cc doesn't check the whole consensus 
matrix, only checked for WRONG_SERVER_UUID and as FetchConsensusState is called 
only if FetchInfo returns OK.

Now there's a new assertion in that fails 
RemoteKsckTest.TestTabletServerMismatchedUUID if 
FetchConsensusState(KsckServerHealth* health) returns UNAVAILABLE.



--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:57:35 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Attila Bukor (Code Review)]

Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd 
Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10293

to look at the new patch set (#11).

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..

KUDU-2426 Fix WRONG_SERVER_UUID case in ksck

RemoteKsckTabletServer::FetchInfo() returned a Status::RemoteError since
KUDU-2364 to indicate a UUID mismatch.
Ksck::FetchInfoFromTabletServers() checked for this Status, and this
resulted in any RemoteError showing as a WRONG_SERVER_UUID in the
tablet server health list.

This commit adds KsckServerHealth output argument to FetchInfo() and
FetchConsensusState() which can be used to add further context to a
non-OK Status.

Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tools/ksck_results.cc
7 files changed, 48 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/10293/11
--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] remove logged Kudu URLs

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9280 )

Change subject: remove logged Kudu URLs
..


Patch Set 7: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Gerrit-Change-Number: 9280
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:45:25 +
Gerrit-HasComments: No

[kudu-CR] remove logged Kudu URLs

[Andrew Wong (Code Review)]

Hello Will Berkeley, Kudu Jenkins, Grant Henke,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9280

to look at the new patch set (#7).

Change subject: remove logged Kudu URLs
..

remove logged Kudu URLs

Previously we would log urls like:
http://kudu.apache.org/releases/1.7.0/docs/...

...to link to pages for common-enough problems with complicated fixes
that warranted some documentation. Given how fragile these URLs can be,
this patch removes such messages, particularly since the URLs are
generated based on `version.txt`, which doesn't necessarily reflect a
proper URL (e.g. if on a SNAPSHOT build) and may be changed by
thirdparty vendors of Kudu.

Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
---
M src/kudu/server/server_base.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/9280/7
--
To view, visit http://gerrit.cloudera.org:8080/9280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Gerrit-Change-Number: 9280
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [java] Add kudu-client dep to kudu-spark-tools

[Grant Henke (Code Review)]

Grant Henke has removed a vote on this change.

Change subject: [java] Add kudu-client dep to kudu-spark-tools
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6255bedac9781981ae8a937f0dc72afff0fc5ef0
Gerrit-Change-Number: 10425
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [java] Add kudu-client dep to kudu-spark-tools

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10425 )

Change subject: [java] Add kudu-client dep to kudu-spark-tools
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6255bedac9781981ae8a937f0dc72afff0fc5ef0
Gerrit-Change-Number: 10425
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 16 May 2018 16:40:57 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 8: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 8
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:40:08 +
Gerrit-HasComments: No

[kudu-CR] remove logged Kudu URLs

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9280 )

Change subject: remove logged Kudu URLs
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Gerrit-Change-Number: 9280
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:17:55 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 8:

Just one-line change on curl_util.cc Line95.


--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 8
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:16:14 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Fengling Wang (Code Review)]

Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10332

to look at the new patch set (#8).

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..

KUDU-2035 Enable HTTP compression for all webserver's paths

This patch enables HTTP compression when gzip compression is
accepted by the client.

Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
5 files changed, 108 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/10332/8
--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 8
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [java] Add kudu-client dep to kudu-spark-tools

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10425


Change subject: [java] Add kudu-client dep to kudu-spark-tools
..

[java] Add kudu-client dep to kudu-spark-tools

We use the kudu-client APIs in kudu-spark-tools
but don’t define it as an explicit dependency.
Using transitive dependencies is a bad practice
but generally doesn’t break anything. However,
the Gradle Intellij integration seams to not find
the kudu-client project dependnecy if it’s not
explicitly listed here.

Change-Id: I6255bedac9781981ae8a937f0dc72afff0fc5ef0
---
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
2 files changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/10425/1
--
To view, visit http://gerrit.cloudera.org:8080/10425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6255bedac9781981ae8a937f0dc72afff0fc5ef0
Gerrit-Change-Number: 10425
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc
File src/kudu/util/curl_util.cc:

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc@96
PS7, Line 96: CHECK_NOTNULL(curl_headers);
> Oh I see. It seems fine? It's based on the example I followed:
(thumbsup)



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:10:33 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc
File src/kudu/util/curl_util.cc:

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc@96
PS7, Line 96: CHECK_NOTNULL(curl_headers);
> By choke I mean would curl_slist_append(ch, s) crash/SIGSEGV if ch is a nul
Oh I see. It seems fine? It's based on the example I followed:
https://curl.haxx.se/libcurl/c/httpcustomheader.html



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:09:28 +
Gerrit-HasComments: Yes

[kudu-CR] remove logged Kudu URLs

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9280 )

Change subject: remove logged Kudu URLs
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Gerrit-Change-Number: 9280
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:09:44 +
Gerrit-HasComments: No

[kudu-CR] [java] Remove private method usage in kudu-mapreduce

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10424


Change subject: [java] Remove private method usage in kudu-mapreduce
..

[java] Remove private method usage in kudu-mapreduce

kudu-mapreduce uses private APIs from KuduPredicate.
This is an issue because the API returns a protobuf
generated class and uses shaded APIs.

This isn’t strictly an issue in the gradle build itself because
calling the shaded methods is ok, but it is an issue in IDEs
like Intellij.

Regardless a shaded dependency is not part of
the public API and should not be exposed/used
because it can cause problems like this.

A follow on patch will work on enforcing that
protobuf is not exposed in the client API so this doesn’t
happen again.

Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
3 files changed, 38 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/10424/1
--
To view, visit http://gerrit.cloudera.org:8080/10424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a
Gerrit-Change-Number: 10424
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

(1 comment)

I noticed another funny thing about the fatal log when trying to start up a 
tserver on top of the files of a running tservers:

F0516 08:58:17.725335 2979312512 tablet_server_main.cc:86] Check failed: 
_s.ok() Bad status: IO error: Failed to load FS layout: Could not lock 
/private/tmp/kudu/data/tserver/0/data/block_manager_instance: Could not lock 
/private/tmp/kudu/data/tserver/0/data/block_manager_instance: lock 
/private/tmp/kudu/data/tserver/0/data/block_manager_instance: Resource 
temporarily unavailable (error 35)

See how the part "Could not lock 
/private/tmp/kudu/data/tserver/0/data/block_manager_instance" is repeated 
twice? Could you see if that's easy to fix as well?

http://gerrit.cloudera.org:8080/#/c/10419/1/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/10419/1/src/kudu/server/server_base.cc@449
PS1, Line 449: Is Kudu already running or are you trying "
 :"to run Kudu with a different user 
than before?
The Status s comes from fs_manager_->Open, and could be any Status that 
function returns. If you look at FsManager::Open, there's a lot of things that 
can go wrong besides being unable to lock an instance file. The "Can not lock" 
message comes from DataDirManager::Open(), so we either need to adjust the 
message there or detect the error here and adjust the error just in that case.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:08:01 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc
File src/kudu/util/curl_util.cc:

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc@96
PS7, Line 96: CHECK_NOTNULL(curl_headers);
> Opps my bad. And that's not leftover debugging. Maybe
By choke I mean would curl_slist_append(ch, s) crash/SIGSEGV if ch is a null 
pointer. If it did, the CHECK's don't help because we'd crash before them.



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:06:15 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Expose the table replication factor on KuduTable

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10382 )

Change subject: [java] Expose the table replication factor on KuduTable
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18a044717dff1f39f1c9addd290917b8ec5a6f72
Gerrit-Change-Number: 10382
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 16 May 2018 16:04:39 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc
File src/kudu/util/curl_util.cc:

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc@96
PS7, Line 96: CHECK_NOTNULL(curl_headers);
> nit: is this leftover debugging? Would curl_slist_append choke on a NULL cu
Opps my bad. And that's not leftover debugging. Maybe
curl_headers = CHECK_NOTNULL(curl_slist_append(curl_headers, header.c_str()));
is better?

And what do you mean the choking?



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:04:26 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Expose the table replication factor on KuduTable

[Grant Henke (Code Review)]

Grant Henke has removed a vote on this change.

Change subject: [java] Expose the table replication factor on KuduTable
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I18a044717dff1f39f1c9addd290917b8ec5a6f72
Gerrit-Change-Number: 10382
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10332 )

Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths
..


Patch Set 7:

(1 comment)

LGTM. One nit / question.

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc
File src/kudu/util/curl_util.cc:

http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc@96
PS7, Line 96: CHECK_NOTNULL(curl_headers);
nit: is this leftover debugging? Would curl_slist_append choke on a NULL 
curl_headers on the previous line anyway?



--
To view, visit http://gerrit.cloudera.org:8080/10332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 15:52:48 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10293 )

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..


Patch Set 10:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc@296
PS8, Line 296: ts->FetchInfo().AndThen([,]() {
 : if (FLAGS_consensus) {
 :   return ts->FetchConsensusState(
> Updated FetchConsensusState() to FetchConsensusState(), this felt mo
Sound good. Mind adding it to the commit message as well?


http://gerrit.cloudera.org:8080/#/c/10293/10/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:

http://gerrit.cloudera.org:8080/#/c/10293/10/src/kudu/tools/ksck_remote.cc@209
PS10, Line 209: *health = KsckServerHealth::UNAVAILABLE;
This never gets set to HEALTHY. I'm surprised that isn't caught somewhere by 
test; shouldn't that mean it will always result in an UNAVAILABLE ts in the 
report?

Also, for symmetry, doc `health` in ksck.h and check for nullptr.



--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 15:42:58 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2287 Expose election failures as metrics

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10076 )

Change subject: KUDU-2287 Expose election failures as metrics
..


Patch Set 15:

(1 comment)

Also needs some tests, maybe in raft-consensus-itest, and possibly partially as 
a new piece of existing tests. Probably also needs some tests specifically for 
pre-election v election behavior.

http://gerrit.cloudera.org:8080/#/c/10076/15/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/10076/15/src/kudu/consensus/raft_consensus.cc@439
PS15, Line 439: time_since_leader_lost_ = MonoTime::Now();
If a node loses contact with the leader for 10 seconds, say, and calls a 
pre-election which it loses, then this code will set time_since_leader_lost_. 
The node will then re-establish contact with the leader, with no term change 
and no call to SetLeaderUuidUnlocked. See DoElectionCallback. The metric will 
then erroneously imply the node doesn't see a leader until the tablet changes 
leadership.

Pre-elections are tricky to handle. We could have a node that is partitioned 
from the leader, but not from the other followers, and it will constantly call 
pre-elections and lose. In this case we'd like the time_since_leader_lost 
metric to keep increasing, not reset on every lost pre-election. But, if 
there's never a real election and the node re-establishes contact with the 
leader then we want the metric to reset. So I think maybe we should be tracking 
this metric through Update() (the heartbeat on the follower).



--
To view, visit http://gerrit.cloudera.org:8080/10076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3
Gerrit-Change-Number: 10076
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 15:43:13 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2287 Expose election failures as metrics

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10076 )

Change subject: KUDU-2287 Expose election failures as metrics
..


Patch Set 15: Verified+1

Agreed, that's a known flake.


--
To view, visit http://gerrit.cloudera.org:8080/10076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3
Gerrit-Change-Number: 10076
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 15:17:27 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2287 Expose election failures as metrics

[Will Berkeley (Code Review)]

Will Berkeley has removed a vote on this change.

Change subject: KUDU-2287 Expose election failures as metrics
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3
Gerrit-Change-Number: 10076
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [java] Expose the table replication factor on KuduTable

[Grant Henke (Code Review)]

Hello Mike Percy, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10382

to look at the new patch set (#2).

Change subject: [java] Expose the table replication factor on KuduTable
..

[java] Expose the table replication factor on KuduTable

Exposes the numReplicas table property to the KuduTable
API. The numReplicas property already exists in
GetTableSchemaResponsePB.

Change-Id: I18a044717dff1f39f1c9addd290917b8ec5a6f72
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
7 files changed, 49 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/10382/2
--
To view, visit http://gerrit.cloudera.org:8080/10382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18a044717dff1f39f1c9addd290917b8ec5a6f72
Gerrit-Change-Number: 10382
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Attila Bukor (Code Review)]

Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10293 )

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck_remote.h
File src/kudu/tools/ksck_remote.h:

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck_remote.h@28
PS8, Line 28: #include "kudu/util/net/net_util.h"
> yep, declared it in ksck.h, thanks for the tip
IWYU didn't like it, moved it to ksck_remote.h instead.



--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 11:11:04 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Attila Bukor (Code Review)]

Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd 
Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10293

to look at the new patch set (#10).

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..

KUDU-2426 Fix WRONG_SERVER_UUID case in ksck

RemoteKsckTabletServer::FetchInfo() returned a Status::RemoteError since
KUDU-2364 to indicate a UUID mismatch.
Ksck::FetchInfoFromTabletServers() checked for this Status, and this
resulted in any RemoteError showing as a WRONG_SERVER_UUID in the
tablet server health list.

This commit adds KsckServerHealth output argument to FetchInfo() which
can be used to add further context to a non-OK Status.

Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tools/ksck_results.cc
7 files changed, 40 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/10293/10
--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Attila Bukor (Code Review)]

Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10293 )

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc@296
PS8, Line 296: ts->FetchInfo().AndThen([,]() {
 : if (FLAGS_consensus) {
 :   return ts->FetchConsensusState(
> Ah, looking here, I don't think `health` gets set if `FetchConsensusState()
Updated FetchConsensusState() to FetchConsensusState(), this felt more 
natural, + this way we can introduce other statuses later, for example 
CONSENSUS_FETCH_FAILED instead of the more generic UNAVAILABLE. This felt out 
of scope though.


http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck_remote.h
File src/kudu/tools/ksck_remote.h:

http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck_remote.h@28
PS8, Line 28: #include "kudu/util/net/net_util.h"
> We should be able to forward declare KsckServerHealth, no?
yep, declared it in ksck.h, thanks for the tip



--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 11:01:22 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

[Attila Bukor (Code Review)]

Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd 
Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10293

to look at the new patch set (#9).

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
..

KUDU-2426 Fix WRONG_SERVER_UUID case in ksck

RemoteKsckTabletServer::FetchInfo() returned a Status::RemoteError since
KUDU-2364 to indicate a UUID mismatch.
Ksck::FetchInfoFromTabletServers() checked for this Status, and this
resulted in any RemoteError showing as a WRONG_SERVER_UUID in the
tablet server health list.

This commit adds KsckServerHealth output argument to FetchInfo() which
can be used to add further context to a non-OK Status.

Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tools/ksck_results.cc
7 files changed, 40 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/10293/9
--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley