Re: Surprising side-effects from gdm setting LC_MESSAGES in natty
Hi Michael, Thanks for your message! I sent a copy of my reply to the ubuntu-desktop mailing list, to make more people aware of the existence of the issue you reported. On 2010-12-28 17:09, Michael Bienia wrote: I'm not sure if I what I saw on my system is expected behaviour or some sort of bug in upgrading the .dmrc. I'm using en_IE.utf8 as locale (to have english messages and the €) and the upgrade of gdm worked so far fine. The problem showed up when I did a ssh connection to a Debian system and wondered why my umlauts stopped working as expected suddenly (they worked without problems till now) and locale complained about a non- existing locale (on the remote host). After some debugging I figured out that as now LC_MESSAGES is also set, ssh transmits it to the remote host. The problem was that LC_MESSAGES was set to en_AG.utf-8 which doesn't exist on the remote host. I finally found out that this value came from my .dmrc. I didn't look into the code why LCMess didn't got set to en_IE.utf8 on upgrade (I edited my .dmrc now) but picked en_AG.utf8 instead (the first UTF-8 locale in locale -a). If I understand you correctly, it's the environment variable LANG that contains en_IE.utf8, while en makes up the whole list in the LANGUAGE variable. The value in the LCMess field in .dmrc, and with that the LC_MESSAGES variable, is derived from the first item in the LANGUAGE list. The LANG value is not taken into consideration, and that's intentional. We have focused on making it work as expected for users who use a LANG locale with some other language than the language they want to apply for message translation. LANGUAGE and LC_MESSAGES control the language for translation, while LANG controls other localization aspects. As you have noticed, since only the language (en) is specified in LANGUAGE, the first available (English) locale is assigned to LCMess/LC_MESSAGES. In your case, since the available locales on the remote machine do not include en_AG.utf8, you need to be more specific when setting LANGUAGE. Both language-selector's Language tab and GDM's login page allow you to specify country, and that would be the easiest way to achieve the settings you need. Manually editing .dmrc works too, but that had not been necessary. I'm not sure whether this is a bug either. ;-) One way to reduce the risk for the behavior you described would be to assign LC_MESSAGES a locale that represents the main dialect, when the first LANGUAGE item consists of a language code only. I haven't figured out a way yet to determine the main dialect, though, so I'd appreciate tips on how to do that. It would be useful also for a closely related idea: https://launchpad.net/bugs/693337 Rgds, Gunnar https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Surprising side-effects from gdm setting LC_MESSAGES in natty
[repost in an attempt to make the list program send a readable message] Hi Michael, Thanks for your message! I sent a copy of my reply to the ubuntu-desktop mailing list, to make more people aware of the existence of the issue you reported. On 2010-12-28 17:09, Michael Bienia wrote: I'm not sure if I what I saw on my system is expected behaviour or some sort of bug in upgrading the .dmrc. I'm using en_IE.utf8 as locale (to have english messages and the €) and the upgrade of gdm worked so far fine. The problem showed up when I did a ssh connection to a Debian system and wondered why my umlauts stopped working as expected suddenly (they worked without problems till now) and locale complained about a non- existing locale (on the remote host). After some debugging I figured out that as now LC_MESSAGES is also set, ssh transmits it to the remote host. The problem was that LC_MESSAGES was set to en_AG.utf-8 which doesn't exist on the remote host. I finally found out that this value came from my .dmrc. I didn't look into the code why LCMess didn't got set to en_IE.utf8 on upgrade (I edited my .dmrc now) but picked en_AG.utf8 instead (the first UTF-8 locale in locale -a). If I understand you correctly, it's the environment variable LANG that contains en_IE.utf8, while en makes up the whole list in the LANGUAGE variable. The value in the LCMess field in .dmrc, and with that the LC_MESSAGES variable, is derived from the first item in the LANGUAGE list. The LANG value is not taken into consideration, and that's intentional. We have focused on making it work as expected for users who use a LANG locale with some other language than the language they want to apply for message translation. LANGUAGE and LC_MESSAGES control the language for translation, while LANG controls other localization aspects. As you have noticed, since only the language (en) is specified in LANGUAGE, the first available (English) locale is assigned to LCMess/LC_MESSAGES. In your case, since the available locales on the remote machine do not include en_AG.utf8, you need to be more specific when setting LANGUAGE. Both language-selector's Language tab and GDM's login page allow you to specify country, and that would be the easiest way to achieve the settings you need. Manually editing .dmrc works too, but that had not been necessary. I'm not sure whether this is a bug either. ;-) One way to reduce the risk for the behavior you described would be to assign LC_MESSAGES a locale that represents the main dialect, when the first LANGUAGE item consists of a language code only. I haven't figured out a way yet to determine the main dialect, though, so I'd appreciate tips on how to do that. It would be useful also for a closely related idea: https://launchpad.net/bugs/693337 Rgds, Gunnar https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Default Desktop Experience for 11.04
On 2011-04-08 08:52, Martin Pitt wrote: Rick Spencer [2011-04-07 18:38 -0700]: 1. There are key feature regressions, for example, there is no systray support for many important applications. ... If this is a major issue, then frankly I'd rather just remove the whitelist and allow all old-style systray applications than dropping Unity by default completely. Totally unaware of the preceding considerations, I'm a little puzzled by this discussion. Based on what I have read in this thread, I'd vote for dropping the whitelist whether the issue is major or not. Personally I have noticed that mail-notification is broken in Unity, which is enough of a reason for me to keep using Classic for now when not needing Unity for developing tests. If the feature can be provided, without a price in the form of e.g. extra maintenance time, is there a good reason for disabling it? Closing the door prematurely on the users and developers concerned seems not right to me. -- Gunnar Hjalmarsson -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Call for testing: LightDM
On 2011-06-06 10:06, Kevin Huang wrote: On 2011-06-06 10:01, Robert Ancell wrote: On 2011-06-04 11:48, Kevin Huang wrote: In GDM design, the display language can be set on two levels: system wide, which determines what shown on the login screen, and user specific. It's only the user language that can be set from the login screen. Since there is no language option in LightDM screen, I assume no user language that can be set in Oneric. Is it correct? No. The ability to let each user set their language preferences is primarily controlled via Language Support. It does not depend on whether you can set the user language from the login screen. This feature is just not implemented yet. It will be in Oneiric. Good to know, Robert. Are you able to say something about e.g. the keyboard layout and universal access? Great. Is Gunnar Hjalmarsso involved in this feature implementation, I'm not yet, but I plan to make myself involved to assist with the i18n matters. :) I'll try to ensure that the current functionality with respect to languages and locales is preserved in the Oneiric release. -- Gunnar Hjalmarsson -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Call for testing: LightDM
On 2011-06-07 10:22, Robert Ancell wrote: Are you able to say something about e.g. the keyboard layout and universal access? This is an area where I'm definitely not an expert, and your help is greatly appreciated here! Most of my knowledge has come from picking Martin Pitt's brain and talking to others. Hmm.. I merely asked because I wouldn't like to see significant regression, and did not mean to imply that I have anything useful to contribute with. Sorry if I gave another impression. :-/ ... I plan to make myself involved to assist with the i18n matters. :) I'll try to ensure that the current functionality with respect to languages and locales is preserved in the Oneiric release. Please do! File bugs on anything that's not up to scratch. You'll hear from me soon. Thanks! -- Gunnar Hjalmarsson -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Reports for Desktop Bugs
Nice work, Pedro! On 2011-06-15 20:29, Pedro Villavicencio Garrido wrote: Please review the page and let me know what you'd like to include,remove,etc. If I'm missing a package you're looking please also tell me I suggest that lightdm and language-selector are included. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Language chooser at login
I have discussed briefly with a couple of developers whether there should be a language chooser on the login screen, and we believe it's a suitable topic for this list. The background is that GDM has provided a language chooser for a long time, but GNOME has (for unclear reasons) dropped it in GDM 3, which will be an available display manager in Oneiric. LightDM, which will be the default dm in Oneiric, had a language chooser in the Natty version, but in the latest versions it has been disabled. I'm of the opinion that we should keep providing a language chooser widget on the login screen, either in the greeter or on the top panel. Before giving the reasons for my view, I'd like to clarify which kind of language chooser it is that I advocate. In short, I'd like it to work as it currently does in Natty. Unlike before, when there was a plain locale chooser that didn't play well with the Lucid and Maverick versions of language-selector, in Natty GDM's language chooser - has a list whose options represent available translations (which in some languages, such as English and Spanish, means a significantly shorter list than before), - persistently changes the user language, and - is well synchronized with language-selector. Over to my arguments: If you change the display language within a session, it does not take effect in that session, but only after you have logged out and logged in again. The language setting is one of the few things that works that way. Those who typically make use of the language chooser on the login screen are reasonably users who alter between two or more display languages. Maybe that group is a small share of the Ubuntu users, but to them it's much more convenient to be able to set the language before logging in, compared to logging in, opening language-selector, changing the language, logging out and then logging in again. Future growth of Ubuntu users will probably be higher outside the English speaking countries than the average growth, so both the number and percentage of multi-lingual users, and consequently also the group that appreciate an opportunity to change language at login, ought to increase. From an Ubuntu user perspective, the question isn't if we should add a language chooser to the login screen, but the question is whether it would be a good idea to remove the feature. Is there any disadvantage with it worth mentioning for those who don't use it? Has anybody complained of its pure existence? ;-) i18n is a key point in the Ubuntu philosophy, and the relative importance of i18n matters in general is growing. In the light of that, I think that removing the language chooser from the login screen would send the wrong signals to prospective Ubuntu users. So let's not do so, please. :) -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Language chooser at login
Robert, I take it that you would like to see a solid base for decision that we do not have access to. Given that, to me the natural conclusion is that Ubuntu keeps providing the feature for now. Btw, your position on this topic seems to have changed rapidly. The language chooser is included in the design description at http://www.freedesktop.org/wiki/Software/LightDM/Design, which I suppose formed a part of the base for the decision to make LightDM the default dm in Ubuntu. And a few weeks ago you stated explicitly on this list that the feature will be included in the Oneiric release. What happened? On 2011-07-04 04:44, Robert Ancell wrote: On 2011-07-03 08:01, Gunnar Hjalmarsson wrote: Those who typically make use of the language chooser on the login screen are reasonably users who alter between two or more display languages. Maybe that group is a small share of the Ubuntu users, but to them it's much more convenient to be able to set the language before logging in, compared to logging in, opening language-selector, changing the language, logging out and then logging in again. Can you provide some examples of these types of users, and why/how they currently switch language? I probably wouldn't do that better than you. But if you think about it, if you would require that sort of insight about every feature we are currently providing, there are a lot of features that should be wiped out right away. ;-) I haven't heard of any standard user requirements to switch between more than two languages, or two languages that do not include English (please post here if you know of any). In another reply Oliver Grawert just gave us some examples worth considering. There are disadvantages to keeping this feature: - This feature is quite complex to support. How? Once in place, I fail to see that complexity. Ok, since I worked with the current Natty solution, I'm about as biased as anyone can be... - By having this feature both in the login screen and in the control center we are duplicating functionality but providing an inconsistent method of configuring it. Agreed. Certainly there is room for organizing the code better, including sharing code between the dm and language-selector. I'd be happy to help with that. - Users can accidentally change it, giving an opportunity to make their session unusable. ??? As I said in a bug comment, I understand that you are loaded with various other aspects of LightDM, to make it stable before the Oneiric release, and that you may not feel for struggling with a language chooser on top of it. But you also know that I have offered to help out with getting the functionality in place. You just need to open the door. Then let's develop this aspect of the desktop further after having considered various options more carefully and in a more structured way than currently is the case. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Language chooser at login
On 2011-07-05 05:31, Robert Ancell wrote: On 04/07/11 21:00, Gunnar Hjalmarsson wrote: I take it that you would like to see a solid base for decision that we do not have access to. Given that, to me the natural conclusion is that Ubuntu keeps providing the feature for now. For a feature to exist, it needs a justification. I see no reason why the result of this discussion cannot produce one if it exists. If there is no justification, then we should not continue a feature. Both pros and cons have been mentioned in this thread. Some of the cons have been conditioned by alternative features that are not ready yet. I think that the pros is enough of a justification to keep providing the feature in Oneiric. In addition to that, the fact that this discussion started is a good reason IMO to consider the matter further during UDS-P. In a thread like this, people tend to forget that there is more into handling languages than picking a locale; see my reply to Martin's message. Also, please note that the decision to include or not include a language selector in Ubuntu does not necessarily reflect the design of LightDM or any other greeters that may be developed for it. That's true. It would make sense that upstream LightDM and Ubuntu differ in this respect. But if the design of upstream LightDM does not include a language chooser, it's highly desirable that the preparations for such a thing, that it currently is shipped with, are kept for now, so it's easy for e.g. Ubuntu to patch a chooser. There are disadvantages to keeping this feature: - This feature is quite complex to support. How? Once in place, I fail to see that complexity. Ok, since I worked with the current Natty solution, I'm about as biased as anyone can be... This feature involves setting a number of environment variables, which may be overridden by login scripts. It needs to be synchronised with the session. Implementing a feature is only one part of the work, keeping it working in the future when other parts of the code change is not free. Ok, that's true, even if I have a feeling that you to some extent think of code that is there for other reasons than the language chooser on the login screen. And a better organized code would make it easier to support. Think of how you would answer this question from a user: How do I change my language? Would the answer be - from the login screen or from the control center. But if you want to change the number format, then only in the control center. Or should you say - from the control center, where all the other settings are. I would say that the principal tool for i18n related settings is the one that you access from the Control Center, and that there is a supplemental tool on the login screen for setting the user language only. Just as I do in language-selector's help document. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Let's discuss this at the next UDS
On 2011-07-06 21:49, Matthew Paul Thomas wrote: Gunnar Hjalmarsson wrote on 06/07/11 07:05: In addition to that, the fact that this discussion started is a good reason IMO to consider the matter further during UDS-P. In a thread like this, people tend to forget that there is more into handling languages than picking a locale; see my reply to Martin's message. A 50-minute face-to-face UDS discussion has its benefits, but waiting 111 days to consider the matter further is far too high a price to pay. Hmm.. My first reaction to that comment was: How many years has GNOME, and with that Ubuntu, provided a language chooser on the login screen? How on earth can this topic suddenly have become so urgent that its solution can't wait another development cycle? But I agree that a 50 minutes session has its limitations. My thought with suggesting UDS was that it would give us time to do careful preparations. I suppose that those preparations would in effect be much more important than the actual session. Since you focus on collaborative documents etc., I think we share the same idea about what it takes to tackle the topic in a proper manner. Can't help worrying a little about the time constraints, though. I spent quite some time during the Natty development cycle to help fix a bunch of bugs about language and locale issues. I'd hate to see Oneiric be shipped with similar bugs as those that were recently resolved because the work is rushed unnecessarily. Maybe my concerns are related to the fact that I'm a newbie here, with very little experience of the kind of collaboration you outline. I look forward to it, though. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Language chooser at login
After having reviewed this thread, there are a few things I'd like to highlight: Language chooser As regards the language chooser on the login screen, it basically serves two purposes: 1. For users who change display language once in a while - for whatever reason - it provides a more convenient way for doing so than doing it from the Language Support UI or its successor. There is a fresh bug report about it, btw: https://launchpad.net/bugs/803858 2. It gives the user of a newly created account an instant possibility, before first login, to set some other display language than the one that was inherited from the system language. In Oneiric the UI for adding a user will include a possibility for admin to select the initial user language, which feature might be considered to replace purpose #2, but not purpose #1. I for one think that purpose #1 justifies that Ubuntu keeps providing a language chooser on the login screen. Shared scripts -- A couple of entries in this thread have hold a perceived complexity of the code against a language chooser on the login screen. I agree that the code for handling certain language related bits and pieces is currently not very well organized. To avoid duplication and facilitate maintenance, I think that a few shared scripts should be written that can be be called from any package - at system installation, at user creation, from the dm, from Language Support, and even when launching a guest session. The package containing those scripts should be a dependency of the packages from which one or more of the scripts are called. It could be language-selector or a new separate package. I think this refactoring should be done irrespective of the conclusion with respect to the language chooser. The shared scripts would probably also facilitate the move from the Language Support UI to the applicable GNOME UI. Storing of language settings As an input to the suggested code refactoring, I believe it's appropriate to talk about where the user language settings are stored. The primary place in Natty is /var/cache/gdm/$USER/dmrc, which file both GDM and language-selector read from and write to. language-selector also writes to ~/.profile, but as long as GDM is the dm, the language settings in ~/.profile are ignored. One advantage with using /var/cache/gdm/$USER/dmrc in this way is that the user language is dealt with correctly even if $HOME is not available, e.g. because it's stored on a separate device that is not mounted or because it's encrypted. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Desktop12.04-Topic] Desktop sound theme,effects?
On 2011-10-10 11:12, Sebastien Bacher wrote: Le lundi 10 octobre 2011 à 11:08 +0200, Martin Pitt a écrit : IMHO startup applications is just about the last place I'd look for sound effects. Right, it's the wrong place but it might be the easiest workaround if wewant to expose it somewhere in the ui without breaking any ui freeze... I too agree that Startup Applications... is not the optimal place, but I thought that that tiny change might be possible to upload to 11.10. IMO, providing an easy way to control the login sound is highly desirable. At least you can point at it when people ask... -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: disable login sound
On 2011-10-17 20:29, Carl Karsten wrote: I want to disable the login sound using a script. To disable it using the gui, you need to do this: http://maketecheasier.com/disable-login-sound-in-ubuntu-oneiric-quick-tips/2011/09/15 Where is the x in Startup Applications: [x] Gnome Login Sound setting stored ? This topic was recently discussed in another thread: https://lists.ubuntu.com/archives/ubuntu-desktop/2011-October/003283.html Seems like the x will be back soon as an update to 11.10. :) https://launchpad.net/bugs/840858 -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Language chooser at login
Progress has been made, and this is a short update. Ubuntu 11.10 was shipped with a language chooser in lightdm-gtk-greeter. Thanks, Robert! Unfortunately - due to time restraints - the chooser is currently broken as regards Ubuntu; see https://launchpad.net/bugs/868346 A proposed fix is available in my PPA at https://launchpad.net/~gunnarhj/+archive/misc I hope it will be uploaded as an update of Ubuntu 11.10. You can help increase the chances for that by installing the PPA package and let us know via a comment on bug 868346 whether it works to your satisfaction. Update on other things that were mentioned in https://lists.ubuntu.com/archives/ubuntu-desktop/2011-July/003165.html: * Shared scripts The shared scripts I talked about are now provided by the accountsservice package. * Storing of language settings In 12.04 we will probably drop ~/.profile as the storing place. PAM has been mentioned as an appropriate tool for actually setting the locale/language environment, and the data will probably be stored in a PAM config file or accountsservice or both. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Low bug triage activity all around
On 2013-01-01 19:04, Omer Akram wrote: On Tue, Jan 1, 2013 at 10:46 PM, Dr. David Alan Gilbert wrote: On 2013-01-01 18:21, Omer Akram wrote: So I think we need to think of some ways to improve the situation and get more people involved into this effort. Does anyone have suggestions/comments about this matter. Most of the irc seems to have been pretty dead over xmas, I'm guessing there aren't many of us doing it just for the heck of it at the moment. There is also the danger that perhaps some of the others got a life and we aren't getting new ones in. That may be a factor... Well, let's hope that community efforts do not depend on people without a life. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Why make ubuntu-desktop recommends ibus and friends?
On 2013-04-01 19:37, Ma Xiaojun wrote: Removing unnecessary dependency of IBus stuff from ubuntu-desktop can make derivatives, e.g., UbuntuKylin life a bit easier I guess. IBus and fcitx are not conflicting, so how do you mean it would make a difference? (disclosure: I installed UK recently but the installer somehow screwed up and IBus is still pulled.) Do you know they tried to not ship IBus? Last I heard was that they were about to ship both. Otherwise /usr/share/language-selector/data/pkg_depends might have something to do with it. Ma Xiaojun: You may want to get involved at https://blueprints.launchpad.net/ubuntu/+spec/client-input-methods -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Assistance Needed?
Hi Geet, and welcome to the Ubuntu community! I think these are two good starting points: https://wiki.ubuntu.com/DesktopTeam http://packaging.ubuntu.com/html/ On 2014-01-28 05:00, Geet Kumar wrote: I am available to work on any assignment which is currently pending. If anyone needs assistance with any sort of work, please email me; That's not how it usually works. A good way to get started is to simply pick a bug in a package that interests you, and prepare a merge proposal or a patch. That way you'll get a grasp of the working flow. If you get stuck, the IRC channel #ubuntu-desktop is a good place to ask for help. Good luck, and welcome again. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Docs on input methods
Our official desktop documentation does not include much about the use of IBus input methods. In the ubuntu-docs trunk for 14.04LTS we have this page: http://people.ubuntu.com/~gunnarhj/keyboard-layouts.html It basically comments on the Text Entry capplet in System Settings. However, I have a feeling that the docs on this topic should better be extended to be relevant to e.g. an Asian user who uses IBus input methods. Consequently it would be great if some input method user could take a look at the linked document and propose additions and/or suitable links. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Call for testing - unity-control-center (fork of gnome-control-center so we can stay on an old version)
I uninstalled g-c-c, g-s-d and gnome-session. Was able to relogin, and my computer did not explode. :) Some observations: To be able to uninstall g-s-d, I had to install gdm. I suppose that gdm (Ubuntu) should be changed to not depend on g-s-d. The following packages could not be uninstalled due to dependencies: - libgnome-control-center1 - gnome-settings-daemon-schemas - gnome-session-(bin/common/canberra) -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Call for testing - unity-control-center (fork of gnome-control-center so we can stay on an old version)
On 2014-02-20 10:34, Gunnar Hjalmarsson wrote: To be able to uninstall g-s-d, I had to install gdm. s/install gdm/uninstall gdm/ -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Call for testing - unity-control-center (fork of gnome-control-center so we can stay on an old version)
On 2014-02-20 10:49, Sebastien Bacher wrote: Le 20/02/2014 10:34, Gunnar Hjalmarsson a écrit : To be able to uninstall g-s-d, I had to install gdm. I suppose that gdm (Ubuntu) should be changed to not depend on g-s-d. No, gdm is the GNOME login manager and uses GNOME depends, that's normal. Unity uses lightdm/unity-greeter which don't need gnome-settings-daemon Will gdm + Unity keep being a possible option? -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Video editor
On 2014-10-03 12:52, Gunnar Hjalmarsson wrote: Pitivi does not work in 14.04 (segmentation fault at launch), ... I just run Pitivi on a fresh 14.04.1 install, so it may not be as bad as I said. (Still unable to launch it on my non-fresh but updated 14.04, though.) -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Video editor
I filed https://launchpad.net/bugs/1377592 where I propose that Pitivi is replaced with OpenShot in the Ubuntu slideshow in the 14.10 installer. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Video editor
On 2014-10-06 08:03, Timo Jyrinki wrote: The upstream has around 80 commits in the recent weeks, so it does not look non-maintained: https://github.com/GNOME/pitivi/commits/master Right, I stand corrected (again). The crash fix for 14.04 would be worth SRU:ing. I was about to do just that. Then, when I noticed that I could run Pitivi on a fresh 14.04 install, I hesitated. Please note that even if the patch at https://bugzilla.gnome.org/727851 fixes the crash, it messes up the windows. So for those with Pitivi working it would lead to a regression. On 2014-10-06 15:42, Iain Lane wrote: Since we recommend this in the installer, I've just spent some time cherry-picking a few patches from upstream to resolve the crash bug and others - it becomes apparent once you fix the immediate crash and fail to launch problems that there are some UI rendering issues. I'll clean up and upload this to Utopic today Great, Iain! If it turns into a useful shape, I withdraw my proposal to change the recommendation. But please note my reservation above about the 14.04 patch. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: offers to make Fcitx default on Japanaese.
Hi Ikuya! On 2015-03-26 01:25, AWASHIRO Ikuya wrote: I would like to say that fcitx should be default on Japanese environment as same as Chinese at 15.04 cycle. We Ubuntu Japanese Team release their own remix called Ubuntu Japanese Remix with a little modification. Fcitx is default Input Method from 14.04 on it. Given the IM related changes in 15.04, making fcitx the default IM framework on all Japanese installs is probably the simplest way to keep offering fcitx as default on the Japanese remix, and thus preventing a kind of regression. So it is time to change the default Input Method on Japanese environment. Assuming that there is a consensus that fcitx is better than ibus for inputting Japanese, it makes sense to me to do it 15.04. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: i386 EOL plans for Ubuntu Desktop?
On 2016-07-05 21:31, Marcos Alano wrote: > 2016-07-05 12:57 GMT-03:00 Bryan Quigley > <bryan.quig...@canonical.com>: >> The general ideas are: >> A. Drop ubuntu-desktop i386 ISO for 16.10 and drop some packages >> from the i386 archive - likely Unity7/8*. > > I think the option A should be put out of discussion or, at least, > analyzed very carefully. That's because some applications for i386 > don't have equivalent for amd64. And other applications depend of > some i386 packages present in the repositories. Big examples are > Skype and Steam. Steam depends of a series of i386 packages for GUI. You can use those applications without installing a 32 bit system. Dropping the ISO isn't equivalent to dropping all the 32 bit packages. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Ubiquity Proposal - Add "minimal" setup with kernel parameter
On 2017-07-13 18:11, Carl Richell wrote: With more deliberation, we're starting to think Ubiquity is over-complicated. With the move to GNOME, it may be time for new installer. We're going to investigate another approach. Installation = Boot to live session that prompts and configures language and kb layout > desktop/dash icon for installation > new installer with disk+encryption setup only. GNOME Initial Setup for user config on first boot. Please don't forget the flavors. Also, currently the installer sets system wide stuff, while the settings can be modified per user. Does GNOME Initial Setup have the ability to distinguish between system wide and user specific? -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Fwd: Re: Advanced input methods in 17.10/18.04
Forwarding the below message since it seems to have not made it to the list for some reason. Forwarded Message Subject: Re: Advanced input methods in 17.10/18.04 Date: Fri, 19 May 2017 21:24:36 +0900 From: AWASHIRO Ikuya <ik...@fruitsbasket.info> Organization: fruitsbasket.info To: Gunnar Hjalmarsson <gunna...@ubuntu.com> CC: ubuntu-desktop@lists.ubuntu.com Hi Gunnar, On Tue, 9 May 2017 17:56:42 +0200 Gunnar Hjalmarsson <gunna...@ubuntu.com> wrote: Going forward I suppose we have these options: 1. Implement support for Fcitx in g-c-c and keep Fcitx as the default IM framework for CJKV. (Does anybody have time to add Fcitx support to g-c-c? Would it be possible to have it accepted upstream?) 2. Keep Fcitx as the default IM framework for CJKV, and let the affected users live with the missing g-c-c integration. (I can't tell how well tested the use of other IM frameworks but IBus in Ubuntu GNOME is.) 3. Go back to IBus as the default IM framework for all languages. IMHO, 3 is better. It is hard to support/use Fcitx for GNOME Shell. Because: 1. g-c-c (and g-s-d) does not support Fcitx as Gunnar says. 2. Fcitx does not support GNOME Shell's status area icon. It must be by design. 3. Input Method Panel extension[^1] is good extension for Fcitx and GNOMEShell, but it does not support to show Hankaku/Zenkaku mode on Japanese language. It is hard to use. 4. Current Fcitx does not support Wayland as Joakim says. 5. gnome-initial-setup does not support Fcitx. [^1]: https://extensions.gnome.org/extension/261/kimpanel/ Regards, -- AWASHIRO Ikuya ik...@fruitsbasket.info / ik...@oooug.jp / iku...@gmail.com GPG fingerprint: 1A19 AD66 C53F 2250 3537 1A9D 3A53 2C1D 20AB CC8A -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Advanced input methods in 17.10/18.04
On 2017-08-16 18:52, Mitsuya Shibata wrote: Hi all, 1. Implement support for Fcitx in g-c-c and keep Fcitx as the default IM framework for CJKV. (Does anybody have time to add Fcitx support to g-c-c? Would it be possible to have it accepted upstream?) 2. Keep Fcitx as the default IM framework for CJKV, and let the affected users live with the missing g-c-c integration. (I can't tell how well tested the use of other IM frameworks but IBus in Ubuntu GNOME is.) 3. Go back to IBus as the default IM framework for all languages. (snip) IMHO option 3 would be something rollback, but saves manpower to work on items. If we want decent features, I'd recommend we go either Option 1 or 2. How about this? It seems that fcitx support in g-c-c is not implemented yet on daily build. Is there any branch or ppa to test it? If so, I would like to try it. I don't think (guessing here - please correct me if I'm wrong) that any work on fcitx support in g-c-c has been done yet. Also, I haven't noticed that any decision on the topic has been made yet, neither for 17.10 nor 18.04. If we assume that no integration will be available in 17.10 and that it *may* be available in 18.04, we still need to decide on the default IM framework for 17.10. Mitsuya, it would be valuable if you could evaluate option 2, i.e. fcitx as the default IM framework for CJKV without g-c-c integration. While Aron mentioned it as a possibility, Ikuya Awashiro raised some doubts. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Advanced input methods in 17.10/18.04
unity-control-center supports both IBus and Fcitx. While IBus is launched by default for most users, Fcitx is the default IM framework for Chinese, Japanese, Korean and Vietnamese (CJKV). Thus, if you select a CJKV language when installing Ubuntu, Fcitx is the IM framework in use at first login. gnome-control-center (g-c-c) only supports IBus, and in Ubuntu GNOME IBus is the default IM framework irrespective of the selected language. Since the fix of <https://launchpad.net/bugs/1594681>, and even if g-c-c does not support it, the Ubuntu GNOME users have the option to use Fcitx or some other alternative to IBus. If doing so they need to set up the input method(s) using e.g. Fcitx Configuration, not g-c-c. The decision to switch to Fcitx as default for CJKV in Ubuntu was made for a reason. The Fcitx tools are better maintained and preferred over IBus by many CJKV users, not least for Simplified Chinese. Going forward I suppose we have these options: 1. Implement support for Fcitx in g-c-c and keep Fcitx as the default IM framework for CJKV. (Does anybody have time to add Fcitx support to g-c-c? Would it be possible to have it accepted upstream?) 2. Keep Fcitx as the default IM framework for CJKV, and let the affected users live with the missing g-c-c integration. (I can't tell how well tested the use of other IM frameworks but IBus in Ubuntu GNOME is.) 3. Go back to IBus as the default IM framework for all languages. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: mozc support in the default ISO
Hi Jeremy, On 2017-09-23 22:47, Jeremy Bicha wrote: Qt4 was removed from the default Ubuntu 17.10 ISO this week as a result of dropping fcitx support there. It looks like the only reason Qt5 is still there is because ibus-mozc recommends mozc-utils-gui which depends on Qt5. mozc is a Japanese input method but we do not pre-install Japanese language packs in the live environment. mozc was added to the live environment just before Ubuntu 15.10 was released: https://bazaar.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/ubuntu.artful/revision/2363 To use the mozc input method, I had to install ibus-mozc and then log out of GNOME and log back in for it to show up in GNOME Settings > Region & Language > Input Sources > + > … > Other > Japanese (Mozc) . Since I have more than one input method/keyboard now, a language menu shows up in the right side of the top bar. That menu allows switching between 6 different mozc modes. gnome-control-center does not provide any other mozc preferences. mozc-utils-gui adds a "Mozc Setup" app. This app has a low-resolution icon which doesn't look as good when people are browsing the list of installed apps in the live environment. mozc-utils-gui allowing customizing a lot of apparently useful mozc preferences. Here are some follow-up questions: 1. Does it make sense to have ibus-mozc in the live environment but without mozc-utils-gui? Aren't packages, which are recommended by packages in the live seed, automatically included on the ISO? Or is it possible to explicitly exclude recommended packages? I tested without mozc-utils-gui, and was able to select between different modes and produce beautiful characters. One difference I noticed when installing mozc-utils-gui was that also a 'tools' menu showed up in the language menu. I added Mitsuya Shibata to the thread, since I'm not able to comment on the importance of the package for live sessions. Two own thoughts: * If we still have qt5, why do you keep the question open? * If mozc-utils-gui would be moved from the ISO somehow, I think we'd need to let pkg_depends pull it explicitly, and then it would need to be in 'supported', right? -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Resources on packaging.ubuntu.com/api/devel getting 404 error
On 2017-10-17 10:03, Khurshid Alam wrote: Doc team's Gunnar pointed me towards this: https://lists.ubuntu.com/archives/ubuntu-community-team/2017-October/001567.html But it didn't help. Right, I mixed up developer.ubuntu.com with community.ubuntu.com, so that tip was a mistake. Sorry. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: mozc support in the default ISO
On 2017-09-24 10:19, Mitsuya Shibata wrote: On non-live session, mozc-utils-gui needs to be installed for Japanse Input Method users. Many Japanese users customize keymap style (MS-IME like or ATOK like, and so on...), customize romaji table, add/edit user's dictionary... Could this be automatically done by ubiquity and language-selector as like language-pack? Yes, that's how it would reasonably be done if it's decided to drop it from 'live'. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: mozc support in the default ISO
On 2017-10-22 14:58, Mitsuya Shibata wrote: I guess we need to patch gnome-desktop if Ubuntu decides to use different default input methods for certain languages. What significance does the default input source have on GNOME? Are we affected atm? I'm asking because my understanding is that this is determined in Ubuntu by the installer and language-selector (pkg_depends). This table used to detect which input source is used at a locale. https://developer.gnome.org/gnome-desktop3/stable/gnome-desktop3-Language-Utilities.html#gnome-get-input-source-from-locale Mainly used is at "Input Source Chooser" on System Settings / Region & Language / Input Sources menu. The chooser get default input source type (xkb or ibus) and engine (jp or anthy) for specified locale. However Input Source Chooser will retrieve "valid", normally equal to "installed", engine from ibus instance, and filter out not installed engine. That is, if ibus-kkc and/or ibus-anthy are not installed, Input Source Chooser doesn't show up these choices (I guess). In System Settings context, if gnome_get_input_source_from_locale() will return "ibus-mozc", there is a possibility to drop ubuntu_ibus_configs.patch from gnome-settings-daemon package. Thanks Mitsuya! What's your opinion on mozc vs. kkc? Would it be fine to switch to ibus-kkc as default for Japanese in Ubuntu 18.04, or are there reasons to 'fight' for ibus-mozc? Please see the discussion at <https://bugzilla.gnome.org/787664>. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Bug 1735362] Re: ibus-sunpinyin: port to Python3 needed
On 2017-12-06 15:21, Sebastien Bacher wrote: @Gunnar, do you know if changing the pinyin engine is a topic that already got discussed? Replied on bug report. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: mozc support in the default ISO
On 2017-10-21 02:44, Jeremy Bicha wrote: gnome-desktop 3.27.1 was released today and changed GNOME's default Japanese input method from ibus-anthy to ibus-kkc. https://git.gnome.org/browse/gnome-desktop/commit/?id=9c1aea9d The GNOME bug is interesting since it originally requested switching to ibus-mozc (Ubuntu's current default) but eventually they preferred to use kkc because it has GTK+ tools: https://bugzilla.gnome.org/787664 I guess we need to patch gnome-desktop if Ubuntu decides to use different default input methods for certain languages. https://git.gnome.org/browse/gnome-desktop/tree/libgnome-desktop/default-input-sources.h What significance does the default input source have on GNOME? Are we affected atm? I'm asking because my understanding is that this is determined in Ubuntu by the installer and language-selector (pkg_depends). May be worth mentioning the history, btw: 14.04 - ibus-anthy 16.04 - fcitx-mozc 17.10 - ibus-mozc -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Remove Python2 for 18.04?
Hi Kev, In 17.10 Ubuntu switched from Fcitx to IBus as default IM framework for CJKV languages because of limitations in the GNOME environment (Wayland, gnome-shell, gnome-control-center...). Please note that this change does not affect the flavors at this time. Fcitx is still the default IM framework for CJKV languages in Xubuntu, Lubuntu, MATE etc. (and, of course, in Kylin), since Fcitx is still (AFAIK) considered preferable by affected users in the Ubuntu community. Rgds, / Gunnar On 2017-10-28 03:17, flocculant wrote: Not sure if any of this gnome language stuff is going to cause us issue like it has in the past. re trusty LTS bug(s) Never really sure about any gnome statements that it ' only affects us' things anymore, consequently forwarding to us. starting to think the same about mainbuntu - don't believe anything deliberate, but fairly sure they'd not check either. Kev On 27/10/17 22:49, Gunnar Hjalmarsson wrote: On 2017-10-27 21:22, Bryan Quigley wrote: * ibus-sunpinyin Was added 9/2017 [2] as part of moving from fcitx. Right. Choosing ibus-sunpinyin was not preceded by any deeper considerations. It was the preferred input method last time Ubuntu's default IM framework for Simplified Chinese was IBus, and has been pulled by language-selector (pkg_depends) after that for Ubuntu GNOME. This package hasn't been updated since 2013. Previously we've added it to the desktop session and then removed for ibus-pinyin for size (and in this case it seems better maintained). GNOME seems to default to ibus-libpinyin: https://git.gnome.org/browse/gnome-desktop/tree/libgnome-desktop/default-input-sources.h That would speak for replacing ibus-sunpinyin with ibus-libpinyin on both the live CD and language-selector. But we should probably try to get opinions from some Chinese users before making this change. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Remove Python2 for 18.04?
On 2017-10-27 21:22, Bryan Quigley wrote: * ibus-sunpinyin Was added 9/2017 [2] as part of moving from fcitx. Right. Choosing ibus-sunpinyin was not preceded by any deeper considerations. It was the preferred input method last time Ubuntu's default IM framework for Simplified Chinese was IBus, and has been pulled by language-selector (pkg_depends) after that for Ubuntu GNOME. This package hasn't been updated since 2013. Previously we've added it to the desktop session and then removed for ibus-pinyin for size (and in this case it seems better maintained). GNOME seems to default to ibus-libpinyin: https://git.gnome.org/browse/gnome-desktop/tree/libgnome-desktop/default-input-sources.h That would speak for replacing ibus-sunpinyin with ibus-libpinyin on both the live CD and language-selector. But we should probably try to get opinions from some Chinese users before making this change. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:fix-patch into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-control-center:fix-patch into
~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/353096
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-control-center:fix-patch into
~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master.
diff --git a/debian/patches/52_region_language.patch b/debian/patches/52_region_language.patch
index 5933fc8..b5d919c 100644
--- a/debian/patches/52_region_language.patch
+++ b/debian/patches/52_region_language.patch
@@ -126,7 +126,7 @@ index 9357c3e..4add980 100644
static char *
get_lang_for_user_object_path (const char *path)
{
-@@ -201,10 +261,13 @@ insert_language (GHashTable *ht,
+@@ -201,30 +261,64 @@
g_autofree gchar *label_own_lang = NULL;
g_autofree gchar *label_current_lang = NULL;
g_autofree gchar *label_untranslated = NULL;
@@ -143,10 +143,19 @@ index 9357c3e..4add980 100644
/* We don't have a translation for the label in
* its own language? */
-@@ -218,13 +281,44 @@ insert_language (GHashTable *ht,
- }
- }
-
+ if (g_strcmp0 (label_own_lang, label_untranslated) == 0) {
+ if (g_strcmp0 (label_current_lang, label_untranslated) == 0)
+-g_hash_table_insert (ht, g_strdup (lang), g_strdup (label_untranslated));
++g_hash_table_insert (ht, g_strdup (key), g_strdup (label_untranslated));
+ else
+-g_hash_table_insert (ht, g_strdup (lang), g_strdup (label_current_lang));
++g_hash_table_insert (ht, g_strdup (key), g_strdup (label_current_lang));
+ } else {
+-g_hash_table_insert (ht, g_strdup (lang), g_strdup (label_own_lang));
++g_hash_table_insert (ht, g_strdup (key), g_strdup (label_own_lang));
++}
++}
++
+gchar **
+cc_common_language_get_installed_languages (void)
+{
@@ -159,13 +168,13 @@ index 9357c3e..4add980 100644
+g_warning ("Couldn't get installed languages: %s", error->message);
+g_error_free (error);
+return NULL;
-+}
+ }
+langs = g_strsplit (output, "\n", 0);
+
+g_free(output);
+return langs;
-+}
-+
+ }
+
GHashTable *
cc_common_language_get_initial_languages (void)
{
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:use-dh_translations into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
Gunnar Hjalmarsson has proposed merging ~gunnarhj/ubuntu/+source/gnome-control-center:use-dh_translations into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. Requested reviews: Ubuntu Desktop (ubuntu-desktop) For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/353670 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-control-center:use-dh_translations into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. diff --git a/debian/changelog b/debian/changelog index e1fdc45..fe483da 100644 --- a/debian/changelog +++ b/debian/changelog @@ -4,6 +4,8 @@ gnome-control-center (1:3.29.90-1~ubuntu2) UNRELEASED; urgency=medium * Fix a typo in debian/patches/52_region_language.patch which broke displaying the selected language in the language panell of gnome-control-center (LP: #1786880) + * debian/rules: +Make use of updated dh_translations; drop workarounds. -- Iain Lane Tue, 14 Aug 2018 16:19:09 +0100 diff --git a/debian/rules b/debian/rules index 89d3561..b650b4a 100755 --- a/debian/rules +++ b/debian/rules @@ -17,17 +17,5 @@ override_dh_auto_configure: override_dh_missing: dh_missing --fail-missing -override_dh_install: - for f in debian/tmp/usr/share/applications/*.desktop; do \ - sed -i -r '/[A-Z].+\[.+\]=/d' "$$f"; \ - echo X-Ubuntu-Gettext-Domain=gnome-control-center-2.0 >> "$$f"; \ - done - dh_install - override_dh_translations: - ninja -C obj-$(DEB_HOST_GNU_TYPE) gnome-control-center-2.0-pot - dh_translations - -override_dh_clean: - rm -f po/gnome-control-center-2.0.pot - dh_clean + dh_translations --domain=gnome-control-center-2.0 -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
Gunnar Hjalmarsson has proposed merging ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. Requested reviews: Ubuntu Desktop (ubuntu-desktop) For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365827 This MP partially addresses LP: #1823778; please see comment #8 in the bug report for details. -- Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. diff --git a/debian/changelog b/debian/changelog index 8455d8a..2826763 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +gnome-control-center (1:3.32.1-1ubuntu4) UNRELEASED; urgency=medium + + * debian/patches/series: +- Disable ubuntu-region-langpack-install.patch (partially fixes + LP: #1823778). + + -- Gunnar Hjalmarsson Thu, 11 Apr 2019 00:01:00 +0200 + gnome-control-center (1:3.32.1-1ubuntu3) disco; urgency=medium * debian/patches/0001-region-Fix-input-source-options-not-being-applied.patch: diff --git a/debian/patches/series b/debian/patches/series index ae7867f..057633f 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -11,7 +11,7 @@ distro-logo.patch 71_ubuntu_dock_settings.patch 99_add_lock-on-suspend.patch ubuntu-region-packagekit.patch -ubuntu-region-langpack-install.patch +#ubuntu-region-langpack-install.patch ubuntu-language-support.patch ubuntu-printer-support.patch ubuntu-legacy-notifications.patch -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
The proposal to merge ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master has been updated. Commit message changed to: Fix issues with locales including a modifier (LP: #1823778) For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365920 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
The latest commit fixes the remaining issue related to modifiers. Now a language represented by a locale with a modifier both has a distinguishing label and can be set from Region & Language. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365920 Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/bionic
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix_bionic into
~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/bionic.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1823778 in gnome-control-center (Ubuntu): "Unable to set Serbian as
Language"
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1823778
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365984
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix_bionic into
~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/bionic.
diff --git a/debian/changelog b/debian/changelog
index c124bf3..34b8d1a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+gnome-control-center (1:3.28.2-0ubuntu0.18.04.4) bionic; urgency=medium
+
+ * debian/patches/ubuntu-region-langpack-install.patch:
+- Dropped, which makes Serbian language items show up as selectable
+ in Region & Language (LP: #1823778).
+ * debian/patches/52_region_language.patch:
+- Prevent that the modifier part is dropped when a language
+ represented by a locale with modifier is set (LP: #1823778).
+
+ -- Gunnar Hjalmarsson Sat, 13 Apr 2019 03:05:00 +0200
+
gnome-control-center (1:3.28.2-0ubuntu0.18.04.3) bionic; urgency=medium
* debian/patches/power-Label-the-PENDING_CHARGING-state-as-Not-Charging.patch:
diff --git a/debian/patches/52_region_language.patch b/debian/patches/52_region_language.patch
index b6cc0ba..ab78f7f 100644
--- a/debian/patches/52_region_language.patch
+++ b/debian/patches/52_region_language.patch
@@ -285,26 +285,7 @@ Index: b/panels/region/cc-region-panel.c
===
--- a/panels/region/cc-region-panel.c
+++ b/panels/region/cc-region-panel.c
-@@ -377,11 +377,15 @@
-gint response_id,
-CcRegionPanel *self)
- {
--const gchar *language;
-+const gchar *locale, *language, *country;
-+gchar *name = NULL;
-
- if (response_id == GTK_RESPONSE_OK) {
--language = cc_language_chooser_get_language (GTK_WIDGET (chooser));
--update_language (self, language);
-+locale = cc_language_chooser_get_language (GTK_WIDGET (chooser));
-+gnome_parse_locale (locale, , , NULL, NULL);
-+name = g_strdup_printf ("%s_%s", language, country);
-+update_language (self, name);
-+g_free (name);
- }
-
- gtk_widget_destroy (GTK_WIDGET (chooser));
-@@ -403,6 +407,47 @@
+@@ -403,6 +403,47 @@
}
static void
@@ -352,7 +333,7 @@ Index: b/panels/region/cc-region-panel.c
update_region (CcRegionPanel *self,
const gchar *region)
{
-@@ -413,6 +458,7 @@
+@@ -413,6 +454,7 @@
} else {
if (g_strcmp0 (region, priv->region) == 0)
return;
@@ -360,7 +341,7 @@ Index: b/panels/region/cc-region-panel.c
g_settings_set_string (priv->locale_settings, KEY_REGION, region);
if (priv->login_auto_apply)
set_system_region (self, region);
-@@ -593,7 +639,7 @@
+@@ -593,7 +635,7 @@
CcRegionPanelPrivate *priv = self->priv;
g_free (priv->region);
@@ -369,7 +350,7 @@ Index: b/panels/region/cc-region-panel.c
update_region_label (self);
}
-@@ -622,15 +668,19 @@
+@@ -622,15 +664,19 @@
{
CcRegionPanelPrivate *priv = self->priv;
const gchar *language = NULL;
@@ -393,7 +374,7 @@ Index: b/panels/region/cc-region-panel.c
update_language_label (self);
}
-@@ -1485,6 +1535,16 @@
+@@ -1485,6 +1531,16 @@
update_buttons (self);
}
@@ -410,7 +391,7 @@ Index: b/panels/region/cc-region-panel.c
static void
on_localed_properties_changed (GDBusProxy *proxy,
GVariant *changed_properties,
-@@ -1499,32 +1559,46 @@
+@@ -1499,32 +1555,46 @@
const gchar **strv;
gsize len;
gint i;
@@ -466,7 +447,7 @@ Index: b/panels/region/cc-region-panel.c
update_language_label (self);
}
-@@ -1594,27 +1668,24 @@
+@@ -1594,27 +1664,24 @@
CcRegionPanelPrivate *priv = self->priv;
GVariantBuilder *b;
gchar *s;
diff --git a/debian/patches/series b/debian/patches/series
index 6357c3a..6d1a542 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -12,7 +12,6 @@
99_add_lock-on-suspend.patch
ubuntu-gnome-version.patch
ubuntu-region-packagekit.patch
-ubuntu-region-langpack-install.patch
ubuntu-language-support.patch
ubuntu-printer-support.patch
ubuntu-legacy-notifications.patch
diff
[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
The proposal to merge ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master has been updated. Description changed to: This proposal fixes the language labels for languages represented by locales with a modifier. So it looks better if you have languages like Serbian or Catalan installed. However, if you try to select a language with a modifier from Region & Language, the language without the modifier is still set. So some further fix is needed before this gets correct. Edit: See comment below. For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365920 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/mutter:translation-fix into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master
Gunnar Hjalmarsson has proposed merging ~gunnarhj/ubuntu/+source/mutter:translation-fix into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master. Requested reviews: Ubuntu Desktop (ubuntu-desktop) Related bugs: Bug #1823722 in mutter (Ubuntu): "keyboard shortcuts are displayed not translated" https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/1823722 For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/mutter/+git/mutter/+merge/365971 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/mutter:translation-fix into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master. diff --git a/debian/changelog b/debian/changelog index 7471ed8..44e1d8c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,12 @@ +mutter (3.32.0+git20190410-1ubuntu2) UNRELEASED; urgency=medium + + * debian/control: +- Add gnome-control-center-data to Build-Depends in order to have + gnome-keybindings.[its,loc] available when parsing po/POTFILES.in + (LP: #1823722). + + -- Gunnar Hjalmarsson Fri, 12 Apr 2019 19:57:00 +0200 + mutter (3.32.0+git20190410-1ubuntu1) disco; urgency=medium * Merge with debian git snapshot (LP: #1820542), remaining changes: diff --git a/debian/control b/debian/control index ebbb4d0..1b21f55 100644 --- a/debian/control +++ b/debian/control @@ -14,6 +14,7 @@ Build-Depends: debhelper-compat (= 12), at-spi2-core , dbus , dmz-cursor-theme , + gnome-control-center-data, gnome-pkg-tools (>= 0.10), gnome-settings-daemon-common , gnome-settings-daemon-dev, diff --git a/debian/control.in b/debian/control.in index b8cb5fa..cc216e6 100644 --- a/debian/control.in +++ b/debian/control.in @@ -10,6 +10,7 @@ Build-Depends: debhelper-compat (= 12), at-spi2-core , dbus , dmz-cursor-theme , + gnome-control-center-data, gnome-pkg-tools (>= 0.10), gnome-settings-daemon-common , gnome-settings-daemon-dev, -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into
~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1823778 in gnome-control-center (Ubuntu): "Unable to set Serbian as
Language"
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1823778
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365920
This proposal fixes the language labels for languages represented by locales
with a modifier. So it looks better if you have languages like Serbian or
Catalan installed.
However, if you try to select a language with a modifier from Region &
Language, the language without the modifier is still set. So some further fix
is needed before this gets correct.
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into
~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master.
diff --git a/debian/patches/52_region_language.patch b/debian/patches/52_region_language.patch
index 5ee0883..dcf1e20 100644
--- a/debian/patches/52_region_language.patch
+++ b/debian/patches/52_region_language.patch
@@ -299,7 +299,32 @@ Index: gnome-control-center-3.32.1/panels/common/cc-language-chooser.c
===
--- gnome-control-center-3.32.1.orig/panels/common/cc-language-chooser.c
+++ gnome-control-center-3.32.1/panels/common/cc-language-chooser.c
-@@ -166,7 +166,7 @@ add_languages (CcLanguageChooser *choose
+@@ -62,16 +62,21 @@ language_widget_new (const gchar *locale_id,
+ g_autofree gchar *country = NULL;
+ g_autofree gchar *language_local = NULL;
+ g_autofree gchar *country_local = NULL;
++g_autofree gchar *language_tmp = NULL;
++g_autofree gchar *language_loc_tmp = NULL;
++g_autofree gchar *modifier = NULL;
+ GtkWidget *row;
+ GtkWidget *box;
+ GtkWidget *language_label;
+ GtkWidget *check;
+ GtkWidget *country_label;
+
+-gnome_parse_locale (locale_id, _code, _code, NULL, NULL);
+-language = gnome_get_language_from_code (language_code, locale_id);
++gnome_parse_locale (locale_id, _code, _code, NULL, );
++language_tmp = gnome_get_language_from_code (language_code, locale_id);
++language = g_strdup_printf ("%s%s%s", language_tmp, modifier ? " - " : "", modifier ? modifier : "");
+ country = gnome_get_country_from_code (country_code, locale_id);
+-language_local = gnome_get_language_from_code (language_code, NULL);
++language_loc_tmp = gnome_get_language_from_code (language_code, NULL);
++language_local = g_strdup_printf ("%s%s%s", language_loc_tmp, modifier ? " - " : "", modifier ? modifier : "");
+ country_local = gnome_get_country_from_code (country_code, NULL);
+
+ row = gtk_list_box_row_new ();
+@@ -166,7 +171,7 @@ add_languages (CcLanguageChooser *choose
gtk_container_add (GTK_CONTAINER (chooser->language_listbox), widget);
}
@@ -308,7 +333,7 @@ Index: gnome-control-center-3.32.1/panels/common/cc-language-chooser.c
}
static void
-@@ -392,7 +392,7 @@ cc_language_chooser_init (CcLanguageChoo
+@@ -392,7 +397,7 @@ cc_language_chooser_init (CcLanguageChoo
gtk_widget_init_template (GTK_WIDGET (chooser));
chooser->more_item = more_widget_new ();
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu): "Default IBus input method
ignored in live session"
https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1786344
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409
This MP is based on the assumption (untested) that the bug happens because
there already is at least one input source in dconf when g-s-d is run. If the
assumption is wrong, this MP is basically a no-op.
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
diff --git a/debian/changelog b/debian/changelog
index 6a493d0..697ea23 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+gnome-settings-daemon (3.32.0-1ubuntu2) UNRELEASED; urgency=medium
+
+ * debian/patches/ubuntu_ibus_configs.patch:
+- Run add_ibus_sources_from_locale() even if dconf already contains
+ one or more sources. This will hopefully make an IBus method be
+ included when applicable also in "live sessions" (LP: #1786344).
+
+ -- Gunnar Hjalmarsson Wed, 05 Jun 2019 21:41:00 +0200
+
gnome-settings-daemon (3.32.0-1ubuntu1) disco; urgency=medium
* Merge with Debian. Remaining changes:
diff --git a/debian/patches/ubuntu_ibus_configs.patch b/debian/patches/ubuntu_ibus_configs.patch
index f69330f..afdf270 100644
--- a/debian/patches/ubuntu_ibus_configs.patch
+++ b/debian/patches/ubuntu_ibus_configs.patch
@@ -6,14 +6,14 @@ the locale, upstream removed it because they use an intial setup but we don't
Bug: https://bugs.launchpad.net/bugs/1719938
Forwarded: not-needed
---
- plugins/keyboard/gsd-keyboard-manager.c | 56 -
- 1 file changed, 55 insertions(+), 1 deletion(-)
+ plugins/keyboard/gsd-keyboard-manager.c | 70
+ 1 file changed, 70 insertions(+)
diff --git a/plugins/keyboard/gsd-keyboard-manager.c b/plugins/keyboard/gsd-keyboard-manager.c
-index fadde34..3b35c69 100644
+index fadde34..930d788 100644
--- a/plugins/keyboard/gsd-keyboard-manager.c
+++ b/plugins/keyboard/gsd-keyboard-manager.c
-@@ -168,6 +168,58 @@ check_xkb_extension (GsdKeyboardManager *manager)
+@@ -168,6 +168,73 @@ check_xkb_extension (GsdKeyboardManager *manager)
return have_xkb;
}
@@ -69,18 +69,31 @@ index fadde34..3b35c69 100644
+g_settings_set_value (settings, KEY_INPUT_SOURCES, g_variant_builder_end ());
+}
+
++static gboolean
++is_initial_done (void) {
++g_autofree gchar *initial_file = NULL;
++g_autofree gchar *contents = NULL;
++
++initial_file = g_build_filename (g_get_user_config_dir (), "gnome-initial-setup-done", NULL);
++
++if (g_file_test (initial_file, G_FILE_TEST_EXISTS) &&
++g_file_get_contents (initial_file, , NULL, NULL))
++if (g_strcmp0 (g_strchomp (contents), "yes") == 0)
++return TRUE;
++
++return FALSE;
++}
++
static void
xkb_init (GsdKeyboardManager *manager)
{
-@@ -762,8 +814,10 @@ maybe_create_initial_settings (GsdKeyboardManager *manager)
-
- /* if we still don't have anything do some educated guesses */
- sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
--if (g_variant_n_children (sources) < 1)
-+if (g_variant_n_children (sources) < 1) {
+@@ -766,6 +833,9 @@ maybe_create_initial_settings (GsdKeyboardManager *manager)
get_sources_from_xkb_config (manager);
-+add_ibus_sources_from_locale (settings);
-+}
g_variant_unref (sources);
++if (! is_initial_done ())
++add_ibus_sources_from_locale (settings);
++
options = g_settings_get_strv (settings, KEY_KEYBOARD_OPTIONS);
+ if (g_strv_length (options) < 1)
+ get_options_from_xkb_config (manager);
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:zoom-options into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/disco
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-control-center:zoom-options into
~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/disco.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1831144 in gnome-control-center (Ubuntu): "GNOME control center UI does
not update dconf setting for magnifier mouse tracking m ode"
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1831144
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/368417
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-control-center:zoom-options into
~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/disco.
diff --git a/debian/changelog b/debian/changelog
index d573c5a..f468694 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+gnome-control-center (1:3.32.2-0ubuntu2) disco; urgency=medium
+
+ * d/p/fix-broken-zoom-options.patch:
+- Update dconf settings properly from the zoom options GUI
+ (LP: #1831144).
+
+ -- Gunnar Hjalmarsson Wed, 05 Jun 2019 23:13:00 +0200
+
gnome-control-center (1:3.32.2-0ubuntu1) disco; urgency=medium
* New upstream stable version, based on the Debian update (lp: #1830884)
diff --git a/debian/patches/fix-broken-zoom-options.patch b/debian/patches/fix-broken-zoom-options.patch
new file mode 100644
index 000..eaa3e6c
--- /dev/null
+++ b/debian/patches/fix-broken-zoom-options.patch
@@ -0,0 +1,191 @@
+Description: Fix zoom settings not applying (and leaks)
+Origin: https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/487.diff
+Bug-Ubuntu: https://launchpad.net/bugs/1831144
+Bug-GNOME: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/555
+Applied-Upstream: yes - commits: 9bc429ce, ffaeb56b, 3351e91e
+
+diff --git a/panels/universal-access/zoom-options.c b/panels/universal-access/zoom-options.c
+index 7266aaab6bddce030dc29b00fcf1974006b14224..dcfaa44e4c9a8c342869c2359f6b93994c821e0b 100644
+--- a/panels/universal-access/zoom-options.c
b/panels/universal-access/zoom-options.c
+@@ -70,7 +70,6 @@ static gchar *contrast_keys[] = {
+ };
+
+ static void set_enable_screen_part_ui (GtkWidget *widget, ZoomOptions *self);
+-static void mouse_tracking_notify_cb (GSettings *settings, const gchar *key, ZoomOptions *self);
+ static void scale_label (GtkBin *toggle, PangoAttrList *attrs);
+ static void xhairs_color_opacity_changed (GtkColorButton *button, ZoomOptions *self);
+ static void xhairs_length_add_marks (ZoomOptions *self, GtkScale *scale);
+@@ -80,41 +79,37 @@ static void contrast_slider_notify_cb (GSettings *settings, const gchar *key, Zo
+ static void effects_slider_changed (GtkRange *slider, ZoomOptions *self);
+
+ static void
+-mouse_tracking_radio_toggled_cb (GtkWidget *widget, ZoomOptions *self)
++mouse_tracking_radio_toggled_cb (ZoomOptions *self, GtkWidget *widget)
+ {
+- if (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (widget)) == TRUE)
+- {
+-g_settings_set_string (self->settings, "mouse-tracking",
+- gtk_buildable_get_name (GTK_BUILDABLE (widget)));
+- }
++ if (!gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (widget)))
++return;
++
++ if (widget == self->centered_radio)
++ g_settings_set_string (self->settings, "mouse-tracking", "centered");
++ else if (widget == self->proportional_radio)
++ g_settings_set_string (self->settings, "mouse-tracking", "proportional");
++ else if (widget == self->push_radio)
++ g_settings_set_string (self->settings, "mouse-tracking", "push");
+ }
+
+ static void
+-init_mouse_mode_radio_group (GSList *mode_group, ZoomOptions *self)
++mouse_tracking_notify_cb (ZoomOptions *self)
+ {
+-gchar *mode;
+-gchar *name;
+-
+-mode = g_settings_get_string (self->settings, "mouse-tracking");
+- for (; mode_group != NULL; mode_group = mode_group->next)
+- {
+- name = (gchar *) gtk_buildable_get_name (GTK_BUILDABLE (mode_group->data));
+- if (g_strcmp0 (name, mode) == 0)
+- gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (mode_group->data), TRUE);
+- else
+- gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (mode_group->data), FALSE);
+-
+- g_signal_connect (G_OBJECT (mode_group->data), "toggled",
+- G_CALLBACK(mouse_tracking_radio_toggled_cb),
+- self);
+- }
++g_autofree gchar *tracking = NULL;
++
++tracking = g_settings_get_string (self->settings, "mouse-tracking");
++if (g_strcmp0 (tracking, "centered") == 0)
++ gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (self->centered_radio), TRUE);
++else if (g_strcmp0 (tracking, "proportional") == 0)
++
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Hi Laney,
I have tested (by faking Japanese first logins) the idea to call
add_ibus_sources_from_locale() from maybe_convert_old_settings(). This is where
I put it:
if (g_variant_n_children (sources) < 1) {
convert_libgnomekbd_layouts (settings);
add_ibus_sources_from_locale (settings);
}
convert_libgnomekbd_layouts() seems to not have changed anything, but Mozc was
added. However, it resulted in a session with only Mozc available in sources.
The reason is that the get_sources_from_xkb_config() call in
maybe_create_initial_settings() did not happen since sources wasn't empty at
that spot in the flow.
I don't know if it would be acceptable to not have a XKB layout available, but
I have my doubts. In any case I feel that such a change would be too intrusive
considering that I want to SRU to bionic whatever solution we choose.
Furthermore, to address the bug happening when you "Try Ubuntu" from the
Ubiquity welcome screen, I suspect that the call would need to be moved beyond
the condition, like this:
if (g_variant_n_children (sources) < 1) {
convert_libgnomekbd_layouts (settings);
}
add_ibus_sources_from_locale (settings);
But that would also result in real installs with only an IBus input method in
sources.
My conclusion is that any call of add_ibus_sources_from_locale() from
maybe_convert_old_settings() would be premature.
So I'm back to my proposal in this MP. It lets g-s-d do its things with respect
to XKB layouts first, and then it adds an IBus method if applicable. Even if
there are a few lines, the regression risk ought to be minimal.
--
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
An attempt to summarize: 1. get_sources_from_xkb_config() needs to be called if no XKB layouts were added previously. 2. add_ibus_sources_from_locale() needs to be run once regardless. To meet both those conditions, you cannot call add_ibus_sources_from_locale() from maybe_convert_old_settings(). -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409 Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
Requested reviews:
Iain Lane (laney)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu): "Default IBus input method
ignored in live session"
https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1786344
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368657
An attempt with calling add_ibus_sources_from_locale() unconditionally during
the first run of the maybe_convert_old_settings() function.
While this results in a slightly more complex patch, I suppose it's better
conceptually, since we don't introduce a dependency of a stamp file belonging
to some other package.
There is also an extra bonus (at least I think it is a bonus): When doing e.g.
a Chinese or Japanese install, and unlike before, the IBus IM is active
instantly at first login. That is, instead of:
[('xkb', 'cn'), ('ibus', 'libpinyin')]
in sources, libpinyin is now the first source:
[('ibus', 'libpinyin'), ('xkb', 'cn')]
--
Your team Ubuntu Desktop is subscribed to branch
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
diff --git a/debian/changelog b/debian/changelog
index 6a493d0..7da503e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+gnome-settings-daemon (3.32.0-1ubuntu2) eoan; urgency=medium
+
+ * debian/patches/ubuntu_ibus_configs.patch:
+- Call add_ibus_sources_from_locale() unconditionally during the
+ first run of the maybe_convert_old_settings() function. This will
+ hopefully make an IBus method be included when applicable also in
+ "live sessions" (LP: #1786344).
+
+ -- Gunnar Hjalmarsson Tue, 11 Jun 2019 15:55:00 +0200
+
gnome-settings-daemon (3.32.0-1ubuntu1) disco; urgency=medium
* Merge with Debian. Remaining changes:
diff --git a/debian/patches/ubuntu_ibus_configs.patch b/debian/patches/ubuntu_ibus_configs.patch
index f69330f..3d6a19d 100644
--- a/debian/patches/ubuntu_ibus_configs.patch
+++ b/debian/patches/ubuntu_ibus_configs.patch
@@ -6,11 +6,11 @@ the locale, upstream removed it because they use an intial setup but we don't
Bug: https://bugs.launchpad.net/bugs/1719938
Forwarded: not-needed
---
- plugins/keyboard/gsd-keyboard-manager.c | 56 -
- 1 file changed, 55 insertions(+), 1 deletion(-)
+ plugins/keyboard/gsd-keyboard-manager.c | 78 +---
+ 1 file changed, 69 insertions(+), 9 deletions(-)
diff --git a/plugins/keyboard/gsd-keyboard-manager.c b/plugins/keyboard/gsd-keyboard-manager.c
-index fadde34..3b35c69 100644
+index fadde34..eb76921 100644
--- a/plugins/keyboard/gsd-keyboard-manager.c
+++ b/plugins/keyboard/gsd-keyboard-manager.c
@@ -168,6 +168,58 @@ check_xkb_extension (GsdKeyboardManager *manager)
@@ -72,15 +72,76 @@ index fadde34..3b35c69 100644
static void
xkb_init (GsdKeyboardManager *manager)
{
-@@ -762,8 +814,10 @@ maybe_create_initial_settings (GsdKeyboardManager *manager)
+@@ -707,7 +759,7 @@ convert_libgnomekbd_layouts (GSettings *settings)
+ g_object_unref (libgnomekbd_settings);
+ }
+
+-static void
++static gint
+ maybe_convert_old_settings (GSettings *settings)
+ {
+ GVariant *sources;
+@@ -715,6 +767,11 @@ maybe_convert_old_settings (GSettings *settings)
+ gchar *stamp_dir_path = NULL;
+ gchar *stamp_file_path = NULL;
+ GError *error = NULL;
++gint count_sources;
++
++sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
++count_sources = g_variant_n_children (sources);
++g_variant_unref (sources);
+
+ stamp_dir_path = g_build_filename (g_get_user_data_dir (), PACKAGE_NAME, NULL);
+ if (g_mkdir_with_parents (stamp_dir_path, 0755)) {
+@@ -726,12 +783,15 @@ maybe_convert_old_settings (GSettings *settings)
+ if (g_file_test (stamp_file_path, G_FILE_TEST_EXISTS))
+ goto out;
+
+-sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
+-if (g_variant_n_children (sources) < 1) {
++if (count_sources < 1)
+ convert_libgnomekbd_layouts (settings);
+-}
++
++sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
++count_sources = g_variant_n_children (sources);
+ g_variant_unref (sources);
+
++add_ibus_sources_from_locale (settings);
++
+ options = g_settings_get_strv (settings, KEY_KEYBOARD_OPTIONS);
+ if (g_strv_length (options) < 1)
+ convert_libgnomekbd_options (settings);
+@@ -744,13 +804,15 @@ maybe_convert_old_settings (GSettings *settings)
+ out:
+ g_free (stamp_file_path);
+ g_free (stamp_dir_path);
++
++return count_sources;
+ }
+
+ static void
+ maybe_create_initial
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
The proposal to merge ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368657 -- Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session3 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
I put a build of the branch in a PPA: https://launchpad.net/~gunnarhj/+archive/ubuntu/gnome-settings-daemon Also, the test case in the bug description suggests a convenient way to confirm the effect. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368678 Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session3 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Well, I couldn't let this go, and submitted yet another MP: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368678 Letting maybe_convert_old_settings() return a boolean, which tells us whether it's the first run, seems to be a more straightforward way, and results in a simpler patch. So I put this one on hold too. Please review the latest MP instead at first hand. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368657 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
The proposal to merge ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:zoom-options into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/disco
Proposed change built in this PPA: https://launchpad.net/~gunnarhj/+archive/ubuntu/gnome-control-center -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/368417 Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-control-center:zoom-options into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/disco. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
The proposal to merge ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session3 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session3 into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu): "Default IBus input method
ignored in live session"
https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1786344
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368678
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session3 into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
diff --git a/debian/changelog b/debian/changelog
index 6a493d0..51971cb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+gnome-settings-daemon (3.32.0-1ubuntu2) UNRELEASED; urgency=medium
+
+ * debian/patches/ubuntu_ibus_configs.patch:
+- Always call add_ibus_sources_from_locale() during the first run
+ of g-s-d. This ensures that an IBus method is included in "live
+ sessions" when applicable (LP: #1786344).
+
+ -- Gunnar Hjalmarsson Tue, 11 Jun 2019 22:00:00 +0200
+
gnome-settings-daemon (3.32.0-1ubuntu1) disco; urgency=medium
* Merge with Debian. Remaining changes:
diff --git a/debian/patches/ubuntu_ibus_configs.patch b/debian/patches/ubuntu_ibus_configs.patch
index f69330f..74b5c89 100644
--- a/debian/patches/ubuntu_ibus_configs.patch
+++ b/debian/patches/ubuntu_ibus_configs.patch
@@ -6,11 +6,11 @@ the locale, upstream removed it because they use an intial setup but we don't
Bug: https://bugs.launchpad.net/bugs/1719938
Forwarded: not-needed
---
- plugins/keyboard/gsd-keyboard-manager.c | 56 -
- 1 file changed, 55 insertions(+), 1 deletion(-)
+ plugins/keyboard/gsd-keyboard-manager.c | 64 +++-
+ 1 file changed, 62 insertions(+), 2 deletions(-)
diff --git a/plugins/keyboard/gsd-keyboard-manager.c b/plugins/keyboard/gsd-keyboard-manager.c
-index fadde34..3b35c69 100644
+index fadde34..6a2b2ba 100644
--- a/plugins/keyboard/gsd-keyboard-manager.c
+++ b/plugins/keyboard/gsd-keyboard-manager.c
@@ -168,6 +168,58 @@ check_xkb_extension (GsdKeyboardManager *manager)
@@ -72,15 +72,57 @@ index fadde34..3b35c69 100644
static void
xkb_init (GsdKeyboardManager *manager)
{
-@@ -762,8 +814,10 @@ maybe_create_initial_settings (GsdKeyboardManager *manager)
+@@ -707,7 +759,7 @@ convert_libgnomekbd_layouts (GSettings *settings)
+ g_object_unref (libgnomekbd_settings);
+ }
+
+-static void
++static gboolean
+ maybe_convert_old_settings (GSettings *settings)
+ {
+ GVariant *sources;
+@@ -715,6 +767,7 @@ maybe_convert_old_settings (GSettings *settings)
+ gchar *stamp_dir_path = NULL;
+ gchar *stamp_file_path = NULL;
+ GError *error = NULL;
++gboolean is_first_run = FALSE;
+
+ stamp_dir_path = g_build_filename (g_get_user_data_dir (), PACKAGE_NAME, NULL);
+ if (g_mkdir_with_parents (stamp_dir_path, 0755)) {
+@@ -726,6 +779,8 @@ maybe_convert_old_settings (GSettings *settings)
+ if (g_file_test (stamp_file_path, G_FILE_TEST_EXISTS))
+ goto out;
+
++is_first_run = TRUE;
++
+ sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
+ if (g_variant_n_children (sources) < 1) {
+ convert_libgnomekbd_layouts (settings);
+@@ -744,6 +799,8 @@ maybe_convert_old_settings (GSettings *settings)
+ out:
+ g_free (stamp_file_path);
+ g_free (stamp_dir_path);
++
++return is_first_run;
+ }
+
+ static void
+@@ -758,7 +815,7 @@ maybe_create_initial_settings (GsdKeyboardManager *manager)
+ if (g_getenv ("RUNNING_UNDER_GDM"))
+ return;
+
+-maybe_convert_old_settings (settings);
++gboolean is_first_run = maybe_convert_old_settings (settings);
/* if we still don't have anything do some educated guesses */
sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
--if (g_variant_n_children (sources) < 1)
-+if (g_variant_n_children (sources) < 1) {
+@@ -766,6 +823,9 @@ maybe_create_initial_settings (GsdKeyboardManager *manager)
get_sources_from_xkb_config (manager);
-+add_ibus_sources_from_locale (settings);
-+}
g_variant_unref (sources);
++if (is_first_run)
++add_ibus_sources_from_locale (settings);
++
options = g_settings_get_strv (settings, KEY_KEYBOARD_OPTIONS);
+ if (g_strv_length (options) < 1)
+ get_options_from_xkb_config (manager);
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Ok, you are of course right. I picked the second of those ideas and made an attempt in a new MP. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409 Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Yeah, I agree; basically that's what I mentioned at the end of my previous comment. But moving it out from the if() wouldn't make a difference wrt the problem with installs without any XKB layout. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409 Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Talked with Laney on #ubuntu-desktop. Will try a different approach and get back. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409 Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu): "Default IBus input method
ignored in live session"
https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1786344
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409
This MP is based on the assumption (untested) that the bug happens because
there already is at least one input source in dconf when g-s-d is run. If the
assumption is wrong, this MP is basically a no-op.
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
diff --git a/debian/changelog b/debian/changelog
index 6a493d0..697ea23 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+gnome-settings-daemon (3.32.0-1ubuntu2) UNRELEASED; urgency=medium
+
+ * debian/patches/ubuntu_ibus_configs.patch:
+- Run add_ibus_sources_from_locale() even if dconf already contains
+ one or more sources. This will hopefully make an IBus method be
+ included when applicable also in "live sessions" (LP: #1786344).
+
+ -- Gunnar Hjalmarsson Wed, 05 Jun 2019 21:41:00 +0200
+
gnome-settings-daemon (3.32.0-1ubuntu1) disco; urgency=medium
* Merge with Debian. Remaining changes:
diff --git a/debian/patches/ubuntu_ibus_configs.patch b/debian/patches/ubuntu_ibus_configs.patch
index f69330f..afdf270 100644
--- a/debian/patches/ubuntu_ibus_configs.patch
+++ b/debian/patches/ubuntu_ibus_configs.patch
@@ -6,14 +6,14 @@ the locale, upstream removed it because they use an intial setup but we don't
Bug: https://bugs.launchpad.net/bugs/1719938
Forwarded: not-needed
---
- plugins/keyboard/gsd-keyboard-manager.c | 56 -
- 1 file changed, 55 insertions(+), 1 deletion(-)
+ plugins/keyboard/gsd-keyboard-manager.c | 70
+ 1 file changed, 70 insertions(+)
diff --git a/plugins/keyboard/gsd-keyboard-manager.c b/plugins/keyboard/gsd-keyboard-manager.c
-index fadde34..3b35c69 100644
+index fadde34..930d788 100644
--- a/plugins/keyboard/gsd-keyboard-manager.c
+++ b/plugins/keyboard/gsd-keyboard-manager.c
-@@ -168,6 +168,58 @@ check_xkb_extension (GsdKeyboardManager *manager)
+@@ -168,6 +168,73 @@ check_xkb_extension (GsdKeyboardManager *manager)
return have_xkb;
}
@@ -69,18 +69,31 @@ index fadde34..3b35c69 100644
+g_settings_set_value (settings, KEY_INPUT_SOURCES, g_variant_builder_end ());
+}
+
++static gboolean
++is_initial_done (void) {
++g_autofree gchar *initial_file = NULL;
++g_autofree gchar *contents = NULL;
++
++initial_file = g_build_filename (g_get_user_config_dir (), "gnome-initial-setup-done", NULL);
++
++if (g_file_test (initial_file, G_FILE_TEST_EXISTS) &&
++g_file_get_contents (initial_file, , NULL, NULL))
++if (g_strcmp0 (g_strchomp (contents), "yes") == 0)
++return TRUE;
++
++return FALSE;
++}
++
static void
xkb_init (GsdKeyboardManager *manager)
{
-@@ -762,8 +814,10 @@ maybe_create_initial_settings (GsdKeyboardManager *manager)
-
- /* if we still don't have anything do some educated guesses */
- sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
--if (g_variant_n_children (sources) < 1)
-+if (g_variant_n_children (sources) < 1) {
+@@ -766,6 +833,9 @@ maybe_create_initial_settings (GsdKeyboardManager *manager)
get_sources_from_xkb_config (manager);
-+add_ibus_sources_from_locale (settings);
-+}
g_variant_unref (sources);
++if (! is_initial_done ())
++add_ibus_sources_from_locale (settings);
++
options = g_settings_get_strv (settings, KEY_KEYBOARD_OPTIONS);
+ if (g_strv_length (options) < 1)
+ get_options_from_xkb_config (manager);
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Application for ubuntu-desktop membership
I apply to the ubuntu-desktop team members for becoming a member of the team. I have been around since 2010, and my contributions have mostly been related somehow to the internationalization of the desktop, such as the tools for setting language and locales, fonts, keyboard layouts/input methods, spellcheck dictionaries, and the translation infrastructure. I'm also keeping up the Ubuntu flavor of the desktop guide (Help). My work has led me to get involved in quite a few packages, and more often than not I'm targeting packages in the ubuntu-desktop packageset. Via PPU:s and a personal packageset I have upload rights to a few of them: https://people.canonical.com/~ubuntu-archive/packagesets/eoan/personal-gunnarhj but often I need to ask for sponsorship. As a member of ubuntu-desktop I would be able to contribute more efficiently and save some time for the developers. But please note that, if you would grant me membership, you wouldn't get rid of my prompts for reviews completely. ;) I'm self-educated in computing, and my knowledge about programming, packaging, etc. is fragmentary. The good news is that I'm aware of my limitations, and have gained a feeling for when I should consult with someone and/or ask for review, and when I'm sure enough to just do it. Thanks in advance for considering my application! -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic.
Commit message:
Enable IBus IM in live session (LP: #1786344)
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu): "Default IBus input method
ignored in live session"
https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1786344
For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/369154
I have tested the daily build ISO from this morning UTC. The issue was resolved
as expected.
So this MP is the bionic equivalent to this upload:
https://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.32.1-1ubuntu2
The branch successfully built in PPA:
https://launchpad.net/~gunnarhj/+archive/ubuntu/gnome-settings-daemon
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic.
diff --git a/debian/changelog b/debian/changelog
index 04e625e..c321c66 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+gnome-settings-daemon (3.28.1-0ubuntu1.3) bionic; urgency=medium
+
+ * debian/patches/ubuntu_ibus_configs.patch:
+- Always call add_ibus_sources_from_locale() during the first run
+ of g-s-d. This ensures that an IBus method is included in "live
+ sessions" when applicable (LP: #1786344).
+ * debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch:
+ - Refreshed
+
+ -- Gunnar Hjalmarsson Fri, 21 Jun 2019 11:58:00 +0200
+
gnome-settings-daemon (3.28.1-0ubuntu1.2) bionic; urgency=medium
* debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch:
diff --git a/debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch b/debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch
index 6a76d1b..a0c2efd 100644
--- a/debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch
+++ b/debian/patches/keyboard-Enable-ibus-for-OSK-purposes.patch
@@ -166,7 +166,7 @@ index 343b049..480e735 100644
}
static void
-@@ -812,8 +859,15 @@ start_keyboard_idle_cb (GsdKeyboardManager *manager)
+@@ -818,8 +865,15 @@ start_keyboard_idle_cb (GsdKeyboardManager *manager)
set_devicepresence_handler (manager);
manager->priv->input_sources_settings = g_settings_new (GNOME_DESKTOP_INPUT_SOURCES_DIR);
@@ -184,7 +184,7 @@ index 343b049..480e735 100644
manager->priv->cancellable = g_cancellable_new ();
-@@ -876,10 +930,12 @@ gsd_keyboard_manager_stop (GsdKeyboardManager *manager)
+@@ -882,10 +936,12 @@ gsd_keyboard_manager_stop (GsdKeyboardManager *manager)
g_clear_object (>settings);
g_clear_object (>input_sources_settings);
diff --git a/debian/patches/ubuntu_ibus_configs.patch b/debian/patches/ubuntu_ibus_configs.patch
index 5b9212a..e731a3e 100644
--- a/debian/patches/ubuntu_ibus_configs.patch
+++ b/debian/patches/ubuntu_ibus_configs.patch
@@ -3,8 +3,8 @@ Description: restore the code that configure the input method according to
Bug: https://bugs.launchpad.net/bugs/1719938
Forwarded: not-needed
---
- plugins/keyboard/gsd-keyboard-manager.c | 53 +
- 1 file changed, 53 insertions(+)
+ plugins/keyboard/gsd-keyboard-manager.c | 64 +++-
+ 1 file changed, 62 insertions(+), 2 deletions(-)
Index: gnome-settings-daemon-3.26.1/plugins/keyboard/gsd-keyboard-manager.c
===
@@ -69,15 +69,57 @@ Index: gnome-settings-daemon-3.26.1/plugins/keyboard/gsd-keyboard-manager.c
static void
xkb_init (GsdKeyboardManager *manager)
{
-@@ -711,8 +763,10 @@ maybe_create_initial_settings (GsdKeyboa
+@@ -656,7 +708,7 @@ convert_libgnomekbd_layouts (GSettings *settings)
+ g_object_unref (libgnomekbd_settings);
+ }
+
+-static void
++static gboolean
+ maybe_convert_old_settings (GSettings *settings)
+ {
+ GVariant *sources;
+@@ -664,6 +716,7 @@ maybe_convert_old_settings (GSettings *settings)
+ gchar *stamp_dir_path = NULL;
+ gchar *stamp_file_path = NULL;
+ GError *error = NULL;
++gboolean is_first_run = FALSE;
+
+ stamp_dir_path = g_build_filename (g_get_user_data_dir (), PACKAGE_NAME, NULL);
+ if (g_mkdir_with_parents (stamp_dir_path, 0755)) {
+@@ -675,6 +728,8 @@ maybe_convert_old_settings (GSettings *settings)
+ if (g_file_test (stamp_file_path, G_FILE_TEST_EXISTS))
+ goto out;
+
++is_first_run = TRUE;
++
+ sources = g_settings_get_value (settings, KEY_INPUT_SOURCES);
+ if (g_variant_n_children (sources) < 1) {
+ convert_libgnomekbd_layouts (settings);
+@@ -693,6 +748,8
Re: Application for ubuntu-desktop membership
On 2019-06-25 11:57, Iain Lane wrote: That makes three¹, so I've gone ahead and added Gunnar to the Ubuntu Desktop team. Thanks, and welcome! Thanks all for the showed trust in me. I'll try to prove worthy of it. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session3 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master
Sure, that has been the plan all the time. Thanks for uploading. And for not accepting any of the more tangled variants. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368678 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master
Ok, Laney. Some comments which may or may not help: The first chunk is due to new upstream code, where I simply append the modifier to the label if present. Similarly to here: https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-desktop3/tree/debian/patches/ubuntu_language.patch (Life would be a bit easier if upstream could attend to this six years old issue: https://gitlab.gnome.org/GNOME/gnome-desktop/issues/50 ) Then I drop the tweak of the language_response() function, which was the culprit as regards ignoring the modifier of the locale name. That tweak was added by Tim as part of the code for installing language packs from g-c-c: https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-control-center/commit/debian/patches/52_region_language.patch?id=39e7ff32 I'm not sure which problem Tim solved with that, but OTOH the langpack install feature is disabled, so dropping that tweak ought to be harmless. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365920 Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Two UIs for application startup at login
Hi all! Take a look at these doc pages: https://help.ubuntu.com/stable/ubuntu-help/shell-apps-auto-start.html (Tweaks) https://help.ubuntu.com/stable/ubuntu-help/startup-applications.html (revert_remove_gnome_session_properties.patch) Both work, but having two such UIs with related docs for almost the same purpose is probably one too many. To make maintenance easier, we should probably drop the patch. OTOH, the UI and related docs for Startup Applications is installed by default. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Two UIs for application startup at login
On 2020-06-16 18:06, Sebastien Bacher wrote: Le 16/06/2020 à 05:43, Gunnar Hjalmarsson a écrit : To make maintenance easier, we should probably drop the patch. OTOH, the UI and related docs for Startup Applications is installed by default. The patch/application has been pretty low maintainance and as you say we don't install tweaks by default. I've no strong opinion but my preference would be keep things are they are today so the option is available out of the box for users who want it Yeah, I think I agree. The reason I noticed is this summary docs page: https://help.ubuntu.com/stable/ubuntu-help/shell-overview.html Under "Customize your desktop" there is a "Have applications start automatically on log in" link (the Tweaks page), and right below under "Applications and windows" there is a "Startup Applications" link (the old feature which is kept in Ubuntu). Maybe, if we keep the patch, I should simply hide the upstream docs page which refers to Tweaks in order to avoid confusion. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: debbriant wants to join
On 2021-08-17 07:15, Ubuntu Documentation Contributors wrote: Hello Ubuntu Desktop, Brian Thompson (debbriant) wants to be a member of Ubuntu Documentation Contributors (ubuntu-doc-contributors), but this is a moderated team, so that membership has to be approved. You can approve, decline or leave it as proposed by following the link below. https://launchpad.net/~ubuntu-doc-contributors/+member/debbriant Why are (some) messages of this kind sent to the ubuntu-desktop list? -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: debbriant wants to join
On 2021-08-18 03:37, Daniel van Vugt wrote: On 17/8/21 9:15 pm, Gunnar Hjalmarsson wrote: On 2021-08-17 07:15, Ubuntu Documentation Contributors wrote: Hello Ubuntu Desktop, Brian Thompson (debbriant) wants to be a member of Ubuntu Documentation Contributors (ubuntu-doc-contributors), but this is a moderated team, so that membership has to be approved. You can approve, decline or leave it as proposed by following the link below. https://launchpad.net/~ubuntu-doc-contributors/+member/debbriant Why are (some) messages of this kind sent to the ubuntu-desktop list? It's because we have groups as members of other groups :/ ~ubuntu-core-doc is a member of ~ubuntu-doc-contributors ~ubuntu-desktop is a member of ~ubuntu-core-doc Right, but I thought such messages were sent to the admins of ~ubuntu-core-doc only. Maybe not... I changed it now so I and Doug Smythies are admins of ~ubuntu-doc-contributors and deactivated ~ubuntu-core-doc as a member. ~ubuntu-core-doc is still the owner. That way those messages shouldn't spam this list going forward. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Submitting a request
On 2021-09-15 21:32, Steve Langasek wrote: In Ubuntu, the wijesekera keyboard is provided by the ibus-m17n package, which I find included by default in Ubuntu 21.04 as well as in Ubuntu 20.04. While ibus-m17n is present on the Ubuntu desktop ISO, it does not stay after the installation is completed unless you select one of a few certain languages in the installer. Sinhala is (currently) not one of the languages which makes ibus-m17n stay: https://salsa.debian.org/gnome-team/gnome-settings-daemon/-/blob/ubuntu/master/debian/patches/ubuntu/keyboard-Use-ibus-sources-from-locale.patch#L22 So you typically need to: * install the ibus-m17n package * log out and log in again and then: If I go into Settings->Region & Language, I am able to find this keyboard under 'Other' -> 'Sinhala'. Is the problem that selecting wijesekera gives the wrong keymap, or is the problem that it has to be manually selected instead of being the default when choosing Sinhala as a language? Because I cannot find where it was the default input method for Sinhala prior to Ubuntu 21.04. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Submitting a request
On 2021-09-16 01:02, Steve Langasek wrote: Thanks for this insight! Based on the original post, it seems to me that we SHOULD retain ibus-m17n for Sinhala. Is this table in gnome-settings-daemon what ensures that it's retained? It's unclear to me how that works, gnome-settings-daemon is not what drives the installation and there are no references to 'm17n' in the ubiquity source. I think it is, without being able to point at the relevant code. At least it works like that with the CJK languages, and it ought to work in the same way with input languages supported by ibus-m17n. I've filed https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1943768 for gsd and am uploading, since it seems obvious to me based on this thread that we should be defaulting to the national keyboard standard rather than the "Sinhala (US, with Sinhala letters)" layout from xkb-data that doesn't even use the native characters. Great; sounds right to me. I'll follow up that it works as intended once it makes it to the daily build ISO. -- Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Sinhala (wijesekera) (was: Submitting a request)
I tested with the latest daily build ISO for Ubuntu (from yesterday, at
17 UTC). Now, if you select the Sinhala language in the installer, the
"Sinhala (wijesekera) (m17n))" input method is included in the list of
active input sources by default. It can be choosen either from the input
source menu in the top bar or via the +Space keyboard shortcut.
This is true both if you run a live session ("Try Ubuntu") and at first
login after the installation has completed.
--
Gunnar Hjalmarsson
https://launchpad.net/~gunnarhj
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Idea: Let selection of default fonts be based on Noto
TJ, On 2023-07-14 17:13, Gunnar Hjalmarsson wrote: On 2023-07-13 09:37, TJ wrote: Could you consider including the visually-impaired friendly Atkinson Hyperlegible Font? https://brailleinstitute.org/freefont To me it looks like a reasonable font to make selectable in Ubuntu. But before that can be really considered, it would need to be packaged in a sensible way for Debian. Even if the Atkinson Hyperlegible font files are actually included in the texlive-fonts-extra package, they would need to be broken out into a separate package. Package created: https://packages.ubuntu.com/mantic/fonts-atkinson-hyperlegible Maybe that is sufficient. A user can do: sudo apt install fonts-atkinson-hyperlegible and pick Atkinson Hyperlegible in the web browser and/or Tweaks. Otherwise, if we want to include it on the ISO, I'm assuming that we should have a blessing from the desktop team before submitting a MIR. -- Cheers, Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Atkinson Hyperlegible font [was: Idea: Let selection of default fonts be based on Noto]
On 2023-08-31 11:22, TJ wrote: On 30/08/2023 10:32, Gunnar Hjalmarsson wrote: On 2023-07-14 17:13, Gunnar Hjalmarsson wrote: On 2023-07-13 09:37, TJ wrote: Could you consider including the visually-impaired friendly Atkinson Hyperlegible Font? https://brailleinstitute.org/freefont To me it looks like a reasonable font to make selectable in Ubuntu. But before that can be really considered, it would need to be packaged in a sensible way for Debian. Even if the Atkinson Hyperlegible font files are actually included in the texlive-fonts-extra package, they would need to be broken out into a separate package. Package created: https://packages.ubuntu.com/mantic/fonts-atkinson-hyperlegible Maybe that is sufficient. A user can do: sudo apt install fonts-atkinson-hyperlegible and pick Atkinson Hyperlegible in the web browser and/or Tweaks. Otherwise, if we want to include it on the ISO, I'm assuming that we should have a blessing from the desktop team before submitting a MIR. Thank-you - that is really useful for visually impaired operators (and that includes those with reasonably good vision that is starting to go fuzzy at close range!). Being used in the installers (or an easily found Accessibility option) would be icing on the cake. Hmm.. The installer is beyond the scope of my fonts overhaul project. :/ Without knowing, I would guess that the fonts used in the desktop installer are determined by the flavor it installs. So in case of standard Ubuntu it's probably the Ubuntu font for latin scripts, while it may be Noto Sans for some of the flavors. But I may be wrong. And in any case it may be possible to set the installer font specifically. If you want to make such a request, one way is an issue here: https://github.com/canonical/ubuntu-desktop-installer/issues Having to hunt for such support often makes those needing it feel like second-class citizens yet for something like this there is very little, if any, down-side to everyone using this by default (especially in an installer where the defaults should cater for all use-cases where there is no opportunity to customise the early experience - particularly for newcomers and novices). -- Rgds, Gunnar Hjalmarsson https://launchpad.net/~gunnarhj -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
