Re: [OpenJDK 2D-Dev] [8u-dev] RFR for JDK-8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData

Looks fine. On 23/04/2018 03:49, Alexey Ivanov wrote: Hi, Could you please review the following backport to 8u-dev? jbs: https://bugs.openjdk.java.net/browse/JDK-8201240 review: http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009122.html jdk11 changeset:

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

: http://cr.openjdk.java.net/~pnarayanan/4954348/webrev.01/ Thank you once again Have a good day Prahalad N. -Original Message- From: Philip Race Sent: Tuesday, March 27, 2018 2:40 AM To: Sergey Bylokhov Cc: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK

Re: [OpenJDK 2D-Dev] [11] JDK-8200526 Test sun/java2d/marlin/ClipShapeTest.java times out

Looks fine. On 30/03/2018 13:09, Laurent Bourgès wrote: Phil, Here is the ClipShapeTest change to fix timeout issue JBS: https://bugs.openjdk.java.net/browse/JDK-8200526 webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8200526.0/ I increased the timeout to 300s per test. I did a

Re: [OpenJDK 2D-Dev] [11] Review Request: 4912693 Behavior of null arguments not specified in Java Sound

look fine. -phil. On 03/08/2018 03:20 PM, Sergey Bylokhov wrote: Thank you for review. An updated version: http://cr.openjdk.java.net/~serb/4912693/webrev.01/ I also have updated the text in the "javax/print" package On 18/01/2018 16:18, Dan Rollo wrote: Hi Sergey, Looks good to m

Re: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is selected via system property

+1 On 20/03/2018 19:42, Prahalad Kumar Narayanan wrote: Hello Phil Good day to you. Thank you for the explanation. I understand your point now. The code changes look good. Thank you Have a good day Prahalad N. - Original Message - From: Phil Race Sent: Wednesday, March 21, 2018

Re: [OpenJDK 2D-Dev] RFR: 8200129 : Remove D3D Performance Counter.

Looks fine. On 22/03/2018 13:33, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/ It was noted in another thread [1] that we had a couple of qualified exports from java.base to java.desktop that are platform-specific but

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

Hi, Prahalad. A few small comments about the test: - Is it possible to test all installed ImageWriterSpi? It seems that the test itself is not a JPEG plugin specific? - You will need to dispose the jpgWriter even in case of exception. On 23/03/2018 01:10, Prahalad Kumar Narayanan wrote:

Re: [OpenJDK 2D-Dev] RFR: 8199870: colorimaging.md needs to remove mention of KCMS

+1 On 20/03/2018 09:54, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8199870 Diff: inline below The legal attribution file src/java.desktop/share/legal/colorimaging.md references the Kodak Color Management System which not only was never in OpenJDK, but is not in Oracle JDK

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi, Laurent. On 05/03/2018 14:19, Laurent Bourgès wrote: First Marlin 0.9.1 patch works well: no crash or bug with larger tiles 128x64 even if d3d / opengl uses internally 32x32 texture caches. Moreover xrender pipeline is the fastest compared to D3D (40% slower) or opengl (>250% slower) !

Re: [OpenJDK 2D-Dev] Initial implementation for batched AA-mask upload for xrender

Hi, Clemens. On 21/02/2018 23:41, Clemens Eisserer wrote: It is still in prototype state with a few rough edges and a few corner-cases unimplemented (e.g. extra alpha with antialiasing), but should be able to run most workloads: http://93.83.133.214/webrev/

Re: [OpenJDK 2D-Dev] Crash in CGraphicsDevice.m

Hi, Bill. The similar bug was reported recently: https://bugs.openjdk.java.net/browse/JDK-8211992 The root cause is how we use CoreGraphics display ID. This identifier can become non-valid at any time therefore methods, which is using this id should be ready to it. And this bug found a few

[OpenJDK 2D-Dev] [12] Review Request: 8211992 GraphicsConfiguration.getDevice().getDisplayMode() causes JVM crash on Mac

Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8211992 Webrev: http://cr.openjdk.java.net/~serb/8211992/webrev.00 Short description: The root cause is how we use CoreGraphics display ID. This identifier can become non-valid at any time therefore

[OpenJDK 2D-Dev] [12] Review Request: 8212790 Javadoc cleanup of java.awt.color package

Hello. Please review a javadoc "weekend cleanup" in jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8212790 Webrev: http://cr.openjdk.java.net/~serb/8212790/webrev.00 Specdiff: http://cr.openjdk.java.net/~serb/8212790/specdiff.00/overview-summary.html To check the difference I suggest to

Re: [OpenJDK 2D-Dev] [12] Review Request: 8212790 Javadoc cleanup of java.awt.color package

Hi, Krishna. Thank you for review! 1894, 1895, 1902, 1904. The text on the lines above is a block comment not a javadoc, the tags are not necessary there. 1570, 1601, I have fixed these: http://cr.openjdk.java.net/~serb/8212790/webrev.01 -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

I have no comments about the current proposal(results is good), but is that really necessary to have this implementation in native code? On 23/10/2018 13:37, Laurent Bourgès wrote: Phil, I quickly modified the final update & sort loop to: - move sort in another block - use qsort() using a new

Re: [OpenJDK 2D-Dev] [12] Review Request: 8212790 Javadoc cleanup of java.awt.color package

, and monochrome output profiles. + * + * The advantage of this class is that it provides a lookup table that Java + * or native methods can use directly to optimize color conversion in some + * cases. -phil On 10/24/18, 9:36 PM, Sergey Bylokhov wrote: Hi, Krishna. Thank you for review! 1894, 1895

Re: [OpenJDK 2D-Dev] [12] Review Request: 8211992 GraphicsConfiguration.getDevice().getDisplayMode() causes JVM crash on Mac

Any volunteers to review? =) On 15/10/2018 18:11, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8211992 Webrev: http://cr.openjdk.java.net/~serb/8211992/webrev.00 Short description:   The root cause is how we use CoreGraphics

Re: [OpenJDK 2D-Dev] [12] Review Request: 8211992 GraphicsConfiguration.getDevice().getDisplayMode() causes JVM crash on Mac

the wrong display id at the end of the constructor of the GraphicsDevice, and run our tests. All whilst a Java app was running of course - on the monitor being removed. -phil. On 10/15/18 6:11 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. Bug: https

Re: [OpenJDK 2D-Dev] RFR: 8210863: Remove Xrandr include files from JDK sources

Looks fine, I assume mach5 is green. On 31/10/2018 11:57, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8210863 Webrev: http://cr.openjdk.java.net/~prr/8210863/ JDK imported Xrandr headers into it's source a really long time ago because old build systems did not have it. We no

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213138: Update ProblemList.txt for mac

r RE, so you can use pre-build test-image if you wish. Regards Prasanta On 31-Oct-18 4:27 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 30/10/2018 02:58, Prasanta Sadhukhan wrote: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126 <https://bugs.openjdk.java.net/browse/JDK

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213138: Update ProblemList.txt for mac

Hi, Prasanta. On 30/10/2018 02:58, Prasanta Sadhukhan wrote: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126 The failure of the TestMainKeyWindow.java is not a bug, you need to provide -nativepath to the jtreg, because

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

On 26/10/2018 00:41, Laurent Bourgès wrote: I suppose a JEP or RFE is required, isnt it ? It depends from the changes, but such contributions are welcome! Cheers, Laurent On 23/10/2018 13:37, Laurent Bourgès wrote: > Phil, > I quickly modified the final update & sort loop

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

On more question about "image/gif" format, as far as I understand this format do not support the alpha as well, then why it works w/o exceptions? On 07/11/2018 11:17, Sergey Bylokhov wrote: Hi, Jay. As far as I understand the "png" still support alpha, and it is tested by

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hi, Jay. As far as I understand the "png" still support alpha, and it is tested by this test? On 07/11/2018 02:11, Jayathirth D V wrote: Hello All, Please review the following fix in JDK12 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176556 Webrev :

[OpenJDK 2D-Dev] [12] Review Request: 8213110 Remove the use of applets in automatic tests

Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213110 Webrev: http://cr.openjdk.java.net/~serb/8213110/webrev.03 Description of the bug: A number of our tests in jdk still launch by applets via "@run applet". Usually we drop this usage when we update

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

pha of 0 and 255, but nothing in between :-) -phil. On 11/7/18, 12:41 PM, Brian Burkhalter wrote: GIF 89a supports a transparent color index in the palette. Brian On Nov 7, 2018, at 11:25 AM, Sergey Bylokhov mailto:sergey.bylok...@oracle.com>> wrote: On more

Re: [OpenJDK 2D-Dev] [12] Review Request: 8213110 Remove the use of applets in automatic tests

Note that for some of the tests I'll need to update the problem list and replace the .html by the .java. But since we actively updates the problem lists right now I postponed this task for a weekend. On 07/11/2018 15:47, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. Bug

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

s enough information, but if we need to change content of IOException or throw something like UnsupportedOperationException we can do it in separate bug. Please let me know I will raise separate bug for the same. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Friday, Novemb

[OpenJDK 2D-Dev] [12] Review Request: 8213568 Typo in java/awt/GraphicsEnvironment/LoadLock/GE_init5.java

Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213568 Webrev: http://cr.openjdk.java.net/~serb/8213568/webrev.00 I have accidentally found a typo in this test, looks like it was copied from the GE_init4, but the tag was not updated properly, so it runs

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file

Looks fine. On 12/11/2018 20:22, Jayathirth D V wrote: Hello All, Gentle reminder for review. Thanks, Jay *From:* Jayathirth D V *Sent:* Tuesday, October 16, 2018 6:37 PM *To:* 2d-dev *Subject:* [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

Hi, Jay. Can you please provide some more detail about this bug. Root cause : In JDK-6788458 we are adding extra alpha channel for destination whenever we have tRNS chunk. But the number of bands in bitDepth scale array was not changed when we have tRNS chunk. This is causing

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Hi, Jay. Probably it will be better to not to change the code inside switch, and only add the check below around of reading CRC: "if (chunkType != IEND_TYPE) {" The current fix may throw "Invalid chunk length" when seek/flush the data for IEND_TYPE, which is not correct. On 12/11/2018

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

to be initialized because of this update, initialized value of chunkCRC will not be used anywhere in the logic. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8211422/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Wednesday, November 14, 2018 4:31 AM

Re: [OpenJDK 2D-Dev] RFR JDK-8211300: Convert C-style array declarations in Java code

Looks fine to me. I have checked the patch, have build the change and run some tests on our supported platforms. On 30/09/2018 20:29, Tagir Valeev wrote: Hello! Please review JDK-8211300 [1] this change: [2]. Also it needs a sponsor as I have only JDK author status in OpenJDK Census [3].

Re: [OpenJDK 2D-Dev] RFR JDK-8211300: Convert C-style array declarations in Java code

't see the trivial solution. But ok, it's an off-topic :-) With best regards, Tagir Valeev -phil. On 10/1/18, 6:24 PM, Sergey Bylokhov wrote: Looks fine to me. I have checked the patch, have build the change and run some tests on our supported platforms. On 30/09/2018 20:29, Tagir Valeev wrote:

Re: [OpenJDK 2D-Dev] RFR: JDK-8211693 Convert C-style array declarations in client demos and jdk.accessibility

Looks fine. I there are no objections I'll push the fix on Monday. On 03/10/2018 20:46, Tagir Valeev wrote: Please review and sponsor the conversion of C-style arrays in other client modules: demos and jdk.accessibility (a left-over after JDK-8211300):

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

Looks fine. On 18/09/2018 00:22, Laurent Bourgès wrote: Hi, Please could a second reviewer have a look ? Phil approved 2 weeks ago. I would like this bug done asap. I will propose for review the javafx patch (almost the same fix) in a moment. Cheers, Laurent Le mar. 11 sept. 2018 à 08:55,

Re: [OpenJDK 2D-Dev] RFR: 8130264 : change the mechanism by which JDK loads the platform-specific PrinterJob implementation

Looks fine. On 15/11/2018 13:41, Phil Race wrote: bug: http://cr.openjdk.java.net/~prr/8130264/ webrev: http://cr.openjdk.java.net/~prr/8130264/ Currently java launcher code embeds the name of the java.desktop module's PrinterJob implementation class for each platform in a system property

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

Original Message- From: Jayathirth D V Sent: Wednesday, November 14, 2018 1:09 PM To: Sergey Bylokhov; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458 Hi Sergey, Thanks for the review. As you pointed out, yes th

[OpenJDK 2D-Dev] [13] Review Request: 8216592 Drop of sun.awt.AWTSecurityManager class

Hello. Please review the fix for jdk 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8216592 Webrev: http://cr.openjdk.java.net/~serb/8216592/webrev.01 The AWTSecurityManager class is an abstract class which provided the AppContext objects through SecurityManager extensions. The plugin

Re: [OpenJDK 2D-Dev] RFR: 8216965 [JDK12] : crash in freetypeScaler.c CopyBW2Grey8

Looks fine. On 18/01/2019 13:44, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8216965 Webrev: http://cr.openjdk.java.net/~prr/8216965/ Starting with JDK 12 b24 we are calling FT_Render_Glyph(..) but there's no check of an error return. Seems that on some very rare occasions

Re: [OpenJDK 2D-Dev] [12] Review Request: 8214076 Cleanup the code related to GraphicsEnvironment/Device/Configuration

Yes, I have build/tested it manually on win/lin/mac platforms, and using mach5 for all supported platforms. On 11/12/2018 19:23, Philip Race wrote: Looks OK. Please confirm it builds on all platforms + headful + headless tests pass on all platforms .. -phil. On 11/30/18, 6:21 PM, Sergey

[OpenJDK 2D-Dev] [12] Review Request: 8214076 Cleanup the code related to GraphicsEnvironment/Device/Configuration

Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8214076 Webrev: http://cr.openjdk.java.net/~serb/8214076/webrev.01 While I am working on the: https://bugs.openjdk.java.net/browse/JDK-8076313 I have started to unify the code between the platforms, and found

Re: [OpenJDK 2D-Dev] RFR: 8214558: bad @run tag in CheckPrinterJobSystemProperty.java

Looks fine. On 30/11/2018 14:50, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8214558 As noted in the bug this test has a bad @run line and the fix is to remove it diff inline below : diff --git a/test/jdk/java/awt/print/PrinterJob/CheckPrinterJobSystemProperty.java

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

+1 On 30/11/2018 13:16, Alexey Ivanov wrote: Hi Prasanta, Looks good to me. Regards, Alexey On 30/11/2018 17:23, Prasanta Sadhukhan wrote: Hi Alexey, Ok. Modified webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/ Regards Prasanta On 30-Nov-18 10:12 PM, Alexey Ivanov wrote:

[OpenJDK 2D-Dev] [12] Review Request: 8214461 Some unused classes may be removed

Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8214461 Webrev: http://cr.openjdk.java.net/~serb/8214461/webrev.00 We have a few internal classes/interfaces which currently unused and may be removed: - sun.awt.image.BadDepthException.java: looks like it

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

Hi, Shashi. The big problem was that I was not able to reproduce this problem neither at my end nor at the systems used for PIT testing. Only Sergey had produced this NPE till now. If you cannot reproduce this exception on the system w/o printers, then it is interesting what will return this

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

Looks fine. On 29/11/2018 01:29, Jayathirth D V wrote: Hi Sergey, Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.02/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 27, 2018 1:29 AM To: Jayathirth D V; 2d-dev Subject

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

Hi, Laurent. I do not think that we should postpone it to the next version. Just send the changes when they are ready, if the review fails to take place at the right time, then the fix will be moved to the jdk13. On 20/11/2018 00:28, Laurent Bourgès wrote: As OpenJDK12 RDP1 is coming soon, I

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

Hi, Jay. In a few places you changed the tables which contains 3 columns, and you actually drop the last column in the row. BTW why we cannot preserve some of the text like: "TIFF Technical Note 2" On 16/11/2018 03:31, Jayathirth D V wrote: Hello All, Please review the following fix in

Re: [OpenJDK 2D-Dev] [12] Review Request: 8213110 Remove the use of applets in automatic tests

The "ProblemList.txt" is updated in the new version: http://cr.openjdk.java.net/~serb/8213110/webrev.04 On 08/11/2018 10:57, Sergey Bylokhov wrote: Note that for some of the tests I'll need to update the problem list and replace the .html by the .java. But since we actively updates t

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

On 21/11/2018 23:00, Jayathirth D V wrote: I was following ZLib like content in the table, but as you mentioned we can keep at least text mentioning that we need to look up stuff related to TIFF Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. The text about zlib broke

Re: [OpenJDK 2D-Dev] Pixel-perfect drawing on JPanel

Hi, Michał. You can create a bug report here: https://bugreport.java.com/bugreport Please additionally to the test provide the system information, and information about screen(resolutions and default scale factor). On 20/12/2018 03:11, Michał Błaszak wrote: Hi All, I hope this is a known

Re: [OpenJDK 2D-Dev] [13] RFR 8214579: JFrame does not paint content in XVFB / X11vnc environment

Hi, Dmitry. On 03/01/2019 10:29, Dmitry Markov wrote: Fix: It is necessary to use X11SurfaceType instead of XRSurfaceType inside createData() for XRWindowSurfaceData Can you please provide some more details why it is necessary? From the first point of view the XRSurfaceType should be used for

[OpenJDK 2D-Dev] [13] Review Request: 8211885 Duplicate id declarations in java.awt.geom.Path2D

Hello. Please review the fix for jdk 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8211885 Webrev: http://cr.openjdk.java.net/~serb/8211885/webrev.00 Duplicated and unused id were removed from the javadoc. -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] RFR: 8218077: Move src/java.desktop/share/legal/mesa3d.md to unix location

Hi, Phil. Not sure that we can move it from the shared folder, because we use this license in the java.desktop/share/native/common/java2d/opengl/J2D_GL/gl.h On 23/03/2019 12:13, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8218077 Webrev :

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8221263: [TEST_BUG] RemotePrinterStatusRefresh test is hard to use

resh occurred. The refresh could happen just before the printer is added. Waiting for another refresh is to prevent false failures. If the list isn't updated in two refresh cycles, likely it won't be updated. In this case, the user will click Fail. Regards, Alexey -phil. On 3/28/19, 5:52 PM, Se

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8221263: [TEST_BUG] RemotePrinterStatusRefresh test is hard to use

On 05/04/2019 15:30, Sergey Bylokhov wrote: On 03/04/2019 09:35, Alexey Ivanov wrote: We can make minRefreshTime equal to 2 minutes but leave the default refresh time of 4 minutes. Does it sound good? This way the time of waiting for two refresh cycles would be reduced to 4 minutes only> W

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8221263: [TEST_BUG] RemotePrinterStatusRefresh test is hard to use

will click Fail. Regards, Alexey -phil. On 3/28/19, 5:52 PM, Sergey Bylokhov wrote: Hi, Alexey. I think it is ok to drop @ignore tag, but I wonder why did you add the step6 to the instruction. 197 +  "updated.\n" 198 + "Step 6: I

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8221263: [TEST_BUG] RemotePrinterStatusRefresh test is hard to use

Hi, Alexey. I think it is ok to drop @ignore tag, but I wonder why did you add the step6 to the instruction. 197 + "updated.\n" 198 + "Step 6: If the list is not updated, wait for another " 199 + "4 minutes, and then

Re: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

v4 looks fine. On 25/03/2019 11:42, Volker Simonis wrote: Hi Thomas, Christoph, thanks for looking into my fix. I hope I've addressed all your concerns with my new webrev: http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528.v4 By the way, I've tested the new implementation by simulating

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8221412: lookupPrintServices() does not always update the list of Windows remote printers

Looks fine. On 26/03/2019 13:22, Alexey Ivanov wrote: Please see the updated webrev: http://cr.openjdk.java.net/~aivanov/8221412/webrev.1/ The difference between .0 and .1 is in some minor white-space adjustments, like parameter alignment. On 26/03/2019 17:01, Alexey Ivanov wrote: Hi,

Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

Hi, Martin.> * getAllFonts NPE handled The current version is fine, but note that this null-check is not necessary. Previously it was possible because the loadFonts() method might skip initialization of the instance field "fonts"(which was null by default) as a result NPE could occurred when

Re: [OpenJDK 2D-Dev] RFR: 8210782: Upgrade HarfBuzz to the latest 2.3.1

Hi, Phil. Should we update the "harfbuzz.md" file as well? On 28/02/2019 16:12, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8210782 Webrev: http://cr.openjdk.java.net/~prr/8210782/ This change upgrades JDK 13 from using harfbuzz v 1.8.1 to v 2.3.1 which is currently the

Re: [OpenJDK 2D-Dev] RFR: 8210782: Upgrade HarfBuzz to the latest 2.3.1

Looks fine. On 28/02/2019 17:55, Philip Race wrote: Oh yes we should :-). Good catch. The license isn't changed so its a small matter of changing what version we list in the file. http://cr.openjdk.java.net/~prr/8210782.1 -phil. On 2/28/19, 4:58 PM, Sergey Bylokhov wrote: Hi, Phil. Should

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

On 21/02/2019 04:23, Alexey Ivanov wrote: Thank you, Sergey, for looking into this. I guess this case requires more investigation. At first sight, it does not look right, does it? Right, I am not sure that "IndexColorModel" is selected intentionally. -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [13] Review Request: 8216592 Drop of sun.awt.AWTSecurityManager class

On 06/02/2019 04:47, Laurent Bourgès wrote: Few questions about this patch. I wonder if IcedTeaWeb will be broken by such change removing the support of multiple AppContexts in FontManage> What are the possible side effects if this change is applied on application using multiple AppContexts ?

Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

Hi, Martin. What exceptions do you expect below? I think any exception will means a bug in jdk, no? try { GraphicsEnvironment e = GraphicsEnvironment.getLocalGraphicsEnvironment(); fonts = e.getAllFonts(); } catch (Exception e) {} Even

Re: [OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

Looks fine. Thank you for contribution! On 12/03/2019 23:38, Mikhail Filippov wrote: I looking for the second reviewer and sponsor for my font patch: http://cr.openjdk.java.net/~dbatrak/8218914/webrev.03/ -- Mikhail Filippov Software Developer JetBrains http://jetbrains.com “The Drive To

Re: [OpenJDK 2D-Dev] RFR(S): 8214343: Handle the absence of Xrandr more generically

Hi, Volker. On 27/11/2018 05:52, Volker Simonis wrote: Change JDK-8213944 fixed the build on AIX (which has no Xrandr) by conditionally excluding the relevant parts on AIX with the help of preprocessor defines. On the mailing lists the wish was expressed to handle the absence of Xrandr more

Re: [OpenJDK 2D-Dev] CFV: New 2d Group Member : Jayathirth DV

Vote: yes

Re: [OpenJDK 2D-Dev] RFR: 8221304: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java

Hi, Phil. The fix looks fine, but I guess the ProblemList should use 8221305 instead of 8221304. On 21/03/2019 21:20, Philip Race wrote: Problem list a test that fails on Mac + Solaris on just those platforms : Bug: https://bugs.openjdk.java.net/browse/JDK-8221304 diff : diff --git

Re: [OpenJDK 2D-Dev] RFR: 8221304: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java

/IncorrectClipXorModeSW2Surface.java 8196025 windows-all  java/awt/image/DrawImage/IncorrectClipXorModeSurface2Surface.java 8196025 windows-all -phil. On 3/21/19, 9:27 PM, Sergey Bylokhov wrote: Hi, Phil. The fix looks fine, but I guess the ProblemList should use 8221305 instead of 8221304. On 21/03/2019 21:20

Re: [OpenJDK 2D-Dev] [12] Review Request: 8213110 Remove the use of applets in automatic tests

on an expected thread. -phil. On 11/26/18 6:29 PM, Sergey Bylokhov wrote: The "ProblemList.txt" is updated in the new version: http://cr.openjdk.java.net/~serb/8213110/webrev.04 On 08/11/2018 10:57, Sergey Bylokhov wrote: Note that for some of the tests I'll need to update the pr

Re: [OpenJDK 2D-Dev] [12] Review Request: 8213110 Remove the use of applets in automatic tests

Hi, Phil. Thank you for review, see my comments inline: You discuss the life cycle of an applet in jtreg ---   - Call init() and start() methods of the Applet   - Waits for 2 seconds   - Call stop() and destroy() methods of the Applet   - Dispose the frame -- I see init() and

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

It looks fine. BTW do we sure that the usage of IndexColorModel is not a bug? On 14/02/2019 06:07, Alexey Ivanov wrote: Hi Sergey, Do you have any comments for the latest webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ Do I push the fix? Regards, Alexey On 12/02/2019

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

On 11/02/2019 09:28, Alexey Ivanov wrote: No, it does not look like it's possible directly. In the case of DashOffset, VolatileImage contains #F8F8F8 instead of #FF, #CC instead of #FF, #00CC00 instead of #00FF00. In other configurations, the colours could be different.

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

Hi, Alexey. On 11/02/2019 01:44, Alexey Ivanov wrote: Isn't isHeadless() used by jtreg itself? These tests seem to have failed only in Windows where there's no true headless environment. Recent versions of Windows Server allow installing the OS without support for desktop environment, it

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

On 11/02/2019 10:41, Alexey Ivanov wrote: Let me experiment with this. Would it be acceptable if I submit a new CR to improve these tests? Ok, fine. -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

On 14/02/2019 13:02, Alexey Ivanov wrote: BTW do we sure that the usage of IndexColorModel is not a bug? I don't think it's a bug. Likely Windows Server OS is installed in Server Code mode which has limited GUI support. I was able to get IndexColorModel on my desktop by something like this:

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8217263: Automate DashOffset test

Looks fine. On 06/02/2019 14:55, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13. bug: https://bugs.openjdk.java.net/browse/JDK-8217263 webrev: http://cr.openjdk.java.net/~aivanov/8217263/webrev.00/ Description: The test has been re-worked to an automatic test. It uses only 2D API.

Re: [OpenJDK 2D-Dev] [13] Review Request: 8216592 Drop of sun.awt.AWTSecurityManager class

Hi, Phil. On 30/01/2019 12:52, Phil Race wrote: private static boolean maybeMultiAppContext() { // Do we have multiple app contexts any more ? // Or do we need a new way to check for multiple app contexts ? // If not, can we remove this code + its downstream dependencies too in a separate

Re: [OpenJDK 2D-Dev] RFR. Repeated words typos in java.desktop

Hi, Andrey. I found only one questionable place in the fix: == /** * Returns an object created with id=key. If the object is not of - * type type, this will throw an exception. + * that type, this will throw an exception. */ private Object

Re: [OpenJDK 2D-Dev] [13] RFR 8214579: JFrame does not paint content in XVFB / X11vnc environment

On 7 Jan 2019, at 23:14, Sergey Bylokhov mailto:sergey.bylok...@oracle.com>> wrote: Hi, Dmitry. On 03/01/2019 10:29, Dmitry Markov wrote: Fix: It is necessary to use X11SurfaceType instead of XRSurfaceType inside createData() for XRWindowSurfaceData Can you please provide some more

Re: [OpenJDK 2D-Dev] RFR: [JDK12] 8218020 Fix version number in mesa.md 3rd party legal file

Looks fine. On 30/01/2019 09:39, Prasanta Sadhukhan wrote: +1 Regards Prasanta On 30-Jan-19 10:59 PM, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8218020 This is a trivial fix to a license file for JDK 12 needed because v5.0 is what we are tracking as using, but the

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8221263: [TEST_BUG] RemotePrinterStatusRefresh test is hard to use

On 08/04/2019 03:14, Alexey Ivanov wrote: Exactly! I would've done it if it had been possible. Changing the minRefreshTime requires changes to both the implementation and the test, so it's better to do it under separate CR, I've submitted one: https://bugs.openjdk.java.net/browse/JDK-8222108

Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8217707: JNICALL declaration breaks Splash screen functions

Looks fine. On 24/03/2019 12:18, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13. bug: https://bugs.openjdk.java.net/browse/JDK-8217707 webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/ Description: Splash screen functionality is broken in 32 bit Windows. It's because

Re: [OpenJDK 2D-Dev] [PATCH] 8220231: Cache HarfBuzz face object for same font's text layout calls

+1 On 01/04/2019 02:12, Alexey Ushakov wrote: Looks good for me. Best Regards, Alexey On Mon, Apr 1, 2019 at 10:46 AM Dmitry Batrak mailto:dmitry.bat...@jetbrains.com>> wrote: > Sorry for the delay. I've now finished verifying this and it is a +1 from me. Thanks! Anyone else,

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

On 06/06/2019 12:50, Jonathan Gibbons wrote: You should be able to use {@link} to refer to other Java elements; It is possible even across the different modules?(I remember there was some related issue) -- Jon On 06/06/2019 12:46 PM, Sergey Bylokhov wrote: Hi, Prasanta. Can you please

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

, but those issues have now been sorted out. -- Jon On 06/06/2019 05:31 PM, Sergey Bylokhov wrote: On 06/06/2019 12:50, Jonathan Gibbons wrote: You should be able to use {@link} to refer to other Java elements; It is possible even across the different modules?(I remember there was some related

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

at 3:40 PM, Phil Race wrote: If you try to print when there is no printer the behavior is not strictly specified. -Phil. On May 29, 2019, at 3:25 PM, Sergey Bylokhov wrote: On 29/05/2019 15:16, Philip Race wrote: It doesn't hang there. It hangs in print(). I guess it is even more strange, it

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

Hi, Prasanta. Can you please double check is it possible to use {@link } instead of in the java files? For example in src/java.desktop/share/classes/javax/print/attribute/package-info.java Note that some of these docs use 80 chars per line alignment, please use the same style. On

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64

Looks fine. On 27/05/2019 02:33, Prasanta Sadhukhan wrote: Hi All, AlphaColorTest is failing in mach5 linux headful nightly system consistently and it seems to be a product bug, so needs to be problemlisted. diff -r cb2628a4f33f test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Wed

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

On 29/05/2019 14:09, Phil Race wrote: think the mystery is not why it times out now, but why it did not do so earlier. But I assume it if the system does not have the printer then PrinterJob.getPrinterJob() should not hang? It looks like the test correctly assume that .getPrinterJob() should

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

It looks like a bug, no? -phil. On 5/29/19, 3:17 PM, Sergey Bylokhov wrote: On 29/05/2019 14:09, Phil Race wrote: think the mystery is not why it times out now, but why it did not do so earlier. But I assume it if the system does not have the printer then PrinterJob.getPrinterJob() should not

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

ould be thrown. It looks like a bug, no? -phil. On 5/29/19, 3:17 PM, Sergey Bylokhov wrote: On 29/05/2019 14:09, Phil Race wrote: think the mystery is not why it times out now, but why it did not do so earlier. But I assume it if the system does not have the printer then PrinterJob.getPrinterJ

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

Looks fine. On 29/05/2019 12:30, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8225007 Webrev : http://cr.openjdk.java.net/~prr/8225007/ This is just adding the printer keyword to two jtreg tests. This is useful for both selecting & excluding the tests and should prevent one

[OpenJDK 2D-Dev] [13] Review Request: 8225372 accessibility errors in tables in java.desktop files

Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8225372 Fix: http://cr.openjdk.java.net/~serb/8225372/webrev.00 Doc: http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/module-summary.html In the fix, some(most) of the issues which were

Re: [OpenJDK 2D-Dev] [13] Review Request: 8224171 The cleanup multi-font related code in the XFontPeer

and version.01 --Semyon On 5/18/19 3:10 PM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8224171 Fix: http://cr.openjdk.java.net/~serb/8224171/webrev.00 This change is the part of my effort to clean up the native initialization code

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

Looks fine. On 11/06/2019 05:39, Philip Race wrote: Hi, I am still looking for a code review on this - needed today ! -phil. On 6/5/19, 11:43 AM, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8217731 webrev: http://cr.openjdk.java.net/~prr/8217731/ This is intended to

<    2   3   4   5   6   7   8   9   10   11   >