Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-28 Thread Marc Gonzalez
On 26/03/2024 21:21, Jeff Johnson wrote: > On 3/26/2024 10:51 AM, Dmitry Baryshkov wrote: > >> On Tue, 26 Mar 2024 at 19:45, Marc Gonzalez wrote: >>> >>> [ It has been pointed out to me that the previous message was unclear. ] >>> [ Below is my 2nd attempt at a clearer message. ] >>> >>>

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-26 Thread Jeff Johnson
On 3/26/2024 10:51 AM, Dmitry Baryshkov wrote: > On Tue, 26 Mar 2024 at 19:45, Marc Gonzalez wrote: >> >> [ It has been pointed out to me that the previous message was unclear. ] >> [ Below is my 2nd attempt at a clearer message. ] >> >> Problem: firmware-5.bin has not been parsed yet when we

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 19:45, Marc Gonzalez wrote: > > [ It has been pointed out to me that the previous message was unclear. ] > [ Below is my 2nd attempt at a clearer message. ] > > Problem: firmware-5.bin has not been parsed yet when we have to handle > the ATH10K_QMI_EVENT_SERVER_ARRIVE case,

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-26 Thread Marc Gonzalez
[ It has been pointed out to me that the previous message was unclear. ] [ Below is my 2nd attempt at a clearer message. ] Problem: firmware-5.bin has not been parsed yet when we have to handle the ATH10K_QMI_EVENT_SERVER_ARRIVE case, so we can't rely on feature bits to work around the lack of

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-26 Thread Marc Gonzalez
On 13/03/2024 16:09, Marc Gonzalez wrote: > I'm still not quite sure where linux-firmware.git fits into all this. https://packages.debian.org/sid/firmware-atheros As far as I understand, Debian package "firmware-atheros (20230625-2)" includes: ath10k/WCN3990/hw1.0/firmware-5.bin

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-19 Thread Marc Gonzalez
On 19/03/2024 15:39, Marc Gonzalez wrote: > What a dweeb... bitten by the very bug I'm supposed to fix :( Is there a kernel bootcmd to force the kernel to probe devices sequentially, in order to get (roughly) deterministic kernel logs I can run diff on? (Even if it slows down boot by a factor of

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-19 Thread Marc Gonzalez
On 19/03/2024 14:47, Marc Gonzalez wrote: > [ 15.255763] remoteproc remoteproc0: powering up 408.remoteproc > [ 15.263925] remoteproc remoteproc0: Booting fw image mba.mbn, size 234152 > [ 15.277228] ath10k_snoc 1880.wifi: received modem starting event > [ 15.370471] qcom-q6v5-mss

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-19 Thread Marc Gonzalez
On 18/03/2024 17:56, Marc Gonzalez wrote: > Hmm, I don't see protection-domain-mapper running... > > Feb 27 17:44:01 venus pd-mapper[308]: no pd maps available > Feb 27 17:44:01 venus pd-mapper[328]: no pd maps available > Feb 27 17:44:02 venus pd-mapper[345]: no pd maps available > Feb 27

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-18 Thread Marc Gonzalez
On 13/03/2024 16:53, Dmitry Baryshkov wrote: > Do you have pd-mapper, rmtfs and tqftpserv running? You also need to > have wlanmdsp.mbn in the same directory as modem.mbn for your platform > (see how this is handled for sdm845). > If these points are implemented and you still don't have the wlan,

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-14 Thread Jeff Johnson
On 3/14/2024 10:52 AM, Marc Gonzalez wrote: > Is this the line you're after: > [ 32.367011] ath10k_snoc 1880.wifi: qmi fw_version 0x100204b2 > fw_build_timestamp 2019-09-04 03:01 fw_build_id > QC_IMAGE_VERSION_STRING=WLAN.HL.1.0-01202-QCAHLSWMTPLZ-1.221523.2 perfect > Is it legal for my

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-14 Thread Marc Gonzalez
On 14/03/2024 15:33, Jeff Johnson wrote: > On 3/7/2024 8:46 AM, Jeff Johnson wrote: > >> On 3/7/2024 7:29 AM, Marc Gonzalez wrote: >> >>> Have you heard back from the dev team? >>> >>> Do they confirm that an issue involving missing MSA_READY notifications >>> was ever noticed? >>> >>> What

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-14 Thread Jeff Johnson
On 3/7/2024 8:46 AM, Jeff Johnson wrote: > On 3/7/2024 7:29 AM, Marc Gonzalez wrote: >> Have you heard back from the dev team? >> >> Do they confirm that an issue involving missing MSA_READY notifications >> was ever noticed? >> >> What devices were affected? (All msm8998? A subset of msm8998?) >>

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-14 Thread Dmitry Baryshkov
On Thu, 14 Mar 2024 at 14:31, Marc Gonzalez wrote: > > On 13/03/2024 16:53, Dmitry Baryshkov wrote: > > > On Wed, 13 Mar 2024 at 17:09, Marc Gonzalez wrote: > > > >> On 05/03/2024 20:20, Kalle Valo wrote: > >> > >>> Marc Gonzalez wrote: > >>> > I need to build a kernel + rootfs + FW to test

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-14 Thread Marc Gonzalez
On 13/03/2024 16:53, Dmitry Baryshkov wrote: > On Wed, 13 Mar 2024 at 17:09, Marc Gonzalez wrote: > >> On 05/03/2024 20:20, Kalle Valo wrote: >> >>> Marc Gonzalez wrote: >>> I need to build a kernel + rootfs + FW to test the proposed solution, then I can spin a formal submission. >>>

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-13 Thread Dmitry Baryshkov
On Wed, 13 Mar 2024 at 17:09, Marc Gonzalez wrote: > > [ Dropping the DT fellows ] > > On 05/03/2024 20:20, Kalle Valo wrote: > > > Marc Gonzalez wrote: > > > >> I need to build a kernel + rootfs + FW to test the proposed solution, > >> then I can spin a formal submission. > > > > Yeah, please do

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-13 Thread Konrad Dybcio
On 3/13/24 16:09, Marc Gonzalez wrote: [ Dropping the DT fellows ] On 05/03/2024 20:20, Kalle Valo wrote: Marc Gonzalez wrote: I need to build a kernel + rootfs + FW to test the proposed solution, then I can spin a formal submission. Yeah, please do test this to make sure we are not

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-13 Thread Marc Gonzalez
[ Dropping the DT fellows ] On 05/03/2024 20:20, Kalle Valo wrote: > Marc Gonzalez wrote: > >> I need to build a kernel + rootfs + FW to test the proposed solution, >> then I can spin a formal submission. > > Yeah, please do test this to make sure we are not missing anything :) I used

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-07 Thread Jeff Johnson
On 3/7/2024 7:29 AM, Marc Gonzalez wrote: > Have you heard back from the dev team? > > Do they confirm that an issue involving missing MSA_READY notifications > was ever noticed? > > What devices were affected? (All msm8998? A subset of msm8998?) > > Was the issue eventually fixed? > (Probably

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-07 Thread Marc Gonzalez
On 29/02/2024 20:46, Jeff Johnson wrote: > On 2/29/2024 10:40 AM, Conor Dooley wrote: > >> On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: >> >>> Marc Gonzalez writes: >> As mentioned in my other reply, there are several msm8998-based devices affected by this issue. Is it

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Kalle Valo
Marc Gonzalez writes: > On 05/03/2024 15:31, Kalle Valo wrote: > >> Thanks, this is exactly what I'm proposing. > > With your suggestions, the patch becomes much simpler: Nice, looks good to me. > I need to build a kernel + rootfs + FW to test the proposed solution, > then I can spin a formal

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Marc Gonzalez
On 05/03/2024 15:31, Kalle Valo wrote: > Thanks, this is exactly what I'm proposing. With your suggestions, the patch becomes much simpler: diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 0032f8aa892ff..18d0abcf6f693 100644 ---

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Kalle Valo
Marc Gonzalez writes: > On 29/02/2024 19:40, Conor Dooley wrote: > >> On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: >> >>> Marc Gonzalez wrote: >>> As mentioned in my other reply, there are several msm8998-based devices affected by this issue. Is it not appropriate to

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Kalle Valo
Conor Dooley writes: > On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: >> Marc Gonzalez writes: > >> > As mentioned in my other reply, there are several msm8998-based >> > devices affected by this issue. Is it not appropriate to consider >> > a kernel-based work-around? >> >>

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Kalle Valo
Marc Gonzalez writes: > On 01/03/2024 09:10, Kalle Valo wrote: > >> Marc Gonzalez wrote: >> >>> Kalle Valo wrote: >>> Here's one example where in ath10k we use a feature bit as a workaround: /* Don't trust error code from otp.bin */ ATH10K_FW_FEATURE_IGNORE_OTP_RESULT

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Marc Gonzalez
On 04/03/2024 20:34, Conor Dooley wrote: > On Mon, Mar 04, 2024 at 05:21:37PM +0100, Marc Gonzalez wrote: > >> On 29/02/2024 19:40, Conor Dooley wrote: >> >>> On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: >>> Marc Gonzalez wrote: > As mentioned in my other reply, there

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Krzysztof Kozlowski
On 04/03/2024 21:21, Dmitry Baryshkov wrote: > On Mon, 4 Mar 2024 at 22:17, Conor Dooley wrote: >> >> On Mon, Mar 04, 2024 at 09:59:13PM +0200, Dmitry Baryshkov wrote: >>> On Mon, 4 Mar 2024 at 21:46, Conor Dooley wrote: On Mon, Mar 04, 2024 at 09:37:00PM +0200, Dmitry Baryshkov wrote:

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-04 Thread Dmitry Baryshkov
On Mon, 4 Mar 2024 at 22:17, Conor Dooley wrote: > > On Mon, Mar 04, 2024 at 09:59:13PM +0200, Dmitry Baryshkov wrote: > > On Mon, 4 Mar 2024 at 21:46, Conor Dooley wrote: > > > On Mon, Mar 04, 2024 at 09:37:00PM +0200, Dmitry Baryshkov wrote: > > > > On Mon, 4 Mar 2024 at 21:34, Conor Dooley

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-04 Thread Conor Dooley
On Mon, Mar 04, 2024 at 09:59:13PM +0200, Dmitry Baryshkov wrote: > On Mon, 4 Mar 2024 at 21:46, Conor Dooley wrote: > > On Mon, Mar 04, 2024 at 09:37:00PM +0200, Dmitry Baryshkov wrote: > > > On Mon, 4 Mar 2024 at 21:34, Conor Dooley wrote: > > > > On Mon, Mar 04, 2024 at 05:21:37PM +0100, Marc

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-04 Thread Dmitry Baryshkov
On Mon, 4 Mar 2024 at 21:46, Conor Dooley wrote: > > On Mon, Mar 04, 2024 at 09:37:00PM +0200, Dmitry Baryshkov wrote: > > On Mon, 4 Mar 2024 at 21:34, Conor Dooley wrote: > > > > > > On Mon, Mar 04, 2024 at 05:21:37PM +0100, Marc Gonzalez wrote: > > > > On 29/02/2024 19:40, Conor Dooley wrote:

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-04 Thread Conor Dooley
On Mon, Mar 04, 2024 at 09:37:00PM +0200, Dmitry Baryshkov wrote: > On Mon, 4 Mar 2024 at 21:34, Conor Dooley wrote: > > > > On Mon, Mar 04, 2024 at 05:21:37PM +0100, Marc Gonzalez wrote: > > > On 29/02/2024 19:40, Conor Dooley wrote: > > > > > > > On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-04 Thread Dmitry Baryshkov
On Mon, 4 Mar 2024 at 21:34, Conor Dooley wrote: > > On Mon, Mar 04, 2024 at 05:21:37PM +0100, Marc Gonzalez wrote: > > On 29/02/2024 19:40, Conor Dooley wrote: > > > > > On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: > > > > > >> Marc Gonzalez wrote: > > >> > > >>> As mentioned in

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-04 Thread Conor Dooley
On Mon, Mar 04, 2024 at 05:21:37PM +0100, Marc Gonzalez wrote: > On 29/02/2024 19:40, Conor Dooley wrote: > > > On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: > > > >> Marc Gonzalez wrote: > >> > >>> As mentioned in my other reply, there are several msm8998-based > >>> devices

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-04 Thread Marc Gonzalez
On 29/02/2024 19:40, Conor Dooley wrote: > On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: > >> Marc Gonzalez wrote: >> >>> As mentioned in my other reply, there are several msm8998-based >>> devices affected by this issue. Is it not appropriate to consider >>> a kernel-based

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-04 Thread Marc Gonzalez
On 01/03/2024 09:10, Kalle Valo wrote: > Marc Gonzalez wrote: > >> Kalle Valo wrote: >> >>> Here's one example where in ath10k we use a feature bit as a workaround: >>> >>> /* Don't trust error code from otp.bin */ >>> ATH10K_FW_FEATURE_IGNORE_OTP_RESULT = 7, >>> >>> >>>

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-01 Thread Kalle Valo
Marc Gonzalez writes: >> Here's one example where in ath10k we use a feature bit as a workaround: >> >> /* Don't trust error code from otp.bin */ >> ATH10K_FW_FEATURE_IGNORE_OTP_RESULT = 7, >> >> >> >> if (!(skip_otp || test_bit(ATH10K_FW_FEATURE_IGNORE_OTP_RESULT,

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-29 Thread Jeff Johnson
On 2/29/2024 10:40 AM, Conor Dooley wrote: > On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: >> Marc Gonzalez writes: > >>> As mentioned in my other reply, there are several msm8998-based >>> devices affected by this issue. Is it not appropriate to consider >>> a kernel-based

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-29 Thread Conor Dooley
On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: > Marc Gonzalez writes: > > As mentioned in my other reply, there are several msm8998-based > > devices affected by this issue. Is it not appropriate to consider > > a kernel-based work-around? > > Sorry, not following you here. But

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-29 Thread Marc Gonzalez
On 28/02/2024 15:59, Jeff Johnson wrote: > On 2/28/2024 5:24 AM, Marc Gonzalez wrote: > >> The driver waits for this indicator before proceeding, >> yet some WCNSS firmwares apparently do not send it. >> On those devices, it seems safe to ignore the indicator, >> and continue loading the

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Marc Gonzalez
On 28/02/2024 17:37, Kalle Valo wrote: > Marc Gonzalez writes: > >> On 28/02/2024 15:03, Kalle Valo wrote: >> >>> Marc Gonzalez writes: >>> + qcom,no-msa-ready-indicator: +type: boolean +description: + The driver waits for this indicator before proceeding,

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Kalle Valo
Marc Gonzalez writes: > On 28/02/2024 15:03, Kalle Valo wrote: > >> Marc Gonzalez writes: >> >>> + qcom,no-msa-ready-indicator: >>> +type: boolean >>> +description: >>> + The driver waits for this indicator before proceeding, >>> + yet some WCNSS firmwares apparently do not

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Marc Gonzalez
On 28/02/2024 15:03, Kalle Valo wrote: > Marc Gonzalez writes: > >> The driver waits for this indicator before proceeding, >> yet some WCNSS firmwares apparently do not send it. >> On those devices, it seems safe to ignore the indicator, >> and continue loading the firmware. >> >> Signed-off-by:

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Marc Gonzalez
[ Adding Jami Kettunen who documented the same issue 3 years ago ] [ Adding Jeffrey Hugo for his past work on msm8998 ] On 28/02/2024 15:59, Jeff Johnson wrote: > On 2/28/2024 5:24 AM, Marc Gonzalez wrote: > >> The driver waits for this indicator before proceeding, >> yet some WCNSS firmwares

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Jeff Johnson
On 2/28/2024 5:24 AM, Marc Gonzalez wrote: > The driver waits for this indicator before proceeding, > yet some WCNSS firmwares apparently do not send it. > On those devices, it seems safe to ignore the indicator, > and continue loading the firmware. Can you list the product/hardware/firmware

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Kalle Valo
Marc Gonzalez writes: > The driver waits for this indicator before proceeding, > yet some WCNSS firmwares apparently do not send it. > On those devices, it seems safe to ignore the indicator, > and continue loading the firmware. > > Signed-off-by: Pierre-Hugues Husson > Signed-off-by: Marc

[PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Marc Gonzalez
The driver waits for this indicator before proceeding, yet some WCNSS firmwares apparently do not send it. On those devices, it seems safe to ignore the indicator, and continue loading the firmware. Signed-off-by: Pierre-Hugues Husson Signed-off-by: Marc Gonzalez ---