On Fri, Jan 27, 2012 at 11:54:25PM +0800, Marek Lindner wrote:
Hi Andrew,
Do you have any performance analysis to show this is really helpful
and not harmful?
I've seen indoor results where i had to reduce the hop penalty,
otherwise BATMAN was taking a short path which worked
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
debug.c |6 +++---
debug.h |4 ++--
main.c | 50 --
man/batctl.8 |7 +--
sys.c| 12
sys.h|2 ++
6 files changed, 52
Hey Martin,
On Fri, Feb 10, 2012 at 03:53:11PM +0100, Martin Hundebøll wrote:
13 files changed, 491 insertions(+), 0 deletions(-)
please excuse my superficial review, but do we really need to bloat batman-adv
by 491 more lines to drop these OGMs? I'm afraid the filter will evolve
more and
On Thu, Mar 01, 2012 at 03:35:18PM +0800, Marek Lindner wrote:
-static void bat_iv_ogm_receive(struct hard_iface *if_incoming,
-struct sk_buff *skb)
+static void _bat_iv_ogm_receive(struct sk_buff *skb,
+ struct hard_iface *if_incoming)
to add
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
to all the patches.
Cheers,
Simon
signature.asc
Description: Digital signature
Hey Marek,
this looks much cleaner. Thanks!
Simon
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
On Sun, Mar 04, 2012 at 04:56:25PM +0800, Marek Lindner wrote:
The B.A.T.M.A.N. IV OGM receive function still was hard-coded although
it is a routing protocol specific function
Hey Gabriel,
thanks for bringing the discussion to the batman ml and giving some constructive
input. I've written this bonding/alternating feature some time ago, and we
released
it at WBMv3 together with this little documentation to be found in the wiki.
Actually,
I considered the feature
Hey there,
On Sun, Mar 11, 2012 at 09:02:54AM -0700, Mitar wrote:
Hi!
However, in my personal case, there's also the fact that WBM has been
evolving in a direction that I don't feel comfortable with (less
technical content, more self- promotion, tolerance for bomb-makers,
etc.)
Hey Guido,
the problem using one radio is explained further here (from another
company, but this applies to any WiFi mesh technology)
http://revolutionwifi.blogspot.com/2012/02/mesh-network-performance-impact.html
Also, if you use two-radio nodes, make sure that you use one module
on 2.4 GHz
Hey there,
the student application period for the Google Summer of Code 2012 has opened.
A chance for any student to get their hands dirty on their favorite OpenSource
project and getting its development process and code base to know better
during these 2 months - while getting payed for it!
As
Hey Antonio,
thanks a lot for fixing my style bugs!!
There is a little bug in one (one line doubled), otherwise:
Reviewed-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
Cheers,
Simon
On Sat, Apr 07, 2012 at 11:06:06PM +0200, Antonio Quartulli wrote:
** this patches are for batman-ad
On Sat, Apr 07, 2012 at 11:06:07PM +0200, Antonio Quartulli wrote:
@@ -732,7 +732,7 @@ static int handle_claim(struct bat_priv *bat_priv,
}
/**
- *
+ * @bat_priv: the bat priv with all the soft interface information
* @bat_priv: the bat priv with all the soft interface information
Hey Puyou,
On Mon, Apr 16, 2012 at 06:35:04PM +0800, puyou.lu wrote:
Hi guys.
I’m trying to make a for nodes WMN using four devices with two wireless
cards each. I would like to use three different channels to reduce the
interference, like this:
[Node A] - channel 1 - [Node B] -
(or even on bridges above it),
not the wlanX interfaces.
http://www.open-mesh.org/wiki/batman-adv/Quick-start-guide
Cheers,
Simon
-Original Message-
From: b.a.t.m.a.n-boun...@lists.open-mesh.org
[mailto:b.a.t.m.a.n-boun...@lists.open-mesh.org] On Behalf Of Simon
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
Your patch does the trick, although I think this ugly function could use a
rewrite.
First counting bytes and then allocating this size to do exactly the same thing
again
is not really good style. If you would like to volunteer to do this job
Hello David,
we are a little bit in a pinch here - the DAT feature sent with this
patchset was developed for a long time, and we need your decision to move on
as more and more patches depend on it:
* should we rewrite DAT to use our own ARP table/backend or
* can we use the ARP neighbor table
Hey David,
thanks for your answer,
On Thu, May 24, 2012 at 01:54:57AM -0400, David Miller wrote:
From: Sven Eckelmann s...@narfation.org
Date: Thu, 24 May 2012 07:34:12 +0200
_You_ were the person that declined the pull request because _you_ wanted
to
rewrite the ARP handling. So
This is especially useful if there are no claims yet, but we still want
to know which gateways are using bridge loop avoidance in the network.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
bridge_loop_avoidance.c | 68
This is especially useful if there are no claims yet, but we still want
to know which gateways are using bridge loop avoidance in the network.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
[EDIT: forgot to rename the function ...]
---
bridge_loop_avoidance.c | 68
Hey Sven,
On Thu, Jun 14, 2012 at 10:43:55PM +0200, Sven Eckelmann wrote:
You forgot the README and most likely the batctl part.
I planned to send the batctl patch later, but README is definitly
missing. Thanks!
Simon
signature.asc
Description: Digital signature
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
debug.c | 10 ++
debug.h |2 ++
main.c |6 ++
3 files changed, 18 insertions(+)
diff --git a/debug.c b/debug.c
index 928f81d..5dca633 100644
--- a/debug.c
+++ b/debug.c
@@ -70,6 +70,16 @@ void
This is especially useful if there are no claims yet, but we still want
to know which gateways are using bridge loop avoidance in the network.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
[EDITv2: forgot to rename the function ...]
[EDITv3: add README entry]
---
README
On Thu, Jun 14, 2012 at 04:51:01PM -0300, gto...@inti.gob.ar wrote:
Hi,
we are interested too in interface alternating, so we made some
tests to understand how it works. As you can see on the attached
sketch.png, we connected two pair of routers using their ethernet
interfaces, E6 with
This is especially useful if there are no claims yet, but we still want
to know which gateways are using bridge loop avoidance in the network.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
[EDITv2: forgot to rename the function ...]
[EDITv3: add README entry]
[EDITv4: fix style
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
bridge_loop_avoidance.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c
index 38aab1e..a61bb74 100644
--- a/bridge_loop_avoidance.c
+++ b
for consistency reasons within the code and with the documentation,
we should always call it claim and unclaim.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
bridge_loop_avoidance.c | 18 +-
packet.h|4 ++--
2 files changed, 11 insertions
the interface if
no memory is available. OTOH, keeping some of the orig_nodes
with too much memory allocated should hurt no one (except for
a few too many bytes allocated).
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
hard-interface.c |7 ++-
1 file changed, 6 insertions
Hello Arthur,
On Tue, Jul 03, 2012 at 10:57:28AM +0200, Arthur Lambert wrote:
Hi,
I am testing Batman Advance (Batman release 2012 1.0) and I am trying
to measure signaling on some topology of VMs. I have 81 nodes (Debian,
3.0.9) with KVM virtualization. My topology is something like this :
Hey Arthur,
On Wed, Jul 04, 2012 at 12:00:09PM +0200, Arthur Lambert wrote:
Hello,
thanks for your answer,
This is what I thought.. Its probably a mistake in my script to
measure signaling. I will check that.
I have already read the document that you give to me. This document
discribes
On Wed, Jul 04, 2012 at 09:43:13AM -0300, Guido Iribarren wrote:
On Wed, Jul 4, 2012 at 6:12 AM, Simon Wunderlich
simon.wunderl...@s2003.tu-chemnitz.de wrote:
Hello Guido,
On Tue, Jul 03, 2012 at 05:07:17PM -0300, Guido Iribarren wrote:
Hello there again,
I have observed a problem
it falsely infers from the broadcast address
that the right backbone gateway should havehandled the broadcast.
Fix this by checking and delegating the batman-adv packet type used
for transmission.
Reported-by: Guido Iribarren guidoiribar...@buenosaireslibre.org
Signed-off-by: Simon Wunderlich s
Hey Guido,
thanks again for the good debugging, that really helped
to understand the problem :)
I've sent a patch, is it possible for you to apply it
and retry? it should be enough to update the two
gateway nodes.
Cheers
Simon
signature.asc
Description: Digital signature
Sorry, my fault. Will send a patch based on maint in a minute.
On Wed, Jul 04, 2012 at 03:12:59PM -0300, Guido Iribarren wrote:
On Wed, Jul 4, 2012 at 11:05 AM, Simon Wunderlich
simon.wunderl...@s2003.tu-chemnitz.de wrote:
Hey Guido,
thanks again for the good debugging, that really helped
it falsely infers from the broadcast address
that the right backbone gateway should havehandled the broadcast.
Fix this by checking and delegating the batman-adv packet type used
for transmission.
Reported-by: Guido Iribarren guidoiribar...@buenosaireslibre.org
Signed-off-by: Simon Wunderlich s
it falsely infers from the broadcast address
that the right backbone gateway should havehandled the broadcast.
Fix this by checking and delegating the batman-adv packet type used
for transmission.
Reported-by: Guido Iribarren guidoiribar...@buenosaireslibre.org
Signed-off-by: Simon Wunderlich s
it falsely infers from the broadcast address
that the right backbone gateway should havehandled the broadcast.
Fix this by checking and delegating the batman-adv packet type used
for transmission.
Reported-by: Guido Iribarren guidoiribar...@buenosaireslibre.org
Signed-off-by: Simon Wunderlich s
was already
doing fine.
The problem was that f8d11504758 was dropping the packets, and with
your patch it doesn't anymore.
Thanks a lot!
On Wed, Jul 4, 2012 at 3:46 PM, Guido Iribarren
guidoiribar...@buenosaireslibre.org wrote:
On Wed, Jul 4, 2012 at 3:30 PM, Simon Wunderlich
simon.wunderl
Hey Guido,
On Sat, Jul 07, 2012 at 12:37:24AM -0300, Guido Iribarren wrote:
Hello again nice folks,
I updated today another segment of the network with just 4 nodes, to
batman-adv 2012.2 (the one i compiled yesterday with simon patches for
blaII, marek stability fixes, and debug log enabled ,
Hey,
On Sun, Jul 22, 2012 at 01:43:25AM +0200, Sven Eckelmann wrote:
Hi,
maybe some of you have seen that I talked in the channel to Antonio whether
we
should migrate to a different solution to serve our git repositories. This is
(in my opinion) a good idea because gitosis [1] (the
Hey Gui,
On Mon, Jul 23, 2012 at 04:20:39AM -0300, Gui Iribarren wrote:
On Sun, Jul 8, 2012 at 7:09 AM, Simon Wunderlich
simon.wunderl...@s2003.tu-chemnitz.de wrote:
[..]
When it doesn't work is when the ad-hoc connection is severed.
which makes the thing look like
http://www.open-mesh.org
Hello Guido,
On Sat, Jul 28, 2012 at 03:34:29PM -0300, Gui Iribarren wrote:
On Wed, Jul 25, 2012 at 5:34 PM, Simon Wunderlich
OK, so you say that it doesn't work when you simply add eth0 batctl, but it
works
with the bridge?
Exactly.
With a caveat: turns out adding plain eth0
Hello Guido,
On Sun, Aug 05, 2012 at 03:26:43AM -0300, Gui Iribarren wrote:
Here i am again,
the involuntary stress-tester of gw_mode + bla2
and mailing-list readers' headache ;)
Given the setup described here
http://www.open-mesh.org/attachments/download/128
let's say one node in mesh1
Hello Edo,
as discussed already, some general remarks:
* please squash these patches to one - as far as I can see, the 2 others are
mostly
fixes to the first one
* Don't turn on debugging in the Makefile - we don't want that by default
* please also include the batctl patch, it is
Hey Guido,
On Fri, Aug 10, 2012 at 04:27:13PM -0300, Gui Iribarren wrote:
Case closed: i had gone lost in a myriad of different openwrt
revisions, compiled binaries, and patches, so I unknowingly updated
that part of the network to a more recent openwrt version, but that
didn't have the check
Hey Luca,
On Fri, Aug 03, 2012 at 11:40:43AM +0200, Luca Pretto wrote:
Thanks for your answer Sven.
So, I've obviously misunderstood the part mixing non-B.A.T.M.A.N. systems
with batman-adv []
I admit: the fact that batman-adv operates al L2 really confuses me a lot!
I'm a DIY nerd with
Hey Sven,
it works in my QEMU machines (and I could reproduce the bug report from 162).
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
(provided you add some sane commit message. ;] )
Cheers,
Simon
On Sun, Aug 19, 2012 at 09:29:53AM +0200, Sven Eckelmann wrote:
[text
We have seen this to break networks when used with bridge loop
avoidance. As we can't see any benefit from sending these ancient frames
via our mesh, we just drop them.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
soft-interface.c | 12 ++--
1 file changed, 10 insertions
The hash functions in the bridge loop avoidance code expects the
VLAN vid to be right after the mac address, but this is not guaranteed.
Fix this by explicitly hashing over the right fields of the struct.
Reported-by: Marek Lindner lindner_ma...@yahoo.de
Signed-off-by: Simon Wunderlich s
On Thu, Aug 23, 2012 at 03:41:58PM +0200, Edo Monticelli wrote:
The bandwith meter module is a simple, kernel-space replacement for bandwith
measurements tool like iperf and netper. It is intended to approximate TCP
behaviour.
It is invoked through batctl: the protocol is connection
To avoid loops in the startup phase until the first announcement is
sent, send an announcement immediately as soon as a backbone gw is
added.
This may happen due to various reasons, e.g. a packet passes the rx
or tx path.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
the next periodic bla work.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
bridge_loop_avoidance.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c
index c522bdf..db046d8 100644
the recompute function to the skb_share_mac()
function, hence the dirty hack in the subject. We expect this problem to
be fixed in linux 3.8 and above.
Reported-by: Antonio Quartulli or...@autistici.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
this is a rewrite of Antonios patch
The address and the VLAN VID may not be packed in the respective
structs. Fix this by comparing the elements individually.
Reported-by: Marek Lindner lindner_ma...@yahoo.de
Reported-by: Sven Eckelmann s...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
The address and the VLAN VID may not be packed in the respective
structs. Fix this by comparing the elements individually.
Reported-by: Marek Lindner lindner_ma...@yahoo.de
Reported-by: Sven Eckelmann s...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
, or with multiple interfaces, or
cases I don't see now. :)
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
On Wed, Oct 17, 2012 at 02:53:05PM +0200, Linus Lüssing wrote:
Threads in the bottom half of batadv_bla_check_bcast_duplist() might
otherwise for instance overwrite variables which other
Good catch! When can I buy you the beer? :D
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
On Wed, Oct 17, 2012 at 02:53:04PM +0200, Linus Lüssing wrote:
So far the crc16 checksum for a batman-adv broadcast data packet, received
on a batman-adv hard interface, was calculated over zero
.
Reported-by: Sven Eckelmann s...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
bridge_loop_avoidance.c | 18 +++---
bridge_loop_avoidance.h |3 +--
routing.c | 10 +++---
types.h |2 +-
4 files changed, 12 insertions
Applied in revision 3c2de69.
Thanks,
Simon
On Wed, Oct 17, 2012 at 09:55:56PM +0200, Sven Eckelmann wrote:
Signed-off-by: Sven Eckelmann s...@narfation.org
---
main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main.c b/main.c
index 0315fe3..96e401a
.
Reported-by: Sven Eckelmann s...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
PATCHv2: change uint32_t to __be32
PATCHv3: this time also changed in types.h
PATCHv4: also compile if bla is disabled
---
bridge_loop_avoidance.c | 18 +++---
bridge_loop_avoidance.h
by 9fd6b0615b5499b270d39a92b8790e206cf75833
(batman-adv: add bridge loop avoidance compile option)
Signed-off-by: Antonio Quartulli or...@autistici.org
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
soft-interface.c | 2 ++
types.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/soft
output is one of them. :)
2. Ignore the possible deadlock
(sry, fill in your own comment...)
That probably won't help. :)
3. Add workarounds in the core net code
Simon Wunderlich already tried it... I personally think it is not the right
way because it more likely to introduce more
On Tue, Dec 11, 2012 at 10:57:24PM +0100, Antonio Quartulli wrote:
OGMs are currently prepared 1 originator interval in advance then the time
they
are used to be sent. This means that once in the air they carry old
information
(e.g. TT announcements).
To fix this, postpone the OGM
...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
Postponing the sysfs removal for the hardif unregister is easier than
other alternatives involving deferring. This should bring us to the
same level to the bridge code, which also messes with sysfs in the
notifier processing function
Eckelmann s...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
Postponing the sysfs removal for the hardif unregister is easier than
other alternatives involving deferring. This should bring us to the
same level to the bridge code, which also messes with sysfs
...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
Changes from RFCv1:
* use work_struct properly, instead of delayed_work
* postpone for softifs as well as for hardifs
Postponing the sysfs removal for the hardif unregister is easier than
other alternatives involving deferring
Kernel before 3.9 have the NET_ADDR_RANDOM flag which needs to be set.
This patch adds the necessary compat change for older kernel.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
compat.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/compat.h b/compat.h
index
Hey Antonio,
On Thu, Jan 10, 2013 at 04:34:47AM +0200, Antonio Quartulli wrote:
Hello Simon,
thanks a lot for taking care of this and sorry for my very late reply..
no problem, thanks for your review!
Il 31.12.2012 01:40 Simon Wunderlich ha scritto:
diff --git a/hard-interface.c b
...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
Changes from PATCHv1:
* INIT_WORK() in respective struct initialization functions
* kerneldoc
Changes from RFCv1:
* use work_struct properly, instead of delayed_work
* postpone for softifs as well as for hardifs
Postponing
...@narfation.org
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
Changes from PATCHv2:
* kerneldoc for functions
Changes from PATCHv1:
* INIT_WORK() in respective struct initialization functions
* kerneldoc
Changes from RFCv1:
* use work_struct properly, instead of delayed_work
* postpone
The Wireless Battle of the Mesh[1] is an event that aims to bring together
people from across the globe to test the performance of different routing
protocols for ad-hoc networks, like Babel, B.A.T.M.A.N., BMX, OLSR, and
802.11s. Of course, new protocols (working on OpenWRT[2]) are always welcome!
Hey Antonio,
I've tested this (just test, no code review) in my 2.6.32 qemu (Debian squeeze,
iproute from wheezy).
It generally loads and batctl if add/del seems to work, but there is something
weird going on with
bridge interaction. After calling the following 3 commands:
brctl addbr br0
On Tue, Feb 19, 2013 at 03:36:46PM +0100, Antonio Quartulli wrote:
In recv_alfred_packet() a break statement is missing at the end of a case
block and the function is returning -1 instead of 0 even if the packet type
was
known. Add a break to let the function behave correctly.
However this
On Tue, Feb 19, 2013 at 09:08:44AM +0800, Marek Lindner wrote:
Hi Simon,
I've tested this (just test, no code review) in my 2.6.32 qemu (Debian
squeeze, iproute from wheezy). It generally loads and batctl if add/del
seems to work, but there is something weird going on with bridge
On Wed, Feb 20, 2013 at 02:26:25PM +0100, Antonio Quartulli wrote:
Hi Simon,
ip link set dev $iface master bat0
This doesn't work. eth0 is not added to batman. To further test, I've added
it via batctl.
I'm not sure..but I think this does not work because the set master command
using ip doesn't.
Hope that helps!
Cheers,
Simon
Tested-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
On Wed, Feb 20, 2013 at 03:57:31PM +0100, Antonio Quartulli wrote:
This patches enable the new rtnl ops to compile on kernels starting from
2.6.32
Signed-off-by: Antonio Quartulli
defined here
This patch uses another approach by moving the initializers in a dummy
struct instead. This also removes the sparse errors.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
compat.h | 30 +-
1 file changed, 13 insertions(+), 17 deletions
Hi,
I've tested this for compatibility on 2.6.32 (Debian stable) in my virtual
machine.
Marek suggested to use:
batctl if add eth0
vconfig add bat0 5
batctl if add bat0.5
and the last command fails with:
Error - can't write to file '/sys/class/net/bat0.5/batman_adv/mesh_iface':
Operation not
to be an _unsigned_ short int
and its 4 MSB will be used as a flag bitfield, while the
remaining 12 bits are used to store the real VID value
Cc: Simon Wunderlich s...@hrz.tu-chemnitz.de
Signed-off-by: Antonio Quartulli anto...@open-mesh.com
[cut..]
diff --git a/packet.h b/packet.h
index
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
Just a small thing which can be adjusted when merging:
On Mon, Apr 08, 2013 at 11:17:16AM +0200, Antonio Quartulli wrote:
@@ -909,8 +910,9 @@ static int batadv_bla_process_claim(struct batadv_priv
*bat_priv
On Thu, Apr 18, 2013 at 03:43:47PM +0200, Antonio Quartulli wrote:
From: Antonio Quartulli anto...@open-mesh.com
Since the MSB bits of any vid variable are now used for
storing flags, print the vid properly by taking the flags
away and printing -1 in case of VID representing no real
VLAN.
will be used batman-adv wide.
In particular, the VID has to be an _unsigned_ short int
and its 4 MSB will be used as a flag bitfield, while the
remaining 12 bits are used to store the real VID value
Cc: Simon Wunderlich s...@hrz.tu-chemnitz.de
Signed-off-by: Antonio Quartulli anto...@open
As we decreased the struct size from 26 to 24 byte, we can remove
__packed as the compile will not add any more padding.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
packet.h |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/packet.h b/packet.h
index
-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
main.c| 28 +++-
packet.h | 34 +-
routing.c | 19 +++
routing.h |2 ++
4 files changed, 69 insertions(+), 14 deletions(-)
diff --git a/main.c b/main.c
index
if not yet implemented
* remove __packed from ogm packets to allow better access in compiled code
This is based on ordex/compat_bump.
Simon Wunderlich (3):
batman-adv: remove vis functionality
batman-adv: reorder packet types
batman-adv: remove packed from batadv_ogm_packet
This is replaced by a userspace program, we don't need this
functionality to bloat the kernel.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
Makefile.kbuild |1 -
bat_iv_ogm.c |7 -
debugfs.c|9 -
hard-interface.c |9 -
main.c | 11
Changes to v1:
* move the build check macros in a separate flag
* reorder batadv_iv_flags and remove VIS stuff
* add check for adding record route info for icmp request/replies
This is based on ordex/compat_bump.
Simon Wunderlich (6):
batman-adv: remove vis functionality
batman-adv: add
Since we removed the __packed from most of the packets, we should
make sure that the offset generated by the compile are correct for
sent/received data.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
main.c |8
1 file changed, 8 insertions(+)
diff --git a/main.c b
Adding host information for record route is only required for ICMP
requests and replys, and should not be added to just any (future?)
packet type.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
routing.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
main.c| 20 +++-
packet.h | 34 +-
routing.c | 19 +++
routing.h |2 ++
4 files changed, 61 insertions(+), 14 deletions(-)
diff --git a/main.c b/main.c
index 5c76d6f
As we decreased the struct size from 26 to 24 byte, we can remove
__packed as the compile will not add any more padding.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
packet.h |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/packet.h b/packet.h
index
The vis flag is not needed anymore, and since we do a compat bump we
can start with the first bit again
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
packet.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/packet.h b/packet.h
index 88d3aa6..cda3236
This is replaced by a userspace program, we don't need this
functionality to bloat the kernel.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
Makefile.kbuild |1 -
bat_iv_ogm.c |7 -
debugfs.c|9 -
hard-interface.c |9 -
main.c | 11
As we decreased the struct size from 26 to 24 byte, we can remove
__packed as the compiler will not add any more padding.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
packet.h |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/packet.h b/packet.h
index
Since we removed the __packed from most of the packets, we should
make sure that the offset generated by the compiler are correct for
sent/received data.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
main.c |8
1 file changed, 8 insertions(+)
diff --git a/main.c b
The vis flag is not needed anymore, and since we do a compat bump we
can start with the first bit again
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
packet.h | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/packet.h b/packet.h
index
-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
main.c| 20 +++-
packet.h | 34 +-
routing.c | 28
routing.h |2 ++
4 files changed, 70 insertions(+), 14 deletions(-)
diff --git a/main.c b/main.c
index
Adding host information for record route is only required for ICMP
requests and replys, and should not be added to just any (future?)
packet type.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
routing.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Changes to v2:
* add some kernel doc
* fix typos in commit messages
Simon Wunderlich (6):
batman-adv: remove vis functionality
batman-adv: add build check macros for packet member offset
batman-adv: reorder packet types
batman-adv: remove packed from batadv_ogm_packet
batman-adv
This is replaced by a userspace program, we don't need this
functionality to bloat the kernel.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
Makefile.kbuild |1 -
bat_iv_ogm.c |7 -
debugfs.c|9 -
hard-interface.c |9 -
main.c | 11
As we decreased the struct size from 26 to 24 byte, we can remove
__packed as the compiler will not add any more padding.
Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
packet.h |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/packet.h b/packet.h
index
201 - 300 of 1522 matches
Mail list logo
