Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

2010-01-05 Thread Evan Stade
On Tue, Jan 5, 2010 at 5:34 PM, Adam Barth aba...@chromium.org wrote: Instead of DOMUI, why not use an extension to display the directory listing? You can put the icons in the CRX. this would drastically inflate the size of the extension and wouldn't match the system icon theme Adam

Re: [chromium-dev] Unit test in chromium which test javascript alert

2010-01-04 Thread Evan Stade
/app_modal_dialog_unittest.cc might be a good place to start start. -- Evan Stade @ chromium On Sun, Jan 3, 2010 at 11:28 PM, n179911 n179...@gmail.com wrote: Hi, Is there any Unit test in chromium which test javascript alert? Does it have automated test case which automatically clicks the pop up dialog cased

Re: [chromium-dev] [extensions] Please leave bugs open until they've been merged to beta (where necessary)

2009-12-16 Thread Evan Stade
a) what labels will a bug that's been deemed merge-worthy have? b) isn't the next beta cut from ToT? are we planning to re-release the current beta? -- Evan Stade On Wed, Dec 16, 2009 at 11:27 AM, Aaron Boodman a...@google.com wrote: That's all, thanks. - a -- Chromium Developers mailing

Re: [chromium-dev] [extensions] Please leave bugs open until they've been merged to beta (where necessary)

2009-12-16 Thread Evan Stade
On Wed, Dec 16, 2009 at 1:55 PM, Aaron Boodman a...@google.com wrote: On Wed, Dec 16, 2009 at 1:07 PM, Evan Stade est...@chromium.org wrote: a) what labels will a bug that's been deemed merge-worthy have? I dunno if there is an existing convention for this, but I was thinking we just leave

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline -open-in-new-window switch

2009-12-15 Thread Evan Stade
On Mon, Dec 14, 2009 at 4:52 PM, Peter Kasting pkast...@google.com wrote: On Mon, Dec 14, 2009 at 4:47 PM, Evan Stade est...@chromium.org wrote: we have had a lot of bug reports asking for NEW_WINDOW, but none for these two dispositions. What use cases do you envisage? Wanting to open

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline -open-in-new-window switch

2009-12-14 Thread Evan Stade
On Mon, Dec 14, 2009 at 11:06 AM, Peter Kasting pkast...@google.com wrote: On Mon, Dec 14, 2009 at 10:33 AM, Darin Fisher da...@chromium.org wrote: I think for parity with other apps, we should provide a command line switch to force the WindowOpenDisposition to NEW_WINDOW. For bonus points,

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline -open-in-new-window switch

2009-12-14 Thread Evan Stade
On Mon, Dec 14, 2009 at 4:43 PM, Peter Kasting pkast...@google.com wrote: On Mon, Dec 14, 2009 at 4:34 PM, Evan Stade est...@chromium.org wrote: I think adding a --disposition= field is overkill and will be harder to maintain (which is the worst part about command line flags). If a new

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-10 Thread Evan Stade
On Thu, Dec 10, 2009 at 10:58 AM, Peter Kasting pkast...@google.com wrote: On Thu, Dec 10, 2009 at 10:45 AM, Jonathan Dixon j...@chromium.orgwrote: In essence: return DoWork(foo) #if defined(OS_POSIX) DoWork(posix_specific) #endif ; // -- Lint complains about this guy I'd

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-09 Thread Evan Stade
I didn't even know that I could disable the linter like that. Good to know---dozens more NOLINTs coming up! Jokes aside, I agree the linter seems a little draconian, especially as it seems to apply to all code in the files you touch, not just your changes. -- Evan Stade -- Chromium Developers

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
it. On Tue, Dec 8, 2009 at 3:18 PM, Evan Stade est...@chromium.org wrote: With the addition of bookmark sync and form autofill, this tab is getting rather tall (see attachment, ignore the blank space above synchronize bookmarks, which is a separate bug). Do we need to move some stuff to Under

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
, is there an example of this UI somewhere? -Ben On Tue, Dec 8, 2009 at 3:30 PM, Evan Stade est...@chromium.org wrote: On Tue, Dec 8, 2009 at 3:22 PM, Tony Chang t...@chromium.org wrote: http://code.google.com/p/chromium/issues/detail?id=18949 Yes, I suppose this problem is not new, but it has

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 4:07 PM, Peter Kasting pkast...@google.com wrote: On Tue, Dec 8, 2009 at 4:03 PM, Ian Fette i...@chromium.org wrote: Putting on my individual contributor hat here, I have to say that Ben's solution would seem very non-intuitive to me. I'm not aware of any app that

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 4:18 PM, Peter Kasting pkast...@google.com wrote: On Tue, Dec 8, 2009 at 4:11 PM, Evan Stade est...@chromium.org wrote: proposals on which of these options (again, see original attachment) to rip out are welcome and within the scope of this thread. Off the top of my

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 4:51 PM, Peter Kasting pkast...@google.com wrote: On Tue, Dec 8, 2009 at 4:25 PM, Evan Stade est...@chromium.org wrote: On Tue, Dec 8, 2009 at 4:18 PM, Peter Kasting pkast...@google.comwrote: * We have crazy word wrapping. The bookmark sync text could fit on one line

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 5:12 PM, Peter Kasting pkast...@google.com wrote: On Tue, Dec 8, 2009 at 4:59 PM, Evan Stade est...@chromium.org wrote: this makes the assumption that there is some best setting for each WM, which is false. What's best for me on metacity is not what's best for you

Re: [chromium-dev] Re: Startup time regressions

2009-11-11 Thread Evan Stade
I'd back it out to make sure your patch is really to blame. -- Evan Stade On Wed, Nov 11, 2009 at 3:49 PM, Alexander Pavlov apav...@chromium.orgwrote: Hey folks, I'm looking into the startup time regression introduced by r31665, and wondering how this can be so Mac-specific (even more so

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Evan Stade
-- Evan Stade On Thu, Nov 5, 2009 at 2:48 PM, Peter Kasting pkast...@google.com wrote: On Thu, Nov 5, 2009 at 2:46 PM, Alexander Teinum atei...@gmail.comwrote: What? What OS? There shouldn't be any 1 pixel border in our fullscreen mode. It's in the Linux-version. In BrowserWindowGtk

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-04 Thread Evan Stade
it seems that the time limit should depend on the type of bustage break winxp compile --- you get 2 minutes break linux views compile --- you get 30 minutes -- Evan Stade On Wed, Nov 4, 2009 at 1:10 PM, Nicolas Sylvain nsylv...@chromium.org wrote: On Wed, Nov 4, 2009 at 12:16 PM, Peter

[chromium-dev] Re: Chromium security UI choices

2009-11-02 Thread Evan Stade
I now have a new response ready for the next click to select all thread: the best way to make your case is to write an academic paper and conduct a user study that shows how the new UI out-performs the current UI. -- Evan Stade --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Evan Stade
On Wed, Oct 28, 2009 at 1:18 PM, Nico Weber tha...@chromium.org wrote: On Wed, Oct 28, 2009 at 1:10 PM, Elliot Glaysher (Chromium) e...@chromium.org wrote: On Wed, Oct 28, 2009 at 12:24 PM, Antoine Labour pi...@google.com wrote: For the UI bits, I'm willing to believe that GTK, which uses

[chromium-dev] anyone for a webkit review?

2009-10-28 Thread Evan Stade
https://bugs.webkit.org/show_bug.cgi?id=30832 FYI the chromium side is here: http://codereview.chromium.org/337032/show -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options

[chromium-dev] Re: anyone for a webkit review?

2009-10-28 Thread Evan Stade
On Wed, Oct 28, 2009 at 5:51 PM, Adam Langley a...@chromium.org wrote: On Wed, Oct 28, 2009 at 5:47 PM, Evan Stade est...@chromium.org wrote: https://bugs.webkit.org/show_bug.cgi?id=30832 It is generally quite important to attach the patch :) AGL oo, thanks for the pointer

[chromium-dev] Re: Linux/Stability - Remember to check the return value from GTK functions.

2009-10-22 Thread Evan Stade
On Wed, Oct 21, 2009 at 10:09 PM, Lei Zhang thes...@chromium.org wrote: Hi Linux folks, This is a kind reminder to check the return values from GTK functions. Every time you put the unchecked result from, say, gtk_file_chooser_get_filename() into a FilePath or std::string, you risk a

[chromium-dev] Spellchecker and memory-mapped dicts

2009-10-22 Thread Evan Stade
in one chunk) For reference, the English dictionary is about 500K, and most dictionaries are under 2 megs, some (such as Hungarian) are much higher, but no dictionary is over 10 megs. Opinions? -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list

[chromium-dev] External protocol dialog checkbox

2009-10-20 Thread Evan Stade
or equivalent. -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: External protocol dialog checkbox

2009-10-20 Thread Evan Stade
fyi: http://codereview.chromium.org/306017/show -- Evan Stade On Tue, Oct 20, 2009 at 5:41 PM, Brian Rakowski br...@chromium.org wrote: Seems like everyone agrees that Cancel should become Don't launch On Tue, Oct 20, 2009 at 1:07 PM, Mark Mentovai m...@chromium.org wrote: Evan Stade

[chromium-dev] Re: Proposal: rename CHROME_PERSONALIZATION to ENABLE_BROWSER_SYNC

2009-10-14 Thread Evan Stade
I always thought PERSONALIZATION was weird. I believe that was the point. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: seeking webkit reviewer for chrome-specific patches

2009-10-13 Thread Evan Stade
3. It is unclear if there are any layout tests which cover this change. I don't think layout tests can or should cover that change, except for pixel tests, which will just need to be rebaselined. --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Converting dialogs to infobars

2009-10-06 Thread Evan Stade
should remain a dialog - I see it whenever I click on links to stuff in the iTunes store, and having it show as an infobar would be unpleasant. Chatted briefly w/Brian he seemed to agree about multiple download dialog, Glen what do you think? -Ben On Tue, Oct 6, 2009 at 3:02 PM, Evan

[chromium-dev] Jank: performance and animation frame rates

2009-10-02 Thread Evan Stade
with the last update, hit me again -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: Jank: performance and animation frame rates

2009-10-02 Thread Evan Stade
We try to fire the timer rapidly, but if we get bogged down, it just won't fire until later; when it actually does fire, we update our state based on how much time has really passed instead of how many times the timer has triggered. In this case, something is not working as expected (at

[chromium-dev] Re: Jank: performance and animation frame rates

2009-10-02 Thread Evan Stade
On Fri, Oct 2, 2009 at 2:07 PM, Antoine Labour pi...@google.com wrote: On Fri, Oct 2, 2009 at 2:02 PM, John Abd-El-Malek j...@chromium.org wrote: On Fri, Oct 2, 2009 at 12:54 PM, Evan Stade est...@chromium.org wrote: We try to fire the timer rapidly, but if we get bogged down, it just

[chromium-dev] Re: [linux] even faster builds: webkit without debug symbols

2009-09-29 Thread Evan Stade
hahaha Scons Tricks Avoid Scons entirely -- Evan Stade On Tue, Sep 29, 2009 at 4:03 PM, Evan Martin e...@chromium.org wrote: I added a section to the LinuxFasterBuilds wiki on another trick for faster builds. This reportedly makes linking and starting gdb about twice as fast, but only

[chromium-dev] Re: Search engine settings backup

2009-09-23 Thread Evan Stade
your profile manually) you can star http://code.google.com/p/chromium/issues/detail?id=15548 and/or http://code.google.com/p/chromium/issues/detail?id=22596 -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] Re: Search engine settings backup

2009-09-23 Thread Evan Stade
On Wed, Sep 23, 2009 at 11:34 AM, Evan Stade est...@chromium.org wrote: On Wed, Sep 23, 2009 at 11:31 AM, m.f michael.fa...@gmail.com wrote: I had to reinstall recently because of the enable-sync bug that hit a few builds ago.  As a result I had to re-establish all of my settings including

[chromium-dev] Re: [linux] user feedback one month in

2009-09-21 Thread Evan Stade
On Sun, Sep 20, 2009 at 7:43 PM, Evan Martin e...@chromium.org wrote: It’s been a little over a month since I started using Chromium, the Open Source version of the Google Chrome Web browser. Since then, I’ve been using Chromium quite extensively. While the honeymoon isn’t over yet, I do

[chromium-dev] Re: [linux] unmount bug

2009-09-18 Thread Evan Stade
http://crbug.com/22149 -- Evan Stade On Fri, Sep 18, 2009 at 9:45 AM, Dan Kegel d...@kegel.com wrote: OK, I asked on that thread. On Fri, Sep 18, 2009 at 8:53 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Can we ask him to submit strace of chrome when it happens? On Fri, Sep 18

[chromium-dev] Re: Linux: Browser side font problems

2009-09-18 Thread Evan Stade
is ~2x worse? -- Evan Stade I then spent some time with a debug build of pango and a profiler. This was not terribly enlightening, the profiler attributed the extra time to libfontconfig. I then started tracing through pango code to see if I could locate where Skia and Pango diverge on getting

[chromium-dev] Re: Verdict: Menu string casing

2009-09-16 Thread Evan Stade
Title Case is terrible. Can't understand why Mac would choose that. After all, why use Title Case on all things that are *not* titles ? Definitely should use Sentence case, even for Mac. After all they are sentences ! Personally I find Tile Case unreadable and I despise it. Then again I'm

[chromium-dev] Re: [linux] parasite is awesome

2009-09-16 Thread Evan Stade
On Wed, Sep 16, 2009 at 5:37 PM, Evan Martin e...@chromium.org wrote: If you set the name of a GtkWidget using gtk_widget_set_name, it shows that name in the Parasite tree.  That makes it easier to find things (see screenshot), so don't be afraid to add 'em. caveat: I think this should be

[chromium-dev] Re: Is there any good tool on Linux to browser and cross reference chromium source code?

2009-09-16 Thread Evan Stade
kdevelop is pretty good, if you just set the include path correctly it will index the code for you and let you jump to symbols. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

[chromium-dev] Re: Fighting the flakiness, animations

2009-09-14 Thread Evan Stade
Perhaps you can move notification service to app :) On Mon, Sep 14, 2009 at 10:43 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Oops. I just noticed that Animation is now in src/app, which means no NotificationService... do you have any more ideas? On Fri, Sep 11, 2009 at 17:41, Evan

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Evan Stade
I agree it should be the responsibility of the committer to make sure the code passes the trybots on all platforms (I have in the past made the mistake of thinking the trybots were open to everyone, but they are not). I think many committers will not be willing to go through very many iterations

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Evan Stade
if it fails. On Fri, Sep 11, 2009 at 6:58 PM, Evan Stade est...@chromium.org wrote: I agree it should be the responsibility of the committer to make sure the code passes the trybots on all platforms (I have in the past made the mistake of thinking the trybots were open to everyone

[chromium-dev] Re: linux startup regression

2009-09-02 Thread Evan Stade
Maybe r25099?  I don't know how long it takes between commit time and when the results show up in the graph, so this is a rough guess. the perf tests are run continuously on the buildbot, so the regression is somewhere in the range between 25120 and 25132.My suspicion lies on r25126 or 25128.

[chromium-dev] Re: Copying of profiles across systems

2009-08-27 Thread Evan Stade
On Wed, Aug 26, 2009 at 7:48 PM, PhistucKphist...@gmail.com wrote: Bearing the upcoming Chrome OS in mind, this should be taken into account quite strongly. Regular programs will probably not move cleanly and nicely from Windows to Chrome OS, but, at least, Google products should migrate

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Evan Stade
Use cairo instead of Skia if you can avoid it in gtk code. -- Evan Stade On Wed, Aug 26, 2009 at 4:12 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: How do I create a SkBitmap of arbitrary size, filled with color of my choice (on Linux)? I'd need that for Linux extension shelf

[chromium-dev] Re: forbidding IN_PROC_BROWSER_TESTS in unit_tests

2009-08-25 Thread Evan Stade
is an in-proc browser test running on unit_tests right now. -- Evan Stade On Tue, Aug 25, 2009 at 1:28 PM, Darin Fisherda...@chromium.org wrote: On Tue, Aug 25, 2009 at 9:24 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: I'm in the middle of debugging a problem which is caused by singletons

[chromium-dev] Re: forbidding IN_PROC_BROWSER_TESTS in unit_tests

2009-08-25 Thread Evan Stade
On Tue, Aug 25, 2009 at 4:15 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: On Tue, Aug 25, 2009 at 16:08, Evan Stade est...@chromium.org wrote: uh, for which binaries are in proc browser tests allowed? I know there is one in interactive_ui_tests and it was causing problems (which caused

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-24 Thread Evan Stade
On Sat, Aug 22, 2009 at 6:18 PM, Evan Martine...@chromium.org wrote: On Fri, Aug 21, 2009 at 11:05 PM, zenikozen...@gmail.com wrote: If you e.g. use Alt+F for Chrome, you break quick access to Wikipedia's in-page search box. It's already the case that if a page grabs a key it overrides the

[chromium-dev] Re: Common terms + Techno Babble glossary

2009-08-20 Thread Evan Stade
is there a reason this isn't on the wiki? -- Evan Stade On Thu, Aug 20, 2009 at 11:31 AM, Albert J. Wong (王重傑)ajw...@chromium.org wrote: I started a page to collect the common terms/lingo that gets used in chromium development.  It's pretty anemic right now, but if a term keeps needing

[chromium-dev] Re: Common terms + Techno Babble glossary

2009-08-20 Thread Evan Stade
ported: http://code.google.com/p/chromium/wiki/Glossary?ts=1250828818updated=Glossary -- Evan Stade On Thu, Aug 20, 2009 at 8:57 PM, Albert J. Wong (王重傑)ajw...@chromium.org wrote: Nope. Feel free to move it, or I'll do it tomorrow. -A On Thu, Aug 20, 2009 at 7:41 PM, Evan Stade est

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Evan Stade
on linux we do alt+e for page menu and alt+f for wrench menu. The reasoning is that these two menus are reasonable approximations of the Edit and File menus, respectively. -- Evan Stade On Tue, Aug 18, 2009 at 8:14 PM, Ben Goodger (Google)b...@chromium.org wrote: I'm not sure about

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Evan Stade
btw, alt alone appears to do nothing for gtk apps. Also, I don't really care which one alt highlights, but it seems to me that alt just highlights the leftmost menu. This happens to always be File. If the File menu is not leftmost, then it's unclear which should be highlighted. -- Evan Stade

[chromium-dev] Re: RenderView page ID

2009-08-17 Thread Evan Stade
I believe Brett meant to say chrome/renderer/render_{view,widget}.{h,cc} -- Evan Stade On Sun, Aug 16, 2009 at 9:36 PM, Brett Wilsonbre...@chromium.org wrote: On Sun, Aug 16, 2009 at 7:56 PM, hap 497hap...@gmail.com wrote: From this documentation, http://dev.chromium.org/developers/how

[chromium-dev] Re: Mac History Menu

2009-08-12 Thread Evan Stade
On Wed, Aug 12, 2009 at 2:18 PM, Robert Sesekrse...@gmail.com wrote: On Wed, Aug 12, 2009 at 15:33, Scott Violet s...@chromium.org wrote: I would suggest you create something like browser/views/event_utils on the Mac (and Linux) side. Any place you're opening a URL from a user gesture you

[chromium-dev] Re: Hyperlink-like UI element

2009-08-10 Thread Evan Stade
I agree that Get Themes ought to be a link. There are other links in the options menu (Learn More, Manage Certificates), so I think this was just an oversight. -- Evan Stade On Mon, Aug 10, 2009 at 11:14 AM, Jens Alfkes...@google.com wrote: The use of blue-underlined links for actions

[chromium-dev] Re: PSA: irc awareness [Was: Trick question: Who is responsible for repairing a red tree?]

2009-08-07 Thread Evan Stade
I've found xchat's notify-send feature to be helpful: settings-prefs-chatting-alerts-show try balloons on highlighted message -- Evan Stade On Thu, Aug 6, 2009 at 10:03 AM, Drew Wilsonatwil...@chromium.org wrote: One caveat for Colloquy is that the default highlight for someone sent you

[chromium-dev] Re: Dev Chrome crashes on subsequent starts after installing a theme

2009-08-06 Thread Evan Stade
Open your favorite terminal program and type rm -rf ~/.config/google-chrome/Default/Extensions/ at the prompt -- Evan Stade On Thu, Aug 6, 2009 at 2:13 PM, Gobbledegookaftabkha...@gmail.com wrote: Thanks for the replies guys. What exactly does this mean: The fix is to rm -rf your

[chromium-dev] Re: Dev Chrome crashes on subsequent starts after installing a theme

2009-08-06 Thread Evan Stade
oh sorry. Not using linux. rm -rf means to delete. So go find your profile directory and delete the Extensions/ folder in there. -- Evan Stade On Thu, Aug 6, 2009 at 2:15 PM, Evan Stadeest...@chromium.org wrote: Open your favorite terminal program and type  rm -rf ~/.config/google-chrome

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Evan Stade
I have a feeling you are talking about the render view, and you should be asking these questions 'round webkit way -- Evan Stade On Fri, Jul 31, 2009 at 12:34 PM, Peter Kastingpkast...@google.com wrote: On Fri, Jul 31, 2009 at 12:00 PM, ptr727 pieter.vilj...@gmail.com wrote: To summarize

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Evan Stade
Ah, I am eating my words. So you don't like the targets/flavors/formats we write to when copying from the omnibox, correct? If you plan to create a patch to change this, here would be the place to discuss the technical details. If you are simply requesting a change, you might be better served

[chromium-dev] Re: Call for highlights to the 196.0 release notes

2009-07-30 Thread Evan Stade
On Thu, Jul 30, 2009 at 1:46 PM, Nico Webertha...@chromium.org wrote: And another one for linux, by estade and me: Linux now has carpet bombing protection. Not too interesting, but since this counts as a security issue these days, you might want to mention it. actually we already had the

[chromium-dev] Re: CMake for chromium

2009-07-27 Thread Evan Stade
On Mon, Jul 27, 2009 at 11:58 AM, Dan Kegeld...@kegel.com wrote: On Mon, Jul 27, 2009 at 11:53 AM, Mark Mentovaim...@chromium.org wrote: I think i'll work on studying the current build system to figure out how to implement a CMake one. That's fine.  Let us (including me) know what you come

[chromium-dev] Re: auto-hide bookmarks bar

2009-07-27 Thread Evan Stade
On Mon, Jul 27, 2009 at 11:51 AM, Peter Kastingpkast...@google.com wrote: On Fri, Jul 24, 2009 at 3:40 PM, David spam.free...@gmail.com wrote: I really like the fact that the bookmark bar is seen only in the new tab page by default. Would it be possible to have the bookmark bar become

[chromium-dev] Re: CMake for chromium

2009-07-27 Thread Evan Stade
On Mon, Jul 27, 2009 at 1:59 PM, Evan Stadeest...@chromium.org wrote: On Mon, Jul 27, 2009 at 11:58 AM, Dan Kegeld...@kegel.com wrote: On Mon, Jul 27, 2009 at 11:53 AM, Mark Mentovaim...@chromium.org wrote: I think i'll work on studying the current build system to figure out how to implement

[chromium-dev] Re: CMake for chromium

2009-07-27 Thread Evan Stade
is there to building in KDevelop rather than from terminal? -- Evan Stade On Mon, Jul 27, 2009 at 5:41 PM, Ben Goodger (Google)b...@chromium.org wrote: Much encouragement to anyone that wants to implement a KDevelop generator. -Ben On Mon, Jul 27, 2009 at 5:34 PM, Dan Kegeld...@kegel.com wrote: Nesting

[chromium-dev] Re: CMake for chromium

2009-07-27 Thread Evan Stade
than MS does intellisense (all I had to do was set the header includes path to src/, and it was essentially instant to parse the symbols). I'm not sure what the point of a generator for it would be though. What advantage is there to building in KDevelop rather than from terminal? -- Evan Stade

[chromium-dev] Re: valgrind updated

2009-07-22 Thread Evan Stade
it's just a helpful wrapper, doing stuff like --malloc-fill=41 and pointing at the suppression file. -- Evan Stade On Wed, Jul 22, 2009 at 8:53 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Seems like a good news, but why should I use this script instead of regular valgrind? I don't

[chromium-dev] Re: IPC from webkit glue?

2009-07-16 Thread Evan Stade
I assume you mean renderer-browser IPC. The RenderView implements the WebViewDelegate interface, so calls to the RenderView take the form within WebViewImpl (e.g.): delegate()-RemoveStoredAutofillEntry(name, value); -- Evan Stade On Thu, Jul 16, 2009 at 9:09 PM, Paul Wickspwick

[chromium-dev] Re: Using Chromium Source Code?

2009-07-12 Thread Evan Stade
On Thu, Jul 9, 2009 at 8:39 AM, dhhwaidhh...@gmail.com wrote: Well, the Chromium _source code_ is open source. But my guess is I don't think you can use the Chromium name nor logo in any personally distributed software. I'm not sure what you mean by this, as there are already chromium

[chromium-dev] Re: Meeting Notes From 2/9/2009 Now Posted!

2009-07-09 Thread Evan Stade
Is it possible to continue posting these? external developers have requested it. -- Evan Stade On Wed, Feb 11, 2009 at 10:18 AM, Peter Kastingpkast...@google.com wrote: On Tue, Feb 10, 2009 at 6:19 PM, Glenn Wilson gwil...@chromium.org wrote: Meeting notes from February 9, 2009 are now

[chromium-dev] using system libjpeg

2009-06-30 Thread Evan Stade
://refspecs.linux-foundation.org/LSB_3.1.0/LSB-Desktop-generic/LSB-Desktop-generic/libjpeg-ddefs.html. Any objections to doing this? Additionally, any build system oriented folk want to assist with making this switch? -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: using system libjpeg

2009-06-30 Thread Evan Stade
b) compiling our libjpeg with boolean = int (at least on linux) This seems the simplest to me.  It's not like we're saving 3 bytes of memory using a char instead of an int for these booleans -- they're likely passed around in 4-byte registers and 4-byte unpacked structs anyway. But I'm

[chromium-dev] Re: Pixel layout tests and checksums

2009-06-23 Thread Evan Stade
(replying to all this time) if that's the case, can't we run a script to find all the cases where svn log --limit 1 is different for the PNG and checksum, then just rebaseline em? -- Evan Stade On Mon, Jun 22, 2009 at 11:51 AM, Pam Greenep...@chromium.org wrote: That's what we do now

[chromium-dev] updating mouse pointer state

2009-06-01 Thread Evan Stade
: is there a better fix? -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-29 Thread Evan Stade
. So I restarted X and it went away. (Note that my x session had been up for like a month.) I searched the internets and it seems to happen to people for a variety of reasons, usually with no resolution found. -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread Evan Stade
and svn diff a.cc is not very readable to me so what i would like to do is revert but give a new name for the file and then i can add a tool in the IDE to quickly windiff thanx 1. svn diff `find . -name *.cc` 2. svn diff a.cc | patch -Rp0 -o a_trunk.cc -- Evan Stade

[chromium-dev] Re: chrome://downloads/ behaviour (some suggestions and a bug, i think)

2009-05-29 Thread Evan Stade
(also, having read the source code that handles downloads, i didn't really get why you first create a temp  file only to transfer it at the end to the real name. i am sure you have reasons but i was just curious) to parallelize the process of choosing the download location and actually

[chromium-dev] Re: Mac History Menu Implementation

2009-05-29 Thread Evan Stade
I like firefox's approach with the recently closed in a submenu of the history menu. Honestly though I can't say I use it very frequently. I just feel safer knowing it's there. -- Evan Stade On Thu, May 28, 2009 at 1:14 PM, Ben Goodger (Google) b...@chromium.org wrote: I would say try

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread Evan Stade
use cygwin -- Evan Stade On Fri, May 29, 2009 at 6:29 PM, nakro yoav.zilberb...@gmail.com wrote: thanx evan, just to be clear i use *windows* (hence the windiff thing) and i have svn 1.6.1 (the normal env i hope, i did not modify it) 1- svn diff `find . -name *.cc` returns: svn.exe

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread Evan Stade
how do you apply other people's diffs if you don't have patch? Run cygwin's setup.exe and select the 'patch' package. -- Evan Stade On Fri, May 29, 2009 at 6:43 PM, nakro yoav.zilberb...@gmail.com wrote: Evan, i have cygwin in my path and i know that when you build chrome it registers

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Evan Stade
purposes, I've also attached linux ;) -- Evan Stade On Wed, May 27, 2009 at 2:27 PM, Ben Goodger (Google) b...@chromium.org wrote: I want to stress this point. It's always best to discuss any change in Chrome code with others before you invest a lot of time on it. You will doubtless get helpful

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-28 Thread Evan Stade
help. -- Evan Stade On Wed, May 27, 2009 at 1:57 PM, Scott Hess sh...@chromium.org wrote: On Wed, May 27, 2009 at 11:42 AM, Darin Fisher da...@chromium.org wrote: The fear of crashing is overblown.  Information about bad states is far more valuable. I'd much rather read blog comments from

[chromium-dev] Re: green flashes in page content

2009-05-19 Thread Evan Stade
webpages). -- Evan Stade On Tue, May 19, 2009 at 5:01 PM, Mohamed Mansour m0.interact...@gmail.com wrote: I see yellow on linux builds :) On May 19, 7:59 pm, Evan Martin e...@chromium.org wrote: If you're seeing green flashes when you resize, don't worry -- that's just the window background

[chromium-dev] Re: [linux] green flashes in page content

2009-05-19 Thread Evan Stade
Are we sure we need this functionality?  I understand the intention of seeing when we're not drawing fast enough, but I'm seeing the green background all the time (on a fast machine), which leads me to believe that the debugging aid is a red herring. Yea, you should see it all the time.

[chromium-dev] Re: Linux splash page update

2009-05-08 Thread Evan Stade
, Evan Stade est...@chromium.org wrote: I think it's time to reword this, as users filing bugs has already proven helpful (to me anyway). Also, I don't think we're really treating it as a pre-alpha any more since user-requested features (such as hotkeys, ui elements, etc.) are getting priority

[chromium-dev] Linux splash page update

2009-05-07 Thread Evan Stade
a moot point. -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: custom_deps [src/webkit/data/layout_tests/LayoutTests: None] has no effort

2009-05-05 Thread Evan Stade
check src/DEPS to see the directories you can ignore. On Tue, May 5, 2009 at 5:41 PM, Tony Chang t...@chromium.org wrote: Be aware that it's not possible to just pick any directory and have it not synced.  It only works on directories that are pulled from a different repository like

[chromium-dev] [linux] GTK and multi-threading

2009-04-10 Thread Evan Stade
connection. Adam suggested this one so he's better able than I to explain the implications. Anyone with thoughts, advice, insight? p.s. So yes, webview copy-pasta is currently very dicey. You can always use the selection clipboard though, as long as you only care about text. -- Evan Stade

[chromium-dev] Re: GDK_IS_WINDOW(window) failed

2009-04-02 Thread Evan Stade
8708 should be fixed now due to http://codereview.chromium.org/59003/show -- Evan Stade On Wed, Apr 1, 2009 at 11:04 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: In r12947 I made fatal gdk/gtk assertions really fatal. And of course it made assertion from http://crbug.com/8708

[chromium-dev] Re: Recent refactoring of widget creation code

2009-03-25 Thread Evan Stade
something out. (your last comment made it sound like you'd just override those functions?) -- Evan Stade On Wed, Mar 25, 2009 at 2:02 PM, Avi Drissman a...@chromium.org wrote: Oh! CreateNewWidgetInternal is virtual! That's... useful. Avi On Wed, Mar 25, 2009 at 4:58 PM, Avi Drissman

[chromium-dev] Re: [linux] plugin info caching

2009-02-18 Thread Evan Stade
It appears that Mozilla (maybe for similar reasons) caches this info across browser runs and relies on the file mtime to see when its cache has expired, much to some users' dismay: https://bugzilla.mozilla.org/show_bug.cgi?id=125469 Or at least they did in 2002. ;) yea, they definitely

[chromium-dev] Re: fixing CommandLine

2009-01-14 Thread Evan Stade
I don't think that it is actually *always* used as a singleton currently. As Ricardo pointed out, only the default constructor uses the CommandLine::Data singleton. The other constructors create new Data objects. This is somewhat moot though if you will be ditching the Data class. And that

[chromium-dev] Re: linux layout tests status

2008-12-16 Thread Evan Stade
SMO folks: any requests on how we can avoid collisions on this? I typically grab something from the middle (e.g. tables/mozilla/marvin) and just hope I don't conflict. If it looks like something I've touched before, I tackle it. If it looks like something that belongs to someone (e.g. fonts