[chromium-dev] Re: When disabling a test, please assign to whoever wrote it

2009-10-15 Thread Jeremy Orlow
This is still happening. VERY annoying. ANYONE who is disabling tests, marking them flaky, etc needs to take the 30 seconds required to svn blame the file and cc people the relevant people. On Tue, Sep 22, 2009 at 2:33 PM, Aaron Boodman a...@chromium.org wrote: Seriously. In a project as big

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Andrew Scherkus
Hrmm... it looks your script assumes depot_tools is in your PATH -- if it can't find it the script crashes. Trying to figure out a workaround. If all else fails I can always give in and add depot_tools to my PATH :) On Wed, Oct 14, 2009 at 11:08 PM, Aaron Boodman a...@chromium.org wrote:

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Darin Fisher
On Wed, Oct 14, 2009 at 7:17 PM, Jeremy Orlow jor...@chromium.org wrote: I think the main points of contention regarding SecurityOrigin::toString() are the name toString and what type it should return. In terms of the names: I think we should provide constructors and getters for each

[chromium-dev] Who's sheriff?

2009-10-15 Thread Mark Mentovai
Today on the waterfall, I see: Sheriffs: munjal From past experience, one sheriff really isn't enough. Munjal should be able to take a lunch break. Also, I think that this will be his first stint as sheriff. It would probably help him out if he had a co-sheriff who had done it at least once

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Erik Corry
This makes me very happy! 2009/10/15 Glenn Wilson gwil...@chromium.org: Hi Webkit gardeners, The Windows canary bot now generates formatted layout test results on each build that had unexpected failing layout tests, which means you can quickly see layout test failures, diffs, and upstream

[chromium-dev] Running applications in chrome with javascript

2009-10-15 Thread David
hi! i want to know how to run an applicacion with the chrome, as the same as activeX in IE and xpcom interfaces in Mozilla... thanks! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

[chromium-dev] hi!

2009-10-15 Thread David
- --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---

[chromium-dev] Re: Who owns crash...@chromium.org and why is there so many updates from it?

2009-10-15 Thread Anthony LaForge
Disabled the auto-crash features for Mac. Kind Regards, Anthony Laforge Technical Program Manager Mountain View, CA On Mon, Oct 12, 2009 at 9:44 AM, Mike Pinkerton pinker...@chromium.orgwrote: I just had crashbot add a totally unrelated stack trace to a bug. I emailed anthony about it, we'll

[chromium-dev] How To Compile Chrome OS

2009-10-15 Thread giamas
Is it possible to Compile Chrome OS version of Chromium? Where I can find more news? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Canary bot, now with formatted layout test results

2009-10-15 Thread Glenn Wilson
Hi Webkit gardeners, The Windows canary bot now generates formatted layout test results on each build that had unexpected failing layout tests, which means you can quickly see layout test failures, diffs, and upstream baselines without running the tool manually. The goal of this output is to help

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Jeremy Orlow
I guess you're rightabout pretty much everything. I'll put it in chrome/common then? (Note I actually wasn't planning on putting it in base unless the API depended on it, but it seemed like including that would just make what I was saying more confusing.) On Thu, Oct 15, 2009 at 12:19 AM,

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Jeremy Orlow
Christmas came early for anyone working on WebKit! Thanks Glen. :-) On Thu, Oct 15, 2009 at 9:17 AM, Erik Corry erik.co...@gmail.com wrote: This makes me very happy! 2009/10/15 Glenn Wilson gwil...@chromium.org: Hi Webkit gardeners, The Windows canary bot now generates formatted layout

[chromium-dev] Re: [chromium-extensions] HTML5 spellcheck attribute

2009-10-15 Thread Aaron Boodman
This is not really an extensions question. I think you want chromium-...@. - a On Thu, Oct 15, 2009 at 9:10 AM, Mixe twitter...@googlemail.com wrote: Chrome does not support HTML5 spellcheck attribute? Then why spellchecking is enabled by default? How we can disable (using JS) spellchecking

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Yaar Schnitman
Glenn, this tool is amazing! It really helped me yesterday on my 1st gardening shift. Re: upstream baselines without running the tool manually How do I do that? On Thu, Oct 15, 2009 at 10:01 AM, Jeremy Orlow jor...@chromium.org wrote: Christmas came early for anyone working on WebKit! Thanks

[chromium-dev] Re: [chromium-extensions] HTML5 spellcheck attribute

2009-10-15 Thread Julie Parent
On Thu, Oct 15, 2009 at 10:04 AM, Aaron Boodman a...@chromium.org wrote: This is not really an extensions question. I think you want chromium-...@. - a On Thu, Oct 15, 2009 at 9:10 AM, Mixe twitter...@googlemail.com wrote: Chrome does not support HTML5 spellcheck attribute? Then why

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Ojan Vafai
Replying off-list as requested... Firstly, this is awesome! On Wed, Oct 14, 2009 at 10:35 PM, Chase Phillips ch...@chromium.org wrote: git-cl upload Runs presubmit tests on upload, continues even if tests fail. This latter part is different than the gcl version. Is that intentional? I

[chromium-dev] Re: layout test dashboard goofup

2009-10-15 Thread Ojan Vafai
I put some more thought into this. Given that we only store a month's worth of data, it's not worth doing backups. Keeping around all the data (maybe a year's worth?) would be awesome though. I actually think that would not be too much work and would add value to the dashboard. At that point,

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Chase Phillips
Hi Andrew, On Wed, Oct 14, 2009 at 11:31 PM, Andrew Scherkus scher...@chromium.orgwrote: Hrmm... it looks your script assumes depot_tools is in your PATH -- if it can't find it the script crashes. Thanks for pointing this out. The hooks should fail gracefully in those cases, so I'll make

[chromium-dev] [Memory] Observations on memory usage in flickr

2009-10-15 Thread Jens Alfke
I spent some time this morning looking at Chrome's memory usage (on OS X 10.5.8) while viewing flickr.com. First I simply started at my photo- stream page and hit Reload over and over. Next I tried going through all of my photos one by one. I used the RPRVT column in 'top', and the 'heap'

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Andrew Scherkus
On Thu, Oct 15, 2009 at 11:03 AM, Chase Phillips ch...@chromium.org wrote: Hi Andrew, On Wed, Oct 14, 2009 at 11:31 PM, Andrew Scherkus scher...@chromium.orgwrote: Hrmm... it looks your script assumes depot_tools is in your PATH -- if it can't find it the script crashes. Thanks for

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Chase Phillips
On Thu, Oct 15, 2009 at 10:38 AM, Ojan Vafai o...@chromium.org wrote: Replying off-list as requested... Right! ;) Firstly, this is awesome! Thanks. On Wed, Oct 14, 2009 at 10:35 PM, Chase Phillips ch...@chromium.orgwrote: git-cl upload Runs presubmit tests on upload, continues

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Evan Martin
On Thu, Oct 15, 2009 at 11:19 AM, Chase Phillips ch...@chromium.org wrote: To bypass the presubmit tests in upload or dcommit, use the --bypass-hooks flag. git-cl dcommit's -f now implies --bypass-hooks along with skipping the commit confirm prompt. Ditto above. The gcl flag is

[chromium-dev] Re: [Memory] Observations on memory usage in flickr

2009-10-15 Thread Peter Kasting
On Thu, Oct 15, 2009 at 11:11 AM, Jens Alfke s...@google.com wrote: • Switching to another tab in the same window is the only way to get heap usage down significantly (by calling V8's IdleNotification) and even then it takes over a minute of occasional idle-time GC to have a significant

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Michael Nordman
On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth aba...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman micha...@google.com wrote: As mentioned f2f, this falls apart as soon as Chrome tries to

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Jeremy Orlow
On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth aba...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman micha...@google.com

[chromium-dev] Re: [Memory] Observations on memory usage in flickr

2009-10-15 Thread James Robinson
On Thu, Oct 15, 2009 at 11:11 AM, Jens Alfke s...@google.com wrote: I spent some time this morning looking at Chrome's memory usage (on OS X 10.5.8) while viewing flickr.com. First I simply started at my photo- stream page and hit Reload over and over. Next I tried going through all of my

[chromium-dev] Re: [Memory] Observations on memory usage in flickr

2009-10-15 Thread Mike Belshe
On Thu, Oct 15, 2009 at 11:11 AM, Jens Alfke s...@google.com wrote: I spent some time this morning looking at Chrome's memory usage (on OS X 10.5.8) while viewing flickr.com. First I simply started at my photo- stream page and hit Reload over and over. Next I tried going through all of my

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Ojan Vafai
On Thu, Oct 15, 2009 at 11:19 AM, Chase Phillips ch...@chromium.org wrote: On Thu, Oct 15, 2009 at 10:38 AM, Ojan Vafai o...@chromium.org wrote: Replying off-list as requested... Right! ;) Doh. However, my tests of gcl upload show they already have the same behavior here: gcl uploads

[chromium-dev] Re: [Memory] Observations on memory usage in flickr

2009-10-15 Thread Peter Kasting
On Thu, Oct 15, 2009 at 11:57 AM, Mike Belshe mbel...@google.com wrote: • We should call V8::IdleNotification in situations other than a hidden tab. A long-lived tab might go for quite a while without being hidden in this way: the user might activate another app, hide Chrome itself, or just

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Michael Nordman
On Thu, Oct 15, 2009 at 11:45 AM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth aba...@chromium.org

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Michael Nordman
On Thu, Oct 15, 2009 at 12:16 PM, Michael Nordman micha...@google.comwrote: On Thu, Oct 15, 2009 at 11:45 AM, Jeremy Orlow jor...@chromium.orgwrote: On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher

[chromium-dev] bugtracker cleanup

2009-10-15 Thread Paweł Hajdan Jr .
Today I reviewed some old bugs which didn't get any attention and tried to correctly mark/assign/close them. Feel free to reassign a bug if I assigned it to you - I was generally looking for people familiar with the area so that they can decide what to do next (please not that the status of such

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Jeremy Orlow
On Thu, Oct 15, 2009 at 12:17 PM, Michael Nordman micha...@google.comwrote: On Thu, Oct 15, 2009 at 12:16 PM, Michael Nordman micha...@google.comwrote: On Thu, Oct 15, 2009 at 11:45 AM, Jeremy Orlow jor...@chromium.orgwrote: On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Marc-Antoine Ruel
Actually, can you package this so it could be upstreamed to webkit.org? On Thu, Oct 15, 2009 at 1:09 PM, Glenn Wilson gwil...@chromium.org wrote: The tool lives in src/webkit/tools/layout_tests/test_output_formatter{.bat,.sh}, and it can actually be run against any builder, not just the

[chromium-dev] No co-sheriff today

2009-10-15 Thread Munjal Doshi
I am the only scheduled sheriff today and there is no co-sheriff. I was out for 5 minutes to grab lunch and ran to my desk. The tree became red in the meantime. Sorry for not being thoughful to aks someone to cover for me during those 5 minutes. It would be great if someone can help me out today

[chromium-dev] Re: No co-sheriff today

2009-10-15 Thread Thomas Van Lenten
I'll keep an eye on things tomorrow morning (east coast hours). TVL On Thu, Oct 15, 2009 at 4:06 PM, Mark Mentovai m...@chromium.org wrote: I've been sheriffing for Munjal for the past hour, when I found the tree in a bad state. I'm happy to keep helping, but it'd be great if some other

[chromium-dev] Re: No co-sheriff today

2009-10-15 Thread Peter Kasting
On Thu, Oct 15, 2009 at 1:13 PM, Thomas Van Lenten thoma...@chromium.orgwrote: http://dev.chromium.org/developers/tree-sheriffs ...which is the top answer when you search for sheriff on dev.chromium.org. (Plug for automated tools) PK --~--~-~--~~~---~--~~

[chromium-dev] Re: bugtracker cleanup

2009-10-15 Thread Evan Martin
On Thu, Oct 15, 2009 at 12:41 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Today I reviewed some old bugs which didn't get any attention and tried to correctly mark/assign/close them. Feel free to reassign a bug if I assigned it to you - I was generally looking for people familiar with

[chromium-dev] Re: No co-sheriff today

2009-10-15 Thread Abubakar
oh. Thanks :) On Fri, Oct 16, 2009 at 1:13 AM, Thomas Van Lenten thoma...@chromium.orgwrote: http://dev.chromium.org/developers/tree-sheriffs On Thu, Oct 15, 2009 at 4:12 PM, Abubakar abubak...@gmail.com wrote: whats this sheriff thing can anyone explain :) ?I thought the first email was

[chromium-dev] WebKit Layouts bot pulling code from the canary?

2009-10-15 Thread Yaar Schnitman
The layout try bots are just too slow for the purposes of webkit gardening, which needs to keep up with the fast stream of layout test breakage coming from webkit.org. Gclient and compilation consume most of the time, but the gardener is usually only interested in the layout tests themselves. How

[chromium-dev] Re: [LTTF] Flaky tests and setTimeout

2009-10-15 Thread Julie Parent
Another class of layout tests with bad setTimeouts in them - Tests of the form: body onload=runTest(); img ... function runTest() { // Wait for img to load setTimeout(step2, 200); } These tests are not flaky, but the setTimeouts are completely unnecessary (body onload always fires AFTER the

[chromium-dev] Re: WebKit Layouts bot pulling code from the canary?

2009-10-15 Thread Julie Parent
Would another solution be to have canary bots for both release and debug? On Thu, Oct 15, 2009 at 1:58 PM, Yaar Schnitman y...@chromium.org wrote: The layout try bots are just too slow for the purposes of webkit gardening, which needs to keep up with the fast stream of layout test breakage

[chromium-dev] Re: WebKit Layouts bot pulling code from the canary?

2009-10-15 Thread Yaar Schnitman
That will help too. I've been missing On Thu, Oct 15, 2009 at 2:03 PM, Julie Parent jpar...@chromium.org wrote: Would another solution be to have canary bots for both release and debug? That will certainly help. I've rolled in test failures into our tree because the canaries didn't detect the

[chromium-dev] Re: [Mac] Chromium terminates when running from Terminal

2009-10-15 Thread Thomas Van Lenten
How exactly are you launching it? ie-what are you typing into the terminal. it might be the executable path change last night. TVL On Thu, Oct 15, 2009 at 6:07 PM, Mikhail Naganov mnaga...@chromium.orgwrote: Hi all, Starting from today, I can't run Chromium from Terminal, unless I'm

[chromium-dev] Re: [Mac] Chromium terminates when running from Terminal

2009-10-15 Thread Mark Mentovai
How are you launching it from the Terminal? Can you tell me the exact invocation? $PATH and working directory too? Can you log the value of path after PathService::Get(base::FILE_EXE, path) in chrome::GetVersionedDirectory(), chrome/common/chrome_paths_mac.mm:72? Mark Mikhail Naganov wrote:

[chromium-dev] Re: [Mac] Chromium terminates when running from Terminal

2009-10-15 Thread Mikhail Naganov
Also answering on Mark's question. $ pwd /Users/mnaganov/chrome/src/xcodebuild/Release/Chromium.app/Contents/MacOS $ ls -l total 40 -rwxr-xr-x 1 mnaganov eng 16472 Oct 16 01:25 Chromium $ echo $PATH

[chromium-dev] Change to default build architecture

2009-10-15 Thread Michael Moss
http://codereview.chromium.org/271113 may require a clobber for Linux builds. The default build used to be 32-bit, but it will now be whatever your build host architecture is. If you are on a 64-bit machine, and haven't explicitly been setting 'target_arch' in gyp, your build will switch from

[chromium-dev] Re: layout test dashboard goofup

2009-10-15 Thread Julie Parent
I actually have a copy of the data from Tuesday at 2:30pm. If you need any information out of the results page, just let me know. Julie On Thu, Oct 15, 2009 at 10:58 AM, Ojan Vafai o...@google.com wrote: I put some more thought into this. Given that we only store a month's worth of data,

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Glenn Wilson
Yes, possibly. The tool is written explicitly for the Chromium builders' output, so it would be plausible but non-trivial to generalize it. It may not be as useful since I don't think they have a concept of an 'upstream' baseline. Those of you who do a lot of work upstream, would it be worth

[chromium-dev] LTTF helping the GTTF make cycle times *minutes* faster

2009-10-15 Thread Ojan Vafai
There are a lot of tests that consistently (i.e. not flaky) timeout. They eat up significant percentage (~10%!) of the cycle time for the test bots (e.g., 1 minute on Windows release). If LTTF folk focus some effort on fixing these first, it would help all of us move forward faster as the bot

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Eric Seidel
One could show baselines of all the other platforms instead of just an upstream baseline. I'm not really sure from the output what this tool does. So it's difficult for me to tell how useful it would be to upstream. -eric On Thu, Oct 15, 2009 at 8:38 PM, Glenn Wilson gwil...@chromium.org

[chromium-dev] Re: LTTF helping the GTTF make cycle times *minutes* faster

2009-10-15 Thread Andrew Scherkus
I'll take on the media ones. On Thu, Oct 15, 2009 at 6:38 PM, Ojan Vafai o...@google.com wrote: There are a lot of tests that consistently (i.e. not flaky) timeout. They eat up significant percentage (~10%!) of the cycle time for the test bots (e.g., 1 minute on Windows release). If LTTF folk

[chromium-dev] Fwd: [webkit-dev] Visual Studio 2005 ATL Security Update

2009-10-15 Thread Eric Seidel
In case any of you who hack on WebKit aren't on webkit-dev. (If that's you, you should definitely join webkit-dev now. It's very very low traffic and very high signal to noise ratio.) -eric -- Forwarded message -- From: Brian Weinstein bweinst...@apple.com Date: Thu, Oct 15,

[chromium-dev] Re: Change to default build architecture

2009-10-15 Thread 鵜飼文敏
On x86_64 machine, I couldn't build even if I clobber.. /usr/bin/ld: skipping incompatible /usr/local/google/home/ukai/src/chromium1/src/sconsbuild/Release/lib/libnpGoogleNaClPluginChrome.a when searching for -lnpGoogleNaClPluginChrome /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome

[chromium-dev] Re: Change to default build architecture

2009-10-15 Thread Michael Moss
On Thu, Oct 15, 2009 at 8:59 PM, Fumitoshi Ukai (鵜飼文敏) u...@chromium.org wrote: On x86_64 machine, I couldn't build even if I clobber.. /usr/bin/ld: skipping incompatible /usr/local/google/home/ukai/src/chromium1/src/sconsbuild/Release/lib/libnpGoogleNaClPluginChrome.a when searching for

[chromium-dev] Re: LTTF helping the GTTF make cycle times *minutes* faster

2009-10-15 Thread Yuta Kitamura
I'm currently working on tests under LayoutTests/http/tests/navigation/. Thanks, Yuta 2009/10/16 Ojan Vafai o...@google.com There are a lot of tests that consistently (i.e. not flaky) timeout. They eat up significant percentage (~10%!) of the cycle time for the test bots (e.g., 1 minute on

[chromium-dev] Re: Change to default build architecture

2009-10-15 Thread Antoine Labour
On Thu, Oct 15, 2009 at 9:04 PM, Michael Moss mm...@chromium.org wrote: On Thu, Oct 15, 2009 at 8:59 PM, Fumitoshi Ukai (鵜飼文敏) u...@chromium.org wrote: On x86_64 machine, I couldn't build even if I clobber.. /usr/bin/ld: skipping incompatible

[chromium-dev] Re: LTTF helping the GTTF make cycle times *minutes* faster

2009-10-15 Thread Anton Muhin
I'll have a look at LayoutTests/fast/dom/Window/window-property-shadowing-name.html yours, anton. On Fri, Oct 16, 2009 at 8:13 AM, Yuta Kitamura yu...@chromium.org wrote: I'm currently working on tests under LayoutTests/http/tests/navigation/. Thanks, Yuta 2009/10/16 Ojan Vafai