[chromium-dev] Re: building with scons after r3597

2008-10-20 Thread Evan Martin
used to. There are other similar files, like test plugins etc. > > Paweł > > On 19 Paź, 21:36, "Evan Martin" <[EMAIL PROTECTED]> wrote: >> It appears after r3597 or so you can no longer run scons directly -- >> you'll get an error about component_se

[chromium-dev] Re: Wrap "Windows" specific call with OS macro

2008-10-21 Thread Evan Martin
Ibrar, What is the return value of that function? It has the "int" but its meaning ends up being platform-specific. I'd instead argue that there are two cases where GetLastError shows up: 1) Places where the code is checking for specific errors, in which case we'll need platform-specific tests

[chromium-dev] Re: New webkit merge underway

2008-10-23 Thread Evan Martin
When you have things looking mostly-ok (e.g. stuff links on Windows), can you send out a "will land again soon" warning so we can double-check it doesn't break the ports? On Wed, Oct 22, 2008 at 7:47 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > FYI, we have started the next webkit merge. This w

[chromium-dev] Re: Error: OverQuotaError; please report!

2008-10-24 Thread Evan Martin
The issue is known and they're looking into fixing it. Thanks for bringing it up! On Fri, Oct 24, 2008 at 2:46 AM, Ibrar Ahmed <[EMAIL PROTECTED]> wrote: > > Hi, > > I am getting this error message while updating my patch set. > > Error: OverQuotaError; please report! > > If this is a wrong list

[chromium-dev] avoiding checking into a closed tree with git-cl

2008-10-28 Thread Evan Martin
If you're using git-cl, it now can check whether the tree is closed automatically. (Thanks Tony!) 1) Pull a new git-cl. 2) Run "git cl config" again. It'll ask you for a tree status URL -- use http://chromium-status.appspot.com/current . 3) Two comands are affected: 3a) git cl tree # prints th

[chromium-dev] Re: Build problems on build 149.30

2008-10-29 Thread Evan Martin
Which platform? Can you paste the errors? On Wed, Oct 29, 2008 at 11:43 AM, Lucila-Nkt <[EMAIL PROTECTED]> wrote: > > I was able to sync the code to the last version and build without any > problems. > But now I can't build revision 4060 (build 149.30). The "icuuc" > project is unavailable and I

[chromium-dev] recent change causing v8 link errors

2008-10-30 Thread Evan Martin
If you get errors like these when building with scons: 2 g++ -o shell /home/jamessan/src/chromium/src/v8/obj/sample/shell/release/shell.o -L. -L/home/jamessan/src/chromium/src/v8 -lv8 -lpthread 3 /home/jamessan/src/chromium/src/v8/obj/sample/shell/release/shell.o: In function `ReadFil

[chromium-dev] wstring deprecated for paths; please use FilePath

2008-10-30 Thread Evan Martin
For cross-platform path strings we have a "FilePath" class that wraps a path, which is UTF-16 on Windows, UTF-8 on Mac, and bytes (UTF-8) on Linux. The theory is that 98% of the code doesn't need to reach inside a path. I've made the first change to start moving base code to use FilePaths. For

[chromium-dev] Re: Getting rid of toplevel scrollers?

2008-10-31 Thread Evan Martin
On Fri, Oct 31, 2008 at 8:07 AM, Brett Wilson <[EMAIL PROTECTED]> wrote: >> My only idea at the moment is to draw my scrollers on top of the OS >> ones, but that would be a bad hack... >> >> Any better idea would be greatly appreciated. > > This isn't easily possible. WebKit handles all the scroll

[chromium-dev] linux build instructions wikified

2008-10-31 Thread Evan Martin
As an experiment, I've moved the Linux build instructions to a world-writeable page here: http://code.google.com/p/chromium/wiki/LinuxBuildInstructions And I've added some hints on how to get the build working on 64-bit systems (special thanks to Graeme Humphries): http://code.google.com/p/chr

[chromium-dev] proposal: re-merge #chromium and #chromium-dev

2008-11-06 Thread Evan Martin
#chromium has almost no traffic and easily 90% of the traffic it does have are developer questions. I propose we kill off #chromium-dev in favor of just #chromium. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Chr

[chromium-dev] Re: proposal: re-merge #chromium and #chromium-dev

2008-11-07 Thread Evan Martin
OK, this has been done. On Thu, Nov 6, 2008 at 2:46 PM, Avi Drissman <[EMAIL PROTECTED]> wrote: > I thought that was the original plan, waiting until traffic died down. I'm > good with it. > > Avi > > On Thu, Nov 6, 2008 at 5:33 PM, Evan Martin <[EMAIL PROTEC

[chromium-dev] Re: sent from test shell on Linux!

2008-11-11 Thread Evan Martin
But not the enter key, last I checked -- I screwed up keyboard handling somewhere. :) Thanks for getting SSL to work! On Tue, Nov 11, 2008 at 2:02 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > Dude, gmail works in the test shell on Linux! > > > > --~--~-~--~~~---~--~

[chromium-dev] Re: sent from test shell on Linux!

2008-11-12 Thread Evan Martin
On Tue, Nov 11, 2008 at 2:22 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > I just did a shootout between test shell and firefox > on linux by pasting the SunSpider public URL in each. > Happily, it ran to completion on both. Just in case anyone else on the starts thinking about benchmarks: - Our dra

[chromium-dev] Re: Compiling with Visual Studio 2008

2008-11-12 Thread Evan Martin
On Wed, Nov 12, 2008 at 2:16 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > On Sun, Sep 21, 2008 at 10:20 AM, Marc-Antoine Ruel <[EMAIL PROTECTED]> wrote: >> If anyone feels to make webkit trunk compilable with VS2008 SP1, I'd >> recommend you to submit patches to them ASAP to reduce the likehood of

[chromium-dev] how keyboard input works

2008-11-12 Thread Evan Martin
I spent some time studying the keyboard code and talking with various people and here's how I think it should work. This discussion also likely generalizes to other events. Some background: keyboard events on different platforms work (surprise!) differently: - On Windows you get some events wh

[chromium-dev] building optimized on linux

2008-11-13 Thread Evan Martin
Build optimized binaries: hammer --mode=opt Hammer/test_shell See what flags are available: hammer --help I expect this to break occasionally, since we tend to fall afoul of the strict aliasing rule in various places. I added some TODO(port)s about it. Also, previous caveats about looking

[chromium-dev] using gold for faster linking

2008-11-18 Thread Evan Martin
gold is a new linker (coincidentally, written by engineers at Google) that is much faster than the standard binutils one. I wrote up some instructions on how to use it here: http://code.google.com/p/chromium/wiki/LinuxFasterBuilds Feel free to edit that it if I got any of my notes wrong, or add

[chromium-dev] Re: LayoutTests results under Linux

2008-11-19 Thread Evan Martin
On Wed, Nov 19, 2008 at 8:42 AM, Adam Langley <[EMAIL PROTECTED]> wrote: > > On Wed, Nov 19, 2008 at 6:09 AM, Mike Pinkerton <[EMAIL PROTECTED]> wrote: >> Awesome work! Probably just some re-basing needed to get the >> font/layout metrics correct for linux and you'll be right up where Mac >> is! >

[chromium-dev] Re: LayoutTests results under Linux

2008-11-19 Thread Evan Martin
On Wed, Nov 19, 2008 at 10:20 AM, Ojan Vafai <[EMAIL PROTECTED]> wrote: > On Wed, Nov 19, 2008 at 8:47 AM, Evan Martin <[EMAIL PROTECTED]> wrote: >> And I intend to look into getting our form control metrics matching >> Windows today as well. > > Are these lay

[chromium-dev] Re: LayoutTests results under Linux

2008-11-19 Thread Evan Martin
On Wed, Nov 19, 2008 at 10:34 AM, Evan Martin <[EMAIL PROTECTED]> wrote: > On Wed, Nov 19, 2008 at 10:20 AM, Ojan Vafai <[EMAIL PROTECTED]> wrote: >> On Wed, Nov 19, 2008 at 8:47 AM, Evan Martin <[EMAIL PROTECTED]> wrote: >>> And I intend to look into getti

[chromium-dev] running linux layout tests

2008-11-20 Thread Evan Martin
As mentioned in a previous thread, we now have enough infrastructure in place to run WebKit's layout tests on Linux. Here's a bit more info about how to get involved. If you build a test_shell executable the instructions on the development site are a good place to start: http://dev.chromium.or

[chromium-dev] Re: running linux layout tests

2008-11-21 Thread Evan Martin
f mismatch 12 test cases (0.4%) Test timed out 2 test cases (0.1%) Test shell crashed This is against Windows baselines, too -- we haven't rebaselined anything yet. Special props to Adam and Dean for figuring out how to make our font metrics match. On Thu, Nov 20, 2008 at 2:22 PM, Evan Martin &l

[chromium-dev] Re: chrome browser control for linux/osx

2008-11-25 Thread Evan Martin
On Sat, Nov 22, 2008 at 8:40 PM, Marshall Greenblatt <[EMAIL PROTECTED]> wrote: > For linux, there's quite a collection of COM/CORBA-like implementations: > http://linas.org/linux/corba.html Chromium is more interesting on Windows because there's no native Windows port of WebKit yet. On Linux, t

[chromium-dev] Re: MathML and math accessibility as a Chromium plugin

2008-12-01 Thread Evan Martin
The right place to put MathML support, I think, would be in WebKit. That way Safari and other browsers benefit too. The WebKit project has an open bug indicating they would like support: https://bugs.webkit.org/show_bug.cgi?id=3251 They also have a working patch for some preliminary support, it

[chromium-dev] Re: removing ATL dependencies from Chromium

2008-12-03 Thread Evan Martin
On Wed, Dec 3, 2008 at 10:24 AM, Peter Kasting <[EMAIL PROTECTED]> wrote: > On Tue, Dec 2, 2008 at 5:54 PM, Erik Kay <[EMAIL PROTECTED]> wrote: >> >> It would be nice to remove ATL/WTL dependencies from Chromium so that >> people can build it with Visual C++ Express. > > According to various webpa

[chromium-dev] linux test shell memory corruption

2008-12-03 Thread Evan Martin
I get nondeterministic crashes in the following small set of tests on Linux: ./webkit/tools/layout_tests/run_webkit_tests.sh --no-pixel-tests LayoutTests/fast/canvas/ Some notes: - doesn't occur in debug mode, only opt, but only some of the time - efence doesn't seem to work with test_shell in

[chromium-dev] Re: The review tool

2008-12-04 Thread Evan Martin
On Thu, Dec 4, 2008 at 4:45 PM, Elliot Glaysher (Chromium) <[EMAIL PROTECTED]> wrote: >> No, Dean is very much correct. "git cl upload" will upload your patch > to the review server and will accept git-diff style arguments > (including diffing against a sha1) or will build a patch going back to >

[chromium-dev] checking in linux expected images

2008-12-05 Thread Evan Martin
Due to font rendering differences (not in the metrics, but in the antialiasing/hinting) and form control differences (similarly, not in the layout, but in the rendering of e.g. shadows), we need a different set of expected images on Linux than Windows. We'd like to check in these images. However

[chromium-dev] Re: checking in linux expected images

2008-12-05 Thread Evan Martin
On Fri, Dec 5, 2008 at 2:41 PM, Peter Kasting <[EMAIL PROTECTED]> wrote: > On Fri, Dec 5, 2008 at 2:35 PM, Evan Martin <[EMAIL PROTECTED]> wrote: >> However, that will mean the chromium repo (under >> webkit/data/layout_tests/platform/chromium-linux) will grow by the

[chromium-dev] Re: UI proposal: Open link in new foreground tab

2008-12-07 Thread Evan Martin
On Sun, Dec 7, 2008 at 3:15 PM, Peter Kasting <[EMAIL PROTECTED]> wrote: > On Sun, Dec 7, 2008 at 1:31 PM, Ojan Vafai <[EMAIL PROTECTED]> wrote: >> >> Similarly , we could add a standard keyboard shortcut for open in a new >> foreground tab, e.g. shift+click opens in a new foreground tab. > > We a

[chromium-dev] Re: UI proposal: Open link in new foreground tab

2008-12-07 Thread Evan Martin
On Sun, Dec 7, 2008 at 1:10 PM, Adam Barth <[EMAIL PROTECTED]> wrote: > This has the cost of increasing the complexity of the context menu. > However, I believe the benefit of supporting the depth-first use case > outweighs this cost. Some thoughts on cost, both from user metrics*: 1) You could

[chromium-dev] Re: data resources and localized strings on linux

2008-12-08 Thread Evan Martin
- Is the plan to mmap the data file directly? Avoids copies, but means we should (a) null terminate the string resources (maybe the rc format does this already) and (b) sort the resource entries by resource id for faster lookup. - We should make explicit the byte order for the int32s. We can't

[chromium-dev] Re: Please announce via email when clobbers are required

2008-12-09 Thread Evan Martin
Do we need to clobber Mac builds on these announcements? (The SCons build has only needed clobbering once so far.) On Tue, Dec 9, 2008 at 9:34 AM, Mike Pinkerton <[EMAIL PROTECTED]> wrote: > > Hey everyone! > > Given that clobbers are sometimes a necessary and required part of our > build proces

[chromium-dev] Re: Extending Value with std::string support

2008-12-09 Thread Evan Martin
On Tue, Dec 9, 2008 at 1:58 PM, Andrew Scherkus <[EMAIL PROTECTED]> wrote: > Looking through some of the code again it gets a bit scary when there's code > checking for TYPE_WSTRING but not the other. > So how about: > CreateStringValue accepts std::string and std::wstring > SetString accepts std:

[chromium-dev] Re: run_webkit_tests changes

2008-12-10 Thread Evan Martin
Here's a git pre-commit hook. In .git/hooks/pre-commit: #!/bin/bash # Check if any files were touched under test_lists. diff_cmd="git diff-index --cached HEAD -- webkit/tools/layout_tests/test_lists" if $diff_cmd | grep -q .; then echo "Test lists changed; running linter..." ./webk

[chromium-dev] Re: User scripts design doc

2008-12-10 Thread Evan Martin
On Wed, Dec 10, 2008 at 3:53 PM, Erik Kay <[EMAIL PROTECTED]> wrote: > In general, my preference would be to have a single id for the > extension. Multiple id's seem to always end in pain and hurting. We > already have one id that we know we have to have - the public key. > This is what we're go

[chromium-dev] Re: Started on x509_certificate_nss.cc

2008-12-10 Thread Evan Martin
In r6591 I reverted a bit of your SSL work (sorry!) to eliminate some crashes. I'm not sure if it's the same thing, but if it isn't, please don't forget about it. On Wed, Dec 10, 2008 at 5:32 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > I've started porting x509_certificate to nss finally. > Don'

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Evan Martin
On Mon, Dec 15, 2008 at 12:14 PM, Aaron Boodman wrote: > It would be better if we could consult Google for spelling > recommendations. It seems like I frequently misspell a word, get the > red squiggly, get no recommendations from Chromium, then go to Google > and it gets it exactly right. The p

[chromium-dev] linux layout tests status

2008-12-16 Thread Evan Martin
Just so everyone's on the same page: As far as I know we're as close to Windows font metrics as we're gonna get. Using the Windows render tree baselines we're only 0.4% behind Windows. Most of that delta is probably stuff that we have that's really broken, and the font-related ones are likely s

[chromium-dev] Re: linux layout tests status

2008-12-16 Thread Evan Martin
On Tue, Dec 16, 2008 at 11:48 AM, Evan Martin wrote: > 2) Run them locally. E.g.: xargs ./run_webkit_tests.sh and then cut'n'paste a section from the failing list at the end of the buildbot output > 3) Verify that they are actually passing by comparing against the &g

[chromium-dev] Re: linux layout tests status

2008-12-16 Thread Evan Martin
On Tue, Dec 16, 2008 at 11:48 AM, Evan Martin wrote: > 2) Run them locally. One more gotcha: due to a bug our debug output is different than the opt output. Adam is fixing it. The builder is running opt, but we want debug output in our baselines. So run your tests locally with the de

[chromium-dev] Re: linux layout tests status

2008-12-16 Thread Evan Martin
On Tue, Dec 16, 2008 at 11:57 AM, Evan Martin wrote: > On Tue, Dec 16, 2008 at 11:48 AM, Evan Martin wrote: >> 2) Run them locally. > > One more gotcha: due to a bug our debug output is different than the > opt output. Adam is fixing it. > The builder is running opt, but

[chromium-dev] Re: linux layout tests status

2008-12-16 Thread Evan Martin
On Tue, Dec 16, 2008 at 11:48 AM, Evan Martin wrote: > Adam wrote a nifty fuzzy image differ that can highlight "meaningful" > diffs between images. It's in third_party/fuzzymatch and maybe he can > comment on how he uses it. With some recent changes, it should be suf

[chromium-dev] Re: list of webkit committers?

2008-12-16 Thread Evan Martin
On Tue, Dec 16, 2008 at 2:58 PM, Darin Fisher wrote: >> This doesn't work well for people in other time zones. I guess we can just >> keep with the webkit process. I wonder if there's a way we can be more >> reliable about getting patches committed within a work-day of them getting >> approved (e

[chromium-dev] Re: linux layout tests status

2008-12-16 Thread Evan Martin
On Tue, Dec 16, 2008 at 11:48 AM, Evan Martin wrote: > Tony set up a temporary pixel builder on his desktop, which Googlers > can access at go/chrome_linuxpixel ; hopefully that'll only be up > during the current period where we're trying to get the Linux pixel > tests

[chromium-dev] Re: Linux && ICU && OpenSuse 11.0

2008-12-17 Thread Evan Martin
On Wed, Dec 17, 2008 at 8:09 AM, giamas wrote: > Currently I'm working on compilation on opensuse 11.0 (I can't use an > Ubuntu as suggested in src/build/install-build-deps.sh ...). Cool! Please update the install instructions wiki with whatever information you find. > 1) The SVN repository do

[chromium-dev] confusing keyword searches

2008-12-17 Thread Evan Martin
Both Matt Cutts and Matt my roommate have recently been caught by useless bookmark keywords. Matt_1 wrote, in a list of things he didn't like about Chrome, 'If I start typing "Google webmaster blog" into the Omnibox, it offers to search Google for "webmaster blog"'. Matt_2 asked me how timeanddate

[chromium-dev] Re: confusing keyword searches

2008-12-17 Thread Evan Martin
." it would've been obvious to me, I think, though that's probably too long for what it does. On Wed, Dec 17, 2008 at 9:10 AM, Scott Violet wrote: > > I'm curious. Where did you expect to see bookmark keywords? Where did > you look first? > > -Scott > > On

[chromium-dev] Re: linux layout tests status

2008-12-18 Thread Evan Martin
On Tue, Dec 16, 2008 at 11:48 AM, Evan Martin wrote: > However, many of our image expected outputs need to be regenerated, > because the font antialiasing is slightly different. > Tony set up a temporary pixel builder on his desktop, which Googlers > can access at go/chrom

[chromium-dev] Re: Getting started, getting blocked...

2008-12-19 Thread Evan Martin
This was the behavior of an old gclient.py as well. How did you get gclient? On Fri, Dec 19, 2008 at 1:01 PM, Jaff wrote: > > Well, this is too strange. It would seem as if some other file-system > mechanism is cacheing > data. I created a new directory and attempted a fresh checkout, and it >

[chromium-dev] Re: Reducing bugginess with --enable-dcheck

2008-12-23 Thread Evan Martin
On Tue, Dec 23, 2008 at 10:24 AM, Peter Kasting wrote: > If you add "--enable-dcheck" to your app shortcut, you will turn on debug > checks throughout the code, even in release mode. Though I can imagine the historical evolution that led up to this, it's super-confusing that DCHECK, with a D imp

[chromium-dev] building with shared libraries

2008-12-25 Thread Evan Martin
I've checked in some changes that make it so you can build (on Linux) with shared libraries. This significantly reduces link times and overall build times at the cost of slower code and slower startup (i.e., you shouldn't use it for user-facing builds). == Background Chromium has historically bu

[chromium-dev] Re: Platform-dependent form control rendering in layout tests

2009-01-05 Thread Evan Martin
On Sun, Jan 4, 2009 at 10:14 PM, Brett Wilson wrote: > I just upgraded my dev box to one of the new quad-cores and put Vista > 64 on it so I can use more memory for the disk cache. (Note: XP64 > isn't one of the standard corp OS images.) I suspect more people will > want to start doing this (I'm

[chromium-dev] Re: HTTP BASIC/DIGEST BUG - Has it been fixed yet?

2009-01-05 Thread Evan Martin
It would help if you link to the bug in the bug tracker. I believe this message is in reference to http://code.google.com/p/chromium/issues/detail?id=1629 which has been marked fixed. On Mon, Jan 5, 2009 at 11:53 AM, HLS wrote: > > Excuse me? > > But how long will it take to fix this bug? I

[chromium-dev] Re: Stabilization Effort Daily Report

2009-01-06 Thread Evan Martin
On Mon, Jan 5, 2009 at 10:49 PM, Jon wrote: > The Layout Tests class went well. We are going to record it next week so > people can watch it on demand. Eric's slides are at > http://www.corp.google.com/~ericroman/layout/ I appreciate the enthusiasm! This isn't world-readable. Perhaps we sho

[chromium-dev] Re: What WebKit goodies do we get in 155?

2009-01-06 Thread Evan Martin
On Tue, Jan 6, 2009 at 12:17 PM, e. roman wrote: > > While not new to WebKit, Chromium's port now implements more of the > base features. > > For example, brettw recently added support for stroked/filled text, > and transformed form controls. > > Example: http://webkit.org/blog/85/introducing-tex

[chromium-dev] Re: test_shell and fonts

2009-01-06 Thread Evan Martin
On Tue, Jan 6, 2009 at 12:57 PM, Paweł Hajdan Jr. wrote: > I thought about bundling required fonts with the test_shell. I'm not > sure about the licensing issues, but this would probably solve these > technical problems. These fonts shouldn't change etc... What do you > think? All of the fonts b

[chromium-dev] Re: test_shell and fonts

2009-01-06 Thread Evan Martin
On Tue, Jan 6, 2009 at 1:52 PM, James Vega wrote: > - Use RedHat's Liberation fonts[0] The project under discussion is test_shell, which we use to verify our font metrics match those of Windows, so we must use the same fonts. For an actual browser we'll surely use whichever fonts are on the use

[chromium-dev] Re: New Wiki Page for LinuxBuildInstructions

2009-01-06 Thread Evan Martin
I'm sorry I didn't comment earlier, but I was away for the holidays. Thanks for writing the pages. I've overwritten the previous build instructions with your new LinuxBuildInstructionsMainPage and fixed up the English a bit. To anyone on chromium-dev: the wiki is editable by anyone, so please g

[chromium-dev] Re: Stabilization Effort Daily Report

2009-01-09 Thread Evan Martin
On Fri, Jan 9, 2009 at 11:32 AM, Jon wrote: > Be sure to sign up > at http://spreadsheets.google.com/ccc?key=pMwul3Seofg448Q1VFJjsJA&hl=en if > you are going to work on a layout test. We don't want to step on each > other's toes. I just noticed Linux is on there. Has anyone else been working o

[chromium-dev] Re: [chromium-checkins] r4633 - in trunk/src/chrome: app browser browser/importer browser/views

2009-01-12 Thread Evan Martin
FYI, the fix is to instead use const char Toolbar5Importer::kUrlXmlTag[] = "url"; On Mon, Jan 12, 2009 at 2:11 PM, Dean McNamee wrote: > > This added a bunch of startup time static initializers. Specifically > there are many things like: > > const std::string Toolbar5Importer::kUrlXmlTag = "ur

[chromium-dev] linux meeting notes

2009-01-12 Thread Evan Martin
Hi, Some of the people working on Linux have set up a weekly meeting* to sync up. I put some meeting notes up here: http://code.google.com/p/chromium/wiki/LinuxWeeklyNotes I likely won't announce future updates to it, so try checking back in a week or so if you're really interested. * It's a

[chromium-dev] Re: dtrace and chromium?

2009-01-13 Thread Evan Martin
This may be naive, but I expect what we have right now ought to be pretty close to working on Solaris anyway. It might be quicker to just fix the few places it doesn't work. (I wouldn't normally expect this of a Linux port of software in general, but we're also sharing all this code with OS X so

[chromium-dev] Re: Qt now a possibility?

2009-01-14 Thread Evan Martin
On Wed, Jan 14, 2009 at 9:15 AM, andrewg wrote: > I am sure most of you have seen the news by now that Qt is switching > from GPL to LGPL licensing. Does this increase the chances of a Qt > Chrome on Linux instead of GTK or has too much work already been > completed on the Linux GUI? I'm no lawy

[chromium-dev] Re: Qt now a possibility?

2009-01-14 Thread Evan Martin
On Wed, Jan 14, 2009 at 9:50 AM, andrewg wrote: > > On Jan 14, 11:44 am, Evan Martin wrote: >> I'm no lawyer, but it appears there was already an exception list[1] >> for the GPL-licensed code that would've covered us anyway? So I >> believe this LGPL thing

[chromium-dev] fixing CommandLine

2009-01-14 Thread Evan Martin
Our CommandLine class is very confusing -- it is not a class for working with command lines, but in fact a stealth singleton that wraps the command line used to start the process. Further, since it came from Windows, it does all this string-munging and quoting that is not necessary on OS X or Linu

[chromium-dev] Re: fixing CommandLine

2009-01-14 Thread Evan Martin
On Wed, Jan 14, 2009 at 9:28 PM, Brett Wilson wrote: > I'm on the fence about this builder class since it somehow feels like > overkill for this application. I intend to update the existing switch-appending functions so it will hopefully be about the same amount of code as before (which uses a c

[chromium-dev] Re: Qt now a possibility?

2009-01-15 Thread Evan Martin
On Thu, Jan 15, 2009 at 10:37 AM, cpu wrote: > When Dean and Evan say that they don't mind reviewing patches for Qt > ports, what we are saying is that > we don't mind having two UI versions of Chromium on linux? > > How would this work in the long term? UI tests times 2? you get to > choose what

[chromium-dev] Re: OSX 10.4 and PPC support?

2009-01-15 Thread Evan Martin
On Thu, Jan 15, 2009 at 3:04 PM, Peter Kasting wrote: >> Also, on a related note, are there also any plans for supporting the >> PPC architecture in the future? > > Almost certainly not going to happen. To clarify: v8 depends on x86 and porting to a new architecture is a lot of work. --~--~

[chromium-dev] Re: Making sense of startup

2009-01-15 Thread Evan Martin
On Thu, Jan 15, 2009 at 3:06 PM, Brett Wilson wrote: > > On Thu, Jan 15, 2009 at 2:06 PM, Erik Kay wrote: >> The issue is one of maintenance. A lot happens at startup. As people >> make changes, it's not necessarily obvious where to insert your >> initialization code. Depending on your depend

[chromium-dev] stubbing out code

2009-01-15 Thread Evan Martin
When you #ifdef around some code to make things temporarily link, but know that you'll need to bring that code (or its functional equivalent) back at some point, please mark those points carefully. I fear that we'll eventually have everything building and linking together at some point and it'll

[chromium-dev] Re: Announcing the release of ChromeWatir

2009-01-19 Thread Evan Martin
On Mon, Jan 19, 2009 at 2:06 AM, sai wrote: > We are happy to announce that the first version of ChromeWatir has > been released. The API follows a similar convention to Watir (http:// > wtr.rubygorge.org) for Google Chrome browser. Please visit the > ChromeWatir Google code > website for more de

[chromium-dev] Re: gcl warnings about missing build system updates

2009-01-22 Thread Evan Martin
It would be nice if these lint-y sorts of tools could be ran independently of gcl, so that our git tools could make use of them. 2009/1/22 Pam Greene : > The new gcl warning for missing unit tests currently only appears on 'gcl > change', but the plan is to set up a generic alert system so gcl ca

[chromium-dev] faster linux iterative builds

2009-01-22 Thread Evan Martin
Combining hammer --interactive and LOAD flags cuts my iterative build time down significantly. I highly recommend it. If you're hacking on WebKit stuff usually you'll only need LOAD=webkit. I updated http://code.google.com/p/chromium/wiki/LinuxFasterBuilds with more info. --~--~-~--~---

[chromium-dev] Re: Inconsistent patching in WTL

2009-01-23 Thread Evan Martin
I haven't read this thread in detail, but for you I just pulled this page out of our internal docs (there are only a few left that haven't yet made it to the public site). Hope it's helpful: http://sites.google.com/a/chromium.org/dev/developers/design-documents/graphics-and-skia If anyone else

[chromium-dev] Re: select option popup menu

2009-01-23 Thread Evan Martin
If we're to obey the system theme, then it's possible the theme specifies a static image to be used for these controls, in which case it's impossible to tint it red. I wonder if we should just fall back on the theme-ignorant drawing code if the control is styled at all. On Fri, Jan 23, 2009 at 2

[chromium-dev] Re: How to Learn WebKit

2009-01-23 Thread Evan Martin
A good place to start would be asking the WebKit team, rather than Chromium. (Some people work on both.) See http://webkit.org for documentation and contact info. On Fri, Jan 23, 2009 at 3:10 PM, giamas wrote: > > Hi to all, > I need some help. > I want to learn WebKit API. > How can I start? >

[chromium-dev] Re: How to speed up building of chrome.dll?

2009-01-26 Thread Evan Martin
To clarify, links that take 3-5 minutes happen to me too. Marc-Antoine was suggesting some ideas to help make them faster, but 3-5 minutes is within the range of "there's probably nothing particularly wrong aside from Chromium being enormous". On Mon, Jan 26, 2009 at 7:15 AM, Marc-Antoine Ruel w

[chromium-dev] [linux] plugin info caching

2009-01-27 Thread Evan Martin
I'd been sending this sort of stuff to Dean and John but maybe other people will find it interesting. Plugin loading works in two phases: - at startup, we scan the plugin directories for metadata, like plugin names and which mime-types they apply to; - at runtime, when we're asked for a specific

[chromium-dev] linux: the views situation

2009-01-28 Thread Evan Martin
Chromium's UI is done with an internal library called "views", which currently is effectively an abstraction around the (kinda impoverished) Windows APIs for doing layout of widgets. Effectively, views manages double-buffering of drawing, Windows widget positioning, and widgets not provided by Wi

[chromium-dev] linux: tabs on top

2009-01-28 Thread Evan Martin
(This is discussion of the UI independent of how it's implemented with views or not.) On Linux the window frame, if one even exists, is managed and drawn by a different process than the application. Additionally, people use a variety of window managers and so there's no guarantees for the way a

[chromium-dev] Re: linux: tabs on top

2009-01-28 Thread Evan Martin
On Wed, Jan 28, 2009 at 1:05 PM, Michael Moss wrote: >> 2) Give up, and just make the tabs flush with the top of the window we >> have. This is probably ugly in the general case (since there will be >> an edge between the title bar and tabs), but will work in all >> situations. > > I'm not sure

[chromium-dev] Re: Accessing popup window URL from WebViewDelegate::CreateWebView()

2009-01-28 Thread Evan Martin
This isn't exactly what you want, but it might help: The new tab page wants all links it opens to be opened in a new process (to help avoid potential leakage of private data due to unanticipated bugs from the new tab page into the page you're opening). So it blocks webkit loading of URLs and ins

[chromium-dev] Re: linux: tabs on top

2009-01-28 Thread Evan Martin
On Wed, Jan 28, 2009 at 2:19 PM, Michael Moss wrote: > On Wed, Jan 28, 2009 at 1:32 PM, Amanda Walker wrote: >> I'm a casual linux-desktop user at best (mostly I ssh to Linux boxen), >> but a Chromium-XP style window frame doesn't strike me as too out of >> place on, say, an Ubuntu desktop as lo

[chromium-dev] Re: Layout test expectations and fallbacks

2009-01-29 Thread Evan Martin
In the past, when we were tracking v8 and kjs baselines, I believe we did have a "common" output dir for tests that matched. The problem then becomes there are a lot of different places to look for a given layout test output. I use a little shell script already so it wouldn't bother me much. *s

[chromium-dev] Re: linux: tabs on top

2009-01-29 Thread Evan Martin
On Thu, Jan 29, 2009 at 10:04 AM, Michael wrote: > It would however be nice and if there was an "easy" way to change the > look of the window deco, primarily the min/max/close buttons. Are > those bitmaps at the moment? Yes. Changing the window color is an idea that's been tossed around but nev

[chromium-dev] Re: linux: the views situation

2009-01-29 Thread Evan Martin
On Thu, Jan 29, 2009 at 10:32 AM, Paweł Prażak wrote: > On Jan 28, 10:18 pm, "Ben Goodger (Google)" wrote: >> First of all let me generally comment that this entire situation is a >> clusterf*ck. I am not happy with the technical constraints imposed by >> Linux and its assorted UIs on Chrome's U

[chromium-dev] Re: New tab -window

2009-01-30 Thread Evan Martin
Currently, I believe we weight clicks on the new tab page and from typing into the omnibox equally. The ranking code there is pretty arbitrary and could definitely use some love. See http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visitsegment_database.cc search for ::Quer

[chromium-dev] Re: Reviewing commit messages

2009-02-03 Thread Evan Martin
On Tue, Feb 3, 2009 at 8:53 AM, Wan-Teh Chang wrote: > Re: typos/spelling errors: I recently started to fix typos/spelling > errors in the description of a CL I'm reviewing by clicking "Edit Issue". > (Rietveld allows a reviewer to edit the description of a CL.) Actually, I think it's a custom h

[chromium-dev] using string16

2009-02-03 Thread Evan Martin
[A bunch of the team met up today to hammer out some decisions.] In brief: for strings that are known to be Unicode (that is, not random byte strings read from a file), we will migrate towards using string16. This means all places we use wstring should be split into the appropriate types: - byt

[chromium-dev] Re: build problem (chromium.r9040.tar.gz)

2009-02-03 Thread Evan Martin
You must use gclient sync to check out. What is the URL for the build instructions were you following? I can fix them. On Tue, Feb 3, 2009 at 6:04 PM, DeArto20 wrote: > > I have downloaded r9040 tar-ball from the chromium web site and built > it in VS2005 > (Before building it, I have removed

[chromium-dev] Re: using string16

2009-02-04 Thread Evan Martin
On Wed, Feb 4, 2009 at 6:53 AM, Dean McNamee wrote: > I apologize for missing this discussion, I'm sure that I'm not seeing > the entire picture and the pros of this argument. I mentioned before > that I'm in support of utf-8 everywhere we can get it. I lost this argument, so I will defer this

[chromium-dev] writing native views code on linux

2009-02-04 Thread Evan Martin
[A bunch of the team met up yesterday to hammer out some decisions.] I think we decided to try to not port the views system, but instead borrow as much code as possible from on top of it. Some considerations that I think played into it (I had argued for this one, so I apologize if I mischaracter

[chromium-dev] Re: build problem (chromium.r9040.tar.gz)

2009-02-04 Thread Evan Martin
On Wed, Feb 4, 2009 at 10:31 AM, noemata wrote: > Surely, it's not that hard to have three sets of archives that provide > a complete snapshot of a working build environment. Internal to > Google, you must gen these anyways, so what's the issue? All such > archives should deliver a built versio

[chromium-dev] Re: [linux] stracing chrome binaries

2009-02-04 Thread Evan Martin
On Wed, Feb 4, 2009 at 3:22 PM, Brett Wilson wrote: > Can you add this to the build page or some Linux environment setup page? Probably this one is good: http://code.google.com/p/chromium/wiki/LinuxBuild64Bit Since it's where we put all of the hacks you need to do for 64-bit. --~--~-~

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread Evan Martin
I fear we have a have a couple long threads of headers that touch everything. At one point we had something like: v8 bindings -> stats table -> process_util -> process, which meant if you touched any of our process-management code we'd rebuild all of WebKit's SVG bindings. :~( For an especially

[chromium-dev] Re: [extensions] Extension Process Model Draft

2009-02-05 Thread Evan Martin
I know that "user scripts" has a known meaning, but in the context of this code it is a rather strange name. // these two are loaded into the extension process chrome_scripts: ["chrome/main.js"], toolstrip: "chrome/toolstrip.html", // this is loaded into renderers user_scripts: { Have

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread Evan Martin
On Thu, Feb 5, 2009 at 4:35 PM, Lei Zhang wrote: > I did the same with -MM and parsed the results. Assuming I did it > right, the average .cc file in src/chrome/ includes about 135 header > files. The files with the most number of includes: > > 440 about_chrome_view.o > 470 options_window_view.o

[chromium-dev] Re: This week's porting progress!

2009-02-07 Thread Evan Martin
We have a 511mb executable that brings up an empty window. On Fri, Feb 6, 2009 at 11:41 PM, Stinger wrote: > > Well, get on it, Linux people. > > On Feb 5, 7:23 pm, Mike Pinkerton wrote: >> Just wanted to give a quick update on the progress we've made over the >> last week in the mac/linux port

  1   2   3   4   5   6   7   8   >