[chromium-dev] Re: Endlessly Checking For Updates

2008-09-18 Thread Peter Kasting
On Thu, Sep 18, 2008 at 2:51 PM, Jiriteach [EMAIL PROTECTED] wrote: After updating Chrome to 0.2.152.1, heading over to Tools About Chrome, it starts checking for updates. Except this keeps going and going! Any one experiencing this same problem? Yes, everyone using 152.1. A fix is in

[chromium-dev] Re: Proposal for Visual changes to Chrome.

2008-10-01 Thread Peter Kasting
Please bring up proposals like this on chromium-discuss, so we can keep chromium-dev restricted to the nuts and bolts of development issues. PK --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Chromium-dev group. To

[chromium-dev] PSA: Review mail best practices

2008-10-08 Thread Peter Kasting
Two recommendations for folks participating in code reviews using Rietveld ( codereview.chromium.org): (1) When uploading a patch, make sure you Edit Issue and add at least one review email; then use the Publish+Mail Comments link (with a blank body, usually) to send out the review request. When

[chromium-dev] Re: to TBR or not to TBR

2008-10-10 Thread Peter Kasting
On Fri, Oct 10, 2008 at 3:50 PM, Ojan Vafai [EMAIL PROTECTED] wrote: I'd love to hear from people who disagree about these proposed policies so we can compromise on something everyone is happy with. I tend to think anybody should be able to do anything TBR if they have a good reason. I'm

[chromium-dev] Re: text zoom vs full page zoom

2008-10-14 Thread Peter Kasting
On Tue, Oct 14, 2008 at 4:05 PM, Glen Murphy [EMAIL PROTECTED] wrote: Like Evan, I'm not at all a fan of changing the page layout for a normal range of text size changes - sometimes I change font size temporarily just to read something quickly, and having the page relayout as a consequence

[chromium-dev] Re: Autofill design document

2008-10-15 Thread Peter Kasting
On Wed, Oct 15, 2008 at 9:09 AM, Ian Fette [EMAIL PROTECTED] wrote: It sounds like you want to have form autofill, but not actually fill stuff in until the user hits submit. While nice in theory, I'm not sure how you exactly get this to work without causing unintended consequences. E.g. there

[chromium-dev] Re: Chrome Bookmarks/Passcards

2008-10-19 Thread Peter Kasting
On Sun, Oct 19, 2008 at 2:43 PM, Chris G [EMAIL PROTECTED] wrote: As you surf the web nothing will ever be filled, and you need never know the passcard system is at work! However as you surf the browser will scan its passcards and if there is one matching the current page a button will light

[chromium-dev] Re: Checkin to help decide which default memory model is best

2008-10-19 Thread Peter Kasting
On Sun, Oct 19, 2008 at 9:16 PM, Jim Roskind [EMAIL PROTECTED] wrote: Note this code is not yet pushed to either Google Chrome's dev channel, nor beta channel. I've only landed this on the Chromium tip-of-tree thus far. It is possible that we'll get enough good data that we won't even need to

[chromium-dev] Re: Chrome Bookmarks/Passcards

2008-10-20 Thread Peter Kasting
On Mon, Oct 20, 2008 at 4:21 PM, Chris G [EMAIL PROTECTED] wrote: On Oct 20, 6:29 pm, Peter Kasting [EMAIL PROTECTED] wrote: I didn't mean that they were different HTML (although they can be), but rather that users perceive them as having different functions. This perception is what I (we

[chromium-dev] Re: Chrome Bookmarks/Passcards

2008-10-20 Thread Peter Kasting
On Mon, Oct 20, 2008 at 6:38 PM, Chris G [EMAIL PROTECTED] wrote: Ok so where are we? Close to ending this thread, as it doesn't seem to be going anywhere. I don't have the time or energy to continue replying, so this will probably be my final response. Is there any agreement we can reach

[chromium-dev] Re: New webkit merge underway

2008-10-23 Thread Peter Kasting
On Wed, Oct 22, 2008 at 7:47 PM, Darin Fisher [EMAIL PROTECTED] wrote: If you make any changes to third_party/WebKit, please prepare an additional CL to port your change to the merge branch. Your changes will be lost if you do not do this! The merge branch is located here:

[chromium-dev] Re: Simple Browser / Rendering Engine

2008-11-22 Thread Peter Kasting
On Sat, Nov 22, 2008 at 11:17 AM, Daniel [EMAIL PROTECTED] wrote: Basically, I'd like to create a build of chromium that has all the bells and whistles removed, but still keeps all the core functionality. Does such a build configuration already exist somewhere? If not, any advice on

[chromium-dev] Re: MathML and math accessibility as a Chromium plugin

2008-12-02 Thread Peter Kasting
On Tue, Dec 2, 2008 at 8:06 AM, PaulTopping [EMAIL PROTECTED] wrote: As far as I know, NPAPI requires that the amount of space the equation takes up on a page be known in advance, rather than be calculated at run-time to be dependent on the MathML content. There is no support for baseline

[chromium-dev] Re: MathML and math accessibility as a Chromium plugin

2008-12-02 Thread Peter Kasting
On Tue, Dec 2, 2008 at 10:30 AM, PaulTopping [EMAIL PROTECTED] wrote: It was my hope that others would read this and think of problems it might solve. SVG support could be done this way, as I suggested. In general, I think it leads to a more modular approach to browser architecture. It would

[chromium-dev] Re: Accessibility design doc

2008-12-02 Thread Peter Kasting
On Tue, Dec 2, 2008 at 3:55 PM, Jonas Klink (Google) [EMAIL PROTECTED]wrote: It seems as if we are now doing a good job of supporting Large/Extra Large Fonts all through the UI There are limits; for example, once you make your fonts dramatically bigger than the defaults, the omnibox starts

[chromium-dev] Re: removing ATL dependencies from Chromium

2008-12-03 Thread Peter Kasting
On Tue, Dec 2, 2008 at 5:54 PM, Erik Kay [EMAIL PROTECTED] wrote: It would be nice to remove ATL/WTL dependencies from Chromium so that people can build it with Visual C++ Express. According to various webpages whose instructions I have not personally tested (e.g.

[chromium-dev] Re: removing ATL dependencies from Chromium

2008-12-03 Thread Peter Kasting
On Wed, Dec 3, 2008 at 10:45 AM, Nicolas Sylvain [EMAIL PROTECTED]wrote: Opening the try servers externally is tricky. If the patch is sent by a malicious users, it means that they can run arbitrary code in our test environment, which is not good. Yes, I think that's the issue we'd have to

[chromium-dev] Re: MathML and math accessibility as a Chromium plugin

2008-12-05 Thread Peter Kasting
On Fri, Dec 5, 2008 at 9:09 AM, PaulTopping [EMAIL PROTECTED] wrote: Isn't NPAPI considered somewhat dead technology? Supported but not a venue for enhancement. No, there is a group dedicated to enhancing it, and proposals for how to improve things. It doesn't get as much attention as a lot

[chromium-dev] Re: Extending Value with std::string support

2008-12-08 Thread Peter Kasting
On Mon, Dec 8, 2008 at 5:28 PM, Andrew Scherkus [EMAIL PROTECTED]wrote: 1) Overload CreateStringValue, GetAsString, etc.. to also accept std::string. Add TYPE_UTF8_STRING to ValueType enum. 2) Overload CreateStringValue, GetAsString, etc.. to also accept std::string. TYPE_STRING becomes

[chromium-dev] Re: Extending Value with std::string support

2008-12-09 Thread Peter Kasting
On Mon, Dec 8, 2008 at 8:09 PM, Brett Wilson [EMAIL PROTECTED] wrote: Be careful because wstring != UTF16String. Yes, hence the need to be very explicit about what these functions actually do (since you can't infer things from types alone). In other places of the code, we use GetWString,

[chromium-dev] Re: UI proposal: Open link in new foreground tab

2008-12-11 Thread Peter Kasting
On Thu, Dec 11, 2008 at 7:28 AM, Mike Pinkerton pinker...@chromium.orgwrote: My point is that I shouldn't have to convince you. Your style of surfing the interwebs is different than mine and no amount of discussion is going to change how either of us surf the web. Let me have my preference.

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 8:06 AM, Darin Fisher da...@chromium.org wrote: Don't you still need to engage some of webkit's code to ensure that space is made for the resizer (when there is only a vertical scrollbar)? He's doing that. (I was confused on this point too.) This requires providing a

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 10:12 AM, Peter Kasting pkast...@google.com wrote: The status bubble is overkill for this; it was a separate window mainly so it could move outside the main browser bounds as needed. Bah, I was wrong. Another issue is that the content area has its own HWND. If you

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 1:27 PM, Evan Martin e...@chromium.org wrote: The problem isn't technical, it's that to do that spell correction it'd involve sending all text form data up to a Google server. Only misspelled words, right? PK --~--~-~--~~~---~--~~ You

[chromium-dev] Re: Trunk build's biggest annoyances?

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 4:50 PM, Mark Larson (Google) m...@chromium.orgwrote: So... what are the 1-3 top issues you think need to get fixed on trunk to make it bearable for everyday use? Maximized mode is pretty awful in XP and Vista non-Aero. PK

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 4:50 PM, Darren Horrocks killallthehum...@gmail.com wrote: and as most people will only use the bookmark bar to access the other bookmarks button, Do you have data to back up this claim? PK --~--~-~--~~~---~--~~ You received this

[chromium-dev] Re: Feature: Extra field to store tags for each bookmark item

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 8:19 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Would be nice to add another field such as Tag (or Label), where we could tag our own bookmarks. I think we've generally agreed internally that this has at least some utility, but we haven't been as sure how to

[chromium-dev] Re: Extensions and profiles

2008-12-16 Thread Peter Kasting
On Tue, Dec 16, 2008 at 5:34 PM, Aaron Boodman a...@chromium.org wrote: Any thoughts, either on advantages or disadvantages to installing extensions per-chrome install, or to assuming that there is only one profile per browser process? From a user perspective, I would very much want

[chromium-dev] Re: Extensions and profiles

2008-12-16 Thread Peter Kasting
On Tue, Dec 16, 2008 at 5:50 PM, Mike Belshe mbel...@google.com wrote: My thought is that extensions should not apply in the incognito mode. I don't know. From my perspective as a user, incognito is more like a flag I temporarily set on my current window/profile, rather than a different

[chromium-dev] Re: Design for subscribing to feeds

2008-12-16 Thread Peter Kasting
On Tue, Dec 16, 2008 at 6:11 PM, Ian Fette i...@chromium.org wrote: 1. Does it really make sense to show the RSS icon for all users, or is there a way to only have it show up for people who actually use RSS feeds? (Not sure how to define those users, maybe we recognize that they have a reader

[chromium-dev] Re: confusing keyword searches

2008-12-17 Thread Peter Kasting
On Wed, Dec 17, 2008 at 9:06 AM, Evan Martin e...@chromium.org wrote: I believe both of these were caused by importing search keywords from Firefox. Yes. In at least the latter case, Matt_2 was unaware that the time keyword even existed on his Firefox (I think it might have been part how

[chromium-dev] Re: Design for better supporting bookmarklets

2008-12-17 Thread Peter Kasting
On Wed, Dec 17, 2008 at 10:23 AM, t...@chromium.org wrote: Should Create App Shortcut or Save Page As be in the same place as Email/Print? I kind of wondered this too, and proposed (verbally) to Nick that we could split the existing Page menu into two menus, and put all these sorts of things

[chromium-dev] Re: Extensions and profiles

2008-12-17 Thread Peter Kasting
On Wed, Dec 17, 2008 at 10:44 AM, Darin Fisher da...@chromium.org wrote: Absolutely... extensions should be able to store data in the profile. I think that issue is orthogonal to where the extensions get installed. Is it orthogonal to where Chrome itself is installed? i.e. if we have two

[chromium-dev] Re: Modal dialogs in Chrome

2008-12-18 Thread Peter Kasting
On Thu, Dec 18, 2008 at 11:11 AM, Darin Fisher da...@chromium.org wrote: I don't see how the UI for a seemingly random set of tabs being blocked by a dialog in one tab could be done in a reasonable fashion. It seems like it would be really confusing UI :-) I agree in principle; in practice

[chromium-dev] Re: Modal dialogs in Chrome

2008-12-18 Thread Peter Kasting
On Thu, Dec 18, 2008 at 11:25 AM, Darin Fisher da...@chromium.org wrote: This idea is similar to what happens today when one tab runs a synchronous XMLHttpRequest that takes a long time to complete. The other tabs in the same renderer become mysteriously unresponsive. (I would love to do

[chromium-dev] Re: Omnibar

2008-12-19 Thread Peter Kasting
On Fri, Dec 19, 2008 at 10:41 AM, Alex Russell slightly...@google.comwrote: The concrete suggestion might not be what we want, but the problem surely sounds valid, no? We have a UI that returns things by type and we don't have anything other than linear navigation to get past one type and to

[chromium-dev] Re: How do you like to view View Source?

2008-12-19 Thread Peter Kasting
On Fri, Dec 19, 2008 at 5:27 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Currently, this is what happens when you view source: Right Click: * Tab - Opens a new tab with source * Application - Finds a window that has tabs, and opens view source there. * Popup -

[chromium-dev] Reducing bugginess with --enable-dcheck

2008-12-23 Thread Peter Kasting
Previously on this list, we have been urged to build and use the trunk to shake out problems. But what if you don't have or don't want to keep a trunk build updated and running? How can you make things better as a 1.0 release branch user? If you add --enable-dcheck to your app shortcut, you will

[chromium-dev] Re: Adding MouseRelease Events for Buttons?

2008-12-25 Thread Peter Kasting
On Wed, Dec 24, 2008 at 8:35 PM, Mohamed Mansour m0.interact...@gmail.comwrote: the way it works now is by executing the following: controller_-AddManagedButton(reload_, IDC_RELOAD); That line of code is letting the CommandHandler manage key events and mouse events. But I want to be able

[chromium-dev] Re: Is Chrome App-Mode discoverable?

2009-01-07 Thread Peter Kasting
On Wed, Jan 7, 2009 at 4:34 PM, Brian Rakowski br...@chromium.org wrote: There's not currently, but we have considered it several times. I don't remember any arguments against it other than we weren't sure if it was going to be necessary. The main argument against it (IIRC) was that we were

[chromium-dev] Re: Context menu for title bar doesn't appear when a tab's context menu was open

2009-01-09 Thread Peter Kasting
On Fri, Jan 9, 2009 at 6:13 AM, DeArto20 sy3...@gmail.com wrote: The following is the reply written by me on bugtracker - Issue 5695. So... why are you mailing it to this list? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Making sense of startup

2009-01-14 Thread Peter Kasting
On Tue, Jan 13, 2009 at 11:56 PM, Ben Goodger (Google) b...@chromium.orgwrote: It looks like everyone and their dog adds init code to the startup sequence. This takes the form of first time initialization, command line switch parsing, etc. Is there any special reason why it's done in the

[chromium-dev] Re: Adding an existing child to a parent view... should it crash?

2009-01-19 Thread Peter Kasting
On Mon, Jan 19, 2009 at 3:19 PM, Marc-Andre Decoste m...@chromium.orgwrote: I got a crash while playing with new code and I wonder if we should fix the view parenting code to avoid this. The problem happens when you try to add a child view to a parent view that already has this view as a

[chromium-dev] Re: linux: the views situation

2009-01-28 Thread Peter Kasting
On Wed, Jan 28, 2009 at 11:56 AM, Evan Martin e...@chromium.org wrote: Options, as I see them: 1) As close to Windows as possible, porting views. 2) As close to native as possible, avoiding views. 3) Something in the middle, hacking views. (2) and (3) both sound better to me than (1), too.

[chromium-dev] Re: linux: tabs on top

2009-01-28 Thread Peter Kasting
On Wed, Jan 28, 2009 at 1:17 PM, Evan Martin e...@chromium.org wrote: Sorta like this screenshot: http://userstyles.org/styles/11000 LOL @ that guy's lousy attempt to blur out Warez-BB.org. I bet he's just getting Linux ISOs. PK --~--~-~--~~~---~--~~

[chromium-dev] Re: Fehler in der Chrome Konsole Bitte weiterleiten an Entwicklungsteam Chrome!

2009-01-29 Thread Peter Kasting
2009/1/29 Lutz B lutz.behre...@gmail.com Fehler in der Chrome Konsole Bitte weiterleiten an Entwicklungsteam Chrome! Can you please file (or have the original author here file) a bug at our public bug tracker? Just go to crbug.com. Please provide the details of the error on that bug. I

[chromium-dev] Re: New tab -window

2009-01-30 Thread Peter Kasting
On Thu, Jan 29, 2009 at 11:43 PM, Simon B. simon.boh...@gmail.com wrote: I have a bunch of everyday-links (intranet...) that require lots of typing Seems like inline autocomplete in the address bar still ought to get you to these with a few keystrokes? PK

[chromium-dev] Re: Meeting Notes From 2/9/2009 Now Posted!

2009-02-11 Thread Peter Kasting
On Tue, Feb 10, 2009 at 6:19 PM, Glenn Wilson gwil...@chromium.org wrote: Meeting notes from February 9, 2009 are now posted on the Chromium developer documentation: http://sites.google.com/a/chromium.org/dev/developers/meeting-notes#02092009 Please contact me if you have any questions, and

[chromium-dev] Re: staying on top of layout tests

2009-02-19 Thread Peter Kasting
On Thu, Feb 19, 2009 at 3:56 PM, Peter Kasting pkast...@chromium.orgwrote: To the degree that new upstream tests represent stuff we're shipping should actually work as advertised, I would prefer not to defer it. One more I forgot. If we're trying to not diverge from Safari too much (for web

[chromium-dev] Re: staying on top of layout tests

2009-02-19 Thread Peter Kasting
On Thu, Feb 19, 2009 at 2:49 PM, Ojan Vafai o...@chromium.org wrote: I don't think it makes sense to block releases to the stable channel on new tests that we've never passed. I somewhat agree, but there is a caveat. When we add a feature, if it's completely broken and awful, we probably

[chromium-dev] Re: Google Chrome's Most visited page is inferior to Apple Safari 4 (beta) Top Sites page

2009-02-24 Thread Peter Kasting
On Tue, Feb 24, 2009 at 6:34 PM, Evan Martin e...@chromium.org wrote: Yes, I would suggest it is urgent that we improve all of Chromium as rapidly as possible. I AGREE THINGS THAT ARE BAD SHOULD BE LESS BAD PLEASE TO BE FIX THIS NOW I CANOT TELL ALL MY FREIND TO SWITCH FROM FOXFIRE PK

[chromium-dev] Re: Streamlining key events

2009-02-25 Thread Peter Kasting
On Wed, Feb 25, 2009 at 11:49 AM, Evan Martin e...@chromium.org wrote: As your prize, I send you a video of RMS dancing: http://www.youtube.com/watch?v=Pube5Aynsls RMS is disturbed that video of himself is available on a site not run by Free Software. I am just disturbed at that video of

[chromium-dev] Re: Frame Switching

2009-02-26 Thread Peter Kasting
On Thu, Feb 26, 2009 at 1:04 PM, Ben Goodger (Google) b...@chromium.orgwrote: I am thinking it might be better to coalesce these two types, since one is a strict subset of another, and just have a mode on the object that indicates it's using a custom frame. Then when we switch DWM off we can

[chromium-dev] Re: Mac Dogfood Planning

2009-03-02 Thread Peter Kasting
On Mon, Mar 2, 2009 at 11:26 AM, Mike Pinkerton pinker...@chromium.orgwrote: Here's a very quick list of things that I see us as needing in order to get to something that we can call dogfood: - bookmark bar - class/nib infrastructure for tab dragging, even if we don't drag tabs Because of

[chromium-dev] Re: Thoughts regarding exposing --single-process, in-process-plugins in release builds

2009-03-02 Thread Peter Kasting
On Mon, Mar 2, 2009 at 6:26 PM, Mike Belshe mbel...@google.com wrote: I think you're advocating this: - Disable the flags we can't support - Leave the flags in chromium/debug builds Yes, this is much better than filtering these out of UMA. PK

[chromium-dev] Readability mode prototyped in the wild

2009-03-04 Thread Peter Kasting
Googlers may remember that one of my brainstorm ideas for Chromium was readability mode, a way to temporarily get rid of everything on a page except the main article. Now a company has prototyped this in the wild using a bookmarklet. Watch the intro video here.

[chromium-dev] Re: Spam on chromium-reviews

2009-03-06 Thread Peter Kasting
On Fri, Mar 6, 2009 at 10:34 AM, John Abd-El-Malek j...@chromium.org wrote: I'm guessing I'm not the only one who's irritated by it. Can we make it so that only members can post to chromium-reviews? We can automatically subscribe everyone who's sent a review in the last month or something.

[chromium-dev] Re: Chrome was on Jeopardy tonight

2009-03-12 Thread Peter Kasting
On Thu, Mar 12, 2009 at 4:55 PM, Daniel A. White dwh...@thetrueaplus.comwrote: Thought I let you guys know. Amazing! What was the answer? (I'm assuming the question was What is Google Chrome?) PK --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: SVG tests and sanity

2009-03-15 Thread Peter Kasting
On Fri, Mar 13, 2009 at 4:49 PM, Scott Violet s...@chromium.org wrote: Those are easy. If the test never worked them DEFER. I agree, if it's not a regression, and (as Linus mentioned) not a hang/crash/leak, let's punt. I only care about not regressing tests that are regressions, not sure how

[chromium-dev] Re: Quick translation question: activatable

2009-03-20 Thread Peter Kasting
On Fri, Mar 20, 2009 at 2:03 PM, Avi Drissman a...@google.com wrote: The term activatable, as seen in RenderWidgetHostViewWin, etc, is not clearly defined. Windows has two concepts relating to focus: focus and activation. A focused window is the window that would receive input events if its

[chromium-dev] Re: ScrollBar Implementation

2009-03-24 Thread Peter Kasting
Without looking at the code, some thoughts: * Scrollbars in web content differ from scrollbars in native content. Native content can use native scrollbars. Web content cannot (web content cannot use native widgets within pages as then pages can just recursively include 10,000 iframes and take

[chromium-dev] Re: Including Droid font in Chrome?

2009-03-24 Thread Peter Kasting
On Tue, Mar 24, 2009 at 6:27 PM, Alex Russell slightly...@google.comwrote: What do others think about including this font with Chrome and making it available to content in the font-family list by default? Also, it occurs to me that including the Droid TTF files on the Google CDN might make

[chromium-dev] Re: [chrome-team] Design-Doc: Automatic Spelling Correction

2009-03-24 Thread Peter Kasting
On Tue, Mar 24, 2009 at 2:26 PM, Siddhartha Chattopadhyay sidc...@chromium.org wrote: A new feature to add to Chromium would be automatic spelling correction. A design doc for this feature can be found at

[chromium-dev] Re: Does JSONStringValueSerializer expect UTF8?

2009-03-24 Thread Peter Kasting
On Tue, Mar 24, 2009 at 8:57 PM, Book'em Dano daniel.c...@gmail.com wrote: Hi guys, I notice that JSONStringValueSerializer in chrome\common takes a narrow string. It expects a UTF8 encoded string, right (i.e. it doesn't have to be ASCII only)? The general pattern in the code is that

[chromium-dev] Re: [chrome-team] Design-Doc: Automatic Spelling Correction

2009-03-24 Thread Peter Kasting
On Tue, Mar 24, 2009 at 10:16 PM, Nick Baum nickb...@chromium.org wrote: We want to start out with a very conservative approach so as to not be annoying. We considered using the hunspell suggestions, but we wanted something that captured one particular, common type of misspelling. However, I

[chromium-dev] Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-10 Thread Peter Kasting
Avi/Adam, you got nominated on IRC as relevant people for this. In http://codereview.chromium.org/66013 I'm changing the way some of the RenderWidgetHost[View] functions work slightly. I need to coordinate to get Mac and Linux changes to accommodate this in (I can't land my patch as-is because of

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-10 Thread Peter Kasting
On Fri, Apr 10, 2009 at 1:07 PM, Adam Langley a...@chromium.org wrote: X sends an expose message to us We ask for a BackingStore We don't have one, so we start a timed wait on the renderer to send us a paint We get the paint, so we create the backing store and copy the bitmap to it. With

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-13 Thread Peter Kasting
On Mon, Apr 13, 2009 at 10:59 AM, Adam Langley a...@chromium.org wrote: On Fri, Apr 10, 2009 at 1:16 PM, Peter Kasting pkast...@google.com wrote: I strongly suggest picking Darin's brain directly for more detail as he has a stronger grasp of this than I do :) I don't want to block

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-13 Thread Peter Kasting
On Mon, Apr 13, 2009 at 11:28 AM, Adam Langley a...@chromium.org wrote: It's not that don't want to deal with this right now, it's that I believe that the current behaviour is correct on Linux. Yes, I grasped that. I've reread your patch and email and I haven't understood any arguments

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-14 Thread Peter Kasting
On Mon, Apr 13, 2009 at 11:51 AM, Avi Drissman a...@chromium.org wrote: On Mon, Apr 13, 2009 at 2:47 PM, Peter Kasting pkast...@google.comwrote: it doesn't fire on Mac and at some point Avi will fix the Mac implementation. Side note: I now understand the issue this fixes and the fix

[chromium-dev] Re: Don't do work in a DCHECK

2009-04-23 Thread Peter Kasting
On Wed, Apr 22, 2009 at 8:39 PM, Mark Larson (Google) m...@chromium.orgwrote: So, please don't do any work in a DCHECK. We're lucky that the above example failed to compile, but it's possible to write code like this that would compile and just cause bizarre errors in release builds. ...and I

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-04-24 Thread Peter Kasting
On Thu, Apr 23, 2009 at 1:35 PM, Nikita Ofitserov himi...@gmail.com wrote: I suggest: Don't try to get pid dynamically, but create on startup in datadir file 'ChromePid' or something like that with pid. Creating files during startup would slow startup too much. Chrome crashing would leave a

[chromium-dev] Re: Changes to FilePath?

2009-04-28 Thread Peter Kasting
On Tue, Apr 28, 2009 at 1:39 PM, Greg Spencer gspen...@google.com wrote: 1) I'd like to add some explicit routines for converting to/from UTF8 and UTF16. While it's nice (and important) that FilePath uses the platform's native string, we've found that many third party libraries have made

[chromium-dev] Re: Changes to FilePath?

2009-04-28 Thread Peter Kasting
On Tue, Apr 28, 2009 at 2:48 PM, Greg Spencer gspen...@google.com wrote: So, I was unable to find the conversion utilities in base that do the conversion to/from UTF8. What are they called? If I missed them (and I looked for a while before I gave up), then maybe they need to be more

[chromium-dev] Re: Discussion to take over #chrome on irc

2009-04-30 Thread Peter Kasting
On Thu, Apr 30, 2009 at 9:42 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Hi Chromium users, there has been some discussion on IRC regarding redirecting users from #chrome to #chromium, etc. Please take a look at http://code.google.com/p/chromium/issues/detail?id=7776 for the feature

[chromium-dev] Re: Concerning HelpWanted tags

2009-05-01 Thread Peter Kasting
There's actually a lot of useful things in this email for someone to learn if they're seeking to become a more regular contributor. On Thu, Apr 30, 2009 at 10:29 PM, Mohamed Mansour m0.interact...@gmail.comwrote: I usually browse the issue tracker for HelpWanted tags, and try to solve those

[chromium-dev] Re: Discussion to take over #chrome on irc

2009-05-01 Thread Peter Kasting
On Fri, May 1, 2009 at 11:01 AM, Jason A. Spiro jasonspi...@gmail.comwrote: On Fri, May 1, 2009 at 2:06 AM, Peter Kasting pkast...@chromium.org wrote: IRC is absolutely the wrong method for support. Encouraging that makes everything worse. Why is it a bad method for support? Because

[chromium-dev] Re: Unforking: Canary Bot Lives!

2009-05-01 Thread Peter Kasting
On Fri, May 1, 2009 at 2:38 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: What does this mean? This means that our unforking efforts have finally paid off -- we can now pull directly from WebKit upstream! Nice! Please do write something for the Chromium blog! We need posts there. PK

[chromium-dev] Read me: When checking in patches for someone else

2009-05-03 Thread Peter Kasting
If you check in patches for someone else, please do the following:* Mention the person who wrote the patch. * Since your gcl change is not the same Rietveld issue as the original review, put a link to the original review in your change description. * Put a BUG= or http://crbug.com/... line in so

[chromium-dev] Re: Read me: When checking in patches for someone else

2009-05-03 Thread Peter Kasting
2009/5/3 Evan Martin e...@chromium.org On Sun, May 3, 2009 at 10:57 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: How should I check whether someone has filed the CLA if it's his first patch going to be committed? I don't know if there's a way to verify. I just ask if they're not

[chromium-dev] Re: Disable plugin

2009-05-03 Thread Peter Kasting
On Sun, May 3, 2009 at 9:39 PM, Robert Dailey rcdai...@gmail.com wrote: I'm asking on the dev list because I do not feel I will get my answer anywhere else. Not only will asking here not necessarily get you an answer but it will waste our time as we try and implement things people need and

[chromium-dev] Re: Windows 7 thumbnail previews for tabs (+ other new features)

2009-05-05 Thread Peter Kasting
On Mon, May 4, 2009 at 5:25 PM, Leith le...@leithalweapon.geek.nz wrote: Has anyone started work on integrating Chrome with the new thumbnail previews in Windows 7? You should probably search the bug tracker for relevant bugs for this. Any information would presumably be there. PK

[chromium-dev] Re: Does chrome has an add-on preference system?

2009-05-05 Thread Peter Kasting
On Tue, May 5, 2009 at 4:43 PM, Aaron Boodman a...@chromium.org wrote: Note that using cookies, as Peter suggests, won't work either. The lesson is, never listen to me. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com

[chromium-dev] Re: Fwd: Friend who works on Chrome

2009-05-06 Thread Peter Kasting
Something lazy-loaded after renderer start blocks system IO looking for a nonexistent DLL or network drive or something? I dunno, I'd try and trace what the IO calls being made are. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: No more local copy of WebCore and JavaScriptCore!

2009-05-08 Thread Peter Kasting
On Fri, May 8, 2009 at 9:49 AM, Darin Fisher da...@chromium.org wrote: I just committed a change that deletes our local copy of WebCore and JavaScriptCore (we use the wtf/ directory from here). http://src.chromium.org/viewvc/chrome?view=revrevision=15644 This change should be fairly

[chromium-dev] Re: Try out --enable-omnibox2!

2009-05-08 Thread Peter Kasting
On Fri, May 8, 2009 at 2:12 PM, sryo teodal...@gmail.com wrote: It looks really good, but brings a usability problem: the hovered entry's title has low contrast with it's bakcground color: http://img141.imageshack.us/img141/8058/omnibox2lowcontrast.png That looks like something worthy of

[chromium-dev] Re: Try out --enable-omnibox2!

2009-05-08 Thread Peter Kasting
On Fri, May 8, 2009 at 2:20 PM, Mike Belshe mbel...@google.com wrote: +1 - I don't like the transparency either. I'd prefer opaque. Me too PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email

[chromium-dev] Re: [extensions] content-type

2009-05-11 Thread Peter Kasting
On Mon, May 11, 2009 at 12:02 PM, Aaron Boodman a...@chromium.org wrote: That is a good idea. We could just use the same download UI and everything. When you click yes in the shelf, it just leads to the normal install dialog. Note, the plan is to change when the download prompting occurs to

[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Peter Kasting
On Mon, May 11, 2009 at 6:35 PM, Adam Barth aba...@chromium.org wrote: One feature of #webkit that I find useful is that every commit is summarized by the CIA-bot. http://cia.vc/ Funny, that's a feature I find utterly useless and annoying and I hate it. Why do you like it? PK

[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Peter Kasting
On Tue, May 12, 2009 at 1:27 PM, Adam Barth aba...@chromium.org wrote: Of course there are other ways of doing those things (like reading the buildbot page or subscribing to the RSS), but I find IRC useful since I'm half paying attention to it anyway. OK, that makes some sense. I think if

[chromium-dev] Re: Extensions now a bit more useful on Dev!

2009-05-12 Thread Peter Kasting
2009/5/12 PhistucK phist...@gmail.com Or give me an option to always always always go to google.com :() www.google.com/ncr ? By the way - is the Extensions system slated for the Chrome 2 release, or is it not a requirement for it? No (Because I saw some messages, though not from

[chromium-dev] Mozilla announces Jetpack extension initiative

2009-05-20 Thread Peter Kasting
https://jetpack.mozillalabs.com/ Similar-sounding goals to Chrome extensions: web-tech-based, no restart needed, backwards-compatible, etc. Not sure how much overlap there is between the two. Any Mozillians who read this (hi beltzner!) feel free to chime in. It would be very cool if these would

[chromium-dev] Re: a cool macro to only run the startup project

2009-05-22 Thread Peter Kasting
On Fri, May 22, 2009 at 8:06 PM, nakro yoav.zilberb...@gmail.com wrote: Sub BuildStartupProject() Dim sb As SolutionBuild = DTE.Solution.SolutionBuild Dim projName As String = sb.StartupProjects(0) sb.BuildProject(sb.ActiveConfiguration.Name, projName, False) End

[chromium-dev] Re: a cool macro to only run the startup project

2009-05-22 Thread Peter Kasting
On Fri, May 22, 2009 at 9:15 PM, nakro yoav.zilberb...@gmail.com wrote: should have read a cool macro to only BUILD the startup project . OK, I understand what you're trying to do. Generally when working I either want to test-compile the file I'm in (ctrl-F7) or actually run the program

[chromium-dev] Re: MessageLoop::PostTask Question

2009-05-25 Thread Peter Kasting
On Mon, May 25, 2009 at 3:44 PM, Evan Martin e...@chromium.org wrote: - The Notification service most definitely is designed to only work on the UI thread. It and its users assume notifications happen on one thread and synchronously. FWIW, the second sentence here is true, but the first is

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-26 Thread Peter Kasting
On Tue, May 26, 2009 at 8:31 PM, Brett Wilson bre...@chromium.org wrote: Don't bother doing an assertion when the next line will crash anyway: DCHECK(foo); foo-DoSomething(); I mostly do what Brett does, but I do sometimes DCHECK in cases like this, where the DCHECK is placed at the very

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-27 Thread Peter Kasting
On Wed, May 27, 2009 at 11:42 AM, Darin Fisher da...@chromium.org wrote: Also, the statement that we should always recover from a failed DCHECK seems very wrong to me. I agree, we should almost never recover from a DCHECK. 90+% of the time, DCHECK is better than if (condition) {

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-05-27 Thread Peter Kasting
On Wed, May 27, 2009 at 1:36 PM, Book'em Dano daniel.c...@gmail.com wrote: Did I miss the announcement that we were going to VS 2008? Not that I know of. Perhaps your local copy is modified somehow? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-05-27 Thread Peter Kasting
On Wed, May 27, 2009 at 1:46 PM, Book'em Dano daniel.c...@gmail.com wrote: The version of chrome.sln on the trunk (http://src.chromium.org/viewvc/ chrome/trunk/src/chrome/chrome.sln?view=markup) contains snipMicrosoft Visual Studio Solution File, Format Version 9.00/ snip This would seem

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Peter Kasting
On Fri, May 29, 2009 at 7:45 PM, Evan Stade est...@chromium.org wrote: I'll also take this opportunity to complain that the dangerous downloads dialog warning icon is way off center on windows. (see attachment. for comparison purposes, I've also attached linux ;) The entire download bar UI

  1   2   3   4   5   >