On Fri, 15 Mar 2024 07:23:30 GMT, Prasanta Sadhukhan
wrote:
> Few tests were converted from applet manual to main using PassFailJFrame
> manual framework but the extra folder was not deleted
>
> javax/swing/JFileChooser/6798062/bug6798062.java
> javax/swing/JFileChooser/FileFilterDescription/F
On Sat, 16 Mar 2024 22:35:16 GMT, Harshitha Onkar wrote:
>> Following InputMethod applet tests are converted to main using PassFailJFrame
>>
>> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
>> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.ja
Conversion of manual applet test to main based using PassFailJFrame manual
framework
-
Commit messages:
- Applet test converted to maim manual
Changes: https://git.openjdk.org/jdk/pull/18340/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18340&range=00
Issue: https://bu
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
jtreg tag update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18323/file
On Fri, 15 Mar 2024 12:59:24 GMT, Alexander Zvegintsev
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> jtreg tag update
>
> test/jdk/javax/swing/JSlider/bug6587742.java line 30:
>
>> 28: * @build PassFailJFram
On Sat, 16 Mar 2024 07:43:18 GMT, Tejesh R wrote:
> Automated the Test `javax/swing/border/Test4129681.java` from manual as
> suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F
> and the same is set explicitly..
test/jdk/javax/swing/bo
On Mon, 18 Mar 2024 03:00:49 GMT, Alexander Zuev wrote:
>> Converted to a main manual test.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixes based on review feedback
test/jdk/java/awt/Cursor/CursorOverlappedPanelsTe
On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
test/jdk/javax/swing/JColorChooser/Test4887836.java line 36:
> 34: * @summary Checks if no tooltip modification when no KeyStroke modifier
> 35: * @run main/manual Test4887836
> 36:
On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
test/jdk/javax/swing/JColorChooser/Test4887836.java line 57:
> 55: private static JColorChooser createColorChooser() {
> 56: JColorChooser chooser = new JColorChooser(Color.
On Fri, 15 Mar 2024 07:36:55 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> jtreg manual tag update
On Fri, 15 Mar 2024 11:30:53 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> jtreg manual tag update
On Thu, 14 Mar 2024 11:02:52 GMT, Tejesh R wrote:
>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test
>> to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revie
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18325
On Mon, 18 Mar 2024 08:43:33 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> jtreg manual tag update
>
> test/jdk/javax/swing/JSplitPane/bug8132123.java line 30:
>
>> 28: import javax.sw
On Mon, 18 Mar 2024 08:09:07 GMT, Abhishek Kumar wrote:
> Is the test exclusive for Metal Look And Feel or should it be checked in
> other LAFs as well? I think it may not work for Nimbus of GTK LAF as setting
> the property `UIManager.getDefaults().put("Label.disabledForeground",
> labelDisab
On Mon, 18 Mar 2024 09:17:16 GMT, Tejesh R wrote:
> > I am not sure but to me the images dont seem to match in windows11..it
> > seems JEditorPane image is 1 pixel thicker than golden images...in which
> > case, it needs to be problemlisted Also, I guess this has potential of
> > making it aut
On Mon, 18 Mar 2024 09:22:02 GMT, Tejesh R wrote:
> Yeah, because its difficult to verify it automatically for all L&F.
Not really, this can be done. But if it is not required to check except Metal
then it is ok.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussi
On Thu, 14 Mar 2024 11:02:52 GMT, Tejesh R wrote:
>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test
>> to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revie
On Mon, 18 Mar 2024 09:21:02 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
Ma
On Mon, 18 Mar 2024 09:32:37 GMT, Abhishek Kumar wrote:
>>> Is the test exclusive for Metal Look And Feel or should it be checked in
>>> other LAFs as well? I think it may not work for Nimbus of GTK LAF as
>>> setting the property
>>> `UIManager.getDefaults().put("Label.disabledForeground",
>
On Mon, 18 Mar 2024 09:32:42 GMT, Tejesh R wrote:
> > > > I am not sure but to me the images dont seem to match in windows11..it
> > > > seems JEditorPane image is 1 pixel thicker than golden images...in
> > > > which case, it needs to be problemlisted Also, I guess this has
> > > > potential
> Automated the Test `javax/swing/border/Test4129681.java` from manual as
> suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F
> and the same is set explicitly..
Tejesh R has updated the pull request incrementally with one additional com
On Mon, 18 Mar 2024 08:04:36 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> test/jdk/javax/swing/border/Test4129681.java line 62:
>
>> 60: label.setSize(SIZE);
>> 61:
On Fri, 15 Mar 2024 21:20:04 GMT, Phil Race wrote:
> This applet test is converted to a main program using PassFailJFrame.
> Other than that, the main thing I improved is the instructions.
Marked as reviewed by psadhukhan (Reviewer).
test/jdk/java/awt/Modal/PrintDialogsTest/PrintDialogsTest.jav
On Mon, 18 Mar 2024 08:01:41 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> jtreg tag update
Looks g
Similar to [JDK-8328157](https://bugs.openjdk.org/browse/JDK-8328157), we want
to move the setting of LDFLAGS to LDFLAGS_JDK[LIB/EXE into SetupJdkLibrary and
SetupJdkExecutable.
-
Commit messages:
- 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
Changes: https://gi
On Fri, 15 Mar 2024 07:29:53 GMT, Abhishek Kumar wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
This pull request has now been integrated.
Changeset: 86f17447
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/86f174473624
On Thu, 14 Mar 2024 17:05:04 GMT, Harshitha Onkar wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> Please remove unused imports
@honkar-jdk Please take a look.
-
PR Comment: h
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
jtreg tag update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18321/file
On Mon, 18 Mar 2024 09:36:02 GMT, Tejesh R wrote:
>>> Yeah, because its difficult to verify it automatically for all L&F.
>>
>> Not really, this can be done. But if it is not required to check except
>> Metal then it is ok.
>
> I meant the label position might vary slightly for different L&F, h
On Mon, 18 Mar 2024 09:50:43 GMT, Tejesh R wrote:
>> Automated the Test `javax/swing/border/Test4129681.java` from manual as
>> suggested in JBS description.
>> Verified in CI system and its Green. The test has been verified for Metal
>> L&F and the same is set explicitly..
>
> Tejesh R has upd
On Thu, 14 Mar 2024 05:21:03 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4760089.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
Marked as
On Thu, 14 Mar 2024 16:13:54 GMT, Damon Nguyen wrote:
>> Convert java/awt/im/JTextFieldTest.java applet test to main using
>> PassFailJFrame.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments
test/jdk/java/a
On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R wrote:
> Convert sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based
> using PassFailJFrame. This is a performance measurement test which provide
> benchmark to compare the outcome with different releases. I have converted
> the test
On Sat, 16 Mar 2024 22:34:10 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
> Automated the Test `javax/swing/border/Test4129681.java` from manual as
> suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F
> and the same is set explicitly..
Tejesh R has updated the pull request incrementally with one additional com
On Mon, 18 Mar 2024 09:37:23 GMT, Prasanta Sadhukhan
wrote:
> > > > > I am not sure but to me the images dont seem to match in
> > > > > windows11..it seems JEditorPane image is 1 pixel thicker than golden
> > > > > images...in which case, it needs to be problemlisted Also, I guess
> > > > >
On Mon, 18 Mar 2024 13:27:56 GMT, Prasanta Sadhukhan
wrote:
>>> > > > I am not sure but to me the images dont seem to match in
>>> > > > windows11..it seems JEditorPane image is 1 pixel thicker than golden
>>> > > > images...in which case, it needs to be problemlisted Also, I guess
>>> > > >
On Mon, 18 Mar 2024 13:27:56 GMT, Prasanta Sadhukhan
wrote:
>>> > > > I am not sure but to me the images dont seem to match in
>>> > > > windows11..it seems JEditorPane image is 1 pixel thicker than golden
>>> > > > images...in which case, it needs to be problemlisted Also, I guess
>>> > > >
On Wed, 13 Mar 2024 17:28:41 GMT, Harshitha Onkar wrote:
>> The following InputMethod test, bug8154816.java is converted to main using
>> PassFailJFrame.
>>
>> - test renamed to PinyinIMCapsTest
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>>
>> PS: I tried to automat
On Fri, 15 Mar 2024 11:39:05 GMT, Christoph Langer wrote:
> > > I added it to our testing. Results early next week.
> >
> >
> > @RealCLanger Thank you. I'm more interested in the failing case. How
> > reliable does the test reproduce the problem?
>
> Yes, it's running in 21 and 22 as well, so
On Mon, 18 Mar 2024 12:25:24 GMT, Abhishek Kumar wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> comm
On Sat, 16 Mar 2024 22:34:10 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
On Sun, 21 Jan 2024 07:58:11 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
On Tue, 12 Mar 2024 18:20:14 GMT, Harshitha Onkar wrote:
> The following InputMethod test, bug8154816.java is converted to main using
> PassFailJFrame.
>
> - test renamed to PinyinIMCapsTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
>
> PS: I tried to automate this t
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/jdk/pull/18319
Harshitha Onkar has updated the pull request
On Mon, 18 Mar 2024 15:39:52 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 55:
>>
>>> 53:
>>> 54: public static void main (String[] args) throws Exception {
>>> 55: PassFailJFrame.builder()
>>
>> OS check can be added.
>> htt
On Thu, 14 Mar 2024 17:59:04 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JToggleButton/bug4128979.java line 69:
>>
>>> 67:
>>> 68: public static void main(String[] args) throws Exception {
>>> 69:
>>> UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLo
Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java
applet test to main using PassFailJFrame
-
Commit messages:
- Move test out. Remove extra directory
- Resize instructions
- Initial test conversion
Changes: https://git.openjdk.org/jdk/pull/18354/files
On Mon, 18 Mar 2024 12:11:48 GMT, Abhishek Kumar wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/im/JTextFieldTest.java line 71:
>
>> 69: frame.getContentPane().add(tf
> Convert java/awt/im/JTextFieldTest.java applet test to main using
> PassFailJFrame.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Remove reundant window constant
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
Convert test to manual main
Move test to the Component folder
-
Commit messages:
- 8328367: Convert java/awt/Component/UpdatingBootTime test to main
Changes: https://git.openjdk.org/jdk/pull/18355/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18355&range=00
Issue: https
> Converted to a main manual test.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Additional fixes based on review
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18331/files
- new: https://git.openjdk.org/jdk/
On Mon, 18 Mar 2024 08:24:31 GMT, Abhishek Kumar wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes based on review feedback
>
> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 37:
>
>> 35: * @
On Mon, 18 Mar 2024 06:04:49 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/ProblemList.txt line 788:
>>
>>> 786: java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031
>>> generic-all
>>> 787: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378
>>> generic-all
>>> 788: java/a
> Following test
> java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted
> to main using PassFailJFrame.
>
> This test is currently problem-listed on macOS and linux, but as per the
> previous JBS bugs
> [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241),
> [JD
Convert test to manual main and move from the dedicated folder
Remove old files
-
Commit messages:
- 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
Changes: https://git.openjdk.org/jdk/pull/18357/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18357
Convert test to main manual and move to the appropriate folder
Remove old files
-
Commit messages:
- 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main
Changes: https://git.openjdk.org/jdk/pull/18358/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18
On Mon, 18 Mar 2024 06:40:36 GMT, Damon Nguyen wrote:
>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to
>> main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove unneeded
On Mon, 18 Mar 2024 06:04:49 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/ProblemList.txt line 788:
>>
>>> 786: java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031
>>> generic-all
>>> 787: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378
>>> generic-all
>>> 788: java/a
> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
> using PassFailJFrame
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Review changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
On Mon, 18 Mar 2024 18:35:23 GMT, Damon Nguyen wrote:
>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to
>> main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review changes
On Fri, 15 Mar 2024 05:06:23 GMT, Alexander Zvegintsev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review changes
>
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 67:
>
>> 65: .
On Mon, 18 Mar 2024 18:16:52 GMT, Alexander Zvegintsev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unneeded Global var. Review comments
>
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java lin
On Mon, 18 Mar 2024 17:45:02 GMT, Alexander Zuev wrote:
>> Converted to a main manual test.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Additional fixes based on review
LGTM
-
Marked as reviewed by honk
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove middle copyright year, update spacings and jtreg summary
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Fri, 15 Mar 2024 00:41:21 GMT, Harshitha Onkar wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove middle copyright year, update spacings and jtreg summary
>
> test/jdk/javax/swing/JColorChooser/Test4887836.j
On Fri, 1 Mar 2024 22:49:25 GMT, Alisen Chung wrote:
> Introduce delays in test to stabilize. Test passes 50x after fix.
This pull request has now been integrated.
Changeset: 3f2e849c
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- remove html
- init commit
Changes: https://git.openjdk.org/jdk/pull/18359/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18359&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328380
Stats:
Convert test to a main based;
Move test to an appropriate folder;
Remove old files;
-
Commit messages:
- Reorganize imports.
- 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main
Changes: https://git.openjdk.org/jdk/pull/18360/files
Webrev: https://webrevs.ope
Convert test to main manual;
Move test to appropriate folder;
Delete old files;
-
Commit messages:
- Reorganize imports.
- 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main
Changes: https://git.openjdk.org/jdk/pull/18361/files
Webrev: https://webrevs.openjdk
Following test - test/jdk/java/awt/dnd/URLDragTest/URLDragTest.html is
converted from applet to main using PassFailJFrame.
PassFailJFrame's `logArea()` is used for logging messages.
-
Commit messages:
- test changes: applet to main
- html file deleted
- test moved
Changes: http
Convert test to a main method based;
Move test to an apropriate location;
Remove old files;
-
Commit messages:
- 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main
Changes: https://git.openjdk.org/jdk/pull/18363/files
Webrev: https://webrevs.openjdk.org/?repo=j
Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no
longer an applet. Added test instructions related to the linked JBS issue.
-
Commit messages:
- Initial test conversion
Changes:
The test is converted to main and remains in the problem list, as the problem
is still valid on Linux and macos.
The test passes on Windows.
* sleeps on EDT removed, replaced with the Swing timer
* Unnecessary ltemListener and variables removed.
* Updated instructions with html for better readab
The test converted to automated, CI and manual testing looks good on all
platforms.
-
Commit messages:
- 8328401: Convert
java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
automated
Changes: https://git.openjdk.org/jdk/pull/18367/files
Webrev: https:/
On Mon, 18 Mar 2024 21:12:19 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main and remains in the problem list, as the problem
> is still valid on Linux and macos.
> The test passes on Windows.
>
> * sleeps on EDT removed, replaced with the Swing timer
> * Unnecessary ltemListe
On Mon, 18 Mar 2024 21:12:19 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main and remains in the problem list, as the problem
> is still valid on Linux and macos.
> The test passes on Windows.
>
> * sleeps on EDT removed, replaced with the Swing timer
> * Unnecessary ltemListe
On Mon, 18 Mar 2024 21:12:19 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main and remains in the problem list, as the problem
> is still valid on Linux and macos.
> The test passes on Windows.
>
> * sleeps on EDT removed, replaced with the Swing timer
> * Unnecessary ltemListe
On Tue, 19 Mar 2024 00:10:17 GMT, Harshitha Onkar wrote:
>> The test is converted to main and remains in the problem list, as the
>> problem is still valid on Linux and macos.
>> The test passes on Windows.
>>
>> * sleeps on EDT removed, replaced with the Swing timer
>> * Unnecessary ltemListe
On Tue, 19 Mar 2024 00:20:17 GMT, Harshitha Onkar wrote:
> Since the .html file is removed, the test file could be moved one level up.
Yes, we can do that, but we already had a discussion that it makes it harder to
do the review, since the github doesn't handle that moving well.
It can be done
On Mon, 18 Mar 2024 20:50:59 GMT, Damon Nguyen wrote:
> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
> no longer an applet. Added test instructions related to the linked JBS issue.
Changes
On Mon, 18 Mar 2024 07:09:33 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review updates
>
> test/jdk/java/awt/im/PinyinIMCommaTest.java line 67:
>
>> 65: if (OSInfo.getOSTyp
On Fri, 15 Mar 2024 14:50:12 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` thread. If the thread is pre-empted bet
On Fri, 15 Mar 2024 12:02:43 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java
>> line 99:
>>
>>> 97: createFiles(temp);
>>> 98:
>>> 99: final JFileChooser fc = new JFileChooser(temp.toFile());
>>
>> it should
> we need to add next to Pass/Fail a "Pause Timer" button, that
(a) stops the count down
(b) changes the Pause Timer to "Resume Timer"
~~(c) disables Pass/Fail until the timer is resumed~~
the test will not have to pause or be aware - only the PassFailJFrame machinery.
~~So the tester can do anythi
On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev
wrote:
>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or b
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18369/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328403
Stats: 57 lines in 2
Fix suggested in bug
[8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720)
had a regression in Nimbus L&F yet it resolved the issue in other L&F. The
better approach would be to handle `MultiResolutionImages `in `PathGraphics`
class `getBufferedImage` method
On Mon, 11 Mar 2024 10:05:41 GMT, Tejesh R wrote:
> Fix suggested in bug
> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720)
> had a regression in Nimbus L&F yet it resolved the issue in other L&F. The
> better approach would be to handle `MultiResolutio
> Convert sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based
> using PassFailJFrame. This is a performance measurement test which provide
> benchmark to compare the outcome with different releases. I have converted
> the test using a PassFailJFrame though PASS/FAIL doesn't mat
On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R wrote:
> Convert sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based
> using PassFailJFrame. This is a performance measurement test which provide
> benchmark to compare the outcome with different releases. I have converted
> the test
On Mon, 18 Mar 2024 17:30:46 GMT, Harshitha Onkar wrote:
>> Updated.
>
> You can remove the OS check here if you would like to, since it is not
> strictly required when run as jtreg test (which is essentially the case here).
I will keep this check as of now.
-
PR Review Comment: h
On Mon, 18 Mar 2024 17:45:02 GMT, Alexander Zuev wrote:
>> Converted to a main manual test.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Additional fixes based on review
Marked as reviewed by abhiscxk (Committer).
--
On Mon, 18 Mar 2024 18:34:18 GMT, Harshitha Onkar wrote:
>> The reason it was not integrated was because of this
>> [comment](https://github.com/openjdk/jdk/pull/3406#pullrequestreview-632106612)
>> wherein it was mentioned to update the test to run without MSOutlook
>> dependancy so that it c
On Fri, 15 Mar 2024 03:17:07 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Ninor update
Ma
On Mon, 18 Mar 2024 17:32:04 GMT, Alexander Zuev wrote:
> Convert test to manual main
> Move test to the Component folder
test/jdk/java/awt/Component/UpdatingBootTime.java line 27:
> 25: * @test
> 26: * @bug 6461933 7194219
> 27: * @summary adjust system boot time in nowMillisUTC() frequentl
On Wed, 13 Mar 2024 07:34:24 GMT, Prasanta Sadhukhan
wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
This pull request has now been integrated.
Changeset: ac5b6cb2
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/ac5
98 matches
Mail list logo
