Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508591959 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508589430 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig @JsonProperty

Re: [PR] [Backport] Concurrent replace should work with supervisors using concurrent locks (#15995) (druid)

2024-02-29 Thread via GitHub
kfaraz merged PR #16019: URL: https://github.com/apache/druid/pull/16019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch 29.0.1 updated: [Backport] Concurrent replace should work with supervisors using concurrent locks (#15995) (#16019)

2024-02-29 Thread kfaraz
This is an automated email from the ASF dual-hosted git repository. kfaraz pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new 33478f08265 [Backport] Concurrent replace should

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508548109 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataManager.java: ## @@ -1035,7 +1035,7 @@ public void poll() @GuardedBy("pollLock") private void

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508550555 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig @JsonProperty

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508543536 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508589430 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig @JsonProperty

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508596892 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig @JsonProperty

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508540758 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508538414 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig @JsonProperty

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508551388 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig

Re: [I] Coordinator crashes after upgrading to 29.0.0 (druid)

2024-02-29 Thread via GitHub
abhishekagarwal87 closed issue #15942: Coordinator crashes after upgrading to 29.0.0 URL: https://github.com/apache/druid/issues/15942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Coordinator crashes after upgrading to 29.0.0 (druid)

2024-02-29 Thread via GitHub
abhishekagarwal87 commented on issue #15942: URL: https://github.com/apache/druid/issues/15942#issuecomment-1972619119 @jreyeshdez - There is an explanation in the ticket you linked, and it has a workaround too. I am going to close this bug as there is nothing we can do from Druid side. If

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
kfaraz commented on PR #15952: URL: https://github.com/apache/druid/pull/15952#issuecomment-1972618896 @AmatyaAvadhanula , looking at the benchmarking, is it correct to conclude that the new logic is faster even when `useSegmentLock = true` (i.e. minor versions exist)? But how can that be

[PR] Bump org.bitbucket.b_c:jose4j from 0.9.3 to 0.9.5 (druid)

2024-02-29 Thread via GitHub
dependabot[bot] opened a new pull request, #16017: URL: https://github.com/apache/druid/pull/16017 Bumps [org.bitbucket.b_c:jose4j](https://bitbucket.org/b_c/jose4j) from 0.9.3 to 0.9.5. Commits

(druid) branch master updated (baaa4a68084 -> 101176590c9)

2024-02-29 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from baaa4a68084 update common-compress to address CVE-2024-25710 CVE-2024-26308 (#16009) add 101176590c9 adaptive

[PR] [Backport] Concurrent replace should work with supervisors using concurrent locks (#15995) (druid)

2024-02-29 Thread via GitHub
AmatyaAvadhanula opened a new pull request, #16019: URL: https://github.com/apache/druid/pull/16019 Backports #15995 to 29.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add support for AzureDNSZone enabled storage accounts used for deep storage (druid)

2024-02-29 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16016: URL: https://github.com/apache/druid/pull/16016#discussion_r1508268216 ## extensions-core/azure-extensions/src/test/java/org/apache/druid/storage/azure/AzureStorageDruidModuleTest.java: ## @@ -285,7 +285,8 @@ {

(druid) 01/01: Prepare 29.0.0 for 29.0.1 release

2024-02-29 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git commit 067facdaa8fcb5712309628ccbc1727734630d7e Author: cryptoe AuthorDate: Fri Mar 1 09:26:49 2024 +0530 Prepare 29.0.0

(druid) branch 29.0.1 created (now 067facdaa8f)

2024-02-29 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a change to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git at 067facdaa8f Prepare 29.0.0 for 29.0.1 release This branch includes the following new commits: new 067facdaa8f

(druid) branch dependabot/maven/org.bitbucket.b_c-jose4j-0.9.5 created (now 822232c22d5)

2024-02-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.bitbucket.b_c-jose4j-0.9.5 in repository https://gitbox.apache.org/repos/asf/druid.git at 822232c22d5 Bump org.bitbucket.b_c:jose4j from 0.9.3 to 0.9.5 No new

Re: [PR] Add support for AzureDNSZone enabled storage accounts used for deep storage (druid)

2024-02-29 Thread via GitHub
georgew5656 commented on code in PR #16016: URL: https://github.com/apache/druid/pull/16016#discussion_r1508261001 ## docs/development/extensions-core/azure.md: ## @@ -42,6 +42,6 @@ To use this Apache Druid extension, [include](../../configuration/extensions.md#

Re: [I] [Flaky IT] : ITKafkaIndexingServiceNonTransactionalParallelizedTest.testKafkaIndexDataWithWithAutoscaler:62 failed (druid)

2024-02-29 Thread via GitHub
github-actions[bot] commented on issue #13662: URL: https://github.com/apache/druid/issues/13662#issuecomment-1972195611 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [PR] msq path to emit unparseable exceptions (druid)

2024-02-29 Thread via GitHub
github-actions[bot] commented on PR #13670: URL: https://github.com/apache/druid/pull/13670#issuecomment-1972195637 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] msq path to emit unparseable exceptions (druid)

2024-02-29 Thread via GitHub
github-actions[bot] closed pull request #13670: msq path to emit unparseable exceptions URL: https://github.com/apache/druid/pull/13670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add delete syntax (druid)

2024-02-29 Thread via GitHub
github-actions[bot] closed pull request #13674: Add delete syntax URL: https://github.com/apache/druid/pull/13674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add delete syntax (druid)

2024-02-29 Thread via GitHub
github-actions[bot] commented on PR #13674: URL: https://github.com/apache/druid/pull/13674#issuecomment-1972195652 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [I] Data migration from MongoDB to Apache Druid (druid)

2024-02-29 Thread via GitHub
github-actions[bot] commented on issue #13679: URL: https://github.com/apache/druid/issues/13679#issuecomment-1972195721 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] Increasing maxOnDiskStorage has no affect (druid)

2024-02-29 Thread via GitHub
github-actions[bot] commented on issue #13677: URL: https://github.com/apache/druid/issues/13677#issuecomment-1972195685 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] JSON flattener should respect druid null handling config (druid.generic.useDefaultValueForNull) for arrays (druid)

2024-02-29 Thread via GitHub
github-actions[bot] commented on issue #13685: URL: https://github.com/apache/druid/issues/13685#issuecomment-1972195751 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] Increasing maxOnDiskStorage has no affect (druid)

2024-02-29 Thread via GitHub
github-actions[bot] closed issue #13677: Increasing maxOnDiskStorage has no affect URL: https://github.com/apache/druid/issues/13677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Integrate the catalog with the Calcite planner (druid)

2024-02-29 Thread via GitHub
github-actions[bot] commented on PR #13686: URL: https://github.com/apache/druid/pull/13686#issuecomment-1972195788 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] Integrate the catalog with the Calcite planner (druid)

2024-02-29 Thread via GitHub
github-actions[bot] closed pull request #13686: Integrate the catalog with the Calcite planner URL: https://github.com/apache/druid/pull/13686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Data migration from MongoDB to Apache Druid (druid)

2024-02-29 Thread via GitHub
github-actions[bot] closed issue #13679: Data migration from MongoDB to Apache Druid URL: https://github.com/apache/druid/issues/13679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] JSON flattener should respect druid null handling config (druid.generic.useDefaultValueForNull) for arrays (druid)

2024-02-29 Thread via GitHub
github-actions[bot] closed issue #13685: JSON flattener should respect druid null handling config (druid.generic.useDefaultValueForNull) for arrays URL: https://github.com/apache/druid/issues/13685 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Flaky IT] : ITKafkaIndexingServiceNonTransactionalParallelizedTest.testKafkaIndexDataWithWithAutoscaler:62 failed (druid)

2024-02-29 Thread via GitHub
github-actions[bot] closed issue #13662: [Flaky IT] : ITKafkaIndexingServiceNonTransactionalParallelizedTest.testKafkaIndexDataWithWithAutoscaler:62 failed URL: https://github.com/apache/druid/issues/13662 -- This is an automated message from the Apache Git Service. To respond to the

(druid) branch master updated (101176590c9 -> c5b032799c3)

2024-02-29 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 101176590c9 adaptive filter partitioning (#15838) add c5b032799c3 Web console: add table and column search

Re: [PR] Web console: make double detection better (druid)

2024-02-29 Thread via GitHub
vogievetsky merged PR #15998: URL: https://github.com/apache/druid/pull/15998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Web console: add table and column search (druid)

2024-02-29 Thread via GitHub
vogievetsky merged PR #15990: URL: https://github.com/apache/druid/pull/15990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (c5b032799c3 -> acb5124679e)

2024-02-29 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from c5b032799c3 Web console: add table and column search (#15990) add acb5124679e make double detection better

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-02-29 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1508475810 ## server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java: ## @@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig

Re: [PR] adaptive filter partitioning (druid)

2024-02-29 Thread via GitHub
clintropolis merged PR #15838: URL: https://github.com/apache/druid/pull/15838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] remove use log of log4j v1 (druid)

2024-02-29 Thread via GitHub
AlbericByte commented on PR #15984: URL: https://github.com/apache/druid/pull/15984#issuecomment-1972239745 @FrankChen021 thanks for help for reviewing when you have time. There is one integration test failed(integration-index-tests-indexer (kafka-index)), which is not related to the

Re: [PR] Array overlap to allow numeric operand (druid)

2024-02-29 Thread via GitHub
clintropolis commented on code in PR #15964: URL: https://github.com/apache/druid/pull/15964#discussion_r1508368697 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/SqlParameterizerShuttle.java: ## @@ -129,13 +129,12 @@ private SqlNode createArrayLiteral(Object value,

[PR] WIP (druid)

2024-02-29 Thread via GitHub
adithyachakilam opened a new pull request, #16018: URL: https://github.com/apache/druid/pull/16018 Fixes #. ### Description Fixed the bug ... Renamed the class ... Added a forbidden-apis entry ...

[PR] update common-compress (druid)

2024-02-29 Thread via GitHub
janjwerner-confluent opened a new pull request, #16009: URL: https://github.com/apache/druid/pull/16009 ### Description - Update common-compress to 1.26.0 to address CVEs CVE-2024-25710 CVE-2024-26308 This PR has: - [ ] been self-reviewed. - [ ] using the

Re: [PR] Revert explain attributes change (druid)

2024-02-29 Thread via GitHub
cryptoe commented on code in PR #16004: URL: https://github.com/apache/druid/pull/16004#discussion_r1507545485 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/IngestHandler.java: ## @@ -405,7 +405,7 @@ public ExplainAttributes explainAttributes() { return

[PR] Support CPU resource configurable for Kubernates job under MoK Mode (druid)

2024-02-29 Thread via GitHub
fectrain opened a new pull request, #16008: URL: https://github.com/apache/druid/pull/16008 Fixes #16007 . ### Description Make CPU core configurable for Kubernetes job(Peon) under MoK Mode Currently the CPU core for Peon is fixed to 1, this PR is to

Re: [PR] update common-compress to address CVE-2024-25710 CVE-2024-26308 (druid)

2024-02-29 Thread via GitHub
janjwerner-confluent commented on PR #16009: URL: https://github.com/apache/druid/pull/16009#issuecomment-1971190887 This resolves: https://github.com/apache/druid/pull/15932 adding commons-codec as the required dependency of processing -- This is an automated message from the

Re: [I] Remove useless helm releated pathes in workflows (druid)

2024-02-29 Thread via GitHub
kfaraz closed issue #16005: Remove useless helm releated pathes in workflows URL: https://github.com/apache/druid/issues/16005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Remove useless CI path (druid)

2024-02-29 Thread via GitHub
kfaraz merged PR #16006: URL: https://github.com/apache/druid/pull/16006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (e0bce0ef904 -> 3acfc954532)

2024-02-29 Thread kfaraz
This is an automated email from the ASF dual-hosted git repository. kfaraz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from e0bce0ef904 Add pre-check for heavy debug logs (#15706) add 3acfc954532 Remove helm paths from CodeQL config

Re: [PR] Fix Windowing/scanAndSort query issues on top of Joins. (druid)

2024-02-29 Thread via GitHub
abhishekagarwal87 commented on code in PR #15996: URL: https://github.com/apache/druid/pull/15996#discussion_r1507735484 ## processing/src/main/java/org/apache/druid/frame/read/columnar/DoubleFrameColumnReader.java: ## @@ -67,7 +67,7 @@ public ColumnPlus readColumn(final Frame

Re: [I] Druid Historicals pod is not starting in on-premises (druid)

2024-02-29 Thread via GitHub
EandrewJones commented on issue #14274: URL: https://github.com/apache/druid/issues/14274#issuecomment-1971507706 Running into the same issue with a kubernetes deployment. Did you ever make headway on this? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix compaction tasks reports getting overwritten (druid)

2024-02-29 Thread via GitHub
georgew5656 commented on code in PR #15981: URL: https://github.com/apache/druid/pull/15981#discussion_r1507739056 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -821,10 +836,10 @@ TaskStatus

Re: [PR] Fix compaction tasks reports getting overwritten (druid)

2024-02-29 Thread via GitHub
georgew5656 commented on code in PR #15981: URL: https://github.com/apache/druid/pull/15981#discussion_r1507750190 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -821,10 +836,10 @@ TaskStatus

Re: [PR] Fix compaction tasks reports getting overwritten (druid)

2024-02-29 Thread via GitHub
adithyachakilam commented on code in PR #15981: URL: https://github.com/apache/druid/pull/15981#discussion_r1507834156 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java: ## @@ -514,6 +518,9 @@ public TaskStatus runTask(TaskToolbox

Re: [PR] Fix compaction tasks reports getting overwritten (druid)

2024-02-29 Thread via GitHub
georgew5656 commented on code in PR #15981: URL: https://github.com/apache/druid/pull/15981#discussion_r1507714422 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java: ## @@ -514,6 +518,9 @@ public TaskStatus runTask(TaskToolbox toolbox)

Re: [PR] Fix compaction tasks reports getting overwritten (druid)

2024-02-29 Thread via GitHub
georgew5656 commented on code in PR #15981: URL: https://github.com/apache/druid/pull/15981#discussion_r1507739056 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -821,10 +836,10 @@ TaskStatus

Re: [PR] Fix compaction tasks reports getting overwritten (druid)

2024-02-29 Thread via GitHub
georgew5656 commented on code in PR #15981: URL: https://github.com/apache/druid/pull/15981#discussion_r1507752572 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -292,6 +293,20 @@ public Set

Re: [PR] Fix Windowing/scanAndSort query issues on top of Joins. (druid)

2024-02-29 Thread via GitHub
kgyrtkirk commented on code in PR #15996: URL: https://github.com/apache/druid/pull/15996#discussion_r1507753367 ## processing/src/main/java/org/apache/druid/frame/read/columnar/DoubleFrameColumnReader.java: ## @@ -67,7 +67,7 @@ public ColumnPlus readColumn(final Frame frame)

[PR] Minor test improvements (druid)

2024-02-29 Thread via GitHub
kgyrtkirk opened a new pull request, #16010: URL: https://github.com/apache/druid/pull/16010 * prioritize the last added matcher in DruidExceptionMatcher * it adds quite a few matchers and the most interesting one which checks the messages is at the end; showing the message could give

[I] Remove useless helm releated pathes in workflows (druid)

2024-02-29 Thread via GitHub
asdf2014 opened a new issue, #16005: URL: https://github.com/apache/druid/issues/16005 We should remove useless helm releated pathes in workflows since the Helm Chart has been migrated to [new repo](https://github.com/asdf2014/druid-helm), FYI,

Re: [PR] Fix deadlock that can occur while merging group by results (druid)

2024-02-29 Thread via GitHub
LakshSingla commented on PR #15420: URL: https://github.com/apache/druid/pull/15420#issuecomment-1970680139 @gianm The PR is ready for review now. There are a few code coverage failures, but I think they are due to making changes in the unrelated classes using the

[I] Make CPU config of Container configurable under MoK mode (druid)

2024-02-29 Thread via GitHub
asdf2014 opened a new issue, #16007: URL: https://github.com/apache/druid/issues/16007 ### Description ![](https://github.com/apache/druid/assets/8108788/457f91b5-d7c6-49b7-89e3-d58be4cae706) In the Druid cluster with MoK mode, we can observe that the CPU usage of task Pod

Re: [PR] fix issues with array_contains and array_overlap with null left side arguments (druid)

2024-02-29 Thread via GitHub
clintropolis commented on code in PR #15974: URL: https://github.com/apache/druid/pull/15974#discussion_r1507243354 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteLookupFunctionQueryTest.java: ## @@ -856,17 +856,12 @@ public void testFilterMvContainsIsNotTrue()

Re: [PR] fix issues with array_contains and array_overlap with null left side arguments (druid)

2024-02-29 Thread via GitHub
clintropolis commented on code in PR #15974: URL: https://github.com/apache/druid/pull/15974#discussion_r1507243354 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteLookupFunctionQueryTest.java: ## @@ -856,17 +856,12 @@ public void testFilterMvContainsIsNotTrue()

[PR] Remove useless CI path (druid)

2024-02-29 Thread via GitHub
fectrain opened a new pull request, #16006: URL: https://github.com/apache/druid/pull/16006 Fixes #16005 . ### Description Remove useless CI path This PR has:

Re: [PR] Fix deadlock that can occur while merging group by results (druid)

2024-02-29 Thread via GitHub
LakshSingla commented on PR #15420: URL: https://github.com/apache/druid/pull/15420#issuecomment-1970631403 @gianm With the recent changes made to the PR, I wanted to revisit the questions posed [here](https://github.com/apache/druid/pull/15420#issuecomment-1878164205), and more, that

Re: [PR] Rows.objectToNumber: Accept decimals with output type LONG. (druid)

2024-02-29 Thread via GitHub
gianm commented on PR #15999: URL: https://github.com/apache/druid/pull/15999#issuecomment-1970659025 Yes, right, the test cases in replace-with-default mode were not looking for the right thing. That's fixed now. Thanks. -- This is an automated message from the Apache Git Service. To

[PR] Revert explain attributes change (druid)

2024-02-29 Thread via GitHub
adarshsanjeev opened a new pull request, #16004: URL: https://github.com/apache/druid/pull/16004 Reverts a change made to explain attributes made by https://github.com/apache/druid/pull/15689. This will maintain backward compatibility. This PR has: - [ ] been

Re: [PR] Revert explain attributes change (druid)

2024-02-29 Thread via GitHub
gianm commented on PR #16004: URL: https://github.com/apache/druid/pull/16004#issuecomment-1971730410 We did release #15689 in 29.0.0. It accidentally included a breaking API change, which is problematic. This PR reverts the breaking change, but since #15689 has already been released, that

Re: [PR] update common-compress to address CVE-2024-25710 CVE-2024-26308 (druid)

2024-02-29 Thread via GitHub
xvrl commented on code in PR #16009: URL: https://github.com/apache/druid/pull/16009#discussion_r1507966483 ## processing/pom.xml: ## @@ -81,6 +81,11 @@ org.apache.commons commons-compress + + commons-codec + commons-codec + runtime

Re: [PR] remove unnecessary elasticsearch dependencies to fix CVE regressions (druid)

2024-02-29 Thread via GitHub
janjwerner-confluent commented on PR #15443: URL: https://github.com/apache/druid/pull/15443#issuecomment-1971638154 @abhishekagarwal87 Yes, I will try to pick up only the only the needed items -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix compaction tasks reports getting overwritten (druid)

2024-02-29 Thread via GitHub
adithyachakilam commented on code in PR #15981: URL: https://github.com/apache/druid/pull/15981#discussion_r1507988676 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -292,6 +293,20 @@ public Set

[I] Add column flattening via UI creating wrong spec for Kafka ingestions (druid)

2024-02-29 Thread via GitHub
daniel-imgarena opened a new issue, #16012: URL: https://github.com/apache/druid/issues/16012 ### Affected Version I'm using Druid 29 ### Description The Console UI creates wrong spec when adding a column flatten for a Kafka ingestion. Reproducing: - Create a

[PR] remove azure-sdk from ranger-extension (druid)

2024-02-29 Thread via GitHub
janjwerner-confluent opened a new pull request, #16011: URL: https://github.com/apache/druid/pull/16011 Fixes # size blowup regression introduced in https://github.com/apache/druid/pull/15443 ### Description This PR removes the transitive dependency of

Re: [PR] update common-compress to address CVE-2024-25710 CVE-2024-26308 (druid)

2024-02-29 Thread via GitHub
janjwerner-confluent commented on code in PR #16009: URL: https://github.com/apache/druid/pull/16009#discussion_r1507971811 ## processing/pom.xml: ## @@ -81,6 +81,11 @@ org.apache.commons commons-compress + + commons-codec + commons-codec +

Re: [PR] Revert explain attributes change (druid)

2024-02-29 Thread via GitHub
gianm commented on code in PR #16004: URL: https://github.com/apache/druid/pull/16004#discussion_r1508014375 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/IngestHandler.java: ## @@ -405,7 +405,7 @@ public ExplainAttributes explainAttributes() { return

Re: [PR] update common-compress to address CVE-2024-25710 CVE-2024-26308 (druid)

2024-02-29 Thread via GitHub
xvrl commented on code in PR #16009: URL: https://github.com/apache/druid/pull/16009#discussion_r1508067842 ## processing/pom.xml: ## @@ -81,6 +81,11 @@ org.apache.commons commons-compress + + commons-codec + commons-codec + runtime

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-02-29 Thread via GitHub
suneet-s commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1508115497 ## docs/ingestion/tasks.md: ## @@ -103,6 +103,14 @@ For some task types, the indexing task can wait for the newly ingested segments

[PR] docs: mention acid-compliance for meta store (druid)

2024-02-29 Thread via GitHub
317brian opened a new pull request, #16014: URL: https://github.com/apache/druid/pull/16014 Explicitly mention that Druid expects their metadata store to be ACID-compliant This PR has: - [x] been self-reviewed. -- This is an automated message from the Apache Git

Re: [PR] docs: mention acid-compliance for meta store (druid)

2024-02-29 Thread via GitHub
317brian closed pull request #16014: docs: mention acid-compliance for meta store URL: https://github.com/apache/druid/pull/16014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump org.bitbucket.b_c:jose4j from 0.9.3 to 0.9.4 (druid)

2024-02-29 Thread via GitHub
dependabot[bot] opened a new pull request, #16015: URL: https://github.com/apache/druid/pull/16015 Bumps [org.bitbucket.b_c:jose4j](https://bitbucket.org/b_c/jose4j) from 0.9.3 to 0.9.4. Commits

(druid) branch dependabot/maven/org.bitbucket.b_c-jose4j-0.9.4 created (now 9e8c0bf9ff4)

2024-02-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.bitbucket.b_c-jose4j-0.9.4 in repository https://gitbox.apache.org/repos/asf/druid.git at 9e8c0bf9ff4 Bump org.bitbucket.b_c:jose4j from 0.9.3 to 0.9.4 No new

[PR] Test (druid)

2024-02-29 Thread via GitHub
superbstreak opened a new pull request, #16013: URL: https://github.com/apache/druid/pull/16013 Fixes #. ### Description Fixed the bug ... Renamed the class ... Added a forbidden-apis entry ...

Re: [PR] Test (druid)

2024-02-29 Thread via GitHub
superbstreak closed pull request #16013: Test URL: https://github.com/apache/druid/pull/16013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] remove azure-sdk from ranger-extension (druid)

2024-02-29 Thread via GitHub
LakshSingla commented on PR #16011: URL: https://github.com/apache/druid/pull/16011#issuecomment-1971767296 Is it safe to exclude the dependency? Last I checked, the ranger did rely on AWS Cloudwatch for some things. Do we not use that functionality in Druid? -- This is an automated

Re: [PR] update common-compress to address CVE-2024-25710 CVE-2024-26308 (druid)

2024-02-29 Thread via GitHub
xvrl commented on code in PR #16009: URL: https://github.com/apache/druid/pull/16009#discussion_r1508081694 ## processing/pom.xml: ## @@ -81,6 +81,12 @@ org.apache.commons commons-compress + Review Comment: ```suggestion ``` -- This is

Re: [PR] remove azure-sdk from ranger-extension (druid)

2024-02-29 Thread via GitHub
xvrl commented on code in PR #16011: URL: https://github.com/apache/druid/pull/16011#discussion_r1508112657 ## extensions-core/druid-ranger-security/pom.xml: ## @@ -178,6 +178,10 @@ org.apache.hadoop hadoop-common +

Re: [PR] remove azure-sdk from ranger-extension (druid)

2024-02-29 Thread via GitHub
janjwerner-confluent commented on code in PR #16011: URL: https://github.com/apache/druid/pull/16011#discussion_r1508130853 ## extensions-core/druid-ranger-security/pom.xml: ## @@ -178,6 +178,10 @@ org.apache.hadoop hadoop-common

[PR] Add support for AzureDNSZone enabled storage accounts used for deep storage (druid)

2024-02-29 Thread via GitHub
zachjsh opened a new pull request, #16016: URL: https://github.com/apache/druid/pull/16016 ### Description Added a new config to AzureAccountConfig `storageAccountEndpointSuffix` which allows the user to specify a storage account endpoint suffix where the underlying

Re: [PR] remove azure-sdk from ranger-extension (druid)

2024-02-29 Thread via GitHub
xvrl commented on code in PR #16011: URL: https://github.com/apache/druid/pull/16011#discussion_r1508246591 ## extensions-core/druid-ranger-security/pom.xml: ## @@ -193,7 +198,13 @@ compile - + + +com.amazonaws +

Re: [PR] update common-compress to address CVE-2024-25710 CVE-2024-26308 (druid)

2024-02-29 Thread via GitHub
xvrl merged PR #16009: URL: https://github.com/apache/druid/pull/16009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (3acfc954532 -> baaa4a68084)

2024-02-29 Thread xvrl
This is an automated email from the ASF dual-hosted git repository. xvrl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 3acfc954532 Remove helm paths from CodeQL config (#16006) add baaa4a68084 update common-compress to address