[GitHub] [pulsar] yonigibbs commented on issue #19299: [Doc] Example Window Function has different names in docs and in the examples folder

2023-01-20 Thread GitBox
yonigibbs commented on issue #19299: URL: https://github.com/apache/pulsar/issues/19299#issuecomment-1398326044 Found one more thing: the docs around starting window functions (https://pulsar.apache.org/docs/2.11.x/functions-quickstart/#start-window-functions) give these two commands:

[GitHub] [pulsar] yonigibbs opened a new issue, #19299: [Doc] Example Window Function has different names in docs and in the examples folder

2023-01-20 Thread GitBox
yonigibbs opened a new issue, #19299: URL: https://github.com/apache/pulsar/issues/19299 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? The

[GitHub] [pulsar] codecov-commenter commented on pull request #19296: [improve][ci] Improve code coverage reporting

2023-01-20 Thread GitBox
codecov-commenter commented on PR #19296: URL: https://github.com/apache/pulsar/pull/19296#issuecomment-1398308556 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-site] lhotari opened a new pull request, #387: Update Pulsar PMC members and committers

2023-01-20 Thread GitBox
lhotari opened a new pull request, #387: URL: https://github.com/apache/pulsar-site/pull/387 Process used to update `data/team.js` file: 1. Logged in to https://whimsy.apache.org/roster/committee/pulsar with browser 2. Appended ".json" to URL so that browser goes to

[GitHub] [pulsar] massakam opened a new pull request, #19298: [feat][cli] Add read command to pulsar-client-tools

2023-01-20 Thread GitBox
massakam opened a new pull request, #19298: URL: https://github.com/apache/pulsar/pull/19298 ### Motivation I thought it would be convenient to create a reader easily with CLI, so I added the read command to pulsar-client-tools. Example of use: ```sh $

[GitHub] [pulsar] nodece commented on pull request #19294: [fix][cli][branch-2.10] Fix mbeans to json

2023-01-20 Thread GitBox
nodece commented on PR #19294: URL: https://github.com/apache/pulsar/pull/19294#issuecomment-1398193060 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on issue #19297: Flaky-test: ReplicatorTest.testDoNotReplicateSystemTopic

2023-01-20 Thread GitBox
lhotari commented on issue #19297: URL: https://github.com/apache/pulsar/issues/19297#issuecomment-1398082751 There's also #12774, but the problem seems to be different. In this case, it looks like there's a race condition in the test itself.

[GitHub] [pulsar] lhotari opened a new issue, #19297: Flaky-test: ReplicatorTest.testDoNotReplicateSystemTopic

2023-01-20 Thread GitBox
lhotari opened a new issue, #19297: URL: https://github.com/apache/pulsar/issues/19297 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure

[GitHub] [pulsar] nodece closed pull request #17017: [improve][broker] Add close function worker

2023-01-20 Thread GitBox
nodece closed pull request #17017: [improve][broker] Add close function worker URL: https://github.com/apache/pulsar/pull/17017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] nodece commented on pull request #16898: [fix][function] Fix load trust certificate

2023-01-20 Thread GitBox
nodece commented on PR #16898: URL: https://github.com/apache/pulsar/pull/16898#issuecomment-1398062365 Ping @michaeljmarshall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] nodece closed pull request #15173: [cleanup][client] Cleanup the creation ssl context

2023-01-20 Thread GitBox
nodece closed pull request #15173: [cleanup][client] Cleanup the creation ssl context URL: https://github.com/apache/pulsar/pull/15173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] nodece closed pull request #16568: [improve][client] Add original principal and authentication data support

2023-01-20 Thread GitBox
nodece closed pull request #16568: [improve][client] Add original principal and authentication data support URL: https://github.com/apache/pulsar/pull/16568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] nodece commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor

2023-01-20 Thread GitBox
nodece commented on code in PR #19295: URL: https://github.com/apache/pulsar/pull/19295#discussion_r1082207478 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java: ## @@ -61,13 +80,47 @@ public AuthenticationDataSource

[GitHub] [pulsar] nodece commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor

2023-01-20 Thread GitBox
nodece commented on code in PR #19295: URL: https://github.com/apache/pulsar/pull/19295#discussion_r1082207478 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java: ## @@ -61,13 +80,47 @@ public AuthenticationDataSource

[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc

2023-01-20 Thread GitBox
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests:

[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc

2023-01-20 Thread GitBox
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests:

[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc

2023-01-20 Thread GitBox
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests:

[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc

2023-01-20 Thread GitBox
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests:

[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc

2023-01-20 Thread GitBox
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests:

[GitHub] [pulsar] lhotari added a comment to the discussion: How to set up Broker config and other configs like bookie etc

2023-01-20 Thread GitBox
GitHub user lhotari added a comment to the discussion: How to set up Broker config and other configs like bookie etc Here's an example from the pulsar-helm-chart CI tests:

[GitHub] [pulsar-site] momo-jun commented on pull request #386: [feat][doc] Add docs for message dispatch throttling

2023-01-19 Thread GitBox
momo-jun commented on PR #386: URL: https://github.com/apache/pulsar-site/pull/386#issuecomment-1398029056 Ping @tisonkun and @urfreespace to take a look first, because this PR tends to make changes to the Docusaurus configurations to enable the math equation. -- This is an automated

[GitHub] [pulsar] nodece commented on pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor

2023-01-19 Thread GitBox
nodece commented on PR #19295: URL: https://github.com/apache/pulsar/pull/19295#issuecomment-1398022448 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] labuladong commented on issue #19196: [Doc] 2.10* docs provide incorrect command for `namespace set-backlog-quota`

2023-01-19 Thread GitBox
labuladong commented on issue #19196: URL: https://github.com/apache/pulsar/issues/19196#issuecomment-1398018127 > but ideally examples would exist for all three limit cases: just size, just time, and both. I agree. I think this is a bug in the admin interface, I'll create a pr to

[GitHub] [pulsar] nodece merged pull request #19282: [fix][broker] Let TokenAuthState update authenticationDataSource

2023-01-19 Thread GitBox
nodece merged PR #19282: URL: https://github.com/apache/pulsar/pull/19282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nodece merged pull request #19283: [improve][broker] Documentation for AuthenticationState contract

2023-01-19 Thread GitBox
nodece merged PR #19283: URL: https://github.com/apache/pulsar/pull/19283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari opened a new pull request, #19296: [improve][ci] Improve code coverage reporting

2023-01-19 Thread GitBox
lhotari opened a new pull request, #19296: URL: https://github.com/apache/pulsar/pull/19296 ### Motivation After reviewing the latest changes made in #19264 for collecting code coverage in a new way, there are a few details that need to be adjusted. The Codecov results can be

[GitHub] [pulsar] codecov-commenter commented on pull request #19282: [fix][broker] Let TokenAuthState update authenticationDataSource

2023-01-19 Thread GitBox
codecov-commenter commented on PR #19282: URL: https://github.com/apache/pulsar/pull/19282#issuecomment-1398006145 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19282?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-manager] xianwei commented on issue #292: Manager doesn't show the Standalone cluster option for adding to tenant

2023-01-19 Thread GitBox
xianwei commented on issue #292: URL: https://github.com/apache/pulsar-manager/issues/292#issuecomment-1398002920 thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] labuladong commented on issue #19207: [Bug] Didn't updata metadata when try to updata the num of partitions of a partitioned-topic

2023-01-19 Thread GitBox
labuladong commented on issue #19207: URL: https://github.com/apache/pulsar/issues/19207#issuecomment-1398002795 Hi @philixtian, I try to reproduce your issue, but it works well in my local standalone cluster:

[GitHub] [pulsar] nodece commented on pull request #19294: [fix][cli][branch-2.10] Fix mbeans to json

2023-01-19 Thread GitBox
nodece commented on PR #19294: URL: https://github.com/apache/pulsar/pull/19294#issuecomment-1397991490 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] labuladong commented on pull request #19253: [fix][test] testSingleTopicConsumerBatchShortName

2023-01-19 Thread GitBox
labuladong commented on PR #19253: URL: https://github.com/apache/pulsar/pull/19253#issuecomment-1397990790 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19295: [feat][broker] OneStageAuth State: move authn out of constructor

2023-01-19 Thread GitBox
michaeljmarshall opened a new pull request, #19295: URL: https://github.com/apache/pulsar/pull/19295 PIP: #12105 ### Motivation In order to implement PIP 97, we must replace `authenticate` calls with `authenticateAsync`. This PR makes those changes for

[GitHub] [pulsar] codecov-commenter commented on pull request #19283: [improve][broker] Documentation for AuthenticationState contract

2023-01-19 Thread GitBox
codecov-commenter commented on PR #19283: URL: https://github.com/apache/pulsar/pull/19283#issuecomment-1397968208 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19283?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] michaeljmarshall commented on pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
michaeljmarshall commented on PR #18130: URL: https://github.com/apache/pulsar/pull/18130#issuecomment-1397944946 > This PR is a little big, so maybe I should split this PR. Sounds good to me. As far as making things asynchronous, I am happy to follow up on that work. I already have

[GitHub] [pulsar] nodece commented on pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
nodece commented on PR #18130: URL: https://github.com/apache/pulsar/pull/18130#issuecomment-1397891061 This PR is a little big, so maybe I should split this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1082086386 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1082085972 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar-client-node] k2la commented on a diff in pull request #278: [improve][client] Add schema typing to consumer and producer

2023-01-19 Thread GitBox
k2la commented on code in PR #278: URL: https://github.com/apache/pulsar-client-node/pull/278#discussion_r1082082603 ## index.d.ts: ## @@ -236,3 +245,21 @@ export type ConsumerCryptoFailureAction = 'FAIL' | 'DISCARD' | 'CONSUME'; + + export type SchemaType = Review

[GitHub] [pulsar] nodece commented on pull request #17676: [fix][cli] Fix mbeans to json

2023-01-19 Thread GitBox
nodece commented on PR #17676: URL: https://github.com/apache/pulsar/pull/17676#issuecomment-1397883044 @codelipenghui See https://github.com/apache/pulsar/pull/19294. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] nodece opened a new pull request, #19294: [fix][cli] Fix mbeans to json

2023-01-19 Thread GitBox
nodece opened a new pull request, #19294: URL: https://github.com/apache/pulsar/pull/19294 ### Motivation Cherry-pick #17676 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` -- This is an automated

[GitHub] [pulsar] zhoudayu123 commented on issue #19269: [Bug] Error while producing messages

2023-01-19 Thread GitBox
zhoudayu123 commented on issue #19269: URL: https://github.com/apache/pulsar/issues/19269#issuecomment-1397875478 wow, the thrid ec2 logs are differt error log .

[GitHub] [pulsar] Denovo1998 commented on issue #18925: [Bug] Cannot auto delete partitioned topic

2023-01-19 Thread GitBox
Denovo1998 commented on issue #18925: URL: https://github.com/apache/pulsar/issues/18925#issuecomment-1397873629 If you look at the comments in 'InactiveTopicDeleteMode', the deletion action assumes that the producers produced or the consumers subscribed to the topic. That's how it's

[GitHub] [pulsar] zhoudayu123 commented on issue #19269: [Bug] Error while producing messages

2023-01-19 Thread GitBox
zhoudayu123 commented on issue #19269: URL: https://github.com/apache/pulsar/issues/19269#issuecomment-1397873593 the second ec2 broker log is different https://user-images.githubusercontent.com/51695477/213609112-1a2d4c8b-4294-438d-bd44-9c8443867a3d.png;> -- This is an automated

[GitHub] [pulsar] codecov-commenter commented on pull request #19045: [improve][broker] PIP-192 Added ServiceUnitStateCompactionStrategy

2023-01-19 Thread GitBox
codecov-commenter commented on PR #19045: URL: https://github.com/apache/pulsar/pull/19045#issuecomment-1397872279 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19045?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] zhoudayu123 commented on issue #19269: [Bug] Error while producing messages

2023-01-19 Thread GitBox
zhoudayu123 commented on issue #19269: URL: https://github.com/apache/pulsar/issues/19269#issuecomment-1397865074 [pulsar-broker-ip-10-106-45-231.us-west-2.compute.internal.log](https://github.com/apache/pulsar/files/10462843/pulsar-broker-ip-10-106-45-231.us-west-2.compute.internal.log)

[GitHub] [pulsar] nodece commented on pull request #19293: [fix][websocket][branch-2.9] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
nodece commented on PR #19293: URL: https://github.com/apache/pulsar/pull/19293#issuecomment-1397859952 Ping @poorbarcode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] nodece opened a new pull request, #19293: [fix][websocket][branch-2.9] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
nodece opened a new pull request, #19293: URL: https://github.com/apache/pulsar/pull/19293 ### Motivation Cherry-pick #19256 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` -- This is an automated

[GitHub] [pulsar] nodece merged pull request #19256: [fix][websocket] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
nodece merged PR #19256: URL: https://github.com/apache/pulsar/pull/19256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun commented on pull request #19281: [improve][io] Upgrade Alluxio to 2.8.1

2023-01-19 Thread GitBox
tisonkun commented on PR #19281: URL: https://github.com/apache/pulsar/pull/19281#issuecomment-1397844465 @sekikn Thanks for your investigation! I'm not quite sure what our policy is to handle such b/w compatibility issues. Generally, client libs will keep it so version bumps are

[GitHub] [pulsar] poorbarcode closed pull request #19274: [Do not merge][Issue] Reproduce:Topics stats shows msgBacklog but there reality no backlog

2023-01-19 Thread GitBox
poorbarcode closed pull request #19274: [Do not merge][Issue] Reproduce:Topics stats shows msgBacklog but there reality no backlog URL: https://github.com/apache/pulsar/pull/19274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] sekikn commented on pull request #19281: [improve][io] Upgrade Alluxio to 2.8.1

2023-01-19 Thread GitBox
sekikn commented on PR #19281: URL: https://github.com/apache/pulsar/pull/19281#issuecomment-1397840229 Thank you for the review @Jason918 @tisonkun! As @tisonkun pointed out, I found this PR (upgrading client to 2.8.1) doesn't work with the old version of Alluxio server (2.7.3), probably

[GitHub] [pulsar] sekikn closed pull request #19281: [improve][io] Upgrade Alluxio to 2.8.1

2023-01-19 Thread GitBox
sekikn closed pull request #19281: [improve][io] Upgrade Alluxio to 2.8.1 URL: https://github.com/apache/pulsar/pull/19281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19256: [fix][websocket] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
poorbarcode commented on code in PR #19256: URL: https://github.com/apache/pulsar/pull/19256#discussion_r1082050185 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java: ## @@ -192,18 +191,15 @@ private void closePingFuture() {

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19289: [branch-2.11][cherry-pick] Close TransactionBuffer when MessageDeduplication#checkStatus failed

2023-01-19 Thread GitBox
Technoboy- commented on code in PR #19289: URL: https://github.com/apache/pulsar/pull/19289#discussion_r1082048686 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TopicTransactionBufferTest.java: ## @@ -1,4 +1,4 @@ -/** +/* Review Comment: Need to

[GitHub] [pulsar] github-actions[bot] commented on issue #17987: [Bug] Issue with implementing TLSAuthentication using Java

2023-01-19 Thread GitBox
github-actions[bot] commented on issue #17987: URL: https://github.com/apache/pulsar/issues/17987#issuecomment-1397836409 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on pull request #18553: [improve][broker] Make dispatch rate limiter more precise

2023-01-19 Thread GitBox
github-actions[bot] commented on PR #18553: URL: https://github.com/apache/pulsar/pull/18553#issuecomment-1397835706 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #18993: [Bug] DBStorageCleanup always logs Deleted Indexes for entries as 0

2023-01-19 Thread GitBox
github-actions[bot] commented on issue #18993: URL: https://github.com/apache/pulsar/issues/18993#issuecomment-1397835301 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Technoboy- closed pull request #19045: [improve][broker] PIP-192 Added ServiceUnitStateCompactionStrategy

2023-01-19 Thread GitBox
Technoboy- closed pull request #19045: [improve][broker] PIP-192 Added ServiceUnitStateCompactionStrategy URL: https://github.com/apache/pulsar/pull/19045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Technoboy- closed pull request #19289: [branch-2.11][cherry-pick] Close TransactionBuffer when MessageDeduplication#checkStatus failed

2023-01-19 Thread GitBox
Technoboy- closed pull request #19289: [branch-2.11][cherry-pick] Close TransactionBuffer when MessageDeduplication#checkStatus failed URL: https://github.com/apache/pulsar/pull/19289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19256: [fix][websocket] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
Technoboy- commented on code in PR #19256: URL: https://github.com/apache/pulsar/pull/19256#discussion_r1082044135 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java: ## @@ -803,6 +803,12 @@ public class ProxyConfiguration implements

[GitHub] [pulsar] lhotari merged pull request #19264: [fix][ci] Fix Jacoco code coverage to report classes in dependent projects

2023-01-19 Thread GitBox
lhotari merged PR #19264: URL: https://github.com/apache/pulsar/pull/19264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao merged pull request #19275: [fix] [ml] Topics stats shows msgBacklog but there reality no backlog

2023-01-19 Thread GitBox
mattisonchao merged PR #19275: URL: https://github.com/apache/pulsar/pull/19275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19292: [feat][sec] PIP 97: Implement for ProxyConnection

2023-01-19 Thread GitBox
michaeljmarshall opened a new pull request, #19292: URL: https://github.com/apache/pulsar/pull/19292 PIP: #12105 ### Motivation Implement asynchronous auth for the proxy connection. This work is a draft because I only just discovered a dependency on replacing all calls to

[GitHub] [pulsar] michaeljmarshall opened a new issue, #19291: [Bug] Proxy does not forward credentials correctly for multi-staged authentication

2023-01-19 Thread GitBox
michaeljmarshall opened a new issue, #19291: URL: https://github.com/apache/pulsar/issues/19291 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version Master (and presumably all

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
michaeljmarshall commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1081884407 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,

[GitHub] [pulsar] michaeljmarshall commented on issue #10816: PulsarProxy does not always refresh authentication tokens received from client

2023-01-19 Thread GitBox
michaeljmarshall commented on issue #10816: URL: https://github.com/apache/pulsar/issues/10816#issuecomment-1397628555 I identified an addition issue with #17831. Specifically, we go to `Connecting` state when the broker challenges the client's auth. That is a problem because it could lead

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
michaeljmarshall commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1081874658 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
michaeljmarshall commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1081872348 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,

[GitHub] [pulsar] asafm commented on pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-19 Thread GitBox
asafm commented on PR #19208: URL: https://github.com/apache/pulsar/pull/19208#issuecomment-1397546362 Sorry about this. I think my [comment](https://github.com/apache/pulsar/pull/19208#discussion_r1081486335) thread has been hiding as resolved, so I'm resurfacing it if that's ok

[GitHub] [pulsar] merlimat merged pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-19 Thread GitBox
merlimat merged PR #19208: URL: https://github.com/apache/pulsar/pull/19208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] poorbarcode commented on pull request #19275: [fix] [ml] Topics stats shows msgBacklog but there reality no backlog

2023-01-19 Thread GitBox
poorbarcode commented on PR #19275: URL: https://github.com/apache/pulsar/pull/19275#issuecomment-1397474820 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19282: [fix][broker] Let TokenAuthState update authenticationDataSource

2023-01-19 Thread GitBox
michaeljmarshall commented on code in PR #19282: URL: https://github.com/apache/pulsar/pull/19282#discussion_r1081673239 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -375,6 +383,7 @@ public String

[GitHub] [pulsar] nlu90 commented on a diff in pull request #15907: [feature][functions]Support auth for function go

2023-01-19 Thread GitBox
nlu90 commented on code in PR #15907: URL: https://github.com/apache/pulsar/pull/15907#discussion_r1081625569 ## pulsar-function-go/conf/conf.go: ## @@ -77,6 +77,9 @@ type Conf struct { UserConfig string `json:"userConfig" yaml:"userConfig"`

[GitHub] [pulsar] lhotari commented on a diff in pull request #19282: [fix][broker] Let TokenAuthState update authenticationDataSource

2023-01-19 Thread GitBox
lhotari commented on code in PR #19282: URL: https://github.com/apache/pulsar/pull/19282#discussion_r1081623676 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -375,6 +383,7 @@ public String getAuthRole()

[GitHub] [pulsar] lhotari commented on a diff in pull request #19282: [fix][broker] Let TokenAuthState update authenticationDataSource

2023-01-19 Thread GitBox
lhotari commented on code in PR #19282: URL: https://github.com/apache/pulsar/pull/19282#discussion_r1081623676 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -375,6 +383,7 @@ public String getAuthRole()

[GitHub] [pulsar] tjiuming commented on issue #19269: [Bug] Error while producing messages

2023-01-19 Thread GitBox
tjiuming commented on issue #19269: URL: https://github.com/apache/pulsar/issues/19269#issuecomment-1397358034 Did there are error logs in the broker side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] tjiuming commented on issue #19269: [Bug] Error while producing messages

2023-01-19 Thread GitBox
tjiuming commented on issue #19269: URL: https://github.com/apache/pulsar/issues/19269#issuecomment-1397341586 Seems your topic name is incorrect, topic name should follow the pattern `persistent/non-persistent://tenant/namespace/topic`. But, it's also an issue, we need to check the

[GitHub] [pulsar] nodece commented on a diff in pull request #19256: [fix][websocket] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
nodece commented on code in PR #19256: URL: https://github.com/apache/pulsar/pull/19256#discussion_r1081486686 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java: ## @@ -192,18 +191,15 @@ private void closePingFuture() { @Override

[GitHub] [pulsar] asafm commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-19 Thread GitBox
asafm commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1081486335 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +62,50 @@ public static MetadataStoreExtended

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1081481553 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar] nicoloboschi opened a new pull request, #19290: [fix][fn] Fix TLS configuration for fn worker to broker if auth disabled

2023-01-19 Thread GitBox
nicoloboschi opened a new pull request, #19290: URL: https://github.com/apache/pulsar/pull/19290 ### Motivation Regression of https://github.com/apache/pulsar/pull/11681 In case of standalone functions worker, the pulsar client connected to the broker doesn't pick up the

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1081481553 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1081478717 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar] lhotari commented on pull request #19285: [improve][broker]Fix recycling OpReadEntry without resetting count

2023-01-19 Thread GitBox
lhotari commented on PR #19285: URL: https://github.com/apache/pulsar/pull/19285#issuecomment-1397200054 > OpReadEntry has been reseted, but count was not reseted. @gaozhangmin Please describe the impact of this. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-19 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1081463873 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19256: [fix][websocket] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
poorbarcode commented on code in PR #19256: URL: https://github.com/apache/pulsar/pull/19256#discussion_r1081437289 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java: ## @@ -192,18 +191,15 @@ private void closePingFuture() {

[GitHub] [pulsar] nodece commented on pull request #19256: [fix][websocket] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
nodece commented on PR #19256: URL: https://github.com/apache/pulsar/pull/19256#issuecomment-1397152986 branch-2.10 and branch-2.11 include these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] nodece commented on a diff in pull request #19256: [fix][websocket] Fix webSocketPingDurationSeconds config

2023-01-19 Thread GitBox
nodece commented on code in PR #19256: URL: https://github.com/apache/pulsar/pull/19256#discussion_r1081433085 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java: ## @@ -192,18 +191,15 @@ private void closePingFuture() { @Override

[GitHub] [pulsar] frankjkelly commented on issue #16249: Pulsar Admin API client should support retries on operations

2023-01-19 Thread GitBox
frankjkelly commented on issue #16249: URL: https://github.com/apache/pulsar/issues/16249#issuecomment-1397034421 @eolivelli Thank you - yes that was my thinking / hope too - consistency is awesome as it reduces cognitive load and anything that helps "pave a golden path" will help with

[GitHub] [pulsar] eolivelli merged pull request #19284: [fix][broker] AbstractBatchedMetadataStore - use AlreadyClosedException instead of IllegalStateException

2023-01-19 Thread GitBox
eolivelli merged PR #19284: URL: https://github.com/apache/pulsar/pull/19284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] eolivelli commented on pull request #19284: [bugfix] AbstractBatchedMetadataStore - use AlreadyClosedException instead of IllegalStateException

2023-01-19 Thread GitBox
eolivelli commented on PR #19284: URL: https://github.com/apache/pulsar/pull/19284#issuecomment-1396972753 @codelipenghui I am not sure that it is worth to cover this change with a test case. This fact happens when the broker is shutting down. -- This is an automated message from the

[GitHub] [pulsar] Debashish-Mallick commented on issue #19267: backlog quota is not reflecting on topic level

2023-01-19 Thread GitBox
Debashish-Mallick commented on issue #19267: URL: https://github.com/apache/pulsar/issues/19267#issuecomment-1396913622 > Could you provide the dump file of the issued broker? Reproduced again and sharing the logs and dumps.

[GitHub] [pulsar] andrasbeni commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-19 Thread GitBox
andrasbeni commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1081205419 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +62,50 @@ public static MetadataStoreExtended

[GitHub] [pulsar] andrasbeni commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-19 Thread GitBox
andrasbeni commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1081205419 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +62,50 @@ public static MetadataStoreExtended

[GitHub] [pulsar] tjiuming commented on pull request #19157: [fix][broker] Close transactionBuffer after MessageDeduplication#checkStatus failed

2023-01-19 Thread GitBox
tjiuming commented on PR #19157: URL: https://github.com/apache/pulsar/pull/19157#issuecomment-1396905188 https://github.com/apache/pulsar/pull/19287 https://github.com/apache/pulsar/pull/19288 https://github.com/apache/pulsar/pull/19289 -- This is an automated message from the

[GitHub] [pulsar] tjiuming opened a new pull request, #19289: [branch-2.11][cherry-pick] Close TransactionBuffer when MessageDeduplication#checkStatus failed

2023-01-19 Thread GitBox
tjiuming opened a new pull request, #19289: URL: https://github.com/apache/pulsar/pull/19289 ### Motivation Cherry-pick https://github.com/apache/pulsar/pull/19157 into branch-2.11 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x]

[GitHub] [pulsar] tjiuming opened a new pull request, #19288: [branch-2.10][cherry-pick] Close TransactionBuffer when MessageDeduplication#checkStatus failed

2023-01-19 Thread GitBox
tjiuming opened a new pull request, #19288: URL: https://github.com/apache/pulsar/pull/19288 ### Motivation Cherry-pick https://github.com/apache/pulsar/pull/19157 into branch-2.10 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x]

[GitHub] [pulsar] codecov-commenter commented on pull request #19275: [fix] [ml] Topics stats shows msgBacklog but there reality no backlog

2023-01-19 Thread GitBox
codecov-commenter commented on PR #19275: URL: https://github.com/apache/pulsar/pull/19275#issuecomment-1396877999 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19275?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19275: [fix] [ml] Topics stats shows msgBacklog but there reality no backlog

2023-01-19 Thread GitBox
mattisonchao commented on code in PR #19275: URL: https://github.com/apache/pulsar/pull/19275#discussion_r1081169593 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -993,12 +993,11 @@ public synchronized void

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19275: [fix] [ml] Topics stats shows msgBacklog but there reality no backlog

2023-01-19 Thread GitBox
mattisonchao commented on code in PR #19275: URL: https://github.com/apache/pulsar/pull/19275#discussion_r1081169593 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -993,12 +993,11 @@ public synchronized void

<    1   2   3   4   5   6   7   8   9   10   >