[GitHub] [airflow] kaxil commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

2019-12-02 Thread GitBox
kaxil commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#issuecomment-560911546 > @kaxil I agree, but for now I am trying to solve one problem. This change is already very big - +2,256

[GitHub] [airflow] codecov-io edited a comment on issue #6702: [AIRFLOW-6140] Add missing types for some core classes. Depends on [AIRFLOW-6004]

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6702: [AIRFLOW-6140] Add missing types for some core classes. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6702#issuecomment-560257785 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6702?src=pr=h1) Report > Merging

[GitHub] [airflow] mik-laj opened a new pull request #6717: [AIRFLOW-6160] Move _check_and_change_state_before_execution to LocalTaskJob

2019-12-02 Thread GitBox
mik-laj opened a new pull request #6717: [AIRFLOW-6160] Move _check_and_change_state_before_execution to LocalTaskJob URL: https://github.com/apache/airflow/pull/6717 Hello I think that LocaclTaskJob should control which tasks are to be executed. SchedulerJob and BackfillingJob

[jira] [Commented] (AIRFLOW-6160) Move _check_and_change_state_before_execution to LocalTaskJob

2019-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986485#comment-16986485 ] ASF GitHub Bot commented on AIRFLOW-6160: - mik-laj commented on pull request #6717:

[GitHub] [airflow] codecov-io edited a comment on issue #6696: [AIRFLOW-6128] Simplify plugins_manager and webserver plugin code. Based on [AIRFLOW-6004] [AIRFLOW-6140]

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6696: [AIRFLOW-6128] Simplify plugins_manager and webserver plugin code. Based on [AIRFLOW-6004] [AIRFLOW-6140] URL: https://github.com/apache/airflow/pull/6696#issuecomment-560183548 #

[GitHub] [airflow] codecov-io edited a comment on issue #6599: [AIRFLOW-6007] Check providers instead of provider package. Depends on [AIRFLOW-6004]

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6599: [AIRFLOW-6007] Check providers instead of provider package. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6599#issuecomment-560146249 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6599?src=pr=h1) Report >

[GitHub] [airflow] stale[bot] closed pull request #6288: AIRFLOW-5540 adding rise exception when the _resolve_connection method fails

2019-12-02 Thread GitBox
stale[bot] closed pull request #6288: AIRFLOW-5540 adding rise exception when the _resolve_connection method fails URL: https://github.com/apache/airflow/pull/6288 This is an automated message from the Apache Git Service.

[jira] [Commented] (AIRFLOW-5540) task with SparkSubmitOperator does not fail if the spark job it executes fails.

2019-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986511#comment-16986511 ] ASF GitHub Bot commented on AIRFLOW-5540: - stale[bot] commented on pull request #6288:

[jira] [Commented] (AIRFLOW-6014) Kubernetes executor - handle preempted deleted pods - queued tasks

2019-12-02 Thread afusr (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986672#comment-16986672 ] afusr commented on AIRFLOW-6014: [~dimberman] Do you think this can be merged? This fixed has saved us

[GitHub] [airflow] mik-laj commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

2019-12-02 Thread GitBox
mik-laj commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#discussion_r352892463 ## File path: airflow/jobs/scheduler_job.py ## @@ -54,8 +54,9 @@ from

[jira] [Created] (AIRFLOW-6160) Move _check_and_change_state_before_execution to LocalTaskJob

2019-12-02 Thread Kamil Bregula (Jira)
Kamil Bregula created AIRFLOW-6160: -- Summary: Move _check_and_change_state_before_execution to LocalTaskJob Key: AIRFLOW-6160 URL: https://issues.apache.org/jira/browse/AIRFLOW-6160 Project: Apache

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352942991 ## File path: airflow/executors/kubernetes_executor.py ## @@ -256,15 +256,15 @@ class

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352942604 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352942743 ## File path: airflow/executors/dask_executor.py ## @@ -66,20 +63,17 @@ def

[jira] [Resolved] (AIRFLOW-6069) Host Travis build should use always python 3.6

2019-12-02 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-6069. - Resolution: Fixed > Host Travis build should use always python 3.6 >

[GitHub] [airflow] codecov-io edited a comment on issue #6702: [AIRFLOW-6140] Add missing types for some core classes. Depends on [AIRFLOW-6004]

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6702: [AIRFLOW-6140] Add missing types for some core classes. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6702#issuecomment-560257785 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6702?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on a change in pull request #6702: [AIRFLOW-6140] Add missing types for some core classes. Depends on [AIRFLOW-6004]

2019-12-02 Thread GitBox
kaxil commented on a change in pull request #6702: [AIRFLOW-6140] Add missing types for some core classes. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6702#discussion_r352921900 ## File path: airflow/executors/executor_loader.py ## @@ -25,11

[GitHub] [airflow] kaxil commented on a change in pull request #6702: [AIRFLOW-6140] Add missing types for some core classes. Depends on [AIRFLOW-6004]

2019-12-02 Thread GitBox
kaxil commented on a change in pull request #6702: [AIRFLOW-6140] Add missing types for some core classes. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6702#discussion_r352922159 ## File path: airflow/models/baseoperator.py ## @@ -869,11 +877,16

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352941360 ## File path: airflow/executors/dask_executor.py ## @@ -36,9 +35,7 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352941360 ## File path: airflow/executors/dask_executor.py ## @@ -36,9 +35,7 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352941360 ## File path: airflow/executors/dask_executor.py ## @@ -36,9 +35,7 @@ def

[GitHub] [airflow] codecov-io edited a comment on issue #6715: [AIRFLOW-5945] Make inbuilt OperatorLinks work when using Serialization

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6715: [AIRFLOW-5945] Make inbuilt OperatorLinks work when using Serialization URL: https://github.com/apache/airflow/pull/6715#issuecomment-560962980 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6715?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6715: [AIRFLOW-5945] Make inbuilt OperatorLinks work when using Serialization

2019-12-02 Thread GitBox
codecov-io commented on issue #6715: [AIRFLOW-5945] Make inbuilt OperatorLinks work when using Serialization URL: https://github.com/apache/airflow/pull/6715#issuecomment-560962980 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6715?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil merged pull request #6716: [AIRFLOW-6159] Change logging level of the heartbeat message to DEBUG

2019-12-02 Thread GitBox
kaxil merged pull request #6716: [AIRFLOW-6159] Change logging level of the heartbeat message to DEBUG URL: https://github.com/apache/airflow/pull/6716 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ITriangle closed pull request #6707: Fix task get log

2019-12-02 Thread GitBox
ITriangle closed pull request #6707: Fix task get log URL: https://github.com/apache/airflow/pull/6707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (AIRFLOW-6159) Change logging level of the heartbeat message to DEBUG

2019-12-02 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-6159. - Fix Version/s: 1.10.7 Resolution: Fixed > Change logging level of the heartbeat message

[jira] [Commented] (AIRFLOW-6159) Change logging level of the heartbeat message to DEBUG

2019-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986525#comment-16986525 ] ASF subversion and git services commented on AIRFLOW-6159: -- Commit

[jira] [Commented] (AIRFLOW-6159) Change logging level of the heartbeat message to DEBUG

2019-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986524#comment-16986524 ] ASF GitHub Bot commented on AIRFLOW-6159: - kaxil commented on pull request #6716:

[jira] [Created] (AIRFLOW-6161) GoogleCloudBaseHook delegate_to doesn't work with GCE service account

2019-12-02 Thread Guillaume Poulin (Jira)
Guillaume Poulin created AIRFLOW-6161: - Summary: GoogleCloudBaseHook delegate_to doesn't work with GCE service account Key: AIRFLOW-6161 URL: https://issues.apache.org/jira/browse/AIRFLOW-6161

[GitHub] [airflow] OmerJog commented on issue #6261: [AIRFLOW-5141] Added optional resource usage logging to KubernetesPod…

2019-12-02 Thread GitBox
OmerJog commented on issue #6261: [AIRFLOW-5141] Added optional resource usage logging to KubernetesPod… URL: https://github.com/apache/airflow/pull/6261#issuecomment-561041583 @Sinsin1367 there is a conflict to resolve This

[jira] [Closed] (AIRFLOW-6097) AIP-21: Rename services

2019-12-02 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik closed AIRFLOW-6097. --- Resolution: Implemented Some of these are already implemented /changed. Have you checked the list

[jira] [Commented] (AIRFLOW-6097) AIP-21: Rename services

2019-12-02 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986678#comment-16986678 ] Michał Słowikowski commented on AIRFLOW-6097: - [~kaxilnaik] Yes, I have a list of modules

[GitHub] [airflow] codecov-io edited a comment on issue #6599: [AIRFLOW-6007] Check providers instead of provider package. Depends on [AIRFLOW-6004]

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6599: [AIRFLOW-6007] Check providers instead of provider package. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6599#issuecomment-560146249 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6599?src=pr=h1) Report >

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352943542 ## File path: airflow/utils/dag_processing.py ## @@ -550,8 +549,8 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352943496 ## File path: airflow/logging_config.py ## @@ -1,3 +1,4 @@ +# -*- coding: utf-8 -*-

[GitHub] [airflow] shaikshakeel commented on issue #6469: [AIRFLOW-5816] S3 to snowflake operator

2019-12-02 Thread GitBox
shaikshakeel commented on issue #6469: [AIRFLOW-5816] S3 to snowflake operator URL: https://github.com/apache/airflow/pull/6469#issuecomment-560502774 @mik-laj @potiuk can you confirm this. I will change accordingly This is

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352740146 ## File path: airflow/executors/celery_executor.py ## @@ -264,30 +284,45 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352741740 ## File path: airflow/executors/dask_executor.py ## @@ -55,23 +58,28 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352742152 ## File path: airflow/executors/kubernetes_executor.py ## @@ -601,18 +629,19 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352743665 ## File path: airflow/executors/kubernetes_executor.py ## @@ -241,17 +253,23 @@ def

[GitHub] [airflow] eladkal closed pull request #6703: [AIRFLOW-XXX] add notice for Mesos Executor deprecation in docs

2019-12-02 Thread GitBox
eladkal closed pull request #6703: [AIRFLOW-XXX] add notice for Mesos Executor deprecation in docs URL: https://github.com/apache/airflow/pull/6703 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] eladkal opened a new pull request #6712: [AIRFLOW-XXX] add notice for Mesos Executor deprecation in docs

2019-12-02 Thread GitBox
eladkal opened a new pull request #6712: [AIRFLOW-XXX] add notice for Mesos Executor deprecation in docs URL: https://github.com/apache/airflow/pull/6712 ### Description MesosExecutor is deprecated from Master https://github.com/apache/airflow/pull/5115 but there is no notice in

[GitHub] [airflow] codecov-io edited a comment on issue #6652: [AIRFLOW-5548] [AIRFLOW-5550] REST API enhancement - dag info, task …

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6652: [AIRFLOW-5548] [AIRFLOW-5550] REST API enhancement - dag info, task … URL: https://github.com/apache/airflow/pull/6652#issuecomment-558277657 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6652?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352747261 ## File path: airflow/executors/local_executor.py ## @@ -43,40 +42,44 @@ This option

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352747865 ## File path: airflow/executors/local_executor.py ## @@ -43,40 +42,44 @@ This option

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352748235 ## File path: airflow/logging_config.py ## @@ -1,4 +1,3 @@ -# -*- coding: utf-8 -*-

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352748854 ## File path: airflow/models/dag.py ## @@ -1254,9 +1253,11 @@ def run( """

[GitHub] [airflow] houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-12-02 Thread GitBox
houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r352748672 ## File path: airflow/jobs/base_job.py ## @@ -171,17 +171,14 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352749876 ## File path: airflow/settings.py ## @@ -68,13 +67,13 @@ LOG_FORMAT =

[GitHub] [airflow] houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-12-02 Thread GitBox
houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r352749458 ## File path: airflow/jobs/local_task_job.py ## @@ -112,13 +111,6 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352681948 ## File path: CONTRIBUTING.rst ## @@ -742,8 +495,56 @@ Resources & links - Airflow users mailing list: ``_ -- `Issues on

[GitHub] [airflow] ashb commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352688262 ## File path: CONTRIBUTING.rst ## @@ -742,8 +495,56 @@ Resources & links - Airflow users mailing list: ``_ -- `Issues on

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352705135 ## File path: airflow/plugins_manager.py ## @@ -187,26 +192,29 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352704490 ## File path: airflow/plugins_manager.py ## @@ -16,17 +15,18 @@ # KIND, either

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352694783 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352698312 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352697033 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

[GitHub] [airflow] codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest URL: https://github.com/apache/airflow/pull/6472#issuecomment-558580149 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6472?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest URL: https://github.com/apache/airflow/pull/6472#issuecomment-558580149 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6472?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest URL: https://github.com/apache/airflow/pull/6472#issuecomment-558580149 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6472?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352731417 ## File path: airflow/executors/base_executor.py ## @@ -16,67 +14,86 @@ # KIND,

[GitHub] [airflow] houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-12-02 Thread GitBox
houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r352750606 ## File path: tests/jobs/test_local_task_job.py ## @@ -43,6 +43,9 @@

[GitHub] [airflow] potiuk commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352680690 ## File path: CONTRIBUTING.rst ## @@ -742,8 +495,56 @@ Resources & links Review comment: Added info on that

[GitHub] [airflow] ashb commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352688262 ## File path: CONTRIBUTING.rst ## @@ -742,8 +495,56 @@ Resources & links - Airflow users mailing list: ``_ -- `Issues on

[GitHub] [airflow] potiuk commented on issue #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on issue #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#issuecomment-560466337 I think it's best to simply refer to CONTRIBUTING.rst in github from the Airflow Website :) This

[GitHub] [airflow] codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest URL: https://github.com/apache/airflow/pull/6472#issuecomment-558580149 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6472?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6708: [AIRFLOW-XXX] Fix docstring minor issues in airflow/kubernetes/

2019-12-02 Thread GitBox
codecov-io commented on issue #6708: [AIRFLOW-XXX] Fix docstring minor issues in airflow/kubernetes/ URL: https://github.com/apache/airflow/pull/6708#issuecomment-560476641 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6708?src=pr=h1) Report > Merging

[GitHub] [airflow] aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers

2019-12-02 Thread GitBox
aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers URL: https://github.com/apache/airflow/pull/6709#discussion_r352726026 ## File path: pylintrc ## @@ -154,6 +154,8 @@ disable=print-statement,

[GitHub] [airflow] potiuk commented on issue #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on issue #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#issuecomment-560467762 Review comments applied. This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6472: [AIRFLOW-6058] Running tests with pytest URL: https://github.com/apache/airflow/pull/6472#issuecomment-558580149 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6472?src=pr=h1) Report > Merging

[jira] [Created] (AIRFLOW-6154) dag_processor_manager log path ignores log directory config

2019-12-02 Thread Ronald Fenner (Jira)
Ronald Fenner created AIRFLOW-6154: -- Summary: dag_processor_manager log path ignores log directory config Key: AIRFLOW-6154 URL: https://issues.apache.org/jira/browse/AIRFLOW-6154 Project: Apache

[GitHub] [airflow] msumit commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers

2019-12-02 Thread GitBox
msumit commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers URL: https://github.com/apache/airflow/pull/6709#discussion_r352719535 ## File path: pylintrc ## @@ -154,6 +154,8 @@ disable=print-statement,

[GitHub] [airflow] aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers

2019-12-02 Thread GitBox
aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers URL: https://github.com/apache/airflow/pull/6709#discussion_r352718565 ## File path: airflow/cli/commands/worker_command.py ## @@ -59,6 +62,12 @@ def

[GitHub] [airflow] aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers

2019-12-02 Thread GitBox
aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers URL: https://github.com/apache/airflow/pull/6709#discussion_r352723411 ## File path: airflow/cli/commands/worker_command.py ## @@ -76,17 +85,19 @@ def

[GitHub] [airflow] aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers

2019-12-02 Thread GitBox
aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers URL: https://github.com/apache/airflow/pull/6709#discussion_r352721673 ## File path: pylintrc ## @@ -154,6 +154,8 @@ disable=print-statement,

[GitHub] [airflow] aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers

2019-12-02 Thread GitBox
aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers URL: https://github.com/apache/airflow/pull/6709#discussion_r352720846 ## File path: airflow/cli/commands/worker_command.py ## @@ -76,17 +85,19 @@ def

[GitHub] [airflow] potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#issuecomment-560518806 > Still a few unrelated files changed. > > Also we've got inconsistent imports airflow.configuration import conf

[GitHub] [airflow] potiuk commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

2019-12-02 Thread GitBox
potiuk commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#issuecomment-560519623 > (Will likely conflict with #6596) Yep. That's why I think it's better to review this one after it is

[jira] [Commented] (AIRFLOW-6142) Different results for pylint locally and in Travis CI

2019-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986256#comment-16986256 ] ASF subversion and git services commented on AIRFLOW-6142: -- Commit

[GitHub] [airflow] potiuk merged pull request #6705: [AIRFLOW-6142] Fix different local/Travis pylint results

2019-12-02 Thread GitBox
potiuk merged pull request #6705: [AIRFLOW-6142] Fix different local/Travis pylint results URL: https://github.com/apache/airflow/pull/6705 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-6142) Different results for pylint locally and in Travis CI

2019-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986255#comment-16986255 ] ASF subversion and git services commented on AIRFLOW-6142: -- Commit

[jira] [Resolved] (AIRFLOW-6142) Different results for pylint locally and in Travis CI

2019-12-02 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-6142. --- Fix Version/s: 2.0.0 Resolution: Fixed > Different results for pylint locally and

[jira] [Commented] (AIRFLOW-6142) Different results for pylint locally and in Travis CI

2019-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986254#comment-16986254 ] ASF GitHub Bot commented on AIRFLOW-6142: - potiuk commented on pull request #6705:

[GitHub] [airflow] potiuk commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352762271 ## File path: CONTRIBUTING.rst ## @@ -742,8 +495,56 @@ Resources & links - Airflow users mailing list: ``_ -- `Issues on

[GitHub] [airflow] potiuk commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352763339 ## File path: CONTRIBUTING.rst ## @@ -742,8 +495,56 @@ Resources & links - Airflow users mailing list: ``_ -- `Issues on

[GitHub] [airflow] potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#issuecomment-560527624 I think NOW I resolved everything that needs to be resolved in this commit (some more commits are following), I let

[GitHub] [airflow] codecov-io commented on issue #6712: [AIRFLOW-XXX] add notice for Mesos Executor deprecation in docs

2019-12-02 Thread GitBox
codecov-io commented on issue #6712: [AIRFLOW-XXX] add notice for Mesos Executor deprecation in docs URL: https://github.com/apache/airflow/pull/6712#issuecomment-560535226 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6712?src=pr=h1) Report > Merging

[jira] [Created] (AIRFLOW-6155) Add some reading and writing functionality to the GCP Bigtable hook

2019-12-02 Thread Emily Mazo (Jira)
Emily Mazo created AIRFLOW-6155: --- Summary: Add some reading and writing functionality to the GCP Bigtable hook Key: AIRFLOW-6155 URL: https://issues.apache.org/jira/browse/AIRFLOW-6155 Project: Apache

[jira] [Created] (AIRFLOW-6149) Rename postgres_to_gcs. service

2019-12-02 Thread Jira
Michał Słowikowski created AIRFLOW-6149: --- Summary: Rename postgres_to_gcs. service Key: AIRFLOW-6149 URL: https://issues.apache.org/jira/browse/AIRFLOW-6149 Project: Apache Airflow

[jira] [Created] (AIRFLOW-6150) Rename cassandra_to_gcs. service

2019-12-02 Thread Jira
Michał Słowikowski created AIRFLOW-6150: --- Summary: Rename cassandra_to_gcs. service Key: AIRFLOW-6150 URL: https://issues.apache.org/jira/browse/AIRFLOW-6150 Project: Apache Airflow

[GitHub] [airflow] mik-laj commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

2019-12-02 Thread GitBox
mik-laj commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#issuecomment-560291492 @ashb @potiuk @kaxil @nuclearpinguin It works for me. Can you look at it?

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352492591 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
nuclearpinguin commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352510424 ## File path: LOCAL_VIRTUALENV.rst ## @@ -19,15 +19,15 @@ .. contents:: :local: Local Virtual Environment

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
nuclearpinguin commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352510570 ## File path: LOCAL_VIRTUALENV.rst ## @@ -19,15 +19,15 @@ .. contents:: :local: Local Virtual Environment

[GitHub] [airflow] potiuk commented on issue #6706: [AIRFLOW-6143] Remove master-failing pylint:disables

2019-12-02 Thread GitBox
potiuk commented on issue #6706: [AIRFLOW-6143] Remove master-failing pylint:disables URL: https://github.com/apache/airflow/pull/6706#issuecomment-560284151 Thanks @Fokko ! This is an automated message from the Apache Git

[jira] [Created] (AIRFLOW-6146) Rename gcs_to_bq service

2019-12-02 Thread Jira
Michał Słowikowski created AIRFLOW-6146: --- Summary: Rename gcs_to_bq service Key: AIRFLOW-6146 URL: https://issues.apache.org/jira/browse/AIRFLOW-6146 Project: Apache Airflow Issue

[GitHub] [airflow] mik-laj commented on issue #6359: [AIRFLOW-XXX] Change instances "Google cloud storage" to "Google Cloud Storage".

2019-12-02 Thread GitBox
mik-laj commented on issue #6359: [AIRFLOW-XXX] Change instances "Google cloud storage" to "Google Cloud Storage". URL: https://github.com/apache/airflow/pull/6359#issuecomment-560289355 @dgorelik Can you do rebase? Travis is sad, because master branch was broken.

[jira] [Created] (AIRFLOW-6152) Rename bigquery_to_gcs service

2019-12-02 Thread Jira
Michał Słowikowski created AIRFLOW-6152: --- Summary: Rename bigquery_to_gcs service Key: AIRFLOW-6152 URL: https://issues.apache.org/jira/browse/AIRFLOW-6152 Project: Apache Airflow

[GitHub] [airflow] potiuk commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

2019-12-02 Thread GitBox
potiuk commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#issuecomment-560293372 Yeah. Seems we have a lot of big changes to the code recently. I will take a look shortly.

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352491482 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

  1   2   3   >