[GitHub] [calcite] ffmax closed pull request #1400: make every SqlDialect parse their own data type

ffmax closed pull request #1400: make every SqlDialect parse their own data type URL: https://github.com/apache/calcite/pull/1400 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] danny0405 commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

danny0405 commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#discussion_r316480310 ## File path:

[GitHub] [calcite] LiShuMing opened a new pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li)

LiShuMing opened a new pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li) URL: https://github.com/apache/calcite/pull/1401 Add `regexp_replace` function in Calcite as discussed at [CALCITE-3280](https://issues.apache.org/jira/browse/CALCITE-3280). Add

[GitHub] [calcite] jinxing64 edited a comment on issue #1324: [CALCITE-3203] When matching materializations, match Project with child of Aggregate

jinxing64 edited a comment on issue #1324: [CALCITE-3203] When matching materializations, match Project with child of Aggregate URL: https://github.com/apache/calcite/pull/1324#issuecomment-523786270 @hsyuan Thanks for your kind reminder. Actually I think this case can be

[GitHub] [calcite] jinxing64 edited a comment on issue #1324: [CALCITE-3203] When matching materializations, match Project with child of Aggregate

jinxing64 edited a comment on issue #1324: [CALCITE-3203] When matching materializations, match Project with child of Aggregate URL: https://github.com/apache/calcite/pull/1324#issuecomment-523786270 @hsyuan Thanks for your kind reminder. Actually I think this case can be

[GitHub] [calcite] danny0405 commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li)

danny0405 commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li) URL: https://github.com/apache/calcite/pull/1401#discussion_r316541081 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java ##

[GitHub] [calcite] ffmax opened a new pull request #1400: make every SqlDialect parse their own data type

ffmax opened a new pull request #1400: make every SqlDialect parse their own data type URL: https://github.com/apache/calcite/pull/1400 Every database might have different type or same type but different type name, therefore making every SqlDialect parse their own data type is suitable

[GitHub] [calcite-avatica-go] F21 merged pull request #47: Add more nil checks in error handling.

F21 merged pull request #47: Add more nil checks in error handling. URL: https://github.com/apache/calcite-avatica-go/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on

[calcite-avatica-go] branch master updated: [CALCITE-3275] add nil checks to error parsing (Tino Rusch).

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git The following commit(s) were added to refs/heads/master by this push: new 7a35be7 [CALCITE-3275] add

[GitHub] [calcite-avatica-go] F21 commented on issue #47: Add more nil checks in error handling.

F21 commented on issue #47: Add more nil checks in error handling. URL: https://github.com/apache/calcite-avatica-go/pull/47#issuecomment-523771232 thanks @trusch ! This is an automated message from the Apache Git Service. To

[GitHub] [calcite] jinxing64 commented on issue #1324: [CALCITE-3203] When matching materializations, match Project with child of Aggregate

jinxing64 commented on issue #1324: [CALCITE-3203] When matching materializations, match Project with child of Aggregate URL: https://github.com/apache/calcite/pull/1324#issuecomment-523786270 @hsyuan Thanks for your kind reminder. Actually I think this case can be replaced by

[GitHub] [calcite] LiShuMing commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li)

LiShuMing commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li) URL: https://github.com/apache/calcite/pull/1401#discussion_r316542621 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java ##

[GitHub] [calcite] LiShuMing commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li)

LiShuMing commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li) URL: https://github.com/apache/calcite/pull/1401#discussion_r316542621 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java ##

[GitHub] [calcite-avatica-go] trusch commented on issue #47: Add more nil checks in error handling.

trusch commented on issue #47: Add more nil checks in error handling. URL: https://github.com/apache/calcite-avatica-go/pull/47#issuecomment-523770284 @F21 This is ready to merge now! This is an automated message from the

[GitHub] [calcite] danny0405 commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li)

danny0405 commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li) URL: https://github.com/apache/calcite/pull/1401#discussion_r316544139 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java ##

[GitHub] [calcite] ffmax opened a new pull request #1402: make every SqlDialect parse their own data type

ffmax opened a new pull request #1402: make every SqlDialect parse their own data type URL: https://github.com/apache/calcite/pull/1402 Every database might have different type or same type but different type name, therefore making every SqlDialect parse their own data type is a suitable

[GitHub] [calcite] danny0405 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

danny0405 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r316606865 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -1579,15 +1579,38 @@ List SelectList() : SqlNode

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r316597742 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -1579,15 +1579,38 @@ List SelectList() :

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316608509 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java

[GitHub] [calcite] Fokko commented on a change in pull request #1393: [CALCITE-3265] Remove the unused variables

Fokko commented on a change in pull request #1393: [CALCITE-3265] Remove the unused variables URL: https://github.com/apache/calcite/pull/1393#discussion_r316624501 ## File path: core/src/main/java/org/apache/calcite/runtime/Matcher.java ## @@ -63,7 +58,6 @@ private

[GitHub] [calcite] danny0405 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

danny0405 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r316586419 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -1579,15 +1579,38 @@ List SelectList() : SqlNode

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r316592589 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -1579,15 +1579,38 @@ List SelectList() :

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316607816 ## File path:

[GitHub] [calcite] rubenada edited a comment on issue #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada edited a comment on issue #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#issuecomment-523844012 > > > You can remove this change in this PR: >

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316642445 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316606659 ## File path:

[GitHub] [calcite] rubenada commented on issue #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on issue #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#issuecomment-523844012 > > > You can remove this change in this PR: >

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316606659 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316606659 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316719387 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java

[GitHub] [calcite] ihuzenko commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

ihuzenko commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#discussion_r316735641 ## File path:

[GitHub] [calcite] LaiZhou commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

LaiZhou commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316661758 ## File path:

[GitHub] [calcite] LaiZhou commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

LaiZhou commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316662337 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316699416 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316672026 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java

[GitHub] [calcite] rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#discussion_r316670865 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java

[GitHub] [calcite] hsyuan commented on issue #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec…

hsyuan commented on issue #1156: [CALCITE-2973] Allow theta joins that have equi conditions to be exec… URL: https://github.com/apache/calcite/pull/1156#issuecomment-524000289 > @hsyuan , I'm not sure we can do that, since this change affects just EnumerableHashJoin (which will support

[GitHub] [calcite] julianhyde commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

julianhyde commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#discussion_r316816217 ## File path:

[GitHub] [calcite] xndai commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

xndai commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#discussion_r316952608 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

danny0405 commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#discussion_r316954972 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

danny0405 commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#discussion_r316956324 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java ##

[GitHub] [calcite] julianhyde commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

julianhyde commented on a change in pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#discussion_r316976211 ## File path:

[GitHub] [calcite] julianhyde commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

julianhyde commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#discussion_r316977414 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java

[GitHub] [calcite] xndai commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

xndai commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#discussion_r316979608 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@

[GitHub] [calcite] julianhyde commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

julianhyde commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#discussion_r316979955 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java

[calcite] 02/02: [CALCITE-3220] JDBC adapter now transforms TRIM to TRIM, LTRIM or RTRIM when target is Hive (Jacky Woo)

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 48c0db1206b17c571d477d912d193d32b5be1eff Author: jackyWoo AuthorDate: Tue Jul 30 20:15:26 2019 +0800

[calcite] branch master updated (22577e4 -> 48c0db1)

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 22577e4 [CALCITE-3228] Error while applying rule ProjectScanRule: interpreter new 00ad79b [CALCITE-3263] Add

[GitHub] [calcite] asfgit closed pull request #1342: [CALCITE-3220] HiveSqlDialect transforms function Trim to correct Hive format

asfgit closed pull request #1342: [CALCITE-3220] HiveSqlDialect transforms function Trim to correct Hive format URL: https://github.com/apache/calcite/pull/1342 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] LiShuMing commented on issue #1390: [CALCITE-3263] Add MD5/SHA1 SQL functions (ShuMing Li)

LiShuMing commented on issue #1390: [CALCITE-3263] Add MD5/SHA1 SQL functions (ShuMing Li) URL: https://github.com/apache/calcite/pull/1390#issuecomment-524180544 I'm sorry. Why close it? This is an automated message from

[GitHub] [calcite] julianhyde commented on a change in pull request #1393: [CALCITE-3265] Remove the unused variables

julianhyde commented on a change in pull request #1393: [CALCITE-3265] Remove the unused variables URL: https://github.com/apache/calcite/pull/1393#discussion_r316824569 ## File path: core/src/main/java/org/apache/calcite/runtime/Matcher.java ## @@ -63,7 +58,6 @@ private

[GitHub] [calcite] xndai opened a new pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

xndai opened a new pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403 In VolcanoPlanner.rename(), the given relnode will be removed when we find there's an equivalent rel after rename. But if the node to be

[GitHub] [calcite] LiShuMing commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li)

LiShuMing commented on a change in pull request #1401: [CALCITE-3280] Add regexp_replace function (Shuming Li) URL: https://github.com/apache/calcite/pull/1401#discussion_r316952202 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

hsyuan commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#discussion_r316905704 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ##

[calcite] branch master updated (7294460 -> 22577e4)

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 7294460 [CALCITE-3223] MV fails to match when there is Non-RexInputRef in the projects (Jin Xing) add

[GitHub] [calcite] chunweilei merged pull request #1355: [CALCITE-3228] Error while applying rule ProjectScanRule: interpreter

chunweilei merged pull request #1355: [CALCITE-3228] Error while applying rule ProjectScanRule: interpreter URL: https://github.com/apache/calcite/pull/1355 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] hbtoo commented on issue #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

hbtoo commented on issue #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#issuecomment-524101474 +1 lgtm This is an automated message from the Apache Git

[GitHub] [calcite] julianhyde commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

julianhyde commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#discussion_r316913355 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java