suneet-s commented on pull request #10689:
URL: https://github.com/apache/druid/pull/10689#issuecomment-761212906
@jihoonson Do you think this Improvement should be called out in the release
notes
This is an automated
This is an automated email from the ASF dual-hosted git repository.
jihoonson pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 95065bd Bump dev version to 0.22.0-SNAPSHOT
This is an automated email from the ASF dual-hosted git repository.
vogievetsky pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/druid-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 7a51fa3 Autobuild (#113)
vogievetsky opened a new pull request #113:
URL: https://github.com/apache/druid-website/pull/113
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vogievetsky merged pull request #113:
URL: https://github.com/apache/druid-website/pull/113
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jihoonson merged pull request #10759:
URL: https://github.com/apache/druid/pull/10759
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jihoonson commented on pull request #10689:
URL: https://github.com/apache/druid/pull/10689#issuecomment-761214333
@suneet-s yes, I think it's worth mentioning. Thanks for catching it.
This is an automated message from the
This is an automated email from the ASF dual-hosted git repository.
vogievetsky pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid-website-src.git
The following commit(s) were added to refs/heads/master by this push:
new 318b53f remove 1 meetup, add 2
vogievetsky merged pull request #200:
URL: https://github.com/apache/druid-website-src/pull/200
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Karthikeyantkr commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-761223669
@FrankChen021
```
2021-01-15T22:06:13,611 WARN [DruidSchema-Cache-0]
org.apache.druid.client.cache.AbstractRedisCache - Exception pulling items from
cache
Karthikeyantkr commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-761224017
I tried a large timeout and also bind IP. still the same exception.
This is an automated message from the
jihoonson opened a new pull request #10769:
URL: https://github.com/apache/druid/pull/10769
This PR has 2 changes:
- Promoting [the contributing
doc](https://github.com/apache/druid/blob/master/CONTRIBUTING.md). This change
also includes a suggestion for not using force pushes and
michaelschiff edited a comment on pull request #10412:
URL: https://github.com/apache/druid/pull/10412#issuecomment-760648631
@Tiaaa awesome! I see peon metrics in pushgateway as well.
https://user-images.githubusercontent.com/1669670/104682480-a0131900-56a9-11eb-8817-3dea4d0b3b0d.png;>
suneet-s commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558805012
##
File path: processing/src/main/java/org/apache/druid/segment/filter/Filters.java
##
@@ -552,4 +594,96 @@ public static boolean
jihoonson commented on a change in pull request #10769:
URL: https://github.com/apache/druid/pull/10769#discussion_r558736917
##
File path: .github/pull_request_template.md
##
@@ -48,11 +57,4 @@ This PR has:
- [ ] added integration tests.
- [ ] been tested in a test Druid
suneet-s commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558804246
##
File path: processing/src/main/java/org/apache/druid/segment/filter/Filters.java
##
@@ -480,68 +485,105 @@ public static boolean
suneet-s commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558804322
##
File path: processing/src/main/java/org/apache/druid/segment/filter/Filters.java
##
@@ -480,68 +485,105 @@ public static boolean
Tiaaa commented on a change in pull request #10412:
URL: https://github.com/apache/druid/pull/10412#discussion_r558784419
##
File path:
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java
##
@@ -0,0 +1,153 @@
+/*
+ *
abhishekagarwal87 commented on a change in pull request #10761:
URL: https://github.com/apache/druid/pull/10761#discussion_r558817270
##
File path: services/src/main/java/org/apache/druid/cli/PullDependencies.java
##
@@ -83,6 +83,9 @@
capistrant commented on a change in pull request #10769:
URL: https://github.com/apache/druid/pull/10769#discussion_r558674556
##
File path: .github/pull_request_template.md
##
@@ -48,11 +57,4 @@ This PR has:
- [ ] added integration tests.
- [ ] been tested in a test Druid
Aaronong opened a new pull request #10771:
URL: https://github.com/apache/druid/pull/10771
### Description
Currently, Protobuf Descriptors can only be retrieved from the local
filesystem, or unauthorized URLs.
This commit introduces the ability to retrieve descriptors via
HashSalmon opened a new issue #10770:
URL: https://github.com/apache/druid/issues/10770
Hey All,
I am trying to connect to redis cluster with druid 0.19. The broker log
shows host cannot be null. It looks like druid cannot parse config name
"druid.cache.cluster.nodes".
suneet-s commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558805842
##
File path:
processing/src/main/java/org/apache/druid/query/filter/BooleanFilter.java
##
@@ -23,13 +23,14 @@
import
clintropolis commented on pull request #10688:
URL: https://github.com/apache/druid/pull/10688#issuecomment-760749616
Hi @zhangyue19921010
I know some of our travis integration tests have been a bit flakey lately,
but could you avoid doing this to trigger CI:
zhangyue19921010 commented on pull request #10688:
URL: https://github.com/apache/druid/pull/10688#issuecomment-760752356
> Hi @zhangyue19921010
>
> I know some of our travis integration tests have been a bit flakey lately,
but could you avoid doing this to trigger CI:
>
gianm commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558087010
##
File path:
processing/src/test/java/org/apache/druid/segment/filter/FilterCnfConversionTest.java
##
@@ -253,54 +253,54 @@ public void
gianm commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558087569
##
File path:
processing/src/test/java/org/apache/druid/segment/filter/FilterCnfConversionTest.java
##
@@ -356,65 +356,65 @@ public void
gianm commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558087569
##
File path:
processing/src/test/java/org/apache/druid/segment/filter/FilterCnfConversionTest.java
##
@@ -356,65 +356,65 @@ public void
gianm commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558088939
##
File path:
processing/src/test/java/org/apache/druid/segment/join/JoinFilterAnalyzerTest.java
##
@@ -2545,18 +2545,10 @@ public void
gianm commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-760769950
> By the way, I did a similar thing in #10304 to reduce some boilerplate
code but used composition instead of inheritance. Added
package-private`*BufferAggregatorHelper` classes
gianm commented on a change in pull request #10605:
URL: https://github.com/apache/druid/pull/10605#discussion_r558098809
##
File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4
##
@@ -51,9 +51,12 @@ numericElement : (LONG | DOUBLE | NULL);
literalElement
abhishekagarwal87 commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-760774449
Right. I was being subtle about it :) It would be nice to use the same style
everywhere. If that pattern needs some modification, I can do that as well.
gianm commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-760776516
Which pattern do you think is better? I haven't had a chance to take a look
at yours yet, so I'm wondering if I should make yours match mine, or mine match
yours.
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558115336
##
File path:
core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java
##
@@ -74,7 +74,7 @@ public ExprType
clintropolis commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558121651
##
File path:
core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java
##
@@ -74,7 +74,7 @@ public ExprType
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558124796
##
File path:
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java
##
@@ -305,17 +305,29 @@ private static ColumnCapabilities
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558127972
##
File path:
processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java
##
@@ -27,6 +27,13 @@
{
Predicate
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558131456
##
File path:
processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java
##
@@ -70,6 +71,11 @@ default MultiValueDimensionVectorSelector
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558132323
##
File path:
processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java
##
@@ -27,6 +27,13 @@
{
Predicate
zhangyue19921010 commented on pull request #10524:
URL: https://github.com/apache/druid/pull/10524#issuecomment-760783961
Hi @himanshug Thanks for your review. I am trying to understand what you
suggested:
1. Extract the autoScale logic out of `SeekableStreamSupervisor` to minimize
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558133615
##
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/vector/GroupByVectorColumnProcessorFactory.java
##
@@ -64,7 +65,16 @@
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558133615
##
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/vector/GroupByVectorColumnProcessorFactory.java
##
@@ -64,7 +65,16 @@
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558136293
##
File path:
processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java
##
@@ -55,6 +69,105 @@ public ExpressionFilter(final Supplier
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558138626
##
File path:
processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java
##
@@ -55,6 +69,105 @@ public ExpressionFilter(final Supplier
zhangyue19921010 edited a comment on pull request #10524:
URL: https://github.com/apache/druid/pull/10524#issuecomment-760783961
Hi @himanshug Thanks for your review. I am trying to understand what you
suggested:
1. Extract the autoScale logic out of `SeekableStreamSupervisor` to
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558143595
##
File path:
processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java
##
@@ -57,6 +57,15 @@ default int
gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558162034
##
File path:
core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java
##
@@ -74,7 +74,7 @@ public ExprType
alphaxo commented on issue #8663:
URL: https://github.com/apache/druid/issues/8663#issuecomment-760801874
Facing the same issue also with version 0.16.0-incubating.
This is an automated message from the Apache Git Service.
alphaxo edited a comment on issue #8663:
URL: https://github.com/apache/druid/issues/8663#issuecomment-760801874
Facing the same issue also with version 0.16.0-incubating.
I have encountered this problem several times. The scenario at that time was
that I needed to delete the data
abhishekagarwal87 commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-76089
I usually avoid abstract classes so there is no tight coupling. It can make
unit testing easier as well. I can pass a mock helper into a vector aggregator
and unit
FrankChen021 commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760939773
> I am seeing this message now when I restart the broker. Broker log:
>
> ```
> 2021-01-14T20:56:13,304 WARN [DruidSchema-Cache-0]
FrankChen021 commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760941017
> This error in historical node :
>
> ```
> 2021-01-14T20:56:13,647 WARN
[segmentMetadata_dsp_media_and_bids_[2020-08-09T09:00:00.000Z/2020-08-09T10:00:00.000Z]]
vogievetsky merged pull request #199:
URL: https://github.com/apache/druid-website-src/pull/199
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
vogievetsky pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid-website-src.git
The following commit(s) were added to refs/heads/master by this push:
new 357b8dc add Blueshift, update
vogievetsky merged pull request #112:
URL: https://github.com/apache/druid-website/pull/112
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vogievetsky opened a new pull request #112:
URL: https://github.com/apache/druid-website/pull/112
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
vogievetsky pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/druid-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new d92675b Autobuild (#112)
suneet-s commented on a change in pull request #10761:
URL: https://github.com/apache/druid/pull/10761#discussion_r558538468
##
File path: services/src/main/java/org/apache/druid/cli/PullDependencies.java
##
@@ -83,6 +83,9 @@
.put("commons-beanutils",
gianm commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-761138114
I've pushed up a new patch that undoes the refactoring and instead
implements things using the same technique as #10304.
jihoonson opened a new pull request #10768:
URL: https://github.com/apache/druid/pull/10768
Backport of #10751 to 0.21.0.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
suneet-s commented on a change in pull request #10761:
URL: https://github.com/apache/druid/pull/10761#discussion_r558549231
##
File path:
extensions-core/kinesis-indexing-service/src/test/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplierTest.java
##
@@ -410,6
suneet-s commented on a change in pull request #10761:
URL: https://github.com/apache/druid/pull/10761#discussion_r558549684
##
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java
##
@@ -366,8 +390,8
xvrl commented on pull request #10764:
URL: https://github.com/apache/druid/pull/10764#issuecomment-761156934
test failures are unrelated
```
[ERROR] Run 1: KafkaIndexTaskTest.testRunTransactionModeRollback:2434
expected:<2> but was:<3>
```
This is an automated email from the ASF dual-hosted git repository.
xvrl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new c5ecbf6 fix task metric types in statsd emitter
xvrl merged pull request #10764:
URL: https://github.com/apache/druid/pull/10764
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
65 matches
Mail list logo
