On Mon, 13 Jun 2022 07:26:32 GMT, Matthias Baesken wrote:
> Hi Daniel, should we maybe better print something like "check for not allowed
> characters" in the exception ? Do you have an easy and cheap way in mind to
> the get the unsupported character (in this case "_") to add it to the output
On Fri, 10 Jun 2022 08:26:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8285405?
>>
>> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the
>> existing `te
> various APIs of this class.
>
> For `WeakHashMap.newWeakHashMap` and `HashMap.newHashMap`, I have created new
> test classes under relevant locations, since these classes already have test
> classes (almost) per API/feature in those locations.
Jaikiran Pai has updated the pull
> various APIs of this class.
>
> For `WeakHashMap.newWeakHashMap` and `HashMap.newHashMap`, I have created new
> test classes under relevant locations, since these classes already have test
> classes (almost) per API/feature in those locations.
Jaikiran Pai has updated the pull requ
On Thu, 9 Jun 2022 21:11:55 GMT, David M. Lloyd wrote:
>> https://github.com/openjdk/jdk/blob/bc28baeba9360991e9b7575e1fbe178d873ccfc1/src/java.base/share/classes/jdk/internal/misc/Signal.java#L177-L178
>>
>> Instead of separate Hashtable.get/remove calls we can just use value
>> returned by
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
> `test/jdk/java/util/LinkedHas
On Tue, 7 Jun 2022 12:19:29 GMT, Magnus Ihse Bursie wrote:
> I have failed to reproduce the working conditions that makes a file actually
> unreadable for the owner on Windows, neither on my GHA test repo, nor
> locally.
I had quick look at the CI setup we have access to. It appears that
On 07/06/22 9:39 am, Stuart Marks wrote:
Hi Jai,
The error
java.lang.OutOfMemoryError: Java heap space
indicates that the VM really has run out of memory. Presumably if you
increased the heap size, it would actually be able to allocate that
memory. You might have to add the /othervm
Can I please get a review of this change which addresses
https://bugs.openjdk.java.net/browse/JDK-8285405?
I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
`test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for
various APIs of this class.
For
On Mon, 6 Jun 2022 14:58:25 GMT, Thiago Henrique Hüpner
wrote:
>> 8287353: Use snippet tag instead of pre tag in Javadoc of
>> InterruptedException
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update
On Wed, 27 Apr 2022 13:33:29 GMT, Thiago Henrique Hüpner
wrote:
>> 8287353: Use snippet tag instead of pre tag in Javadoc of
>> InterruptedException
>
> If this is a valid change, could someone please create a Jira issue to link
> to it?
Hello @Thihup, overall this change looks fine to me.
On Sat, 28 May 2022 12:00:00 GMT, Andrey Turbanov wrote:
> Hashtable doesn't allow `null` values. So, instead of pair
> `containsKey`/`remove` calls, we can directly call `remove` and then compare
> result with `null`.
>
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote:
> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
> Changed only to do so if `doReplace` is `true` in
> `String.encodeWithEncoder()`.
In a recent enhancement we added new APIs to construct LinkedHashMap,
HashMap and WeakHashMap instances as part of
https://bugs.openjdk.java.net/browse/JDK-8186958.
Since we missed adding tests for that change, I have been working on
adding some basic tests for this change as part of
On Sun, 29 May 2022 14:00:20 GMT, Andrey Turbanov wrote:
> `String.contains` was introduced in Java 5.
> Some code in java.naming still uses old approach with `String.indexOf` to
> check if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to
On Sat, 28 May 2022 12:05:31 GMT, Anthony Vanelverdinghe
wrote:
>> The change is trivial, but I'll need help from someone to create a JBS issue
>> & sponsor this PR.
>
> Anthony Vanelverdinghe has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe
wrote:
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
@anthonyvdotbe, can you also please change the copyright year on that file from
`Copyright (c) 2021,` to `Copyright (c) 2021,
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe
wrote:
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
Hello @anthonyvdotbe, I've created
https://bugs.openjdk.java.net/browse/JDK-8287440 for this change. Please edit
the title of
On Wed, 25 May 2022 23:08:38 GMT, Brian Burkhalter wrote:
> If only a leftover `char` remains in the stream, do not add `-1` to the
> return value in `lockedRead()`.
Looks fine to me.
-
Marked as reviewed by jpai (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8895
On Sat, 30 Apr 2022 08:56:23 GMT, Andrey Turbanov wrote:
> The method `java.util.zip.ZipFile.Source#get` could be improved by usage of
> `Map.putIfAbsent` instead of separate `containsKey`/`get`/`put` calls. We
> known that HashMap `java.util.zip.ZipFile.Source#files` can contain only
>
On Tue, 24 May 2022 13:08:53 GMT, liach wrote:
> so on a mismatch, it would print parameter type initialized after
> instantiation expected: true actual: false
That looks fine then. I hadn't looked closely at what testng prints and I had
thought that on an assertion failure it would print
On Tue, 24 May 2022 13:07:08 GMT, liach wrote:
>> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 605:
>>
>>> 603: mv.visitLdcInsn(Type.getObjectType(dotToSlash(className)));
>>> 604: mv.visitMethodInsn(INVOKEVIRTUAL, JL_CLASS,
>>> 605:
On Fri, 20 May 2022 18:22:47 GMT, liach wrote:
>> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of
>> `Class.forName(String)`. `make test
>> TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new
>> `LazyInitializationTest` failing the eager initialization
On Sun, 22 May 2022 05:58:25 GMT, Christian Stein wrote:
> Commit
> https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640
> for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654)
> added an optional description accessor on the `ToolProvider`
On Mon, 23 May 2022 10:38:43 GMT, Christian Stein wrote:
>> This commit adds an API note to ToolProvider about being reusable/reentrant.
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update
On Mon, 23 May 2022 19:47:33 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR addresses the performance issue that is described in JDK-8287162.
>
> With this fix, the ZipFileSystem methods: initOwner, initGroup, and
> initPermissions will not be invoked unless
On Wed, 18 May 2022 06:30:34 GMT, Adam Sotona wrote:
>> ### Problem description
>> Minimal jdk image created by jlink with the only jdk.compiler module and its
>> dependencies
>> fails to run java source launcher correctly (for example when --source N is
>> specified).
>> Failing source
On Tue, 17 May 2022 13:08:32 GMT, Adam Sotona wrote:
>> ### Problem description
>> Minimal jdk image created by jlink with the only jdk.compiler module and its
>> dependencies
>> fails to run java source launcher correctly (for example when --source N is
>> specified).
>> Failing source
On Tue, 17 May 2022 11:15:19 GMT, Alan Bateman wrote:
> This is a test fix. ThreadAPI.testGetStackTrace3 tests Thread::getStackTrace
> on a thread doing a selection operation. The test is not reliable as it
> expects to see the "select" method in the stack trace after waiting 200ms.
> The
On Fri, 13 May 2022 14:17:44 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the failure
> handler command `dmesg` on macOS?
>
> As noted in the JBS issue, the command currently fails with permission error.
> The commit in thi
On Mon, 16 May 2022 22:06:25 GMT, Leonid Mesnik wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright year
>
> Looks reasonable.
Thank you @lmesnik for the rev
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. Th
On Fri, 13 May 2022 07:14:30 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change that addresses
>> https://bugs.openjdk.java.net/browse/JDK-8286559?
>>
>> The commit here removes the `synchronized` on `mark` and `reset` methods of
>> `InflaterI
On Wed, 11 May 2022 09:00:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change that addresses
> https://bugs.openjdk.java.net/browse/JDK-8286559?
>
> The commit here removes the `synchronized` on `mark` and `reset` methods of
> `InflaterInputStream`. Th
mmand.
>
> Tested locally on macOS by running:
>
>
> cd test/failure_handler
> make clean
> make test
>
> Then checked the generated environment.html files for the dmesg command
> output. Looks fine after this change.
Jaikiran Pai has updated the pull request
Can I please get a review of this change which proposes to fix the failure
handler command `dmesg` on macOS?
As noted in the JBS issue, the command currently fails with permission error.
The commit in this PR uses `sudo` as suggested in the man pages of that command.
Tested locally on macOS by
ssary, in which case, I'll revert that part.
>
> This change is similar to what was recently done for `FilterInputStream`
> https://github.com/openjdk/jdk/pull/8309 and `PushbackInputStream`
> https://github.com/openjdk/jdk/pull/8433
>
> tier1, tier2 and tier3 tests were run
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> syst
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> syst
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> syst
On Wed, 11 May 2022 11:38:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes build failures on macos
> when using `--with-zlib=bundled`?
>
> With this change the build now passes (tested both with bundled and system
> zlib variants).
>
> t
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib
On Wed, 11 May 2022 11:52:55 GMT, Magnus Ihse Bursie wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - copyright years
>> - disable format-nonliteral warning when building LIBSPLA
On Wed, 11 May 2022 12:50:39 GMT, Alan Bateman wrote:
>> Thank you for these useful inputs Magnus. I did these changes locally but
>> for some reason this format-nonliteral is not getting picked up while
>> building that library. I will investigate and see what's going on. Will
>> update the
related failures have
> been noticed.
Jaikiran Pai has updated the pull request incrementally with four additional
commits since the last revision:
- copyright years
- disable format-nonliteral warning when building LIBSPLASHSCREEN with bundled
zlib
- Magnus' suggestion - make the L
On Wed, 11 May 2022 11:56:30 GMT, Magnus Ihse Bursie wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1,
Can I please get a review of this change which fixes build failures on macos
when using `--with-zlib=bundled`?
With this change the build now passes (tested both with bundled and system zlib
variants).
tier1, tier2 and tier3 testing has been done and no related failures have been
noticed.
On Tue, 10 May 2022 20:22:39 GMT, Naoto Sato wrote:
> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter
> replaces on malformed/unmappable characters with replacements. However, there
> was a code path that lacked to set the `CodingErrorAction.REPLACE` on the
>
On Wed, 11 May 2022 09:00:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change that addresses
> https://bugs.openjdk.java.net/browse/JDK-8286559?
>
> The commit here removes the `synchronized` on `mark` and `reset` methods of
> `InflaterInputStream`. Th
Can I please get a review of this change that addresses
https://bugs.openjdk.java.net/browse/JDK-8286559?
The commit here removes the `synchronized` on `mark` and `reset` methods of
`InflaterInputStream`. The `mark` method is a no-op method and the `reset`
method only always throws a
On Tue, 10 May 2022 14:58:15 GMT, Aleksey Shipilev wrote:
>> There are plenty of tests failing on many architectures due to
>> `--enable-preview` VM code introduced by Loom. This improvement eliminates
>> some of the redundant `--enable-preview` clauses from the Sealed Classes
>> tests, since
On Tue, 10 May 2022 14:54:39 GMT, Aleksey Shipilev wrote:
>> There are plenty of tests failing on many architectures due to
>> `--enable-preview` VM code introduced by Loom. This improvements eliminates
>> some of the redundant `--enable-preview` clauses from the Record tests,
>> since
On Wed, 20 Apr 2022 19:16:00 GMT, Andrey Turbanov wrote:
> 1. No need to call `String.substring` if you need need to compare start of
> string with some constant. `String.startWith` suites better.
> 2. Unused String array is allocated in `childrenNamesSpi` method
Marked as reviewed by jpai
On Mon, 9 May 2022 18:59:43 GMT, Naoto Sato wrote:
> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support
> second-level resolution, enabling round trips with `java.time.ZoneOffset`s.
> Corresponding CSR is also being drafted.
On Mon, 9 May 2022 18:59:43 GMT, Naoto Sato wrote:
> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support
> second-level resolution, enabling round trips with `java.time.ZoneOffset`s.
> Corresponding CSR is also being drafted.
On Tue, 10 May 2022 12:07:31 GMT, Aleksey Shipilev wrote:
> There are plenty of tests failing on many architectures due to
> `--enable-preview` VM code introduced by Loom. This improvement eliminates
> some of the redundant `--enable-preview` clauses from the Sealed Classes
> tests, since
On Tue, 10 May 2022 12:03:09 GMT, Aleksey Shipilev wrote:
> There are plenty of tests failing on many architectures due to
> `--enable-preview` VM code introduced by Loom. This improvements eliminates
> some of the redundant `--enable-preview` clauses from the Record tests, since
> Records
On Wed, 4 May 2022 15:02:43 GMT, liach wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 500:
>>
>>> 498: Box newKey = new Box(k1a);
>>> 499: Box newVal = new Box(v1a);
>>> 500: Box r = map.computeIfAbsent(newKey, k -> { called[0] = true;
>>> return newVal;
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>>
On Fri, 29 Apr 2022 03:00:40 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>>
On Mon, 2 May 2022 13:13:02 GMT, Weijun Wang wrote:
>> `lines.remove()` and `lines.subList()` will throw the correct exception.
>> Since you asked, we can add it.
>
> Now that we call `subList` at the beginning, I think there's no need to
> explicitly perform a check.
Hello Weijun, the change
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the conten
On Mon, 2 May 2022 06:25:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8285915?
>>
>> With this change, the environment details collected by the failure handler
>> will now inc
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the conten
certain cases when debugging network tests that fail.
>
> Testing done (on macOS):
>
>
> cd test/failure_handler
> make test
>
> Then verified that the generated environment.html had the `/etc/hosts` file
> content
Jaikiran Pai has updated the pull request incremental
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the conten
On Fri, 29 Apr 2022 10:46:31 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated to add space character in begining
Can I please get a review of this change which addresses
https://bugs.openjdk.java.net/browse/JDK-8285915?
With this change, the environment details collected by the failure handler will
now include the contents of the `/etc/hosts/` file, which can be useful in
certain cases when debugging
On Fri, 29 Apr 2022 00:06:32 GMT, Stuart Marks wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 257:
>>
>>> 255: checkEntries(map.entrySet(), entry(k1b, v1b),
>>> 256: entry(k2, v2));
>>> 257: }
>>
>> Would an additional check
On Fri, 29 Apr 2022 01:20:17 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>>
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
>
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
>
On Wed, 27 Apr 2022 22:27:34 GMT, Joe Darcy wrote:
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties,
On Wed, 27 Apr 2022 20:10:03 GMT, Brian Burkhalter wrote:
> Please review this request to remove the `synchronized` keyword from the
> `mark(int)` and `reset()` methods of `java.io.PushbackInputStream`.
Looks fine to me.
Given that `mark()` currently is a no-op and `reset()` throws an
On Fri, 22 Apr 2022 08:04:09 GMT, Johnny Lim wrote:
>> Hello @izeye, I've created a JBS issue for this change
>> https://bugs.openjdk.java.net/browse/JDK-8285440. Please edit the title of
>> this PR to "8285440: Typo in Collections.addAll method javadoc" so that it
>> triggers the workflow of
On Fri, 22 Apr 2022 15:08:51 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by core-libs, and accepted those changes
> where it indeed discovered real typos.
>
> I will update copyright years using a script before pushing (otherwise like
> every second change would be a
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote:
> This PR fixes a typo.
Thank you for contributing. The change looks fine to me. After someone with a
Reviewer role approves this change, I can sponsor this for you.
-
Marked as reviewed by jpai (Committer).
PR:
On Fri, 25 Mar 2022 00:55:00 GMT, Johnny Lim wrote:
>> Hi,
>>
>> please (re)submit a completed OCA at OCA.opensource.oracle.com.
>
> @robilad Hi. Thanks for the feedback!
>
> I submitted it again. I tried to fill it as possible as I can this time.
> Please let me know if there's anything
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Wed, 20 Apr 2022 07:33:14 GMT, Alan Bateman wrote:
> I wonder if it should be removed from InputStream at the same time.
Interesting. I hadn't noticed `InputStream` had those two methods synchronized.
I suspect removing synchronization from those two methods on `InputStream` is
probably a
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Sat, 16 Apr 2022 14:34:01 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/misc/Blocker.java line 76:
>>
>>> 74: && currentCarrierThread() instanceof CarrierThread ct
>>> && !ct.inBlocking()) {
>>> 75: ct.beginBlocking();
>>> 76:
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 13 Apr 2022 17:42:57 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Wed, 13 Apr 2022 08:30:33 GMT, Aleksey Shipilev wrote:
>>> Hello @shipilev, do you think this stackless nature of this specific
>>> `DatatypeException` type should be noted in its javadoc, just to avoid any
>>> surprises when someone in future ends up using this exception type as the
>>>
On Thu, 31 Mar 2022 17:54:28 GMT, Aleksey Shipilev wrote:
>> See bug report for more details. This change improves
>> SPECjvm2008:xml.validation for about +3%:
>>
>>
>> baseline: 298.353 ± 1.008 ops/min
>> patched: 309.912 ± 1.347 ops/min
>>
>> Of course, the real improvements might be
On Mon, 11 Apr 2022 16:03:08 GMT, Alan Bateman wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adapted wording and copyrights based on @jaikiran review
>
> src/java.base/share/classes/java/util/zip/ZipFile.java
On Mon, 4 Apr 2022 06:55:10 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which now marks `CollectionView` as
> a `sealed` class with only `EntrySetView`, `KeySetView` and `ValuesView` as
> the sub-classes? This change corresponds to
> https://bugs.open
On Mon, 4 Apr 2022 06:55:10 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which now marks `CollectionView` as
> a `sealed` class with only `EntrySetView`, `KeySetView` and `ValuesView` as
> the sub-classes? This change corresponds to
> https://bugs.open
On Wed, 6 Apr 2022 16:28:21 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Wed, 6 Apr 2022 16:28:21 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Wed, 6 Apr 2022 16:28:21 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Tue, 29 Mar 2022 20:05:50 GMT, Mandy Chung wrote:
> A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load`
> returns the same `NativeLibrary` instance of a given path if it's called
> multiple times. This means that multiple clients have to coordinate that the
> last one
On Wed, 30 Mar 2022 06:17:54 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Marked as reviewed by jpai (Committer).
-
PR:
1 - 100 of 584 matches
Mail list logo
