[GitHub] [activemq-artemis] michaelandrepearce commented on a diff in pull request #4001: Improve ActiveMQBasicSecurityManager documentation

michaelandrepearce commented on code in PR #4001: URL: https://github.com/apache/activemq-artemis/pull/4001#discussion_r841280545 ## docs/user-manual/en/security.md: ## @@ -1221,6 +1221,11 @@ management performed on the live broker will be reflected on the backup upon

[GitHub] [activemq-artemis] michaelandrepearce commented on a diff in pull request #4001: Improve ActiveMQBasicSecurityManager documentation

michaelandrepearce commented on code in PR #4001: URL: https://github.com/apache/activemq-artemis/pull/4001#discussion_r841279602 ## docs/user-manual/en/security.md: ## @@ -1221,6 +1221,11 @@ management performed on the live broker will be reflected on the backup upon

[GitHub] [activemq-artemis] ViliusS commented on a diff in pull request #4001: Improve ActiveMQBasicSecurityManager documentation

ViliusS commented on code in PR #4001: URL: https://github.com/apache/activemq-artemis/pull/4001#discussion_r841274500 ## docs/user-manual/en/security.md: ## @@ -1221,6 +1221,11 @@ management performed on the live broker will be reflected on the backup upon failover.

[GitHub] michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-468884555 @clebertsuconic as mentioned, here is the federation stuff, sorry wasnt sooner, just a manic week. And

[GitHub] michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

michaelandrepearce edited a comment on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-468884555 @clebertsuconic as mentioned, here is the federation stuff, sorry wasnt sooner, just a manic week. And

[GitHub] michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses

michaelandrepearce commented on issue #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573#issuecomment-468884555 @clebertsuconic as mentioned, here is the federation stuff, sorry wasnt sooner, just a manic week.

[GitHub] michaelandrepearce opened a new pull request #2573: ARTEMIS-2265 Support Federated Queues and Addresses

michaelandrepearce opened a new pull request #2573: ARTEMIS-2265 Support Federated Queues and Addresses URL: https://github.com/apache/activemq-artemis/pull/2573 Implement Federated Queue (builds on recent consumer priority) Implement Federated Address (builds on recent queue level

[GitHub] jbertram closed pull request #2: Initial Content proposal for new ActiveMQ website

jbertram closed pull request #2: Initial Content proposal for new ActiveMQ website URL: https://github.com/apache/activemq-website/pull/2 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] jbertram opened a new pull request #2: Initial Content proposal for new ActiveMQ website

jbertram opened a new pull request #2: Initial Content proposal for new ActiveMQ website URL: https://github.com/apache/activemq-website/pull/2 This is an automated message from the Apache Git Service. To respond to the

[GitHub] franz1981 commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

franz1981 commented on issue #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572#issuecomment-468653660 I have left 2 commits until it will get reviewed, to simplify the code review Given that is

[GitHub] franz1981 opened a new pull request #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication

franz1981 opened a new pull request #2572: ARTEMIS-2264 PurgeOnNoConsumers prevent removal of messages with replication URL: https://github.com/apache/activemq-artemis/pull/2572 This is an automated message from the Apache

[GitHub] k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-468620562 @clebertsuconic @michaelandrepearce I'm struggling to find the right way to refactor by moving

[GitHub] alanprot opened a new pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

alanprot opened a new pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s… URL: https://github.com/apache/activemq/pull/349 …how information about Storage write latency This is an

[GitHub] michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation

michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation URL: https://github.com/apache/activemq-artemis/pull/2571#discussion_r261428128 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation

michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation URL: https://github.com/apache/activemq-artemis/pull/2571#discussion_r261428128 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation

michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation URL: https://github.com/apache/activemq-artemis/pull/2571#discussion_r261428128 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation

michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation URL: https://github.com/apache/activemq-artemis/pull/2571#discussion_r261428128 ## File path:

[GitHub] tofflos opened a new pull request #2571: Added Javadoc reference to the documentation

tofflos opened a new pull request #2571: Added Javadoc reference to the documentation URL: https://github.com/apache/activemq-artemis/pull/2571 I would have preferred the link to point to https://activemq.apache.org/artemis/docs/2.7.0/configuring-transports.html but I'm not

[GitHub] franz1981 closed pull request #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

franz1981 closed pull request #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523 This is an automated message from the Apache Git Service. To

[GitHub] clebertsuconic commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

clebertsuconic commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-468293346 I am merging this so I can cherry-pick using some git-magic into the new native project.

[GitHub] clebertsuconic commented on issue #2570: ARTEMIS-TBD / DO-NOT-MERGE-THIS Stripping activemq-artemis as a separated proejct

clebertsuconic commented on issue #2570: ARTEMIS-TBD / DO-NOT-MERGE-THIS Stripping activemq-artemis as a separated proejct URL: https://github.com/apache/activemq-artemis/pull/2570#issuecomment-467996157 I'm sending this PR to test what would happen in Travis. I'm still working on it.. it

[GitHub] clebertsuconic opened a new pull request #2570: ARTEMIS-TBD / DO-NOT-MERGE-THIS Stripping activemq-artemis as a separated proejct

clebertsuconic opened a new pull request #2570: ARTEMIS-TBD / DO-NOT-MERGE-THIS Stripping activemq-artemis as a separated proejct URL: https://github.com/apache/activemq-artemis/pull/2570 This is an automated message from

[GitHub] clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-467943246 @k-wall one way would be to add a method setCorrelation on Message. There, the default

[GitHub] k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-467941470 > please squash the previous commit on the first.. > > Also did you look into Michael's

[GitHub] clebertsuconic commented on issue #2569: ARTEMIS-2263 Support queue level auto-delete configuration

clebertsuconic commented on issue #2569: ARTEMIS-2263 Support queue level auto-delete configuration URL: https://github.com/apache/activemq-artemis/pull/2569#issuecomment-467886902 +1000 merging it This is an automated

[GitHub] asfgit merged pull request #2569: ARTEMIS-2263 Support queue level auto-delete configuration

asfgit merged pull request #2569: ARTEMIS-2263 Support queue level auto-delete configuration URL: https://github.com/apache/activemq-artemis/pull/2569 This is an automated message from the Apache Git Service. To respond to

[GitHub] clebertsuconic commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

clebertsuconic commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260766594 ## File path:

[GitHub] clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-467875172 please squash the previous commit on the first.. Also did you look into Michael's

[GitHub] k-wall commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

k-wall commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260663401 ## File path:

[GitHub] k-wall commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

k-wall commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260663401 ## File path:

[GitHub] k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-467790082 > There's a checkstyle issue on your change. (easy to fix) > > Can you provide a use case for why

[GitHub] nguyenhoan opened a new pull request #348: close DataByteArrayOutputStream buff of WriteBatch

nguyenhoan opened a new pull request #348: close DataByteArrayOutputStream buff of WriteBatch URL: https://github.com/apache/activemq/pull/348 This is an automated message from the Apache Git Service. To respond to the

[GitHub] michaelandrepearce commented on a change in pull request #2569: ARTEMIS-2263 Support queue level auto-delete configuration

michaelandrepearce commented on a change in pull request #2569: ARTEMIS-2263 Support queue level auto-delete configuration URL: https://github.com/apache/activemq-artemis/pull/2569#discussion_r260577498 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2569: ARTEMIS-2263 Support queue level auto-delete configuration

michaelandrepearce commented on a change in pull request #2569: ARTEMIS-2263 Support queue level auto-delete configuration URL: https://github.com/apache/activemq-artemis/pull/2569#discussion_r260577387 ## File path:

[GitHub] michaelandrepearce opened a new pull request #2569: ARTEMIS-2263 Support queue level auto-delete configuration

michaelandrepearce opened a new pull request #2569: ARTEMIS-2263 Support queue level auto-delete configuration URL: https://github.com/apache/activemq-artemis/pull/2569 Add ability to configure when creating auto created queues at the queue level Add support for configuring message

[GitHub] michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260478864 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260477757 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260477757 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260474101 ## File path:

[GitHub] clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request

clebertsuconic commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-467596553 There's a checkstyle issue on your change. (easy to fix) Can you provide a use case for

[GitHub] k-wall opened a new pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

k-wall opened a new pull request #2568: ARTEMIS-2262: Correlate management response messages with the request URL: https://github.com/apache/activemq-artemis/pull/2568 This is an automated message from the Apache Git

[GitHub] clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r260320311 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r260320311 ## File path:

[GitHub] emagiz commented on issue #2547: Patched with live lock evaluation

emagiz commented on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-467365112 It's taking some time because we are also looking into large message support using amqp where we get two different issues with broken

[GitHub] emagiz commented on issue #2547: Patched with live lock evaluation

emagiz commented on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-467361027 Yes, I will. I will address your comments and I checked the other pull request which addresses a different issue. It will take some time for

[GitHub] orpiske closed pull request #2566: ARTEMIS-2183 Useless statement in public synchronized List

orpiske closed pull request #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566 This is an automated message from the Apache Git Service. To respond to

[GitHub] wy96f commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

wy96f commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r260106529 ## File path:

[GitHub] clebertsuconic commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467251396 can you close this? I sent a statement to close it but for some reason it did not work. already

[GitHub] asfgit closed pull request #2565: ARTEMIS-2243 Fixing ClassLoding issues

asfgit closed pull request #2565: ARTEMIS-2243 Fixing ClassLoding issues URL: https://github.com/apache/activemq-artemis/pull/2565 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit merged pull request #2567: RefsOperation::getMessages

asfgit merged pull request #2567: RefsOperation::getMessages URL: https://github.com/apache/activemq-artemis/pull/2567 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] clebertsuconic commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467209134 #2567 supersedes this. when merged, it will close this one.

[GitHub] clebertsuconic opened a new pull request #2567: RefsOperation::getMessages

clebertsuconic opened a new pull request #2567: RefsOperation::getMessages URL: https://github.com/apache/activemq-artemis/pull/2567 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] clebertsuconic commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467208829 @orpiske / @michaelandrepearce there are no tests for listPreparedTransactionsDetail on consumers. I

[GitHub] oflebbe opened a new pull request #347: Use secure repository url

oflebbe opened a new pull request #347: Use secure repository url URL: https://github.com/apache/activemq/pull/347 Should be obvious This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] orpiske commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467169083 > So the only other thing here. Is this obviosuly has gone unnoticed for ages. To avoid this in future a test,

[GitHub] orpiske removed a comment on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

orpiske removed a comment on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467164632 On a second thought. I don't think that is right.

[GitHub] orpiske edited a comment on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

orpiske edited a comment on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467164632 On a second thought. I don't think that is right.

[GitHub] orpiske edited a comment on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

orpiske edited a comment on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467164632 > So the only other thing here. Is this obviosuly has gone unnoticed for ages. To avoid this in future a

[GitHub] orpiske edited a comment on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

orpiske edited a comment on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467164632 > So the only other thing here. Is this obviosuly has gone unnoticed for ages. To avoid this in future a

[GitHub] orpiske commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on issue #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566#issuecomment-467164632 > So the only other thing here. Is this obviosuly has gone unnoticed for ages. To avoid this in future a test,

[GitHub] orpiske opened a new pull request #2566: ARTEMIS-2183 Useless statement in public synchronized List

orpiske opened a new pull request #2566: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2566 Sending this PR again based feedback from @clebertsuconic. Ensures that the returned list returns the refsToAck list instead

[GitHub] orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259961238 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259960599 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259960277 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259955081 ## File path:

[GitHub] orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259943352 ## File path:

[GitHub] orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259943352 ## File path:

[GitHub] orpiske closed pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske closed pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564 This is an automated message from the Apache Git Service. To respond to

[GitHub] orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259940130 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

michaelandrepearce commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259939801 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

michaelandrepearce commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259939801 ## File path:

[GitHub] clebertsuconic commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-467101331 -1000 This is an automated message from the

[GitHub] clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259932919 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259932073 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259932073 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259926106 ## File path:

[GitHub] clebertsuconic opened a new pull request #2565: ARTEMIS-2243 Fixing ClassLoding issues

clebertsuconic opened a new pull request #2565: ARTEMIS-2243 Fixing ClassLoding issues URL: https://github.com/apache/activemq-artemis/pull/2565 This is an automated message from the Apache Git Service. To respond to the

[GitHub] clebertsuconic commented on issue #2563: NO-JIRA Document reloading when using modularised broker.xml

clebertsuconic commented on issue #2563: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2563#issuecomment-467093513 @michaelandrepearce if you're merging your own commit on a small thing, there's no need to send a PR..

[GitHub] wy96f commented on issue #2558: ARTEMIS-2257 Synchronize SharedEventLoopGroup shutdownGracefully

wy96f commented on issue #2558: ARTEMIS-2257 Synchronize SharedEventLoopGroup shutdownGracefully URL: https://github.com/apache/activemq-artemis/pull/2558#issuecomment-466977919 > @wy96f did you see my comment on the JIRA? > > Synchronized SharedEventLoopGroup is not the bug, it's

[GitHub] wy96f commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

wy96f commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259702299 ## File path:

[GitHub] wy96f commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

wy96f commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259701428 ## File path:

[GitHub] michaelandrepearce commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List

michaelandrepearce commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-466787498 Id agree with franz for it not to be causing issue you got to think is this even being used. Is it and

[GitHub] franz1981 commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List

franz1981 commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-466779725 I think that the original idea were to return a copy of it, that's why the method were synchronized.. But the

[GitHub] orpiske commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-466779487 @franz1981 @michaelandrepearce thanks for the insights and ideas! In light of that, I changed it to return

[GitHub] orpiske commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-466775546 > Take a look at the history for it ans maybe it has been changed from something that was correct before! It

[GitHub] franz1981 commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List

franz1981 commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-466771257 Take a look at the history for it ans maybe it has been changed from something that was correct before!

[GitHub] orpiske commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-466762846 > I would assume this is a bug and actually is meant to be populated by an internal field Maybe it should be

[GitHub] orpiske opened a new pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

orpiske opened a new pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564 Removes the seemingly unnecessary call to addAll to self. This is

[GitHub] asfgit closed pull request #2563: NO-JIRA Document reloading when using modularised broker.xml

asfgit closed pull request #2563: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2563 This is an automated message from the Apache Git Service. To respond

[GitHub] michaelandrepearce opened a new pull request #2563: NO-JIRA Document reloading when using modularised broker.xml

michaelandrepearce opened a new pull request #2563: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2563 This is an automated message from the Apache Git

[GitHub] asfgit merged pull request #2562: NO-JIRA Document reloading when using modularised broker.xml

asfgit merged pull request #2562: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2562 This is an automated message from the Apache Git Service. To respond

[GitHub] michaelandrepearce opened a new pull request #2562: NO-JIRA Document reloading when using modularised broker.xml

michaelandrepearce opened a new pull request #2562: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2562 Add docs to clarify the need to touch broker.xml for modularised config to reload

[GitHub] asfgit closed pull request #2529: Refactor the native library build code

asfgit closed pull request #2529: Refactor the native library build code URL: https://github.com/apache/activemq-artemis/pull/2529 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit closed pull request #2530: Native library fixes

asfgit closed pull request #2530: Native library fixes URL: https://github.com/apache/activemq-artemis/pull/2530 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] clebertsuconic commented on issue #2558: ARTEMIS-2257 Synchronize SharedEventLoopGroup shutdownGracefully

clebertsuconic commented on issue #2558: ARTEMIS-2257 Synchronize SharedEventLoopGroup shutdownGracefully URL: https://github.com/apache/activemq-artemis/pull/2558#issuecomment-466420409 @wy96f did you see my comment on the JIRA? Synchronized SharedEventLoopGroup is not the bug,

[GitHub] clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259368542 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259368333 ## File path:

[GitHub] franz1981 commented on issue #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

franz1981 commented on issue #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#issuecomment-466403676 @michaelandrepearce I've added support for the `NettyFailoverTest` that's using the node managers for

[GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259343016 ## File path:

[GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259343016 ## File path:

  1   2   3   4   5   6   7   8   9   10   >