Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246416127
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246398611
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246403272
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/QueueConsumerPriorityTest.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245974624
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245973668
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245968414
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConsumerPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245955337
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245973707
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245953999
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245965929
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245972322
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/QueueConsumerPriorityTest.java
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2256
Delivery annotations are for per-hop usage, so the brokers the only thing
that should be adding delivery annotations to messages it is sending.
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2464#discussion_r242205353
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
> So openwire always returns a value on asking groupseq. It never gives an
ability to determine if it was set by client or not.
It does seem to return a value if you ask for
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
> Re seq not set, its an int field so its tech always set if you request
it, just should default 0 if not set.
JMSXGroupSeq is set explicitly by the application. If it isn't
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
I tried the tests and they worked, but it occurred to me that though
changes might be needed in general to fix whats currently stopping the tests
passing, just making them pass is likely
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2387
The 3 tests that failed earlier (in multiple envs) pass with this reverted,
so it does seem related beyond the original coincidence of changing the same
bits.
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2387
There are integration test failures occurring on master recently due to
some issue or change with JMSXGroupSeq handling, looks to be for
Openwire-->AMQP te
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2367
There was a JIRA recently about changing the IDs, ARTEMIS-1018, if it
caused these failures the fixup commit should have gone against that too rather
than being a NO-JIRA.
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r222357714
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/SendAcknowledgementHandler.java
---
@@ -41,4 +41,13
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r221189768
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/SendAcknowledgementHandler.java
---
@@ -41,4 +41,13
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r221191158
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
---
@@ -577,26 +587,62
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2306
Seems like https://issues.apache.org/jira/browse/ARTEMIS-1898 might be
relevant to one part of the changes.
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2274
Fair enough, I can see that could be argued as a bug, however are there any
uses in the broker which will do that? I don't know of any off hand.
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2274#discussion_r214073404
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java
---
@@ -106,7
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2277
Looks good to me, unsurprisingly. I just tweaked the commit message
slightly to fix/reverse part of the threshold statement in the first half.
Looking at it further, the same
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2272#discussion_r213342138
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallbackTest.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2272#discussion_r213343201
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallbackTest.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2272#discussion_r213342991
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallbackTest.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2272#discussion_r213341266
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2272#discussion_r213343972
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallbackTest.java
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2274
Not sure I'd call it a bug really, more that this is a memory optimisation,
one that shouldnt be getting used much since it only comes into play if you are
encoding things (whereas
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2245
Merged to 2.6.x in commit c1c2d01bc525411d46cef1c7589e4a1e71e42b02
---
GitHub user gemmellr opened a pull request:
https://github.com/apache/activemq-artemis/pull/2245
ARTEMIS-2027: handle aborted AMQP deliveries
Fixes handling of aborted deliveries to ensure the receiver processes the
delivery (and any subsequent ones) appropriately. Unit tested only
GitHub user gemmellr opened a pull request:
https://github.com/apache/activemq-artemis/pull/2230
ARTEMIS-1978: update to proton-j 0.27.3 to resolve sequencing issues
As before with #2221, but now cherry picked to 2.6.x with needed fixups.
You can merge this pull request into a Git
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2221
I'd also like to backport this change to 2.6.x given the severity of the
problems, which is why 0.27.3 is used and not yet 0.28.1.
The backport needs a small test change rather
GitHub user gemmellr opened a pull request:
https://github.com/apache/activemq-artemis/pull/2221
ARTEMIS-1978: update to proton-j 0.27.3 to resolve sequencing issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gemmellr
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
I was offering a second view that there is an issue requiring a change and
noting the proposal worked for me, not suggesting you should just keep
modifying it yourself.
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
FWIW, I created a broker instance on Windows with spaces in the directory
name, and the broker failed to start using the suggested run command. I then
edited the artemis.cmd within
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-nms-amqp/pull/2
I cant really help on the code side as .NET isn't an area I play, but from
a skim over the file list for curiosity it seemed like there are various
non-code elements in this PR which
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2174#discussion_r201008853
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2154#discussion_r197166964
--- Diff:
examples/protocols/amqp/dotnet/HighPerformanceLoad/ReceiverPool.cs ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2152
> with heart beats.. you won't this test.. as ping/pongs will disconnect
the client.
The idle-timeout stuff defaults to killing after 60 seconds, which the test
doesnt e
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2152
Yes, after a connection-reset-by-peer error which meant the broker knew the
connection had gone, which it knew regardless of whether idle-timeout handling
was enabled or not, but failed
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2152
To me it seemed more about cleaning up the client regardless of
idle-timeout, and that it should do exactly the same if idle-timeout handling
is enabled or if it wasn't using AMQP at all.
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2152
(I still don't think it should be in that class though per #2149
comments...but the test itself looks good now)
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2152
Looks good
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2152#discussion_r196818582
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -137,18
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2149#discussion_r196814636
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -80,4 +88,68
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2149#discussion_r196726608
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -80,4 +88,68
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2149#discussion_r196726336
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -80,4 +88,68
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2149#discussion_r196726944
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -80,4 +88,68
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2149#discussion_r196724509
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -80,4 +88,68
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2143
For anyone else wondering later, the other JIRA appears to be
https://issues.apache.org/jira/browse/ARTEMIS-1942
---
GitHub user gemmellr opened a pull request:
https://github.com/apache/activemq-artemis/pull/2147
ARTEMIS-1940: premature release of pooled buffers during send can cause
AMQP connection failures
See https://issues.apache.org/jira/browse/ARTEMIS-1940 for details.
You can merge
GitHub user gemmellr opened a pull request:
https://github.com/apache/activemq-artemis/pull/2144
ARTEMIS-1934: fix handling/accounting of sent AMQP connection data
Fix for https://issues.apache.org/jira/browse/ARTEMIS-1934 with some tests,
plus improvements for the existing max
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2117
Looks good. Minor nit that I prefer numbered list entries don't all have
"1." as the deliminator since it makes the raw file more awkward to read, but I
also don't ca
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191924187
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191922206
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191921539
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
---
@@ -355,10 +355,27 @@ default Message
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191792711
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r19182
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191680587
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/crossprotocol
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191714303
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191715800
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191721270
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/crossprotocol
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2113
> So RH docs shouldnt influence the upstream/apache.
On this specifically, the docs pointed to are for an implementation of the
AMQP 0-x style topic binding syntax the Arte
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2088
@clebertsuconic I think having it configurable makes sense, but I think its
mostly in the way being part of the default config.
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2088
The CI failure doesnt seem related
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2088
A separate change for later, but I think it would be nicer to remove the
config from the XML by default as few will need/want to change it.
---
GitHub user gemmellr opened a pull request:
https://github.com/apache/activemq-artemis/pull/2088
ARTEMIS-1862: fix 'amqpLowCredits' XML config, update code defaults
More details at https://issues.apache.org/jira/browse/ARTEMIS-1862
You can merge this pull request into a Git
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2084#discussion_r187650767
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageProducerTest.java
---
@@ -70,10
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2084#discussion_r187566075
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageProducerTest.java
---
@@ -70,10
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1961#discussion_r176769932
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1961#discussion_r176719439
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1961#discussion_r176719562
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1881#discussion_r169394169
--- Diff:
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/NetworkHealthTest.java
---
@@ -179,6 +182,7 @@ private void doCheck
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1630#discussion_r148774957
--- Diff: RELEASING.md ---
@@ -93,11 +133,15 @@ scm.tag=1.4.0
## Removing additional files
-Note: There is one additional
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1630#discussion_r148774726
--- Diff: RELEASING.md ---
@@ -62,12 +86,26 @@ What is SCM release tag or label for "ActiveMQ Artemis
Parent"? (org.apache.acti
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
I don't think that makes sense personally. If the end view is that it
should be maintained outwith the broker repo/distribution, that is where it
should go from the outset
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146822624
--- Diff: docs/user-manual/en/kafka-bridges.md ---
@@ -0,0 +1,180 @@
+# Apache ActiveMQ Kafka Bridge
+
+The function of a bridge
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146821726
--- Diff: docs/user-manual/en/kafka-bridges.md ---
@@ -0,0 +1,180 @@
+# Apache ActiveMQ Kafka Bridge
+
+The function of a bridge
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146830052
--- Diff:
integration/activemq-kafka/activemq-kafka-bridge/src/main/java/org/apache/activemq/artemis/integration/kafka/bridge
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146824495
--- Diff: docs/user-manual/en/kafka-bridges.md ---
@@ -0,0 +1,180 @@
+# Apache ActiveMQ Kafka Bridge
+
+The function of a bridge
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146818341
--- Diff: docs/user-manual/en/kafka-bridges.md ---
@@ -0,0 +1,180 @@
+# Apache ActiveMQ Kafka Bridge
+
+The function of a bridge
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146817389
--- Diff: docs/user-manual/en/kafka-bridges.md ---
@@ -0,0 +1,180 @@
+# Apache ActiveMQ Kafka Bridge
+
+The function of a bridge
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146824362
--- Diff: docs/user-manual/en/kafka-bridges.md ---
@@ -0,0 +1,180 @@
+# Apache ActiveMQ Kafka Bridge
+
+The function of a bridge
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146821818
--- Diff: docs/user-manual/en/kafka-bridges.md ---
@@ -0,0 +1,180 @@
+# Apache ActiveMQ Kafka Bridge
+
+The function of a bridge
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146828027
--- Diff:
integration/activemq-kafka/activemq-kafka-protocols/activemq-kafka-amqp-protocol/src/main/java/org/apache/activemq/artemis/integration
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146825025
--- Diff:
integration/activemq-kafka/activemq-kafka-bridge/src/main/java/org/apache/activemq/artemis/integration/kafka/bridge
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
@michaelandrepearce Ah, I missed the note while skimming. The methods will
presumably be at package visibility in keeping with the fact they are not
intended to be used outside
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
Skimming the code quickly, I had to do a double take on a couple of
occasions, and had some related observations.
There looked to be extensive use of implementation detail
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145959626
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145906703
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145906975
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/Events.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145910546
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145907083
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
I don't have any more comments but I was mainly reviewing from the AMQP
handling perspective, I don't know enough about the Core bits usage to be
comfortable about merging it myself
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
> "Connection readTimeout has occurred.",
NETTY_READ_TIMEOUT = "read-timeout-seconds";
private int readTimeout;
Would a more descript
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
..and looks like you changed it while I was commenting as such ;)
---
1 - 100 of 151 matches
Mail list logo
