Re: Review Request 27319: Alerts: Convert Script-Style Flume Alerts From Nagios

2014-10-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27319/#review58976 --- Ship it! Ship It! - Nate Cole On Oct. 28, 2014, 11:36 p.m

Re: Review Request 27331: Show all properties for source subresource in alert_definitions API response

2014-10-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27331/#review58990 --- Ship it! Ship It! - Nate Cole On Oct. 29, 2014, 11:17 a.m

Re: Nagios Alert Ambari 2.0

2014-10-29 Thread Nate Cole
+1 for the proposal. What will be the process for turning off all the hadoop-centric alerts from the running Nagios instance? That we remove the service from Ambari still leaves a dangling service. Thanks, Nate On Oct 29, 2014, at 2:47 PM, Jonathan Hurley jhur...@hortonworks.com wrote: Hi

Re: Review Request 27366: Adds Blueprint export handling for Knox and Zookeeper properties in HDP 2.2 stack

2014-10-30 Thread Nate Cole
see context: are tehse getting set even if, say, Slider is not installed? Are properties getting set if they don't belong? - Nate Cole On Oct. 29, 2014, 8:48 p.m., Robert Nettleton wrote: --- This is an automatically generated e-mail

Re: Review Request 27372: Alerts: Creating WEB Alert Definitions via REST API Drops URI

2014-10-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27372/#review59182 --- Ship it! Ship It! - Nate Cole On Oct. 29, 2014, 11:31 p.m

Re: Review Request 27366: Adds Blueprint export handling for Knox and Zookeeper properties in HDP 2.2 stack

2014-10-30 Thread Nate Cole
On Oct. 30, 2014, 7:22 a.m., Nate Cole wrote: ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, lines 1017-1019 https://reviews.apache.org/r/27366/diff/1/?file=742190#file742190line1017 Just a general question since I

Re: Review Request 27284: Ability to support umask 027

2014-10-31 Thread Nate Cole
On Oct. 30, 2014, 7:25 a.m., Nate Cole wrote: Ship It! Szilard Nemethy wrote: Nate, Will you commit this patch as it is or wait for the implementation for HDP2.2? Shivani suggested to continue with the work for HDP 2.2 under the same patch and ticket, but if you

Re: Review Request 27394: Alerts: Convert HDP 1.x Nagios Alerts

2014-10-31 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27394/#review59325 --- Ship it! Ship It! - Nate Cole On Oct. 30, 2014, 4:44 p.m

Re: Review Request 27422: Flume: /etc/flume/conf/flume-env.sh not being used when multiple agents on host

2014-10-31 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27422/#review59326 --- Ship it! Ship It! - Nate Cole On Oct. 31, 2014, 6:49 a.m

Re: Review Request 27435: Views: 400 error on redeploy

2014-10-31 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27435/#review59397 --- Ship it! Ship It! - Nate Cole On Oct. 31, 2014, 2:29 p.m., Tom

Review Request 27454: Flume: Change default env variables for HCAT and HIVE for cluster version

2014-10-31 Thread Nate Cole
[INFO] Finished at: Fri Oct 31 19:26:24 EDT 2014 [INFO] Final Memory: 28M/158M [INFO] Thanks, Nate Cole

Re: Review Request 27454: Flume: Change default env variables for HCAT and HIVE for cluster version

2014-11-01 Thread Nate Cole
] [INFO] Total time: 49.107s [INFO] Finished at: Fri Oct 31 19:26:24 EDT 2014 [INFO] Final Memory: 28M/158M [INFO] Thanks, Nate Cole

Re: Review Request 27485: Add alerts for ZKFC down

2014-11-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27485/#review59521 --- Ship it! Ship It! - Nate Cole On Nov. 2, 2014, 12:01 a.m

Re: Review Request 27465: Adds support for proper configuration versioning with Blueprints

2014-11-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27465/#review59537 --- Ship it! Ship It! - Nate Cole On Nov. 1, 2014, 11:22 a.m

Re: Review Request 27206: Create Kerberos Service

2014-11-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27206/#review59570 --- Ship it! Ship It! - Nate Cole On Oct. 30, 2014, 10:09 p.m

Review Request 27530: HostComponent requests that include Nagios are not performant

2014-11-03 Thread Nate Cole
12:12:05 EST 2014 [INFO] Final Memory: 29M/213M [INFO] Thanks, Nate Cole

Re: Review Request 27530: HostComponent requests that include Nagios are not performant

2014-11-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27530/#review59595 --- On Nov. 3, 2014, 12:32 p.m., Nate Cole wrote

Re: Review Request 27513: Ambari Server HA Phase 1: Provide backup and restore capability

2014-11-04 Thread Nate Cole
the method, delimited by triple-quotes: def perform_backup(self): User to perform the actual backup - Nate Cole On Nov. 3, 2014, 4:48 a.m., Szilard Nemethy wrote: --- This is an automatically generated e-mail

Review Request 27590: Upgrade Execute: Create API endpoint for upgrades and upgrade items

2014-11-04 Thread Nate Cole
: 29M/248M [INFO] Thanks, Nate Cole

Re: Review Request 27590: Upgrade Execute: Create API endpoint for upgrades and upgrade items

2014-11-04 Thread Nate Cole
--- On Nov. 4, 2014, 4:55 p.m., Nate Cole wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27590

Re: Review Request 27590: Upgrade Execute: Create API endpoint for upgrades and upgrade items

2014-11-04 Thread Nate Cole
--- On Nov. 4, 2014, 4:55 p.m., Nate Cole wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27590

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-05 Thread Nate Cole
is in no-mans land. It's ok to put this kind of detail with the class doc. ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java https://reviews.apache.org/r/27607/#comment101259 Use UpgradeState - Nate Cole On Nov. 4, 2014, 11:30 p.m., Alejandro Fernandez wrote

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-05 Thread Nate Cole
actual timestamp fields, just longs ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql https://reviews.apache.org/r/27607/#comment101267 No timestamp fields - Nate Cole On Nov. 4, 2014, 11:30 p.m., Alejandro Fernandez wrote

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-05 Thread Nate Cole
/ClusterVersionEntity.java https://reviews.apache.org/r/27607/#comment101263 All members should be together at the top. Not member/getter/setter all together - Nate Cole On Nov. 4, 2014, 11:30 p.m., Alejandro Fernandez wrote

Re: Review Request 27635: Repository Version Management - Create API and BE support for creating/retrieving repo versions

2014-11-05 Thread Nate Cole
. - Nate Cole On Nov. 5, 2014, 2:15 p.m., Yurii Shylov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27635/ --- (Updated Nov

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-05 Thread Nate Cole
/ --- (Updated Nov. 4, 2014, 11:30 p.m.) Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, Sid Wagle, and Yurii Shylov. Bugs: AMBARI-8148 https://issues.apache.org/jira/browse/AMBARI-8148 Repository: ambari Description --- 1. Create

Re: Review Request 27635: Repository Version Management - Create API and BE support for creating/retrieving repo versions

2014-11-06 Thread Nate Cole
/resources/Ambari-DDL-MySQL-CREATE.sql https://reviews.apache.org/r/27635/#comment101498 Use _ for table name readability: repo_version. We're trying to make things a bit more readable. - Nate Cole On Nov. 6, 2014, 7:59 a.m., Yurii Shylov wrote

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-06 Thread Nate Cole
https://reviews.apache.org/r/27607/#comment101503 formatting - Nate Cole On Nov. 5, 2014, 5:02 p.m., Alejandro Fernandez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27607

Re: Review Request 27635: Repository Version Management - Create API and BE support for creating/retrieving repo versions

2014-11-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27635/#review60175 --- Ship it! Ship It! - Nate Cole On Nov. 6, 2014, 11:14 a.m

Re: Review Request 27696: Enable Explicit Stack Service Inheritance

2014-11-06 Thread Nate Cole
/ServiceModule.java https://reviews.apache.org/r/27696/#comment101593 Typically see the java/javax.* imported before the org.* stuff, then com.* after that. - Nate Cole On Nov. 6, 2014, 2:59 p.m., John Speidel wrote

Re: Review Request 27688: Alerts: Convert Bigtop Stack Nagios Alerts

2014-11-06 Thread Nate Cole
/services/AmbariMetaInfo.java https://reviews.apache.org/r/27688/#comment101608 Isn't it the case that this could happen? - Nate Cole On Nov. 6, 2014, 12:48 p.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail

Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster

2014-11-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27607/#review60262 --- Ship it! Ship It! - Nate Cole On Nov. 6, 2014, 5:03 p.m

Re: How To pass parameter to ambari stack

2014-11-06 Thread Nate Cole
Hi Raveesh, You can pass data directly to the agent by specifying part of the request info using the _name of the component itself_. For example, Flume agents are a many-per-host, and they are individually controlled with this mechanism. Consider the following command to stop Flume: PUT

Re: Review Request 27282: Expose the ability to trigger all Host Checks on demand via API

2014-11-07 Thread Nate Cole
do that since I don't own it). - Nate Cole On Oct. 31, 2014, 10:20 a.m., Szilard Nemethy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27282

Re: Review Request 27513: Ambari Server HA Phase 1: Provide backup and restore capability

2014-11-07 Thread Nate Cole
://reviews.apache.org/r/27513/#comment101679 Typically wouldn't use a main like this. Usually you create an instance of the class and call the methods on it: backupRestore = BackupRestore(...) backupRestore.backup() etc. - Nate Cole On Nov. 7, 2014, 3:36 a.m., Szilard Nemethy wrote

Re: Review Request 27513: Ambari Server HA Phase 1: Provide backup and restore capability

2014-11-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27513/#review60315 --- Ship it! Ship It! - Nate Cole On Nov. 7, 2014, 3:36 a.m

Re: Review Request 27696: Enable Explicit Stack Service Inheritance

2014-11-07 Thread Nate Cole
/ --- (Updated Nov. 6, 2014, 2:59 p.m.) Review request for Ambari, Nate Cole and Tom Beerbower. Bugs: AMBARI-7175 https://issues.apache.org/jira/browse/AMBARI-7175 Repository: ambari Description --- Adds Explicit Stack Service

Review Request 27730: Upgrade Execute: Load and parse upgrade packs from stack directory

2014-11-07 Thread Nate Cole
] [INFO] Total time: 30:03.553s [INFO] Finished at: Fri Nov 07 10:55:25 EST 2014 [INFO] Final Memory: 29M/252M [INFO] Thanks, Nate Cole

Re: Review Request 27726: Views: Instance Data API doesn't work in threads

2014-11-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27726/#review60347 --- Ship it! Ship It! - Nate Cole On Nov. 7, 2014, 12:43 p.m., Tom

Re: Review Request 27696: Enable Explicit Stack Service Inheritance

2014-11-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27696/#review60350 --- Ship it! Ship It! - Nate Cole On Nov. 6, 2014, 2:59 p.m., John

Re: Review Request 27730: Upgrade Execute: Load and parse upgrade packs from stack directory

2014-11-07 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 27740: ambari cluster HS2 health check causing errors in logs

2014-11-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27740/#review60369 --- Ship it! Ship It! - Nate Cole On Nov. 7, 2014, 3:04 p.m

Re: Review Request 27780: HiveService2 alert for unsecure/secure cluster

2014-11-08 Thread Nate Cole
] Finished at: Sat Nov 08 17:02:15 EST 2014 [INFO] Final Memory: 28M/166M [INFO] Thanks, Nate Cole

Re: Review Request 27728: Usability: Do not force a mysql restart to apply Hive changes

2014-11-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27728/#review60580 --- Ship it! Ship It! - Nate Cole On Nov. 7, 2014, 9:53 a.m

Re: Review Request 27730: Upgrade Execute: Load and parse upgrade packs from stack directory

2014-11-10 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 27790: Alerts: Provide Summary Structure On Alerts Endpoint

2014-11-10 Thread Nate Cole
://reviews.apache.org/r/27790/#comment101948 Why change to public here, I didn't see any cases outside the classes of using it - Nate Cole On Nov. 9, 2014, 9:14 a.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail

Re: Review Request 27396: Pushing component logs to HDFS from ambari-agent

2014-11-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27396/#review60601 --- Ship it! Ship It! - Nate Cole On Nov. 6, 2014, 9:11 p.m., Cabir

Re: Review Request 27790: Alerts: Provide Summary Structure On Alerts Endpoint

2014-11-10 Thread Nate Cole
On Nov. 10, 2014, 9:51 a.m., Nate Cole wrote: ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java, lines 50-63 https://reviews.apache.org/r/27790/diff/1/?file=755705#file755705line50 Why change to public here, I didn't see any cases

Re: Review Request 27802: Rest api's for host component logs.

2014-11-10 Thread Nate Cole
. Can this be in metainfo.xml somewhere? - Nate Cole On Nov. 10, 2014, 4:04 a.m., Cabir Zounaidou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27802

Re: Review Request 27802: Rest api's for host component logs.

2014-11-10 Thread Nate Cole
- Nate Cole On Nov. 10, 2014, 4:04 a.m., Cabir Zounaidou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27802/ --- (Updated Nov

Re: Review Request 27819: Repository Version Management - Create API and BE support for update/delete repository version

2014-11-10 Thread Nate Cole
/CrudDAO.java https://reviews.apache.org/r/27819/#comment102006 Generics typically don't get a huge name, so maybe use E/P, or E/K or something - Nate Cole On Nov. 10, 2014, 1:34 p.m., Yurii Shylov wrote: --- This is an automatically

Re: Review Request 27802: Rest api's for host component logs.

2014-11-10 Thread Nate Cole
On Nov. 10, 2014, 11:25 a.m., Nate Cole wrote: ambari-server/src/main/resources/log_handler_config.json, lines 2-13 https://reviews.apache.org/r/27802/diff/2/?file=756646#file756646line2 Will be hard to add logging for new services. Can this be in metainfo.xml somewhere

Re: Review Request 27870: Alerts: Remove Nagios Service From The Stack

2014-11-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27870/#review60806 --- Ship it! Ship It! - Nate Cole On Nov. 11, 2014, 11:08 a.m

Re: Review Request 27854: Create DAO and Unit Tests for ClusterVersion

2014-11-11 Thread Nate Cole
/dao/ClusterVersionDAO.java https://reviews.apache.org/r/27854/#comment102220 Use DaoUtils - Nate Cole On Nov. 10, 2014, 10:19 p.m., Alejandro Fernandez wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27700: Allow for server-side commands

2014-11-11 Thread Nate Cole
/ServerActionExecutor.java https://reviews.apache.org/r/27700/#comment102237 * its (not it is) - Nate Cole On Nov. 10, 2014, 9:05 a.m., Robert Levas wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27854: Create DAO and Unit Tests for ClusterVersion

2014-11-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27854/#review60844 --- Ship it! Ship It! - Nate Cole On Nov. 11, 2014, 3:16 p.m

Re: Review Request 27897: Create DAO and Unit Tests for HostVersion

2014-11-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27897/#review61029 --- Ship it! Ship It! - Nate Cole On Nov. 11, 2014, 8:15 p.m

Re: Review Request 27819: Repository Version Management - Create API and BE support for update/delete repository version

2014-11-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27819/#review61030 --- Ship it! Ship It! - Nate Cole On Nov. 12, 2014, 6:10 a.m

Re: Review Request 27929: Alerts: Remove Nagios Remnants From Ambari Server Code

2014-11-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27929/#review61081 --- Ship it! This change fills me with happiness :) - Nate Cole

Re: Review Request 27998: Repository Version Management - Add validation for created repo versions

2014-11-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27998/#review61277 --- Ship it! Ship It! - Nate Cole On Nov. 13, 2014, 12:42 p.m

Re: Review Request 27999: Remove Nagios SSL Configuration From Ambari Scripts

2014-11-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27999/#review61295 --- Ship it! Ship It! - Nate Cole On Nov. 13, 2014, 12:55 p.m

Re: Review Request 27998: Repository Version Management - Add validation for created repo versions

2014-11-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27998/#review61452 --- Ship it! Ship It! - Nate Cole On Nov. 14, 2014, 11:35 a.m

Re: Review Request 28054: Add wizard hangs adding hosts with NPE

2014-11-14 Thread Nate Cole
] [INFO] Total time: 13:39.225s [INFO] Finished at: Fri Nov 14 17:16:30 EST 2014 [INFO] Final Memory: 27M/226M [INFO] Thanks, Nate Cole

Re: Review Request 28105: Alerts: Remove Flume Alerts From Host Components

2014-11-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28105/#review61688 --- Ship it! Ship It! - Nate Cole On Nov. 16, 2014, 8:54 a.m

Review Request 28112: Upgrade Execute: define db schema to store upgrade artifacts

2014-11-16 Thread Nate Cole
:21 EST 2014 [INFO] Final Memory: 29M/629M [INFO] Thanks, Nate Cole

Re: Review Request 28112: Upgrade Execute: define db schema to store upgrade artifacts

2014-11-17 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 28112: Upgrade Execute: define db schema to store upgrade artifacts

2014-11-17 Thread Nate Cole
--- On Nov. 17, 2014, 6:49 a.m., Nate Cole wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28112

Re: Review Request 27919: Distribute Repositories/Install Components - custom action script

2014-11-17 Thread Nate Cole
On Nov. 17, 2014, 8:37 a.m., Nate Cole wrote: ambari-server/src/main/resources/custom_actions/scripts/install_packages.py, lines 81-85 https://reviews.apache.org/r/27919/diff/3/?file=763819#file763819line81 A repo file may contain many, does this need a loop? Do

Re: Review Request 27919: Distribute Repositories/Install Components - custom action script

2014-11-17 Thread Nate Cole
On Nov. 17, 2014, 8:37 a.m., Nate Cole wrote: ambari-server/src/main/resources/custom_actions/scripts/install_packages.py, lines 81-85 https://reviews.apache.org/r/27919/diff/3/?file=763819#file763819line81 A repo file may contain many, does this need a loop? Do

Re: Review Request 28112: Upgrade Execute: define db schema to store upgrade artifacts

2014-11-17 Thread Nate Cole
/#comment103625 It can't be inlined because it needs to be serialized into JSON, and for that I need the field. Actually, this is a bug in PERCENT that it _shouldn't_ be in lined. - Nate Cole On Nov. 17, 2014, 6:49 a.m., Nate Cole wrote

Re: Review Request 28112: Upgrade Execute: define db schema to store upgrade artifacts

2014-11-17 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 28112: Upgrade Execute: define db schema to store upgrade artifacts

2014-11-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28112/#review61767 --- On Nov. 17, 2014, 1:56 p.m., Nate Cole wrote: --- This is an automatically generated e-mail

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

2014-11-17 Thread Nate Cole
vs cluster should look the same, no? - Nate Cole On Nov. 17, 2014, 1:28 p.m., Yurii Shylov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28124

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

2014-11-17 Thread Nate Cole
On Nov. 17, 2014, 3:49 p.m., Nate Cole wrote: Is there a need for two different types? A repo_version on a host vs cluster should look the same, no? Alejandro Fernandez wrote: Technically, there is a difference because the Cluster is required to have exactly one stack version

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

2014-11-17 Thread Nate Cole
/28124/#comment103756 No need. Each provider can live on its own. - Nate Cole On Nov. 17, 2014, 1:28 p.m., Yurii Shylov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28124

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

2014-11-17 Thread Nate Cole
://reviews.apache.org/r/28124/ --- (Updated Nov. 17, 2014, 1:28 p.m.) Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole. Bugs: AMBARI-8353 https://issues.apache.org/jira/browse/AMBARI-8353

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

2014-11-18 Thread Nate Cole
-DROP.sql https://reviews.apache.org/r/28159/#comment103852 Since there's a FK, I'm not sure if this needs to be removed before alert_target. I don't understand SQLServer enough to know - Nate Cole On Nov. 18, 2014, 12:34 a.m., Jonathan Hurley wrote

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

2014-11-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/#review61924 --- Ship it! Ship It! - Nate Cole On Nov. 18, 2014, 9:16 a.m

Re: Review Request 27284: Ability to support umask 027

2014-11-18 Thread Nate Cole
://reviews.apache.org/r/27284/#comment103847 Why x? There should be no runnables in this directory? - Nate Cole On Nov. 13, 2014, 5:39 a.m., Szilard Nemethy wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 28000: Bootstaraping and starting agents as non-root

2014-11-18 Thread Nate Cole
://reviews.apache.org/r/28000/#comment103860 change to command_prefix. And is the prefix needed when running as root (no bash -c)? - Nate Cole On Nov. 18, 2014, 10:20 a.m., Andrew Onischuk wrote: --- This is an automatically generated e-mail

Re: Review Request 28000: Bootstaraping and starting agents as non-root

2014-11-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28000/#review61930 --- Ship it! Ship It! - Nate Cole On Nov. 18, 2014, 10:20 a.m

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

2014-11-19 Thread Nate Cole
On Nov. 17, 2014, 3:49 p.m., Nate Cole wrote: Is there a need for two different types? A repo_version on a host vs cluster should look the same, no? Alejandro Fernandez wrote: Technically, there is a difference because the Cluster is required to have exactly one stack version

Re: Review Request 28194: Alerts UI: Alert Definition API should provide a 'description' field

2014-11-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28194/#review62153 --- Ship it! Ship It! - Nate Cole On Nov. 19, 2014, 8:25 a.m

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

2014-11-19 Thread Nate Cole
injected here, so no need for this (a resource provider is explicitly constructed) - Nate Cole On Nov. 19, 2014, 12:41 p.m., Yurii Shylov wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27284: Ability to support umask 027

2014-11-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27284/#review62331 --- Ship it! Ship It! - Nate Cole On Nov. 19, 2014, 9:30 a.m

Review Request 28277: Upgrade Execute: Create stages and tasks

2014-11-19 Thread Nate Cole
] [INFO] Total time: 20:30.942s [INFO] Finished at: Thu Nov 20 01:05:35 EST 2014 [INFO] Final Memory: 32M/611M [INFO] Thanks, Nate Cole

Review Request 28311: Upgrade Execute: implement proper RESTART commands

2014-11-20 Thread Nate Cole
results pending Thanks, Nate Cole

Re: Review Request 28311: Upgrade Execute: implement proper RESTART commands

2014-11-20 Thread Nate Cole
2014 [INFO] Final Memory: 30M/666M [INFO] Thanks, Nate Cole

Re: Review Request 28291: Alerts: Template Engine for Dispatching

2014-11-20 Thread Nate Cole
/notifications/dispatchers/EmailDispatcher.java https://reviews.apache.org/r/28291/#comment104546 Nit: does this still work even if there's no markup in the body? If someone _wanted_ plain text? - Nate Cole On Nov. 20, 2014, 2:16 p.m., Jonathan Hurley wrote

Re: Review Request 28311: Upgrade Execute: implement proper RESTART commands

2014-11-21 Thread Nate Cole
. - Nate Cole On Nov. 20, 2014, 9:43 p.m., Nate Cole wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28311/ --- (Updated Nov. 20

Re: Review Request 28311: Upgrade Execute: implement proper RESTART commands

2014-11-21 Thread Nate Cole
://reviews.apache.org/r/28311/#review62541 --- On Nov. 20, 2014, 9:43 p.m., Nate Cole wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28311

Re: Review Request 28311: Upgrade Execute: implement proper RESTART commands

2014-11-21 Thread Nate Cole
it? Nate Cole wrote: Let's discuss. Not sure why distribute/install requires a restart. Firing a single custom action that is not a restart is pretty straightforward. Dmitro Lisnichenko wrote: Since different hosts with different service components installed have different package

Re: Review Request 28336: Provide stage resource information via REST API

2014-11-21 Thread Nate Cole
/ambari/server/api/resources/StageResourceDefinition.java https://reviews.apache.org/r/28336/#comment104736 Should be stage? - Nate Cole On Nov. 21, 2014, 12:26 p.m., Tom Beerbower wrote: --- This is an automatically generated e-mail

Re: [VOTE] Ambari 1.7.0 release

2014-11-21 Thread Nate Cole
+1 for 1.7.0 On Nov 19, 2014 5:36 PM, Alejandro Fernandez alejan...@apache.org wrote: Hi all, The time has come to vote on releasing Ambari 1.7.0. In the past couple of weeks, the Ambari 1.7.0 release branch has received a lot of bug fixes and finally reached 0 open Jiras; you should all be

Re: Review Request 28336: Provide stage resource information via REST API

2014-11-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28336/#review62730 --- Ship it! Ship It! - Nate Cole On Nov. 22, 2014, 8:48 a.m., Tom

Review Request 28370: Upgrade Execute: create database mappings for Upgrades to Requests

2014-11-22 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 28336: Provide stage resource information via REST API

2014-11-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28336/#review62736 --- Ship it! Ship It! - Nate Cole On Nov. 22, 2014, 9:18 a.m., Tom

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Nate Cole
/HostInfo_linux.py https://reviews.apache.org/r/28394/#comment105009 Probably also modify HostInfo_win.py - Nate Cole On Nov. 24, 2014, 1:33 p.m., Jonathan Hurley wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 28405: Distribute Repositories/Install Components - server part

2014-11-25 Thread Nate Cole
across all hosts? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java https://reviews.apache.org/r/28405/#comment105169 No sysout here. - Nate Cole On Nov. 24, 2014, 3:50 p.m., Dmitro Lisnichenko wrote

Re: Review Request 28453: Alerts: Remove Deprecated NagiosPropertyProvider Stub

2014-11-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28453/#review63052 --- Ship it! Ship It! - Nate Cole On Nov. 25, 2014, 4:53 p.m

  1   2   3   4   5   6   7   8   9   10   >