Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1138
@arina-ielchiieva, @paul-rogers, I have reworked this pull request to use
`AvroDrillTable`, as it was before my changes. Also, with `AvroDrillTable`
there is no need to make changes in `AvroRecord
Github user lherrmann974 commented on the issue:
https://github.com/apache/drill/pull/258
Hello,
any news on this PR ? The upgraded GIS abilities would be greatly
appreciated.
Thanks in advance.
---
Can we also discuss the remaining items for the 1.13 release? If something is
not ready yet, we should change the fix version to the next release.
-Original Message-
From: Sorabh Hamirwasia
Sent: March 5, 2018 5:28 PM
To: dev@drill.apache.org
Subject: Re: Drill Hangout tomorrow at 10 am
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
I also would really like to see this through to completion. If there is
something I can do, please let me know.
> On Mar 6, 2018, at 08:04, lherrmann974 wrote:
>
> Hello,
> any n
Github user brendanstennett commented on the issue:
https://github.com/apache/drill/pull/258
+1 And would be happy to help get it across the finish line for you.
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1151
DRILL-6151: Fragment executors may terminate without sending final batch to
a downstream causing query to hang
You can merge this pull request into a Git repository by running:
$ git pull http
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/1152
DRILL-6199: Add support for filter push down and partition pruning wiâ¦
â¦th several nested star sub-queries
Re-written original solution to apply rule on later stages when we wor
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1152
@chunhui-shi please review.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1151
The reason of the change is that some other errors can be thrown. For
example, `StackOverflowError`.
+1, LGTM.
---
Right now i haven't found the reason of
TestDrillbitResilience.cancelAfterAllResultsProduced failure, most likely
the cause of the failure is that the query is able to have been completed
before cancellation request is processed.
This test not only the case, there is one more ignored test
TestDrill
Hangout starts now. Please join.
On Tue, Mar 6, 2018 at 4:04 PM, Pritesh Maker wrote:
> Can we also discuss the remaining items for the 1.13 release? If something
> is not ready yet, we should change the fix version to the next release.
>
> -Original Message-
> From: Sorabh Hamirwasia
>
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1138#discussion_r172606895
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/ExtendableRelDataTypeHolder.java
---
@@ -0,0 +1,82 @@
+/*
+ * Li
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1138#discussion_r172599233
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java ---
@@ -78,6 +79,23 @@ public ColumnExplorer(OptionManager op
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1138#discussion_r172600066
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroDrillTable.java
---
@@ -58,16 +65,31 @@ public AvroDrillTable(String st
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1138#discussion_r172606583
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -277,6 +279,25 @@ public String deriveAlias(
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1105
Looks good, @vrozov are you ok with the changes?
---
Arina Ielchiieva created DRILL-6213:
---
Summary: During restart drillbit be should be killed forcefully if
exceeds allowed timeout
Key: DRILL-6213
URL: https://issues.apache.org/jira/browse/DRILL-6213
Github user priteshm commented on a diff in the pull request:
https://github.com/apache/drill/pull/1135#discussion_r172619940
--- Diff: distribution/src/resources/drillbit.sh ---
@@ -45,7 +45,7 @@
# configuration file. The option takes precedence over the
# DRILL_CONF_DIR
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1135#discussion_r172621216
--- Diff: distribution/src/resources/drillbit.sh ---
@@ -45,7 +45,7 @@
# configuration file. The option takes precedence over the
# DRILL_C
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1138#discussion_r172618262
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java ---
@@ -78,6 +79,23 @@ public ColumnExplorer(OptionManager optionMa
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1138#discussion_r172620291
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroDrillTable.java
---
@@ -58,16 +65,31 @@ public AvroDrillTable(String storageE
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1138#discussion_r172618093
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/ExtendableRelDataTypeHolder.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1138#discussion_r172630422
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -277,6 +279,25 @@ public String deriveAlias(
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1105
@ilooner @arina-ielchiieva How `innerNext()` and `close()` can execute
concurrently? Does not `FragmentExecutor.hasCloseoutThread` ensure that either
`close()` is called on the `run()` thread or `run(
The code base is huge so many contributions that I doubt anyone knows all
aspects of Drill. So don't be overwhelmed by the amount of code. :)
Starting with the Architecture: http://drill.apache.org/docs/architecture/
There are plenty of resources here, and even online youtube/slideshare content
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1105
@vrozov Thanks for catching this, I believe you are right.
hasClouseoutThread guarantees innerNext and close won't be called concurrently.
However, I still believe innerNext and receivingFragmentFini
Khurram Faraaz created DRILL-6214:
-
Summary: DrillRuntimeException: Unexpected byte 0xfe at position 0
encountered while decoding UTF8 string.
Key: DRILL-6214
URL: https://issues.apache.org/jira/browse/DRILL-6214
Github user gparai commented on the pull request:
https://github.com/apache/drill/commit/9073aed67d89e8b2188870d6c812706085c9c41b#commitcomment-27961774
In logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java:
In logical/src/main/java/org/apache/drill/common/exp
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1138
@vvysotskyi, thanks for addressing the schema issues!
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1104
I noticed this change when merging with the latest master. What does
`DYNAMIC_STAR` mean? The original `WILDCARD` name was more theoretical. How is
`DYNAMIC_STAR` different from `STAR` (other tha
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
Hi Brendan, I can review it if you can complete it.
âC
> On Mar 6, 2018, at 10:57, Brendan Stennett
wrote:
>
> +1 And would be happy to help get it across the finish line
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1125
@paul-rogers Thank you Paul. I will be incorporating some of your
suggestions in future PRs. This change will allow us to build more things on
top.
---
Khurram Faraaz created DRILL-6215:
-
Summary: Use prepared statement instead of Statement in
JdbcRecordReader class
Key: DRILL-6215
URL: https://issues.apache.org/jira/browse/DRILL-6215
Project: Apache
Kunal Khatua created DRILL-6216:
---
Summary: Metadata mismatch when connecting to a Drill 1.12.0 with
a Drill-1.13.0-SNAPSHOT driver
Key: DRILL-6216
URL: https://issues.apache.org/jira/browse/DRILL-6216
P
Hi Parth
DRILL-6216 is a release blocker that is being currently looked into.
Ref:
DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a
Drill-1.13.0-SNAPSHOT driver
https://issues.apache.org/jira/browse/DRILL-6216
Please add it to the list of required commits as well.
Than
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1150
@Ben-Zvi Boaz, can you do a committer review for this PR and include it in
this week's batch commit ?
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172678483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java
---
@@ -103,6 +96,23 @@ protected void handle(ControlConnection c
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172718426
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -69,6 +74,11 @@
private final IdlePingHandler pingHandler;
pr
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172642452
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -371,17 +376,20 @@ protected void afterExecute(final Runnable r, f
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172667685
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -312,6 +312,11 @@ public synchronized void connect(String connect,
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172678133
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -182,6 +196,66 @@ public boolean isActive() {
protected abstra
GitHub user dvjyothsna opened a pull request:
https://github.com/apache/drill/pull/1153
DRILL-6044: Fixed shutdown button in Web UI when ssl,auth are enabled
Fixed shutdown button to avoid cross domain requests since they are causing
some issues when ssl and auth are enabled
You ca
We have two items remaining -
DRILL-1491 - Ideally, I would like to make sure that CANCEL is handled
correctly with JDK 8. If the failure of the unit test is because the cancel
is received after the query is completed, then the issue is less severe,
but I would like to be sure that this is the cas
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1150#discussion_r172735136
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/schema/SchemaBuilder.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache S
Hi All,
The root cause for DRILL-6216 is due to a recent change made as part of
https://issues.apache.org/jira/browse/DRILL-6049. With this PR a default field
name for values ValueVector inside any NullableValueVector was introduced which
is $values$ [1]. Before this PR the values ValueVector f
Just sent an email on RCA of DRILL-6216 to discuss next steps.
Thanks,
Sorabh
From: Parth Chandra
Sent: Tuesday, March 6, 2018 6:48:21 PM
To: dev
Subject: Re: [DISCUSS] 1.13.0 release
We have two items remaining -
DRILL-1491 - Ideally, I would like to make sur
Thanks Sorabh, for the analysis and the pointers to the relevant code.
Doing the version check check for client and server would be the right
thing to do but probably too disruptive at this stage of the release. We
should do it for the next release.
For 1.13, could the change of the $values$ be re
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1144
AFAIK, IndexOutOfBoundsException is thrown by Netty when a write to a
DrillBuf goes out of bounds (see
https://github.com/netty/netty/blob/netty-4.0.48.Final/buffer/src/main/java/io/netty/buffer
+1 on reverting this if it doesn't break things.
On Wed, Mar 7, 2018 at 11:11 AM, Aman Sinha wrote:
> Thanks Sorabh, for the analysis and the pointers to the relevant code.
> Doing the version check check for client and server would be the right
> thing to do but probably too disruptive at this
Hi Sorabh,
Thanks for tracking this one down. Our unit tests did not uncover this issue
when I did the original PR, unfortunately. The name change was done to be
consistent with other places where we use special names and, as I recall, help
with certain tasks.
Clearly, however, if the client dep
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1150
Fixed the typo.
@Ben-Zvi, thanks for pointing out the unit tests: I do have test file in my
branch; forgot to include it with the PR. Just did.
---
51 matches
Mail list logo
