Re: [FlexJS] technical debt

Hi, > Harbs: Feel free to do what you want to SonarQube now, but don’t make any changes based on the reports. I think you would agree that it doesn’t matter what tool you use to find issues and a blanket statement like that is like saying you must use a particular IDE to edit your co

Re: [FlexJS] technical debt

Justin - You seem to pick the part of the conversation that you are interested in and edit out the rest of the context. It makes it difficult to have a conversation about the best way to move forward in this project. Harbs: >>> Feel free to do what you want to SonarQube now, but don’t make any

Re: [FlexJS] technical debt

Hi, > The exercise with the Wiki was essentially for you to present a proposed set > of Sonar rules. You did this, thank you. > > It was not intended by me as [LAZY CONSENSUS]. Clearly there is healthy > disagreement and consensus is not yet achieved. Nor is it intended to be. I created a new

Re: [FlexJS] technical debt

Hi, > Also, in FlexJS, we want very few if any custom events to bubble. > Bubbling was overused in regular Flex and was, IMO, a bad practice because > it breaks encapsulation. Events provide encapsulation by allowing application to respond to changes outside of the object. IMO it’s also a good p

Re: [FlexJS] technical debt

Hi Justin, The exercise with the Wiki was essentially for you to present a proposed set of Sonar rules. You did this, thank you. It was not intended by me as [LAZY CONSENSUS]. Clearly there is healthy disagreement and consensus is not yet achieved. > On Jul 17, 2017, at 11:22 PM, Justin Mclean

Re: [FlexJS] technical debt

Additionally, the cloning results in extra objects that need to be garbage collected, which can hurt performance and make effects/animations look bad. Good call on avoiding it! - Josh On Tue, Jul 18, 2017 at 8:23 AM, Alex Harui wrote: > +1 to what Harbs said. > > Also, in FlexJS, we want very f

Re: [FlexJS] technical debt

+1 to what Harbs said. Also, in FlexJS, we want very few if any custom events to bubble. Bubbling was overused in regular Flex and was, IMO, a bad practice because it breaks encapsulation. Bubbling was intended to allow an object in the DOM to monitor inputs to its children without having to atta

Re: [FlexJS] technical debt

Sure. But for which events? You seem to have missed my point. > On Jul 18, 2017, at 10:35 AM, Justin Mclean wrote: > >> How often is clone really used? > > I’ve used it in just about every single application I've ever written in Flex > and I assume most applications will need it.

Re: [FlexJS] technical debt

Hi, > I’m actually not convinced that we should enforce use of cloneEvent on all > events. Again in the wiki doc I did put that it may not be required in every case. If you have bubbles as a parameter it would be reasonable to assume that a cloneEvent method is needed, where bubble isn’t a par

Re: [FlexJS] technical debt

Hi, > How are you going to get rid of that rule if we are using different name of > method in FlexJS ? Rule can be changed itself ? Rule can be changed and you can create your own rules. Given this isn't going to come up often (new events are not added that frequently) and it easy to see compli

Re: [FlexJS] technical debt

" > > that those events are missing their own cloneEvent ? > > Thanks, > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context: > http://apache-flex-development.247.n4.nabble.com/FlexJS-technical-

Re: [FlexJS] technical debt

47.n4.nabble.com/FlexJS-technical-debt-tp62851p63385.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] technical debt

Hi, > "It looks to me that FielEventError, FileEvent, ContextMenuEvent and Focus > event are missing close methods and probably require them" > > that those events are missing their own cloneEvent ? Yes see [1] Thanks, Justin 1. https://builds.apache.org/analysis/component_issues?id=org.apa

Re: [FlexJS] technical debt

Hi, > I think it was reasonable to switch off rule [1]. That's something which we > shouldn't be forced to do by the sonar. Sonar is not forcing anyone to do anything. You’ll note at the top of the document I put: Rule violations: • that are critical or blocker generally indicate bugs a

Re: [FlexJS] technical debt

@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-technical-debt-tp62851p63382.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] technical debt

Hi, > event.clone() is wrong for FlexJS. It’s event.cloneEvent() Which if you actually looked none of those 8 examples include a cloneEvent method either. It looks to me that FielEventError, FileEvent, ContextMenuEvent and Focus event are missing close methods and probably require them. TodoLi

Re: [FlexJS] technical debt

ext: http://apache-flex-development.247.n4.nabble.com/FlexJS-technical-debt-tp62851p63376.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] technical debt

event.clone() is wrong for FlexJS. It’s event.cloneEvent() There was other feedback on the dev list. That seemed to have been ignored. A lot of the rules fly in the face to current convention in the SDK. Some (such as returning from a constructor) are actually enforced by the compiler so the ru

Re: [FlexJS] technical debt

Hi, So more than a week has gone by and I’ve received little feedback on [1]. Given that I’ll gone ahead and implement the rules as discussed in the document so people can see the changes. The new results are up: - First off the header rules is overly strict and expects a copyright line not ju

Re: [FlexJS] technical debt

How can you use filtering to change what the dashboard shows? > On Jul 10, 2017, at 2:02 PM, Justin Mclean wrote: > > Hi, > >> I was trying to set up an alternate set because it’s easier to have two sets >> to compare rather than having long drawn-out discussion. > > As opposed to using the f

Re: [FlexJS] technical debt

Hi, > I was trying to set up an alternate set because it’s easier to have two sets > to compare rather than having long drawn-out discussion. As opposed to using the filtering that exists in the web interface? That seems an easier way to do to comparisons but I guess sit depends on your exact a

Re: [FlexJS] technical debt

That’s a good idea, and I will probably do so next time I’m inclined to spend time on this. > On Jul 10, 2017, at 10:43 AM, Justin Mclean wrote: > > If you are trying things out rather than experimenting on the live server you > can run Sonar Cube locally.

Re: [FlexJS] technical debt

I was trying to set up an alternate set because it’s easier to have two sets to compare rather than having long drawn-out discussion. I don’t think there’s any harm in having two sets to compare. I tried playing with my set using inheritance, but I just messed it up. I really don’t have the tim

Re: [FlexJS] technical debt

Hi, > I have permissions to edit profiles, but I don’t seem to have permissions to > assign profiles. You do have permissions you’re just doing it in the wrong place. Also I won’t recommend hard coding a set of rules as you have done. It’s better to define the rule set as a delta of the defaul

Re: [FlexJS] technical debt

; > Can you take a look whether you can edit it ? It seems that I don't have > some permission to change that profile. > > Thanks, > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context: > htt

Re: [FlexJS] technical debt

Hi, > Can you take a look whether you can edit it ? It seems that I don't have > some permission to change that profile. Harbs has the same permissions as me so yes he can edit it. If you want permission to edit it you need to ask Infra. If you do get access please take care as it is possible t

Re: [FlexJS] technical debt

e.com/FlexJS-technical-debt-tp62851p63016.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] technical debt

Hi, I reset the default rules back to the way they were and created a "FlexJS Framework” quality profile we can make the changes there. Thanks, Justin

Re: [FlexJS] technical debt

While I personally use === and !==, the vast, VAST majority of ActionScript developers do not. I think it makes sense to turn that off for the default profile. It's not considered best practice in the ActionScript community. Probably because we encounter undefined significantly less than JS develop

Re: [FlexJS] technical debt

Justin, Let us know when you make the changes. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-technical-debt-tp62851p62980.html Sent from the Apache Flex Development mailing list

Re: [FlexJS] technical debt

Actually I did not miss that. The Flex code is an external project: https://code.google.com/archive/p/jsf-flex/ I’ll be happy to communicate. Thanks, Harbs > On Jul 9, 2017, at 1:39 PM, Justin Mclean wrote: > > Hi, > >> Of the remaining 16 proje

Re: [FlexJS] technical debt

Hi, > Of the remaining 16 projects, it’s very easy to see that none of them are > using the Flex language. The first link relies on projects meta data and may not be accurate. None of the links you provide show what profile(s) the projects use. You missed that MyFaces uses Sonar Type and it

Re: [FlexJS] technical debt

> On Jul 9, 2017, at 11:53 AM, Justin Mclean wrote: > >> O really! - There are other projects which using AS3 in Apache? Could you >> send a links? > > Off top of my head MyFaces, Thrift and a couple of others. Maxim works on one > of them but I think they may of moved to a JS front end. None

Re: [FlexJS] technical debt

Hi, > O really! - There are other projects which using AS3 in Apache? Could you > send a links? Off top of my head MyFaces, Thrift and a couple of others. Maxim works on one of them but I think they may of moved to a JS front end. None that I know use AS as the main language but given the 300+

Re: [FlexJS] technical debt

or do you want me to try it? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-technical-debt-tp62851p62975.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] technical debt

Hi, > I made two changes on Friday. Can I ask why you didn’t email the list saying you had done this and what the purpose of disabling those rules were? Or disabling rules when I suggested that you should make a custom profile instead? > It’s important to note that these changes were only to t

Re: [FlexJS] technical debt

ssage in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-technical-debt-tp62851p62973.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] technical debt

I’m just catching up on email. I made two changes on Friday. I deactivated the following two rules for the Flex language. (Please note that I only deactivated them. I did not delete them.) I wanted to see how much that would effect the score: "===" and "!==" should be used instead of "==" and "!

Re: [FlexJS] technical debt

Hi, > Before you accuse anyone (even if you expressed doubt) do you have a way to > determine who made the change to the Sonar Cube configuration? I can’t see anything in the interface no, but the changes are logged and infra will be able to tell. If it wasn’t him I’ll appoligise. Thanks, Just

Re: [FlexJS] technical debt

OK got it. Before you accuse anyone (even if you expressed doubt) do you have a way to determine who made the change to the Sonar Cube configuration? Does Infrastructure? Did anyone on the Flex project make any changes? Regards, Dave > On Jul 7, 2017, at 8:18 PM, Justin Mclean wrote: > > Hi

Re: [FlexJS] technical debt

Hi, > My discussion was around procedures related to technical debt. And you would agree the Sonar Cube configuration relates to that? > Keep in mind that this is all my opinion as part of the PMC. If others don't > agree then there is not yet consensus. Which is why as suggested I’m trying to

Re: [FlexJS] technical debt

Hi Justin, My discussion was around procedures related to technical debt. Keep in mind that this is all my opinion as part of the PMC. If others don't agree then there is not yet consensus. I'm not sure about the profile. Please take a look at the commits and you should question and discuss th

Re: [FlexJS] technical debt

Hi, I’ve created a draft page here [1] and will do some more work on it over the weekend. Thanks, Justin 1. https://cwiki.apache.org/confluence/display/FLEX/Sonar+Cube+Flex+Rules

Re: [FlexJS] technical debt

Hi, Harbs I see you have gone ahead (or rather I assume it was you so apologies if it wasn't) and modified the default Flex profile. As discussed in this thread that was not the right way to do this and there needs to some documentation and discussion around this before we make changes. As Dave

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

The TraceListener in the example code listens for events from the TestRunner and prints to the console. Those same events could be used to collect failures and do anything you want with them. - Josh On Fri, Jul 7, 2017 at 8:59 AM, Alex Harui wrote: > Hi Josh, > > That could be good. I took a q

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

And you have a Core.swc in /Users/harbs/Documents/ApacheFlex/flex-asjs/frameworks/libs? What is in: /Users/harbs/Documents/ApacheFlex/flex-asjs/frameworks/flex-config.xml -Alex On 7/7/17, 9:14 AM, "Harbs" wrote: >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

https://paste.apache.org/Gcuj > On Jul 7, 2017, at 6:55 PM, Alex Harui wrote: > > What error did you get? > > The Ant build on the CI server runs checkintests and it is passing there. > > The FlexJS Mustella uses Selenium for the JS run, but some manual > interv

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

Hi Josh, That could be good. I took a quick look and didn't understand how it reports errors that can be collected and reported. How does that work? Would it interface with Selenium? Thanks, -Alex On 7/7/17, 8:23 AM, "Josh Tynjala" wrote: >I wrote a simple test runner similar to FlexUnit for

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

What error did you get? The Ant build on the CI server runs checkintests and it is passing there. The FlexJS Mustella uses Selenium for the JS run, but some manual intervention is currently required. -Alex On 7/7/17, 3:16 AM, "Harbs" wrote: >The checkintests target currently fails. I’m guessi

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

I wrote a simple test runner similar to FlexUnit for some of my projects. I'm happy to donate this code to FlexJS or FlexUnit if it can help bootstrap the testing efforts. https://github.com/BowlerHatLLC/nextgenas-test It supports [Test], [Before], and [After] metadata: https://github.com/Bowler

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

The checkintests target currently fails. I’m guessing the build file was not updated for dual. Selenium has a JS API[1]. It seems like we should be able to write tests in MXML and AS and then use Node.js to run the results. I’m not sure how easy it would be to generalize tests so that the same

Re: [FlexJS] technical debt

Hi, > I don’t see any options like that (logged in using my Apache account). Does > someone need to add permissions? If you can’t see them then yes you would need to ask infra. Justin

Re: [FlexJS] technical debt

I don’t see any options like that (logged in using my Apache account). Does someone need to add permissions? > On Jul 7, 2017, at 10:49 AM, Justin Mclean wrote: > > Hi, > >>> and how do we change them? > > In the sonar cube web interface (same url as before) under rules/quality > profile. It

Re: [FlexJS] technical debt

Hi, >> and how do we change them? In the sonar cube web interface (same url as before) under rules/quality profile. It's best to set up a new quality profile rather than edit the existing one as that may effect other projects. I’ll put together a wiki page on making the rules more in the style

Re: [FlexJS] technical debt

Considering you did not answer the most significant part of my question. I’m asking it again. > On Jul 6, 2017, at 9:13 PM, Harbs wrote: > > and how do we change them?

Re: [FlexJS] technical debt

IMO, it applies to anyone making changes to code paths that are probably working. As we've already seen, there is a cost to making a mistake in what seems like a simple change that totally outweighs the value to the technology. Folks creating new features or fixing major bugs are really "moving t

Re: [FlexJS] technical debt

Hi, > Think of it like this if someone makes a commit you would not revert without > giving them an opportunity to do it first. > > So the suggestion from me is get approval for anything complex. It is the > social thing to do. !00% agree. > I see you asked directly about a standard else thre

Re: [FlexJS] technical debt

Sent from my iPhone > On Jul 6, 2017, at 5:22 PM, Justin Mclean wrote: > > Hi, > >> If you make a change to fix technical debt then you should also assure that >> both existing tests pass and if no tests exist then tests are added and >> proper. > > I’m all for more tests. However should t

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

Hi, What do people feel about setting a code and branch coverage on all checkins? Say 80% coverage of changes made? Thanks, Justin

Re: [FlexJS] technical debt

>> Well Object is always THE base class. It may not be known what the actual base class should be and it is certainly not flexible to always create a base class just to have a one to satisfy the rule. >Nor would I suggest that. There are some cases where creating a new class with properties is goi

Re: [FlexJS] technical debt

Hi, > If you make a change to fix technical debt then you should also assure that > both existing tests pass and if no tests exist then tests are added and > proper. I’m all for more tests. However should this apply to any changes anyone makes for any reason OR only changes I make? I asking b

Re: [FlexJS] technical debt

Hi, > That is the concern, but it may be that the developer was making a > speculative change. If I were cleaning then I would do one of two actions. > > (a) Review the history of that change and see if the associated comments > provide a reason. > (b) Ask the developer who made the change. Bo

Re: [FlexJS] technical debt

> On Jul 6, 2017, at 4:22 PM, Justin Mclean wrote: > > Hi, > >> - Do we care about code being commented out? I think not. > > If we know why it was commented out sure. There’s always the concern is this > code possibly needed or not? That is the concern, but it may be that the developer was

Re: [FlexJS] technical debt

> On Jul 6, 2017, at 4:30 PM, Justin Mclean wrote: > > Hi, > >>> IMO, even more important than technical debt is a test system and tests to >>> make sure any changes don't break anything. >> >> That would include any changes to fix “technical debt”. > > Or if fact any changes right? If you

Re: [FlexJS] technical debt

Hi, >> IMO, even more important than technical debt is a test system and tests to >> make sure any changes don't break anything. > > That would include any changes to fix “technical debt”. Or if fact any changes right? Thanks, Justin

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

Hi, BTW Sonar can give you useful test coverage statistics [1] and will even show line by line where a test is covered by tests [2] look at the red and green bars in the gutter. Thanks, Justin 1. https://builds.apache.org/analysis/component_measures/domain/Coverage?id=org.apache.flex.flexjs.c

Re: [FlexJS] technical debt

Hi, > - Do we care about code being commented out? I think not. If we know why it was commented out sure. There’s always the concern is this code possibly needed or not? > - Does a semicolon matter? It marked as a minor issue but it can cause issues when JS code is optimised and/or minified.

Re: [FlexJS] technical debt

Hi, > A large percentage of the complaints are inaccurate. The reason the technical > debt increased is largely because of the new TLF code. > > Who made these rules and how do we change them? We can make it look much > better by just changing some of the rules… The rules come from various pla

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

I have a subset of Mustella working on both platforms in the BasicTests that run from the checkintests target in the Ant build. There is a writeup on Mustella in the wiki https://cwiki.apache.org/confluence/display/FLEX/Mustella+Overview. I haven't gone through it to see how much does or doesn't

FlexJS Tests (was Re: [FlexJS] technical debt)

Where are the instructions on how to use it? If I know how to write tests, I’d be much better about doing so… > On Jul 6, 2017, at 11:53 PM, Alex Harui wrote: > > I have put in place a test infrastructure

Re: [FlexJS] technical debt

Yup. For example: I’d say an extremely large percentage of the “technical debt” in TLF is there for a reason. Do NOT “fix” any of that… > On Jul 6, 2017, at 11:53 PM, Alex Harui wrote: > > But IMO, for right now, if "it ain't broke, don't fix it".

Re: [FlexJS] technical debt

>> >> My 2 cents, >> -Alex >> >> From: Dave Fisher mailto:dave2w...@comcast.net>> >> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" >>mailto:dev@flex.apache.org>> >> Date: Thursday, July 6, 2017 at 9:24 AM &g

Re: [FlexJS] technical debt

st.net>> > Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" > mailto:dev@flex.apache.org>> > Date: Thursday, July 6, 2017 at 9:24 AM > To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" > mailto:dev@flex.apache.org>> &g

Re: [FlexJS] technical debt

A large percentage of the complaints are inaccurate. The reason the technical debt increased is largely because of the new TLF code. Who made these rules and how do we change them? We can make it look much better by just changing some of the rules… Harbs > On Jul 6, 2017, at 2:24 AM, Justin Mc

Re: [FlexJS] technical debt

isher mailto:dave2w...@comcast.net>> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" mailto:dev@flex.apache.org>> Date: Thursday, July 6, 2017 at 9:24 AM To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" mailto:dev@flex.apache.org>> Subj

Re: [FlexJS] technical debt

Hi Justin, (I missed your double reply until I reviewed the thread before sending. This caused me to remove part of this email.) I looked at some of the major and minor Code Smells. I think that rather than accepting the ActionScript conventions that Sonar provides that most of these can be el

Re: [FlexJS] technical debt

Hi, Dave I assume the case statement issue you referring to is is the last one in this list [1]. It not a bug but style wise it’s a little odd and probably should still be fixed. Thanks, Justin 1. https://builds.apache.org/analysis/component_issues/index?id=org.apache.flex.flexjs.framework%3A

Re: [FlexJS] technical debt

Hi, > You cut my previous reply which means I need to repeat. Why is that? All modern email clients support threaded messages. so people should be able to see my email and your original in context. When replying repeating the whole email is generally frowned upon. Sorry if I cut too much out

Re: [FlexJS] technical debt

Hi Justin, You cut my previous reply which means I need to repeat. You called out changes since 0.8. And I only looked at the change since in Sonar. I took about 5 minutes, a very superficial check. Lots of TD should be explored carefully hopefully by the original developer. I agree with the n

Re: [FlexJS] technical debt

Hi, > In the differential all 30 of the bugs are of the form: > > Make this class “Event" override "Event.clone()” function Which some are false positives as there’s a cloneEvent method. Note you can mark them as such in the interface. I had already fixed a couple of these a few weeks back. >

Re: [FlexJS] technical debt

Hi - In the differential all 30 of the bugs are of the form: Make this class “Event" override "Event.clone()” function All of the 133 vulnerabilities are of these forms: Make this "public static" field const Remove this use of the "trace" function. The singular code smell (Sonar says that flex

[FlexJS] technical debt

Hi, If you take a look at this [1] you see that technical debt increased a bit between the 0.8 and 0.9 releases. It would be good if we could reduce this. While Sonar cube isn’t perfect, probably needs some tuning, and there are a number of false positives in there it is trying to tell us somet