Re: Review Request 66288: HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks (2.x line)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66288/#review200043 --- Ship it! Ship It! - Peter Vary On March 26, 2018, 10:14 p.m

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

23 (patched) <https://reviews.apache.org/r/66290/#comment280630> nit: Do not use * based imports - Peter Vary On March 26, 2018, 9:35 p.m., Bharathkrishna Guruvayoor Murali wrote: > > --- > This is an automatically genera

Re: PTest stuck

s that it should not, while >> TestMiniLlapLocalCliDriver does not seem to be running at all. >> >> -Jesús >> >> >> On 3/22/18, 8:06 AM, "Peter Vary" <pv...@cloudera.com> wrote: >> >>The disks was full. >>Removed l

Re: Integration testing for clients

ething we should do. > > Alan. > > On Thu, Mar 22, 2018 at 3:49 AM, Peter Vary <pv...@cloudera.com> wrote: > >> Hi Matt, >> >> The MiniHMS is an internal test utility used to test HMS features. >> It is contained in the hive-standalone-metastore-3.0.0-SNAPS

Re: PTest stuck

The disks was full. Removed log files, and test runs. Restarted ptest Please reschedule your tests please. Thanks, Peter > On Mar 22, 2018, at 9:29 AM, Prasanth Jayachandran > wrote: > > The tests aren’t running anymore. > > Thanks > Prasanth > >> On Mar 21,

Re: Review Request 66188: HIVE-18986 Table rename will run java.lang.StackOverflowError in dataNucleus if the table contains large number of columns

tching(dbType) What do you think @Aihua? standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java Lines 842 (patched) <https://reviews.apache.org/r/66188/#comment280196> nit: typo: "queris" - Peter Vary On March 21, 2018, 6:5

Re: Integration testing for clients

Hi Matt, The MiniHMS is an internal test utility used to test HMS features. It is contained in the hive-standalone-metastore-3.0.0-SNAPSHOT-tests.jar I do not think there are currently plans publish it in any of the artifacts. Thanks, Peter > On Mar 21, 2018, at 6:44 PM, Matt Burgess

Re: Review Request 65943: HIVE-18888: Replace synchronizedMap with ConcurrentHashMap

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65943/#review198869 --- Ship it! Ship It! - Peter Vary On March 8, 2018, 1:19 a.m

Re: Review Request 65943: HIVE-18888: Replace synchronizedMap with ConcurrentHashMap

/DynamicValueRegistryTez.java Lines 22-23 (original), 22-23 (patched) <https://reviews.apache.org/r/65943/#comment279064> Remove unused imports - Peter Vary On March 7, 2018, 6:08 a.m., Alexander Kolbasov wrote: > > --- > This is a

Re: HMS API testing and direct SQL

Hi Team, The MetaStore API tests are designed to be easily extensible by new MetaStore configurations. Just take a look at the following class: MetaStoreFactoryForTests. We can add a new configurations here like it is done with the RemoteMetaStore. What we have to decide is: which is the right

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review198704 --- Ship it! Ship It! - Peter Vary On Feb. 21, 2018, 11:37 a.m

Re: reverting test-breaking changes

18 at 8:25 AM, Thejas Nair <thejas.n...@gmail.com> >>> wrote: >>> >>>> +1 >>>> I agree, this makes sense. The number of failures keeps increasing. >>>> A 24 hour heads up in either case before revert would be good. >>>>

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesList.java 15bd6c6 Diff: https://reviews.apache.org/r/65753/diff/3/ Changes: https://reviews.apache.org/r/65753/diff/2-3/ Testing --- Run the affected tests Thanks, Peter Vary

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

/hive/metastore/client/TestTablesList.java 15bd6c6 Diff: https://reviews.apache.org/r/65753/diff/2/ Changes: https://reviews.apache.org/r/65753/diff/1-2/ Testing --- Run the affected tests Thanks, Peter Vary

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

To reply, visit: https://reviews.apache.org/r/65753/#review198121 --- On Feb. 22, 2018, 12:25 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To repl

Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

15bd6c6 Diff: https://reviews.apache.org/r/65753/diff/1/ Testing --- Run the affected tests Thanks, Peter Vary

Re: reverting test-breaking changes

I agree with Zoltan. The continuously braking tests make it very hard to spot real issues. Any thoughts on doing it automatically? > On Feb 22, 2018, at 10:47 AM, Zoltan Haindrich wrote: > > * > > Hello, > > * > * > > ** > > In the last couple weeks the number of broken tests

[jira] [Created] (HIVE-18771) Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

Peter Vary created HIVE-18771: - Summary: Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration Key: HIVE-18771 URL: https://issues.apache.org/jira/browse/HIVE-18771

Re: Review Request 65716: HIVE-18696: The partition folders might not get cleaned up properly in the HiveMetaStore.add_partitions_core method if an exception occurs

he/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java Lines 626 (patched) <https://reviews.apache.org/r/65716/#comment278139> Why is this change? Is this an incompatible change? - Peter Vary On Feb. 20, 2018,

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 3370 (patched) <https://reviews.apache.org/r/65731/#comment278142> How "expensive" is this call? Is this a simple query? What happens if the destintaion table has 1m partitions? :) - Peter Vary On Feb. 21,

Re: Review Request 65730: HIVE-18697: The HiveMetastore.exchange_partitions method throws FileNotFoundException if the given partition doesn't exist in the source table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65730/#review197847 --- Ship it! Ship It! - Peter Vary On Feb. 21, 2018, 10:36 a.m

[jira] [Created] (HIVE-18745) Fix MetaStore creation in tests, so multiple MetaStores can be started on the same machine

Peter Vary created HIVE-18745: - Summary: Fix MetaStore creation in tests, so multiple MetaStores can be started on the same machine Key: HIVE-18745 URL: https://issues.apache.org/jira/browse/HIVE-18745

[DISCUSS] deprecation policy

Hi Team, I am seeing several jiras proposing removing functions from Hive: HIVE-18691 Drop Support for Explicit Table Lock From Apache Hive HIVE-18692 Remove HPL/SQL From Apache Hive HIVE-18448 Drop Support For Indexes From Apache Hive I generally agree with removing unused functions. Especially

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/#review196982 --- Ship it! Ship It! - Peter Vary On Feb. 5, 2018, 6:01 p.m

Re: Review Request 65331: HIVE-17751 Separate HMS Client and HMS server into separate sub-modules

idea to have the MetaStoreUtils in metastore-common too? What do you think? - Peter Vary On Feb. 6, 2018, 6:35 p.m., Alexander Kolbasov wrote: > > --- > This is an automatica

[jira] [Created] (HIVE-18591) Fix flaky tests in MetaStore client tests

Peter Vary created HIVE-18591: - Summary: Fix flaky tests in MetaStore client tests Key: HIVE-18591 URL: https://issues.apache.org/jira/browse/HIVE-18591 Project: Hive Issue Type: Sub-task

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196516 --- Ship it! Ship It! - Peter Vary On Jan. 30, 2018, 8:15 a.m

Re: Long running time for recently added tests in standalone-metastore

+1 > On Jan 30, 2018, at 1:54 AM, Owen O'Malley wrote: > > +1 > > On Mon, Jan 29, 2018 at 4:38 PM, Alexander Kolbasov > wrote: > >> Quite reasonable. >> +1 >> >> On Mon, Jan 29, 2018 at 4:19 PM, Alan Gates wrote: >> >>>

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

it! standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java Lines 1312 (patched) <https://reviews.apache.org/r/65380/#comment276063> Agree with Adam, please move it to another test class. - Peter Vary On Jan. 29, 2018, 12:27 p.m., Marta Kuczora

Re: Review Request 65353: Create tests to cover getTableMeta method

field for others, and check the results too. - Peter Vary On Jan. 26, 2018, 6:12 p.m., Adam Szita wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196338 --- Ship it! Ship It! - Peter Vary On Jan. 26, 2018, 1:03 p.m

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

We don't have to do this for all the JIRAs in HIVE-18371, since most of > > them are already done. But would be good for future tests. > > Peter Vary wrote: > When we have a junit release with this commit: > > https://github.com/junit-team/junit4/commit/1bf8438b6

[jira] [Created] (HIVE-18555) Inconsistent exceptions between different IMetaStoreClient implementations

Peter Vary created HIVE-18555: - Summary: Inconsistent exceptions between different IMetaStoreClient implementations Key: HIVE-18555 URL: https://issues.apache.org/jira/browse/HIVE-18555 Project: Hive

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review196309 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 4:37 p.m

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review196257 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 3:41 p.m

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review196256 --- Ship it! Ship It! - Peter Vary On Jan. 25, 2018, 2:40 p.m

Re: Review Request 65284: Create tests to cover listPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review196255 --- Ship it! Ship It! - Peter Vary On Jan. 25, 2018, 1:47 p.m

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review196254 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 4:37 p.m

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

://reviews.apache.org/r/65264/diff/3-4/ Testing --- Run the created tests Thanks, Peter Vary

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

way, and it might be good to split up the > > different filter tests Good idea! Done - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review196144

Re: Review Request 65285: Create tests to cover getPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/#review196234 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 2:02 p.m

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196065 --- On Jan. 24, 2018, 10:52 a.m., Peter Vary wrote: > > ---

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

/65210/diff/3-4/ Testing --- Run the tests Thanks, Peter Vary

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

ated e-mail. To reply, visit: https://reviews.apache.org/r/65265/#review196012 --- On Jan. 23, 2018, 4:54 p.m., Peter Vary wrote: > > --- > This is a

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java ed071f8 Diff: https://reviews.apache.org/r/65265/diff/4/ Changes: https://reviews.apache.org/r/65265/diff/3-4/ Testing --- Run the tests Thanks, Peter Vary

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

eply, visit: https://reviews.apache.org/r/65210/#review196003 ------- On Jan. 23, 2018, 4:47 p.m., Peter Vary wrote: > > --- > This is an automatically g

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

/diff/2-3/ Testing --- Run the tests Thanks, Peter Vary

Re: Review Request 65285: Create tests to cover getPartition(s) methods

che.org/r/65285/#comment275539> Maybe test for no database? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java Lines 347 (patched) <https://reviews.apache.org/r/65285/#comment275540> Maybe test for case insensitivity? - Peter Vary On

Re: Review Request 65284: Create tests to cover listPartition(s) methods

istPartitions.java Lines 815 (patched) <https://reviews.apache.org/r/65284/#comment275510> What happens with filter like this: "YYyy=\"2017\""? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 1061 (patched) <

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

> > valid use case or an exception will occur? Good idea. Done - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/#review195980

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java ed071f8 Diff: https://reviews.apache.org/r/65265/diff/3/ Changes: https://reviews.apache.org/r/65265/diff/2-3/ Testing --- Run the tests Thanks, Peter Vary

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

eviews.apache.org/r/65264/#review195979 --- On Jan. 23, 2018, 11:18 a.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65264/ > ---

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java PRE-CREATION Diff: https://reviews.apache.org/r/65264/diff/3/ Changes: https://reviews.apache.org/r/65264/diff/2-3/ Testing --- Run the created tests Thanks, Peter Vary

[jira] [Created] (HIVE-18511) Fix generated checkstyle errors

Peter Vary created HIVE-18511: - Summary: Fix generated checkstyle errors Key: HIVE-18511 URL: https://issues.apache.org/jira/browse/HIVE-18511 Project: Hive Issue Type: Sub-task

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java PRE-CREATION Diff: https://reviews.apache.org/r/65264/diff/2/ Changes: https://reviews.apache.org/r/65264/diff/1-2/ Testing --- Run the created tests Thanks, Peter Vary

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java ed071f8 Diff: https://reviews.apache.org/r/65265/diff/2/ Changes: https://reviews.apache.org/r/65265/diff/1-2/ Testing --- Run the tests Thanks, Peter Vary

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

pache.org/r/65210/diff/1/?file=1941480#file1941480line605> > > > > Calling alterFunction with null newFunction migh be also a test case. Done. Thanks! - Peter --- This is an automatically generated e

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

: https://reviews.apache.org/r/65210/diff/1-2/ Testing --- Run the tests Thanks, Peter Vary

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java Lines 218 (patched) <https://reviews.apache.org/r/65241/#comment275260> Is this ok to have this characters in the index name? - Peter Vary On Jan. 19, 2018, 3:17 p.m., Marta Kuczora

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java Lines 172 (patched) <https://reviews.apache.org/r/65240/#comment275251> Is it possible to have a set of indexes in most of the cases, and use that? - Peter Vary On Jan. 19, 2018, 3:05 p.m., Marta K

Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

://reviews.apache.org/r/65265/diff/1/ Testing --- Run the tests Thanks, Peter Vary

[jira] [Created] (HIVE-18509) Create tests for table manipulation related methods (create, alter, drop)

Peter Vary created HIVE-18509: - Summary: Create tests for table manipulation related methods (create, alter, drop) Key: HIVE-18509 URL: https://issues.apache.org/jira/browse/HIVE-18509 Project: Hive

Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

PRE-CREATION Diff: https://reviews.apache.org/r/65264/diff/1/ Testing --- Run the created tests Thanks, Peter Vary

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

java Lines 1117 (patched) <https://reviews.apache.org/r/65219/#comment275135> I do not understand this check - Peter Vary On Jan. 18, 2018, 4:58 p.m., Marta Kuczora wrote: > > --- > This is an automatically gen

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java Lines 341 (patched) <https://reviews.apache.org/r/65213/#comment275134> Question: Does this behave the same way for external tables too? - Peter Vary On Jan. 18, 2018, 1:11 p.m., Marta Kuczora

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

17/#comment275132> nit: We might want to add TODO comments to places where we think we want to change standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 450 (patched) <https://reviews.apache.org/r/65217/#comment275133> Ques

Review Request 65210: HIVE-18480 Create tests for function related methods

- standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java PRE-CREATION Diff: https://reviews.apache.org/r/65210/diff/1/ Testing --- Run the tests Thanks, Peter Vary

Re: Rebasing standalone-metastore branch

Thanks Alan! Go on with the rebase. Peter > On Jan 17, 2018, at 12:40 AM, Vihang Karajgaonkar wrote: > > Thanks for the headsup Alan. I am okay with the rebasing > standalone-metastore branch. Will update my WIP patches accordingly. > > On Tue, Jan 16, 2018 at 2:01 PM,

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

he exception type is > > InvalidOperationException so that we catch errors like if someone changes > > the thrown exception in the future. > > Peter Vary wrote: > Shall I separate the test case into two? With/Without cascade? There is a > little extra stuff there creating

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

-CREATION Diff: https://reviews.apache.org/r/65018/diff/5/ Changes: https://reviews.apache.org/r/65018/diff/4-5/ Testing --- Run the new tests Thanks, Peter Vary

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

tabase with the cascade option. What do you think? - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review195158 -----

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

PRE-CREATION Diff: https://reviews.apache.org/r/65018/diff/4/ Changes: https://reviews.apache.org/r/65018/diff/3-4/ Testing --- Run the new tests Thanks, Peter Vary

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

still can split the test cases more. What do you think? - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review195114 -----

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

/RemoteMetaStoreForTests.java PRE-CREATION Diff: https://reviews.apache.org/r/65018/diff/3/ Changes: https://reviews.apache.org/r/65018/diff/2-3/ Testing --- Run the new tests Thanks, Peter Vary

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

/hive/metastore/client/TestDatabases.java > > Lines 353 (patched) > > <https://reviews.apache.org/r/65018/diff/1/?file=1935455#file1935455line353> > > > > This could also be separated into multiple test cases. Done - Peter ------

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

/65018/diff/2/ Changes: https://reviews.apache.org/r/65018/diff/1-2/ Testing --- Run the new tests Thanks, Peter Vary

Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

/hadoop/hive/metastore/minihms/MiniHMS.java PRE-CREATION standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/RemoteMetaStore.java PRE-CREATION Diff: https://reviews.apache.org/r/65018/diff/1/ Testing --- Run the new tests Thanks, Peter Vary

Re: [Announce] New committer: Deepak Jaiswal

Congratulation Deepak! > On Jan 5, 2018, at 11:18 PM, Ashutosh Chauhan wrote: > > The Project Management Committee (PMC) for Apache Hive has invited Deepak > Jaiswal to become a committer and we are pleased to announce that he has > accepted. > > Welcome, Deepak! > >

[jira] [Created] (HIVE-18372) Create testing infra to test different HMS instances

Peter Vary created HIVE-18372: - Summary: Create testing infra to test different HMS instances Key: HIVE-18372 URL: https://issues.apache.org/jira/browse/HIVE-18372 Project: Hive Issue Type: Sub

[jira] [Created] (HIVE-18371) Create more tests for standalone-metastore HiveMetaStoreClient API

Peter Vary created HIVE-18371: - Summary: Create more tests for standalone-metastore HiveMetaStoreClient API Key: HIVE-18371 URL: https://issues.apache.org/jira/browse/HIVE-18371 Project: Hive

[jira] [Created] (HIVE-18370) standalone-metastore gen dir contains two annotation/package-info.java which causes IDEA build fail

Peter Vary created HIVE-18370: - Summary: standalone-metastore gen dir contains two annotation/package-info.java which causes IDEA build fail Key: HIVE-18370 URL: https://issues.apache.org/jira/browse/HIVE-18370

[jira] [Created] (HIVE-18357) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

Peter Vary created HIVE-18357: - Summary: Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder Key: HIVE-18357 URL: https://issues.apache.org/jira/browse/HIVE-18357 Project

[jira] [Created] (HIVE-18356) Fixing license headers in checkstyle

Peter Vary created HIVE-18356: - Summary: Fixing license headers in checkstyle Key: HIVE-18356 URL: https://issues.apache.org/jira/browse/HIVE-18356 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass

Peter Vary created HIVE-18355: - Summary: Add builder for metastore Thrift classes missed in the first pass Key: HIVE-18355 URL: https://issues.apache.org/jira/browse/HIVE-18355 Project: Hive

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

oes not include 37 different ways to fetch partitions (I exaggerate only >>> slightly), but we need to find a way to do it that does not force users >> to >>> rewrite their application to upgrade to the standalone metastore. >>> >>> Alan. >>>

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

te only > slightly), but we need to find a way to do it that does not force users to > rewrite their application to upgrade to the standalone metastore. > > Alan. > > > On Fri, Dec 15, 2017 at 2:20 AM, Peter Vary <pv...@cloudera.com> wrote: > >> If the appl

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

ons are inheriting from TException the applications would > still work. But would it still work if we old metastore client library is > used with a newer version of metastore server running with these changes ? > > > On Wed, Dec 13, 2017 at 4:02 AM, Peter Vary <pv...@cloudera.com

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

il.com> wrote: >> >>> This direction looks good to me. >>> If the new exceptions are inheriting from TException the applications >>> would >>> still work. But would it still work if we old metastore client library is >>> used with a

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

Dec 13, 2017, at 1:02 PM, Peter Vary <pv...@cloudera.com> wrote: > > Hi Team, > > Since the work begin to separate the HMS to a standalone project we thought > that it would be useful the create extensive API tests for the public APIs of > the new project. > We

[DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

Hi Team, Since the work begin to separate the HMS to a standalone project we thought that it would be useful the create extensive API tests for the public APIs of the new project. We started to create tests using the IMetaStoreClient interface implementations and found that not surprisingly

Re: checkstyle changes

single method call is split into multiple > lines. > It insists on 4 chars in this case, though we use 2 in (all?) other cases. > > Could this be dialed down as well? > > > On 12/5/17, 7:26 AM, "Peter Vary" <pv...@cloudera.com> wrote: > >+1 for

Re: checkstyle changes

+1 for the changes > On Dec 5, 2017, at 1:02 PM, Zoltan Haindrich wrote: > > Hello, > > I've filed a ticket to make the checkstyle warnings less noisy > (https://issues.apache.org/jira/browse/HIVE-18222) > > * set maxlinelength to 140 >I think everyone is working with

Re: Review Request 63144: HIVE-16748: Integreate YETUS to Pre-Commit

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63144/#review190136 --- Ship it! Ship It! - Peter Vary On Oct. 26, 2017, 7:04 p.m

Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

> On Nov. 2, 2017, 10:40 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 265 (patched) > > <https://reviews.apache.org/r/63528/diff/1/?file=1879637#file1879637line265> > > > &

Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

me, -1); This way we will load only the required amount of partitions, instead of all. - Peter Vary On Nov. 2, 2017, 10:02 p.m., Adam Szita wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [Announce] New committer: Tao Li

Congratulations Tao! :) > On Nov 1, 2017, at 6:49 PM, Ashutosh Chauhan wrote: > > The Project Management Committee (PMC) for Apache Hive has invited Tao Li to > become a committer and we are pleased to announce that he has accepted. > > Welcome, Tao! > > Thanks, >

Re: Review Request 62810: HIVE-17300 WebUI query plan graphs

/ Testing --- Thanks, Peter Vary

Re: Review Request 63144: HIVE-16748: Integreate YETUS to Pre-Commit

to print out the stack trace too - Peter Vary On Oct. 19, 2017, 12:40 p.m., Adam Szita wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 62975: HIVE-17798: When replacing the src table names in BeeLine testing, the table names shouldn't be changed to lower case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62975/#review188023 --- Ship it! Ship It! - Peter Vary On Oct. 13, 2017, 2:21 p.m

[jira] [Created] (HIVE-17800) input_part6.q wants to test partition pruning, but tests expression evaluation

Peter Vary created HIVE-17800: - Summary: input_part6.q wants to test partition pruning, but tests expression evaluation Key: HIVE-17800 URL: https://issues.apache.org/jira/browse/HIVE-17800 Project: Hive

<    1   2   3   4   5   6   7   8   9   >