Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72528/#review221036 --- Ship it! +1 since the remaining issue will be fixed in

Re: Review Request 72553: HIVE-23555 Cancel compaction jobs when hive.compactor.worker.timeout is reached

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72553/ --- (Updated máj. 28, 2020, 8:58 de) Review request for hive, Karen Coppage and

Review Request 72553: HIVE-23555 Cancel compaction jobs when hive.compactor.worker.timeout is reached

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72553/ --- Review request for hive, Karen Coppage and Laszlo Pinter. Bugs: HIVE-23555

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/#review220839 --- Ship it! Ship It! - Peter Vary On máj. 20, 2020, 2:03 du,

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/#review220824 ---

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/#review220822 --- Ship it! Ship It! - Peter Vary On máj. 19, 2020, 5:58 de,

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

> On máj. 18, 2020, 12:51 du, Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 305 (patched) > > > > > > Migth want to add asserts here to check non-null argument

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/#review220805 --- Minor comments only. Thanks for the patch!

Re: Review Request 72481: HIVE-23234: Optimize TxnHandler::allocateTableWriteIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72481/#review220689 --- Thanks Marci, Few querstions below - probably I just do not

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72470/#review220673 --- Ship it! Ship It! - Peter Vary On máj. 7, 2020, 1:21 du,

Re: Review Request 72436: Locks: Implement zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72436/#review220526 --- Ship it! Ship It! - Peter Vary On ápr. 28, 2020, 4:23 du,

Re: Review Request 72444: HIVE-23280: Trigger compaction with old aborted txns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72444/#review220523 --- Ship it! Ship It! - Peter Vary On ápr. 28, 2020, 10:37 de,

Re: Review Request 72444: HIVE-23280: Trigger compaction with old aborted txns

> On ápr. 28, 2020, 8:54 de, Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java > > Lines 113 (patched) > > > > > > Do we know

Re: Review Request 72436: Locks: Implement zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72436/#review220517 --- Quick quersions. Thanks for the patch, Peter

Re: Review Request 72444: HIVE-23280: Trigger compaction with old aborted txns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72444/#review220514 --- Thanks for the patch Karen! Few questions below. Thanks, Peter

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220500 --- Fix it, then Ship it! Fix it and ship it

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220487 --- Overall looks good. There are some changes which might not be

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/#review220426 --- Ship it!

Re: Review Request 72392: HIVE-23103 Oracle statement batching

> On ápr. 21, 2020, 7:51 de, Marton Bod wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > > Lines 662 (patched) > > > > > > Once this part executes,

Re: Review Request 72392: HIVE-23103 Oracle statement batching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72392/ --- (Updated ápr. 21, 2020, 12:41 du) Review request for hive, Denys Kuzmenko and

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/#review220374 --- Some nits, did not checked all the unit tests changes. Anything I

Review Request 72392: HIVE-23103 Oracle statement batching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72392/ --- Review request for hive, Denys Kuzmenko and Marton Bod. Bugs: HIVE-23103

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220369 --- This is a really big/scary change. I am really interested in the

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

> On ápr. 17, 2020, 7:03 du, Peter Vary wrote: > > Thanks Peter for the patch! > > This fix is long overdue! > > > > I do not understand one thing, see below. > > > > Also I would like to ask Denys to confirm, that running the init sqls again > > and again will not cause too much overhead in

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72380/#review220352 --- Thanks Peter for the patch! This fix is long overdue! I do not

Re: Review Request 72378: HIVE-23201: Improve logging in locking

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220347 --- Mostly agree, few comments. I would like to ask you to go through

Re: Review Request 72360: HIVE-23093: Create new metastore config value for jdbc max batch size

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72360/#review220331 ---

Re: Review Request 72359: HIVE-23104: Minimize critical paths of TxnHandler::commitTxn and abortTxn

> On ápr. 14, 2020, 11:22 de, Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1325 (patched) > > > > > > Not really important

Re: Review Request 72359: HIVE-23104: Minimize critical paths of TxnHandler::commitTxn and abortTxn

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72359/#review220308 --- Thanks for the patch Marton! Some questions, ideas. Thanks,

Re: Review Request 72112: HIVE-22869 - Add locking benchmark to metastore-tools/metastore-benchmarks

> On ápr. 3, 2020, 9:59 de, Peter Vary wrote: > > standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java > > Lines 341 (patched) > > > > > > I put this

Re: Review Request 72336: HIVE-23114: Insert overwrite with dynamic partitioning is not working correctly with direct insert

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72336/#review220255 --- Fix it, then Ship it! Single very important comment! :)

Re: Review Request 72112: HIVE-22869 - Add locking benchmark to metastore-tools/metastore-benchmarks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72112/#review220212 --- Thanks for the patch @Zoltan! Some comments below. Peter

Re: Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

> On ápr. 1, 2020, 7:38 de, Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 4295 (patched) > > > > > > Please extract

Re: Review Request 72283: HIVE-23076 Add batching for openTxn

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72283/ --- (Updated ápr. 2, 2020, 10:23 de) Review request for hive, Denys Kuzmenko and

Re: Review Request 72283: HIVE-23076 Add batching for openTxn

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72283/ --- (Updated ápr. 1, 2020, 1:12 du) Review request for hive, Denys Kuzmenko and

Re: Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72290/#review220167 ---

Re: Review Request 72291: HIVE-23107: Remove MIN_HISTORY_LEVEL table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72291/#review220153 --- Ship it! Just a question, maybe not relevant. Thanks for the

Re: Review Request 72264: HIVE-23052: Optimize lock enqueueing in TxnHandler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/#review220146 --- Thanks for the patch Marci! A few questions below, feel free to

Re: Review Request 72283: HIVE-23076 Add batching for openTxn

> On márc. 30, 2020, 10:36 de, Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 603 (patched) > > > > > > Could we rename

Review Request 72283: HIVE-23076 Add batching for openTxn

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72283/ --- Review request for hive, Denys Kuzmenko and Marton Bod. Bugs: HIVE-23076

Re: Review Request 72109: HIVE-20948: Eliminate file rename in compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72109/#review219603 --- LGTM +1, just minor nits?

Re: Review Request 71904: HIVE-21164: ACID: explore how we can avoid a move step during inserts/compaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71904/#review219487 --- Thanks for the patch! This will be very-very usefull. Some minor

Review Request 72081: HIVE-22805 Vectorization with conditional array or map is not implemented and throws an error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72081/ --- Review request for hive and Ramesh Kumar Thangarajan. Bugs: HIVE-22805

Re: Review Request 72028: HIVE-22729: Provide a failure reason for failed compactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72028/#review219450 --- Ship it! - Peter Vary On jan. 30, 2020, 10:23 de, Laszlo

Re: Review Request 72043: HIVE-21487: COMPLETED_COMPACTIONS and COMPACTION_QUEUE table missing appropriate indexes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72043/#review219380 --- Have you tested the sqls on every db? If they run correctly on

Re: Review Request 72059: HIVE-22793: Update default settings in HMS Benchmarking tool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72059/#review219434 --- Ship it! Ship It! - Peter Vary On jan. 30, 2020, 9:35 de,

Re: Review Request 72028: HIVE-22729: Provide a failure reason for failed compactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72028/#review219433 --- Could you please update the hive schema as well? Thanks, Peter

Re: Review Request 71888: HIVE-22568: Process compaction candidates in parallel by the Initiator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71888/#review219251 --- Ship it! Ship It! - Peter Vary On dec. 6, 2019, 12:54 du,

Re: Review Request 71949: HIVE-20934: ACID: Query based compactor for minor compaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71949/#review219177 --- Ship it! Ship It! - Peter Vary On jan. 8, 2020, 10:40 de,

Re: Review Request 71949: HIVE-20934: ACID: Query based compactor for minor compaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71949/#review219171 ---

Re: Review Request 71963: HIVE-22700: Compactions may leak memory when unauthorized

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71963/#review219145 --- Ship it! Ship It! - Peter Vary On jan. 7, 2020, 2:51 du,

Re: Review Request 71949: HIVE-20934: ACID: Query based compactor for minor compaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71949/#review219140 --- itests/hive-unit/pom.xml Lines 440 (patched)

Re: Review Request 71844: HIVE-22554: ACID: Wait timeout for blocking compaction should be configurable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71844/#review218855 --- Ship it! Ship It! - Peter Vary On nov. 28, 2019, 1:49 du,

Re: Review Request 71812: HIVE-22534: ACID: Improve Compactor thread logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71812/#review218820 --- Since everybody can comment on logging, I have a few comments :)

Re: Review Request 71775: HIVE-22280: Q tests for partitioned temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71775/#review218819 --- Ship it! Ship It! - Peter Vary On nov. 20, 2019, 4:25 du,

Re: Review Request 71792: COMPLETED_TXN_COMPONENTS table is never cleaned up unless Compactor runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71792/#review218762 ---

Re: Review Request 71763: HIVE-22484: Remove Calls to printStackTrace

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71763/#review218620 --- ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java Line 646

Re: Review Request 71671: HIVE-22401: Refactor CompactorMR

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71671/#review218420 --- Thanks for the patch. A nit and a question.

Re: Review Request 71589: Create read-only transactions

> On okt. 17, 2019, 11:10 de, Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 992 (original), 1003 (patched) > > > > > > Why is this a List of Pairs, why not just a Map? Is the

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/#review218258 --- nits and a single question

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/#review218201 --- ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/#review218200 --- +1 pending tests. And some nits, just to be constructive :D :D :D

Re: Review Request 71606: HIVE-21407: Parquet predicate pushdown is not working correctly for char column types

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71606/#review218190 --- Ship it! Ship It! - Peter Vary On okt. 10, 2019, 11:39 de,

Re: Review Request 71589: Create read-only transactions

> On okt. 10, 2019, 7:46 de, Peter Vary wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java > > Lines 47 (patched) > > > > > > What about CREATE TABLE AS SELECT * FROM...? > > We still

Re: Review Request 71606: HIVE-21407: Parquet predicate pushdown is not working correctly for char column types

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71606/#review218175 --- Thanks for chasing this down! Really appreciate it!

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/#review218174 --- One more question to find a way to identify write queries.

Re: Review Request 71574: HIVE-22212: Implement append partition related methods on temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71574/#review218019 --- Ship it! Ship It! - Peter Vary On okt. 2, 2019, 11:49 de,

Re: Review Request 71550: HIVE-22137: Implement alter/rename partition related methods on temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71550/#review218017 --- Ship it! Just one minor comment, we can fix that in a

Re: Review Request 71558: HIVE-21987: Hive is unable to read Parquet int32 annotated with decimal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71558/#review217991 --- Ship it! Ship It! - Peter Vary On szept. 30, 2019, 11:53

Re: Review Request 71550: HIVE-22137: Implement alter/rename partition related methods on temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71550/#review217953 ---

Re: Review Request 71506: HIVE-22084: Implement exchange partitions related methods on temporary tables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71506/#review217910 --- Thanks Laszlo! Few quick questions below. We might want to test

Re: Review Request 71243: HIVE-21875: Implement drop partition related methods on temporary tables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71243/#review217752 --- Fix it and ship it

Re: Review Request 70474: HIVE-21407: Parquet predicate pushdown is not working correctly for char column types

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70474/#review215157 --- Ship it! Ship It! - Peter Vary On máj. 9, 2019, 7:51 de,

Re: Review Request 70474: HIVE-21407: Parquet predicate pushdown is not working correctly for char column types

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70474/#review214659 --- Fix it, then Ship it! Just one little nit. Otherwise LGTM +1

Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

> On márc. 21, 2019, 10:18 de, Peter Vary wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > > Lines 3153-3155 (patched) > > > > > > My concern

Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70256/#review213878 ---

Re: Review Request 69914: HIVE-21227: HIVE-20776 causes view access regression

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69914/#review212667 --- Ship it! Ship It! - Peter Vary On febr. 8, 2019, 6:48 de,

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/#review212622 --- Ship it! Ship It! - Peter Vary On febr. 6, 2019, 9:17 du,

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/#review212343 --- Ship it! Ship It! - Peter Vary On jan. 3, 2019, 1:40 de,

Re: Review Request 69780: HIVE-21099 Do Not Print StackTraces to STDERR in ConditionalResolverMergeFiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69780/#review212173 --- Ship it! Ship It! - Peter Vary On jan. 17, 2019, 10:22 de,

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

> On jan. 8, 2019, 10:04 de, Peter Vary wrote: > > Thanks for the patch! > > Two nits below. > > Also a bit concerned about the size calculation - seems ok, but it would be > > good to have a few test case which validates the contentsummary > > calculations (when every path is cached/only few

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/#review211758 --- Thanks for the patch! Two nits below. Also a bit concerned about

Re: Review Request 69633: HIVE-20159 Do Not Print StackTraces to STDERR in ConditionalResolverSkewJoin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69633/#review211722 --- Thanks for the fix! Fix it and ship it!

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

> On jan. 3, 2019, 1:42 de, Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 374 (patched) > > > > > > The

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

> On jan. 3, 2019, 1:42 de, Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 374 (patched) > > > > > > The

Re: Review Request 69410: HIVE-20330: HCatLoader cannot handle multiple InputJobInfo objects for a job with multiple inputs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69410/#review210823 --- Ship it! Ship It! - Peter Vary On nov. 20, 2018, 12:53 du,

Review Request 69432: HIVE-20964 Create a test that checks the level of the parallel compilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69432/ --- Review request for hive, Denys Kuzmenko, Marta Kuczora, and Adam Szita. Bugs:

Re: Review Request 69410: HIVE-20330: HCatLoader cannot handle multiple InputJobInfo objects for a job with multiple inputs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69410/#review210792 --- My only concen is that some other components might use

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210752 --- Mostly just questions about logging

Re: Review Request 69254: HIVE-20818: Views created with a WHERE subquery will regard views referenced in the subquery as direct input

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69254/#review210334 --- Just one question. Thanks, Peter

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210036 --- Ship it! Ship It! - Peter Vary On okt. 25, 2018, 1:36 du,

Re: Review Request 69155: HIVE-20760: Reducing memory overhead due to multiple HiveConfs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69155/#review210029 --- Thanks for the patch Barna! Indeed this will be a sizeable memory

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/#review209735 --- Thanks Laci! 1 serions question 1 mild one and several annoying

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/#review209443 --- Thanks Laszlo! This is a big patch indeed. Comments below. Could

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review209081 --- Thanks Denys, I like this new version. My last comments are

Re: Review Request 68828: HIVE-20601 : EnvironmentContext null in ALTER_PARTITION event in DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68828/#review209069 --- Ship it! Ship It! - Peter Vary On szept. 24, 2018, 8:42 du,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review208968 --- Hi Denys, Could you please think a little about separating the

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On szept. 17, 2018, 9:15 de, Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 507 (original), 666 (patched) > > > > > > please don't make this method more visible; use

Re: Review Request 61663: WebUI query plan graphs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61663/#review208622 --- Fix it then ship it! Thanks for the revitalization of this

Re: Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68523/#review208033 --- Thanks for the patch. LGTM, just one question regarding the

  1   2   3   >