p against this bug and
was scratching my head as to what was wrong. =-)
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
if ( (strcmp(q->filename, rr->filename) == 0) ||
> +(strcmp(q->uri, rr->uri) == 0) ){
I might be missing something, but why'd you revert this change?
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
.
--Cliff
----
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Thu, 23 Aug 2001, Greg Ames wrote:
> Cliff Woolley wrote:
> >
> > I'm sure this has been discussed, but someone please remind me what was
> > decided. Are we going to continue to maintain mod_tls? I'm sure there
> > are some changes that have been
l-as-a-bucket thing, then ++1, let's get this bad
boy out the door. :-)
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
tion we
have right now. If 2.0.25 starts to show problems when it gets put up on
daedalus, I'm still +1 for beta on 2.0.24 (with the mod_include fixes).
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
his taken care of. :-/
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
uld be that Win32 is lagging far
behind, which I don't believe to be the case at all.
But that's just my $0.02. I won't veto a split release, but let's just
say I'm -0.75 on the idea.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
there" from Ryan all around due to the age of 2.0.24), then
2.0.25 needs to get ironed out and put up on daedalus ASAP for testing in
production. And it needs to be compilable. =-)
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
its argument as const. Should this
line be backed down to char * or does something else need to be done?
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
ist: /tmp/cliff/htdocs/apache_pb.gif
/cgi-bin/test-cgi doesn't work either, btw.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
r->canonical_filename = r->filename;
>}
>
Crap, and I saw those (briefly), too... I thought they looked strange for
some reason but didn't focus on it long enough to see the obvious. I
wonder why the hell didn't this cause a gcc warning?
--Cliff
-
half a million warnings from
mod_ssl. I turned off mod_ssl to clear the air, and sure enough there
they were right in front of my face.
Anyhow, good catch.
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
patch didn't help on my end... I just committed it before I saw your
note here. Sorry, hope it doesn't get in your way. I'll revert if you
want.
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On 24 Aug 2001 [EMAIL PROTECTED] wrote:
> wrowe 01/08/23 21:41:47
>
> Log:
>
>
WTF?
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
(strcmp(q->uri, rr->uri) == 0) &&
+ (strcmp(q->uri, "INTERNALLY GENERATED "
+ "file-relative req") !=
0)))
{
founddupe = 1
On Fri, 24 Aug 2001, Cliff Woolley wrote:
> if (strncmp(rnew->filename, fdir, fdirlen) != 0
>&& rnew->filename[fdirlen]
>&& ap_strchr_c(rnew->filename + fdirlen, '/') == NULL)
>
> This is not new behavior ... it&#
On Thu, 23 Aug 2001, Doug MacEachern wrote:
> On Fri, 24 Aug 2001, Cliff Woolley wrote:
>
> funny, i tried committing a change to mod_include.c and up-to-date failed,
> was the same indentation fix. then i was going to suggest this patch to
> cure the same problem, since
ain it. :-)
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
t, bb);
> +return ap_pass_brigade(f->next, bb);
I thought so. Thanks.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
but I doubt you'll need that here either.
There are plenty of uses of apr_brigade_split() in the core filters that
you can look at as an example.
Hope this helps! Let me know if you have more questions.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
is helps! Let me know if you have more questions.
>
> Quite well, thank you kindly. I'm hacking up some docs to pass your
> help on. apr_buckets.h has func descriptions but I'd like to make a
> sybling of _Hook_Functions_ [1] with THE RULES and some common
> recipies.
Great! I've been meaning to write up a "buckets 101" tutorial... maybe
this will give me a kick-start. =-)
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
; +apr_bucket_copy(ec, &foo);
>}
> APR_BRIGADE_INSERT_TAIL(bsend, foo);
>ec = APR_BUCKET_NEXT(ec);
>
>
>
>
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
/x-server-parsed-html mime-type,
though, right?
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
. I'll dig up that
"three phase plan" message I posted a while back and go from there.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
r_bucket.c
Oops, thanks.
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
ucket_read in find_start_sequence and split the bucket there if
> its size exceeds some reasonable threshold?
Let me second that idea... checking per-bucket would be WAY better IMO.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Wed, 29 Aug 2001, Gonyou, Austin wrote:
> The referrence here is one about all the filters used by apache 2.0.
> If there is a filter bucket in APR,
What do you mean by "filter bucket"?
> it's understandable that Apache 2.0 modules will have 2 parts. The
> logic piece and the filter piece.
-DONE_PROCESS or -DNO_DETACH...
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
is resolved, the comments
are trivial to revert to maintain that consistency.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
we wouldn't be spreading implementation assumptions throughout
> the support code.
apachectl already has some values substituted at configure time... might
as well just substitute in the requisite signals as well.
--Cliff
----------
C
vote for 26
tomorrow midday to fix these issues. I'll volunteer to RM since Ryan's
already done it once in 24 hours. =-)
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
sh roll eastern time.
Thanks,
Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
At least on this front, I'm in total agreement... the httpd-test suite is
excellent. I've gotten to where I rely on it heavily to test any change I
make (even small ones) before committing, because it's so good at sniffing
out the subtle (and not-so-subtle) problems. If everybody used it, we'd
be set.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
n working on)
You just described my whole life lately...
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
w I'm late
for class)...
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
v tests were skipped... you have --enable-dav and
--enable-dav-fs... what gives?
Thanks for doing this!
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
Here goes.
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
ta release is because it simply has not been ready for beta release -- the
> big fixes we have been making lately have vastly improved it over what
> it was two months ago.
That's a good point, one we shouldn't forget. :)
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
anks,
Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
other option is that we patch these to a single code path
> > _today_. Let Apache run a bit slow until these optimizations are
> > moved into the right, magic places.
> >
> I think that would make more sense.
+1
--Cliff
-------
s on HEAD?
Thanks,
Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
g the tests from httpd-test (which seems to now be
working) in order to post the results here (they were failing miserably),
but I see that you just committed a fix. I'll stop my test and do a cvs
up. Stay tuned...
--Cliff
----------
C
On Thu, 30 Aug 2001, Cliff Woolley wrote:
> I was just running the tests from httpd-test (which seems to now be
> working) in order to post the results here (they were failing miserably),
> but I see that you just committed a fix. I'll stop my test and do a cvs
> up. Stay
On Fri, 31 Aug 2001, Cliff Woolley wrote:
> More details on the mod_include tests that failed, which are essentially
> all the ones involving valid subrequests:
>
> FAILED tests 1, 15, 17-20
> Failed 6/22 tests, 72.73% okay
And from the error log:
[Fri Aug 31 00:18:1
> #if 0's you added:
> >
> > request.c:297: warning: `resolve_symlink' defined but not used
>
> That will become used, rather soon (after the next tag.)
Figured it would.
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
now works:
Arggh. I think I like Bill's solution of ditching this "INTERNALLY
GENERATED crap" and just make it NULL. But my brain is too fried right
now to get that working.
I'm going to sleep. We'll fix this tomorrow.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
return the directory structure to the state of distribution?
That's true. Give or take the config.nice thing.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
f I do a GET /test/ it core dumps
> any ideas?
I was just looking at exactly the same thing. It's unrelated to the
INTERNALLY GENERATED FOONESS thing. I'll keep looking...
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
XXX When this is reenabled, the cache triggers need to be set to faux
* dir_walk/file_walk values.
*/
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
t (the right way) and then we can do
> a release.
+1.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
sitive) and using an up-to-date
copy of the perl-framework. I assume you tried doing a t/TEST -clean,
right?
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
t none of them have really BIG
content... not even close to big enough to warrant a brigade split. Maybe
we should add a test that includes biggish data from the middle of a
biggish file? Somewhere around 32k should be sufficient, I'd guess...
--Cliff
----------
odule either, but size
is not the final consideration in what goes in and what doesn't.)
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
e
to see it.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
buted through official httpd subprojects are more
visible/more trusted, but we don't really know one way or the other on
that front yet.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
akefiles and so on which do affect the state. If I make distclean, it
means I want to start over again with the first step out of the tarball,
namely configure. It doesn't mean I want to lose the options I passed to
configure.
My $0.02.
--Cliff
------
en in a different way by now. :-) But it's also true that
we're lightyears closer to a stable release now than ever before.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
y.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
ght now (for the
> first time in recent memory, win9x is doing something better than
> nt/2k :)
Will the wonders never cease! :)
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Mon, 3 Sep 2001, Cliff Woolley wrote:
> > Actually, is anybody on the list (with 2.0 from cvs-HEAD) using
> > cgi/cgid for subrequests, redirects, or error pages? That would be
> > the area of interest.
Using prefork/mod_cgi/mod_include, the results are defi
changed the subject to a new thread... (these
tests were just to see what would happen, not to try to show that your
change broke something).
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Tue, 4 Sep 2001, Justin Erenkrantz wrote:
> All uppercase. 6 of one, half-dozen of the other. -- justin
I'll take the 6. I like this a whole lot better. Thanks, Justin. :)
--Cliff
--
Cliff Woolley
[EMAIL P
d) the cases *I've*
thought up, which isn't very many. =-)
I have no idea what the Right Way is.
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Wed, 5 Sep 2001, john sachs wrote:
> i applied this patch and the mod_include test fails in the same spot
> as it has been. content file has:
>
> 'include file' with relative path to file not in same path as the file
> you are requesting.
Yep. This patch has no effect on that. It's probabl
f the existance of the else case. The easiest way to do that
is probably to change the else case to set r->uri NULL instead of to
"INTERNALLY GENERATED fooness" and test r->uri before using it in all
places it's used.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Wed, 5 Sep 2001, Justin Erenkrantz wrote:
> On Wed, Sep 05, 2001 at 11:34:24PM -0400, Cliff Woolley wrote:
> > hack did. Both will break if you have a relative path that goes UP at
> > least one directory first, since the strncmp will fail. You'll get back
>
>
On Wed, 5 Sep 2001, Greg Stein wrote:
> I don't understand what you're trying to solve here, and how this
> solves it.
It's an attempt to fix the mod_include
segfault. It "solves" it by setting r->uri to something valid rather than
setting it to "INTERNALLY GENERATED...". It's as yet unclear
ystem, I have to catch those in the map_to_storage hook,
> or the server will 500.
Hmm... I'd have thought that was the whole point of the map_to_storage
hook, if its name were any indication...
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
be an optimization that I want to use,
> not a requirement that I HAVE to use.
Ahh, yes, well that makes sense. I agree.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
s.
This is _1.3_ mod_tls, which only exists in Netware. I've never figured
out why it was in there. I never much liked the idea, but whatever.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
to
house mod_ldap.
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
mod_rewrite, mod_ssl, etc. Those modules have
certainly each had their own problems now and then, but they've also
helped us sniff out major problems in the core. I'm not saying that this
necessarily applies to mod_gz, but you get my point.
--Cliff
----------
have
historically NOT delayed server releases. +1 to put mod_gz in there if
that's what it takes to get agreement on this issue.
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
95.2 19991024 (release)
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
Happy 1 billion, everybody. (Only half an hour to go...) :-)
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
necessarily mean the original file
descriptor is still open, so you're not guaranteed that you can use
sendfile()...
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
d all the buckets up and writev()'d
them all in one fell swoop like we do now.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Sun, 9 Sep 2001, Brian Pane wrote:
> Right, although this isn't a problem with Apache because the file bucket
> code doesn't close the fd when it does an mmap.
mod_file_cache does.
--Cliff
------
Cliff Woolley
discussions.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
n ap_ function,
since other modules also use apr_explode_locatime and could take advantage
of it as well. (Haven't we talked about doing this before? What ever
happened to that?)
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
mod_rewrite for variable substitution. Surely there's a faster way to
accomplish that little bit of logic than forty or so strcasecmp's for each
variable (in the worst case)...
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
Does anyone else think that mod_imap is at this point in time a rather
unfortunate name for an image-map handling module?
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
nt_localtime() which is the same as
apr_explode_localtime() except that the input must never be older than
TIME_CACHE_SIZE seconds? Or is that too httpd-tailored? If so, no sweat,
make it an ap_ function instead of an apr_ function.
--Cliff
----------
one that puts it over its buffering threshold, then it will flush
the data it's already examined down the filter chain.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
u don't keep the whole file MMAPed at one
time, which is pretty much an impossible guarantee to make from within
file_read(). Callers can make that guarantee, but I don't know how they
communicate it to the buckets code in a clean way.
--Cliff
--------
odule magic numbers don't match.
--Cliff
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
t out of sync.
httpd-win.conf only differs from httpd-std.conf in minor ways as well.
The biggest differences again are in default directory names. IMO a
comment or two would fix that problem right up.
What gives?
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
this, so there's the possibility I made some
stupid mistakes. I'll get back to it later no doubt, but if someone else
would care to take the next turn at looking over it, I'd appreciate it.
To save bandwidth, my version is here:
http://www.apache.org/~jwoolley/mod_gzi
hat a
derivative exists takes the original out of the running, for the obvious
reasons that the original is heavily tested and so on. If someone else
can even just use my version to read it through to more quickly understand
what's going on in the original version (but use the original version)
then I think it was worth it.
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
otherwise you will have a gzip'ed included file in a non-gziped main file.
All good points.
Thanks,
Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Sat, 15 Sep 2001, Cliff Woolley wrote:
> > The ability to add compression statistics to the Apache logs
> > via the r->notes interface was one of the things that people
> > needed the MOST.
>
> Okay, I didn't know that. It wasn't clear from the code that
hould be able to get this same functionality out of mod_log_config
even if the data is stored in r->pool's userdata, right? The user
explicitly tells us what the key name is that they want logged, so we
should be good to go.
--Cliff
-----
gt;uri would ever be NULL. Can it really? Even when there is no
r->uri, we set it to the empty string. That was that whole INTERNALLY
GENERATED bogosity that we scratched our heads over for a while and then
Ryan fixed it by setting it to "". Under what circumstances will
r->uri==NULL?
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
guess it's not a showstopper.
--Cliff
PS: I volunteered to RM 2.0.26 a while back and am still willing...
------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
e lot of
> other things if/when something showed up as NULL ) that
> weren't apppriate for a macro ( Used to write a complete separate log
> file for things that turned up NULL during request hooks and such ).
>
> In non-debug mode... it's really all pretty irrelevant.
O
(in my case, I run some cleanup code
> which can take a while, and would like the client to be on its way).
Why can't you just register a cleanup on c->pool instead of r->pool?
--Cliff
----------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
t something simple?
I've never seen this message before (other files I looked at currently
work fine, btw).
--Cliff
--
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
On Mon, 17 Sep 2001, Ian Holsman wrote:
> mod_cgi seems to be a bit borked.
See if my commit fixed it for you as well... it did for me. It seems to
have just been a constness problem in disguise.
Thanks,
--Cliff
--
Cliff Wool
gister a cleanup on pchild when I
realized that the pchild pointer is static to each individual MPM and I
can't figure out how to access it from a module. Is there some other pool
with a similar lifetime that should be used besides pchild? Or is there
some way to get at pchild that I'm miss
1 - 100 of 1113 matches
Mail list logo
