Re: HTTP/2 and no-longer "experimental"

2017-05-31 Thread Graham Leggett
On 31 May 2017, at 2:07 PM, Jim Jagielski wrote: > There was discussion some time ago about dropping the "experimental" > tag from our HTTP/2 implementation. It is causing loads of people > to not use it, as well as allowing for the perpetuation of FUD that > httpd really

Re: Ideas from ApacheCon

2017-05-23 Thread Graham Leggett
On 23 May 2017, at 3:29 PM, Jim Riggs wrote: >>> Does that differ from "CacheQuickHandler OFF"? > > > This one is a bit quirky and requires some investigation to see the edge > cases. There appear to be some situations where Require directives with > `CacheQuickHandler

Re: SSL Policy Definitions

2017-05-03 Thread Graham Leggett
On 03 May 2017, at 2:01 PM, Stefan Eissing wrote: > We seem to all agree that a definition in code alone will not be good enough. > People need to be able to see what is actually in effect. I think we’re overthinking this. We only need to document the settings

Re: SSL and Usability and Safety

2017-05-02 Thread Graham Leggett
On 02 May 2017, at 3:19 PM, Stefan Eissing wrote: > How can we help Mr and Ms Normal to stay up to date on these things? > > - We cannot rewrite their config unasked. We need to be backward compatible. > - Our defaults nowadays are dangerously unsafe, so users MUST

Re: drop experimental from http2 for 2.4.next?

2017-04-18 Thread Graham Leggett
On 17 Apr 2017, at 10:24 AM, Stefan Eissing wrote: > These modules, they grow up so fast... > > For the project, it would be good to drop that "experimental" and > treat HTTP/2 as an integral part of httpd. Not only for political > posturing (which is important),

Re: drop experimental from http2 for 2.4.next?

2017-04-18 Thread Graham Leggett
On 15 Apr 2017, at 11:02 PM, Eric Covener wrote: > Hi everyone, shall we drop experimental from mod_http2 for 2.4.next? +1. > We could drop it and keep CTR. It can’t be not-experimental and CRT at the same time. Regards, Graham — smime.p7s Description: S/MIME

Re: json, rather sooner than later

2017-03-31 Thread Graham Leggett
On 31 Mar 2017, at 2:51 PM, Stefan Eissing wrote: > Hey, I'm currently evaluating some addition to httpd that needs to > parse/serialize JSON. > I know not everyone is a fan of that format, but some protocols do require it > (I try to > spare us a discussion

Re: Reset out x.minor.z definition of 'minor' at httpd?

2017-01-20 Thread Graham Leggett
On 20 Jan 2017, at 10:40 PM, Jim Jagielski wrote: > In fact, I'd announce 2.5-alpha "immediately" as what's > in trunk... with a set schedule that 2.6-Beta1 is tagged 2 > months later and a goal that 2.6-GA be announced at > ApacheCon Miami. > > But this all implies that

Re: Reset out x.minor.z definition of 'minor' at httpd?

2017-01-20 Thread Graham Leggett
On 20 Jan 2017, at 4:29 PM, William A Rowe Jr wrote: >>> Right now, there are a number of gratuitous breaking changes on trunk >>> that change binary ABI. I'm considering a trunk fork to preserve these >>> changes (branches/3.x-future/?) and reverting every change to trunk/

Re: Reset out x.minor.z definition of 'minor' at httpd?

2017-01-20 Thread Graham Leggett
On 20 Jan 2017, at 7:47 PM, David Zuelke wrote: > I'd actually like to question the whole practice of porting features back to > older branches. I think that's the core reason why trunk is in total > disarray, and why no substantial releases have been made. There is just no >

Re: Alternate versioning proposal: patch line releases

2017-01-20 Thread Graham Leggett
On 20 Jan 2017, at 2:15 AM, Jacob Champion wrote: > Ignore the versioning number then; that's not really the core of my proposal. > The key points I'm making are > > - introduce the concept of a low-risk release line We have always had this, the current low-risk release

Re: Reset out x.minor.z definition of 'minor' at httpd?

2017-01-20 Thread Graham Leggett
On 19 Jan 2017, at 11:43 PM, William A Rowe Jr wrote: > I think one of our disconnects with 2.4 -> 2.6 is that in any other > framework, there would be no ABI breakage in 2.6. That breakage > would be deferred to and shipped as 3.0. > > The httpd project choose to call

Re: Async write completion broken in trunk?

2017-01-18 Thread Graham Leggett
On 18 Jan 2017, at 3:38 PM, Jim Jagielski wrote: > That's a good overview... Yeah, it might be getter better, but it does > seem that the nature of the bugs implies it's also getting more > fragile. Could be, likely is, just my impression due to some weird > things I've seen

Re: Async write completion broken in trunk?

2017-01-18 Thread Graham Leggett
On 18 Jan 2017, at 3:05 PM, Jim Jagielski wrote: > Well, there's this, and it seems like there are issues w/ > the current mutexing as well, causing weird wake-ups. Only solution really is to find the bugs and fix them. Regards, Graham — smime.p7s Description: S/MIME

Re: Async write completion broken in trunk?

2017-01-18 Thread Graham Leggett
On 18 Jan 2017, at 3:00 PM, Jim Jagielski wrote: > Somewhat on-topic but also off-topic as well, but it does seem > that event on trunk is getting much more fragile instead of more > stable. It seems to be picking up some kruft which is making > event on trunk a *worse* option

Re: Async write completion broken in trunk?

2017-01-18 Thread Graham Leggett
On 17 Jan 2017, at 7:40 PM, Luca Toscano wrote: > Since this email thread seems important, is there any update from anybody > working on it? It would be great to open a bugzilla task otherwise, to track > everything and make sure that we don't forget about it :) I

Re: RemoteIPProxyProtocol

2017-01-16 Thread Graham Leggett
On 15 Jan 2017, at 18:35, Daniel Ruggeri wrote: >> As we *sure* we want to call it RemoteIPProxyProtocol instead >> of just "regular" ProxyProtocol ? >> >> The latter just sounds and looks "more right" to me. > > I still like RemoteIPProxyProtocol because I also like the

Re: clang-analyzer?

2017-01-09 Thread Graham Leggett
On 08 Jan 2017, at 4:45 AM, Leif Hedstrom wrote: > I ran clang-analyzer against the HTTPD master branch, and it found 126 > issues. Many of these are benign, but I was curious if the community has any > thoughts on this? With another project, I’ve found that keep static code

Re: [proposed] 2.4 Maintenance SIG

2017-01-04 Thread Graham Leggett
On 04 Jan 2017, at 8:37 PM, Jacob Champion wrote: >> Can you give us an example of this dead code? > > In modules/ alone (I haven't looked at server/ yet, and don't plan to today), > after ignoring build-related files and stripping the svn-diff context, there > are

Re: [proposed] 2.4 Maintenance SIG

2017-01-04 Thread Graham Leggett
On 04 Jan 2017, at 3:16 PM, William A Rowe Jr wrote: >> Can you give us an example of this dead code? > > svn diff --ignore-properties --no-diff-deleted -x --ignore-all-space > https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/server >

Re: Automated tests

2017-01-04 Thread Graham Leggett
On 31 Dec 2016, at 4:58 AM, William A Rowe Jr wrote: > Thinking two things would help. > > Splitting our functional utilities into a libaputil would make it much easier > to write the tests that exercise these elements of our code. Definite +1. I want to see a C based

Re: [proposed] 2.4 Maintenance SIG

2017-01-04 Thread Graham Leggett
On 03 Jan 2017, at 10:47 PM, Jacob Champion wrote: > I don't feel that trunk is a dead branch, but I do think there is dead code > in trunk. Can you give us an example of this dead code? Regards, Graham — smime.p7s Description: S/MIME cryptographic signature

Re: [proposed] 2.4 Maintenance SIG

2017-01-03 Thread Graham Leggett
On 03 Jan 2017, at 4:07 PM, William A Rowe Jr wrote: > Can you clarify the problem you’re trying to solve? > > v3.0 and v2.6 are just numbers. For modest changes, we move to v2.6. For a > very large architecture change (for example, the addition of filters in v1.x > to

Re: [proposed] 2.4 Maintenance SIG

2017-01-03 Thread Graham Leggett
On 03 Jan 2017, at 2:11 AM, William A Rowe Jr wrote: > So far, discussions are polarized on a single axis... > > East: Let's work on 3.0; whatever is going on in 2.4 won't distract me, I > won't spend time reviewing enhancements, because 3.0 is the goal. > > West: Let's

Re: Redis and mod_cache/mod_socache

2016-10-31 Thread Graham Leggett
On 31 Oct 2016, at 5:05 PM, Jim Jagielski wrote: > Moving to APR: > > Query: Think it would be worth my time to work on a Redis > implementation for APR-util? I am working on a minimal Redis > lib, related to work, which is basically a soft reboot of Credis > from GoogleCode,

Re: Redis and mod_cache/mod_socache

2016-10-31 Thread Graham Leggett
On 31 Oct 2016, at 4:13 PM, Ruediger Pluem wrote: > Which creates the generic question for me: Can't we setup APR in a way that > for certain aspects we could compile > "drivers" against an existing APR whose code exists outside of APR first and > gets part of standard APR

Re: Redis and mod_cache/mod_socache

2016-10-31 Thread Graham Leggett
On 31 Oct 2016, at 3:43 PM, Jim Jagielski wrote: > It would, but that would mean even more of a APR dependency > and a wait until the next release of APR and etc, etc, etc... > Basically, APR moves too slow for httpd. APR can make a release at any time. It usually doesn’t

Re: Redis and mod_cache/mod_socache

2016-10-31 Thread Graham Leggett
On 31 Oct 2016, at 3:30 PM, Jim Jagielski wrote: > Query: Think it would be worth my time to work on a > Redis implementation for mod_cache/mod_socache? I am > working on a minimal Redis lib, related to work, which > is basically a soft reboot of Credis from GoogleCode, > which

Re: Random AH01842 errors in mod_session_crypto

2016-10-04 Thread Graham Leggett
On 4 Oct 2016, at 15:47, Paul Spangler wrote: > From my understanding, apr_crypto_key_t is an opaque struct defined > separately by each crypto provider, so mod_session_crypto will not be able to > do the sizeof. That's a sizeof a pointer to apr_crypto_key_t, not the

Re: Async write completion broken in trunk?

2016-09-14 Thread Graham Leggett
On 06 Sep 2016, at 12:06 AM, Stefan Fritsch wrote: > in trunk, when having a lot of slow long running transfers, most of them seem > to hog a thread and only a few of them go into async write completion mode. > Compare this to 2.4, where many transfers are doing async write

Re: httpd-trunk\modules\filters\mod_crypto

2016-09-08 Thread Graham Leggett
On 08 Sep 2016, at 12:09 PM, NormW wrote: > What versions of apr\apr-util are assumed to be used when compiling > httpd-trunk? > I get the following error when compiling mod_crypto, but can't find where the > offending symbol is typedef'd. Presently using apr-1.5 and

Re: svn commit: r1753263 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_protocol.c

2016-08-03 Thread Graham Leggett
On 18 Jul 2016, at 6:32 PM, William A Rowe Jr wrote: > Worse, in http 2.4, the first two registered methods collide with BREW and > WHEN. That said, the 'fix', if we wanted to resolve it, is to use M_INVALID > +3 as the first value. I’m not seeing the problem here, there

Caching PROPFIND

2016-07-27 Thread Graham Leggett
Hi all, According to https://tools.ietf.org/html/rfc7234#section-2, it says the following: "However, it is also possible to cache [...] responses to methods other than GET if the method's definition allows such caching and defines something suitable for use as a cache key." Would it

Re: svn commit: r1752099 - in /httpd/httpd/trunk: ./ build/rpm/ docs/log-message-tags/ docs/manual/ docs/manual/mod/ modules/filters/

2016-07-12 Thread Graham Leggett
On 11 Jul 2016, at 4:39 PM, Ruediger Pluem wrote: >> Added: httpd/httpd/trunk/modules/filters/mod_crypto.c >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_crypto.c?rev=1752099=auto >>

Re: [Patch] mod_crypto: A general purpose crypto filter with HLS support

2016-07-10 Thread Graham Leggett
On 12 Dec 2014, at 12:59 AM, Yann Ylavic wrote: >> Incorporating the above, How about this? > > Looks fine, modulo the above (didn't figure out before): All of this has been included. I’ve committed this in r1752099 so that further development can occur on trunk.

Re: Mergine of Multiple Cookie Headers

2016-06-28 Thread Graham Leggett
On 28 Jun 2016, at 4:29 PM, Rainer Canavan wrote: > We've observed multiple gateways, operated by e.g. AT, COLT and > Vodafone, that inject additional Cookie: headers into client requests, > such as > > Cookie: actually=from_the_client > Cookie: Bearer-Type=w-TCP >

Re: RFC 7230..7235 Parsing Conformance?

2016-05-17 Thread Graham Leggett
On 17 May 2016, at 6:43 PM, William A Rowe Jr wrote: > Wondering what other contributors are thinking on this topic. > > We have a number of changes in the ABNF grammar between > RFC2616 and RFC7230..7235. Do we want trunk 2.6/3.0 to be > an entirely RFC723x generation

Re: core_output, files and setaside

2016-05-04 Thread Graham Leggett
On 04 May 2016, at 3:22 PM, Stefan Eissing wrote: > file_bucket_setaside() currently does not care about the refcount. setaside > affects *all* shared file buckets, wherever they currently reside. So it > moves the contained apr_file_t into the filter deferred

Re: core_output, files and setaside

2016-05-04 Thread Graham Leggett
On 04 May 2016, at 11:13 AM, Stefan Eissing wrote: > The problem is not the apr_bucket_destroy(). The file bucket setaside, calls > apr_file_setaside(), in core_output on a deferred pool, and then core_output > clears that pool. This invalidates all still

Re: core_output, files and setaside

2016-05-04 Thread Graham Leggett
On 04 May 2016, at 10:45 AM, Stefan Eissing wrote: > I have been wrong before...but... > > mod_http2 needs to send out a file response: > 1. it starts with the response body brigade: [file:0-len][eos] > 2. it sends the first 16K frame by splitting the file bucket:

Re: TIL

2016-04-27 Thread Graham Leggett
On 27 Apr 2016, at 2:49 PM, Stefan Eissing wrote: > I had a look into 2.4.x this morning and while there are changes in filter > brigade setaside code, the basic "cleanup" of empty and meta buckets before > the setaside is there already. > > I think this has not

Re: TIL

2016-04-27 Thread Graham Leggett
On 26 Apr 2016, at 4:49 PM, Stefan Eissing wrote: > Today I Learned the difference between writing > DATA + META > and > DATA + META + FLUSH > to the core output filters. I am astonished that > my code ever worked. > > Seriously, what is the reason for this

Re: Allow SSLProxy* config in context?

2016-04-13 Thread Graham Leggett
On 13 Apr 2016, at 12:40 PM, Rainer Jung wrote: > I stumbled into a situation where a reverse proxy had two different backends > behind the same VHost of the proxy. Both backends demand client certs as > becomes more and more common for services today. Unfortunately

Re: Status for 2.4.20

2016-03-25 Thread Graham Leggett
On 23 Mar 2016, at 1:58 PM, Noel Butler wrote: > as stated previously, this shit will happen when certain people push with a > release often mentality > > AFAIK there is *ZERO* critical exploit bugs to be patched by any pending > release, so lets get house in order S

Re: svn commit: r1736216 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2016-03-22 Thread Graham Leggett
On 22 Mar 2016, at 7:08 PM, yla...@apache.org wrote: > URL: http://svn.apache.org/viewvc?rev=1736216=rev > Log: > Follow up to r1734656: restore c->data_in_input_filters usage to > see if it helps unblocking test framework. I created an almost identical patch before doing an update, the only

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

2016-03-22 Thread Graham Leggett
On 22 Mar 2016, at 7:11 PM, Yann Ylavic wrote: > In r1736216, I tried to restore c->data_in_input_filters usage as > prior to r1734656. > Does it help (or I'll revert)? Got caught up in other stuff before I could get to the bottom of this :( It looks like we need to

Re: svn commit: r1735176 - in /httpd/httpd/trunk: CHANGES modules/http/http_core.c

2016-03-19 Thread Graham Leggett
On 16 Mar 2016, at 1:08 PM, Stefan Eissing wrote: > I needed to revert r1735174 to make HTTP/1.1 work again. I submitted this to > trunk since other people are affected too. > > Graham: if you are unable to reproduce this and need any additional data, pls > let

Re: [Patch] Ensure HTTP1 filters are only added on HTTP1 requests

2016-03-16 Thread Graham Leggett
On 16 Mar 2016, at 5:57 AM, William A Rowe Jr wrote: > My concern is that this can't and shouldn't change on 2.4.x. > > I love the concept and it is correct, however there are enough modules relying > on the fact that they must remove the http protocol filters that changing

Re: [Patch] mod_tcp / mod_proxy_tcp / mod_ssl_tcp

2016-03-15 Thread Graham Leggett
On 12 Mar 2016, at 5:46 PM, Graham Leggett <minf...@sharp.fm> wrote: > The following patch provides support for TCP proxying to httpd. Here is an updated patch with changes to the ap_mpm_register_poll* functions. Regards, Graham -- httpd-tcp-proxy2.patch Description: Binary data

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-15 Thread Graham Leggett
On 15 Mar 2016, at 1:09 PM, Yann Ylavic wrote: >> I just gave it a try and it was a lot more elegant than I thought. >> >> You create an array the precise size you need, and off you go. > > That's indeed elegant enough, but I think I prefer the plain array > solution,

[Patch] Ensure HTTP1 filters are only added on HTTP1 requests

2016-03-14 Thread Graham Leggett
Hi all, The following patch fixes the problem where the HTTP1 filters are added on non HTTP1 requests. The filters are now only added if ap_get_protocol() returns AP_PROTOCOL_HTTP1. Regards, Graham -- Index: modules/http/http_core.c

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

2016-03-14 Thread Graham Leggett
On 14 Mar 2016, at 10:48 AM, Ruediger Pluem wrote: > This seems to cause frequent (no always) failures with test 8 of > t/ssl/proxy.t. > The request times out with a 504 status. So it looks like the "backend" in > this request does not respond. > Used MPM is Event, OS CentOS

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-14 Thread Graham Leggett
On 14 Mar 2016, at 11:13 AM, Stefan Eissing wrote: > Like the direction this is going as well. > > Do we need a MPM Query for detecting support before one actually has a handle > for registration? We do - most recent patch has that, and we managed to drop one

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-14 Thread Graham Leggett
On 14 Mar 2016, at 11:17 PM, Yann Ylavic wrote : >> Having looked at this in more detail this isn’t as simple. >> >> The sticking point is the cleanup, which needs to be passed a single struct >> to do it’s work. To pass both the pfds and the npdfs these two need to be >>

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-14 Thread Graham Leggett
On 14 Mar 2016, at 10:32 AM, Yann Ylavic wrote: > Since apr_pollfd_t is not opaque (unlike apr_socket_t), maybe we could > remove the indirection here (and in the code below) with somthing like > (apr_pollfd_t *pfds, size_t npfds, ...). > That would allow a single

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-14 Thread Graham Leggett
On 14 Mar 2016, at 10:32 AM, Yann Ylavic wrote: > Since apr_pollfd_t is not opaque (unlike apr_socket_t), maybe we could > remove the indirection here (and in the code below) with somthing like > (apr_pollfd_t *pfds, size_t npfds, ...). > That would allow a single

Re: [Patch] mod_tcp / mod_proxy_tcp / mod_ssl_tcp

2016-03-14 Thread Graham Leggett
On 14 Mar 2016, at 11:01 AM, Yann Ylavic wrote: >> The following patch provides support for TCP proxying to httpd. >> >> It consists of the following three parts: >> >> - mod_tcp: Allows the frontend to receive pure TCP connections > > It looks like this module is only

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-13 Thread Graham Leggett
On 13 Mar 2016, at 10:55 PM, Eric Covener wrote: > I also meant the original feature never made it, so we can whatever we > want to it. What do you think of this? It includes a cleanup to the original pool to remove any unfired pollsets from the core. Index:

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-13 Thread Graham Leggett
On 13 Mar 2016, at 10:53 PM, Eric Covener wrote: > I don't think I had a good reason for going one way or the other, +1 > here. Trunk-only and presumably nobody consuming it from the lack of > feedback. From what I can see, this was never backported to v2.4. Regards, Graham

Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-13 Thread Graham Leggett
Hi all, I would like to propose a change to the mpm_register_socket_callback() hooks to add the ability to support both pipes as well as sockets. In addition, I need more control over the individual events to support the idea that one socket/pipe might want to read at the same time another

Re: [Patch] mod_tcp / mod_proxy_tcp / mod_ssl_tcp

2016-03-13 Thread Graham Leggett
On 12 Mar 2016, at 6:26 PM, Eric Covener wrote: > Very cool stuff. Only looked on the surface so far, but one thing it > reminded me of in the async case is that the MPM knows the "suspended" > count but we never gave an API to really "unsuspend" when using a > timed or socket

[Patch] mod_tcp / mod_proxy_tcp / mod_ssl_tcp

2016-03-12 Thread Graham Leggett
Hi all, The following patch provides support for TCP proxying to httpd. It consists of the following three parts: - mod_tcp: Allows the frontend to receive pure TCP connections - mod_proxy_tcp: Allows the proxy to make pure tcp or tls connections to a backend - mod_ssl_tcp: Allows the proxy to

Re: conn_rec needs a context

2016-03-02 Thread Graham Leggett
On 02 Mar 2016, at 2:26 AM, Yann Ylavic wrote: >>> Would it make sense to add a vector of contexts that same way we have a >>> vector of configs, one slot for each module, which will allow any module to >>> add a context of it’s own to conn_rec without having to extend

conn_rec needs a context

2016-03-01 Thread Graham Leggett
Hi all, In order to get connections to have async behaviour, it must be possible for the process_connection hook to exit in the expectation of being called again when an async mpm is present - this is easy, the mpms already do that. The missing bit is that conn_rec needs a context so that when

Re: state of h2 (long)

2016-03-01 Thread Graham Leggett
On 29 Feb 2016, at 10:33 PM, Jim Jagielski wrote: > I've been digging into how we could better leverage serf on the mod_proxy > side w/o going the route of mod_serf itself... Agreed that using > pollsets et.al. would be useful. Maybe some of the motorz mpm logic > could be

httpd + systemd

2016-02-26 Thread Graham Leggett
Hi all, I am trying to come up with a vanilla systemd unit file so that our RPM packaging contains a sensible startup on systemd environments, but I’m struggling. With the unit file below the “systemctl restart httpd” command hangs. Usually the server starts fine, but then the server is

Re: svn commit: r1725149 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h server/core.c

2016-01-18 Thread Graham Leggett
On 18 Jan 2016, at 1:40 AM, cove...@apache.org wrote: > Author: covener > Date: Sun Jan 17 23:40:09 2016 > New Revision: 1725149 > > URL: http://svn.apache.org/viewvc?rev=1725149=rev > Log: > allow expressions to be used in SetHandler. Opt-in with expr= prefix. I am -0.9 on the opt-in with

Re: async mpms + http2

2015-12-15 Thread Graham Leggett
On 15 Dec 2015, at 5:44 PM, Stefan Eissing wrote: > However, there is another state in HTTP/2 processing, where a BLOCK_READ is > performed: flow control on streaming out responses. Basically, the client has > a window of n bytes, the server sends n response

Re: scoreboard and http2

2015-12-09 Thread Graham Leggett
On 09 Dec 2015, at 3:49 PM, Stefan Eissing wrote: > For the next 2.4 release, I would like to add scoreboard support to mod_http2. > > There are several options for doing so and I would like your feedback on which > route we should take. I try to outline what

Re: AW: reverse proxy wishlist

2015-12-03 Thread Graham Leggett
On 3 Dec 2015, at 15:50, Plüm, Rüdiger, Vodafone Group wrote: > How about an async proxy that frees up the thread while waiting on a slow > backend? This is generic httpd thing, not restricted to mod_proxy. From what I have seen it shouldn't be difficult, we just

Re: issue with "uncacheable" cache revalidations

2015-12-01 Thread Graham Leggett
On 1 Dec 2015, at 15:50, Eric Covener wrote: > I've been looking at an issue where a revalidation > of a stale cache entry fails because the 304 response > on the revalidation doesn't contain its own CC or Expires > but the URL has a query string. This kicks the revalidation

Re: svn commit: r1715938 - /httpd/httpd/trunk/modules/cache/cache_util.c

2015-11-24 Thread Graham Leggett
On 24 Nov 2015, at 6:36 PM, Yann Ylavic wrote: > Sure, but my point is that the worst case is likely depend on the > application, It will depend on the application, yes. > eg: > >case 'm': >case 'M': >if (!strncmp(token, "max-age", 7) >||

Re: svn commit: r1715938 - /httpd/httpd/trunk/modules/cache/cache_util.c

2015-11-24 Thread Graham Leggett
On 24 Nov 2015, at 6:15 PM, Yann Ylavic wrote: > Not sure: >if (!strcmp(h, "max-age") >|| ap_cmpcasestr(h, "max-age")) > is likely to be a bit faster than a single ap_cmpcasestr() when it > matches, but much slower when it does not. Yep, that’s the point. The

Re: svn commit: r1715938 - /httpd/httpd/trunk/modules/cache/cache_util.c

2015-11-24 Thread Graham Leggett
On 24 Nov 2015, at 5:21 PM, Jim Jagielski wrote: > For these types of paths, where we use a switch/case against > the 1st char of the token, the real reason why we used that > impl was to avoid the (expected) expensive string comparison. > > This is really no longer an issue.

Re: 2.4.18?

2015-11-18 Thread Graham Leggett
On 18 Nov 2015, at 9:11 AM, Noel Butler wrote: > absolutely not! I personally only update phpmyadmin once, on initial major > release, because I (like many others) were so of updating it every few days . We’re catering for everybody here, not just your unique use case.

Re: CentOS 7 and test framework

2015-11-18 Thread Graham Leggett
On 18 Nov 2015, at 5:45 PM, Jim Jagielski wrote: > Anyone else having troubles convincing the test framework > in centOS 7 to recreate the various SSL certs and stuff??? > > usually a 'make realclean' will delete them and a t/TEST -clean > followed by t/TEST will recreate

Re: 2.4.18?

2015-11-17 Thread Graham Leggett
On 17 Nov 2015, at 2:18 PM, Noel Butler wrote: > You run into complacency dangers if you end up in a "release very often" > mode, take phpmyadmin as one example, most admins I know gave up updating it, > because there were updates every week, sometimes every few days,

Re: 2.4.18?

2015-11-17 Thread Graham Leggett
On 17 Nov 2015, at 07:13, Noel Butler wrote: > ??? We only had 2.4.17 5 weeks ago, why the rush? We have improvements, why make people wait? Regards, Graham --

Re: Moderations for modules.apache.org

2015-11-09 Thread Graham Leggett
On 09 Nov 2015, at 2:41 PM, Daniel Gruno wrote: > You're welcome to try to clean it up ;) > make a user account on the system and give me the UID of that user (the > ID, not the username - there are tens of thousands of users, so I can't > see them all in the admin

Re: Moderations for modules.apache.org

2015-11-09 Thread Graham Leggett
On 06 Nov 2015, at 6:55 PM, Daniel Gruno wrote: > I'm sorry to say modules.apache.org is so bot/spam infested now, that > it's impossible to moderate it unless I spend more than an hour every > day going through all the fake modules and users added on a daily basis. > > I

Moderations for modules.apache.org

2015-11-06 Thread Graham Leggett
Hi all, I've had a module waiting to be approved at modules.apache.org for a while, anyone know who the moderator is? Regards, Graham --

Re: trailer

2015-11-05 Thread Graham Leggett
On 05 Nov 2015, at 3:04 PM, Stefan Eissing wrote: > Looking at the source regarding trailer handling, am I correct in seeing: > - no support for sending trailer to the client in http core Did a quick look at this and it looks like it, yes. Ideally the CHUNK

Re: Is Apache getting too patchy?

2015-10-27 Thread Graham Leggett
On 27 Oct 2015, at 12:40 AM, Tim Bannister wrote: >> That may not be easy. You need to find someone who'll be interested in an >> idea or patch, and has the time to review it. >> Plus, the community as a whole to agree it's a good idea, or at least not >> actively

Re: Improve Apache performance on high load (prefork MPM) with multiple Accept mutexes (Patch attached)

2015-10-26 Thread Graham Leggett
On 26 Oct 2015, at 10:45 AM, Yehezkel Horowitz wrote: > Any chance someone could take a short look and provide me a feedback (of any > kind)? > > I know your focus is on 2.4 and trunk, but there are still many 2.2 servers > out there… > > Patch attached again for

Re: Question about CACHE_SEPARATOR in modules/cache/cache_util.h

2015-10-26 Thread Graham Leggett
On 26 Oct 2015, at 9:05 AM, Christophe JAILLET wrote: > in modules/cache/cache_util.h, CACHE_SEPARATOR is defined as: > > #define CACHE_SEPARATOR ", " > > > I don't see any reason to have 3 spaces here. > It is only used within calls to 'cache_strqtok'

Re: Question about CACHE_SEPARATOR in modules/cache/cache_util.h

2015-10-26 Thread Graham Leggett
On 26 Oct 2015, at 2:15 PM, Rainer Jung wrote: > The line goes back to > > https://bz.apache.org/bugzilla/show_bug.cgi?id=50199 > > where Nick reported the problem and Graham provided the initial patch. > > The defined tokenizer chars were "comma-space-space-space"

Re: [users@httpd] Chunked transfer delay with httpd 2.4 on Windows.

2015-10-22 Thread Graham Leggett
On 22 Oct 2015, at 5:31 PM, Andy Wang wrote: > I already had to do that. We have this weird scenario where when our > installer installs httpd, httpd hangs. Packet captures show the request > arriving but no ACK or any form of response. > > If I kill the installer process,

Re: buckets and connections (long post)

2015-10-22 Thread Graham Leggett
On 22 Oct 2015, at 6:04 PM, Stefan Eissing wrote: >> mod_ssl already worries about buffering on it’s own, there is no need to >> recreate this functionality. Was this not working? > > As I wrote "it has other bucket patterns", which do not get optimized by the >

Re: buckets and connections (long post)

2015-10-22 Thread Graham Leggett
On 22 Oct 2015, at 6:03 PM, Stefan Eissing wrote: > This is all true and correct - as long as all this happens in a single > thread. If you have multiple threads and create sub pools for each from a > main pool, each and every create and destroy of these

Re: buckets and connections (long post)

2015-10-22 Thread Graham Leggett
On 22 Oct 2015, at 5:43 PM, Stefan Eissing wrote: >> The blocking read breaks the spirit of the event MPM. >> >> In theory, as long as you enter the write completion state and then not >> leave until your connection is done, this problem will go away. >> >> If

Re: buckets and connections (long post)

2015-10-22 Thread Graham Leggett
On 22 Oct 2015, at 5:55 PM, Stefan Eissing wrote: >> With the async filters this flow control is now made available to every >> filter in the ap_filter_setaside_brigade() function. When mod_http2 handles >> async filters you’ll get this flow control for free. > >

Re: master connection + mod_ssl + http2

2015-10-21 Thread Graham Leggett
On 21 Oct 2015, at 2:42 PM, Stefan Eissing wrote: > The basic changes: > 1. conn_rec->master is NULL for HTTP/1.1 connections, but points to the > "real" connection for HTTP/2 requests. > 2. mod_ssl no longer initalizes any SSLConnRec* for slave connections >

Re: buckets and connections (long post)

2015-10-21 Thread Graham Leggett
On 21 Oct 2015, at 4:18 PM, Stefan Eissing wrote: > How good does this mechanism work for mod_http2? On the one side it's the > same, on the other quite different. > > On the real, main connection, the master connection, where the h2 session > resides, things are

Re: Forwarded buckets' lifetime (was: [Bug 58503] segfault in apr_brigade_cleanup()...)

2015-10-20 Thread Graham Leggett
On 20 Oct 2015, at 10:42 AM, Stefan Eissing wrote: >> So if at all a change for trunk only that requires a very deep review of all >> brigade usages. > > As I learned, bucket brigades are very optimized for the common HTTP/1 case: > appearing during one >

Re: master connections

2015-10-20 Thread Graham Leggett
On 20 Oct 2015, at 6:14 PM, Stefan Eissing wrote: > In /trunk we have the master connection member of conn_rec which we cannot > backport to 2.4.x - as I understand. We can do, as long as the value goes at the very end of the struct, and we have a minor MMN bump

XSLT filter for httpd

2015-10-19 Thread Graham Leggett
Hi all, In the light of the move to simple services that talk XML/JSON and HTML and Javascript based clients that become more and more capable, I find myself wanting an XSLT filter quite often these days to sit in the middle and translate between the two. As a complement to mod_xmlenc, would

Re: XSLT filter for httpd

2015-10-19 Thread Graham Leggett
On 19 Oct 2015, at 3:20 PM, Nick Kew wrote: > There are several old modules: for example mod_transform. > I expect they still serve for sites without i18n requirements. > One option would be to overhaul that. > > Note, mod_transform is GPL. Originally my decision when I

Re: H2 compatible ciphers (was: svn commit: r1708593)

2015-10-16 Thread Graham Leggett
On 16 Oct 2015, at 12:56 PM, Stefan Eissing wrote: > I am not blacklisting ciphers for the whole server. I try to define > the security settings required for HTTP/2 as defined in the standard - > as a configurable directive. > > There is no problem with denying

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

2015-10-12 Thread Graham Leggett
On 11 Oct 2015, at 7:00 PM, Stefan Eissing wrote: > Ok, analyzed the code. Here is what seems to be happening: > > - mod_http2, in the connection hook, does a blocking, speculative read to > a) make sure the ALPN has been triggered Looking at the code inside the

Re: about those async filters

2015-10-08 Thread Graham Leggett
On 07 Oct 2015, at 4:30 PM, Stefan Eissing wrote: > In http2 land, the request happen on "pseudo" connections, connections > properly created by ap_run_create_connection(), but with own filters of type > AP_FTYPE_PROTOCOL and AP_FTYPE_NETWORK, registered by

<    1   2   3   4   5   6   7   8   9   10   >