Ruediger Pluem wrote:
On 09/11/2007 06:09 PM, jean-frederic clere wrote:
Plüm wrote:
-Ursprüngliche Nachricht-
Von: jean-frederic clere
Gesendet: Montag, 10. September 2007 16:38
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Ruediger Pluem wrote:
On 09/11/2007 10:51 PM, Jim Jagielski wrote:
I would also suggest that we keep ap_proxy_lb_workers
in proxy_util.c (as it currently is), since even
though its not part of the API, other proxy module
make have a need for it (and again, keeping the
number of changes
-Ursprüngliche Nachricht-
Von: jean-frederic clere
Gesendet: Mittwoch, 12. September 2007 10:34
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Ruediger Pluem wrote:
On 09/11/2007 10:51 PM, Jim Jagielski wrote:
I
Plüm wrote:
-Ursprüngliche Nachricht-
Von: jean-frederic clere
Gesendet: Mittwoch, 12. September 2007 10:34
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Ruediger Pluem wrote:
On 09/11/2007 10:51 PM, Jim Jagielski wrote
-Ursprüngliche Nachricht-
Von: jean-frederic clere
Gesendet: Mittwoch, 12. September 2007 12:15
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
The check for worker_size is not needed as worker_size is
never zero
Jim Jagielski wrote:
On Sep 11, 2007, at 12:44 PM, jean-frederic clere wrote:
Jim Jagielski wrote:
On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
1. IMHO requires a minor bump.
Find a patch that covers all the points you raised below.
More comments?
Requires a major
Plüm wrote:
-Ursprüngliche Nachricht-
Von: jean-frederic clere
Gesendet: Montag, 10. September 2007 16:38
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Jim Jagielski wrote:
On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF
On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
1. IMHO requires a minor bump.
Find a patch that covers all the points you raised below.
More comments?
Requires a major bump. Also destroys all those mystical
other balancers from working as-is, since they
must now be not only
Jim Jagielski wrote:
On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
1. IMHO requires a minor bump.
Find a patch that covers all the points you raised below.
More comments?
Requires a major bump. Also destroys all those mystical
other balancers from working as-is, since
On Sep 11, 2007, at 12:44 PM, jean-frederic clere wrote:
Jim Jagielski wrote:
On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
1. IMHO requires a minor bump.
Find a patch that covers all the points you raised below.
More comments?
Requires a major bump. Also destroys all
On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
AP_DECLARE(lb_score *) ap_get_scoreboard_lb(int lb_num)
{
-if (((lb_num 0) || (lb_limit lb_num))) {
+char *ptr;
+if (((lb_num 0) || (lb_limit lb_num)) || worker_size==0) {
return(NULL); /* Out of range */
On 09/11/2007 06:09 PM, jean-frederic clere wrote:
Plüm wrote:
-Ursprüngliche Nachricht-
Von: jean-frederic clere
Gesendet: Montag, 10. September 2007 16:38
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Jim Jagielski wrote
On 09/11/2007 06:23 PM, Jim Jagielski wrote:
On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
1. IMHO requires a minor bump.
Find a patch that covers all the points you raised below.
More comments?
Requires a major bump. Also destroys all those mystical
Curious again. Why
On Sep 11, 2007, at 4:04 PM, Ruediger Pluem wrote:
On 09/11/2007 06:23 PM, Jim Jagielski wrote:
On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
1. IMHO requires a minor bump.
Find a patch that covers all the points you raised below.
More comments?
Requires a major bump.
Why doesn't j-f go ahead and commit the revised patch
to trunk and we can address our concerns in the code
instead of email :)
On 09/11/2007 10:18 PM, Jim Jagielski wrote:
On Sep 11, 2007, at 4:04 PM, Ruediger Pluem wrote:
On 09/11/2007 06:23 PM, Jim Jagielski wrote:
On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
1. IMHO requires a minor bump.
Find a patch that covers all the points you raised
On Sep 11, 2007, at 4:39 PM, Ruediger Pluem wrote:
it will fail to compile after the patch, because lb_score is now an
incomplete type. So I guess in order to keep it backportable we
need to stick with
typedef struct lb_score lb_score;
struct lb_score {
unsigned char data[1024];
};
On 09/11/2007 10:51 PM, Jim Jagielski wrote:
I would also suggest that we keep ap_proxy_lb_workers
in proxy_util.c (as it currently is), since even
though its not part of the API, other proxy module
make have a need for it (and again, keeping the
number of changes to a minimum).
+1.
On Sep 11, 2007, at 5:01 PM, Ruediger Pluem wrote:
On 09/11/2007 10:51 PM, Jim Jagielski wrote:
I would also suggest that we keep ap_proxy_lb_workers
in proxy_util.c (as it currently is), since even
though its not part of the API, other proxy module
make have a need for it (and again,
Jim Jagielski wrote:
Ruediger Pluem wrote:
Because it was
int ap_proxy_lb_workers(void);
and not
PROXY_DECLARE(int)ap_proxy_lb_workers(void);
Yep. Ideally, of course, a design like mod_ssl with the
ssl_private.h usage is nice, because there you can
expose functions that need to be
-Ursprüngliche Nachricht-
Von: jean-frederic clere [mailto:[EMAIL PROTECTED]
Gesendet: Montag, 10. September 2007 13:23
An: dev@httpd.apache.org
Cc: Jim Jagielski
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Plüm wrote:
-Ursprüngliche
Plüm wrote:
-Ursprüngliche Nachricht-
Von: jean-frederic clere [mailto:[EMAIL PROTECTED]
Gesendet: Montag, 10. September 2007 13:23
An: dev@httpd.apache.org
Cc: Jim Jagielski
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Plüm wrote
On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF-Group wrote:
For example what about adding:
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_worker_size)
*proxy_lb_worker_size;
and use a void * in scoreboard and an int for the size?
For me this sounds fine, but I would guess that Jim doesn't like
the
Jim Jagielski wrote:
On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF-Group wrote:
For example what about adding:
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_worker_size)
*proxy_lb_worker_size;
and use a void * in scoreboard and an int for the size?
For me this sounds fine, but I would guess
On Sep 10, 2007, at 8:24 AM, jean-frederic clere wrote:
Jim Jagielski wrote:
On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF-Group wrote:
For example what about adding:
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_worker_size)
*proxy_lb_worker_size;
and use a void * in scoreboard and an int for
Jim Jagielski wrote:
On Sep 10, 2007, at 8:24 AM, jean-frederic clere wrote:
Jim Jagielski wrote:
On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF-Group wrote:
For example what about adding:
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_worker_size)
*proxy_lb_worker_size;
and use a void * in
On Sep 10, 2007, at 10:13 AM, jean-frederic clere wrote:
Jim Jagielski wrote:
I'm not sure what you mean. mod_proxy does, in child_init,
the calls to create those scoreboard entries. It does
so via ap_proxy_initialize_worker_share(). No matter
what, the -s is set to:
worker-s =
Jim Jagielski wrote:
On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF-Group wrote:
For example what about adding:
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_worker_size)
*proxy_lb_worker_size;
and use a void * in scoreboard and an int for the size?
For me this sounds fine, but I would guess
On Sep 10, 2007, at 10:37 AM, jean-frederic clere wrote:
typedef struct ap_sb_handle_t ap_sb_handle_t;
@@ -181,7 +175,7 @@
AP_DECLARE(worker_score *) ap_get_scoreboard_worker(int x, int y);
AP_DECLARE(process_score *) ap_get_scoreboard_process(int x);
AP_DECLARE(global_score *)
-Ursprüngliche Nachricht-
Von: jean-frederic clere
Gesendet: Montag, 10. September 2007 16:38
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Jim Jagielski wrote:
On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF-Group
-Ursprüngliche Nachricht-
Von: Jim Jagielski
Gesendet: Montag, 10. September 2007 16:51
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
On Sep 10, 2007, at 10:37 AM, jean-frederic clere wrote:
typedef struct
On Sep 10, 2007, at 11:08 AM, Plüm, Rüdiger, VF-Group wrote:
Sorry for being a pain in the neck with this topic :-)
:)
It just seems that we're spending so much time on something
which was envisioned as a quick, logical fix to trunk
which could then be backported to 2.2. But it's getting
On Mon, Sep 10, 2007 at 05:02:52PM +0200, Plüm, Rüdiger, VF-Group wrote:
1. IMHO requires a minor bump.
2. Why messing around with lb_score any longer? Instead of
...
Sorry for stepping in on the discussion -- but Jim has tried to clean
the code, JFC has helped providing alternative patches,
Plüm wrote:
-Ursprüngliche Nachricht-
Von: jean-frederic clere
Gesendet: Montag, 10. September 2007 16:38
An: dev@httpd.apache.org
Betreff: Re: svn commit: r573264 -
/httpd/httpd/trunk/include/scoreboard.h
Jim Jagielski wrote:
On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF
On Sep 10, 2007, at 12:19 PM, jean-frederic clere wrote:
Well that just because I am thinking that the size of
proxy_worker_stat
could be changed by a balancer, like adding extra bytes to
proxy_worker_stat.
That is what 'void *context' is designed to do. Be a place
where unique data can
Jim Jagielski wrote:
On Sep 10, 2007, at 12:19 PM, jean-frederic clere wrote:
Well that just because I am thinking that the size of proxy_worker_stat
could be changed by a balancer, like adding extra bytes to
proxy_worker_stat.
That is what 'void *context' is designed to do. Be a
On 09/10/2007 05:39 PM, Martin Kraemer wrote:
On Mon, Sep 10, 2007 at 05:02:52PM +0200, Plüm, Rüdiger, VF-Group wrote:
1. IMHO requires a minor bump.
2. Why messing around with lb_score any longer? Instead of
...
Sorry for stepping in on the discussion -- but Jim has tried to clean
the
Of course, the *real* fix is to make the scoreboard and
its entire allocation something which is more callable/usable
by modules, which is something we talked about several
times and is like a major aspect of 3.0.
But the current discussion tries to somehow say
that lb_score shouldn't know that
On Sep 7, 2007, at 6:20 PM, Ruediger Pluem wrote:
On 09/07/2007 03:03 PM, Jim Jagielski wrote:
On Sep 7, 2007, at 6:29 AM, jean-frederic clere wrote:
I think I have patched it. Could you try it?
Ahh... this is much nicer that my idea of breaking out
the data struct defs from the rest
On 09/09/2007 07:24 PM, Jim Jagielski wrote:
On Sep 7, 2007, at 6:20 PM, Ruediger Pluem wrote:
On 09/07/2007 03:03 PM, Jim Jagielski wrote:
On Sep 7, 2007, at 6:29 AM, jean-frederic clere wrote:
I think I have patched it. Could you try it?
Ahh... this is much nicer that my idea
Ruediger Pluem wrote:
Because it was
int ap_proxy_lb_workers(void);
and not
PROXY_DECLARE(int)ap_proxy_lb_workers(void);
Yep. Ideally, of course, a design like mod_ssl with the
ssl_private.h usage is nice, because there you can
expose functions that need to be shared amoung files
Martin Kraemer wrote:
On Fri, Sep 07, 2007 at 10:30:13AM +0200, jean-frederic clere wrote:
That is going to break:
In mod_proxy.h:
int ap_proxy_lb_workers(void);
In server/scoreboard.c:
+++
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_workers)
*proxy_lb_workers;
On Fri, Sep 07, 2007 at 10:30:13AM +0200, jean-frederic clere wrote:
That is going to break:
In mod_proxy.h:
int ap_proxy_lb_workers(void);
In server/scoreboard.c:
+++
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_workers)
*proxy_lb_workers;
+++
Yes, it breaks:
Grrr... I tested with a compile and it worked fine, but
I forgot to do a make distclean 1st.
Yep.
Problem is that we're leaking info in mod_proxy.h
that we shouldn't :/
I'll revert until we figure out a better way to do
this...
On Sep 7, 2007, at 4:30 AM, jean-frederic clere wrote:
That is
On Fri, Sep 07, 2007 at 12:29:05PM +0200, jean-frederic clere wrote:
I think I have patched it. Could you try it?
Index: modules/proxy/proxy_util.c
===
...
Yep, thanks, that fixes it for me too.
+1 from me.
Martin
--
On Sep 7, 2007, at 6:29 AM, jean-frederic clere wrote:
I think I have patched it. Could you try it?
Ahh... this is much nicer that my idea of breaking out
the data struct defs from the rest of mod_proxy.h
And its more logical this way as well...
Compiles clean... testing now.
Too burned
On Sep 7, 2007, at 5:37 AM, Martin Kraemer wrote:
On Fri, Sep 07, 2007 at 10:30:13AM +0200, jean-frederic clere wrote:
That is going to break:
In mod_proxy.h:
int ap_proxy_lb_workers(void);
In server/scoreboard.c:
+++
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_workers)
Martin Kraemer wrote:
On Fri, Sep 07, 2007 at 10:30:13AM +0200, jean-frederic clere wrote:
That is going to break:
In mod_proxy.h:
int ap_proxy_lb_workers(void);
In server/scoreboard.c:
+++
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_workers)
*proxy_lb_workers;
That is going to break:
In mod_proxy.h:
int ap_proxy_lb_workers(void);
In server/scoreboard.c:
+++
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_workers)
*proxy_lb_workers;
+++
Cheers
Jean-Frederic
[EMAIL PROTECTED] wrote:
Author: jim
Date: Thu Sep 6 06:46:46 2007
jean-frederic clere wrote:
That is going to break:
In mod_proxy.h:
int ap_proxy_lb_workers(void);
In server/scoreboard.c:
+++
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_workers)
*proxy_lb_workers;
+++
which is fine - this is trunk.
Heaven forbid we backport
On 09/07/2007 03:03 PM, Jim Jagielski wrote:
On Sep 7, 2007, at 6:29 AM, jean-frederic clere wrote:
I think I have patched it. Could you try it?
Ahh... this is much nicer that my idea of breaking out
the data struct defs from the rest of mod_proxy.h
I do not share this view and
51 matches
Mail list logo
