[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 2: oh - we should be careful that Tim's mirroring script does not check any of the binaries into the ASF repo.

[Impala-CR](cdh5-trunk) PREVIEW: Enable TPC-H workload for Kudu tables

2016-07-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: PREVIEW: Enable TPC-H workload for Kudu tables .. PREVIEW: Enable TPC-H workload for Kudu tables With this commit we enable loading of TPC-H data in Kudu

Re: Looking for OLAP suggestion

2016-07-13 Thread Dimitris Tsirogiannis
Hi, You have correctly identified most of the important issues with the current metadata design :). Most of these issues are tracked in various JIRAs (search for catalog-server label) and we do plan to work on them sometime in the future. For instance, we're actively working on a per-partition

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 1: The ASF build becomes consistent with the non-ASF build after we run download_requrements in the ASF

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-3778: Fix ASF packaging build .. IMPALA-3778: Fix ASF packaging build The tarballs in IMPALA_HOME/infra/python/deps and the thirdparty directory have

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 1: (2 comments) Yes, I ran the private build and test and the packaging job which passed. I will do so

[Impala-CR](cdh5-trunk) IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components.

2016-07-13 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. .. IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. This patch

[Impala-CR](cdh5-trunk) IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components.

2016-07-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. .. Patch Set 3: (5 comments)

[Impala-CR](cdh5-trunk) IMPALA-3857: KuduScanNode race on returning "optional" threads

2016-07-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads .. Patch Set 1: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 1: Has this whl->tar.gz thing been tested with packaging? private-build-and-test? How does it "make it consistent

[Impala-CR] IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has abandoned this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Abandoned This is the wrong branch. Switched this review to cdh5-trunk instead of master. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3647 Change subject: IMPALA-3778: Fix ASF packaging build .. IMPALA-3778: Fix ASF packaging build The tarballs in

[Impala-CR] IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3626/1/bin/impala-config.sh File

Re: IMPALA-2428 Support multiple-character string as the field delimiter

2016-07-13 Thread Jim Apple
Can you please put your design here, rather than just telling us where you pasted it? On Tue, Jul 12, 2016 at 4:33 AM, Yuanhao Luo wrote: > Hello, everyone. To fix IMPALA-2428 , I have push a commit to gerrit. > I have illustrated my design in detail in IMPALA-2428

Re: Looking for OLAP suggestion

2016-07-13 Thread Henry Robinson
Hi Tianyi - The idea behind the metadata cache is to try to ensure that no RPCs to the metastore are on the critical path of query planning. However, the way we populate and invalidate the cache does cause us some problems; the statestore was never designed to carry this kind of payload and this

[Impala-CR](cdh5-trunk) IMPALA-3859: Don't log file data on parse errors

2016-07-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3859: Don't log file data on parse errors .. Patch Set 1: I'd like to get opinions on whether removing the logging is the right thing to do. My view is

[Impala-CR](cdh5-trunk) IMPALA-3859: Don't log file data on parse errors

2016-07-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/3646 Change subject: IMPALA-3859: Don't log file data on parse errors .. IMPALA-3859: Don't log file data on parse errors Logging file or

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. Patch Set 13: Code-Review+1 (2 comments) Thanks! Just add 1 more test case for now. Let's chat

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3328 to look at the new patch set (#13). Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS ..

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. Patch Set 13: (5 comments)

[Impala-CR](cdh5-trunk) PREVIEW: Enable TPC-H workload for Kudu tables

2016-07-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: PREVIEW: Enable TPC-H workload for Kudu tables .. PREVIEW: Enable TPC-H workload for Kudu tables With this commit we enable loading of TPC-H data in Kudu

[Impala-CR](cdh5-trunk) IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components.

2016-07-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3845: Split up hdfs-parquet-scanner.cc into more files/components. .. Patch Set 2: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3610: Account for memory used by filters in the coordinator

2016-07-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 1: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. Patch Set 11: (5 comments) Nice! I think we can get this in very soon, I'd like to make sure we

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#12). Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. IMPALA-3210: last/first_value() support for IGNORE NULLS Added support for the 'ignore

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 8: (23 comments) http://gerrit.cloudera.org:8080/#/c/3220/8/be/src/codegen/llvm-codegen.cc

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. Patch Set 12: (3 comments)

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-13 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3220 to look at the new patch set (#9). Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. ..

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. Patch Set 11: Yup, doing another pass now. (Got caught up with a bad Kudu bug.) -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3857: KuduScanNode race on returning "optional" threads

2016-07-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/3637 Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads .. IMPALA-3857: KuduScanNode race on returning

[Impala-CR](cdh5-trunk) IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()

2016-07-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() .. Patch Set 1: ASAN build:

[Impala-CR] IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 1: (1 comment) This also appears o fix impala-asf-master-exhaustive-rhel7

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. Patch Set 11: (3 comments) Matt, could you also take another look at the window standardization

[Impala-CR](cdh5-trunk) PREVIEW: Enable TPC-H workload for Kudu tables

2016-07-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: PREVIEW: Enable TPC-H workload for Kudu tables .. Patch Set 1: Just curious but why can't we reuse the tpch-q*.test files? The queries and the results are

[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-07-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#11). Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. IMPALA-3210: last/first_value() support for IGNORE NULLS Added support for the 'ignore

[Impala-CR](cdh5-trunk) IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()

2016-07-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() .. Patch Set 1: Verified that test_cancellation.py in ASAN build starts passing with this change. It

[Impala-CR](cdh5-trunk) IMPALA-3159: impala-shell does not accept wildcard or SAN certificates

2016-07-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3159: impala-shell does not accept wildcard or SAN certificates .. Patch Set 7: Verified-1 Build failed:

[Impala-CR](cdh5-trunk) IMPALA-3804: Push per-split filtering into scanners

2016-07-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3804: Push per-split filtering into scanners .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3561/2/be/src/exec/base-sequence-scanner.cc