afs merged pull request #529: JENA-1663: Add triples and prefixes inside a
transaction
URL: https://github.com/apache/jena/pull/529
This is an automated message from the Apache Git Service.
To respond to the message, please
afs commented on issue #527: SDB Transform - improve performance of OPTIONAL,
MINUS
URL: https://github.com/apache/jena/pull/527#issuecomment-462063369
@grahamtriggs - What is an example query to show this in action?
This is
grahamtriggs commented on issue #527: SDB Transform - improve performance of
OPTIONAL, MINUS
URL: https://github.com/apache/jena/pull/527#issuecomment-462271798
@afs Hi - I'm not entirely sure what you want as an example. To see what it
is doing, this is the simplest form of query:
afs commented on a change in pull request #527: SDB Transform - improve
performance of OPTIONAL, MINUS
URL: https://github.com/apache/jena/pull/527#discussion_r255914151
##
File path:
jena-sdb/src/main/java/org/apache/jena/sdb/compiler/TransformOptimizeSubqueryFragments.java
#
afs commented on issue #527: SDB Transform - improve performance of OPTIONAL,
MINUS
URL: https://github.com/apache/jena/pull/527#issuecomment-462727250
OK - I have something working. My first attempt was using a pattern that was
too general to be moved.
There aren't many users of SD
grahamtriggs commented on issue #527: SDB Transform - improve performance of
OPTIONAL, MINUS
URL: https://github.com/apache/jena/pull/527#issuecomment-462799056
@afs OK, I've changed the comments
For tests, what would you like to see? Currently, as it is enabled by
default, the tran
afs commented on issue #527: SDB Transform - improve performance of OPTIONAL,
MINUS
URL: https://github.com/apache/jena/pull/527#issuecomment-463137961
Yes, that's the level of tests that would set this up for long term
stability. They would mean that in the future some other change somewh
afs opened a new pull request #530: JENA-1670: Hardwire and isolate ext.Xerces
setup
URL: https://github.com/apache/jena/pull/530
This is an automated message from the Apache Git Service.
To respond to the message, please lo
grahamtriggs commented on issue #527: SDB Transform - improve performance of
OPTIONAL, MINUS
URL: https://github.com/apache/jena/pull/527#issuecomment-463310716
@afs I've added a test class that runs half a dozen tests on the transformer
- one that shouldn't result in a change in the Op, a
afs commented on issue #527: SDB Transform - improve performance of OPTIONAL,
MINUS
URL: https://github.com/apache/jena/pull/527#issuecomment-463573751
@grahamtriggs - great - I'll check it out soon.
This is an automated mess
afs opened a new pull request #531: JENA-1671: Fix general query servlet.
URL: https://github.com/apache/jena/pull/531
* direct servlet as ActionService
* remove dataset description from query if processed
This is an automa
afs merged pull request #527: SDB Transform - improve performance of OPTIONAL,
MINUS
URL: https://github.com/apache/jena/pull/527
This is an automated message from the Apache Git Service.
To respond to the message, please lo
afs opened a new pull request #532: JENA-1672: Proper function implementation
URL: https://github.com/apache/jena/pull/532
This is an automated message from the Apache Git Service.
To respond to the message, please log on Git
grahamtriggs opened a new pull request #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533
This patch combines a few enhancements to the way SQL queries are formed:
1) The order of variables is retained in the ScopeBase (a HashSet is
replaced with LinkedHashSet). When
afs commented on issue #528: Allow direct loading of tuples without temporary
tables
URL: https://github.com/apache/jena/pull/528#issuecomment-464061578
The project position on SDB is currently that it is discouraged for new
applications and that problems with the module SDB would not bloc
afs commented on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-464149627
Recorded as [JENA-1673](https://issues.apache.org/jira/browse/JENA-1673).
(If the JIRA is opened before the PR and the PR has the JENA- in the
title, the automation w
afs merged pull request #530: JENA-1670: Hardwire and isolate ext.Xerces setup
URL: https://github.com/apache/jena/pull/530
This is an automated message from the Apache Git Service.
To respond to the message, please log on Gi
afs merged pull request #531: JENA-1671: Fix general query servlet.
URL: https://github.com/apache/jena/pull/531
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and us
afs commented on issue #528: Allow direct loading of tuples without temporary
tables
URL: https://github.com/apache/jena/pull/528#issuecomment-464165138
Some tests maybe?
This is an automated message from the Apache Git Servi
afs edited a comment on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-464165809
Some tests maybe?
This is an automated message from the Apache Git Service.
To respond to the message, pl
afs commented on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-464165809
Some test maybe?
This is an automated message from the Apache Git Service.
To respond to the message, please log
afs removed a comment on issue #528: Allow direct loading of tuples without
temporary tables
URL: https://github.com/apache/jena/pull/528#issuecomment-464165138
Some tests maybe?
This is an automated message from the Apache G
grahamtriggs commented on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-464205740
Functionally, the LinkedHastSet (order of Scope), and DISTINCT / GROUP BY
translation are tested multiple times during the existing tests - the code is
exercised and a
afs commented on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-464343025
I was thinking of tests that check this functionality is happening. The
existing test suite should test SPARQL execution functionality but doesn't
check how that happened. A sm
afs merged pull request #528: Allow direct loading of tuples without temporary
tables
URL: https://github.com/apache/jena/pull/528
This is an automated message from the Apache Git Service.
To respond to the message, please l
afs merged pull request #532: JENA-1672: Proper function implementation
URL: https://github.com/apache/jena/pull/532
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub an
seaninryan opened a new pull request #534: [WIP] Proof of concept for
prometheus endpoint
URL: https://github.com/apache/jena/pull/534
I've put together a new servlet to try and expose some of the existing stats
(i.e. what's exposed by `http://:3030/$/stats/`) in a format
consumable by pr
kinow commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-465340261
@Claudenw I think we had a discussion in the mailing list recently about
Grafana, Prometheus. This might be interesting for you?
---
grahamtriggs commented on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-465351735
@afs Hi - I've added some basic tests:
1) There is a test to check that scopes added to the ScopeBase are returned
in the correct order
2) There is a simp
Claudenw commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-465536670
@kinow thanks for the heads up. @seaninryan works with me at the same
company. I advised him to make his changes known to the community for
ajs6f commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-465620789
Is this endpoint usable by software other than Prometheus? I mean to ask;
are there other monitoring suites that could accept this data or would
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-465642833
I'm not 100% sure @ajs6f - but I think that it probably is a propriety
Prometheus format. It's described
[here](https://github.com/promet
ajs6f commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-465644411
Ok, cool. Given the small amount of code here, I don't really have any
problem with supporting one particular framework (especially since I under
grahamtriggs commented on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-465710002
@afs Ooops! I've added the Apache header to both of those files.
This is an automated message from the
afs merged pull request #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
afs opened a new pull request #535: JENA-1674: Don't sign extend
Float.floatToIntBits.
URL: https://github.com/apache/jena/pull/535
Add TestFloatNode for value-based testing of FloatNode.
Use canonical NaN for packing Double.NaN.
-
afs commented on issue #535: JENA-1674: Don't sign extend Float.floatToIntBits.
URL: https://github.com/apache/jena/pull/535#issuecomment-465788847
Sorry @rvesse - discovered I'd been running the wrong test suite and the
original PR was not passing. Caught thanks to TravisCI. The only chang
DamienFontaine opened a new pull request #536: Add support SurroundQueryParser
to jena-text
URL: https://github.com/apache/jena/pull/536
PR to add [SurroundQueryParser
](https://lucene.apache.org/core/7_1_0/queryparser/org/apache/lucene/queryparser/surround/parser/QueryParser.html)
in jen
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-466044561
micrometer.io looks interesting.
Have I understood micrometer correctly? The Fuseki counters/stats/...
implement in the micrometer framework
ajs6f commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-466045612
It is like Dexx in that it is persistent (aka functional) collections
library, and it is not like Dexx in that Dexx intends to exclusively port t
ajs6f commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-466077065
Yep, [looks
like](https://lists.apache.org/list.html?dev@jena.apache.org:gte=1d:pcollections)
we did look at PCollections, and the performance w
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-466159232
Yes - we have to allow "bring their own" adapter, and may provide one
specific one (our own simple custom one?).
Is there any work around do
afs merged pull request #535: JENA-1674: Don't sign extend Float.floatToIntBits.
URL: https://github.com/apache/jena/pull/535
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rvesse commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-466525608
Pinging @osma @xristy
Not that it's a blocker for this PR but anytime I see this kind of code
pattern in Jena (and Java in general) I thin
ajs6f commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-467013724
@rvesse I agree, although for the near-term it's worth watching out for
[OSGi
problems](https://blog.osgi.org/2013/02/javautilserviceloader-in-osg
osma commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-467075475
I think it's a pity this PR merges the two methods into one, making the code
a bit messier and more difficult to understand. Is that because
Surrou
DamienFontaine commented on issue #536: Add support SurroundQueryParser to
jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-467100377
@osma Yes, the SurroundQueryParser doesn't implement
org.apache.lucene.queryparser.classic.QueryParser but all parsers can return a
org.
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-467156265
I changed what I'd done to use micrometer.. the creation of the required
objects is a bit tricky so for now I've just done it in the servle
seaninryan commented on a change in pull request #534: [WIP] Proof of concept
for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#discussion_r259990280
##
File path:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/ctl/ActionPrometheus.java
#
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-467941793
Hi all
I think I've got this to somewhere decent now
- I've got a core dependency on `micrometer-core` and have add a module in
e
afs opened a new pull request #537: JENA-1676 , JENA-1677: Make the commit step
more robust against external factors
URL: https://github.com/apache/jena/pull/537
[JENA-1676](https://issues.apache.org/jira/browse/JENA-1676) : TDB1
[JENA-1677](https://issues.apache.org/jira/browse/JENA
afs commented on issue #537: JENA-1676 , JENA-1677: Make the commit step more
robust against external factors
URL: https://github.com/apache/jena/pull/537#issuecomment-468435652
The normal processing of transactions is not affected by this PR, except
that there is code rewrite. What change
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261561114
##
File path:
jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/tran
rvesse commented on issue #537: JENA-1676 , JENA-1677: Make the commit step
more robust against external factors
URL: https://github.com/apache/jena/pull/537#issuecomment-468629410
NB - For other reviewers ignoring whitespace changes in the diff view
eliminating a bunch of non-changes
---
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261562315
##
File path:
jena-tdb/src/main/java/org/apache/jena/tdb/transaction/Transaction.ja
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261561694
##
File path:
jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/tran
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261561015
##
File path:
jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/tran
afs commented on a change in pull request #537: JENA-1676 , JENA-1677: Make the
commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261577326
##
File path:
jena-tdb/src/main/java/org/apache/jena/tdb/transaction/Transaction.java
afs commented on a change in pull request #537: JENA-1676 , JENA-1677: Make the
commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261577353
##
File path:
jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transac
afs commented on a change in pull request #537: JENA-1676 , JENA-1677: Make the
commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261578115
##
File path:
jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transac
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261641027
##
File path:
jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/tran
afs commented on a change in pull request #537: JENA-1676 , JENA-1677: Make the
commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261706207
##
File path:
jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transac
afs opened a new pull request #538: JENA-1678 : Update version of sjf4j
URL: https://github.com/apache/jena/pull/538
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
afs commented on issue #538: JENA-1678 : Update version of sjf4j
URL: https://github.com/apache/jena/pull/538#issuecomment-468961853
For CVE-2018-8088.
While Jena does not use this feature of slf4j, it helps if the jar
dependencies can be kept CVE-clean to assist users in environment
afs merged pull request #538: JENA-1678 : Update version of sjf4j
URL: https://github.com/apache/jena/pull/538
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
afs opened a new pull request #539: Comments cleanup; remove unused functions.
URL: https://github.com/apache/jena/pull/539
This PR is clean up that have accumulated on some of my local branches:
- add some javadoc on test classes
- miscellaneous comment typos
- rename a test cl
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-469011478
This is looking very interesting!
I'll look at the servlet when I'm at my development machine (not this coming
week). There are already free
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-469688552
Thanks for looking @afs :+1:
I'm not 100% clear on how all the packaging works. Be great if you can fire
it up next week and let me
afs merged pull request #539: Comments cleanup; remove unused functions.
URL: https://github.com/apache/jena/pull/539
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
afs merged pull request #537: JENA-1676 , JENA-1677: Make the commit step more
robust against external factors
URL: https://github.com/apache/jena/pull/537
This is an automated message from the Apache Git Service.
To respond
afs opened a new pull request #540: JENA-1680: Code formatting jena-dboe-*
URL: https://github.com/apache/jena/pull/540
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
afs opened a new pull request #541: JENA-1679: EBV values for Nan (double and
float)
URL: https://github.com/apache/jena/pull/541
This is an automated message from the Apache Git Service.
To respond to the message, please lo
afs merged pull request #540: JENA-1680: Code formatting jena-dboe-*
URL: https://github.com/apache/jena/pull/540
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
afs merged pull request #541: JENA-1679: EBV values for NaN (double and float)
URL: https://github.com/apache/jena/pull/541
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
afs opened a new pull request #542: JENA-1682: Update Apache fileupload version
URL: https://github.com/apache/jena/pull/542
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
afs merged pull request #542: JENA-1682: Update Apache fileupload version
URL: https://github.com/apache/jena/pull/542
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
afs opened a new pull request #543: JENA-1684: Insert server registrations into
uploaded model.
URL: https://github.com/apache/jena/pull/543
This is an automated message from the Apache Git Service.
To respond to the message
afs opened a new pull request #544: JENA-1685: Make code safer for
multithreaded use. Add comments.
URL: https://github.com/apache/jena/pull/544
This is an automated message from the Apache Git Service.
To respond to the mes
afs commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-474896463
All - where are we on this PR? Should it be merged, things being as they are
in Lucene, or are there specific changes to make?
And documentat
afs commented on a change in pull request #536: Add support SurroundQueryParser
to jena-text
URL: https://github.com/apache/jena/pull/536#discussion_r267706457
##
File path:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java
##
@@ -401,25 +402,38 @@ p
jmkeil opened a new pull request #545: JENA-1686: set Dyadic#getL() and
Dyadic#getR() return type to Graph
URL: https://github.com/apache/jena/pull/545
This is an automated message from the Apache Git Service.
To respond to
jmkeil opened a new pull request #546: JENA-1687: refine NodeFactory return
types
URL: https://github.com/apache/jena/pull/546
This is an automated message from the Apache Git Service.
To respond to the message, please log o
jmkeil opened a new pull request #547: JENA-1688: add methods Node#asBlank,
Node#asConcret, Node#asLiteral, Node#asURI, Node#asVariable
URL: https://github.com/apache/jena/pull/547
This is an automated message from the Apach
jmkeil opened a new pull request #548: JENA-1689: change type of
Polyadic#m_subGraphs from List to Set
URL: https://github.com/apache/jena/pull/548
…ted addition of graphs causing performance issues and unexpected behavior
in case of removal of graphs
-
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-475252662
This is looking good. I have it working in Fuseki Full (webapp form) and in
Fuseki Main (the more configurable servlet form) - details for running
Claudenw commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-475299369
*bump*
Does anyone have in their plans to look at this?
This is an au
Claudenw removed a comment on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-475299369
*bump*
Does anyone have in their plans to look at this?
This
afs commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-475429675
[JENA-1690](https://issues.apache.org/jira/browse/JENA-1690).
This is an automated m
afs merged pull request #543: JENA-1684: Insert server registrations into
uploaded model.
URL: https://github.com/apache/jena/pull/543
This is an automated message from the Apache Git Service.
To respond to the message, plea
afs merged pull request #544: JENA-1685: Make code safer for multithreaded use.
Add comments.
URL: https://github.com/apache/jena/pull/544
This is an automated message from the Apache Git Service.
To respond to the message,
afs merged pull request #545: JENA-1686: set Dyadic#getL() and Dyadic#getR()
return type to Graph
URL: https://github.com/apache/jena/pull/545
This is an automated message from the Apache Git Service.
To respond to the messa
afs commented on issue #545: JENA-1686: set Dyadic#getL() and Dyadic#getR()
return type to Graph
URL: https://github.com/apache/jena/pull/545#issuecomment-475598995
Thanks!
This is an automated message from the Apache Git Ser
afs edited a comment on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-475252662
This is looking good. I have it working in Fuseki Full (webapp form) and in
Fuseki Main (the more configurable servlet form) - details for
afs edited a comment on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-475252662
This is looking good. I have it working in Fuseki Full (webapp form) and in
Fuseki Main (the more configurable servlet form) - details for
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-475628676
Packaging
Looking in more detail ... the duplication of classes in the jena-prometheus
jar means the amount of new code in module `jen
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-475639789
Admin: [JENA-1691](https://issues.apache.org/jira/browse/JENA-1691).
This is an au
osma commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-475686611
@afs Thanks for the reminder
@DamienFontaine Any chance to refactor `parseQuery` just a little bit? There
is quite a lot of redundancy and re
xristy commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-475756380
Thanks for patience w/ my lack of response - slammed is all I can say.
In any event, I agree with Osma’s comments. After the merge, then we
afs commented on issue #548: JENA-1689: change type of Polyadic#m_subGraphs
from List to Set
URL: https://github.com/apache/jena/pull/548#issuecomment-476404449
What is the performance issue? Is itbecause a graph is added two or more
times?
MultiUnion.addGraph suppresses duplicate g
afs edited a comment on issue #548: JENA-1689: change type of
Polyadic#m_subGraphs from List to Set
URL: https://github.com/apache/jena/pull/548#issuecomment-476404449
What is the performance issue? Is it because a graph is added two or more
times?
MultiUnion.addGraph suppresses dup
1 - 100 of 1204 matches
Mail list logo