DamienFontaine commented on issue #536: Add support SurroundQueryParser to
jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-478899467
Is everyone agrees with the last @xristy version ?
This is an automated
xristy commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-479007515
+1 for last version
This is an automated message from the Apache Git Service.
To
afs opened a new pull request #551: JENA-1699: Clear deleted prefix from the
abbreviation map
URL: https://github.com/apache/jena/pull/551
This is an automated message from the Apache Git Service.
To respond to the message,
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479412885
@afs I've pushed a bunch of changes based off your feedback. I think it's
quite neat now apart from the creation of the _combined jar_ as
afs commented on issue #547: JENA-1688: add methods Node#asBlank,
Node#asConcret, Node#asLiteral, Node#asURI, Node#asVariable
URL: https://github.com/apache/jena/pull/547#issuecomment-476405301
This seem related to PR#546 and the discussion on
afs edited a comment on issue #548: JENA-1689: change type of
Polyadic#m_subGraphs from List to Set
URL: https://github.com/apache/jena/pull/548#issuecomment-476404449
What is the performance issue? Is it because a graph is added two or more
times?
MultiUnion.addGraph suppresses
afs commented on issue #548: JENA-1689: change type of Polyadic#m_subGraphs
from List to Set
URL: https://github.com/apache/jena/pull/548#issuecomment-476404449
What is the performance issue? Is itbecause a graph is added two or more
times?
MultiUnion.addGraph suppresses duplicate
jmkeil commented on issue #547: JENA-1688: add methods Node#asBlank,
Node#asConcret, Node#asLiteral, Node#asURI, Node#asVariable
URL: https://github.com/apache/jena/pull/547#issuecomment-476504397
Yes.
This is an automated
jmkeil closed pull request #548: JENA-1689: change type of Polyadic#m_subGraphs
from List to Set
URL: https://github.com/apache/jena/pull/548
This is an automated message from the Apache Git Service.
To respond to the
jmkeil commented on issue #548: JENA-1689: change type of Polyadic#m_subGraphs
from List to Set
URL: https://github.com/apache/jena/pull/548#issuecomment-476504576
You are right. Sorry.
This is an automated message from the
jmkeil closed pull request #547: JENA-1688: add methods Node#asBlank,
Node#asConcret, Node#asLiteral, Node#asURI, Node#asVariable
URL: https://github.com/apache/jena/pull/547
This is an automated message from the Apache Git
afs commented on a change in pull request #536: Add support SurroundQueryParser
to jena-text
URL: https://github.com/apache/jena/pull/536#discussion_r267706457
##
File path:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java
##
@@ -401,25 +402,38 @@
xristy commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-475756380
Thanks for patience w/ my lack of response - slammed is all I can say.
In any event, I agree with Osma’s comments. After the merge, then we
afs merged pull request #551: JENA-1699: Clear deleted prefix from the
abbreviation map
URL: https://github.com/apache/jena/pull/551
This is an automated message from the Apache Git Service.
To respond to the message,
rvesse commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-479810329
Merged, thanks again for the contribution
If you have chance to update the docs to mention this new capability that
would also be great -
rvesse merged pull request #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479940586
:+1: thanks @afs I've removed the new extras module.
I made the Prometheus provider the default for now - I think we may as well
afs edited a comment on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479922355
Licensing
@claudew - would you be able to help out with the L issues here?
The LICENSE and NOTICE for the combined
claudew commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479935807
@afs I think you meant @claudenw (Claude Warren), not @claudew (Claude
Whitmyer).
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479937698
@claudew - yes, sorry.
@Claudenw - would you be able to help out with the L issues here?
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479907207
@afs - w.r.t. licenses for `HdrHistogram` and `LatencyUtils` - what's
involved there? Downloading and copying in the `LICENCE` files from
afs edited a comment on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479922355
Licensing
@claudenw - would you be able to help out with the L issues here?
The LICENSE and NOTICE for the combined
rvesse commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-479984285
@DamienFontaine Thanks, doc changes added and visible on the staging site -
http://jena.staging.apache.org/documentation/query/text-query.html
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480177187
I've added a very basic test @afs
This is an automated message from the
afs commented on a change in pull request #534: [WIP] Proof of concept for
prometheus endpoint
URL: https://github.com/apache/jena/pull/534#discussion_r272574084
##
File path:
afs commented on a change in pull request #534: [WIP] Proof of concept for
prometheus endpoint
URL: https://github.com/apache/jena/pull/534#discussion_r272572323
##
File path:
jena-fuseki2/jena-fuseki-webapp/src/test/java/org/apache/jena/fuseki/TestMetrics.java
##
@@
afs commented on a change in pull request #534: [WIP] Proof of concept for
prometheus endpoint
URL: https://github.com/apache/jena/pull/534#discussion_r272513825
##
File path:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/metrics/SimpleMetricsProvider.java
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480213481
One test goes a long way!
This is an automated message from the Apache Git
seaninryan commented on a change in pull request #534: [WIP] Proof of concept
for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#discussion_r272536407
##
File path:
Claudenw commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480343725
I think we only need to add the licenses (there may be only one) to the
META-INF folder. We could do this by just copying the file(s) or
seaninryan commented on a change in pull request #534: [WIP] Proof of concept
for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#discussion_r272587966
##
File path:
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480372154
> Does this only go into the fuseki war
@Claudenw There are three binary artifacts.
Claudenw commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480515318
I was goingto add the licensing information but discovered that the
HdrHistogram and LatencyUtils are both licensed under creative commons
Claudenw commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480519092
I can not find a straight text version of
https://creativecommons.org/publicdomain/zero/1.0/legalcode so perhaps we
should just provide
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-47270
Sorted the 501 thing... will look at the tests tomorrow
This is an
afs commented on a change in pull request #549: JENA-1696: Control of jackson
versions. Update jsonld-java
URL: https://github.com/apache/jena/pull/549#discussion_r269946739
##
File path: pom.xml
##
@@ -57,11 +57,15 @@
0.10.0
ajs6f commented on a change in pull request #549: JENA-1696: Control of jackson
versions. Update jsonld-java
URL: https://github.com/apache/jena/pull/549#discussion_r270034237
##
File path: pom.xml
##
@@ -57,11 +57,15 @@
0.10.0
afs opened a new pull request #549: JENA-1696: Control of jackson versions.
Update jsonld-java
URL: https://github.com/apache/jena/pull/549
Expicit control the version of jackson.core so we can pick ones with
security fixes.
rvesse commented on a change in pull request #549: JENA-1696: Control of
jackson versions. Update jsonld-java
URL: https://github.com/apache/jena/pull/549#discussion_r269945012
##
File path: pom.xml
##
@@ -57,11 +57,15 @@
0.10.0
afs commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-478237677
Hi all - where are we on this PR?
If there are some approvals from @xristy / @osma / other Jena committers, I
can go the merge.
afs merged pull request #550: Updates for libthrift and commons-compress
URL: https://github.com/apache/jena/pull/550
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xristy commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-478257773
The switch seems not correct yet:
> case "AnalyzingQueryParser":
> if (qp == null) qp = new
afs opened a new pull request #550: Updates for libthrift and commons-compress
URL: https://github.com/apache/jena/pull/550
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rvesse commented on a change in pull request #549: JENA-1696: Control of
jackson versions. Update jsonld-java
URL: https://github.com/apache/jena/pull/549#discussion_r269945012
##
File path: pom.xml
##
@@ -57,11 +57,15 @@
0.10.0
afs commented on a change in pull request #549: JENA-1696: Control of jackson
versions. Update jsonld-java
URL: https://github.com/apache/jena/pull/549#discussion_r270059867
##
File path: pom.xml
##
@@ -57,11 +57,15 @@
0.10.0
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-477652161
Thanks @afs great feedback. These all make sense I think - I'll start
working through them
afs merged pull request #549: JENA-1696: Control of jackson versions. Update
jsonld-java
URL: https://github.com/apache/jena/pull/549
This is an automated message from the Apache Git Service.
To respond to the message,
xristy commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-478621634
I also had second thoughts about the needless instantiation and almost
edited the previous as follows:
```java
private Query
osma commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-478627458
Either version is fine.
This is an automated message from the Apache Git Service.
osma commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-478569188
I still don't get the `switch` block. The control flow seems just...messy,
with all the `if` checks and sometimes implicitly falling through to the
xristy commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-478607770
@osma cleaner, and I thought it was a good idea to alert users that they are
using a deprecated query parser if they refer to
osma commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-478613166
I'm okay with @xristy's version, although QueryParser is needlessly
instantiated in some cases. But I'd choose clear code over premature
Claudenw commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480739946
After reviewing the licensing documentation in the libraries and Apache's
policy on public domain licenses (
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480751661
It is a ASF policy that NOTICE is minimal. This is to avoid simply passing
the problems onto downstream consumers, because NOTICE is legal
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-480602750
A link in LICENSE is better and acceptable these days. HdrHistogram and
LatencyUtils binaries artifacts themselves don't include a LICENSE or
seaninryan commented on a change in pull request #534: [WIP] Proof of concept
for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#discussion_r259990280
##
File path:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/ctl/ActionPrometheus.java
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-467156265
I changed what I'd done to use micrometer.. the creation of the required
objects is a bit tricky so for now I've just done it in the
DamienFontaine commented on issue #536: Add support SurroundQueryParser to
jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-467100377
@osma Yes, the SurroundQueryParser doesn't implement
org.apache.lucene.queryparser.classic.QueryParser but all parsers can return a
afs opened a new pull request #537: JENA-1676 , JENA-1677: Make the commit step
more robust against external factors
URL: https://github.com/apache/jena/pull/537
[JENA-1676](https://issues.apache.org/jira/browse/JENA-1676) : TDB1
afs commented on issue #537: JENA-1676 , JENA-1677: Make the commit step more
robust against external factors
URL: https://github.com/apache/jena/pull/537#issuecomment-468435652
The normal processing of transactions is not affected by this PR, except
that there is code rewrite. What
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-467941793
Hi all
I think I've got this to somewhere decent now
- I've got a core dependency on `micrometer-core` and have add a module in
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261561114
##
File path:
rvesse commented on issue #537: JENA-1676 , JENA-1677: Make the commit step
more robust against external factors
URL: https://github.com/apache/jena/pull/537#issuecomment-468629410
NB - For other reviewers ignoring whitespace changes in the diff view
eliminating a bunch of non-changes
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261562315
##
File path:
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261561694
##
File path:
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261561015
##
File path:
afs commented on a change in pull request #537: JENA-1676 , JENA-1677: Make the
commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261577353
##
File path:
afs commented on a change in pull request #537: JENA-1676 , JENA-1677: Make the
commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261577326
##
File path:
jena-tdb/src/main/java/org/apache/jena/tdb/transaction/Transaction.java
afs commented on a change in pull request #537: JENA-1676 , JENA-1677: Make the
commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261706207
##
File path:
afs commented on issue #538: JENA-1678 : Update version of sjf4j
URL: https://github.com/apache/jena/pull/538#issuecomment-468961853
For CVE-2018-8088.
While Jena does not use this feature of slf4j, it helps if the jar
dependencies can be kept CVE-clean to assist users in
afs merged pull request #538: JENA-1678 : Update version of sjf4j
URL: https://github.com/apache/jena/pull/538
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
afs opened a new pull request #538: JENA-1678 : Update version of sjf4j
URL: https://github.com/apache/jena/pull/538
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-466044561
micrometer.io looks interesting.
Have I understood micrometer correctly? The Fuseki counters/stats/...
implement in the micrometer
DamienFontaine opened a new pull request #536: Add support SurroundQueryParser
to jena-text
URL: https://github.com/apache/jena/pull/536
PR to add [SurroundQueryParser
](https://lucene.apache.org/core/7_1_0/queryparser/org/apache/lucene/queryparser/surround/parser/QueryParser.html)
in
ajs6f commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-466045612
It is like Dexx in that it is persistent (aka functional) collections
library, and it is not like Dexx in that Dexx intends to exclusively port
ajs6f commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-466077065
Yep, [looks
like](https://lists.apache.org/list.html?dev@jena.apache.org:gte=1d:pcollections)
we did look at PCollections, and the performance
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-466159232
Yes - we have to allow "bring their own" adapter, and may provide one
specific one (our own simple custom one?).
Is there any work around
ajs6f commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-465644411
Ok, cool. Given the small amount of code here, I don't really have any
problem with supporting one particular framework (especially since I
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-465642833
I'm not 100% sure @ajs6f - but I think that it probably is a propriety
Prometheus format. It's described
ajs6f commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-465620789
Is this endpoint usable by software other than Prometheus? I mean to ask;
are there other monitoring suites that could accept this data or would
grahamtriggs commented on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-465710002
@afs Ooops! I've added the Apache header to both of those files.
This is an automated message from the
afs merged pull request #535: JENA-1674: Don't sign extend Float.floatToIntBits.
URL: https://github.com/apache/jena/pull/535
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rvesse commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-466525608
Pinging @osma @xristy
Not that it's a blocker for this PR but anytime I see this kind of code
pattern in Jena (and Java in general) I
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-469688552
Thanks for looking @afs :+1:
I'm not 100% clear on how all the packaging works. Be great if you can fire
it up next week and let me
afs opened a new pull request #539: Comments cleanup; remove unused functions.
URL: https://github.com/apache/jena/pull/539
This PR is clean up that have accumulated on some of my local branches:
- add some javadoc on test classes
- miscellaneous comment typos
- rename a test
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-469011478
This is looking very interesting!
I'll look at the servlet when I'm at my development machine (not this coming
week). There are already
afs commented on a change in pull request #537: JENA-1676 , JENA-1677: Make the
commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261578115
##
File path:
rvesse commented on a change in pull request #537: JENA-1676 , JENA-1677: Make
the commit step more robust against external factors
URL: https://github.com/apache/jena/pull/537#discussion_r261641027
##
File path:
osma commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-467075475
I think it's a pity this PR merges the two methods into one, making the code
a bit messier and more difficult to understand. Is that because
afs merged pull request #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to
afs opened a new pull request #535: JENA-1674: Don't sign extend
Float.floatToIntBits.
URL: https://github.com/apache/jena/pull/535
Add TestFloatNode for value-based testing of FloatNode.
Use canonical NaN for packing Double.NaN.
afs commented on issue #535: JENA-1674: Don't sign extend Float.floatToIntBits.
URL: https://github.com/apache/jena/pull/535#issuecomment-465788847
Sorry @rvesse - discovered I'd been running the wrong test suite and the
original PR was not passing. Caught thanks to TravisCI. The only
afs merged pull request #542: JENA-1682: Update Apache fileupload version
URL: https://github.com/apache/jena/pull/542
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
afs merged pull request #540: JENA-1680: Code formatting jena-dboe-*
URL: https://github.com/apache/jena/pull/540
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
afs merged pull request #541: JENA-1679: EBV values for NaN (double and float)
URL: https://github.com/apache/jena/pull/541
This is an automated message from the Apache Git Service.
To respond to the message, please log on
afs opened a new pull request #542: JENA-1682: Update Apache fileupload version
URL: https://github.com/apache/jena/pull/542
This is an automated message from the Apache Git Service.
To respond to the message, please log on
afs opened a new pull request #540: JENA-1680: Code formatting jena-dboe-*
URL: https://github.com/apache/jena/pull/540
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
afs opened a new pull request #541: JENA-1679: EBV values for Nan (double and
float)
URL: https://github.com/apache/jena/pull/541
This is an automated message from the Apache Git Service.
To respond to the message, please
afs merged pull request #539: Comments cleanup; remove unused functions.
URL: https://github.com/apache/jena/pull/539
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
afs merged pull request #537: JENA-1676 , JENA-1677: Make the commit step more
robust against external factors
URL: https://github.com/apache/jena/pull/537
This is an automated message from the Apache Git Service.
To
1 - 100 of 1191 matches
Mail list logo
