[jira] [Updated] (LENS-1183) Optimize multiple acquire calls on

[ https://issues.apache.org/jira/browse/LENS-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1183: --- Summary: Optimize multiple acquire calls on (was: Optimize multiple acquire calls on LensSessionImpl

[jira] [Updated] (LENS-1183) Optimize multiple acquire

[ https://issues.apache.org/jira/browse/LENS-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1183: --- Summary: Optimize multiple acquire (was: Optimize multiple acquire calls on ) > Optimize multi

[jira] [Updated] (LENS-1183) Optimize multiple acquire calls on

[ https://issues.apache.org/jira/browse/LENS-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1183: --- Description: 1. In LensSessionImpl if acquireCount.incrementAndGet() >1 , no need to exec

[jira] [Commented] (LENS-1168) Isolate submissions for each driver

[ https://issues.apache.org/jira/browse/LENS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323738#comment-15323738 ] Puneet Gupta commented on LENS-1168: +1 for approach 2. Query submitter thread can use a pool

Re: Review Request 47593: LENS-1148 : Throttling tests to regression

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47593/#review136629 --- Ship it! Ship It! - Puneet Gupta On June 8, 2016, 8:43 a.m

Re: Review Request 47593: LENS-1148 : Throttling tests to regression

gression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 519) <https://reviews.apache.org/r/47593/#comment201669> can we add a final else fail("Unexpected Queue"). - Puneet Gupta On Ju

Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for inmemory queries

close on driver 2. Process waiting queries - Puneet Gupta On June 7, 2016, 5:52 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47593: LENS-1148 : Throttling tests to regression

(lines 509 - 512) <https://reviews.apache.org/r/47593/#comment201254> Can we also assert totalrunning <= maxConcurrent Are we adding usercost based throttling tests cases separately ? - Puneet Gupta On June 2,

Re: Review Request 47593: LENS-1148 : Throttling tests to regression

ed value for priority. lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 292 - 295) <https://reviews.apache.org/r/47593/#comment201247> Should we remove this check ? queued and running list is empty already . - Puneet Gupta On June

Re: Review Request 47593: LENS-1148 : Throttling tests to regression

> On May 20, 2016, 3:17 a.m., Puneet Gupta wrote: > > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java, > > line 146 > > <https://reviews.apache.org/r/47593/diff/1/?file=1387941#file1387941line146> > > > > It may pick

Re: Review Request 47593: LENS-1148 : Throttling tests to regression

cases for the same reason. - Puneet Gupta On June 2, 2016, 8:40 a.m., Archana H wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Updated] (LENS-1163) Description of "lens.driver.jdbc.get.connection.timeout" is wrong

[ https://issues.apache.org/jira/browse/LENS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1163: --- Attachment: lens-1163.patch > Description of "lens.driver.jdbc.get.connection.timeout&q

[jira] [Commented] (LENS-1157) Execute with timeout fails to read metadata when user requests streamed results

[ https://issues.apache.org/jira/browse/LENS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313943#comment-15313943 ] Puneet Gupta commented on LENS-1157: https://reviews.apache.org/r/48201 > Execute with timeout fa

[jira] [Updated] (LENS-1157) Execute with timeout fails to read metadata when user requests streamed results

[ https://issues.apache.org/jira/browse/LENS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1157: --- Attachment: lens-1157.01.patch > Execute with timeout fails to read metadata when user reque

[jira] [Commented] (LENS-1157) Execute with timeout fails to read metadata when user requests streamed results

[ https://issues.apache.org/jira/browse/LENS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313940#comment-15313940 ] Puneet Gupta commented on LENS-1157: Taking patch from reviewboard and attaching > Exec

[jira] [Updated] (LENS-1157) Execute with timeout fails to read metadata when user requests streamed results

[ https://issues.apache.org/jira/browse/LENS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1157: --- Status: Patch Available (was: In Progress) > Execute with timeout fails to read metadata when u

[jira] [Commented] (LENS-1165) Separate client for query submission from other thrift operations

[ https://issues.apache.org/jira/browse/LENS-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313936#comment-15313936 ] Puneet Gupta commented on LENS-1165: +1 > Separate client for query submission from other thr

[jira] [Commented] (LENS-1158) Thread names with hive2 build are growing huge

[ https://issues.apache.org/jira/browse/LENS-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311891#comment-15311891 ] Puneet Gupta commented on LENS-1158: Committed. Thanks [~prongs] > Thread names with hive2 bu

[jira] [Updated] (LENS-1158) Thread names with hive2 build are growing huge

[ https://issues.apache.org/jira/browse/LENS-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1158: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Thread names with hive2 bu

Re: Review Request 48071: LENS-1160: classloader getting closed on lens session close.

/DatabaseResourceService.java (line 51) <https://reviews.apache.org/r/48071/#comment200806> Should we extend URL class loader instead and call it UncloseableURLClassLoader ? - Puneet Gupta On May 31, 2016, 2:35 p.m., Rajat Khandelwal

Re: Review Request 47776: LENS-1151: More info on Queries moving between waiting and queued queries data structures

/QueryExecutionServiceImpl.java (line 3133) <https://reviews.apache.org/r/47776/#comment200805> is it possible to make do with the other log ? This can be inferred based on "query not allowed to launch" and "query lauched". - Puneet Gupta On May 31, 2016, 2:39 p.

Re: Review Request 48071: LENS-1160: classloader getting closed on lens session close.

oaders. - Puneet Gupta On May 31, 2016, 10:50 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 48007: LENS-1158: Thread names with hive2 build are growing huge

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48007/#review135621 --- Ship it! Ship It! - Puneet Gupta On May 28, 2016, 10:43 a.m

Re: Review Request 47450: Lens-1143

/TestDuplicateQueries.java (line 180) <https://reviews.apache.org/r/47450/#comment200512> can we close this new session also ? We have a max limit on open sessions. - Puneet Gupta On May 26, 2016, 11:17 a.m., Lavkesh Lahngir

[jira] [Created] (LENS-1163) Description of "lens.driver.jdbc.get.connection.timeout" is wrong

Puneet Gupta created LENS-1163: -- Summary: Description of "lens.driver.jdbc.get.connection.timeout" is wrong Key: LENS-1163 URL: https://issues.apache.org/jira/browse/LENS-1163 Project: A

Re: Review Request 47777: Added Weighted selector

> On May 25, 2016, 5:54 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightCostSelector.java, > > lines 46-48 > > <https://reviews.apache.org/r/4/diff/1/?file=1392428#file1392428line46> > > > > B

Re: Review Request 47777: Added Weighted selector

> On May 25, 2016, 6:27 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightCostSelector.java, > > line 62 > > <https://reviews.apache.org/r/4/diff/1/?file=1392428#file1392428line62> > > > > i

Re: Review Request 47450: Lens-1143

like we are using for opening session ? OR .. we can use the util class RestAPITestUtil.execute() if rest calls are really required. we can follow the same elsewwhere. - Puneet Gupta On May 24, 2016, 9:56 a.m., Lav

Re: Review Request 47777: Added Weighted selector

91> if a driver has "lens.driver.driverratio" not set, should it be added to eligible drivers ? We need to handle the case where there are say 3 drivers which have have the minimum cost, and only 2 have "lens.driver.driverratio" set. - Puneet Gupta

Re: Review Request 47777: Added Weighted selector

t;https://reviews.apache.org/r/4/#comment199590> AbstractQueryContext.java can be removed form chnage list. See no chnages here - Puneet Gupta On May 24, 2016, 3:35 p.m., Anshul Gupta wrote: > > --- > This is an automatically generate

[jira] [Assigned] (LENS-266) Resultset not honouring index and size params

[ https://issues.apache.org/jira/browse/LENS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta reassigned LENS-266: - Assignee: Puneet Gupta > Resultset not honouring index and size par

Re: Review Request 47121: LENS-1010: Make LensClient implement java.lang.Closable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47121/#review134521 --- Ship it! Ship It! - Puneet Gupta On May 21, 2016, 8:33 a.m

Re: Review Request 47121: LENS-1010: Make LensClient implement java.lang.Closable

/LensServices.java (line 144) <https://reviews.apache.org/r/47121/#comment199141> This is not required after Lens-957. GenericExceptionMapper should take care of this. Should we remove all usages form form MetastoreResource.java ? - Puneet Gupta On May 21, 2016, 8:33 a.m., Rajat Khandelwal

[jira] [Commented] (LENS-266) Resultset not honouring index and size params

[ https://issues.apache.org/jira/browse/LENS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296272#comment-15296272 ] Puneet Gupta commented on LENS-266: --- The current get result API

[jira] [Issue Comment Deleted] (LENS-266) Resultset not honouring index and size params

[ https://issues.apache.org/jira/browse/LENS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-266: -- Comment: was deleted (was: The current get result API "org.apache.lens.server.query.QueryServiceRes

[jira] [Commented] (LENS-266) Resultset not honouring index and size params

[ https://issues.apache.org/jira/browse/LENS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296268#comment-15296268 ] Puneet Gupta commented on LENS-266: --- The current get result API

[jira] [Updated] (LENS-1140) Merging session jar with DB resources fails if session jar is not HDFS

[ https://issues.apache.org/jira/browse/LENS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1140: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Merging session jar with

[jira] [Commented] (LENS-1140) Merging session jar with DB resources fails if session jar is not HDFS

[ https://issues.apache.org/jira/browse/LENS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296151#comment-15296151 ] Puneet Gupta commented on LENS-1140: Committed. Thanks [~amareshwari] > Merging session jar with

Re: [ANNOUNCE] New Apache Lens PMC member : Deepak Barr

Congrats Deepak !! On Mon, May 23, 2016 at 2:24 PM, archana h wrote: > Congratualtions Deepak..:) > > On Mon, May 23, 2016 at 1:45 PM, Raghavendra Singh < > raghavendra.si...@inmobi.com> wrote: > >> Congrats Deepak!! >> >> On Mon, May 23, 2016 at 1:42 PM, Amareshwari

[jira] [Commented] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296068#comment-15296068 ] Puneet Gupta commented on LENS-1032: Property Name is "lens.query.cancel.on.timeout" &g

Re: [ANNOUNCE] New Apache Lens committer : Archana H

Congrats Archana !! Thanks, Puneet Gupta On Mon, May 23, 2016 at 11:10 AM, Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > The Apache Lens PMC has asked Archana H to become Lens committer. We are > pleased to announce that she has accepted. > > Being a commit

Re: Review Request 47593: Throttling tests to regression

727> Should we wait or should we kill the queries to reduce test run time ? - Puneet Gupta On May 19, 2016, 2:26 p.m., Archana H wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 47407: LENS-1140 : Fix loading jar in HDFS as a session jar with db resources available.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47407/#review133915 --- Ship it! Ship It! - Puneet Gupta On May 19, 2016, 5:15 a.m

Re: Review Request 47450: Lens-1143

198284> is @Test annotation required? Please check - Puneet Gupta On May 17, 2016, 11:53 a.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 47407: LENS-1140 : Fix loading jar in HDFS as a session jar with db resources available.

ll fail fast which seems correct. Just re-conforming. - Puneet Gupta On May 16, 2016, 9:09 a.m., Amareshwari Sriramadasu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 47174: LENS-904: Session close should not result in queued query failures

/LensSessionImpl.java <https://reviews.apache.org/r/47174/#comment197636> Should we retain this Info Log ? It looks helpful even generally. log.info("Adding {} as an active query for session {}", queryHandle, this); Same for removeFromActiveQueries() - Puneet G

Re: Review Request 47174: LENS-904: Session close should not result in queued query failures

nceFromSession.java (line 173) <https://reviews.apache.org/r/47174/#comment197630> +1 for testing re-start secanrio - Puneet Gupta On May 15, 2016, 7:19 p.m., Rajat Khandelwal wrote: > > --- >

Re: Review Request 47301: LENS-1141 : Adding user cost ceiling tests

s.java (line 353) <https://reviews.apache.org/r/47301/#comment197332> Not sure if this will be true always. This query might be SUCCESSFUL. - Puneet Gupta On May 12, 2016, 12:05 p.m., Archana H wrote: > > --- > This is an au

Re: Review Request 47007: Return same handle for repeated query from same user

/src/test/resources/lens-site.xml). Many test cases fire the same query in same session and rely on it to create multiple queries in server. - Puneet Gupta On May 12, 2016, 10:05 a.m., Lavkesh Lahngir wrote

[jira] [Updated] (LENS-1019) Return same handle for repeated query from same user

[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1019: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Return same handle for repea

[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user

[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281489#comment-15281489 ] Puneet Gupta commented on LENS-1019: Committed. Thanks [~lavkesh] > Return same handle for repea

[jira] [Commented] (LENS-957) Lens CLI to throw exact caused exception instead of showing generic Lens error

[ https://issues.apache.org/jira/browse/LENS-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281464#comment-15281464 ] Puneet Gupta commented on LENS-957: --- Committed. Thanks [~amareshwari] > Lens CLI to throw exact cau

[jira] [Commented] (LENS-1041) Test case org.apache.lens.client.TestLensClient.testTimeout Failing intermittently

[ https://issues.apache.org/jira/browse/LENS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281404#comment-15281404 ] Puneet Gupta commented on LENS-1041: Pre-commit build passed https://builds.apache.org/view/PreCommit

Re: Review Request 43765: LENS-957 : Add GenericExceptionMapper to map all non LensException as well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43765/#review132866 --- Ship it! Ship It! - Puneet Gupta On May 12, 2016, 9:27 a.m

Re: Review Request 47007: Return same handle for repeated query from same user

> On May 12, 2016, 6:08 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 1847 > > <https://reviews.apache.org/r/47007/diff/7/?file=1379662#file1379662line1847> > > > > Sy

[jira] [Updated] (LENS-1038) Streaming and other session related tests

[ https://issues.apache.org/jira/browse/LENS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1038: --- Fix Version/s: 2.6 > Streaming and other session related te

[jira] [Updated] (LENS-1041) Test case org.apache.lens.client.TestLensClient.testTimeout Failing intermittently

[ https://issues.apache.org/jira/browse/LENS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1041: --- Attachment: lens-1041.01.patch > Test case org.apache.lens.client.TestLensClient.testTimeout Fail

[jira] [Commented] (LENS-1041) Test case org.apache.lens.client.TestLensClient.testTimeout Failing intermittently

[ https://issues.apache.org/jira/browse/LENS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281349#comment-15281349 ] Puneet Gupta commented on LENS-1041: Taking patch from reviewboard and attaching > Test c

[jira] [Updated] (LENS-1041) Test case org.apache.lens.client.TestLensClient.testTimeout Failing intermittently

[ https://issues.apache.org/jira/browse/LENS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1041: --- Status: Patch Available (was: In Progress) > Test c

Review Request 47298: LENS-1041: Test case org.apache.lens.client.TestLensClient.testTimeout Failing intermittently

Thanks, Puneet Gupta

[jira] [Work started] (LENS-1041) Test case org.apache.lens.client.TestLensClient.testTimeout Failing intermittently

[ https://issues.apache.org/jira/browse/LENS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1041 started by Puneet Gupta. -- > Test case org.apache.lens.client.TestLensClient.testTimeout Fail

Re: Review Request 47121: LENS-1010: Make LensClient implement java.lang.Closable

/lens/client/LensConnection.java (line 224) <https://reviews.apache.org/r/47121/#comment197125> Better to remove these retries. The cause of this failure Lens-1041 is being fixed. - Puneet Gupta On May 12, 2016, 7:28 a.m., Rajat Khandelwal

[jira] [Issue Comment Deleted] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1032: --- Comment: was deleted (was: Incremental patch for help doc required) > Add option to kill the qu

[jira] [Updated] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1032: --- Status: Patch Available (was: Reopened) > Add option to kill the query on timeout api on time

[jira] [Updated] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1032: --- Attachment: lens-1032.v4.patch Incremental patch. Updated help doc client-config.apt which was missed

[jira] [Reopened] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta reopened LENS-1032: Incremental patch for help doc required > Add option to kill the query on timeout api on time

Re: Review Request 43765: LENS-957 : Add GenericErrorMapper to map all non LensException

> On May 12, 2016, 7:15 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java, > > line 128 > > <https://reviews.apache.org/r/43765/diff/3/?file=1379717#file1379717line128> > > > > + for mov

Re: Review Request 43765: LENS-957 : Add GenericErrorMapper to map all non LensException

<https://reviews.apache.org/r/43765/#comment197106> + for moving this to exception mapper. The usage is much simpler now and handled by the framework interanlly. - Puneet Gupta On May 11, 2016, 3:27 p.m., Amareshwari Srira

Re: Review Request 47007: Return same handle for repeated query from same user

/lens/server/query/QueryExecutionServiceImpl.java (line 1847) <https://reviews.apache.org/r/47007/#comment197082> Syncronize on sessionHandle also required. Please check. - Puneet Gupta On May 11, 2016, 2:26 p.m., Lavkesh Lahngir

Re: Review Request 47121: LENS-1010: Make LensClient implement java.lang.Closable

t; When are we expecting this exception? lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 236) <https://reviews.apache.org/r/47121/#comment197059> Will this code flow be reached or will it stop at if (processingException != null) instead in this case

Re: Review Request 47180: LENS-1038 : Streaming and other session related tests

e/lens/regression/ITStreamingTests.java (line 121) <https://reviews.apache.org/r/47180/#comment196937> Should we check instead assertTrue(queryRes instanceof PersistentQueryResult) Same for line 166 - Puneet Gupta On May 11, 2016, 8:29 a.m., Arc

[jira] [Created] (LENS-1041) Test case org.apache.lens.client.TestLensClient.testTimeout Failing intermittently

Puneet Gupta created LENS-1041: -- Summary: Test case org.apache.lens.client.TestLensClient.testTimeout Failing intermittently Key: LENS-1041 URL: https://issues.apache.org/jira/browse/LENS-1041 Project

[jira] [Updated] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1032: --- Attachment: lens-1032.03.patch > Add option to kill the query on timeout api on time

Re: Review Request 47159: LENS-1032: Add option to kill the query on timeout api on timeout

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47159/#review132612 --- On May 11, 2016, 12:05 p.m., Puneet Gupta wrote: > > ---

[jira] [Assigned] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta reassigned LENS-1032: -- Assignee: Puneet Gupta > Add option to kill the query on timeout api on time

[jira] [Updated] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1032: --- Status: Patch Available (was: Open) > Add option to kill the query on timeout api on time

[jira] [Commented] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280022#comment-15280022 ] Puneet Gupta commented on LENS-1032: Taking patch from reviewboard and attaching > Add option to k

Re: Review Request 47159: LENS-1032: Add option to kill the query on timeout api on timeout

:46.852s Thanks, Puneet Gupta

Re: Review Request 47007: Return same handle for repeated query from same user

called on LensSessionImpl. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1847) <https://reviews.apache.org/r/47007/#comment196907> First session check is not required - Puneet Gupta O

Re: Review Request 47159: LENS-1032: Add option to kill the query on timeout api on timeout

] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 32:46.852s Thanks, Puneet Gupta

Re: Review Request 47159: LENS-1032: Add option to kill the query on timeout api on timeout

-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280 src/site/apt/admin/session-config.apt 206d6a4 Diff: https://reviews.apache.org/r/47159/diff/ Testing --- org.apache.lens.server.query.TestQueryService#testAutoCancelOnTimeOut : Pass Thanks, Puneet Gupta

Re: Review Request 47159: LENS-1032: Add option to kill the query on timeout api on timeout

is property false as of now. - Puneet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47159/#review132406 ------- On May

Re: Review Request 47121: LENS-1010: Make LensClient implement java.lang.Closable

> On May 10, 2016, 2:52 a.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/LensConnection.java, line > > 214 > > <https://reviews.apache.org/r/47121/diff/2/?file=1376577#file1376577line214> > > > > should we have only one p

Re: Review Request 47159: LENS-1032: Add option to kill the query on timeout api on timeout

fd6bae3de365cb93710decc9ec9d786406c7b8cc src/site/apt/admin/session-config.apt 206d6a4ca54cb22d4d1261215bd3f77675911a65 Diff: https://reviews.apache.org/r/47159/diff/ Testing --- org.apache.lens.server.query.TestQueryService#testAutoCancelOnTimeOut : Pass Thanks, Puneet Gupta

Re: Review Request 47007: Return same handle for repeated query from same user

time for this test case ? Is it possible to optimize to reduce the run time Instead of DeferredPersistentResultFormatter we can also use QueryExecutionServiceImpl#pauseQuerySubmitter. This will make sure query does not finish execution. See if t

Re: Review Request 47121: LENS-1010: Make LensClient implement java.lang.Closable

/LensConnection.java (line 214) <https://reviews.apache.org/r/47121/#comment196546> should we have only one public close*() method ? Two methods can be confusing for end user. If we need to return APIResult, we can not adhere to Closeable Interface - Puneet Gupta On May 9, 2016, 3:18 p.m.,

Re: Review Request 47007: Return same handle for repeated query from same user

th debugging. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1799) <https://reviews.apache.org/r/47007/#comment196433> We need hash of Configuration( LensConf will not have session info) - Puneet Gupta On May 9, 2016, 9:41 a.m., Lav

[jira] [Commented] (LENS-1036) Lens Server Installation and Run should not require user to install Hive

[ https://issues.apache.org/jira/browse/LENS-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276021#comment-15276021 ] Puneet Gupta commented on LENS-1036: Can we per-bundle hive jars with lens-server ? > Lens Ser

[jira] [Created] (LENS-1036) Lens Server Installation and Run should not require user to install Hive

Puneet Gupta created LENS-1036: -- Summary: Lens Server Installation and Run should not require user to install Hive Key: LENS-1036 URL: https://issues.apache.org/jira/browse/LENS-1036 Project: Apache

[jira] [Commented] (LENS-1029) lens-server-snapshotter died in one of the scenarios

[ https://issues.apache.org/jira/browse/LENS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276011#comment-15276011 ] Puneet Gupta commented on LENS-1029: https://reviews.apache.org/r/46968/ > lens-server-snapshot

[jira] [Updated] (LENS-1029) lens-server-snapshotter died in one of the scenarios

[ https://issues.apache.org/jira/browse/LENS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1029: --- Attachment: lens-1029.v2.patch > lens-server-snapshotter died in one of the scenar

Re: Review Request 46968: LENS-1029: lens-server-snapshotter died in one of the scenarios

Integers are persisted using writeObject and can be read back as well. - Did some local testing to check graceful shutdown of ScheduledExecutorService Don't think we need a test cases for above two cince its supported out of box by java Thanks, Puneet Gupta

Re: Review Request 46968: LENS-1029: lens-server-snapshotter died in one of the scenarios

> On May 4, 2016, 11:50 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/LensServices.java, lines > > 313-314 > > <https://reviews.apache.org/r/46968/diff/1/?file=1370653#file1370653line313> > > > > Why i

Re: Review Request 46968: LENS-1029: lens-server-snapshotter died in one of the scenarios

> > > > > > > With this change done, we are coupling them. If > > lens.server.recover.onrestart is true, then lens.server.restart.enabled > > should also be true. > > > > I'm fine with the change. But just call

Re: Review Request 46968: LENS-1029: lens-server-snapshotter died in one of the scenarios

wait counter? Shouldnt we simple join the > > thread and wait for it to completely write the persist state? > > Puneet Gupta wrote: > serverSnapshotScheduler.shutdown() initiates a graceful shutdown but one > needs to wait for the shutdown using awaitTermination() which takes

Re: Review Request 46968: LENS-1029: lens-server-snapshotter died in one of the scenarios

, Puneet Gupta

[jira] [Commented] (LENS-1032) Add option to kill the query on timeout api on timeout

[ https://issues.apache.org/jira/browse/LENS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272108#comment-15272108 ] Puneet Gupta commented on LENS-1032: Update Default value of lens.query.kill.on.timeou = true

[jira] [Created] (LENS-1032) Add option to kill the query on timeout api on timeout

Puneet Gupta created LENS-1032: -- Summary: Add option to kill the query on timeout api on timeout Key: LENS-1032 URL: https://issues.apache.org/jira/browse/LENS-1032 Project: Apache Lens Issue

Re: Review Request 46968: LENS-1029: lens-server-snapshotter died in one of the scenarios

eviews.apache.org/r/46968/#review131792 ------- On May 4, 2016, 12:03 p.m., Puneet Gupta wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 46968: LENS-1029: lens-server-snapshotter died in one of the scenarios

of ScheduledExecutorService Don't think we need a test cases for above two cince its supported out of box by java Thanks, Puneet Gupta

<    1   2   3   4   5   6   7   8   9   10   >