subject:"OFBIZ Manufacturing"

Re: Getting Started with Apache OFBiz Manufacturing in 5 Easy Steps

2019-07-01 Thread Paul Foxworthy

>
> > > On Tue, Jun 25, 2019 at 2:34 AM Sharan Foga  wrote:
> > >
> > >> Swapnil has already followed up with me and I am happy to release the
> > >> copyright for this tutorial document and fully contribute it back to
> > under
> > >> ASL v2 so the project so the community is free to use, change or
> update
> > it
> > >> as needed.
>

Thanks Sharan, that's great news.

Cheers

Paul Foxworthy

-- 
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Australia

Phone: +61 3 9585 6788
Web: http://www.coherentsoftware.com.au/
Email: i...@coherentsoftware.com.au

Re: Getting Started with Apache OFBiz Manufacturing in 5 Easy Steps

2019-06-25 Thread Aditya Sharma

Thanks Sharan. It will definitely add a lot of value.

Thanks everyone involved in the effort.

Thanks and regards,
Aditya Sharma

On Tue, Jun 25, 2019 at 2:58 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Sharan, and thanks to All involved in this effort!
>
> Jacques
>
> Le 25/06/2019 à 06:50, Swapnil M Mane a écrit :
> > Thanks so much, Sharan for this valuable contribution, highly
> appreciated!!
> >
> > @Team,
> > We are making slight changes (creating confluence document from PDF,
> > updating the screenshots, etc.) in original PDF document to sync with the
> > latest OFBiz release.
> > Here is the initial version of improved document [1], currently in WIP,
> > will be completed soon.
> > (Thanks to Archana Asthana for participating in the effort of syncing the
> > document with the latest release)
> >
> > [1] https://cwiki.apache.org/confluence/x/Pw3HBg
> >
> >
> > - Best Regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
> >
> >
> >
> > On Tue, Jun 25, 2019 at 2:34 AM Sharan Foga  wrote:
> >
> >> Hi All
> >>
> >> I saw a note about the Getting Started with Apache OFBiz Manufacturing &
> >> MRP in 5 Easy Steps tutorial document that I wrote a while ago that is
> >> being added to the wiki as individual pages. The original pdf tutorial
> >> document I contributed included a copyright notice which is probably
> why my
> >> name was included in the title.
> >>
> >> Swapnil has already followed up with me and I am happy to release the
> >> copyright for this tutorial document and fully contribute it back to
> under
> >> ASL v2 so the project so the community is free to use, change or update
> it
> >> as needed.
> >>
> >> Thanks
> >> Sharan
> >>
> >>
>

Re: Getting Started with Apache OFBiz Manufacturing in 5 Easy Steps

2019-06-25 Thread Jacques Le Roux


Thanks Sharan, and thanks to All involved in this effort!

Jacques

Le 25/06/2019 à 06:50, Swapnil M Mane a écrit :

Thanks so much, Sharan for this valuable contribution, highly appreciated!!

@Team,
We are making slight changes (creating confluence document from PDF,
updating the screenshots, etc.) in original PDF document to sync with the
latest OFBiz release.
Here is the initial version of improved document [1], currently in WIP,
will be completed soon.
(Thanks to Archana Asthana for participating in the effort of syncing the
document with the latest release)

[1] https://cwiki.apache.org/confluence/x/Pw3HBg


- Best Regards,
Swapnil M Mane,
ofbiz.apache.org



On Tue, Jun 25, 2019 at 2:34 AM Sharan Foga  wrote:


Hi All

I saw a note about the Getting Started with Apache OFBiz Manufacturing &
MRP in 5 Easy Steps tutorial document that I wrote a while ago that is
being added to the wiki as individual pages. The original pdf tutorial
document I contributed included a copyright notice which is probably why my
name was included in the title.

Swapnil has already followed up with me and I am happy to release the
copyright for this tutorial document and fully contribute it back to under
ASL v2 so the project so the community is free to use, change or update it
as needed.

Thanks
Sharan

Re: Getting Started with Apache OFBiz Manufacturing in 5 Easy Steps

2019-06-24 Thread Swapnil M Mane

Thanks so much, Sharan for this valuable contribution, highly appreciated!!

@Team,
We are making slight changes (creating confluence document from PDF,
updating the screenshots, etc.) in original PDF document to sync with the
latest OFBiz release.
Here is the initial version of improved document [1], currently in WIP,
will be completed soon.
(Thanks to Archana Asthana for participating in the effort of syncing the
document with the latest release)

[1] https://cwiki.apache.org/confluence/x/Pw3HBg

- Best Regards,
Swapnil M Mane,
ofbiz.apache.org

On Tue, Jun 25, 2019 at 2:34 AM Sharan Foga  wrote:

> Hi All
>
> I saw a note about the Getting Started with Apache OFBiz Manufacturing &
> MRP in 5 Easy Steps tutorial document that I wrote a while ago that is
> being added to the wiki as individual pages. The original pdf tutorial
> document I contributed included a copyright notice which is probably why my
> name was included in the title.
>
> Swapnil has already followed up with me and I am happy to release the
> copyright for this tutorial document and fully contribute it back to under
> ASL v2 so the project so the community is free to use, change or update it
> as needed.
>
> Thanks
> Sharan
>
>

Getting Started with Apache OFBiz Manufacturing in 5 Easy Steps

2019-06-24 Thread Sharan Foga

Hi All

I saw a note about the Getting Started with Apache OFBiz Manufacturing & MRP in 
5 Easy Steps tutorial document that I wrote a while ago that is being added to 
the wiki as individual pages. The original pdf tutorial document I contributed 
included a copyright notice which is probably why my name was included in the 
title.

Swapnil has already followed up with me and I am happy to release the copyright 
for this tutorial document and fully contribute it back to under ASL v2 so the 
project so the community is free to use, change or update it as needed. 

Thanks
Sharan

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-30 Thread Jacopo Cappellato

On Thu, Mar 30, 2017 at 2:16 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> [...] Jacopo asked me to prove I was right, it's not the same.

I have never asked you to prove you were right; all I have asked is:

"to revert the changes in which you have changed the functional behavior of
the system without testing OR test the new behavior and confirm it is
working fine"

> [...] Like if I was in a trial, where Jacopo, Scott, Taher and you were
> accusing me.

I suggest you to try not being so defensive and do your best to accept
criticism to your work not as it was criticism to you as a person.
Please also be more respectful to the other committers, and to the people
reading your messages, who are spending time trying to help and protect the
code: accusing them to be an "elite", accusing them to practice FUD (which
is a strong statement for which I would expect your apologies) is really
killing the collaboration.

Jacopo

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-30 Thread Jacques Le Roux


Le 30/03/2017 à 14:16, Jacques Le Roux a écrit :
It still happens that I prefer to submit a patch and there are cases in Jira. https://issues.apache.org/jira/issues/?filter=12340482 Not all 
attachments are patches, but even if it's only a half+, it's still around 100 cases

Sorry, this is a personal filter I can only view, use rather 
https://issues.apache.org/jira/issues/?filter=12340487

Jacques

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-30 Thread Jacques Le Roux

Hi Michael,

It will be my last answer, and I'll try to be positive, just using facts, else
we will never end.

Le 29/03/2017 à 11:23, Michael Brohl a écrit :

Hi Jacques,

Am 28.03.17 um 05:47 schrieb Jacques Le Roux:

Le 25/03/2017 à 13:21, Michael Brohl a écrit :

The lack of code documentation is not a free ticket to just change the code
behaviour without proper analysis.

It's not because the swallowed exceptions where not documented that I decided to catch them. I rather proposed later to at least document them; if
we had fear (ie no proofs) that it was going to break the flow.

What make you think that I did not a proper analysis? Actually it was a fast
analysis based on 2 principles:
1) Exceptions should be catched because they fail fast. It's then easier to analyse a stack error.
https://www.owasp.org/index.php/Exception_handling_techniques#Swallowing_Exceptions. You may prefer
https://www.google.com/search?q=swallowing+exceptions

And yes, I did a lot of OFBiz log analysis, where stack errors are very
important. And no, most of the errors I had to analyse were not mine!
2) Returning an error from a service does not guarantee that all cases are
covered, notably exceptions

These are just general rules and patterns and do not prove that a proper
analysis for this special case was made.
I did a proper analysis based on these patterns and rules. Jacopo asked me to prove I was right, it's not the same. I got into much details then
applying the ideas I had initially. Like if I was in a trial, where Jacopo, Scott, Taher and you were accusing me.

Now how could I prove that I previously did a proper analysis? It was in my
brain, hard to say.
Let me ask you another question. In which cases is it good to swallow an exception? I believe there are very rare cases, if any. And having a
swallowed exception is a smell for refactoring.
I must admit I did not then dig as much as I did to convince Jacopo I was not derailing the flow. But that's what I had in mind. It was not a shoot
in the dark as you seem to think.

I did not say that it was a shot in the dark but that it needs proper analysis. You admit for yourself that you did it after Jacopo asked you to
revert the commit and not before you committed. That's what worries me.

Actually it's very different when you are thinking and when you are
writing/doing.

The right process should be

1. discuss

2. provide a patch

3. let others review/comment

4. decide

5. commit
I don't agree with this process for present changes. It's much, too much bureaucracy in this case, sorry to say. I though agree that there are
cases where it's necessary, and I sometimes do so.

That's not bureaucracy but collaboration and a principle to assure quality and prevent errors. As I said before, I won't apply this process to any
single fix or trivial enhancement.

In this case, what would be so difficult to put the patch for your proposal in
Jira and asked for some opinions from other contributors?
That's something I do sometimes. But wait contributors do that, and here is the situation: 259 issues with patches available waiting
https://issues.apache.org/jira/issues/?filter=12340473

among 51 bugs https://issues.apache.org/jira/issues/?filter=12333848
So before submitting a patch I always balance if it's a good idea or if I can take the responsibility of directly committing. I also always consider
the 10" action rule. If I can do it in 10" then I do it right away. Somrtimes I end shaving the yak and would slap myself :/
It still happens that I prefer to submit a patch and there are cases in Jira. https://issues.apache.org/jira/issues/?filter=12340482 Not all
attachments are patches, but even if it's only a half+, it's still around 100 cases

In https://issues.apache.org/jira/browse/OFBIZ-9123 you agreed that this woul be the better approach by stating " I concur with Michael's opinion,
notably the well stated 4 points process."

But, if you read all the comment https://s.apache.org/4HFD I then did a review
and agree it was OK. Here is another sentence is the same comment
>
For me this did not need to be reverted and been postponed. Later, after Pierre's comment on FTL templates, I asked Jinghai twice to follow the
structure we "recently" (then) adopted. I guess he missed the 1st and did quickly on the 2nd.

It is really dangerous to easily change code like this.

Why? Please explain and prove your allegations...

It's obvious that changing program logic without proper analysis is dangerous,
especially in a complex system like OFBiz, isn't it?
I agree OFBiz is complex but this was not complex, people feared it was complex, it was not. "You shall not swallow exceptions" could be the mantra of
the week.
Jacques, please be not so hasty with committing stuff.

I don't commit stuff hastily. I commit a lot, but not hastily. I make errors,
who does not?

You might call it like you want, my impression is that slowing down a bit

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-29 Thread Jacques Le Roux


Le 29/03/2017 à 15:27, Jacques Le Roux a écrit :

It will more clear there where this is at least some limited ways of formatting 
(code, etc.)


Jacques



Typo
It will more clear there where there is at least some limited ways of 
formatting (code, etc.)

Jacques


:D still a word missing
It will BE more clear there, where there is at least some limited ways of 
formatting (code, etc.)

Jacques

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-29 Thread Jacques Le Roux


It will more clear there where this is at least some limited ways of formatting 
(code, etc.)


Jacques



Typo
It will more clear there where there is at least some limited ways of 
formatting (code, etc.)

Jacques

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-29 Thread Jacques Le Roux


Le 27/03/2017 à 10:01, Jacopo Cappellato a écrit :

On Sat, Mar 25, 2017 at 8:23 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


[...]
Now feel free to revert my commit if you still think it's a bad thing, but
sincerely I'm not convinced! If you do so I'll then at least add comments
to explain the situation...


The analysis and tests that you did in this email to reply to my request
are actually what I was asking for that is (quoting myself):

"[...] to revert the changes in which you have changed the functional
behavior of the system without testing OR test the new behavior and confirm
it is working fine."

So this is the right direction: please similarly complete your analysis and
testing on any other code modified/affected by your commits or revert the
functional changes that you can't analyze or test.

Thanks

Jacopo


To keep things clear I'll answer you an everybody in the related Jira "Fix Default 
or Empty Catch block in Java files" OFBIZ-8341
I will explain each commit in the Jira for everybody interested.
It will more clear there where this is at least some limited ways of formatting 
(code, etc.)

Jacques

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-29 Thread Michael Brohl


Hi Jacques,

Am 28.03.17 um 05:47 schrieb Jacques Le Roux:

Le 25/03/2017 à 13:21, Michael Brohl a écrit :

+1

The lack of code documentation is not a free ticket to just change 
the code behaviour without proper analysis.


It's not because the swallowed exceptions where not documented that I 
decided to catch them. I rather proposed later to at least document 
them; if we had fear (ie no proofs) that it was going to break the flow.
What make you think that I did not a proper analysis? Actually it was 
a fast analysis based on 2 principles:
1) Exceptions should be catched because they fail fast. It's then 
easier to analyse a stack error. 
https://www.owasp.org/index.php/Exception_handling_techniques#Swallowing_Exceptions. 
You may prefer https://www.google.com/search?q=swallowing+exceptions
And yes, I did a lot of OFBiz log analysis, where stack errors are 
very important. And no, most of the errors I had to analyse were not 
mine!
2) Returning an error from a service does not guarantee that all cases 
are covered, notably exceptions




These are just general rules and patterns and do not prove that a proper 
analysis for this special case was made.


I must admit I did not then dig as much as I did to convince Jacopo I 
was not derailing the flow. But that's what I had in mind. It was not 
a shoot in the dark as you seem to think.




I did not say that it was a shot in the dark but that it needs proper 
analysis. You admit for yourself that you did it after Jacopo asked you 
to revert the commit and not before you committed. That's what worries me.




The right process should be

1. discuss

2. provide a patch

3. let others review/comment

4. decide

5. commit
I don't agree with this process for present changes. It's much, too 
much bureaucracy in this case, sorry to say. I though agree that there 
are cases where it's necessary, and I sometimes do so.


That's not bureaucracy but collaboration and a principle to assure 
quality and prevent errors. As I said before, I won't apply this process 
to any single fix or trivial enhancement.
In this case, what would be so difficult to put the patch for your 
proposal in Jira and asked for some opinions from other contributors?


In https://issues.apache.org/jira/browse/OFBIZ-9123 you agreed that this 
woul be the better approach by stating " I concur with Michael's 
opinion, notably the well stated 4 points process."




It is really dangerous to easily change code like this.

Why? Please explain and prove your allegations...


It's obvious that changing program logic without proper analysis is 
dangerous, especially in a complex system like OFBiz, isn't it?


Jacques, please be not so hasty with committing stuff. 
I don't commit stuff hastily. I commit a lot, but not hastily. I make 
errors, who does not?


You might call it like you want, my impression is that slowing down a 
bit and collaborating more by providing a patch instead of directly 
commiting your work might reduce the number of errors and save us a lot 
of time discussing and reverting afterwards.



We have had a lot of similar cases with reverts,

"A lot of similar cases with reverts"? Really? Which ones?


Just search for "revert/reverted/reverts" in the commits mailing list 
and you'll find them.


committing half done solutions and such lately. 

"half done solutions and such", have you examples?


We had several disccussions about them, the encryption issue and the 
addition of the PriCat component come to mind. There were some others 
but I won't spent time to dig them up again.


And please be aware that others might not have so much time to follow 
every commit in detail, analyze and comment promptly.
I don't ask anybody to follow the pace I have currently the chance to 
have. But if I follow your comment, then we would use RTC, for now 
it's CTR. And with RTC, OFBiz evolution, which is not currently 
brilliant,  would begin to stale.


In my opinion, the evolution should be towards quality, ease of 
maintenance and robustness, not about commiting lots of stuff in a short 
amount of time. A well balanced use of RTC and CTR will help all of us.




It really worries me because we lose quality and it's not easy to 
detect errors 
It never easy to detect errors. It needs a lot of work. Do you suggest 
that I put errors in code by negligence? Have a look at what I do, and 
you will be convinced on the contrary. I track errors as much as I can 
and I help others to fix them when they are not mine.


I did not say any of this nor do I suggest it.

and changed functionality in such a complex project. 
I repeat, again, I did not change any functionalities, hence the "No 
functional change". Prove the contrary...
And don't rely too much on the tests as we don't have such a high 
test coverage.

I don't rely only on tests, but yes I also rely on them, who does not?


Thanks for some more patience,
That I can understand, but not all the FUD above, and not going to RTC 
because of fear. If

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-27 Thread Jacques Le Roux

Le 25/03/2017 à 13:21, Michael Brohl a écrit :

The lack of code documentation is not a free ticket to just change the code
behaviour without proper analysis.

It's not because the swallowed exceptions where not documented that I decided to catch them. I rather proposed later to at least document them; if we
had fear (ie no proofs) that it was going to break the flow.

What make you think that I did not a proper analysis? Actually it was a fast
analysis based on 2 principles:
1) Exceptions should be catched because they fail fast. It's then easier to analyse a stack error.
https://www.owasp.org/index.php/Exception_handling_techniques#Swallowing_Exceptions. You may prefer https://www.google.com/search?q=swallowing+exceptions

I must admit I did not then dig as much as I did to convince Jacopo I was not derailing the flow. But that's what I had in mind. It was not a shoot in
the dark as you seem to think.

The right process should be

1. discuss

2. provide a patch

3. let others review/comment

4. decide

5. commit
I don't agree with this process for present changes. It's much, too much bureaucracy in this case, sorry to say. I though agree that there are cases
where it's necessary, and I sometimes do so.

It is really dangerous to easily change code like this.

Why? Please explain and prove your allegations...

Jacques, please be not so hasty with committing stuff.

I don't commit stuff hastily. I commit a lot, but not hastily. I make errors,
who does not?

We have had a lot of similar cases with reverts,

"A lot of similar cases with reverts"? Really? Which ones?
committing half done solutions and such lately.

"half done solutions and such", have you examples?

And please be aware that others might not have so much time to follow every
commit in detail, analyze and comment promptly.
I don't ask anybody to follow the pace I have currently the chance to have. But if I follow your comment, then we would use RTC, for now it's CTR. And
with RTC, OFBiz evolution, which is not currently brilliant, would begin to stale.

It really worries me because we lose quality and it's not easy to detect errors
It never easy to detect errors. It needs a lot of work. Do you suggest that I put errors in code by negligence? Have a look at what I do, and you will
be convinced on the contrary. I track errors as much as I can and I help others to fix them when they are not mine.
and changed functionality in such a complex project.

I repeat, again, I did not change any functionalities, hence the "No functional
change". Prove the contrary...

And don't rely too much on the tests as we don't have such a high test coverage.

I don't rely only on tests, but yes I also rely on them, who does not?

Thanks for some more patience,
That I can understand, but not all the FUD above, and not going to RTC because of fear. If you have something to say, please comment the code and
detail the problems you see, then we can discuss...

Jacques

Michael

Am 24.03.17 um 14:13 schrieb Jacopo Cappellato:

On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

[...]
If we (both and All) agree on collaborating to document on purpose
swallowed exceptions, even when you are not directly concerned, then I
agree to revert my changes, deal?

We are not negotiating: I have simply asked you to revert the changes in
which you have changed the functional behavior of the system without
testing OR test the new behavior and confirm it is working fine.

In general I like the effort of improving this old code containing
swallowed exceptions by providing more comments, documentation etc... or
completely refactoring it; but this has to be done with proper testing.

I hope this clarifies my request.

Jacopo

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-27 Thread Jacopo Cappellato

On Sat, Mar 25, 2017 at 8:23 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> [...]
> Now feel free to revert my commit if you still think it's a bad thing, but
> sincerely I'm not convinced! If you do so I'll then at least add comments
> to explain the situation...

The analysis and tests that you did in this email to reply to my request
are actually what I was asking for that is (quoting myself):

"[...] to revert the changes in which you have changed the functional
behavior of the system without testing OR test the new behavior and confirm
it is working fine."

So this is the right direction: please similarly complete your analysis and
testing on any other code modified/affected by your commits or revert the
functional changes that you can't analyze or test.

Thanks

Jacopo

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-27 Thread Jacopo Cappellato

On Mon, Mar 27, 2017 at 10:24 AM, Michael Brohl 
wrote:

> Hi Jacopo,
>
> I'm not for a general change to Review-Then-Commit but pleading for a more
> sensible way to handle these things as a responsible committer.
>
> As a guideline: if in doubt, always provide a patch and describe what the
> change should do or fix and let others review.
>
> Of course not for trivial changes or fixes. But when it comes to new
> modules, significantly changing the behaviour of the business logic etc. I
> think it's better to apply Review-Then-Commit.
>
> And of course, if others want a commit to be reverted, we should do it
> first and then discuss.
>
> Regards,
>
> Michael
>

I totally agree with all you wrote Michael.

Jacopo

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-27 Thread Michael Brohl


Hi Jacopo,

I'm not for a general change to Review-Then-Commit but pleading for a 
more sensible way to handle these things as a responsible committer.


As a guideline: if in doubt, always provide a patch and describe what 
the change should do or fix and let others review.


Of course not for trivial changes or fixes. But when it comes to new 
modules, significantly changing the behaviour of the business logic etc. 
I think it's better to apply Review-Then-Commit.


And of course, if others want a commit to be reverted, we should do it 
first and then discuss.


Regards,

Michael


Am 27.03.17 um 10:07 schrieb Jacopo Cappellato:

On Sat, Mar 25, 2017 at 1:21 PM, Michael Brohl 
wrote:


+1

The lack of code documentation is not a free ticket to just change the
code behaviour without proper analysis.

The right process should be

1. discuss

2. provide a patch

3. let others review/comment

4. decide

5. commit

It is really dangerous to easily change code like this.

Jacques, please be not so hasty with committing stuff. We have had a lot
of similar cases with reverts, committing half done solutions and such
lately. And please be aware that others might not have so much time to
follow every commit in detail, analyze and comment promptly.

It really worries me because we lose quality and it's not easy to detect
errors and changed functionality in such a complex project. And don't rely
too much on the tests as we don't have such a high test coverage.

Thanks for some more patience,

Michael



I am fine with continuing with the Commit-Then-Review approach (and
leverage Review-ThenCommit approach only when more appropriate) provided
that the committer is willing to accept (by reverting or performing further
work as requested by the reviewers) negative reviews. What we should really
avoid is committers dragging their feet, pushing back reviews, trying to
argue and negotiate to keep their code as committed.

Jacopo






smime.p7s
Description: S/MIME Cryptographic Signature

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-27 Thread Jacopo Cappellato

On Sat, Mar 25, 2017 at 1:21 PM, Michael Brohl 
wrote:

> +1
>
> The lack of code documentation is not a free ticket to just change the
> code behaviour without proper analysis.
>
> The right process should be
>
> 1. discuss
>
> 2. provide a patch
>
> 3. let others review/comment
>
> 4. decide
>
> 5. commit
>
> It is really dangerous to easily change code like this.
>
> Jacques, please be not so hasty with committing stuff. We have had a lot
> of similar cases with reverts, committing half done solutions and such
> lately. And please be aware that others might not have so much time to
> follow every commit in detail, analyze and comment promptly.
>
> It really worries me because we lose quality and it's not easy to detect
> errors and changed functionality in such a complex project. And don't rely
> too much on the tests as we don't have such a high test coverage.
>
> Thanks for some more patience,
>
> Michael
>
>
I am fine with continuing with the Commit-Then-Review approach (and
leverage Review-ThenCommit approach only when more appropriate) provided
that the committer is willing to accept (by reverting or performing further
work as requested by the reviewers) negative reviews. What we should really
avoid is committers dragging their feet, pushing back reviews, trying to
argue and negotiate to keep their code as committed.

Jacopo

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-27 Thread Taher Alkhateeb

I think we should start a discussion about these types of commits. I have
concerns and problems with the way commits are getting done at the moment.
Meanwhile, I also agree with Jacopo on the need for a thorough review
instead of these _bulk_ commits without looking carefully at all possible
affected locations in the code base. I mean even with extreme care we
sometimes catch deeply hidden bugs.

On Sat, Mar 25, 2017 at 3:21 PM, Michael Brohl 
wrote:

> +1
>
> The lack of code documentation is not a free ticket to just change the
> code behaviour without proper analysis.
>
> The right process should be
>
> 1. discuss
>
> 2. provide a patch
>
> 3. let others review/comment
>
> 4. decide
>
> 5. commit
>
> It is really dangerous to easily change code like this.
>
> Jacques, please be not so hasty with committing stuff. We have had a lot
> of similar cases with reverts, committing half done solutions and such
> lately. And please be aware that others might not have so much time to
> follow every commit in detail, analyze and comment promptly.
>
> It really worries me because we lose quality and it's not easy to detect
> errors and changed functionality in such a complex project. And don't rely
> too much on the tests as we don't have such a high test coverage.
>
> Thanks for some more patience,
>
> Michael
>
>
> Am 24.03.17 um 14:13 schrieb Jacopo Cappellato:
>
> On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> [...]
>>> If we (both and All) agree on collaborating to document on purpose
>>> swallowed exceptions, even when you are not directly concerned, then I
>>> agree to revert my changes, deal?
>>>
>>
>> We are not negotiating: I have simply asked you to revert the changes in
>> which you have changed the functional behavior of the system without
>> testing OR test the new behavior and confirm it is working fine.
>>
>> In general I like the effort of improving this old code containing
>> swallowed exceptions by providing more comments, documentation etc... or
>> completely refactoring it; but this has to be done with proper testing.
>>
>> I hope this clarifies my request.
>>
>> Jacopo
>>
>>
>
>

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-25 Thread Pierre Smits

So you're suggesting to apply RtC in stead op CtR regarding improvement
issues, Michael?

I suggest you start that discussion in a new thread and work towards
consensus and documenting.

Best regards,

Pierre

On Saturday, March 25, 2017, Michael Brohl  wrote:

> +1
>
> The lack of code documentation is not a free ticket to just change the
> code behaviour without proper analysis.
>
> The right process should be
>
> 1. discuss
>
> 2. provide a patch
>
> 3. let others review/comment
>
> 4. decide
>
> 5. commit
>
> It is really dangerous to easily change code like this.
>
> Jacques, please be not so hasty with committing stuff. We have had a lot
> of similar cases with reverts, committing half done solutions and such
> lately. And please be aware that others might not have so much time to
> follow every commit in detail, analyze and comment promptly.
>
> It really worries me because we lose quality and it's not easy to detect
> errors and changed functionality in such a complex project. And don't rely
> too much on the tests as we don't have such a high test coverage.
>
> Thanks for some more patience,
>
> Michael
>
>
> Am 24.03.17 um 14:13 schrieb Jacopo Cappellato:
>
>> On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> [...]
>>> If we (both and All) agree on collaborating to document on purpose
>>> swallowed exceptions, even when you are not directly concerned, then I
>>> agree to revert my changes, deal?
>>>
>>
>> We are not negotiating: I have simply asked you to revert the changes in
>> which you have changed the functional behavior of the system without
>> testing OR test the new behavior and confirm it is working fine.
>>
>> In general I like the effort of improving this old code containing
>> swallowed exceptions by providing more comments, documentation etc... or
>> completely refactoring it; but this has to be done with proper testing.
>>
>> I hope this clarifies my request.
>>
>> Jacopo
>>
>>
>
>

-- 
Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-25 Thread Michael Brohl


+1

The lack of code documentation is not a free ticket to just change the 
code behaviour without proper analysis.


The right process should be

1. discuss

2. provide a patch

3. let others review/comment

4. decide

5. commit

It is really dangerous to easily change code like this.

Jacques, please be not so hasty with committing stuff. We have had a lot 
of similar cases with reverts, committing half done solutions and such 
lately. And please be aware that others might not have so much time to 
follow every commit in detail, analyze and comment promptly.


It really worries me because we lose quality and it's not easy to detect 
errors and changed functionality in such a complex project. And don't 
rely too much on the tests as we don't have such a high test coverage.


Thanks for some more patience,

Michael


Am 24.03.17 um 14:13 schrieb Jacopo Cappellato:

On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


[...]
If we (both and All) agree on collaborating to document on purpose
swallowed exceptions, even when you are not directly concerned, then I
agree to revert my changes, deal?


We are not negotiating: I have simply asked you to revert the changes in
which you have changed the functional behavior of the system without
testing OR test the new behavior and confirm it is working fine.

In general I like the effort of improving this old code containing
swallowed exceptions by providing more comments, documentation etc... or
completely refactoring it; but this has to be done with proper testing.

I hope this clarifies my request.

Jacopo






smime.p7s
Description: S/MIME Cryptographic Signature

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-25 Thread Jacques Le Roux


Le 24/03/2017 à 14:13, Jacopo Cappellato a écrit :

On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


[...]
If we (both and All) agree on collaborating to document on purpose
swallowed exceptions, even when you are not directly concerned, then I
agree to revert my changes, deal?


We are not negotiating: I have simply asked you to revert the changes in
which you have changed the functional behavior of the system without
testing OR test the new behavior and confirm it is working fine.

I thought you could have given some information on the documentation to put 
into the swallowed exceptions :/

In general I like the effort of improving this old code containing
swallowed exceptions by providing more comments, documentation etc... or
completely refactoring it; but this has to be done with proper testing.

I hope this clarifies my request.

Jacopo


OK so I'll try to answer to your request.
No need to say that all the tests pass. We know we don't directly cover all services but at least we got that when running all tests (gradlew 
testIntegration):
2017-03-24 14:33:03,864 |main |ServiceDispatcher |T| Sync service [test-dispatcher-Oz3Z0DRojV/updateProductionRunTask] finished in [830] 
milliseconds
2017-03-24 14:33:04,173 |main |ServiceDispatcher |T| Sync service [test-dispatcher-Oz3Z0DRojV/updateProductionRunTask] finished in [162] 
milliseconds

It's part of testProductionRunQuickIssueAndProduce through a call to 
productionRunDeclareAndProduce itself calling updateProductionRunTask

I think we can agree that the successful behaviour can't have been derailed by my changes. It's only when a  GenericEntityException or 
GenericServiceException is raised that it might be have been changed, right? So at least in a normal situation (no exceptions) it's OK.


Now what happens when an exception is raised?
In case of a GenericEntityException 2 expressions are concerned. In case of issues it's better to catch them rather than ignore them. Nothing was done 
before, it was simply ignored. How could let a GenericEntityException swallowed here be better? It's better now IMO, shit happens, better not let it 
hits the fan.


In case of a GenericServiceException the sync call to 
issueProductionRunTaskComponent is concerned. It's a simple-method.
Here are the 2 cases in log when putting a typo in 
issueProductionRunTaskComponent

With exception handled:
2017-03-24 20:29:38,267 |main |ServiceDispatcher |T| [[Sync service failed...- total:0.0,since last(Begin):0.0]] - 
'test-dispatcher-m10o2bxhIR / issueProductionRunTaskComponent'

2017-03-24 20:29:38,267 |main |TransactionUtil   |W| Calling 
transaction setRollbackOnly; this stack trace shows where this is happening:
java.lang.Exception: Service [issueProductionRunTaskComponent] threw an 
unexpected exception/error
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:512) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.manufacturing.jobshopmgt.ProductionRunServices.updateProductionRunTask(ProductionRunServices.java:2210)
 [ofbiz.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_121]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) 
~[?:1.8.0_121]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) 
~[?:1.8.0_121]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
at 
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:395) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.manufacturing.jobshopmgt.ProductionRunServices.productionRunDeclareAndProduce(ProductionRunServices.java:1882)
 [ofbiz.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_121]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) 
~[?:1.8.0_121]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) 
~[?:1.8.0_121]
at

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-25 Thread Jacques Le Roux


I also agreed, I just expected some help to comment why the exceptions were 
swallowed :/

Jacques


Le 24/03/2017 à 21:09, Scott Gray a écrit :

I agree with Jacopo, these are very functional changes that shouldn't be
made without understanding the workflow.  It's good to clean up the code
but it shouldn't be done blindly.

On 25 March 2017 at 02:13, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:


On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


[...]
If we (both and All) agree on collaborating to document on purpose
swallowed exceptions, even when you are not directly concerned, then I
agree to revert my changes, deal?


We are not negotiating: I have simply asked you to revert the changes in
which you have changed the functional behavior of the system without
testing OR test the new behavior and confirm it is working fine.

In general I like the effort of improving this old code containing
swallowed exceptions by providing more comments, documentation etc... or
completely refactoring it; but this has to be done with proper testing.

I hope this clarifies my request.

Jacopo

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-24 Thread Scott Gray

I agree with Jacopo, these are very functional changes that shouldn't be
made without understanding the workflow.  It's good to clean up the code
but it shouldn't be done blindly.

On 25 March 2017 at 02:13, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > [...]
> > If we (both and All) agree on collaborating to document on purpose
> > swallowed exceptions, even when you are not directly concerned, then I
> > agree to revert my changes, deal?
>
>
> We are not negotiating: I have simply asked you to revert the changes in
> which you have changed the functional behavior of the system without
> testing OR test the new behavior and confirm it is working fine.
>
> In general I like the effort of improving this old code containing
> swallowed exceptions by providing more comments, documentation etc... or
> completely refactoring it; but this has to be done with proper testing.
>
> I hope this clarifies my request.
>
> Jacopo
>

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-24 Thread Jacopo Cappellato

On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> [...]
> If we (both and All) agree on collaborating to document on purpose
> swallowed exceptions, even when you are not directly concerned, then I
> agree to revert my changes, deal?

We are not negotiating: I have simply asked you to revert the changes in
which you have changed the functional behavior of the system without
testing OR test the new behavior and confirm it is working fine.

In general I like the effort of improving this old code containing
swallowed exceptions by providing more comments, documentation etc... or
completely refactoring it; but this has to be done with proper testing.

I hope this clarifies my request.

Jacopo

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-24 Thread Jacques Le Roux


Hi Jacopo,

Thanks for your review. I understand your concerns but IMO if an exception has a good reason to be swallowed then this reason should be documented by 
a comment in the catch. Else how can we quickly differentiate these cases from plain forgotten swallowed exceptions? Apart of course by deeply 
analysing the concerned code which can be difficult in some cases (I agree not much here).


So I don't want to blindly revert but rather want to handle this case positively. So I think we need to have a look at each case and try to 
collaborate for a better future for OFBiz


--

Let's take ProductionRunServices for a start: https://s.apache.org/bjbA

The 1st hunk concerns updateProductionRunTask()

-} catch (GenericEntityException gee) {
-
-} catch (GenericServiceException gee) {
-
+} catch (GenericEntityException | GenericServiceException e) {
+String errMsg = "Problem calling the 
updateProductionRunTaskStatus service";
+Debug.logError(e, errMsg, module);
+return ServiceUtil.returnError(errMsg);
 }

You put it in at r648703 here is the detail https://s.apache.org/uOWj
Then you improved it at r1043899 by adding

 return ServiceUtil.returnError(ServiceUtil.getErrorMessage(resultService));

But you still let the swallowed exceptions (which BTW looks like a quick C/P, both named gee). If I review the concerned try I can't clearly 
understand why. To me errors in services are handled but not other cases.

--
The 2nd hunk concerns approveRequirement
Here you swallowed the exception (I guess you wrote that before the Apache era) 
and also use a  ServiceUtil.returnError

  return ServiceUtil.returnError(UtilProperties.getMessage(resource, 
"ManufacturingRequirementNotExists", locale));

But we can have 2 cases here
1) no requirement w/o exception, OK
2) a simple entity exception for an unknown reason, swallowed
Why not handling the 2nd case?

The 3rd hunk concerns createProductionRunFromRequirement and is the same case 
than the 2nd

For ShoppingCartEvents and ShoppingCartHelper, it's the same kind of cases than 
the 2nd and 3rd hunks above. That should not be hard to document.

If we (both and All) agree on collaborating to document on purpose swallowed exceptions, even when you are not directly concerned, then I agree to 
revert my changes, deal?


Jacques

Le 23/03/2017 à 09:04, Jacopo Cappellato a écrit :

Forwarding an email that I sent yesterday and seems to be lost in the net.

Jacopo

On Tue, Mar 21, 2017 at 10:29 AM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:


Jacques,

I have some concerns about this and similar changes you are committing in
the attempt to improve exception handling: converting a swallowed exception
into a service/event error is actually introducing a pretty relevant
functional change. Maybe the original code was intended to ignore the
exception and move one with additional business logic: however a bulk
change without a deep study/testing of every specific change you are
introducing is not the right way to go in my opinion. I would recommend to
revert these commits and perform an analysis and testing before introducing
these changes.

Jacopo

On Tue, Mar 21, 2017 at 9:40 AM, <jler...@apache.org> wrote:


Author: jleroux
Date: Tue Mar 21 08:40:07 2017
New Revision: 1787906

URL: http://svn.apache.org/viewvc?rev=1787906=rev
Log:
No functional changes, fixes a bunch of swallowed exceptions

Modified:
 ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/
main/java/org/apache/ofbiz/manufacturing/jobshopmgt/Produ
ctionRunServices.java
 ofbiz/ofbiz-framework/trunk/applications/order/src/main/java
/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
 ofbiz/ofbiz-framework/trunk/applications/order/src/main/java
/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java

Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/
main/java/org/apache/ofbiz/manufacturing/jobshopmgt/Produ
ctionRunServices.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/app
lications/manufacturing/src/main/java/org/apache/ofbiz/
manufacturing/jobshopmgt/ProductionRunServices.java?rev=
1787906=1787905=1787906=diff

==
--- ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/
main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
(original)
+++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/
main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
Tue

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-23 Thread Jacopo Cappellato

Forwarding an email that I sent yesterday and seems to be lost in the net.

Jacopo

On Tue, Mar 21, 2017 at 10:29 AM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> Jacques,
>
> I have some concerns about this and similar changes you are committing in
> the attempt to improve exception handling: converting a swallowed exception
> into a service/event error is actually introducing a pretty relevant
> functional change. Maybe the original code was intended to ignore the
> exception and move one with additional business logic: however a bulk
> change without a deep study/testing of every specific change you are
> introducing is not the right way to go in my opinion. I would recommend to
> revert these commits and perform an analysis and testing before introducing
> these changes.
>
> Jacopo
>
> On Tue, Mar 21, 2017 at 9:40 AM, <jler...@apache.org> wrote:
>
>> Author: jleroux
>> Date: Tue Mar 21 08:40:07 2017
>> New Revision: 1787906
>>
>> URL: http://svn.apache.org/viewvc?rev=1787906=rev
>> Log:
>> No functional changes, fixes a bunch of swallowed exceptions
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/
>> main/java/org/apache/ofbiz/manufacturing/jobshopmgt/Produ
>> ctionRunServices.java
>> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java
>> /org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java
>> /org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java
>>
>> Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/
>> main/java/org/apache/ofbiz/manufacturing/jobshopmgt/Produ
>> ctionRunServices.java
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/app
>> lications/manufacturing/src/main/java/org/apache/ofbiz/
>> manufacturing/jobshopmgt/ProductionRunServices.java?rev=
>> 1787906=1787905=1787906=diff
>> 
>> ==
>> --- ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/
>> main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
>> (original)
>> +++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/
>> main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
>> Tue Mar 21 08:40:07 2017
>> @@ -2214,10 +2214,10 @@ public class ProductionRunServices {
>>  }
>> }
>>  }
>> -} catch (GenericEntityException gee) {
>> -
>> -} catch (GenericServiceException gee) {
>> -
>> +} catch (GenericEntityException |
>> GenericServiceException e) {
>> +String errMsg = "Problem calling the
>> updateProductionRunTaskStatus service";
>> +Debug.logError(e, errMsg, module);
>> +return ServiceUtil.returnError(errMsg);
>>  }
>>  }
>>  }
>> @@ -2264,7 +2264,10 @@ public class ProductionRunServices {
>>  GenericValue requirement = null;
>>  try {
>>  requirement = EntityQuery.use(delegator).fro
>> m("Requirement").where("requirementId", requirementId).queryOne();
>> -} catch (GenericEntityException gee) {
>> +} catch (GenericEntityException e) {
>> +String errMsg = "Problem calling the approveRequirement
>> service";
>> +Debug.logError(e, errMsg, module);
>> +return ServiceUtil.returnError(errMsg);
>>  }
>>
>>  if (requirement == null) {
>> @@ -2295,7 +2298,10 @@ public class ProductionRunServices {
>>  GenericValue requirement = null;
>>  try {
>>  requirement = EntityQuery.use(delegator).fro
>> m("Requirement").where("requirementId", requirementId).queryOne();
>> -} catch (GenericEntityException gee) {
>> +} catch (GenericEntityException e) {
>> +String errMsg = "Problem calling the
>> createProductionRunFromRequirement service";
>> +Debug.logError(e, errMsg, module);
>> +return ServiceUtil.returnError(errMsg);
>>  }
>>  if (requirement == null) {
>>  return 
>> ServiceUtil.returnError(UtilProperties.getMessage(resource,
>> "ManufacturingRequirementNotExists", locale));
>>
>> Modified: ofbiz/ofb

Re: svn commit: r1659914 - in /ofbiz/trunk/applications/manufacturing: config/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ webapp/manufacturing/WEB-INF/actions

2015-02-21 Thread Jacques Le Roux


Thanks Deepak,

And thanks for the reminder :)

Done at revision: 1661323

Jacques

Le 16/02/2015 05:50, Deepak Dixit a écrit :

inline:


On Feb 15, 2015, at 5:08 PM, jler...@apache.org wrote:

Author: jleroux
Date: Sun Feb 15 11:38:46 2015
New Revision: 1659914

URL: http://svn.apache.org/r1659914
Log:
A patch from Pierre Smits for
Have parties to be assigned to production run tasks 
https://issues.apache.org/jira/browse/OFBIZ-5706
It is not possible to assign parties to execute one or more task in a 
production run.

And
ProductionRun doesn't capture and show manufacturing organisation 
https://issues.apache.org/jira/browse/OFBIZ-5709
The production run should capture the manufacturing (internal) organisation on 
creation.

Modified:
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml

ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml

ofbiz/trunk/applications/manufacturing/servicedef/services_production_run.xml

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ProductionRunDeclaration.groovy

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/JobshopScreens.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/ManufacturingMenus.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/ProductionRunForms.xml

Modified: 
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml?rev=1659914r1=1659913r2=1659914view=diff
==
--- ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml 
(original)
+++ ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml Sun 
Feb 15 11:38:46 2015
@@ -19,6 +19,9 @@
 under the License.
--
resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; 
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/ofbiz-properties.xsd;
+property key=AddParty
+value xml:lang=enAdd Party/value
+/property
 property key=FormFieldTitle_allocatedCost
 value xml:lang=deVerrechnete Kosten/value
 value xml:lang=enAllocated Cost/value
@@ -3771,6 +3774,10 @@
 value 
xml:lang=zhçäº§è¿è¡æ´æ°å¤±è´¥ï¼è¯·æ¥çæ¥å¿äºè§£è¯¦ç»ä¿¡æ¯/value
 value 
xml:lang=zh-TWçç¢éè¡æ´æ°å¤±æ,è«æª¢è¦æ¥èªçè§£è©³ç´°è³è¨/value
 /property
+property key=ManufacturingProductionRunParties
+value xml:lang=enParties/value
+value xml:lang=nlPartijen/value
+/property
 property key=ManufacturingProductionRunPrintDocuments
 value xml:lang=deDokumente fÃ¼r Produktionsauftrage drucken/value
 value xml:lang=enProduction Run Print Documents/value

Modified: 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml?rev=1659914r1=1659913r2=1659914view=diff
==
--- 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
 Sun Feb 15 11:38:46 2015
@@ -20,7 +20,36 @@ under the License.

simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
 
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd;
-
+
+
+simple-method method-name=createProductionRunPartyAssign
+short-description=Assign the selected party to the production run or 
task
+
+set field=productionRunId from-field=parameters.productionRunId/
+set field=partyId from-field=parameters.partyId/
+set field=roleTypeId from-field=parameters.roleTypeId/
+set field=statusId value=PRTYASGN_ASSIGNED/
+set field=parameters.statusId value=PRTYASGN_ASSIGNED/
+
+if-not-empty field=parameters.workEffortId
+set field=workEffortId from-field=parameters.workEffortId/
+/if-not-empty
+if-empty field=parameters.workEffortId
+set field=parameters.workEffortId from-field=productionRunId/
+set field=workEffortId from-field=productionRunId/
+/if-empty
+
+entity-one entity-name=WorkEffort value-field=workEffort/
+set field=fromDate from-field=workEffort.estimatedStartDate/
+set field=statusDateTime 
from-field=workEffort.estimatedStartDate/
+set field

Re: svn commit: r1659914 - in /ofbiz/trunk/applications/manufacturing: config/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ webapp/manufacturing/WEB-INF/actions

2015-02-15 Thread Adrian Crum


We have 6 duplicate Parties UI labels.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 2/15/2015 3:38 AM, jler...@apache.org wrote:

Author: jleroux
Date: Sun Feb 15 11:38:46 2015
New Revision: 1659914

URL: http://svn.apache.org/r1659914
Log:
A patch from Pierre Smits for
Have parties to be assigned to production run tasks 
https://issues.apache.org/jira/browse/OFBIZ-5706
It is not possible to assign parties to execute one or more task in a 
production run.

And
ProductionRun doesn't capture and show manufacturing organisation 
https://issues.apache.org/jira/browse/OFBIZ-5709
The production run should capture the manufacturing (internal) organisation on 
creation.

Modified:
 ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
 
ofbiz/trunk/applications/manufacturing/servicedef/services_production_run.xml
 
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ProductionRunDeclaration.groovy
 
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy
 
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml
 
ofbiz/trunk/applications/manufacturing/widget/manufacturing/JobshopScreens.xml
 
ofbiz/trunk/applications/manufacturing/widget/manufacturing/ManufacturingMenus.xml
 
ofbiz/trunk/applications/manufacturing/widget/manufacturing/ProductionRunForms.xml

Modified: 
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml?rev=1659914r1=1659913r2=1659914view=diff
==
--- ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml 
(original)
+++ ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml Sun 
Feb 15 11:38:46 2015
@@ -19,6 +19,9 @@
  under the License.
  --
  resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; 
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/ofbiz-properties.xsd;
+property key=AddParty
+value xml:lang=enAdd Party/value
+/property
  property key=FormFieldTitle_allocatedCost
  value xml:lang=deVerrechnete Kosten/value
  value xml:lang=enAllocated Cost/value
@@ -3771,6 +3774,10 @@
  value 
xml:lang=zhçäº§è¿è¡æ´æ°å¤±è´¥ï¼è¯·æ¥çæ¥å¿äºè§£è¯¦ç»ä¿¡æ¯/value
  value 
xml:lang=zh-TWçç¢éè¡æ´æ°å¤±æ,è«æª¢è¦æ¥èªçè§£è©³ç´°è³è¨/value
  /property
+property key=ManufacturingProductionRunParties
+value xml:lang=enParties/value
+value xml:lang=nlPartijen/value
+/property
  property key=ManufacturingProductionRunPrintDocuments
  value xml:lang=deDokumente fÃ¼r Produktionsauftrage 
drucken/value
  value xml:lang=enProduction Run Print Documents/value

Modified: 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml?rev=1659914r1=1659913r2=1659914view=diff
==
--- 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
 Sun Feb 15 11:38:46 2015
@@ -20,7 +20,36 @@ under the License.

  simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
  
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd;
-
+
+
+simple-method method-name=createProductionRunPartyAssign
+short-description=Assign the selected party to the production run or 
task
+
+set field=productionRunId from-field=parameters.productionRunId/
+set field=partyId from-field=parameters.partyId/
+set field=roleTypeId from-field=parameters.roleTypeId/
+set field=statusId value=PRTYASGN_ASSIGNED/
+set field=parameters.statusId value=PRTYASGN_ASSIGNED/
+
+if-not-empty field=parameters.workEffortId
+set field=workEffortId from-field=parameters.workEffortId/
+/if-not-empty
+if-empty field=parameters.workEffortId
+set field=parameters.workEffortId from-field=productionRunId/
+set field=workEffortId from-field=productionRunId/
+/if-empty
+
+entity-one entity-name=WorkEffort value-field=workEffort/
+set field=fromDate from-field=workEffort.estimatedStartDate/
+set field=statusDateTime 
from-field=workEffort.estimatedStartDate/
+set field

Re: svn commit: r1659914 - in /ofbiz/trunk/applications/manufacturing: config/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ webapp/manufacturing/WEB-INF/actions

2015-02-15 Thread Jacques Le Roux


Are you sure? I can't find any locally (trunk HEAD), and would this relates to 
this commit?

Jacques

Le 15/02/2015 15:38, Adrian Crum a écrit :

We have 6 duplicate Parties UI labels.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 2/15/2015 3:38 AM, jler...@apache.org wrote:

Author: jleroux
Date: Sun Feb 15 11:38:46 2015
New Revision: 1659914

URL: http://svn.apache.org/r1659914
Log:
A patch from Pierre Smits for
Have parties to be assigned to production run tasks 
https://issues.apache.org/jira/browse/OFBIZ-5706
It is not possible to assign parties to execute one or more task in a 
production run.

And
ProductionRun doesn't capture and show manufacturing organisation 
https://issues.apache.org/jira/browse/OFBIZ-5709
The production run should capture the manufacturing (internal) organisation on 
creation.

Modified:
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
ofbiz/trunk/applications/manufacturing/servicedef/services_production_run.xml
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ProductionRunDeclaration.groovy
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml
ofbiz/trunk/applications/manufacturing/widget/manufacturing/JobshopScreens.xml
ofbiz/trunk/applications/manufacturing/widget/manufacturing/ManufacturingMenus.xml
ofbiz/trunk/applications/manufacturing/widget/manufacturing/ProductionRunForms.xml

Modified: 
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml?rev=1659914r1=1659913r2=1659914view=diff
==
--- ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml 
(original)
+++ ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml Sun 
Feb 15 11:38:46 2015
@@ -19,6 +19,9 @@
  under the License.
  --
  resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; 
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/ofbiz-properties.xsd;
+property key=AddParty
+value xml:lang=enAdd Party/value
+/property
  property key=FormFieldTitle_allocatedCost
  value xml:lang=deVerrechnete Kosten/value
  value xml:lang=enAllocated Cost/value
@@ -3771,6 +3774,10 @@
  value 
xml:lang=zhçäº§è¿è¡æ´æ°å¤±è´¥ï¼è¯·æ¥çæ¥å¿äºè§£è¯¦ç»ä¿¡æ¯/value
  value 
xml:lang=zh-TWçç¢éè¡æ´æ°å¤±æ,è«æª¢è¦æ¥èªçè§£è©³ç´°è³è¨/value
  /property
+property key=ManufacturingProductionRunParties
+value xml:lang=enParties/value
+value xml:lang=nlPartijen/value
+/property
  property key=ManufacturingProductionRunPrintDocuments
  value xml:lang=deDokumente fÃ¼r Produktionsauftrage 
drucken/value
  value xml:lang=enProduction Run Print Documents/value

Modified: 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml?rev=1659914r1=1659913r2=1659914view=diff

==
--- 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
 Sun Feb 15 11:38:46 2015
@@ -20,7 +20,36 @@ under the License.

  simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd;
-
+
+
+simple-method method-name=createProductionRunPartyAssign
+short-description=Assign the selected party to the production run or 
task
+
+set field=productionRunId from-field=parameters.productionRunId/
+set field=partyId from-field=parameters.partyId/
+set field=roleTypeId from-field=parameters.roleTypeId/
+set field=statusId value=PRTYASGN_ASSIGNED/
+set field=parameters.statusId value=PRTYASGN_ASSIGNED/
+
+if-not-empty field=parameters.workEffortId
+set field=workEffortId from-field=parameters.workEffortId/
+/if-not-empty
+if-empty field=parameters.workEffortId
+set field=parameters.workEffortId from-field=productionRunId/
+set field=workEffortId from-field=productionRunId/
+/if-empty
+
+entity-one entity-name=WorkEffort value-field=workEffort/
+set field=fromDate from-field=workEffort.estimatedStartDate/
+set field

Re: svn commit: r1659914 - in /ofbiz/trunk/applications/manufacturing: config/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ webapp/manufacturing/WEB-INF/actions

2015-02-15 Thread Adrian Crum


Search *.xml for Parties.

This commit adds another duplicate label.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 2/15/2015 9:52 AM, Jacques Le Roux wrote:

Are you sure? I can't find any locally (trunk HEAD), and would this
relates to this commit?

Jacques

Le 15/02/2015 15:38, Adrian Crum a écrit :

We have 6 duplicate Parties UI labels.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 2/15/2015 3:38 AM, jler...@apache.org wrote:

Author: jleroux
Date: Sun Feb 15 11:38:46 2015
New Revision: 1659914

URL: http://svn.apache.org/r1659914
Log:
A patch from Pierre Smits for
Have parties to be assigned to production run tasks
https://issues.apache.org/jira/browse/OFBIZ-5706
It is not possible to assign parties to execute one or more task in a
production run.

And
ProductionRun doesn't capture and show manufacturing organisation
https://issues.apache.org/jira/browse/OFBIZ-5709
The production run should capture the manufacturing (internal)
organisation on creation.

Modified:
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml

ofbiz/trunk/applications/manufacturing/servicedef/services_production_run.xml

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ProductionRunDeclaration.groovy

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/JobshopScreens.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/ManufacturingMenus.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/ProductionRunForms.xml


Modified:
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml?rev=1659914r1=1659913r2=1659914view=diff

==

---
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
(original)
+++
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
Sun Feb 15 11:38:46 2015
@@ -19,6 +19,9 @@
  under the License.
  --
  resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/ofbiz-properties.xsd;

+property key=AddParty
+value xml:lang=enAdd Party/value
+/property
  property key=FormFieldTitle_allocatedCost
  value xml:lang=deVerrechnete Kosten/value
  value xml:lang=enAllocated Cost/value
@@ -3771,6 +3774,10 @@
  value
xml:lang=zhçäº§è¿è¡æ´æ°å¤±è´¥ï¼è¯·æ¥çæ¥å¿äºè§£è¯¦ç»ä¿¡æ¯/value

  value
xml:lang=zh-TWçç¢éè¡æ´æ°å¤±æ,è«æª¢è¦æ¥èªçè§£è©³ç´°è³è¨/value

  /property
+property key=ManufacturingProductionRunParties
+value xml:lang=enParties/value
+value xml:lang=nlPartijen/value
+/property
  property key=ManufacturingProductionRunPrintDocuments
  value xml:lang=deDokumente fÃ¼r Produktionsauftrage
drucken/value
  value xml:lang=enProduction Run Print Documents/value

Modified:
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml

URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml?rev=1659914r1=1659913r2=1659914view=diff

==

---
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
(original)
+++
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
Sun Feb 15 11:38:46 2015
@@ -20,7 +20,36 @@ under the License.

  simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd;

-
+
+
+simple-method method-name=createProductionRunPartyAssign
+short-description=Assign the selected party to the
production run or task
+
+set field=productionRunId
from-field=parameters.productionRunId/
+set field=partyId from-field=parameters.partyId/
+set field=roleTypeId from-field=parameters.roleTypeId/
+set field=statusId value=PRTYASGN_ASSIGNED/
+set field=parameters.statusId value=PRTYASGN_ASSIGNED/
+
+if-not-empty field=parameters.workEffortId
+set field=workEffortId
from-field=parameters.workEffortId/
+/if-not-empty
+if-empty field=parameters.workEffortId
+set field=parameters.workEffortId
from-field=productionRunId/
+set field=workEffortId from-field=productionRunId/
+/if-empty

Re: svn commit: r1659914 - in /ofbiz/trunk/applications/manufacturing: config/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ webapp/manufacturing/WEB-INF/actions

2015-02-15 Thread Jacques Le Roux


Indeed, I thought you were speaking about labels. So it's only labels values.

A new CommonParties seems the best label to replace them all.
I will do so if nobody disagree

Jacques


Le 15/02/2015 18:57, Adrian Crum a écrit :

Search *.xml for Parties.

This commit adds another duplicate label.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 2/15/2015 9:52 AM, Jacques Le Roux wrote:

Are you sure? I can't find any locally (trunk HEAD), and would this
relates to this commit?

Jacques

Le 15/02/2015 15:38, Adrian Crum a écrit :

We have 6 duplicate Parties UI labels.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 2/15/2015 3:38 AM, jler...@apache.org wrote:

Author: jleroux
Date: Sun Feb 15 11:38:46 2015
New Revision: 1659914

URL: http://svn.apache.org/r1659914
Log:
A patch from Pierre Smits for
Have parties to be assigned to production run tasks
https://issues.apache.org/jira/browse/OFBIZ-5706
It is not possible to assign parties to execute one or more task in a
production run.

And
ProductionRun doesn't capture and show manufacturing organisation
https://issues.apache.org/jira/browse/OFBIZ-5709
The production run should capture the manufacturing (internal)
organisation on creation.

Modified:
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml

ofbiz/trunk/applications/manufacturing/servicedef/services_production_run.xml

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ProductionRunDeclaration.groovy

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy

ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/JobshopScreens.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/ManufacturingMenus.xml

ofbiz/trunk/applications/manufacturing/widget/manufacturing/ProductionRunForms.xml


Modified:
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml?rev=1659914r1=1659913r2=1659914view=diff

==

---
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
(original)
+++
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
Sun Feb 15 11:38:46 2015
@@ -19,6 +19,9 @@
  under the License.
  --
  resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/ofbiz-properties.xsd;

+property key=AddParty
+value xml:lang=enAdd Party/value
+/property
  property key=FormFieldTitle_allocatedCost
  value xml:lang=deVerrechnete Kosten/value
  value xml:lang=enAllocated Cost/value
@@ -3771,6 +3774,10 @@
  value
xml:lang=zhçäº§è¿è¡æ´æ°å¤±è´¥ï¼è¯·æ¥çæ¥å¿äºè§£è¯¦ç»ä¿¡æ¯/value

  value
xml:lang=zh-TWçç¢éè¡æ´æ°å¤±æ,è«æª¢è¦æ¥èªçè§£è©³ç´°è³è¨/value

  /property
+property key=ManufacturingProductionRunParties
+value xml:lang=enParties/value
+value xml:lang=nlPartijen/value
+/property
  property key=ManufacturingProductionRunPrintDocuments
  value xml:lang=deDokumente fÃ¼r Produktionsauftrage
drucken/value
  value xml:lang=enProduction Run Print Documents/value

Modified:
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml

URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml?rev=1659914r1=1659913r2=1659914view=diff 



==

---
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
(original)
+++
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
Sun Feb 15 11:38:46 2015
@@ -20,7 +20,36 @@ under the License.

  simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd;

-
+
+
+simple-method method-name=createProductionRunPartyAssign
+short-description=Assign the selected party to the
production run or task
+
+set field=productionRunId
from-field=parameters.productionRunId/
+set field=partyId from-field=parameters.partyId/
+set field=roleTypeId from-field=parameters.roleTypeId/
+set field=statusId value=PRTYASGN_ASSIGNED/
+set field=parameters.statusId value=PRTYASGN_ASSIGNED/
+
+if-not-empty field=parameters.workEffortId
+set field=workEffortId
from-field=parameters.workEffortId

Re: svn commit: r1659914 - in /ofbiz/trunk/applications/manufacturing: config/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ webapp/manufacturing/WEB-INF/actions

2015-02-15 Thread Deepak Dixit

inline:

 On Feb 15, 2015, at 5:08 PM, jler...@apache.org wrote:
 
 Author: jleroux
 Date: Sun Feb 15 11:38:46 2015
 New Revision: 1659914
 
 URL: http://svn.apache.org/r1659914
 Log:
 A patch from Pierre Smits for 
 Have parties to be assigned to production run tasks 
 https://issues.apache.org/jira/browse/OFBIZ-5706
 It is not possible to assign parties to execute one or more task in a 
 production run.
 
 And
 ProductionRun doesn't capture and show manufacturing organisation 
 https://issues.apache.org/jira/browse/OFBIZ-5709
 The production run should capture the manufacturing (internal) organisation 
 on creation.
 
 Modified:
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml

 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml

 ofbiz/trunk/applications/manufacturing/servicedef/services_production_run.xml

 ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ProductionRunDeclaration.groovy

 ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy

 ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml

 ofbiz/trunk/applications/manufacturing/widget/manufacturing/JobshopScreens.xml

 ofbiz/trunk/applications/manufacturing/widget/manufacturing/ManufacturingMenus.xml

 ofbiz/trunk/applications/manufacturing/widget/manufacturing/ProductionRunForms.xml
 
 Modified: 
 ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml?rev=1659914r1=1659913r2=1659914view=diff
 ==
 --- ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml 
 (original)
 +++ ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml 
 Sun Feb 15 11:38:46 2015
 @@ -19,6 +19,9 @@
 under the License.
 --
 resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; 
 xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/ofbiz-properties.xsd;
 +property key=AddParty
 +value xml:lang=enAdd Party/value
 +/property
 property key=FormFieldTitle_allocatedCost
 value xml:lang=deVerrechnete Kosten/value
 value xml:lang=enAllocated Cost/value
 @@ -3771,6 +3774,10 @@
 value 
 xml:lang=zhçäº§è¿è¡æ´æ°å¤±è´¥ï¼è¯·æ¥çæ¥å¿äºè§£è¯¦ç»ä¿¡æ¯/value
 value 
 xml:lang=zh-TWçç¢éè¡æ´æ°å¤±æ,è«æª¢è¦æ¥èªçè§£è©³ç´°è³è¨/value
 /property
 +property key=ManufacturingProductionRunParties
 +value xml:lang=enParties/value
 +value xml:lang=nlPartijen/value
 +/property
 property key=ManufacturingProductionRunPrintDocuments
 value xml:lang=deDokumente fÃ¼r Produktionsauftrage 
 drucken/value
 value xml:lang=enProduction Run Print Documents/value
 
 Modified: 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml?rev=1659914r1=1659913r2=1659914view=diff
 ==
 --- 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
  (original)
 +++ 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
  Sun Feb 15 11:38:46 2015
 @@ -20,7 +20,36 @@ under the License.
 
 simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
 
 xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd;
 -
 +
 +
 +simple-method method-name=createProductionRunPartyAssign 
 +short-description=Assign the selected party to the production run 
 or task
 +
 +set field=productionRunId 
 from-field=parameters.productionRunId/
 +set field=partyId from-field=parameters.partyId/
 +set field=roleTypeId from-field=parameters.roleTypeId/
 +set field=statusId value=PRTYASGN_ASSIGNED/
 +set field=parameters.statusId value=PRTYASGN_ASSIGNED/
 +
 +if-not-empty field=parameters.workEffortId
 +set field=workEffortId from-field=parameters.workEffortId/
 +/if-not-empty
 +if-empty field=parameters.workEffortId
 +set field=parameters.workEffortId 
 from-field=productionRunId/
 +set field=workEffortId from-field=productionRunId/
 +/if-empty
 +
 +entity-one entity-name=WorkEffort value-field=workEffort/
 +set field=fromDate from-field=workEffort.estimatedStartDate/
 +set field=statusDateTime 
 from-field=workEffort.estimatedStartDate/
 +set

Re: svn commit: r1610918 - in /ofbiz/trunk: applications/accounting/script/org/ofbiz/accounting/agreement/ applications/accounting/widget/ applications/manufacturing/script/org/ofbiz/manufacturing/bom

2014-07-16 Thread Jacques Le Roux


Hi Jacopo,

Are you aware this does not compile?

Jacques

Le 16/07/2014 09:16, jaco...@apache.org a écrit :

Author: jacopoc
Date: Wed Jul 16 07:16:15 2014
New Revision: 1610918

URL: http://svn.apache.org/r1610918
Log:
Fixed miscellaneous errors spotted while reviewing the logs generated by the 
ArtifactInfo tool.

Modified:
 
ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
 ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml
 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 
ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml
 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/picklist/PicklistServices.xml
 ofbiz/trunk/framework/common/webcommon/WEB-INF/portal-controller.xml
 
ofbiz/trunk/framework/webtools/src/org/ofbiz/webtools/artifactinfo/ServiceArtifactInfo.java

Modified: 
ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml?rev=1610918r1=1610917r2=1610918view=diff
==
--- 
ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
 (original)
+++ 
ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
 Wed Jul 16 07:16:15 2014
@@ -100,12 +100,12 @@ under the License.
  /iterate
  /if-compare
  if-compare field=parameters.copyAgreementFacilities value=Y 
operator=equals
-get-related value-field=agreement relation-name=AgreementFaclityAppl 
list=agreementFaclityAppls/
-iterate list=agreementFaclityAppls entry=agreementFaclityAppl
-clear-field field=createAgreementFaclityApplInMap/
-set-service-fields service-name=createAgreementFaclityAppl 
to-map=createAgreementFaclityApplInMap map=agreementFaclityAppl/
-set from-field=agreementIdTo 
field=createAgreementFaclityApplInMap.agreementId/
-call-service service-name=createAgreementFaclityAppl 
in-map-name=createAgreementFaclityApplInMap/
+get-related value-field=agreement relation-name=AgreementFacilityAppl 
list=agreementFacilityAppls/
+iterate list=agreementFacilityAppls 
entry=agreementFacilityAppl
+clear-field field=createAgreementFacilityApplInMap/
+set-service-fields service-name=createAgreementFacilityAppl 
to-map=createAgreementFacilityApplInMap map=agreementFacilityAppl/
+set from-field=agreementIdTo 
field=createAgreementFacilityApplInMap.agreementId/
+call-service service-name=createAgreementFacilityAppl 
in-map-name=createAgreementFacilityApplInMap/
  /iterate
  /if-compare
  if-compare field=parameters.copyAgreementParties value=Y 
operator=equals

Modified: ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml?rev=1610918r1=1610917r2=1610918view=diff
==
--- ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml (original)
+++ ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml Wed Jul 16 
07:16:15 2014
@@ -485,9 +485,6 @@ under the License.
  screenlet 
title=${uiLabelMap.AccountingAgreementItem}
  include-form name=ViewAgreementItemInfoForReport 
location=component://accounting/widget/AgreementForms.xml/
  /screenlet
-screenlet 
title=${uiLabelMap.AccountingAgreementItemFacilitiesForReport}
-include-form name=ListAgreementItemFacilitiesForReport 
location=component://accounting/widget/AgreementForms.xml/
-/screenlet
  /decorator-section
  /decorator-screen
  /widgets

Modified: 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml?rev=1610918r1=1610917r2=1610918view=diff
==
--- 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 Wed Jul 16 07:16:15 2014
@@ -25,7 +25,6 @@ under the License.
  if-empty field=parameters.fromDate
  now-timestamp field=parameters.fromDate/
  /if-empty
-set field

Re: svn commit: r1610918 - in /ofbiz/trunk: applications/accounting/script/org/ofbiz/accounting/agreement/ applications/accounting/widget/ applications/manufacturing/script/org/ofbiz/manufacturing/bom

2014-07-16 Thread Jacopo Cappellato

yeah, sorry for this, I am fixing it now.

Jacopo

On Jul 16, 2014, at 9:39 AM, Jacques Le Roux jacques.le.r...@les7arts.com 
wrote:

 Hi Jacopo,
 
 Are you aware this does not compile?
 
 Jacques
 
 Le 16/07/2014 09:16, jaco...@apache.org a écrit :
 Author: jacopoc
 Date: Wed Jul 16 07:16:15 2014
 New Revision: 1610918
 
 URL: http://svn.apache.org/r1610918
 Log:
 Fixed miscellaneous errors spotted while reviewing the logs generated by the 
 ArtifactInfo tool.
 
 Modified:
 
 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
 ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml
 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 
 ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml
 
 ofbiz/trunk/applications/product/script/org/ofbiz/shipment/picklist/PicklistServices.xml
 ofbiz/trunk/framework/common/webcommon/WEB-INF/portal-controller.xml
 
 ofbiz/trunk/framework/webtools/src/org/ofbiz/webtools/artifactinfo/ServiceArtifactInfo.java
 
 Modified: 
 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml?rev=1610918r1=1610917r2=1610918view=diff
 ==
 --- 
 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
  (original)
 +++ 
 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
  Wed Jul 16 07:16:15 2014
 @@ -100,12 +100,12 @@ under the License.
  /iterate
  /if-compare
  if-compare field=parameters.copyAgreementFacilities value=Y 
 operator=equals
 -get-related value-field=agreement 
 relation-name=AgreementFaclityAppl list=agreementFaclityAppls/
 -iterate list=agreementFaclityAppls 
 entry=agreementFaclityAppl
 -clear-field field=createAgreementFaclityApplInMap/
 -set-service-fields 
 service-name=createAgreementFaclityAppl 
 to-map=createAgreementFaclityApplInMap map=agreementFaclityAppl/
 -set from-field=agreementIdTo 
 field=createAgreementFaclityApplInMap.agreementId/
 -call-service service-name=createAgreementFaclityAppl 
 in-map-name=createAgreementFaclityApplInMap/
 +get-related value-field=agreement 
 relation-name=AgreementFacilityAppl list=agreementFacilityAppls/
 +iterate list=agreementFacilityAppls 
 entry=agreementFacilityAppl
 +clear-field field=createAgreementFacilityApplInMap/
 +set-service-fields 
 service-name=createAgreementFacilityAppl 
 to-map=createAgreementFacilityApplInMap map=agreementFacilityAppl/
 +set from-field=agreementIdTo 
 field=createAgreementFacilityApplInMap.agreementId/
 +call-service service-name=createAgreementFacilityAppl 
 in-map-name=createAgreementFacilityApplInMap/
  /iterate
  /if-compare
  if-compare field=parameters.copyAgreementParties value=Y 
 operator=equals
 
 Modified: ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml?rev=1610918r1=1610917r2=1610918view=diff
 ==
 --- ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml 
 (original)
 +++ ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml Wed Jul 
 16 07:16:15 2014
 @@ -485,9 +485,6 @@ under the License.
  screenlet 
 title=${uiLabelMap.AccountingAgreementItem}
  include-form 
 name=ViewAgreementItemInfoForReport 
 location=component://accounting/widget/AgreementForms.xml/
  /screenlet
 -screenlet 
 title=${uiLabelMap.AccountingAgreementItemFacilitiesForReport}
 -include-form 
 name=ListAgreementItemFacilitiesForReport 
 location=component://accounting/widget/AgreementForms.xml/
 -/screenlet
  /decorator-section
  /decorator-screen
  /widgets
 
 Modified: 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml?rev=1610918r1=1610917r2=1610918view=diff
 ==
 --- 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
  (original)
 +++ 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz

Re: svn commit: r1610918 - in /ofbiz/trunk: applications/accounting/script/org/ofbiz/accounting/agreement/ applications/accounting/widget/ applications/manufacturing/script/org/ofbiz/manufacturing/bom

2014-07-16 Thread Jacopo Cappellato

fixed, thank you Jacques.

Jacopo

On Jul 16, 2014, at 9:55 AM, Jacopo Cappellato jacopo.cappell...@gmail.com 
wrote:

 yeah, sorry for this, I am fixing it now.
 
 Jacopo
 
 On Jul 16, 2014, at 9:39 AM, Jacques Le Roux jacques.le.r...@les7arts.com 
 wrote:
 
 Hi Jacopo,
 
 Are you aware this does not compile?
 
 Jacques
 
 Le 16/07/2014 09:16, jaco...@apache.org a écrit :
 Author: jacopoc
 Date: Wed Jul 16 07:16:15 2014
 New Revision: 1610918
 
 URL: http://svn.apache.org/r1610918
 Log:
 Fixed miscellaneous errors spotted while reviewing the logs generated by 
 the ArtifactInfo tool.
 
 Modified:

 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml

 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml

 ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml

 ofbiz/trunk/applications/product/script/org/ofbiz/shipment/picklist/PicklistServices.xml
ofbiz/trunk/framework/common/webcommon/WEB-INF/portal-controller.xml

 ofbiz/trunk/framework/webtools/src/org/ofbiz/webtools/artifactinfo/ServiceArtifactInfo.java
 
 Modified: 
 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml?rev=1610918r1=1610917r2=1610918view=diff
 ==
 --- 
 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
  (original)
 +++ 
 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
  Wed Jul 16 07:16:15 2014
 @@ -100,12 +100,12 @@ under the License.
 /iterate
 /if-compare
 if-compare field=parameters.copyAgreementFacilities value=Y 
 operator=equals
 -get-related value-field=agreement 
 relation-name=AgreementFaclityAppl list=agreementFaclityAppls/
 -iterate list=agreementFaclityAppls 
 entry=agreementFaclityAppl
 -clear-field field=createAgreementFaclityApplInMap/
 -set-service-fields 
 service-name=createAgreementFaclityAppl 
 to-map=createAgreementFaclityApplInMap map=agreementFaclityAppl/
 -set from-field=agreementIdTo 
 field=createAgreementFaclityApplInMap.agreementId/
 -call-service service-name=createAgreementFaclityAppl 
 in-map-name=createAgreementFaclityApplInMap/
 +get-related value-field=agreement 
 relation-name=AgreementFacilityAppl list=agreementFacilityAppls/
 +iterate list=agreementFacilityAppls 
 entry=agreementFacilityAppl
 +clear-field field=createAgreementFacilityApplInMap/
 +set-service-fields 
 service-name=createAgreementFacilityAppl 
 to-map=createAgreementFacilityApplInMap map=agreementFacilityAppl/
 +set from-field=agreementIdTo 
 field=createAgreementFacilityApplInMap.agreementId/
 +call-service service-name=createAgreementFacilityAppl 
 in-map-name=createAgreementFacilityApplInMap/
 /iterate
 /if-compare
 if-compare field=parameters.copyAgreementParties value=Y 
 operator=equals
 
 Modified: ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml?rev=1610918r1=1610917r2=1610918view=diff
 ==
 --- ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml 
 (original)
 +++ ofbiz/trunk/applications/accounting/widget/AgreementScreens.xml Wed Jul 
 16 07:16:15 2014
 @@ -485,9 +485,6 @@ under the License.
 screenlet 
 title=${uiLabelMap.AccountingAgreementItem}
 include-form 
 name=ViewAgreementItemInfoForReport 
 location=component://accounting/widget/AgreementForms.xml/
 /screenlet
 -screenlet 
 title=${uiLabelMap.AccountingAgreementItemFacilitiesForReport}
 -include-form 
 name=ListAgreementItemFacilitiesForReport 
 location=component://accounting/widget/AgreementForms.xml/
 -/screenlet
 /decorator-section
 /decorator-screen
 /widgets
 
 Modified: 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml?rev=1610918r1=1610917r2=1610918view=diff
 ==
 --- 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom

Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing: config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ widget/manufacturing/

2014-04-25 Thread Jacques Le Roux

This is actually a bug fix and another Jira issue is open for it: OFBIZ-5224. I guess it slipped in Pierre's OFBIZ-5523 patch. In a sense Pierre is 
correct, and I checked the 1st part (simple-methods below) when I reviewed his 1st patch for OFBIZ-5523 some months ago


The simple-method issueProductionRunTaskComponent implements the service of 
same name which is called by  issueProductionRunTask, which correctly sets
if-empty field=parameters.failIfItemsAreNotOnHand
set field=parameters.failIfItemsAreNotOnHand value=Y/
/if-empty
before calling issueProductionRunTaskComponent

But that's not all the story. Unfortunately, 1st time I did not check another call by updateProductionRunTask Java services, failIfItemsAreNotOnHand 
is not set there , so the solution before was correct in this case.


I would revert this change, fixe both issues in another commit and backport and 
close OFBIZ-5224, but I will wait Pierre's answer OFBIZ-5224 before.

Jacques

Le 25/04/2014 07:24, Jacopo Cappellato a écrit :

On Apr 24, 2014, at 10:23 PM, jler...@apache.org wrote:


 simple-method method-name=issueProductionRunTask short-description=Issues the Inventory 
for a Production Run Task login-required=false
 entity-one entity-name=WorkEffort value-field=workEffort/
@@ -159,7 +174,7 @@ under the License.
 if
 condition
 or
-if-empty 
field=parameters.failIfItemsAreNotOnHand/
+if-compare field=parameters.failIfItemsAreNotAvailable 
operator=equals value=Y type=String/
 if-compare field=parameters.failIfItemsAreNotOnHand operator=equals 
value=Y type=String/
 /or
 /condition

I suspect this should not be part of the commit.

Jacopo

Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing: config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ widget/manufacturing/

2014-04-25 Thread Jacopo Cappellato


On Apr 25, 2014, at 2:27 PM, Jacques Le Roux jacques.le.r...@free.fr wrote:

 This is actually a bug fix and another Jira issue is open for it: OFBIZ-5224.

I had closed that issue as a Not a Problem: please see my comments there.
That code should be reverted.

Jacopo

Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing: config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ widget/manufacturing/

2014-04-25 Thread Jacques Le Roux


OK, makes sense now, would have been easier if Pierre have responded in time

Reverted this line at r1590063

Jacques

Le 25/04/2014 16:39, Jacopo Cappellato a écrit :

On Apr 25, 2014, at 2:27 PM, Jacques Le Roux jacques.le.r...@free.fr wrote:


This is actually a bug fix and another Jira issue is open for it: OFBIZ-5224.

I had closed that issue as a Not a Problem: please see my comments there.
That code should be reverted.

Jacopo

Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing: config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ widget/manufacturing/

2014-04-25 Thread Pierre Smits

I must apologize to you both for you spending your time on OFBIZ-5224.
Having spend some time the last few days on the context of the issue I came
to realise that the patch I provided would not be better than the situation
it tries to alleviate. It would just flip the coin. And that wouldn't be in
the best interest of this community or the users of the output of this
project.

Regards,

Pierre Smits

*ORRTIZ.COM http://www.orrtiz.com*
Services  Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail  Trade
http://www.orrtiz.com


On Fri, Apr 25, 2014 at 5:50 PM, Jacques Le Roux jacques.le.r...@free.frwrote:

 OK, makes sense now, would have been easier if Pierre have responded in
 time

 Reverted this line at r1590063

 Jacques

 Le 25/04/2014 16:39, Jacopo Cappellato a écrit :

  On Apr 25, 2014, at 2:27 PM, Jacques Le Roux jacques.le.r...@free.fr
 wrote:

  This is actually a bug fix and another Jira issue is open for it:
 OFBIZ-5224.

 I had closed that issue as a Not a Problem: please see my comments there.
 That code should be reverted.

 Jacopo

Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing: config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ widget/manufacturing/

2014-04-25 Thread Jacques Le Roux


Thanks Pierre, it's clear now

Jacques

Le 25/04/2014 23:25, Pierre Smits a écrit :

I must apologize to you both for you spending your time on OFBIZ-5224.
Having spend some time the last few days on the context of the issue I came
to realise that the patch I provided would not be better than the situation
it tries to alleviate. It would just flip the coin. And that wouldn't be in
the best interest of this community or the users of the output of this
project.

Regards,

Pierre Smits

*ORRTIZ.COM http://www.orrtiz.com*
Services  Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail  Trade
http://www.orrtiz.com


On Fri, Apr 25, 2014 at 5:50 PM, Jacques Le Roux jacques.le.r...@free.frwrote:


OK, makes sense now, would have been easier if Pierre have responded in
time

Reverted this line at r1590063

Jacques

Le 25/04/2014 16:39, Jacopo Cappellato a écrit :

  On Apr 25, 2014, at 2:27 PM, Jacques Le Roux jacques.le.r...@free.fr

wrote:

  This is actually a bug fix and another Jira issue is open for it:

OFBIZ-5224.


I had closed that issue as a Not a Problem: please see my comments there.
That code should be reverted.

Jacopo

Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing: config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ widget/manufacturing/

2014-04-24 Thread Jacopo Cappellato


On Apr 24, 2014, at 10:23 PM, jler...@apache.org wrote:

 simple-method method-name=issueProductionRunTask 
 short-description=Issues the Inventory for a Production Run Task 
 login-required=false
 entity-one entity-name=WorkEffort value-field=workEffort/
 @@ -159,7 +174,7 @@ under the License.
 if
 condition
 or
 -if-empty 
 field=parameters.failIfItemsAreNotOnHand/
 +if-compare 
 field=parameters.failIfItemsAreNotAvailable operator=equals value=Y 
 type=String/
 if-compare 
 field=parameters.failIfItemsAreNotOnHand operator=equals value=Y 
 type=String/
 /or
 /condition

I suspect this should not be part of the commit.

Jacopo

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Jacques Le Roux


Hi Adam,

I don't know what others think about that, but personnally I don't like it. For 
instance we get now from beginning of the line
(trailers blanks included)

'GenericValue refurbItemAssoc =
EntityUtil.getFirst(EntityUtil.filterByDate(product.getRelated(MainProductAssoc, 
UtilMisc.toMap(productAssocTypeId,
PRODUCT_REFURB),'
214 chars
'repsCustomers =
EntityUtil.filterByDate(userLogin.getRelatedOne(Party).getRelatedByAnd(FromPartyRelationship,
 UtilMisc.toMap(roleTypeIdFrom,
AGENT, roleTypeIdTo, CUSTOMER, partyIdTo, partyId)));'
232 chars
'repsCustomers =
EntityUtil.filterByDate(userLogin.getRelatedOne(Party).getRelatedByAnd(FromPartyRelationship,
 UtilMisc.toMap(roleTypeIdFrom,
SALES_REP, roleTypeIdTo, CUSTOMER, partyIdTo, partyId)));
241 chars

'ListGenericValue productAssocs = 
EntityUtil.filterByDate(product.getRelatedCache(MainProductAssoc,
UtilMisc.toMap(productAssocTypeId, PRODUCT_VARIANT), 
UtilMisc.toList(sequenceNum)));'
218 chars

'  #assign itemProductAssocList = 
cartLine.getProduct().getRelated(MainProductAssoc,
Static[org.ofbiz.base.util.UtilMisc].toList(productAssocTypeId, 
sequenceNum))?if_exists/'
195 chars
'ListGenericValue variantProductFeatureAndAppls = 
variant.getRelated(ProductFeatureAndAppl,
UtilMisc.toMap(productFeatureTypeId, productFeatureTypeId, productFeatureApplTypeId, 
STANDARD_FEATURE, description,
description), null);'
271 chars
' if (UtilValidate.isNotEmpty(instanceProduct)  EntityTypeUtil.hasParentType(delegator, 
ProductType, productTypeId,
instanceProduct.getString(productTypeId), parentTypeId, AGGREGATED)) {
205 chars

I don't know which screen size you use, but for me those lines are too long.

Some time ago, I suggested that we could get a consensus on the maximum code 
lines length. Eclipse (and I guess most IDEs) is able
then to format/split/wrap the lines on this basis.
Rules and best practices are sometimes preventing creativity, but I don't think 
in this case, it's a problem.

Personaly I think that around 180 shoud be a maximum. I have attached My Java 
code formatter at the
https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions page as 
an example.

Jacques


From: doo...@apache.org

Author: doogie
Date: Tue May 29 04:10:11 2012
New Revision: 1343472

URL: http://svn.apache.org/viewvc?rev=1343472view=rev
Log:
OPTIMIZE: Join a few overly long split lines.

Modified:
   
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java
   
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceWorker.java
   
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMTree.java
   
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRun.java
   
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
   ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
   
ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReturnServices.java
   ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
   
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java
   ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/showcartitems.ftl
   
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductEvents.java
   
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductServices.java
   
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
   
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/thirdparty/usps/UspsServices.java

Modified: 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java?rev=1343472r1=1343471r2=1343472view=diff
==
--- 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java
 (original)
+++ 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java
 Tue May 29 04:10:11 2012
@@ -333,8 +333,7 @@ public class InvoiceServices {
// for purchase orders, the pay to address is the 
BILLING_LOCATION of the vendor
GenericValue billFromVendor = 
orh.getPartyFromRole(BILL_FROM_VENDOR);
if (billFromVendor != null) {
-ListGenericValue billingContactMechs =
billFromVendor.getRelatedOne(Party).getRelatedByAnd(PartyContactMechPurpose,
-UtilMisc.toMap(contactMechPurposeTypeId, 
BILLING_LOCATION));
+ListGenericValue billingContactMechs =
billFromVendor.getRelatedOne(Party

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Adam Heath


On 06/02/2012 11:51 AM, Jacques Le Roux wrote:

Hi Adam,

I don't know what others think about that, but personnally I don't like
it. For instance we get now from beginning of the line
(trailers blanks included)


The terminal on my laptop is 198 chars.  At work it's 147.  But that 
doesn't matter.


I only combined lines that were affected by the deprecation that I've 
been doing.  I didn't do it to all files.


Also, in several of those files, they were not self-consistent.  Some 
times, even in the same method, and in the same general area of the 
method, some lines were split, and some were all on a single line.  And 
the split wasn't consistent.


There is no way that we can ever enforce a single, unified width. 
Screen sizes change, font sizes change.  It's too political to come up 
with a solution.


So, the only fallback is to never split.  Then it is up to each 
end-developer to modify their display to handle the long lines.


ps: This is similiar to svn storing files in the repo with one kind of 
line-ending, then upon checkout(or when checking-in), it converts 
automatically.


ppd: This is also similiar to keyword expansion; it happens at checkout 
time, but the repo stores it unmodified.

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Jacopo Cappellato


On Jun 2, 2012, at 7:15 PM, Adam Heath wrote:

 There is no way that we can ever enforce a single, unified width. Screen 
 sizes change, font sizes change.  It's too political to come up with a 
 solution.
 
 So, the only fallback is to never split.  Then it is up to each end-developer 
 to modify their display to handle the long lines.

I would instead prefer the following guideline: There is no upper limit to 
line width; only split long lines if it increases readability of the code.

Jacopo

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Adam Heath


On 06/02/2012 01:06 PM, Jacopo Cappellato wrote:


On Jun 2, 2012, at 7:15 PM, Adam Heath wrote:


There is no way that we can ever enforce a single, unified width. Screen sizes 
change, font sizes change.  It's too political to come up with a solution.

So, the only fallback is to never split.  Then it is up to each end-developer 
to modify their display to handle the long lines.


I would instead prefer the following guideline: There is no upper limit to line 
width; only split long lines if it increases readability of the code.


That's fine too.  I do the same, when embedding a toMap-type call in the 
middle of a method invocation, and I forsee the need to add/remove 
fields in the future.


In the commit you commented on, I believe I only combined lines that 
seemed to be arbitrarily split on individual method arguments, due to 
some random screen width.  It never really seemed at all consistent.


I also don't really see the need to go thru and force-reformat 
everything.  Just do it as we run into stuff.  However, I would prefer 
it if such reformatting changes were committed separately, and not mixed 
in with other real stuff.

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Jacopo Cappellato


On Jun 2, 2012, at 8:10 PM, Adam Heath wrote:

 In the commit you commented on,

Oh no, it was Jacques not me :-)

Jacopo

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Adam Heath


On 06/02/2012 01:14 PM, Jacopo Cappellato wrote:


On Jun 2, 2012, at 8:10 PM, Adam Heath wrote:


In the commit you commented on,


Oh no, it was Jacques not me :-)

Jacopo


No, really, I don't get you two confused.  I just wasn't paying 
attention.  I've only had half a cup of coffee today.

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Jacques Le Roux


Adam Heath wrote:

On 06/02/2012 01:06 PM, Jacopo Cappellato wrote:


On Jun 2, 2012, at 7:15 PM, Adam Heath wrote:


There is no way that we can ever enforce a single, unified width. Screen sizes 
change, font sizes change.  It's too political
to come up with a solution. So, the only fallback is to never split.  Then it is up to each end-developer to modify their 
display to handle the long lines.


I would instead prefer the following guideline: There is no upper limit to 
line width; only split long lines if it increases
readability of the code.


That's fine too.  I do the same, when embedding a toMap-type call in the
middle of a method invocation, and I forsee the need to add/remove
fields in the future.



In the commit you commented on, I believe I only combined lines that
seemed to be arbitrarily split on individual method arguments, due to
some random screen width.  It never really seemed at all consistent.


You could still have cut them at the right place ;o)


I also don't really see the need to go thru and force-reformat
everything.  Just do it as we run into stuff.  However, I would prefer
it if such reformatting changes were committed separately, and not mixed
in with other real stuff.


Yes I also think it's a bad practise to reformat all: more useless reviews. Only when we rewrite/refactor makes sense or when it's 
really bad (seems that it was your case)


OK, let the creativity flows then...

This said Ctrl+I in Eclipse is still your friend. It's not just about max line length, but OK we already follow the Sun convention 
mostly


Chapter closed for me

Jacques

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Jacques Le Roux


Jacques Le Roux wrote:

Adam Heath wrote:

On 06/02/2012 01:06 PM, Jacopo Cappellato wrote:


On Jun 2, 2012, at 7:15 PM, Adam Heath wrote:


There is no way that we can ever enforce a single, unified width. Screen sizes 
change, font sizes change.  It's too political
to come up with a solution. So, the only fallback is to never split.  Then it 
is up to each end-developer to modify their
display to handle the long lines.


I would instead prefer the following guideline: There is no upper limit to 
line width; only split long lines if it increases
readability of the code.


That's fine too.  I do the same, when embedding a toMap-type call in the
middle of a method invocation, and I forsee the need to add/remove
fields in the future.



In the commit you commented on, I believe I only combined lines that
seemed to be arbitrarily split on individual method arguments, due to
some random screen width.  It never really seemed at all consistent.


You could still have cut them at the right place ;o)


I also don't really see the need to go thru and force-reformat
everything.  Just do it as we run into stuff.  However, I would prefer
it if such reformatting changes were committed separately, and not mixed
in with other real stuff.


Yes I also think it's a bad practise to reformat all: more useless reviews. 
Only when we rewrite/refactor makes sense or when it's
really bad (seems that it was your case)

OK, let the creativity flows then...

This said Ctrl+I in Eclipse is still your friend. It's not just about max line 
length, but OK we already follow the Sun convention
mostly


I meant Ctrl+Shift+F (default formatter key), since Ctrl+I  is only about 
indentation.

Jacques


Chapter closed for me

Jacques

Re: OFBIZ Manufacturing

2012-04-12 Thread Jacques Le Roux


Hi Jean-Luc, Pierre,

Just if you did not notice, thanks to Adrian, this discussion is now on user ML 
(does not belong me)
Please use the new thread there: http://markmail.org/message/gnn5ardilphvu5e7

Jacques

From: Jean-Luc Malet jeanluc.ma...@nereide.biz

Pierre,

I agree with Jacques on this point. ESB could be a difficult solution to install and to maintain with different third system. I 
think the SOAP and XML-RPC, that we already installed for our customers is a good way to do.


For the other question, we have customers experiences on manufacturing system and we have a good knowledge and expertise about 
manufacturing in general (most of them begun with BaaN ERP, in a manufacturing compagny) and also a good knowledge on the OFBiz 
manufacturing functionnalities. We intalled one of our first customer, which was a manufacturing company, in 2006. And last week, 
we installed another one which is a food manufacturing company.


So don't hesitate to contact us if we can help and explain us how we could help 
you in this project.

Regards,

--
Jean-Luc Malet
Directeur de Projet
Tel : 0974533612
Mob : 0687618801

Société Néréide
3b Les Isles 37270 Veretz
www.nereide.biz



Le 10/04/2012 23:39, Jacques Le Roux a écrit :
Just a word: it does not make sense to use an ESB like ServiceMix as long as it's not mandatory. In other words you may consider 
1st using OFBiz as much as possible, and use only an ESB if you need to integrate with other systems. Even then sometimes using 
SOAP or XML-RPC would be easier depending of the openness of third systems. RMI is faster but beware of troubleshooting it on a 
net with a lot of firewalls...


The beauty of OFBiz is that it comes already integrated. We know the ERP way (all integrated) has some drawbacks, but don't 
forget about drawbacks of other ways... OFBiz is not perfect but it works OOTB and can be easily enhanced... Some ESB projects 
have already proved to fail in the mid/long term...


You might be interested by
https://cwiki.apache.org/confluence/display/OFBIZ/Manufacturing+Process+Stories+and+Diagrams
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Related+Books#OFBizRelatedBooks-GettingStartedwithApacheOFBizManufacturingMRPin5EasySteps;(Release09.04andabove)
https://cwiki.apache.org/confluence/display/OFBREQDES/UBPL+Introduction
https://cwiki.apache.org/confluence/display/OFBREQDES/Universal+Business+Process+Library+Index

But this topic is more for the user list...

Jacques

From: Integrin info.integ...@gmail.com

Pierre -

While I do not claim to be an expert in Manufacturing, I'm helping
customize Ofbiz for a Food Sevices Industry in a Franchise Model where
Ofbiz Manufacturing be the food kitchen; Additionally the following
modules, being used
- MyPortal  : Dashboard
- Order Manager: Purchase , Sales Orders, Transfer Orders
- Party Manager : Suppliers, Users  Customers
- SFA : Sales Forecast
- Facility : Inventory  Shipping
-Manufacturing: MRP in Manufacturing, very handy for automating
Requirements management

As far as ESB integration goes, Ofbiz being based on Service based
Architecture, should come very handy; I'm guessing you will have some
work to do to be able to make individual modules, loosely coupled
using ESB

Goodluck with your efforts!

- Regards
Sakthi

On 4/10/12, Pierre Smits pierre.sm...@gmail.com wrote:

Dear all,

Currently I am participating in the collaboration project IMAGINE -
Innovative End-to-End Management of Dynamic Manufacturing Networks, that
resides under the theme  Virtual Factories and Enterprises as part of the
FP7 Programme of the EU.

The goal of this project is to enable SME Manufacturing Enterprises in the
EU market space to shorten the time-to-market of their product by assisting
manufacturing customers in forming partnerships with suppliers and a better
exchange of information and data throughout the lifecycle of the
partnership.

During methodology studies it is envisioned that exchange of information
and data entails 4 interlocking areas, namely:

   1. Partner blueprints - All static information (and data) re
   organization and human entities, including connection mechanisms
(addresses
   and such) of the participating organization
   2. Manufacture blueprints - All static information (and data) re
   products (e.g. pricing, QoS re delivery, mBOM's, eBOM's and such)
   3. End-2-End blueprints - All dynamic information (and data) re inputs
   and output of the process segments, in customer to supplier end-2-end
   processes while manufacturing the goods (but also including process
   definitions in BPEL, BPMN and xPDL)
   4. QA blueprints - All information (and data) relating to maintaining
   the QoS requirements of the organization and establishing/enhancing trust
   between (potential) partners (encompassing org. certification, e.g. ISO
   9000, but also product certification, and more)

All to be facilitated through established Open Standards and Technolgies.

In the methodology studies

Re: OFBIZ Manufacturing

2012-04-11 Thread Pierre Smits

Hi Jacques, all,


First of all: you are right. If there weren't a need for solution you
wouldn't go that way.

But as it happens, within the consortium of the project there are partners
who have implemented ESB's (and for the sake of the argument let's pretend
that in the European market space every variant ESB is implemented) and
allow only to be connected through their ESB.

And also the IMAGINE platform is expected to have an ESB as part of the
architecture, but that hasn't been formalized yet. So that may change.

So what needs to be done so that OFBiz can connect to an ESB and that info
and data is delivered through that ESB to either the portal in the IMAGINE
platform or the partner with his system at the other end of the ESB?

Secondly:
OFBiz is also a solution for manufacturing. We have the code in place. But
how good is it? Are there endusers who use that component and how?

I have seen and read the book you referred to, and have worked to the code
to understand its principles. But like I said I don't have the experience
in implementing a manufacturing solution, so I don't know what it all
entails. That's why I invite everybody to share their insights.

Regarding,

Pierre




Op 10 april 2012 23:39 schreef Jacques Le Roux jacques.le.r...@les7arts.com
 het volgende:

 Just a word: it does not make sense to use an ESB like ServiceMix as long
 as it's not mandatory. In other words you may consider 1st using OFBiz as
 much as possible, and use only an ESB if you need to integrate with other
 systems. Even then sometimes using SOAP or XML-RPC would be easier
 depending of the openness of third systems. RMI is faster but beware of
 troubleshooting it on a net with a lot of firewalls...

 The beauty of OFBiz is that it comes already integrated. We know the ERP
 way (all integrated) has some drawbacks, but don't forget about drawbacks
 of other ways... OFBiz is not perfect but it works OOTB and can be easily
 enhanced... Some ESB projects have already proved to fail in the mid/long
 term...

 You might be interested by
 https://cwiki.apache.org/**confluence/display/OFBIZ/**
 Manufacturing+Process+Stories+**and+Diagramshttps://cwiki.apache.org/confluence/display/OFBIZ/Manufacturing+Process+Stories+and+Diagrams
 https://cwiki.apache.org/**confluence/display/OFBADMIN/**
 OFBiz+Related+Books#**OFBizRelatedBooks-https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Related+Books#OFBizRelatedBooks-
 **GettingStartedwithApacheOFBizM**anufacturingMRPin5EasySteps(**
 Release09.04andabove)
 https://cwiki.apache.org/**confluence/display/OFBREQDES/**
 UBPL+Introductionhttps://cwiki.apache.org/confluence/display/OFBREQDES/UBPL+Introduction
 https://cwiki.apache.org/**confluence/display/OFBREQDES/**
 Universal+Business+Process+**Library+Indexhttps://cwiki.apache.org/confluence/display/OFBREQDES/Universal+Business+Process+Library+Index

 But this topic is more for the user list...

 Jacques

 From: Integrin info.integ...@gmail.com

  Pierre -

 While I do not claim to be an expert in Manufacturing, I'm helping
 customize Ofbiz for a Food Sevices Industry in a Franchise Model where
 Ofbiz Manufacturing be the food kitchen; Additionally the following
 modules, being used
 - MyPortal  : Dashboard
 - Order Manager: Purchase , Sales Orders, Transfer Orders
 - Party Manager : Suppliers, Users  Customers
 - SFA : Sales Forecast
 - Facility : Inventory  Shipping
 -Manufacturing: MRP in Manufacturing, very handy for automating
 Requirements management

 As far as ESB integration goes, Ofbiz being based on Service based
 Architecture, should come very handy; I'm guessing you will have some
 work to do to be able to make individual modules, loosely coupled
 using ESB

 Goodluck with your efforts!

 - Regards
 Sakthi

 On 4/10/12, Pierre Smits pierre.sm...@gmail.com wrote:

 Dear all,

 Currently I am participating in the collaboration project IMAGINE -
 Innovative End-to-End Management of Dynamic Manufacturing Networks, that
 resides under the theme  Virtual Factories and Enterprises as part of
 the
 FP7 Programme of the EU.

 The goal of this project is to enable SME Manufacturing Enterprises in
 the
 EU market space to shorten the time-to-market of their product by
 assisting
 manufacturing customers in forming partnerships with suppliers and a
 better
 exchange of information and data throughout the lifecycle of the
 partnership.

 During methodology studies it is envisioned that exchange of information
 and data entails 4 interlocking areas, namely:

   1. Partner blueprints - All static information (and data) re
   organization and human entities, including connection mechanisms
 (addresses
   and such) of the participating organization
   2. Manufacture blueprints - All static information (and data) re
   products (e.g. pricing, QoS re delivery, mBOM's, eBOM's and such)
   3. End-2-End blueprints - All dynamic information (and data) re inputs
   and output of the process segments, in customer to supplier end-2-end

Re: OFBIZ Manufacturing

2012-04-11 Thread Pierre Smits

Hi Adrian,

Is there a JIRA for this issue?

Regards,

Pierre

Op 11 april 2012 12:28 schreef adrian.c...@sandglass-software.com het
volgende:

 I prefer to connect OFBiz to ESB via REST.

 Manufacturing works okay. I found a bug in the BOM that causes an out of
 memory error with large assemblies, but I haven't had time to fix it yet.

 -Adrian

 Quoting Pierre Smits pierre.sm...@gmail.com:

  Hi Jacques, all,


 First of all: you are right. If there weren't a need for solution you
 wouldn't go that way.

 But as it happens, within the consortium of the project there are partners
 who have implemented ESB's (and for the sake of the argument let's pretend
 that in the European market space every variant ESB is implemented) and
 allow only to be connected through their ESB.

 And also the IMAGINE platform is expected to have an ESB as part of the
 architecture, but that hasn't been formalized yet. So that may change.

 So what needs to be done so that OFBiz can connect to an ESB and that info
 and data is delivered through that ESB to either the portal in the IMAGINE
 platform or the partner with his system at the other end of the ESB?

 Secondly:
 OFBiz is also a solution for manufacturing. We have the code in place. But
 how good is it? Are there endusers who use that component and how?

 I have seen and read the book you referred to, and have worked to the code
 to understand its principles. But like I said I don't have the experience
 in implementing a manufacturing solution, so I don't know what it all
 entails. That's why I invite everybody to share their insights.

 Regarding,

 Pierre




 Op 10 april 2012 23:39 schreef Jacques Le Roux 
 jacques.le.r...@les7arts.com

 het volgende:


  Just a word: it does not make sense to use an ESB like ServiceMix as long
 as it's not mandatory. In other words you may consider 1st using OFBiz as
 much as possible, and use only an ESB if you need to integrate with other
 systems. Even then sometimes using SOAP or XML-RPC would be easier
 depending of the openness of third systems. RMI is faster but beware of
 troubleshooting it on a net with a lot of firewalls...

 The beauty of OFBiz is that it comes already integrated. We know the ERP
 way (all integrated) has some drawbacks, but don't forget about drawbacks
 of other ways... OFBiz is not perfect but it works OOTB and can be
 easily
 enhanced... Some ESB projects have already proved to fail in the mid/long
 term...

 You might be interested by
 https://cwiki.apache.org/confluence/display/OFBIZ/**https://cwiki.apache.org/**confluence/display/OFBIZ/**
 Manufacturing+Process+Stories+and+Diagramshttps://cwiki.**
 apache.org/confluence/display/**OFBIZ/Manufacturing+Process+**
 Stories+and+Diagramshttps://cwiki.apache.org/confluence/display/OFBIZ/Manufacturing+Process+Stories+and+Diagrams
 
 https://cwiki.apache.org/confluence/display/OFBADMIN/**https://cwiki.apache.org/**confluence/display/OFBADMIN/**
 OFBiz+Related+Books#OFBizRelatedBooks-https://**
 cwiki.apache.org/confluence/**display/OFBADMIN/OFBiz+**Related+Books#**
 OFBizRelatedBooks-https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Related+Books#OFBizRelatedBooks-
 
 GettingStartedwithApacheOFBizManufacturing**
 MRPin5EasySteps(**
 Release09.04andabove)
 https://cwiki.apache.org/confluence/display/OFBREQDES/https://cwiki.apache.org/**confluence/display/OFBREQDES/**
 UBPL+Introductionhttps://**cwiki.apache.org/confluence/**
 display/OFBREQDES/UBPL+**Introductionhttps://cwiki.apache.org/confluence/display/OFBREQDES/UBPL+Introduction
 
 https://cwiki.apache.org/confluence/display/OFBREQDES/https://cwiki.apache.org/**confluence/display/OFBREQDES/**
 Universal+Business+Process+Library+Indexhttps://cwiki.**
 apache.org/confluence/display/**OFBREQDES/Universal+Business+**
 Process+Library+Indexhttps://cwiki.apache.org/confluence/display/OFBREQDES/Universal+Business+Process+Library+Index
 


 But this topic is more for the user list...

 Jacques

 From: Integrin info.integ...@gmail.com

  Pierre -


 While I do not claim to be an expert in Manufacturing, I'm helping
 customize Ofbiz for a Food Sevices Industry in a Franchise Model where
 Ofbiz Manufacturing be the food kitchen; Additionally the following
 modules, being used
 - MyPortal  : Dashboard
 - Order Manager: Purchase , Sales Orders, Transfer Orders
 - Party Manager : Suppliers, Users  Customers
 - SFA : Sales Forecast
 - Facility : Inventory  Shipping
 -Manufacturing: MRP in Manufacturing, very handy for automating
 Requirements management

 As far as ESB integration goes, Ofbiz being based on Service based
 Architecture, should come very handy; I'm guessing you will have some
 work to do to be able to make individual modules, loosely coupled
 using ESB

 Goodluck with your efforts!

 - Regards
 Sakthi

 On 4/10/12, Pierre Smits pierre.sm...@gmail.com wrote:

  Dear all,

 Currently I am participating in the collaboration project IMAGINE -
 Innovative End

Re: OFBIZ Manufacturing

2012-04-11 Thread Jean-Luc Malet


Pierre,

I agree with Jacques on this point. ESB could be a difficult solution to 
install and to maintain with different third system. I think the SOAP 
and XML-RPC, that we already installed for our customers is a good way 
to do.


For the other question, we have customers experiences on manufacturing 
system and we have a good knowledge and expertise about manufacturing in 
general (most of them begun with BaaN ERP, in a manufacturing compagny) 
and also a good knowledge on the OFBiz manufacturing functionnalities. 
We intalled one of our first customer, which was a manufacturing 
company, in 2006. And last week, we installed another one which is a 
food manufacturing company.


So don't hesitate to contact us if we can help and explain us how we 
could help you in this project.


Regards,

--
Jean-Luc Malet
Directeur de Projet
Tel : 0974533612
Mob : 0687618801

Société Néréide
3b Les Isles 37270 Veretz
www.nereide.biz



Le 10/04/2012 23:39, Jacques Le Roux a écrit :
Just a word: it does not make sense to use an ESB like ServiceMix as 
long as it's not mandatory. In other words you may consider 1st using 
OFBiz as much as possible, and use only an ESB if you need to 
integrate with other systems. Even then sometimes using SOAP or 
XML-RPC would be easier depending of the openness of third systems. 
RMI is faster but beware of troubleshooting it on a net with a lot of 
firewalls...


The beauty of OFBiz is that it comes already integrated. We know the 
ERP way (all integrated) has some drawbacks, but don't forget about 
drawbacks of other ways... OFBiz is not perfect but it works OOTB and 
can be easily enhanced... Some ESB projects have already proved to 
fail in the mid/long term...


You might be interested by
https://cwiki.apache.org/confluence/display/OFBIZ/Manufacturing+Process+Stories+and+Diagrams 

https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Related+Books#OFBizRelatedBooks-GettingStartedwithApacheOFBizManufacturingMRPin5EasySteps;(Release09.04andabove) 


https://cwiki.apache.org/confluence/display/OFBREQDES/UBPL+Introduction
https://cwiki.apache.org/confluence/display/OFBREQDES/Universal+Business+Process+Library+Index 



But this topic is more for the user list...

Jacques

From: Integrin info.integ...@gmail.com

Pierre -

While I do not claim to be an expert in Manufacturing, I'm helping
customize Ofbiz for a Food Sevices Industry in a Franchise Model where
Ofbiz Manufacturing be the food kitchen; Additionally the following
modules, being used
- MyPortal  : Dashboard
- Order Manager: Purchase , Sales Orders, Transfer Orders
- Party Manager : Suppliers, Users  Customers
- SFA : Sales Forecast
- Facility : Inventory  Shipping
-Manufacturing: MRP in Manufacturing, very handy for automating
Requirements management

As far as ESB integration goes, Ofbiz being based on Service based
Architecture, should come very handy; I'm guessing you will have some
work to do to be able to make individual modules, loosely coupled
using ESB

Goodluck with your efforts!

- Regards
Sakthi

On 4/10/12, Pierre Smits pierre.sm...@gmail.com wrote:

Dear all,

Currently I am participating in the collaboration project IMAGINE -
Innovative End-to-End Management of Dynamic Manufacturing Networks, 
that
resides under the theme  Virtual Factories and Enterprises as part 
of the

FP7 Programme of the EU.

The goal of this project is to enable SME Manufacturing Enterprises 
in the
EU market space to shorten the time-to-market of their product by 
assisting
manufacturing customers in forming partnerships with suppliers and a 
better

exchange of information and data throughout the lifecycle of the
partnership.

During methodology studies it is envisioned that exchange of 
information

and data entails 4 interlocking areas, namely:

   1. Partner blueprints - All static information (and data) re
   organization and human entities, including connection mechanisms
(addresses
   and such) of the participating organization
   2. Manufacture blueprints - All static information (and data) re
   products (e.g. pricing, QoS re delivery, mBOM's, eBOM's and such)
   3. End-2-End blueprints - All dynamic information (and data) re 
inputs
   and output of the process segments, in customer to supplier 
end-2-end

   processes while manufacturing the goods (but also including process
   definitions in BPEL, BPMN and xPDL)
   4. QA blueprints - All information (and data) relating to 
maintaining
   the QoS requirements of the organization and 
establishing/enhancing trust
   between (potential) partners (encompassing org. certification, 
e.g. ISO

   9000, but also product certification, and more)

All to be facilitated through established Open Standards and 
Technolgies.


In the methodology studies it was also envisioned that, while initial
profiling should start by registering company and lead contact 
persons and

their mechanisms in a portal solution (currently intended OS product:
Liferay, part of the envisioned IMAGINE

Re: OFBIZ Manufacturing

2012-04-10 Thread Integrin

Pierre -

While I do not claim to be an expert in Manufacturing, I'm helping
customize Ofbiz for a Food Sevices Industry in a Franchise Model where
Ofbiz Manufacturing be the food kitchen; Additionally the following
modules, being used
- MyPortal  : Dashboard
- Order Manager: Purchase , Sales Orders, Transfer Orders
- Party Manager : Suppliers, Users  Customers
- SFA : Sales Forecast
- Facility : Inventory  Shipping
-Manufacturing: MRP in Manufacturing, very handy for automating
Requirements management

As far as ESB integration goes, Ofbiz being based on Service based
Architecture, should come very handy; I'm guessing you will have some
work to do to be able to make individual modules, loosely coupled
using ESB

Goodluck with your efforts!

- Regards
Sakthi

On 4/10/12, Pierre Smits pierre.sm...@gmail.com wrote:
 Dear all,

 Currently I am participating in the collaboration project IMAGINE -
 Innovative End-to-End Management of Dynamic Manufacturing Networks, that
 resides under the theme  Virtual Factories and Enterprises as part of the
 FP7 Programme of the EU.

 The goal of this project is to enable SME Manufacturing Enterprises in the
 EU market space to shorten the time-to-market of their product by assisting
 manufacturing customers in forming partnerships with suppliers and a better
 exchange of information and data throughout the lifecycle of the
 partnership.

 During methodology studies it is envisioned that exchange of information
 and data entails 4 interlocking areas, namely:

1. Partner blueprints - All static information (and data) re
organization and human entities, including connection mechanisms
 (addresses
and such) of the participating organization
2. Manufacture blueprints - All static information (and data) re
products (e.g. pricing, QoS re delivery, mBOM's, eBOM's and such)
3. End-2-End blueprints - All dynamic information (and data) re inputs
and output of the process segments, in customer to supplier end-2-end
processes while manufacturing the goods (but also including process
definitions in BPEL, BPMN and xPDL)
4. QA blueprints - All information (and data) relating to maintaining
the QoS requirements of the organization and establishing/enhancing trust
between (potential) partners (encompassing org. certification, e.g. ISO
9000, but also product certification, and more)

 All to be facilitated through established Open Standards and Technolgies.

 In the methodology studies it was also envisioned that, while initial
 profiling should start by registering company and lead contact persons and
 their mechanisms in a portal solution (currently intended OS product:
 Liferay, part of the envisioned IMAGINE platform), as soon as the
 connection mechanisms regarding service adapters are setup and verified
 systems like CRM, Manufacturing, ProjectMgt and Warehousing connect through
 the IMAGINE platform (mainly OS ESB like Servicemix - while providing
 dashboard functionalities in the portal for participants that are not (yet)
 at the highest level of maturity regarding partnering - e.g. uploading data
 through spreadsheets and info via PDF and such).

 As this project still has a lifespan of approx 2 years left and system
 integration has no started yet, it is my belief that OFBiz could be in the
 front runner position and create a name in the EU market space regarding
 Open Source ERP in general and Manufacturing in particular combined with
 info and data exchange through ESBs. Which is a huge opportunity for us.

 Thinking of the possibilites I foresee following use-cases (amongst others)
 to be applicable:

- When the initial registration of the company has been realized and the
connection mechanism regarding the ESB connectivity has been setup and
verified the information relating the Partner blueprint is provided by
means of the data available/maintained in the Party component
- When potential suppliers are identified through the search
capabilities in the portal the data contained there (Party data et all)
 is
pulled/delivered into the SCM (through the ESB)
- When potential customers are identified through the seach capabilities
in the portal the data contained thee is pulled/delivered into the CRM
(through the ESB)
- When potential suppliers are initially contacted and a connection is
being negotiated more data is pullled from and/or delivered to Product
Catalog and Manufacturing (through the ESB)
- When an agreement is concluded this is also pulled/delivered in the
system of the participant(s)
- When proces segments are started, executed and concluded information
(date) thereabout are pulled/delivered into the ERP system of the
 customer
(also through the ESB) and send to the portal for dashboarding purpopes.

 Unfortunately I am not that well experienced in Manufacturing, establishing
 ESB integration for OFBiz and delivering data from one system (like

Re: OFBIZ Manufacturing

2012-04-10 Thread Jacques Le Roux

Just a word: it does not make sense to use an ESB like ServiceMix as long as it's not mandatory. In other words you may consider 1st 
using OFBiz as much as possible, and use only an ESB if you need to integrate with other systems. Even then sometimes using SOAP or 
XML-RPC would be easier depending of the openness of third systems. RMI is faster but beware of troubleshooting it on a net with a 
lot of firewalls...


The beauty of OFBiz is that it comes already integrated. We know the ERP way (all integrated) has some drawbacks, but don't forget 
about drawbacks of other ways... OFBiz is not perfect but it works OOTB and can be easily enhanced... Some ESB projects have 
already proved to fail in the mid/long term...


You might be interested by
https://cwiki.apache.org/confluence/display/OFBIZ/Manufacturing+Process+Stories+and+Diagrams
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Related+Books#OFBizRelatedBooks-GettingStartedwithApacheOFBizManufacturingMRPin5EasySteps;(Release09.04andabove)
https://cwiki.apache.org/confluence/display/OFBREQDES/UBPL+Introduction
https://cwiki.apache.org/confluence/display/OFBREQDES/Universal+Business+Process+Library+Index

But this topic is more for the user list...

Jacques

From: Integrin info.integ...@gmail.com

Pierre -

While I do not claim to be an expert in Manufacturing, I'm helping
customize Ofbiz for a Food Sevices Industry in a Franchise Model where
Ofbiz Manufacturing be the food kitchen; Additionally the following
modules, being used
- MyPortal  : Dashboard
- Order Manager: Purchase , Sales Orders, Transfer Orders
- Party Manager : Suppliers, Users  Customers
- SFA : Sales Forecast
- Facility : Inventory  Shipping
-Manufacturing: MRP in Manufacturing, very handy for automating
Requirements management

As far as ESB integration goes, Ofbiz being based on Service based
Architecture, should come very handy; I'm guessing you will have some
work to do to be able to make individual modules, loosely coupled
using ESB

Goodluck with your efforts!

- Regards
Sakthi

On 4/10/12, Pierre Smits pierre.sm...@gmail.com wrote:

Dear all,

Currently I am participating in the collaboration project IMAGINE -
Innovative End-to-End Management of Dynamic Manufacturing Networks, that
resides under the theme  Virtual Factories and Enterprises as part of the
FP7 Programme of the EU.

The goal of this project is to enable SME Manufacturing Enterprises in the
EU market space to shorten the time-to-market of their product by assisting
manufacturing customers in forming partnerships with suppliers and a better
exchange of information and data throughout the lifecycle of the
partnership.

During methodology studies it is envisioned that exchange of information
and data entails 4 interlocking areas, namely:

   1. Partner blueprints - All static information (and data) re
   organization and human entities, including connection mechanisms
(addresses
   and such) of the participating organization
   2. Manufacture blueprints - All static information (and data) re
   products (e.g. pricing, QoS re delivery, mBOM's, eBOM's and such)
   3. End-2-End blueprints - All dynamic information (and data) re inputs
   and output of the process segments, in customer to supplier end-2-end
   processes while manufacturing the goods (but also including process
   definitions in BPEL, BPMN and xPDL)
   4. QA blueprints - All information (and data) relating to maintaining
   the QoS requirements of the organization and establishing/enhancing trust
   between (potential) partners (encompassing org. certification, e.g. ISO
   9000, but also product certification, and more)

All to be facilitated through established Open Standards and Technolgies.

In the methodology studies it was also envisioned that, while initial
profiling should start by registering company and lead contact persons and
their mechanisms in a portal solution (currently intended OS product:
Liferay, part of the envisioned IMAGINE platform), as soon as the
connection mechanisms regarding service adapters are setup and verified
systems like CRM, Manufacturing, ProjectMgt and Warehousing connect through
the IMAGINE platform (mainly OS ESB like Servicemix - while providing
dashboard functionalities in the portal for participants that are not (yet)
at the highest level of maturity regarding partnering - e.g. uploading data
through spreadsheets and info via PDF and such).

As this project still has a lifespan of approx 2 years left and system
integration has no started yet, it is my belief that OFBiz could be in the
front runner position and create a name in the EU market space regarding
Open Source ERP in general and Manufacturing in particular combined with
info and data exchange through ESBs. Which is a huge opportunity for us.

Thinking of the possibilites I foresee following use-cases (amongst others)
to be applicable:

   - When the initial registration of the company has been realized and the
   connection mechanism regarding

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-13 Thread Hans Bakker

Jacques, still not working ,

have a look at the accounting invoicelist and press find..

Regards,
Hans


On Mon, 2011-09-12 at 15:11 +0200, Jacques Le Roux wrote:
 OK, I found another one, looks like my double-check needed another check :/
 
 Jacques
 
 From: Hans Bakker mailingl...@antwebsystems.com
  The log errors are gone, however the screen does still not display the
  id.
 
  the same problem in this list:
 
  https://localhost:8443/humanres/control/EditSkillTypes
 
  or
 
  https://localhost:8443/accounting/control/findInvoices
 
  Regards,
  Hans
 
 
  On Mon, 2011-09-12 at 13:53 +0200, Jacques Le Roux wrote:
  I double-checked (reviewed my changes done by regexp) there are no other 
  issues
 
  Jacques
 
  Jacques Le Roux wrote:
   OK I found it, testing and committing if OK
  
   Thanks
  
   Jacques
  
   Hans Bakker wrote:
   Ok try again, still think this revision make the list forms not work
   anymore.
  
   go to:
   https://localhost:8443/humanres/control/EditResponsibilityTypes
  
   and you will the problem in the list and a lot of messages in the log:
  
   UEL exception while getting value: java.lang.Null
  
  
   Regards,
   Hans
  
   On Mon, 2011-09-12 at 17:51 +0700, Hans Bakker wrote:
   forget what i said, it looks like it is not this version.
  
   sorry.
  
   regards, Hans
  
   On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:
   looks like that the list multi does not work anymore because of this
   change...can it be reverted?
  
   Regards,
   Hans
  
   On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:
   Author: jleroux
   Date: Sun Sep 11 17:06:11 2011
   New Revision: 1169478
  
   URL: http://svn.apache.org/viewvc?rev=1169478view=rev
   Log:
   No functional changes, simple code refactoring around 
   UtilValidate.is(Not)Empty()
  
   Changes implementation of UtilValidate.isEmpty() for Collection and 
   Map by using isEmpty() instead of c.size() == 0). It's
   more clear and as efficient. Removes also useless parentheses there.
  
   Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. 
   This for 2 reasons:
   * Make the code more readable by replacing the (!)null/isEmpty 
   pattern.
   * Avoid possible NPEs when only isEmpty() was used (after 
   Entity.find... for instance). I found a lot of cases (242 today)
   where isEmpty() could perhaps be replaced in Framework. But I guess 
   no NPE checks were missing there and anyway it was too
   much for me to check them all... So I only did the relevant changes 
   in Applications...
  
  
   Modified:
   
   ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   
   ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
   
   ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
   
   ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
   
   ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
   
   ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
   
   ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
   
   ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
   
   ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
   
   ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
   
   ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
   
   ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
   
   ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
   
   ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
   
   ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
   
   ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
   
   ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
   ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
   
   ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
   
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
   
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
   
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
   
   ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
   
   ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
   
   ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java
  
   Modified: 
   ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   URL:
   http

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-13 Thread Jacques Le Roux


Hi Hans,

It works here but not on trunk demo.
here: invoices list with Id
trunk: no invoices list
You: ?

I will check trunk demo log...

Jacques

From: Hans Bakker mailingl...@antwebsystems.com

Jacques, still not working ,

have a look at the accounting invoicelist and press find..

Regards,
Hans


On Mon, 2011-09-12 at 15:11 +0200, Jacques Le Roux wrote:

OK, I found another one, looks like my double-check needed another check :/

Jacques

From: Hans Bakker mailingl...@antwebsystems.com
 The log errors are gone, however the screen does still not display the
 id.

 the same problem in this list:

 https://localhost:8443/humanres/control/EditSkillTypes

 or

 https://localhost:8443/accounting/control/findInvoices

 Regards,
 Hans


 On Mon, 2011-09-12 at 13:53 +0200, Jacques Le Roux wrote:
 I double-checked (reviewed my changes done by regexp) there are no other 
issues

 Jacques

 Jacques Le Roux wrote:
  OK I found it, testing and committing if OK
 
  Thanks
 
  Jacques
 
  Hans Bakker wrote:
  Ok try again, still think this revision make the list forms not work
  anymore.
 
  go to:
  https://localhost:8443/humanres/control/EditResponsibilityTypes
 
  and you will the problem in the list and a lot of messages in the log:
 
  UEL exception while getting value: java.lang.Null
 
 
  Regards,
  Hans
 
  On Mon, 2011-09-12 at 17:51 +0700, Hans Bakker wrote:
  forget what i said, it looks like it is not this version.
 
  sorry.
 
  regards, Hans
 
  On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:
  looks like that the list multi does not work anymore because of this
  change...can it be reverted?
 
  Regards,
  Hans
 
  On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:
  Author: jleroux
  Date: Sun Sep 11 17:06:11 2011
  New Revision: 1169478
 
  URL: http://svn.apache.org/viewvc?rev=1169478view=rev
  Log:
  No functional changes, simple code refactoring around 
UtilValidate.is(Not)Empty()
 
  Changes implementation of UtilValidate.isEmpty() for Collection and Map by using isEmpty() instead of c.size() == 0). 
  It's

  more clear and as efficient. Removes also useless parentheses there.
 
  Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. 
This for 2 reasons:
  * Make the code more readable by replacing the (!)null/isEmpty pattern.
  * Avoid possible NPEs when only isEmpty() was used (after Entity.find... for instance). I found a lot of cases (242 
  today)
  where isEmpty() could perhaps be replaced in Framework. But I guess no NPE checks were missing there and anyway it was 
  too

  much for me to check them all... So I only did the relevant changes in 
Applications...
 
 
  Modified:
  
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  
ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
  
ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
  
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
  
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
  
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
  
ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
  
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
  
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
  
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
  
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
  
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
  
ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
  
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
  
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
  
ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
  ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
  
ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
  
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
  
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
  
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
  
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
  
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
  
ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java
 
  Modified: 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  URL:
  
http

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Jacques Le Roux

Ha yes right, I will change that back again. Maybe there are previous others to change as well, I will see. I must sayt that I used 
regexp on application and began to check wethere the changes were relevant or not and finally gave up (as it's safe and not much 
costly). That's why I did not touch framework.


Jacques

Scott Gray wrote:

Hi Jacques,

Please keep in mind that GenericDelegator methods that return a list do not 
actually ever return a null value and in a large
number of cases it is both more efficient and better coding style to just use 
list.isEmpty().  The only situation where you need
to check for null is if the delegator throws an exception and the code attempts 
to use the result outside of the try block.

Regards
Scott

On 12/09/2011, at 5:06 AM, jler...@apache.org wrote:


Author: jleroux
Date: Sun Sep 11 17:06:11 2011
New Revision: 1169478

URL: http://svn.apache.org/viewvc?rev=1169478view=rev
Log:
No functional changes, simple code refactoring around 
UtilValidate.is(Not)Empty()

Changes implementation of UtilValidate.isEmpty() for Collection and Map by 
using isEmpty() instead of c.size() == 0). It's more
clear and as efficient. Removes also useless parentheses there.

Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This for 2 
reasons:
* Make the code more readable by replacing the (!)null/isEmpty pattern.
* Avoid possible NPEs when only isEmpty() was used (after Entity.find... for 
instance). I found a lot of cases (242 today) where
isEmpty() could perhaps be replaced in Framework. But I guess no NPE checks 
were missing there and anyway it was too much for me
to check them all... So I only did the relevant changes in Applications...


Modified:
   
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
   ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
   ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
   
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
   
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
   
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
   
ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
   
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
   
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
   ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
   
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
   
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
   
ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
   ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
   
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
   ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
   ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
   
ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
   ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
   ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
   
ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java

Modified: 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
== 
---
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 (original) +++
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 Sun Sep 11 17:06:11 2011 @@ -91,7 +91,7 @@
public class ContentServices { return 
ServiceUtil.returnError(UtilProperties.getMessage(resource,
ContentAssocRetrievingError, UtilMisc.toMap(errorString, 
e.toString()), locale)); }

-if (targetOperations == null || targetOperations.isEmpty()) {
+if (UtilValidate.isEmpty(targetOperations)) {
results.put(contentList, contentList);
return results;
}

Modified: 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Hans Bakker

looks like that the list multi does not work anymore because of this
change...can it be reverted?

Regards,
Hans

On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:
 Author: jleroux
 Date: Sun Sep 11 17:06:11 2011
 New Revision: 1169478
 
 URL: http://svn.apache.org/viewvc?rev=1169478view=rev
 Log:
 No functional changes, simple code refactoring around 
 UtilValidate.is(Not)Empty()
 
 Changes implementation of UtilValidate.isEmpty() for Collection and Map by 
 using isEmpty() instead of c.size() == 0). It's more clear and as efficient. 
 Removes also useless parentheses there.
 
 Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This for 
 2 reasons:
 * Make the code more readable by replacing the (!)null/isEmpty pattern.
 * Avoid possible NPEs when only isEmpty() was used (after Entity.find... for 
 instance). I found a lot of cases (242 today) where isEmpty() could perhaps 
 be replaced in Framework. But I guess no NPE checks were missing there and 
 anyway it was too much for me to check them all... So I only did the relevant 
 changes in Applications...
 
 
 Modified:
 
 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
 ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
 
 ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
 
 ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
 
 ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
 ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
 
 ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
 
 ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
 
 ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
 
 ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
 
 ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
 
 ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
 ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
 
 ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
 ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
 ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
 
 ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java
 
 Modified: 
 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
 ==
 --- 
 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  (original)
 +++ 
 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  Sun Sep 11 17:06:11 2011
 @@ -91,7 +91,7 @@ public class ContentServices {
  return 
 ServiceUtil.returnError(UtilProperties.getMessage(resource, 
 ContentAssocRetrievingError, UtilMisc.toMap(errorString, e.toString()), 
 locale));
  }
  
 -if (targetOperations == null || targetOperations.isEmpty()) {
 +if (UtilValidate.isEmpty(targetOperations)) {
  results.put(contentList, contentList);
  return results;
  }
 
 Modified: 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=1169478r1=1169477r2=1169478view=diff
 ==
 --- 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  (original)
 +++ 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  Sun Sep 11 17:06:11 2011
 @@ -3063,7 +3063,7

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Jacques Le Roux


Could you rather give me an example? In order to fix the related issue only.
BTW did you udpate last changes?

Jacques

From: Hans Bakker mailingl...@antwebsystems.com

looks like that the list multi does not work anymore because of this
change...can it be reverted?

Regards,
Hans

On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:

Author: jleroux
Date: Sun Sep 11 17:06:11 2011
New Revision: 1169478

URL: http://svn.apache.org/viewvc?rev=1169478view=rev
Log:
No functional changes, simple code refactoring around 
UtilValidate.is(Not)Empty()

Changes implementation of UtilValidate.isEmpty() for Collection and Map by 
using isEmpty() instead of c.size() == 0). It's more
clear and as efficient. Removes also useless parentheses there.

Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This for 2 
reasons:
* Make the code more readable by replacing the (!)null/isEmpty pattern.
* Avoid possible NPEs when only isEmpty() was used (after Entity.find... for 
instance). I found a lot of cases (242 today) where
isEmpty() could perhaps be replaced in Framework. But I guess no NPE checks 
were missing there and anyway it was too much for me
to check them all... So I only did the relevant changes in Applications...


Modified:

ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java

ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java

ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java

ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java

ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java

ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java

ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java

ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java

ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java

ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java

ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java

ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java

Modified: 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
==
--- 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 (original)
+++ 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 Sun Sep 11 17:06:11 2011
@@ -91,7 +91,7 @@ public class ContentServices {
 return ServiceUtil.returnError(UtilProperties.getMessage(resource, 
ContentAssocRetrievingError,
UtilMisc.toMap(errorString, e.toString()), locale));
 }

-if (targetOperations == null || targetOperations.isEmpty()) {
+if (UtilValidate.isEmpty(targetOperations)) {
 results.put(contentList, contentList);
 return results;
 }

Modified: 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=1169478r1=1169477r2=1169478view=diff
==
--- 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Hans Bakker

forget what i said, it looks like it is not this version.

sorry.

regards, Hans

On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:
 looks like that the list multi does not work anymore because of this
 change...can it be reverted?
 
 Regards,
 Hans
 
 On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:
  Author: jleroux
  Date: Sun Sep 11 17:06:11 2011
  New Revision: 1169478
  
  URL: http://svn.apache.org/viewvc?rev=1169478view=rev
  Log:
  No functional changes, simple code refactoring around 
  UtilValidate.is(Not)Empty()
  
  Changes implementation of UtilValidate.isEmpty() for Collection and Map by 
  using isEmpty() instead of c.size() == 0). It's more clear and as 
  efficient. Removes also useless parentheses there.
  
  Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This 
  for 2 reasons:
  * Make the code more readable by replacing the (!)null/isEmpty pattern.
  * Avoid possible NPEs when only isEmpty() was used (after Entity.find... 
  for instance). I found a lot of cases (242 today) where isEmpty() could 
  perhaps be replaced in Framework. But I guess no NPE checks were missing 
  there and anyway it was too much for me to check them all... So I only did 
  the relevant changes in Applications...
  
  
  Modified:
  
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  
  ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
  
  ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
  
  ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
  
  ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
  
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
  
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
  
  ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
  
  ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
  
  ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
  
  ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
  ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
  
  ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
  
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
  
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
  ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
  ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
  
  ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java
  
  Modified: 
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
  ==
  --- 
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   (original)
  +++ 
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   Sun Sep 11 17:06:11 2011
  @@ -91,7 +91,7 @@ public class ContentServices {
   return 
  ServiceUtil.returnError(UtilProperties.getMessage(resource, 
  ContentAssocRetrievingError, UtilMisc.toMap(errorString, e.toString()), 
  locale));
   }
   
  -if (targetOperations == null || targetOperations.isEmpty()) {
  +if (UtilValidate.isEmpty(targetOperations)) {
   results.put(contentList, contentList);
   return results;
   }
  
  Modified: 
  ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=1169478r1=1169477r2=1169478view=diff
  ==
  --- 
  ofbiz/trunk/applications

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Hans Bakker

Ok try again, still think this revision make the list forms not work
anymore.

go to:
https://localhost:8443/humanres/control/EditResponsibilityTypes

and you will the problem in the list and a lot of messages in the log:

UEL exception while getting value: java.lang.Null


Regards,
Hans

On Mon, 2011-09-12 at 17:51 +0700, Hans Bakker wrote:
 forget what i said, it looks like it is not this version.
 
 sorry.
 
 regards, Hans
 
 On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:
  looks like that the list multi does not work anymore because of this
  change...can it be reverted?
  
  Regards,
  Hans
  
  On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:
   Author: jleroux
   Date: Sun Sep 11 17:06:11 2011
   New Revision: 1169478
   
   URL: http://svn.apache.org/viewvc?rev=1169478view=rev
   Log:
   No functional changes, simple code refactoring around 
   UtilValidate.is(Not)Empty()
   
   Changes implementation of UtilValidate.isEmpty() for Collection and Map 
   by using isEmpty() instead of c.size() == 0). It's more clear and as 
   efficient. Removes also useless parentheses there.
   
   Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This 
   for 2 reasons:
   * Make the code more readable by replacing the (!)null/isEmpty pattern.
   * Avoid possible NPEs when only isEmpty() was used (after Entity.find... 
   for instance). I found a lot of cases (242 today) where isEmpty() could 
   perhaps be replaced in Framework. But I guess no NPE checks were missing 
   there and anyway it was too much for me to check them all... So I only 
   did the relevant changes in Applications...
   
   
   Modified:
   
   ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   
   ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
   ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
   
   ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
   
   ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
   
   ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
   
   ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
   
   ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
   
   ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
   
   ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
   ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
   
   ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
   
   ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
   
   ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
   
   ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
   
   ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
   
   ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
   ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
   
   ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
   
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
   
   ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
   ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
   
   ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
   
   ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java
   
   Modified: 
   ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   URL: 
   http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
   ==
   --- 
   ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
(original)
   +++ 
   ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
Sun Sep 11 17:06:11 2011
   @@ -91,7 +91,7 @@ public class ContentServices {
return 
   ServiceUtil.returnError(UtilProperties.getMessage(resource, 
   ContentAssocRetrievingError, UtilMisc.toMap(errorString, 
   e.toString()), locale));
}

   -if (targetOperations == null || targetOperations.isEmpty()) {
   +if (UtilValidate.isEmpty(targetOperations)) {
results.put(contentList, contentList);
return

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Jacques Le Roux


OK I found it, testing and committing if OK

Thanks

Jacques

Hans Bakker wrote:

Ok try again, still think this revision make the list forms not work
anymore.

go to:
https://localhost:8443/humanres/control/EditResponsibilityTypes

and you will the problem in the list and a lot of messages in the log:

UEL exception while getting value: java.lang.Null


Regards,
Hans

On Mon, 2011-09-12 at 17:51 +0700, Hans Bakker wrote:

forget what i said, it looks like it is not this version.

sorry.

regards, Hans

On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:

looks like that the list multi does not work anymore because of this
change...can it be reverted?

Regards,
Hans

On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:

Author: jleroux
Date: Sun Sep 11 17:06:11 2011
New Revision: 1169478

URL: http://svn.apache.org/viewvc?rev=1169478view=rev
Log:
No functional changes, simple code refactoring around 
UtilValidate.is(Not)Empty()

Changes implementation of UtilValidate.isEmpty() for Collection and Map by 
using isEmpty() instead of c.size() == 0). It's
more clear and as efficient. Removes also useless parentheses there.

Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This for 2 
reasons:
* Make the code more readable by replacing the (!)null/isEmpty pattern.
* Avoid possible NPEs when only isEmpty() was used (after Entity.find... for 
instance). I found a lot of cases (242 today)
where isEmpty() could perhaps be replaced in Framework. But I guess no NPE 
checks were missing there and anyway it was too
much for me to check them all... So I only did the relevant changes in 
Applications...


Modified:

ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java

ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java

ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java

ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java

ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java

ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java

ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java

ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java

ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java

ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java

ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java

ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java

Modified: 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
== 
---
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 (original) +++
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 Sun Sep 11 17:06:11 2011 @@ -91,7 +91,7 @@
 public class ContentServices { return 
ServiceUtil.returnError(UtilProperties.getMessage(resource,
 ContentAssocRetrievingError, UtilMisc.toMap(errorString, 
e.toString()), locale)); }

-if (targetOperations == null || targetOperations.isEmpty()) {
+if (UtilValidate.isEmpty(targetOperations)) {
 results.put(contentList, contentList);
 return results;
 }

Modified: 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Jacques Le Roux


I double-checked (reviewed my changes done by regexp) there are no other issues

Jacques

Jacques Le Roux wrote:

OK I found it, testing and committing if OK

Thanks

Jacques

Hans Bakker wrote:

Ok try again, still think this revision make the list forms not work
anymore.

go to:
https://localhost:8443/humanres/control/EditResponsibilityTypes

and you will the problem in the list and a lot of messages in the log:

UEL exception while getting value: java.lang.Null


Regards,
Hans

On Mon, 2011-09-12 at 17:51 +0700, Hans Bakker wrote:

forget what i said, it looks like it is not this version.

sorry.

regards, Hans

On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:

looks like that the list multi does not work anymore because of this
change...can it be reverted?

Regards,
Hans

On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:

Author: jleroux
Date: Sun Sep 11 17:06:11 2011
New Revision: 1169478

URL: http://svn.apache.org/viewvc?rev=1169478view=rev
Log:
No functional changes, simple code refactoring around 
UtilValidate.is(Not)Empty()

Changes implementation of UtilValidate.isEmpty() for Collection and Map by 
using isEmpty() instead of c.size() == 0). It's
more clear and as efficient. Removes also useless parentheses there.

Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This for 2 
reasons:
* Make the code more readable by replacing the (!)null/isEmpty pattern.
* Avoid possible NPEs when only isEmpty() was used (after Entity.find... for 
instance). I found a lot of cases (242 today)
where isEmpty() could perhaps be replaced in Framework. But I guess no NPE 
checks were missing there and anyway it was too
much for me to check them all... So I only did the relevant changes in 
Applications...


Modified:

ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java

ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java

ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java

ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java

ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java

ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java

ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java

ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java

ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java

ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java

ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java

ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java

ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java

Modified: 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
== 
---
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 (original) +++
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 Sun Sep 11 17:06:11 2011 @@ -91,7 +91,7 @@
 public class ContentServices { return 
ServiceUtil.returnError(UtilProperties.getMessage(resource,
 ContentAssocRetrievingError, UtilMisc.toMap(errorString, 
e.toString()), locale)); }

-if (targetOperations == null || targetOperations.isEmpty()) {
+if (UtilValidate.isEmpty(targetOperations)) {
 results.put(contentList, contentList);
 return results;
 }

Modified: 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Hans Bakker

thanks Jacques for the quick fix,,
Regards,
Hans

On Mon, 2011-09-12 at 13:53 +0200, Jacques Le Roux wrote:
 I double-checked (reviewed my changes done by regexp) there are no other 
 issues
 
 Jacques
 
 Jacques Le Roux wrote:
  OK I found it, testing and committing if OK
 
  Thanks
 
  Jacques
 
  Hans Bakker wrote:
  Ok try again, still think this revision make the list forms not work
  anymore.
 
  go to:
  https://localhost:8443/humanres/control/EditResponsibilityTypes
 
  and you will the problem in the list and a lot of messages in the log:
 
  UEL exception while getting value: java.lang.Null
 
 
  Regards,
  Hans
 
  On Mon, 2011-09-12 at 17:51 +0700, Hans Bakker wrote:
  forget what i said, it looks like it is not this version.
 
  sorry.
 
  regards, Hans
 
  On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:
  looks like that the list multi does not work anymore because of this
  change...can it be reverted?
 
  Regards,
  Hans
 
  On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:
  Author: jleroux
  Date: Sun Sep 11 17:06:11 2011
  New Revision: 1169478
 
  URL: http://svn.apache.org/viewvc?rev=1169478view=rev
  Log:
  No functional changes, simple code refactoring around 
  UtilValidate.is(Not)Empty()
 
  Changes implementation of UtilValidate.isEmpty() for Collection and Map 
  by using isEmpty() instead of c.size() == 0). It's
  more clear and as efficient. Removes also useless parentheses there.
 
  Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. 
  This for 2 reasons:
  * Make the code more readable by replacing the (!)null/isEmpty pattern.
  * Avoid possible NPEs when only isEmpty() was used (after 
  Entity.find... for instance). I found a lot of cases (242 today)
  where isEmpty() could perhaps be replaced in Framework. But I guess no 
  NPE checks were missing there and anyway it was too
  much for me to check them all... So I only did the relevant changes in 
  Applications...
 
 
  Modified:
  
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  
  ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  
  ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
  
  ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
  
  ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
  
  ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
  
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
  
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
  
  ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
  
  ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
  
  ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
  
  ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
  ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
  
  ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
  
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
  
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
  
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
  ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
  
  ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
  
  ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java
 
  Modified: 
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  URL:
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
  ==
   ---
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   (original) +++
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   Sun Sep 11 17:06:11 2011 @@ -91,7 +91,7 @@
   public class ContentServices { return 
  ServiceUtil.returnError(UtilProperties.getMessage(resource,
   ContentAssocRetrievingError, UtilMisc.toMap

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Hans Bakker

The log errors are gone, however the screen does still not display the
id.

the same problem in this list:

https://localhost:8443/humanres/control/EditSkillTypes

or

https://localhost:8443/accounting/control/findInvoices

Regards,
Hans


On Mon, 2011-09-12 at 13:53 +0200, Jacques Le Roux wrote:
 I double-checked (reviewed my changes done by regexp) there are no other 
 issues
 
 Jacques
 
 Jacques Le Roux wrote:
  OK I found it, testing and committing if OK
 
  Thanks
 
  Jacques
 
  Hans Bakker wrote:
  Ok try again, still think this revision make the list forms not work
  anymore.
 
  go to:
  https://localhost:8443/humanres/control/EditResponsibilityTypes
 
  and you will the problem in the list and a lot of messages in the log:
 
  UEL exception while getting value: java.lang.Null
 
 
  Regards,
  Hans
 
  On Mon, 2011-09-12 at 17:51 +0700, Hans Bakker wrote:
  forget what i said, it looks like it is not this version.
 
  sorry.
 
  regards, Hans
 
  On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:
  looks like that the list multi does not work anymore because of this
  change...can it be reverted?
 
  Regards,
  Hans
 
  On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:
  Author: jleroux
  Date: Sun Sep 11 17:06:11 2011
  New Revision: 1169478
 
  URL: http://svn.apache.org/viewvc?rev=1169478view=rev
  Log:
  No functional changes, simple code refactoring around 
  UtilValidate.is(Not)Empty()
 
  Changes implementation of UtilValidate.isEmpty() for Collection and Map 
  by using isEmpty() instead of c.size() == 0). It's
  more clear and as efficient. Removes also useless parentheses there.
 
  Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. 
  This for 2 reasons:
  * Make the code more readable by replacing the (!)null/isEmpty pattern.
  * Avoid possible NPEs when only isEmpty() was used (after 
  Entity.find... for instance). I found a lot of cases (242 today)
  where isEmpty() could perhaps be replaced in Framework. But I guess no 
  NPE checks were missing there and anyway it was too
  much for me to check them all... So I only did the relevant changes in 
  Applications...
 
 
  Modified:
  
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  
  ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  
  ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
  
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
  
  ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
  
  ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
  
  ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
  
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
  
  ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
  
  ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
  
  ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
  
  ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
  
  ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
  ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
  
  ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
  
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
  
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
  
  ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
  ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
  
  ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
  
  ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java
 
  Modified: 
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  URL:
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
  ==
   ---
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   (original) +++
  ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
   Sun Sep 11 17:06:11 2011

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-12 Thread Jacques Le Roux


OK, I found another one, looks like my double-check needed another check :/

Jacques

From: Hans Bakker mailingl...@antwebsystems.com

The log errors are gone, however the screen does still not display the
id.

the same problem in this list:

https://localhost:8443/humanres/control/EditSkillTypes

or

https://localhost:8443/accounting/control/findInvoices

Regards,
Hans


On Mon, 2011-09-12 at 13:53 +0200, Jacques Le Roux wrote:

I double-checked (reviewed my changes done by regexp) there are no other issues

Jacques

Jacques Le Roux wrote:
 OK I found it, testing and committing if OK

 Thanks

 Jacques

 Hans Bakker wrote:
 Ok try again, still think this revision make the list forms not work
 anymore.

 go to:
 https://localhost:8443/humanres/control/EditResponsibilityTypes

 and you will the problem in the list and a lot of messages in the log:

 UEL exception while getting value: java.lang.Null


 Regards,
 Hans

 On Mon, 2011-09-12 at 17:51 +0700, Hans Bakker wrote:
 forget what i said, it looks like it is not this version.

 sorry.

 regards, Hans

 On Mon, 2011-09-12 at 17:28 +0700, Hans Bakker wrote:
 looks like that the list multi does not work anymore because of this
 change...can it be reverted?

 Regards,
 Hans

 On Sun, 2011-09-11 at 17:06 +, jler...@apache.org wrote:
 Author: jleroux
 Date: Sun Sep 11 17:06:11 2011
 New Revision: 1169478

 URL: http://svn.apache.org/viewvc?rev=1169478view=rev
 Log:
 No functional changes, simple code refactoring around 
UtilValidate.is(Not)Empty()

 Changes implementation of UtilValidate.isEmpty() for Collection and Map 
by using isEmpty() instead of c.size() == 0). It's
 more clear and as efficient. Removes also useless parentheses there.

 Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This 
for 2 reasons:
 * Make the code more readable by replacing the (!)null/isEmpty pattern.
 * Avoid possible NPEs when only isEmpty() was used (after Entity.find... 
for instance). I found a lot of cases (242 today)
 where isEmpty() could perhaps be replaced in Framework. But I guess no 
NPE checks were missing there and anyway it was too
 much for me to check them all... So I only did the relevant changes in 
Applications...


 Modified:
 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
 ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
 
ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
 ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java
 
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java
 
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
 
ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java
 
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
 
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
 
ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
 ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java
 
ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
 
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
 
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
 ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
 
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java
 
ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java

 Modified: 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 URL:
 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
 
== ---
 
ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java (original) 
+++
 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java Sun Sep 11 17:06:11 2011 @@ -91,7 +91,7

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-11 Thread Scott Gray

Hi Jacques,

Please keep in mind that GenericDelegator methods that return a list do not 
actually ever return a null value and in a large number of cases it is both 
more efficient and better coding style to just use list.isEmpty().  The only 
situation where you need to check for null is if the delegator throws an 
exception and the code attempts to use the result outside of the try block.

Regards
Scott

On 12/09/2011, at 5:06 AM, jler...@apache.org wrote:

 Author: jleroux
 Date: Sun Sep 11 17:06:11 2011
 New Revision: 1169478
 
 URL: http://svn.apache.org/viewvc?rev=1169478view=rev
 Log:
 No functional changes, simple code refactoring around 
 UtilValidate.is(Not)Empty()
 
 Changes implementation of UtilValidate.isEmpty() for Collection and Map by 
 using isEmpty() instead of c.size() == 0). It's more clear and as efficient. 
 Removes also useless parentheses there.
 
 Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This for 
 2 reasons:
 * Make the code more readable by replacing the (!)null/isEmpty pattern.
 * Avoid possible NPEs when only isEmpty() was used (after Entity.find... for 
 instance). I found a lot of cases (242 today) where isEmpty() could perhaps 
 be replaced in Framework. But I guess no NPE checks were missing there and 
 anyway it was too much for me to check them all... So I only did the relevant 
 changes in Applications...
 
 
 Modified:

 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java

 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
ofbiz/trunk/applications/marketing/src/org/ofbiz/sfa/vcard/VCard.java

 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java

 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartServices.java

 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java

 ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java

 ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java

 ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilValidate.java

 ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections/FlexibleMapAccessor.java

 ofbiz/trunk/framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java

 ofbiz/trunk/framework/birt/src/org/ofbiz/birt/report/service/OFBizBirtViewerReportService.java

 ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java

 ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java

 ofbiz/trunk/framework/jetty/src/org/ofbiz/jetty/container/JettyContainer.java
ofbiz/trunk/framework/sql/src/org/ofbiz/sql/SQLInsert.java

 ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/seleniumxml/RemoteRequest.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelForm.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/ModelMenuItem.java
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java
ofbiz/trunk/specialpurpose/pos/src/org/ofbiz/pos/component/Journal.java

 ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow/WfApplicationServices.java
 
 Modified: 
 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java?rev=1169478r1=1169477r2=1169478view=diff
 ==
 --- 
 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  (original)
 +++ 
 ofbiz/trunk/applications/content/src/org/ofbiz/content/content/ContentServices.java
  Sun Sep 11 17:06:11 2011
 @@ -91,7 +91,7 @@ public class ContentServices {
 return 
 ServiceUtil.returnError(UtilProperties.getMessage(resource, 
 ContentAssocRetrievingError, UtilMisc.toMap(errorString, e.toString()), 
 locale));
 }
 
 -if (targetOperations == null || targetOperations.isEmpty()) {
 +if (UtilValidate.isEmpty(targetOperations)) {
 results.put(contentList, contentList);
 return results;
 }
 
 Modified: 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=1169478r1=1169477r2=1169478view=diff
 ==
 --- 
 ofbiz/trunk/applications

Re: svn commit: r1133343 - /ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml

2011-06-08 Thread Adrian Crum

This change wouldn't be necessary if the correct Java type was specified 
in the service definition. In other words, the service engine should 
convert the parameter to the correct Java data type before the simple 
method is executed.


-Adrian

On 6/8/2011 12:06 PM, ash...@apache.org wrote:

Author: ashish
Date: Wed Jun  8 11:06:46 2011
New Revision: 1133343

URL: http://svn.apache.org/viewvc?rev=1133343view=rev
Log:
Bug fix. Type(Timestamp) must be mentioned in the createBOMAssoc service for 
the fromDate field which is currently set as a String. Thanks Suprit.

Modified:
 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml

Modified: 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml?rev=1133343r1=1133342r2=1133343view=diff
==
--- 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 Wed Jun  8 11:06:46 2011
@@ -30,7 +30,7 @@ under the License.
  set field=searchDuplicatedAncestorContext.productId 
from-field=parameters.productId/
  set field=searchDuplicatedAncestorContext.productIdTo 
from-field=parameters.productIdTo/
  if-not-empty field=parameters.fromDate
-set field=searchDuplicatedAncestorContext.fromDate 
from-field=parameters.fromDate/
+set field=searchDuplicatedAncestorContext.fromDate from-field=parameters.fromDate 
type=Timestamp/
  /if-not-empty
  set field=searchDuplicatedAncestorContext.productAssocTypeId 
from-field=parameters.productAssocTypeId/
  call-service service-name=searchDuplicatedAncestor 
in-map-name=searchDuplicatedAncestorContext

Re: svn commit: r1133343 - /ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml

2011-06-08 Thread Ashish Vijaywargiya

Yes I agree and we were thinking to go by this route only. In service
definition auto-attributes tag is being used for pk and non-pk fields so
we can't mention field type over there.
Thanks Adrain for your comment.

--
Ashish

On Wed, Jun 8, 2011 at 5:11 PM, Adrian Crum 
adrian.c...@sandglass-software.com wrote:

 This change wouldn't be necessary if the correct Java type was specified in
 the service definition. In other words, the service engine should convert
 the parameter to the correct Java data type before the simple method is
 executed.

 -Adrian


 On 6/8/2011 12:06 PM, ash...@apache.org wrote:

 Author: ashish
 Date: Wed Jun  8 11:06:46 2011
 New Revision: 1133343

 URL: http://svn.apache.org/viewvc?rev=1133343view=rev
 Log:
 Bug fix. Type(Timestamp) must be mentioned in the createBOMAssoc service
 for the fromDate field which is currently set as a String. Thanks Suprit.

 Modified:

 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml

 Modified:
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml?rev=1133343r1=1133342r2=1133343view=diff

 ==
 ---
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 (original)
 +++
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 Wed Jun  8 11:06:46 2011
 @@ -30,7 +30,7 @@ under the License.
  set field=searchDuplicatedAncestorContext.productId
 from-field=parameters.productId/
  set field=searchDuplicatedAncestorContext.productIdTo
 from-field=parameters.productIdTo/
  if-not-empty field=parameters.fromDate
 -set field=searchDuplicatedAncestorContext.fromDate
 from-field=parameters.fromDate/
 +set field=searchDuplicatedAncestorContext.fromDate
 from-field=parameters.fromDate type=Timestamp/
  /if-not-empty
  set field=searchDuplicatedAncestorContext.productAssocTypeId
 from-field=parameters.productAssocTypeId/
  call-service service-name=searchDuplicatedAncestor
 in-map-name=searchDuplicatedAncestorContext

Re: svn commit: r1133343 - /ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml

2011-06-08 Thread Scott Gray

Hi Ashish,

According to the service definition in webtools that service does correctly 
specify a timestamp type for that attribute.  Are you sure that the parameter's 
type is entering the service as a String?  If so, there would be a framework 
level bug causing that to happen because it shouldn't be the case.

Regards
Scott

On 9/06/2011, at 12:44 AM, Ashish Vijaywargiya wrote:

 Yes I agree and we were thinking to go by this route only. In service
 definition auto-attributes tag is being used for pk and non-pk fields so
 we can't mention field type over there.
 Thanks Adrain for your comment.
 
 --
 Ashish
 
 On Wed, Jun 8, 2011 at 5:11 PM, Adrian Crum 
 adrian.c...@sandglass-software.com wrote:
 
 This change wouldn't be necessary if the correct Java type was specified in
 the service definition. In other words, the service engine should convert
 the parameter to the correct Java data type before the simple method is
 executed.
 
 -Adrian
 
 
 On 6/8/2011 12:06 PM, ash...@apache.org wrote:
 
 Author: ashish
 Date: Wed Jun  8 11:06:46 2011
 New Revision: 1133343
 
 URL: http://svn.apache.org/viewvc?rev=1133343view=rev
 Log:
 Bug fix. Type(Timestamp) must be mentioned in the createBOMAssoc service
 for the fromDate field which is currently set as a String. Thanks Suprit.
 
 Modified:
 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 
 Modified:
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml?rev=1133343r1=1133342r2=1133343view=diff
 
 ==
 ---
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 (original)
 +++
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 Wed Jun  8 11:06:46 2011
 @@ -30,7 +30,7 @@ under the License.
 set field=searchDuplicatedAncestorContext.productId
 from-field=parameters.productId/
 set field=searchDuplicatedAncestorContext.productIdTo
 from-field=parameters.productIdTo/
 if-not-empty field=parameters.fromDate
 -set field=searchDuplicatedAncestorContext.fromDate
 from-field=parameters.fromDate/
 +set field=searchDuplicatedAncestorContext.fromDate
 from-field=parameters.fromDate type=Timestamp/
 /if-not-empty
 set field=searchDuplicatedAncestorContext.productAssocTypeId
 from-field=parameters.productAssocTypeId/
 call-service service-name=searchDuplicatedAncestor
 in-map-name=searchDuplicatedAncestorContext
 
 
 



smime.p7s
Description: S/MIME cryptographic signature

Re: svn commit: r1133343 - /ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml

2011-06-08 Thread Ashish Vijaywargiya

Thanks Scott for your valuable comment, it helps!
Please give me some time, I will get back with additional comments so that
we could discuss more on this.

--
Ashish

On Wed, Jun 8, 2011 at 6:46 PM, Scott Gray scott.g...@hotwaxmedia.comwrote:

 Hi Ashish,

 According to the service definition in webtools that service does correctly
 specify a timestamp type for that attribute.  Are you sure that the
 parameter's type is entering the service as a String?  If so, there would be
 a framework level bug causing that to happen because it shouldn't be the
 case.

 Regards
 Scott

 On 9/06/2011, at 12:44 AM, Ashish Vijaywargiya wrote:

  Yes I agree and we were thinking to go by this route only. In service
  definition auto-attributes tag is being used for pk and non-pk fields
 so
  we can't mention field type over there.
  Thanks Adrain for your comment.
 
  --
  Ashish
 
  On Wed, Jun 8, 2011 at 5:11 PM, Adrian Crum 
  adrian.c...@sandglass-software.com wrote:
 
  This change wouldn't be necessary if the correct Java type was specified
 in
  the service definition. In other words, the service engine should
 convert
  the parameter to the correct Java data type before the simple method is
  executed.
 
  -Adrian
 
 
  On 6/8/2011 12:06 PM, ash...@apache.org wrote:
 
  Author: ashish
  Date: Wed Jun  8 11:06:46 2011
  New Revision: 1133343
 
  URL: http://svn.apache.org/viewvc?rev=1133343view=rev
  Log:
  Bug fix. Type(Timestamp) must be mentioned in the createBOMAssoc
 service
  for the fromDate field which is currently set as a String. Thanks
 Suprit.
 
  Modified:
 
 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
 
  Modified:
 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
  URL:
 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml?rev=1133343r1=1133342r2=1133343view=diff
 
 
 ==
  ---
 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
  (original)
  +++
 
 ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/bom/BomSimpleMethods.xml
  Wed Jun  8 11:06:46 2011
  @@ -30,7 +30,7 @@ under the License.
  set field=searchDuplicatedAncestorContext.productId
  from-field=parameters.productId/
  set field=searchDuplicatedAncestorContext.productIdTo
  from-field=parameters.productIdTo/
  if-not-empty field=parameters.fromDate
  -set field=searchDuplicatedAncestorContext.fromDate
  from-field=parameters.fromDate/
  +set field=searchDuplicatedAncestorContext.fromDate
  from-field=parameters.fromDate type=Timestamp/
  /if-not-empty
  set field=searchDuplicatedAncestorContext.productAssocTypeId
  from-field=parameters.productAssocTypeId/
  call-service service-name=searchDuplicatedAncestor
  in-map-name=searchDuplicatedAncestorContext

Re: svn commit: r982273 - /ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java

2010-08-04 Thread Adam Heath


On 08/04/2010 09:53 AM, jaco...@apache.org wrote:

Author: jacopoc
Date: Wed Aug  4 14:53:54 2010
New Revision: 982273

URL: http://svn.apache.org/viewvc?rev=982273view=rev
Log:
Improved error handling: the java event was hiding the error returned by the 
service.


Modified:
 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java

Modified: 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java?rev=982273r1=982272r2=982273view=diff
==
--- 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java
 Wed Aug  4 14:53:54 2010
@@ -37,6 +37,7 @@ import org.ofbiz.entity.GenericPK;
  import org.ofbiz.entity.GenericValue;
  import org.ofbiz.service.GenericServiceException;
  import org.ofbiz.service.LocalDispatcher;
+import org.ofbiz.service.ServiceUtil;

  public class ProductionRunEvents {

@@ -88,6 +89,10 @@ public class ProductionRunEvents {
  inputMap.put(lotId, parameters.get(lotId));
  inputMap.put(userLogin, userLogin);
  Map result = dispatcher.runSync(productionRunDeclareAndProduce, 
inputMap);
+if (ServiceUtil.isError(result)) {
+request.setAttribute(_ERROR_MESSAGE_, 
ServiceUtil.getErrorMessage(result));
+return error;
+}
  } catch (GenericServiceException e) {
  String errMsg = Error issuing materials:  + e.toString();
  Debug.logError(e, errMsg, module);


Not directly related to this change, but I see that this controller 
event catches an exception, then sets an attribute on the request with 
an error message.  Would it not be a nice feature to be able to set 
the exception into the request, so that the controller can do 
something nice for the client browser?

Re: svn commit: r982273 - /ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java

2010-08-04 Thread Adam Heath


On 08/04/2010 09:53 AM, jaco...@apache.org wrote:

Author: jacopoc
Date: Wed Aug  4 14:53:54 2010
New Revision: 982273

URL: http://svn.apache.org/viewvc?rev=982273view=rev
Log:
Improved error handling: the java event was hiding the error returned by the 
service.


Modified:
 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java

Modified: 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java?rev=982273r1=982272r2=982273view=diff
==
--- 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java
 Wed Aug  4 14:53:54 2010
@@ -37,6 +37,7 @@ import org.ofbiz.entity.GenericPK;
  import org.ofbiz.entity.GenericValue;
  import org.ofbiz.service.GenericServiceException;
  import org.ofbiz.service.LocalDispatcher;
+import org.ofbiz.service.ServiceUtil;

  public class ProductionRunEvents {

@@ -88,6 +89,10 @@ public class ProductionRunEvents {
  inputMap.put(lotId, parameters.get(lotId));
  inputMap.put(userLogin, userLogin);
  Map result = dispatcher.runSync(productionRunDeclareAndProduce, 
inputMap);
+if (ServiceUtil.isError(result)) {
+request.setAttribute(_ERROR_MESSAGE_, 
ServiceUtil.getErrorMessage(result));
+return error;
+}


There's another anti-pattern in this file(unrelated to this commit).

==
Map fooMap = UtilMisc.toMap(key1, value1, key2, value2);
fooMap.put(key3, value3);
fooMap.put(key4, value4);
// do something with fooMap.
==

The anti-pattern here is the unconditional addition of extra keys. 
Either don't use toMap at all, or put them all into the toMap method call.




  } catch (GenericServiceException e) {
  String errMsg = Error issuing materials:  + e.toString();
  Debug.logError(e, errMsg, module);

Re: svn commit: r834479 - in /ofbiz/trunk: applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/order/config/ applications/order/webapp/ordermgr/WEB-INF/ applications/order/

2009-11-13 Thread Divesh Dutta


Thanks for the appreciation Jacques :-)


Regards
--
Divesh Dutta.

Jacques Le Roux wrote:

Thank you Divesh!

Jacques

From: Ashish Vijaywargiya vijaywargiya.ash...@gmail.com

Thanks Jacques for your appreciation.
It really encourage us to work more and more for the community.

PS: Divesh please don't get upset - Jacques also said thank you by 
saying to

me ;-).

--
Ashish

On Thu, Nov 12, 2009 at 9:28 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:


Hi Ashish,

I had a look, I like it very much (notably the production run link)

Thanks!

Jacques

 Author: ashish

Date: Tue Nov 10 14:32:53 2009
New Revision: 834479

URL: http://svn.apache.org/viewvc?rev=834479view=rev
Log:
Applied patch from jira issue OFBIZ-3173 - Better supportability for
products of type MARKETING_PKG_AUTO in order processing and 
fulfillment

process.
Following points are covered in this patch:
1) Show associated products for product of type 
MARKETING_PKG_AUTO on

order items section of show cart page in order manager application.

2) Marketing packages should only shown backordered when ATP of 
product
which compose Marketing packages product are less than quantity 
added in

cart.

3) Pick sheets should show Products of type Marketing Packages 
along with

the products which compose Marketing Packages.

4) Show link of production run created on order items section of Order
detail page while placing order for product of type 
MARKETING_PKG_AUTO.


5) Product of type Marketing Packages should be shown on Verify Pick
Screen along with Products they are composed of.

Thanks Divesh for the contribution - this is very nice addition to the
trunk.
I would be more then happy to see comments / concern from - Jacopo? 
Scott?

Anil? or others?

Re: svn commit: r834479 - in /ofbiz/trunk: applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/order/config/ applications/order/webapp/ordermgr/WEB-INF/ applications/order/

2009-11-12 Thread Jacques Le Roux


Hi Ashish,

I had a look, I like it very much (notably the production run link)

Thanks!

Jacques


Author: ashish
Date: Tue Nov 10 14:32:53 2009
New Revision: 834479

URL: http://svn.apache.org/viewvc?rev=834479view=rev
Log:
Applied patch from jira issue OFBIZ-3173 - Better supportability for products of type MARKETING_PKG_AUTO in order processing and 
fulfillment process.

Following points are covered in this patch:
1) Show associated products for product of type MARKETING_PKG_AUTO on order items section of show cart page in order manager 
application.


2) Marketing packages should only shown backordered when ATP of product which compose Marketing packages product are less than 
quantity added in cart.


3) Pick sheets should show Products of type Marketing Packages along with the 
products which compose Marketing Packages.

4) Show link of production run created on order items section of Order detail page while placing order for product of type 
MARKETING_PKG_AUTO.


5) Product of type Marketing Packages should be shown on Verify Pick Screen 
along with Products they are composed of.

Thanks Divesh for the contribution - this is very nice addition to the trunk.
I would be more then happy to see comments / concern from - Jacopo? Scott? 
Anil? or others?

Re: svn commit: r834479 - in /ofbiz/trunk: applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/order/config/ applications/order/webapp/ordermgr/WEB-INF/ applications/orde

2009-11-12 Thread Ashish Vijaywargiya

Thanks Jacques for your appreciation.
It really encourage us to work more and more for the community.

PS: Divesh please don't get upset - Jacques also said thank you by saying to
me ;-).

--
Ashish

On Thu, Nov 12, 2009 at 9:28 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

 Hi Ashish,

 I had a look, I like it very much (notably the production run link)

 Thanks!

 Jacques

  Author: ashish
 Date: Tue Nov 10 14:32:53 2009
 New Revision: 834479

 URL: http://svn.apache.org/viewvc?rev=834479view=rev
 Log:
 Applied patch from jira issue OFBIZ-3173 - Better supportability for
 products of type MARKETING_PKG_AUTO in order processing and fulfillment
 process.
 Following points are covered in this patch:
 1) Show associated products for product of type MARKETING_PKG_AUTO on
 order items section of show cart page in order manager application.

 2) Marketing packages should only shown backordered when ATP of product
 which compose Marketing packages product are less than quantity added in
 cart.

 3) Pick sheets should show Products of type Marketing Packages along with
 the products which compose Marketing Packages.

 4) Show link of production run created on order items section of Order
 detail page while placing order for product of type MARKETING_PKG_AUTO.

 5) Product of type Marketing Packages should be shown on Verify Pick
 Screen along with Products they are composed of.

 Thanks Divesh for the contribution - this is very nice addition to the
 trunk.
 I would be more then happy to see comments / concern from - Jacopo? Scott?
 Anil? or others?

Re: svn commit: r834479 - in /ofbiz/trunk: applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/order/config/ applications/order/webapp/ordermgr/WEB-INF/ applications/order/

2009-11-12 Thread Jacques Le Roux


Thank you Divesh!

Jacques

From: Ashish Vijaywargiya vijaywargiya.ash...@gmail.com

Thanks Jacques for your appreciation.
It really encourage us to work more and more for the community.

PS: Divesh please don't get upset - Jacques also said thank you by saying to
me ;-).

--
Ashish

On Thu, Nov 12, 2009 at 9:28 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:


Hi Ashish,

I had a look, I like it very much (notably the production run link)

Thanks!

Jacques

 Author: ashish

Date: Tue Nov 10 14:32:53 2009
New Revision: 834479

URL: http://svn.apache.org/viewvc?rev=834479view=rev
Log:
Applied patch from jira issue OFBIZ-3173 - Better supportability for
products of type MARKETING_PKG_AUTO in order processing and fulfillment
process.
Following points are covered in this patch:
1) Show associated products for product of type MARKETING_PKG_AUTO on
order items section of show cart page in order manager application.

2) Marketing packages should only shown backordered when ATP of product
which compose Marketing packages product are less than quantity added in
cart.

3) Pick sheets should show Products of type Marketing Packages along with
the products which compose Marketing Packages.

4) Show link of production run created on order items section of Order
detail page while placing order for product of type MARKETING_PKG_AUTO.

5) Product of type Marketing Packages should be shown on Verify Pick
Screen along with Products they are composed of.

Thanks Divesh for the contribution - this is very nice addition to the
trunk.
I would be more then happy to see comments / concern from - Jacopo? Scott?
Anil? or others?

Re: svn commit: r793479 - /ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java

2009-07-13 Thread Jacopo Cappellato


Hi Hans,

thanks for reporting this bug; I have improved the code to be more  
readable and fixed the bug.


Jacopo

On Jul 13, 2009, at 9:42 AM, hans...@apache.org wrote:


Author: hansbak
Date: Mon Jul 13 07:42:39 2009
New Revision: 793479

URL: http://svn.apache.org/viewvc?rev=793479view=rev
Log:
commented out code which contains an error because it can prevent  
running a production run. included a suggestion how to fix it, but i  
am unable to test it. Jacopo, can you?


Modified:
   ofbiz/trunk/applications/manufacturing/src/org/ofbiz/ 
manufacturing/jobshopmgt/ProductionRunServices.java


Modified: ofbiz/trunk/applications/manufacturing/src/org/ofbiz/ 
manufacturing/jobshopmgt/ProductionRunServices.java

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=793479r1=793478r2=793479view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/manufacturing/src/org/ofbiz/ 
manufacturing/jobshopmgt/ProductionRunServices.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/org/ofbiz/ 
manufacturing/jobshopmgt/ProductionRunServices.java Mon Jul 13  
07:42:39 2009

@@ -1014,9 +1014,11 @@
}
// Now get the cost information associated to the fixed  
asset and compute the costs
GenericValue fixedAsset =  
workEffort.getRelatedOne(FixedAsset);
-if (UtilValidate.isEmpty(fixedAsset)   
UtilValidate.isNotEmpty(routingTask)) {

-fixedAsset = routingTask.getRelatedOne(FixedAsset);
+/* TODO if (UtilValidate.isEmpty(fixedAsset)   
UtilValidate.isNotEmpty(routingTask)) {
+   field does not exist, workEffortAssoc does not have a  
fixedAssetId:  fixedAsset =  
routingTask.getRelatedOne(FixedAsset);
+   better?:		  fixedAsset =  
routingTask 
.getRelatedOne(workEffortIdTo).getRelatedOne(FixedAsset);

}
+*/
if (UtilValidate.isNotEmpty(fixedAsset)) {
List setupCosts =  
fixedAsset.getRelatedByAnd(FixedAssetStdCost,  
UtilMisc.toMap(fixedAssetStdCostTypeId, SETUP_COST));
GenericValue setupCost =  
EntityUtil.getFirst(EntityUtil.filterByDate(setupCosts));

Re: svn commit: r793286 - in /ofbiz/trunk: applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java specialpurpose/ecommerce/data/DemoConfigurator.xml

2009-07-12 Thread Jacopo Cappellato


Hi Hans,

you can get similar results by setting configItemTypeId to STANDARD

Jacopo

On Jul 12, 2009, at 10:09 AM, hans...@apache.org wrote:


Author: hansbak
Date: Sun Jul 12 08:09:54 2009
New Revision: 793286

URL: http://svn.apache.org/viewvc?rev=793286view=rev
Log:
added the possbility that in a configurable product a subassembly is  
included with a BOM definition which need to be assembled fist, demo  
data to demonstrate this is included for the famous PC001


Modified:
   ofbiz/trunk/applications/manufacturing/src/org/ofbiz/ 
manufacturing/jobshopmgt/ProductionRunServices.java

   ofbiz/trunk/specialpurpose/ecommerce/data/DemoConfigurator.xml

Modified: ofbiz/trunk/applications/manufacturing/src/org/ofbiz/ 
manufacturing/jobshopmgt/ProductionRunServices.java

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=793286r1=793285r2=793286view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/manufacturing/src/org/ofbiz/ 
manufacturing/jobshopmgt/ProductionRunServices.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/org/ofbiz/ 
manufacturing/jobshopmgt/ProductionRunServices.java Sun Jul 12  
08:09:54 2009

@@ -48,6 +48,7 @@
import org.ofbiz.entity.condition.EntityOperator;
import org.ofbiz.entity.util.EntityUtil;
import org.ofbiz.manufacturing.bom.BOMTree;
+import org.ofbiz.manufacturing.bom.BOMNode;
import org.ofbiz.manufacturing.techdata.TechDataServices;
import org.ofbiz.product.config.ProductConfigWrapper;
import org.ofbiz.product.config.ProductConfigWrapper.ConfigOption;
@@ -231,7 +232,6 @@
} catch (GenericServiceException gse) {
Debug.logWarning(gse.getMessage(), module);
}
-// =
if (routing == null) {
return  
ServiceUtil.returnError(UtilProperties.getMessage(resource,  
ManufacturingProductRoutingNotExist, locale));

}
@@ -391,7 +391,7 @@
while (pb.hasNext()) {
// The components variable contains a list of  
BOMNodes:

// each node represents a product (component).
-org.ofbiz.manufacturing.bom.BOMNode node =  
(org.ofbiz.manufacturing.bom.BOMNode) pb.next();
+BOMNode node =  
(org.ofbiz.manufacturing.bom.BOMNode) pb.next();

GenericValue productBom = node.getProductAssoc();
if ((productBom.getString(routingWorkEffortId)  
== null  first) || (productBom.getString(routingWorkEffortId) !=  
null   
productBom 
.getString 
(routingWorkEffortId 
).equals(routingTask.getString(workEffortId {

serviceContext.clear();
@@ -2217,7 +2217,39 @@
BigDecimal totalQuantity =  
(BigDecimal)components.get(componentProductId);
componentQuantity =  
totalQuantity.add(componentQuantity);

}
-components.put(componentProductId,  
componentQuantity);

+
+// check if a bom exists
+List bomList = null;
+try {
+	bomList = delegator.findByAnd(ProductAssoc,  
UtilMisc.toMap(productId, componentProductId,  
productAssocTypeId, MANUF_COMPONENT));
+	bomList = EntityUtil.filterByDate(bomList,  
UtilDateTime.nowTimestamp());

+} catch (GenericEntityException e) {
+	return ServiceUtil.returnError(try to get BOM  
list from productAssoc);

+}
+// if so create a mandatory predecessor to this  
production run

+if(UtilValidate.isNotEmpty(bomList)) {
+   serviceContext.clear();
+   serviceContext.put(productId, componentProductId);
+   serviceContext.put(quantity, componentQuantity);
+	serviceContext.put(startDate,  
UtilDateTime.nowTimestamp());

+   serviceContext.put(facilityId, facilityId);
+   serviceContext.put(userLogin, userLogin);
+   resultService = null;
+   try {
+		resultService =  
dispatcher.runSync(createProductionRunsForProductBom,  
serviceContext);
+		GenericValue workEffortPreDecessor =  
delegator.makeValue(WorkEffortAssoc, UtilMisc.toMap(
+workEffortIdTo, productionRunId,  
workEffortIdFrom, resultService.get(productionRunId),
+workEffortAssocTypeId, WORK_EFF_PRECEDENCY,  
fromDate, UtilDateTime.nowTimestamp()));

+   workEffortPreDecessor.create();
+   } catch (GenericServiceException e) {
+		return  
ServiceUtil.returnError(UtilProperties.getMessage(resource,  
ManufacturingProductionRunNotCreated, locale));

+   } catch

Re: svn commit: r686748 - in /ofbiz/trunk/applications: manufacturing/config/ manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ manuf

2008-08-18 Thread Jacques Le Roux


Thanks Bilgin for the i18n reminder :o)

Jacques

From: [EMAIL PROTECTED]

Author: bibryam
Date: Mon Aug 18 06:30:35 2008
New Revision: 686748

URL: http://svn.apache.org/viewvc?rev=686748view=rev
Log:
Add possibility for entering comments for configurable product options. The 
comments are attached to production runs as notes.
Thanks to Jacopo and BJ for their comments.
Internationalization note: this commit contains new UI labels.

Modified:
   ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
   
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
   
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy
   
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/jobshopmgt/ProductionRunForms.xml
   
ofbiz/trunk/applications/manufacturing/widget/manufacturing/JobshopScreens.xml
   
ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/configproductdetail.ftl
   
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWorker.java
   
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java

Modified: 
ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml?rev=686748r1=686747r2=686748view=diff

==
--- ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml 
(original)
+++ ofbiz/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml Mon 
Aug 18 06:30:35 2008
@@ -1379,6 +1379,9 @@
value 
xml:lang=thà¸£à¸²à¸¢à¸à¸²à¸£à¸à¸à¸à¸à¸²à¸£à¸à¸¥à¸´à¸à¸ªà¸´à¸à¸à¹à¸²à¸à¸²à¸à¸ªà¸´à¸à¸à¸£à¸±à¸à¸¢à¹à¹à¸¡à¹à¸à¸²à¸§à¸£/value

value xml:lang=zhçäº§è¿è¡åºå®èµäº§åè¡¨/value
/property
+property key=ManufacturingListOfProductionRunNotes
+value xml:lang=enList Of Production Run Notes/value
+/property
property key=ManufacturingListOfProductionRunRoutingTasks
value xml:lang=enTasks/value
value xml:lang=esLista de tareas de la corrida de 
producciÃ³n/value

Modified: 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=686748r1=686747r2=686748view=diff

==
--- 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
 (original)
+++ ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java Mon Aug 18 06:30:35 
2008

@@ -2196,6 +2196,25 @@
componentQuantity = new Double(totalQuantity.doubleValue() 
+ componentQuantity.doubleValue());
}
components.put(componentProductId, componentQuantity);
+
+//  create production run notes from comments
+String comments = co.getComments();
+if (UtilValidate.isNotEmpty(comments)) {
+resultService.clear();
+serviceContext.clear();
+serviceContext.put(workEffortId, productionRunId);
+serviceContext.put(internalNote, Y);
+serviceContext.put(noteInfo, comments);
+serviceContext.put(noteName, co.getDescription());
+serviceContext.put(userLogin, userLogin);
+serviceContext.put(noteParty, 
userLogin.getString(partyId));
+try {
+resultService = 
dispatcher.runSync(createWorkEffortNote, serviceContext);
+} catch (GenericServiceException e) {
+Debug.logWarning(e.getMessage(), module);
+return ServiceUtil.returnError(e.getMessage());
+}
+}
}
}


Modified: 
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy?rev=686748r1=686747r2=686748view=diff

==
--- 
ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy
 (original)
+++ ofbiz/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/actions/jobshopmgt/ViewProductionRun.groovy Mon Aug 18 
06:30:35 2008

@@ -63,5 +63,11 @@
context.quantity = productionRun.getQuantity(); // this is useful to 
compute the total estimates runtime in the form

Re: svn commit: r660846 - in /ofbiz/trunk/applications/manufacturing: src/org/ofbiz/manufacturing/jobshopmgt/ webapp/manufacturing/WEB-INF/actions/jobshopmgt/ webapp/manufacturing/jobshopmgt/

2008-05-28 Thread Christian Geisert


[EMAIL PROTECTED] schrieb:

Author: jacopoc
Date: Wed May 28 00:46:40 2008
New Revision: 660846

URL: http://svn.apache.org/viewvc?rev=660846view=rev
Log:
Added partial support for lot id in production runs.


That's great news (I'm currently looking  at the (missing) lot 
functionality in OFBiz ;-)
I'll have a look at the lot support for Receive Inventory (if you 
aren't already working on it)


--
Christian

Re: svn commit: r601270 - /ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java

2007-12-05 Thread Jacques Le Roux

Thanks for new in comment Scott (related to release4.0 back-port of course ;o)

Jacques

 Author: lektran
 Date: Wed Dec  5 01:32:23 2007
 New Revision: 601270

 URL: http://svn.apache.org/viewvc?rev=601270view=rev
 Log:
 Fix a few new bugs

 Modified:
 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java

 Modified: 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
 URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=601270r1=601269r2=601270view=diff
 ==
 --- 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  (original)
 +++ 
 ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
  Wed Dec  5 01:32:23
2007
 @@ -1554,6 +1554,7 @@
  serviceContext.put(userLogin, userLogin);
  resultService = 
 dispatcher.runSync(createInventoryItemDetail, serviceContext);
  serviceContext.clear();
 +serviceContext.put(userLogin, userLogin);
  serviceContext.put(workEffortId, productionRunId);
  serviceContext.put(inventoryItemId, inventoryItemId);
  resultService = 
 dispatcher.runSync(createWorkEffortInventoryProduced, serviceContext);
 @@ -1589,6 +1590,7 @@
  serviceContext.put(userLogin, userLogin);
  resultService = 
 dispatcher.runSync(createInventoryItemDetail, serviceContext);
  serviceContext.clear();
 +serviceContext.put(userLogin, userLogin);
  serviceContext.put(workEffortId, productionRunId);
  serviceContext.put(inventoryItemId, inventoryItemId);
  resultService = 
 dispatcher.runSync(createWorkEffortInventoryProduced, serviceContext);
 @@ -1677,6 +1679,7 @@
  serviceContext.put(userLogin, userLogin);
  resultService = 
 dispatcher.runSync(createInventoryItemDetail, serviceContext);
  serviceContext.clear();
 +serviceContext.put(userLogin, userLogin);
  serviceContext.put(workEffortId, productionRunTaskId);
  serviceContext.put(inventoryItemId, inventoryItemId);
  resultService = 
 dispatcher.runSync(createWorkEffortInventoryProduced, serviceContext);
 @@ -1713,6 +1716,7 @@
  serviceContext.put(userLogin, userLogin);
  resultService = 
 dispatcher.runSync(createInventoryItemDetail, serviceContext);
  serviceContext.clear();
 +serviceContext.put(userLogin, userLogin);
  serviceContext.put(workEffortId, productionRunTaskId);
  serviceContext.put(inventoryItemId, inventoryItemId);
  resultService = 
 dispatcher.runSync(createWorkEffortInventoryProduced, serviceContext);

Re: svn commit: r575413 - /ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java

2007-09-14 Thread Jacopo Cappellato


Si,

we will comment on this in the Jira issue; however there was an issue 
with your commit: in your patch you test against SALES_ORDER_SHIP while 
the seed data was SALE_ORDER_SHIP; however, in rev.575601 I've corrected 
the seed data to reflect your commit.


Jacopo

[EMAIL PROTECTED] wrote:

Author: sichen
Date: Thu Sep 13 12:44:16 2007
New Revision: 575413

URL: http://svn.apache.org/viewvc?rev=575413view=rev
Log:
Fix a bug where MRP was using daysToShip to create requirements for parts. Also 
provide some information about MRP requirements: show productId and start date

Modified:

ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java

Modified: 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java?rev=575413r1=575412r2=575413view=diff
==
--- 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java
 (original)
+++ 
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/mrp/MrpServices.java
 Thu Sep 13 12:44:16 2007
@@ -496,7 +496,7 @@
 parameters.put(inventoryEventPlanTypeId, 
MRP_REQUIREMENT);
 double componentEventQuantity = node.getQuantity();
 try {
-
InventoryEventPlannedServices.createOrUpdateInventoryEventPlanned(parameters, 
new Double(-1.0 * componentEventQuantity), null, null, false, delegator);
+
InventoryEventPlannedServices.createOrUpdateInventoryEventPlanned(parameters, new Double(-1.0 * 
componentEventQuantity), null, product.get(productId) + :  + eventDate, 
false, delegator);
 } catch (GenericEntityException e) {
 Debug.logError(Error : 
delegator.findByPrimaryKey(\InventoryEventPlanned\, parameters) 
=+parameters+--+e.getMessage(), module);
 logMrpError(node.getProduct().getString(productId), 
Unable to create event (processBomComponent), delegator);
@@ -639,13 +639,17 @@
 } catch (GenericEntityException e) {
 return ServiceUtil.returnError(Problem running 
createOrUpdateInventoryEventPlanned);
 }
+   // days to ship is only relevant for sales order to 
plan for preparatory days to ship.  Otherwise MRP will push event dates for 
manufacturing parts
+// as well and cause problems
+daysToShip = 0;
 if (productFacility != null) {
 reorderQuantity = 
(productFacility.getDouble(reorderQuantity) != null? 
productFacility.getDouble(reorderQuantity).doubleValue(): -1);
 minimumStock = (productFacility.getDouble(minimumStock) != 
null? productFacility.getDouble(minimumStock).doubleValue(): 0);
-daysToShip = (productFacility.getLong(daysToShip) != null? 
productFacility.getLong(daysToShip).intValue(): 0);
+if 
(SALES_ORDER_SHIP.equals(inventoryEventForMRP.getString(inventoryEventPlanTypeId)))
 {
+daysToShip = (productFacility.getLong(daysToShip) != 
null? productFacility.getLong(daysToShip).intValue(): 0);
+}
 } else {
 minimumStock = 0;
-daysToShip = 0;
 reorderQuantity = -1;
 }
 // 
-

84 matches

Mail list logo