Github user erikdw commented on the issue:
https://github.com/apache/storm-site/pull/5
:shipit: ! Thanks @srdo .FYI, I hand-hacked my view of the site using
Google Chrome's developer tools, and verified that the additions you propose
make it look good:
https:/
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2636#discussion_r184219125
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/client/ClusterFactory.java
---
@@ -67,7 +83,57 @@ protected Cluster make(Map
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2637
@hmcl : would you happen to have a chance (or desire) to skim through this
PR Hugo? I know that you contributed heavily to storm-kafka-client, so thought
you might have some thoughts on this. No
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2634#discussion_r181535091
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -372,9 +374,10 @@
/**
* How many executors to spawn for ackers
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2550
@HeartSaVioR : I just updated all the commit messages in-line with @hmcl's
proposal. I also noticed that I missed the addition of the `serialVersionUID`
to Fields.java so I put that in and re
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2550
> First of all, I need to make this clear: I'm not claiming that this PR
should be changed. I'm OK to merge this in as it is, and I'll do it once 24hrs
policy is met.
Let m
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2550
@hmcl : now we're going down the rathole that I knew existed if we didn't
take this offline. ð
Before I get to the question of using command-line `git` to see the related
commi
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2550
To be clear, I'm largely aligned with what you're both saying. I might not
understand what precise problem you face that makes not squashing such a
problem, but I too would appreciate the
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2550
@hmcl @HeartSaVioR : perhaps we can take this offline? (I admit to being
guilty of starting this discussion in these PRs.)
I am not grasping the actual problems that you encounter that make
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2550
STORM-2937: Overwrite latest storm-kafka-client 1.x-branch into 1.0.x-branch
Mimics @HeartSaVioR 's work in STORM-2936 and PR #2549, but applies back to
the more divergent 1.0.x-branch. Big t
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2549
Also can you please tell me how you "archived" the couple of items that you
did?
---
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2549
I know we've talked with @hmcl about the "to squash or not to squash?"
question -- IMNSHO this is a perfect example of where squashing is a bad idea.
i.e., I have *no* idea what &
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2433
@revans2 : thanks, please just loop us in and we'll carve out time to
provide feedback.
---
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2433
/quote My consideration is the workers started by parent supervisor, how do
the workers know their parent supervisor's heartbeat/assignment port? If i
passed it as starting argument, the port wi
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2433
@HeartSaVioR : really @revans2 noticed the change's implications for
storm-on-mesos, so he should get the credit. :-) He's rightly suggested that
we create some tests to codify everything
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2433
@HeartSaVioR :
> By the way, I was not aware of the discussion in storm-mesos, so don't
know which works should be done in Storm side, and how these are coupled with
"this
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2510
@srdo : makes sense, thanks for the info
---
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2510
@srdo : that is my understanding as well. Sorry, I didn't realize you
backported this to all of the other active branches already, is that done by
default for trivial changes like this?
---
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2512
@srdo : I assume for cleanliness / ease of reading purposes? I am a
proponent of squashing commits when there are tons of slight tweaks being made
to the same code. I do like separate commits for
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2512
@srdo : I actually spent extra effort to have 2 commits. :-) This was to
ensure that there is no hidden changes amidst the renaming of the file (I am a
strong proponent of trivial-to-read commits
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2510
@srdo & @revans2 : thx for the quick review-and-merge here! Follow-up
question: since this has been present since the Flux stuff was introduced, it
impacts all active branches. Should I back
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2511
@revans2 & @srdo : thx for the quick review-and-merge!
---
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2512
[STORM-2894] fix some random typos
* MultilangEnvirontmentTest
* There is no "t" between n and m in Environment.
* getOffsetFromConfigAndFroceFromStart
* The r and o are tra
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2511
[STORM-2893] fix storm distribution build by using POSIX tar
There is a known issue with the maven-assembly-plugin version 2.5+ where it
fails with errors like the following:
```
[ERROR
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2510
[STORM-2892] fix PATH substitution in flux tests
The tests fail when the PATH environment variable has a trailing colon,
despite that being a valid PATH.
This happens because it is substituted
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2468
@ptgoetz : I've created PRs for the branches:
* [`1.0.x-branch`](https://github.com/apache/storm/pull/2470)
* [`1.1.x-branch`](https://github.com/apache/storm/pull/2471)
* [`1.x-b
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2471
[STORM-2690] resurrect invocation of ISupervisor.assigned() & make
Supervisor.launchDaemon() accessible
This commit fixes the storm-mesos integration for the interaction between
the Storm co
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2472
[STORM-2690] resurrect invocation of ISupervisor.assigned() & make
Supervisor.launchDaemon() accessible
This commit fixes the storm-mesos integration for the interaction between
the Storm co
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2470
[STORM-2690] resurrect invocation of ISupervisor.assigned() & make
Supervisor.launchDaemon() accessible
This commit fixes the storm-mesos integration for the interaction between
the Storm co
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2468
@ptgoetz : yep! I've been testing on `1.0.x-branch`. I can send PRs for
all the active main branches (`1.0.x-branch`, `1.1.x-branch`, `1.x-branch`).
---
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2468
@revans2 : can you please review this when you have a chance? Notably we
mostly need this back in the
[1.0.x-branch](https://github.com/apache/storm/tree/1.0.x-branch), since (as
[we
discussed
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2468
[STORM-2690] resurrect invocation of ISupervisor.assigned() & make
Supervisor.launchDaemon() accessible
This commit fixes the storm-mesos integration for the interaction between
the Storm co
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2203
@ptgoetz: thanks for your work on this. But I may please request that you
add some description about what you've actually done? There is a lot of
discussion in STORM-2153, and a ton of diff
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2188
@HeartSaVioR : please review at your convenience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@HeartSaVioR : FYI, here's the PR for the backport:
* https://github.com/apache/storm/pull/2188
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2188
STORM-2506: Print mapping between Task ID and Kafka Partitions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erikdw/storm STORM-2506--1.x
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@HeartSaVioR : FYI, I resolved the conflicts in my local repo, I'm gonna
build and then send a new PR, will link from here.
---
If your project is set up for it, you can reply to this email and
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@HeartSaVioR : I didn't have time tonight. I'll try to get to it tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@HeartSaVioR : I'll try to take a stab later tonight at it. I'll let you
know if I find time.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@HeartSaVioR : thanks a lot! @srishtyagrawal is on leave for a month. Are
there any 1.x releases planned before late July?
---
If your project is set up for it, you can reply to this email and
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2117
@srdo : thanks for your perspective on this. I wonder if we could do this:
* we adhere to the no-uppercase-acronyms rule we are debating now, thus
creating some breaking changes
** as stated
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2117
@srdo : I might be in the minority (though it's hard to tell, since as you
noted the email thread didn't get much traction), but I don't think there's
much advantage in changing
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2117
@srdo : my opinion runs contrary to others it seems. For every breaking
API change my team & company incur a bunch of coordination work. We have many
independent internal engineering teams that
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
[Green
âï¸](https://travis-ci.org/apache/storm/builds/233734011?utm_source=github_status&utm_medium=notification),
woot!
---
If your project is set up for it, you can reply to this email
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@srishtyagrawal : thanks! So there's still a [test
failure](https://travis-ci.org/apache/storm/jobs/233447284):
```
Tests run: 37, Failures: 1, Errors: 0, Skipped: 0, Time el
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
technically and I think canonically, there's no problem with a method and a
variable having the same exact name. What's bad in the existing code is that
`taskId()` means something
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@srdo : ah, I forgot that `final` was different from `static` + `final`,
and that `static` + `final` is *really* what a constant should be.
So, in that list that I [posted
above](https
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@revans2 : agree that we should be careful in making changes away from the
base "google_checks.xml", and I did already [argue
above](https://github.com/apache/storm/pull/2109#discussion_
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@srishtyagrawal : we didn't *choose* to set it to 1, we just inherited the
default of the google style in
[google_checks.xml](https://github.com/checkstyle/checkstyle/blob/checkstyle-7.7/src
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2109#discussion_r116677826
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -139,8 +139,8 @@ public void
onPartitionsRevoked
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
These failed build errors should go away once #2112 (my checkstyle-fixing
PR) is merged and you rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2109#discussion_r116337786
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -139,8 +139,8 @@ public void
onPartitionsRevoked
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2109#discussion_r116337306
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -75,9 +79,9 @@ private static DynamicBrokersReader buildReader(Map
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2112
@revans2 : ah, thanks for pointing out the need for license. I copied how
google-cloud-intellij is doing it:
*
https://github.com/GoogleCloudPlatform/google-cloud-intellij/blob
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2112
@vinodkc & @revans2 & @hmcc & @srishtyagrawal : please ð when you have a
chance. This is a follow-up to the
[discussions](https://github.com/apache/
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2112
[STORM-2510] update checkstyle configuration to lower violations
1. Update from checkstyle-6.11.2 to checkstyle-7.7.
2. Tweak google_checks.xml from checkstyle-7.7 to have the following
changes
Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22100450
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22100422
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22098737
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096706
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096665
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096565
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096048
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096038
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2106
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2105#discussion_r115647872
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/drpc/DRPCServer.java ---
@@ -45,170 +46,180 @@
import org.slf4j.Logger;
import
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2105#discussion_r115638968
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/drpc/DRPCServer.java ---
@@ -45,170 +46,180 @@
import org.slf4j.Logger;
import
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2101
@revans2 : here's the backport to 1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2101
[STORM-2191] shorten classpaths by using wildcards
Backport of PR #2094 to 1.x-branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erikdw
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2094#discussion_r114898011
--- Diff: docs/Setting-up-a-Storm-cluster.md ---
@@ -102,9 +102,9 @@ The time to allow any given healthcheck script to run
before it is marked failed
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2094#discussion_r114897599
--- Diff: docs/Setting-up-a-Storm-cluster.md ---
@@ -102,9 +102,9 @@ The time to allow any given healthcheck script to run
before it is marked failed
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2083
@hmcc : I put a comment in the bug -- the problem isn't sufficiently
specified IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2092#discussion_r113879015
--- Diff: docs/storm-pmml.md ---
@@ -0,0 +1,37 @@
+#Storm PMML Bolt
--- End diff --
I'm anal like that. ;-)
---
If your project is s
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2092#discussion_r113874334
--- Diff: docs/storm-pmml.md ---
@@ -0,0 +1,37 @@
+#Storm PMML Bolt
--- End diff --
nit: spacing is not consistent here with the other docs
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2094
@revans2 & @harshach & @hmcl : Here's my proposed change. I'm probably
misinterpreting some of the usages or behaviors with all of these various
external library features, but
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2094
[STORM-2191] shorten classpaths by using wildcards
Instead of fully enumerating all JARs in the lib directories, we just use
a Java classpath wildcard to allow the JVM to autodiscover all JARs in
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2091
fix typo in storm-client pom file: kyro -> kryo
@revans2 : typo I found while poking around and trying to understand the
shaded kryo jar, as per [our discussion in
STORM-2191](ht
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2088
[STORM-2486] Prevent cd from printing target directory to avoid breaking
classpath
@harshach &/or @hmcl &/or @revans2 &/or @HeartSaVioR : can you please
review this when you get a chan
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/1874
I'm unable to reconcile the statements about the ratio always being 1:1
with the content of your "For example" paragraph. Those examples sound like
you have having a different numb
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/1874
@danny0405 : given that I personally find no value in having this separate
task vs. executor distinction that Storm supports (i.e., allowing for a
different ratio than 1:1 for tasks to executors
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/1131
@jianbzhou : you can file a STORM JIRA ticket yourself actually -- you just
need to [create an Apache JIRA
account](https://issues.apache.org/jira/secure/Signup!default.jspa).
---
If your project
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/1851
@danny0405 : thanks for the adjustment! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/1131
> Btw, I just send the latest code to you via email.
@jianbzhou: can you please clarify the "you" in this statement?
> we have communicated via email for a while a
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1851#discussion_r94543681
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/PartitionManager.java ---
@@ -199,7 +199,12 @@ private void fill() {
try
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/1817
@knusbaum : can you please put in some details about what is wrong, how
it's fixed, etc.?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/1406
@abhishekagarwal87 & @HeartSaVioR : any update on this? Getting visibility
into queue depth in storm is a major reason for us to even consider upgrading
off of the storm-0.9.x branch. Do you
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/913
Pointer to the new PR referenced above:
https://github.com/apache/storm/pull/924
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/1744
@revans2 : Since I didn't have any substantive blocking commits I'm ok with
merging it. And it's been long enough that I think you're probably ok to merge
away. Any hidden pro
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90198668
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90193679
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90195674
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90198469
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90196514
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r9024
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90192685
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3640 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90191719
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3640 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89243737
--- Diff: storm-core/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -304,6 +307,41 @@ public void readBlobTo(String key, OutputStream out,
Subject
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/1755
error log for blobstore was missing a space between string 'key' and â¦
â¦the actual key value
Example:
2016-11-01 06:09:58.001 o.a.s.b.BlobStoreUtils [ERROR] Could no
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1443#discussion_r82918924
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java ---
@@ -218,6 +219,11 @@ public static ByteBufferMessageSet
fetchMessages
Github user erikdw commented on the pull request:
https://github.com/apache/storm/pull/236#issuecomment-217228874
@abhishekagarwal87 : awesome news!
Any way you can post a screenshot of the UI you are currently proposing?
At least please do so with the PR when you send it
1 - 100 of 155 matches
Mail list logo
