[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-30 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199314863 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-30 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199315728 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-30 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199315205 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-07-01 Thread GitBox
arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r199343698 ## File path:

[GitHub] sohami commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#discussion_r199210264 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/lateraljoin/TestE2EUnnestAndLateral.java

[GitHub] arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-29 Thread GitBox
arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199212137 ## File path:

[GitHub] vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-29 Thread GitBox
vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199215493 ## File path:

[GitHub] vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-29 Thread GitBox
vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199217282 ## File path:

[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-29 Thread GitBox
Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401424556 @arina-ielchiieva, I thought about that - but it's a bit more complicated in how i'd like it to be: An "Export All"

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199251973 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230469 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230386 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-06-29 Thread GitBox
KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199242382 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199228648 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator

2018-06-29 Thread GitBox
vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#discussion_r199237071 ## File path:

[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-29 Thread GitBox
Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401441469 Filed DRILL-6562 to track this. Regarding one vs multiple files, my reasoning was to keep it more human readable

[GitHub] ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199263635 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199264949 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-40105 If logging needs to be enabled just for QA purposes, I still don't see why it needs to be enabled per query or be dynamic

[GitHub] ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401453225 @vrozov My understanding was the following. QA has setup automatic tests of both the performance of batch sizing as well

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401466019 I'll work on adding the instructions into both the docs dir on this repo and the write-up on Parth's repo once the PR is in.

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230067 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] arina-ielchiieva commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-29 Thread GitBox
arina-ielchiieva commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401437213 Sounds fair regarding the enhancement Jira. I think keeping export button even in update mode is also good.

[GitHub] KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-06-29 Thread GitBox
KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#issuecomment-401439843 WIP: going to exclude unneeded dependencies from dependencies added to dependencyManagement.

[GitHub] priteshm commented on issue #1272: DRILL-5977: Filter Pushdown in Drill-Kafka plugin

2018-06-29 Thread GitBox
priteshm commented on issue #1272: DRILL-5977: Filter Pushdown in Drill-Kafka plugin URL: https://github.com/apache/drill/pull/1272#issuecomment-401474974 @akumarb2010 is this ready to be committed? This is an automated

[GitHub] ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401424230 @vrozov I discussed the logging with @sachouche. The issue is that some information needed to be logged for QA purposes on

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199272513 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199272414 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-29 Thread GitBox
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199274859 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-29 Thread GitBox
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199274012 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-07-02 Thread GitBox
vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199453686 ## File path: exec/jdbc-all/pom.xml ## @@ -636,6 +636,7 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-07-02 Thread GitBox
vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199467902 ## File path: exec/java-exec/pom.xml ## @@ -309,7 +309,7 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-07-02 Thread GitBox
vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199470655 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-07-02 Thread GitBox
vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199454793 ## File path: pom.xml ## @@ -60,6 +61,7 @@ 4.11

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-07-02 Thread GitBox
vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199451218 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-07-02 Thread GitBox
vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199457978 ## File path: pom.xml ## @@ -257,6 +259,16 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-07-02 Thread GitBox
vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199452917 ## File path: pom.xml ## @@ -2356,6 +2417,7 @@

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-29 Thread GitBox
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199289952 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199307744 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199310178 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199308452 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199308790 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@

[GitHub] sachouche commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

2018-06-29 Thread GitBox
sachouche commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354#issuecomment-401513254 @kkhatua, can you please review this fix? Thanks!

[GitHub] sachouche opened a new pull request #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

2018-06-29 Thread GitBox
sachouche opened a new pull request #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354 Reserving same size intermediary buffers to handle the case of false-positive; that is, a column is first thought to be fixed length

[GitHub] sachouche opened a new pull request #1355: DRILL-6560: Enhanced the batch statistics logging enablement

2018-06-29 Thread GitBox
sachouche opened a new pull request #1355: DRILL-6560: Enhanced the batch statistics logging enablement URL: https://github.com/apache/drill/pull/1355 This PR is reserved for internal Drill testing. It provides more logging control when testing the batch sizing functionality. At this

[GitHub] sachouche commented on issue #1355: DRILL-6560: Enhanced the batch statistics logging enablement

2018-06-29 Thread GitBox
sachouche commented on issue #1355: DRILL-6560: Enhanced the batch statistics logging enablement URL: https://github.com/apache/drill/pull/1355#issuecomment-401513955 @bitblender, can you please review this PR? Thanks!

[GitHub] priteshm commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-06-29 Thread GitBox
priteshm commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401503273 @ilooner can you also take a look at it? This is an

[GitHub] ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-29 Thread GitBox
ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#issuecomment-401498074 @Ben-Zvi Thank you Boaz for the thorough review and giving me a +1 finally.

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198928698 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198886347 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199270039 ## File path: distribution/src/resources/storage-plugins-example.conf ## @@ -0,0 +1,66 @@ +# Licensed to the Apache

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198883586 ## File path: common/src/main/java/org/apache/drill/common/exceptions/DrillIOException.java ## @@ -19,24 +19,23 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073178 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -63,17

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073307 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199075637 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199079357 ## File path: distribution/src/deb/control/conffiles ## @@ -16,3 +16,4 @@ /etc/drill/conf/drill-override.conf

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199076849 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199105919 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -25,6

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198926537 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83,15

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199093883 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -25,6

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199266170 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83,15

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276671 ## File path: exec/java-exec/src/main/resources/drill-module.conf ## @@ -393,7 +393,11 @@ drill.exec: { //port

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276599 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199104274 ## File path: distribution/src/resources/storage-plugins-example.conf ## @@ -0,0 +1,66 @@ +# Licensed to the Apache

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198882971 ## File path: common/src/main/java/org/apache/drill/common/config/CommonConstants.java ## @@ -31,4 +31,7 @@ /**

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198931779 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ## @@ -248,6 +248,12 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198928608 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginMap.java ## @@ -111,7 +112,7

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276235 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198884749 ## File path: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java ## @@ -36,11 +36,11 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073387 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198892158 ## File path: distribution/src/resources/drill-override-example.conf ## @@ -251,6 +251,9 @@ drill.exec: {

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198932079 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199077537 ## File path: logical/src/main/java/org/apache/drill/common/config/LogicalPlanPersistence.java ## @@ -37,12 +37,12

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073271 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276413 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401508476 @arina-ielchiieva , on second thoughts, i think having a seperate profile is better. Created a new profile called 'docker'.

[GitHub] Agirish edited a comment on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish edited a comment on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401508476 @arina-ielchiieva , on second thoughts, i think having a separate profile is better. Created a new profile called 'docker'.

[GitHub] HanumathRao commented on issue #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-29 Thread GitBox
HanumathRao commented on issue #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#issuecomment-401513962 @amansinha100 Thank you for the review. This is an

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199305514 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199307586 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199306162 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199306981 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -121,69

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199218902 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-29 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199305835 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -17,22

[GitHub] kkhatua commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-29 Thread GitBox
kkhatua commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401503825 I'd be more comfortable with single plugins to avoid any possible corruption (e.g. format, etc) as debugging could be a

[GitHub] ilooner commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-06-29 Thread GitBox
ilooner commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401509765 @priteshm will take a look monday. @vrozov please fix conflict and travis failures.

[GitHub] vrozov commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-06-29 Thread GitBox
vrozov commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401510580 @ilooner I'll rebase after review. Travis CI failure is not related to the change, it failed due to the build exceeding

[GitHub] priteshm commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
priteshm commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401478271 I do see that a similar approach is followed for other operators for batch sizing. I do agree with @ilooner that it would

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-29 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230386 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

2018-07-02 Thread GitBox
KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#issuecomment-401707337 Done. This is an automated

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-02 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199395144 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@

[GitHub] kkhatua commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

2018-07-02 Thread GitBox
kkhatua commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354#issuecomment-401693445 The IDE (or Maven, itself) might report this as unused. It might be worth mentioning as a that this is a placeholder for the

[GitHub] asfgit closed pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-07-02 Thread GitBox
asfgit closed pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] asfgit closed pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-07-02 Thread GitBox
asfgit closed pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] asfgit closed pull request #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i…

2018-07-02 Thread GitBox
asfgit closed pull request #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i… URL: https://github.com/apache/drill/pull/1352 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] asfgit closed pull request #1342: DRILL-6537:Limit the batch size for buffering operators based on how …

2018-07-02 Thread GitBox
asfgit closed pull request #1342: DRILL-6537:Limit the batch size for buffering operators based on how … URL: https://github.com/apache/drill/pull/1342 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] asfgit closed pull request #309: DRILL-4020: The not-equal operator returns incorrect results when used on the HBase row key

2018-07-02 Thread GitBox
asfgit closed pull request #309: DRILL-4020: The not-equal operator returns incorrect results when used on the HBase row key URL: https://github.com/apache/drill/pull/309 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] asfgit closed pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-07-02 Thread GitBox
asfgit closed pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] arina-ielchiieva opened a new pull request #1357: DRILL-6557: Use size in bytes during Hive statistics calculation if present

2018-07-02 Thread GitBox
arina-ielchiieva opened a new pull request #1357: DRILL-6557: Use size in bytes during Hive statistics calculation if present URL: https://github.com/apache/drill/pull/1357 1. Check size in bytes presence in stats before fetching input splits and use it if present. 2. Add log trace

[GitHub] arina-ielchiieva commented on issue #1357: DRILL-6557: Use size in bytes during Hive statistics calculation if present

2018-07-02 Thread GitBox
arina-ielchiieva commented on issue #1357: DRILL-6557: Use size in bytes during Hive statistics calculation if present URL: https://github.com/apache/drill/pull/1357#issuecomment-401691697 @vvysotskyi please review. This is

  1   2   3   4   5   6   7   8   9   10   >