Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT syntax
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2296/2//COMMIT_MSG
Commit Message:
Line
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1822: Cleanup query profile log
..
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/2260/2/be/src/util/logging-support.cc
File be/src/util/
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1822: Cleanup query profile log
..
Patch Set 3:
(6 comments)
Just a few small things. Thanks! The be test looks nice.
http://gerrit.cloudera.org:8080/#
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1822: Cleanup query profile log
..
Patch Set 4: Code-Review+1
(1 comment)
nice, let's get Dan to +2
http://gerrit.cloudera.org:8080/#/c/2260/4/be/src/u
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2410
Change subject: IMPALA-3102: Admission control supportability
..
IMPALA-3102: Admission control supportability
A few small but importan
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2296/2//COMMIT_MSG
Commit Message
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3102: Admission control supportability
..
Patch Set 1:
Manual for now- I pushed it to the test 6-node cluster. Will update the commit
msg.
--
To view
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2410
to look at the new patch set (#2).
Change subject: IMPALA-3102: Admission control supportability
..
IMPALA-3102: Admis
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3102: Admission control supportability
..
Patch Set 2: Code-Review+2
Carrying Dan's +2
--
To view, visit http://gerrit.cloudera.org:8080/2410
To unsubs
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3102: Admission control supportability
..
Patch Set 2:
Yeah, thanks. I'll resubmit.
--
To view, visit http://gerrit.cloudera.org:8080/2410
To unsubscri
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2432
Change subject: IMPALA-3102: Admission control supportability
..
IMPALA-3102: Admission control supportability
A few small but importan
Matthew Jacobs has abandoned this change.
Change subject: IMPALA-3102: Admission control supportability
..
Abandoned
moved to 5.7.0:
http://gerrit.cloudera.org:8080/#/c/2432/
--
To view, visit http://gerrit.cloudera.org:8080/
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3102: Admission control supportability
..
Patch Set 1: Code-Review+2
Cherry-pick
Carrying +2 from Dan & Silvius on cdh5-trunk review
http://gerrit.clou
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1822: Cleanup query profile log
..
Patch Set 6:
The gvm failed only due to BE udf/uda-test failures which appear to be
unrelated. I filed IMPALA-3132.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool.
..
Patch Set 1:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/2430/1/be/src/runtime/thread-
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2430/1/be/src/runtime/thread-re
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool.
..
Patch Set 2:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/2430/2/be/src/exec/hdfs-scan-
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax
..
Patch Set 5: Code-Review+1
Looks good, thanks for iterating on this. Just need a +2 from Alex.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2430/2/be/src/exec/hdfs-scan-no
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool.
..
Patch Set 3: Code-Review+1
(2 comments)
Thanks!
http://gerrit.cloudera.org:8080/#/c/2430/3/
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2508
Change subject: Add gperftools 2.4
..
Add gperftools 2.4
Change-Id: Ifedb3ef3faa73d33872fbb01f05efc0975c0d0ab
---
M buildall.sh
1 file
Matthew Jacobs has posted comments on this change.
Change subject: Add gperftools 2.4
..
Patch Set 1:
Built this locally and running tests locally now.
--
To view, visit http://gerrit.cloudera.org:8080/2508
To unsubscribe, vi
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2509
Change subject: Switch to gperftools 2.4
..
Switch to gperftools 2.4
Change-Id: Ic06dd692c4c045db1275fca9c59e267c909599a3
---
M be/src/
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2508
to look at the new patch set (#2).
Change subject: IMPALA-3162: Add gperftools 2.4
..
IMPALA-3162: Add gperftools 2.4
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3162: Add gperftools 2.4
..
Patch Set 2: Code-Review+2
I just updated the commit message. Carrying Dan's +2
--
To view, visit http://gerrit.cloudera.or
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2509
to look at the new patch set (#2).
Change subject: IMPALA-3162: Upgrade to gperftools 2.4
..
IMPALA-3162: Upgrade to g
Matthew Jacobs has posted comments on this change.
Change subject: Make .gitignore work with thirdparty
..
Patch Set 1:
Aren't we going to remove thirdparty now?
--
To view, visit http://gerrit.cloudera.org:8080/2517
To unsub
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3162: Upgrade to gperftools 2.4
..
Patch Set 2:
+Henry: Per the discussion about removing thirdparty, does it seem OK to make
this change to use gperft
Matthew Jacobs has posted comments on this change.
Change subject: Make .gitignore work with thirdparty
..
Patch Set 2:
(1 comment)
Now might be a good time to decide if we can get rid of the non-java
dependencies (well, ever
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2509
to look at the new patch set (#3).
Change subject: IMPALA-3162: Upgrade to gperftools 2.4
..
IMPALA-3162: Upgrade to g
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2509
to look at the new patch set (#4).
Change subject: IMPALA-3162: Upgrade to gperftools 2.4
..
IMPALA-3162: Upgrade to g
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3162: Upgrade to gperftools 2.4
..
Patch Set 4:
Ran all tests locally (core) against toolchain build. Built the thirdparty
version (didn't run the tests
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3162: Add gperftools 2.4
..
Patch Set 2:
submitting for gvm now, I verified an exhaustive run passed with the latest
native-toolchain which contains gpe
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3162: Add gperftools 2.4
..
Patch Set 2:
canceled gvm. 2.5 was just released so I'll upgrade to that version.
--
To view, visit http://gerrit.cloudera.
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2538
Change subject: IMPALA-3162: Upgrade gperftools from 2.4 to 2.5
..
IMPALA-3162: Upgrade gperftools from 2.4 to 2.5
Change-Id: I505c1a26
Matthew Jacobs has abandoned this change.
Change subject: IMPALA-3162: Add gperftools 2.4
..
Abandoned
this was submitted by pushing to the repository
--
To view, visit http://gerrit.cloudera.org:8080/2508
To unsubscribe, vis
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2509
to look at the new patch set (#5).
Change subject: IMPALA-3162: Upgrade to gperftools 2.5
..
IMPALA-3162: Upgrade to g
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3183: clang doesn't allow C files to have -std=c++14
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2540/1/be/src/gutil/d
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3183: clang doesn't allow C files to have -std=c++14
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/2540
To unsubscribe
Hello Internal Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2509
to look at the new patch set (#6).
Change subject: IMPALA-3162: Upgrade to gperftools 2.5
..
IMPALA-
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3162: Upgrade to gperftools 2.5
..
Patch Set 6: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/2509
To unsubscribe, visit http:
Hello Casey Ching, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2567
to look at the new patch set (#4).
Change subject: IMPALA-3191: toolchain components should use toolchain cmake
..
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain components should use toolchain cmake
..
Patch Set 5: Code-Review+2
carrying Casey's +2, my test run seems fine so I'm going to push, and
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-3199: Enable admission control by default
..
IMPALA-3199: Enable admission control by default
Enables admission control by default but without any limits
c
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain components should use toolchain cmake
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/2567
To unsubscribe,
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2576
Change subject: IMPALA-3199: Enable admission control by default
..
IMPALA-3199: Enable admission control by default
Change-Id: I404c4e
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3162: Upgrade to gperftools 2.5 (take 2)
..
Patch Set 1:
Yup, and I checked that the sles12 build of gperftools 2.5 is published.
--
To view, visit htt
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain components should use toolchain cmake
..
Patch Set 3:
The issue with that is that it doesn't ensure cmake is built beforehand. I can
cha
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain cmake hangs on sles12
..
Patch Set 2:
Thanks.
I changed the verify-impala-toolchain-package-build job to allow private
repositories and
Hello Casey Ching, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2567
to look at the new patch set (#3).
Change subject: IMPALA-3191: toolchain components should use toolchain cmake
..
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3199: Enable admission control by default
..
Patch Set 1:
This should have no observable effect. I'm running an exhaustive build now to
verify.
--
To
Matthew Jacobs has posted comments on this change.
Change subject: Improve AtomicInt abstraction and implementation
..
Patch Set 1:
(1 comment)
was just taking a look, happy to make a thorough review later if you'd like as
we
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain cmake hangs on sles12
..
Patch Set 2:
At least, that's what I'm thinking for cmake as well. We have a number of
projects that use cmake
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain cmake hangs on sles12
..
Patch Set 2:
(1 comment)
I'm also testing this now with a private build on all OSes
http://gerrit.cloudera.org
Matthew Jacobs has posted comments on this change.
Change subject: Add binutils
..
Patch Set 2: Code-Review+1
+1 assuming the test build passes
--
To view, visit http://gerrit.cloudera.org:8080/2575
To unsubscribe, visit http
Matthew Jacobs has posted comments on this change.
Change subject: CDH-38434: Fix Impala packaging build
..
Patch Set 1: Code-Review+2
sles build is still failing (regardless of the gperftools upgrade), so lets get
the revert
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain cmake hangs on sles12
..
Patch Set 2:
So it made it further but still hanging. We invoke cmake to build many of the
other components, bu
Matthew Jacobs has posted comments on this change.
Change subject: Support for building LLVM 3.7 and 3.8 on CentOS 5
..
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/2546/2/buildall.sh
File buildall.sh:
Line 6
Matthew Jacobs has submitted this change and it was merged.
Change subject: Do not run cmake bootstrap in parallel to mitigate sles12 bug
..
Do not run cmake bootstrap in parallel to mitigate sles12 bug
Seems to mitigate the cm
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain cmake hangs on sles12
..
Patch Set 2:
Yeah, I was looking at that as well. I was worried about other dependencies,
but maybe it's not a
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2565
Change subject: Do not run cmake bootstrap in parallel to mitigate sles12 bug
..
Do not run cmake bootstrap in parallel to mitigate sles
Matthew Jacobs has posted comments on this change.
Change subject: Do not run cmake bootstrap in parallel to mitigate sles12 bug
..
Patch Set 1:
Correct, it doesn't seem like there's a known fix for the issue right now so
we'l
Matthew Jacobs has posted comments on this change.
Change subject: Do not run cmake bootstrap in parallel to mitigate sles12 bug
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/2565
To unsubscribe,
Hello Casey Ching, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2567
to look at the new patch set (#5).
Change subject: IMPALA-3191: toolchain components should use toolchain cmake
..
Matthew Jacobs has submitted this change and it was merged.
Change subject: IMPALA-3191: toolchain components should use toolchain cmake
..
IMPALA-3191: toolchain components should use toolchain cmake
The toolchain doesn't buil
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-3191: toolchain cmake hangs on sles12
..
IMPALA-3191: toolchain cmake hangs on sles12
The toolchain doesn't build on sles12. It appears to be a
cmake bug [
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2581
Change subject: IMPALA-3162: Upgrade to gperftools 2.5 (take 2)
..
IMPALA-3162: Upgrade to gperftools 2.5 (take 2)
Switches the gperfto
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2567
Change subject: IMPALA-3191: toolchain cmake hangs on sles12
..
IMPALA-3191: toolchain cmake hangs on sles12
The toolchain doesn't buil
Matthew Jacobs has posted comments on this change.
Change subject: Add binutils
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/2575/1/init.sh
File init.sh:
Line 166: #
do we also want an option to use the sy
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1822: Cleanup query profile log
..
Patch Set 6:
It looks like https://issues.cloudera.org/browse/IMPALA-3132 is resolved, can
you rebase this patch and
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain cmake hangs on sles12
..
Patch Set 2:
We'd need to build binutils as well? This gets complicated if we want to be
able to build a partic
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3191: toolchain components should use toolchain cmake
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2567/4/init.sh
File init.sh:
Line
Matthew Jacobs has posted comments on this change.
Change subject: Support for building LLVM 3.7 and 3.8 on CentOS 5
..
Patch Set 4: Code-Review+1
thanks!
--
To view, visit http://gerrit.cloudera.org:8080/2546
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: Preview: Re-enable Kudu in build using client stubs when needed
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2585/1/be/src/exec/kudu-util.cc
Matthew Jacobs has posted comments on this change.
Change subject: Preview: Re-enable Kudu in build using client stubs when needed
..
Patch Set 1:
Before combing through the details, I'd like to make sure we're on the same
pag
Matthew Jacobs has posted comments on this change.
Change subject: Don't link with binutils from the toolchain
..
Patch Set 1:
Which old systems are we worried about in particular, centos5? What do you mean
by "some time would
Matthew Jacobs has posted comments on this change.
Change subject: Fix struct vs class compile warning for Clang
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/2590
To unsubscribe, visit http:/
Matthew Jacobs has posted comments on this change.
Change subject: Don't link with binutils from the toolchain
..
Patch Set 1:
What happens when we do this?
I guess this is probably not a huge concern if we properly address
h
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3230: Spurious errors from DeleteOldLogs()
..
Patch Set 1:
Can you add a test case in logging-support-test.cc ?
--
To view, visit http://gerrit.clouder
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3230: Spurious errors from DeleteOldLogs()
..
Patch Set 2:
Yeah, I took a look at the doc and I think the other errors aren't necessary to
handle. Fine
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2576
to look at the new patch set (#3).
Change subject: IMPALA-3199: Enable admission control by default
..
IMPALA-3199: En
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3199: Enable admission control by default
..
Patch Set 3: Code-Review+2
rebase, carry +2
--
To view, visit http://gerrit.cloudera.org:8080/2576
To unsu
Matthew Jacobs has posted comments on this change.
Change subject: Don't link with binutils from the toolchain
..
Patch Set 1:
I meant why can't we link w/ the toolchain linker? Presumably something went
wrong?
--
To view, v
Matthew Jacobs has posted comments on this change.
Change subject: Preview: Re-enable Kudu in build using client stubs when needed
..
Patch Set 1:
Yes I think that makes sense as well and I think is aligned with what we
chatte
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3230: Spurious errors from DeleteOldLogs()
..
Patch Set 2:
Regarding our in person conversation about testing, I thought it'd be weird to
return the num
Matthew Jacobs has posted comments on this change.
Change subject: Re-enable Kudu in build using client stubs when needed
..
Patch Set 2:
Too bad about the partial symbols idea. Did you ask Kudu about having a
function like Ge
Matthew Jacobs has posted comments on this change.
Change subject: Re-enable Kudu in build using client stubs when needed
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/2585/2/CMakeLists.txt
File CMakeLists.t
Matthew Jacobs has posted comments on this change.
Change subject: Add Kudu using parcels
..
Patch Set 1:
(4 comments)
Your bash skills are unparalleled. This isn't a full review, I just got a
chance to look quickly. I have t
Matthew Jacobs has posted comments on this change.
Change subject: Re-enable Kudu in build using client stubs when needed
..
Patch Set 5:
I'm gonna do one more quick pass tonight or tmr morning, then ready to sign
off. Sorry f
Matthew Jacobs has posted comments on this change.
Change subject: Re-enable Kudu in build using client stubs when needed
..
Patch Set 5: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2585/5/CMakeLists.txt
Fil
Matthew Jacobs has posted comments on this change.
Change subject: Add Kudu using parcels
..
Patch Set 3: Code-Review+1
Thanks for addressing my previous comments. Makes sense for what we're doing on
the Impala side for now.
Matthew Jacobs has posted comments on this change.
Change subject: Re-enable Kudu in build using client stubs when needed
..
Patch Set 5:
(1 comment)
one more quick question...
http://gerrit.cloudera.org:8080/#/c/2585/5/tests
Matthew Jacobs has posted comments on this change.
Change subject: Re-enable Kudu in build using client stubs when needed
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2585/5/tests/custom_cluster/test_kudu_no
Matthew Jacobs has posted comments on this change.
Change subject: Implemented a framework for the C++ hiveserver2 client.
..
Patch Set 2:
(14 comments)
I think the interface is getting pretty close, but it's hard to sign off
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query
option
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2384/5/be/src/service/
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query
option
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2384/7/be/src/service/q
Matthew Jacobs has posted comments on this change.
Change subject: Implemented a framework for the C++ hiveserver2 client.
..
Patch Set 3:
(9 comments)
Thanks! I still need to look a bit more in the morning.
http://gerrit.clo
Matthew Jacobs has posted comments on this change.
Change subject: Allow switching between custom and bootstrapped toolchain
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2665/1/CMakeLists.txt
File CMakeLists
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query
option
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2384/7/be/src/service/q
Matthew Jacobs has posted comments on this change.
Change subject: Allow switching between custom and bootstrapped toolchain
..
Patch Set 1: Code-Review+1
ok, makes sense
--
To view, visit http://gerrit.cloudera.org:8080/2665
1 - 100 of 523 matches
Mail list logo
