Re: [edk2] [patch 1/7] MdeModulePkg/PiSmmCore: Add EDKII PI SMM Memory Attribute table.

Comments below: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 25, 2015 10:48 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Fan, Jeff; Zeng, Star Subject: Re: [edk2] [patch 1/7] MdeModulePkg/PiSmmCore: Add EDKII PI SMM

Re: [edk2] [patch 1/3] UefiCpuPkg/PiSmmCpu: Add 2 APIs in SmmCpuFeaturesLib.

Jiewen, I recommend SmmCpuFeaturesAllocatePageTableMemory () function header comment block be updated clarify that the API can be called more once to allocate memory for page tables. With that comment change: Reviewed-by: Michael Kinney Mike > -Original

Re: [edk2] [patch 1/7] MdeModulePkg/PiSmmCore: Add EDKII PI SMM Memory Attribute table.

On 11/25/15 16:26, Yao, Jiewen wrote: > Comments below: Thanks for the answers! Regarding the cover letter, you only need to pass --cover-letter to the "git format-patch" utility. (Not sure how to do it on Windows though.) After the 0/7 file is generated, the user is supposed to edit it

[edk2] [PATCH] ArmPkg: add typecast in UncachedMemoryAllocationLib to fix build warning

Small warning fix. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen --- .../Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

Jiewen, Why does IDT need to be 4KB aligned? The IDT Base provided in the SmiException.asm and SmiException.S for IA32 and X64 are declared to be in .data sections. As long as the PiSmmCpuDxeSmm driver is built with code/data sections separated and on 4KB boundaries, this should guarantee IDT

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move XD enable to ASM before paging enable.

Jiewen, Doing 2 CPUID instructions in every SMI looks expensive. We have global mXdSupported. Can we change that to gXdSupported and detect support in driver entry and use this BOOLEAN flag in assembly code to determine if the MSR_EFER need to be updated? Also, please use MSR_EFER and

Re: [edk2] Ip4Config to Ip4Config2 Transition

Hi Eugene, So your case is that the firmware is updated but NVRAM is kept unchanged. Do you usually do this for a big release such as UDK2015? We don't like the idea to support the old NVRAM in the new driver since it increases much complexity to the driver. The data structures used to record

Re: [edk2] [PATCH v2 2/2] UefiCpuPkg/CpuS3DataDxe: Add module to initialize ACPI_CPU_DATA for S3

Laszlo, Thanks for the feedback and the testing! I have made the updates you suggested in this series except for removing the lines that initialize the RegisterTable fields. I left those there to make it easier for CPU/Platform package that needs to use this module as a starting point for a

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move XD enable to ASM before paging enable.

Jiewen, Yes. That is a good solution to declare global in assembly for this case. Mike > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, November 25, 2015 2:17 PM > To: Kinney, Michael D ; edk2-de...@ml01.01.org > Cc: Fan, Jeff

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

Jiewen, The assembly file supports declaring read/write data and read-only data sections. Would that resolve the issue to put IDT in read-only section? Your patch summary also does not mention the read-only requirements for the IDT. Please add that to the summary. Mike > -Original

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move XD enable to ASM before paging enable.

Got it. I will create a new patch to handle that. -Original Message- From: Kinney, Michael D Sent: Thursday, November 26, 2015 8:00 AM To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D Cc: Fan, Jeff Subject: RE: [patch] UefiCpuPkg/PiSmmCpu: Move XD enable to ASM before paging

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

Yes, I will add more detail in comment section, on why it is copied. You are right that PE/COFF support .RDATA section. Unfortunately, current EDKII link options may merge .RDATA to .DATA section. So we are not able to use that. One possible optimization I could think is to remove IDT in ASM

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

Jiewen, It is easier to maintain in C, so if it is possible to move assembly code to C and address this issue then that is definitely the best solution. If we think there is value in specific types of modules using 4K alignment and not merging sections together, then we should be able to

Re: [edk2] [patch 3/3] MdeModulePkg/NvmExpress: Clean Phase/CqHdbl/SqTdbl fields to restart HC

Ok, I will move those codes into NvmeControllerInit() Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, November 25, 2015 3:32 PM To: Tian, Feng; simon.l...@ssi.samsung.com Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [patch 3/3] MdeModulePkg/NvmExpress: Clean

[edk2] [Patch] NetworkPkg: Update iSCSI driver to check existing AIP instances

According to UEFI spec, iSCSI HBA must install an AIP instance with network boot information block. This patch updates UEFI iSCSI driver to check whether there are AIP instances installed by iSCSI HBA adapter and if yes, the UEFI iSCSI driver will return EFI_ABORTED in its driver binding Start().

[edk2] EDK python script

Hi, I'm trying to build EDK BIOS with python script on Linux but got below error. [16:50:59]W: [Step 2/5] Build environment: Linux-3.2.0-69-generic-x86_64-with-Ubuntu-12.04-precise [16:50:59]W: [Step 2/5] Build start time: 16:50:59, Nov.25 2015 [16:50:59]W: [Step 2/5]

[edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

v2: *Revise some codes according to the comments. 1.In HttpResponseWorker, check the HttpHeaders in the first used place. 2.In EfiHttpPoll(), check the HttpInstance state outside of if condition. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

Yes, the HttpHeaders always not be a NULL pointer when a success call from HttpTcpReceiveHeader function, I will modify when I commit. Thanks -Original Message- From: Fu, Siyuan Sent: Thursday, November 26, 2015 10:09 AM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Ye, Ting; Wu,

Re: [edk2] [PATCH v2 2/2] UefiCpuPkg/CpuS3DataDxe: Add module to initialize ACPI_CPU_DATA for S3

Thanks Mike. I have checked in SVN 18958, with comment update as your suggestion. -Original Message- From: Kinney, Michael D Sent: Thursday, November 26, 2015 2:39 AM To: Laszlo Ersek; edk2-de...@ml01.01.org; Kinney, Michael D Cc: Yao, Jiewen; Fan, Jeff Subject: RE: [edk2] [PATCH v2

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

Hi, Lubo Should HttpHeaders always not be a NULL pointer upon a success call of HttpTcpReceiveHeader? If yes, you should use ASSERT here, otherwise the patch is ok with me? Status = HttpTcpReceiveHeader (HttpInstance, , ); -if (EFI_ERROR (Status)) { +if (EFI_ERROR (Status) ||

Re: [edk2] [Patch] NetworkPkg: Update iSCSI driver to check existing AIP instances

Samer, I can wait until you back for work. Sorry about that. :) Best Regards, Ye Ting From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Thursday, November 26, 2015 11:25 AM To: edk2-devel@lists.01.org; Ye, Ting Subject: RE: [Patch] NetworkPkg: Update iSCSI driver to check

Re: [edk2] [Patch] NetworkPkg: Update iSCSI driver to check existing AIP instances

Thanks Ting. I will review this over Thanksgiving... -Original Message- From: Ye Ting [ting...@intel.com] Received: Wednesday, 25 Nov 2015, 8:45PM To: edk2-devel@lists.01.org [edk2-devel@lists.01.org] CC: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com] Subject: [Patch] NetworkPkg:

[edk2] [PATCH 2/3] ArmPkg: create RVCT assembler macro to centralize EXPORT, AREA, and function label definition

In response to Leifs request earlier, this adds a new RVCT assembler macro to centralize the exporting of assembly functions including the EXPORT directive (so the linker can see it), the AREA directive (so it's in its own section for code size reasons) and the function label itself. This

[edk2] [PATCH 3/3] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

This has the effect of splitting assembly functions into their own sections so the linker can remove unused ones to save space. This has been tested to build with ArmPkg.dsc with RVCT 4. The majority of the conversion was performed with the attached python script. Contributed-under: TianoCore

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

On 2015-11-03 13:01:17, Laszlo Ersek wrote: > Cc: Paolo Bonzini > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > > Notes: > v4: > - update to current test results > > v3: > - this

[edk2] [PATCH] ArmPkg: Initialize variable in UncachedMemoryAllocationLib's AllocatePagesFromList to fix build warning

Addressing Ard and Laszlo's feedback. Updated subject. Moved initialization to separate line. Removed the typecast which was a carryover from a more strict convention we use in our private code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen

Re: [edk2] [PATCH] ArmPkg: add typecast in UncachedMemoryAllocationLib to fix build warning

On 25 November 2015 at 17:35, Cohen, Eugene wrote: > Small warning fix. > Hello Eugene, Presumably, the warning is about the variable potentially being used uninitialized? If so, please drop the cast in the initializer, and update your $subject accordingly. I am not sure (cc'ing

Re: [edk2] [PATCH v2 2/2] UefiCpuPkg/CpuS3DataDxe: Add module to initialize ACPI_CPU_DATA for S3

Laszlo, I have rb Jiewen's patch to SmmCpuFeaturesLib, so it should go in soon. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 25, 2015 10:23 AM > To: Kinney, Michael D ; edk2-de...@ml01.01.org > Cc: Yao,

Re: [edk2] [patch 1/3] UefiCpuPkg/PiSmmCpu: Add 2 APIs in SmmCpuFeaturesLib.

Jiewen, I recommend SmmCpuFeaturesAllocatePageTableMemory () function header comment block be updated clarify that the API can be called more once to allocate memory for page tables. With that comment change: Reviewed-by: Michael Kinney Mike > -Original

Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

Jiewen, I recommend SmmCpuFeaturesAllocatePageTableMemory () function header comment block be updated clarify that the API can be called more once to allocate memory for page tables. With that comment change: Reviewed-by: Michael Kinney Mike > -Original

Re: [edk2] [PATCH] ArmPkg: add typecast in UncachedMemoryAllocationLib to fix build warning

On 11/25/15 18:41, Ard Biesheuvel wrote: > On 25 November 2015 at 17:35, Cohen, Eugene wrote: >> Small warning fix. >> > > Hello Eugene, > > Presumably, the warning is about the variable potentially being used > uninitialized? > If so, please drop the cast in the initializer, and

Re: [edk2] [PATCH v2 2/2] UefiCpuPkg/CpuS3DataDxe: Add module to initialize ACPI_CPU_DATA for S3

On 11/25/15 18:05, Kinney, Michael D wrote: > Laszlo, > > Thanks for the feedback and the testing! > > I have made the updates you suggested in this series except for > removing the lines that initialize the RegisterTable fields. I left > those there to make it easier for CPU/Platform package

Re: [edk2] [patch 1/2] UefiCpuPkg/PiSmmCpu: Always set RW+P bit for page table by default.

Reviewed-by: Michael Kinney > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, November 25, 2015 4:35 AM > To: edk2-de...@ml01.01.org > Cc: Yao, Jiewen ; Fan, Jeff ; > Kinney, Michael D

Re: [edk2] [PATCH] ArmPkg: Initialize variable in UncachedMemoryAllocationLib's AllocatePagesFromList to fix build warning

On 11/25/15 18:59, Cohen, Eugene wrote: > Addressing Ard and Laszlo's feedback. > > Updated subject. Moved initialization to separate line. Removed the > typecast which was a carryover from a more strict convention we use in our > private code. > > > Contributed-under: TianoCore

Re: [edk2] [PATCH 3/3] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

The attached python script was discarded by the mail server so here it is in plaintext for anyone interested. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen ## @file # asmfix.py: Process RVCT ASM files to replace exported functions with a #

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

Hi Mike You are right that IDT is in data section. I did this purposely, because there was requirement to set IDT table to be ReadOnly. MCE handler might run and MCE handler address is there. In order to separate it from other data section, I move it to new place. Or other normal data will also

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move XD enable to ASM before paging enable.

HI Mike Current gXdSupported is defined in C code. I am not able to refer it directly in protected mode asm directly. One possible way is to define AsmXdSupported variable in protected mode ASM, then we can let C code back fill the data value. Like what we did for gSmiStack and gSmiCr3. Do you

Re: [edk2] [patch 1/7] MdeModulePkg/PiSmmCore: Add EDKII PI SMM Memory Attribute table.

Got it. I generated it successfully with your guide. Thanks! -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 25, 2015 11:35 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Fan, Jeff; Zeng, Star Subject: Re: [edk2] [patch 1/7]

Re: [edk2] [PATCH] ArmPkg: add missing MigratePeiServicesTablePointer function required by update to the PeiServicesTablePointerLib in svn 15115

On 25 November 2015 at 14:09, Cohen, Eugene wrote: > Ard, > > Thanks - I'm still working on trying to get you and Leif included. Wouldn't > it be a nice feature if the mail server detected 'ArmPkg' and then > automatically put you two on the To: line? > >> Also, you need to add

Re: [edk2] Vlv2TbltDevicePkg/GenBiosId binary

On 11/25/15 1:34 AM, Jordan Justen wrote: Also, why is Vlv2TbltDevicePkg 14MB, and more than 65% of that is binaries? We moved a large chunk of binaries out of BaseTools/Bin a while back, and this seems like a similar situation. I think these binaries don't belong in the EDK II source code

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

On 2015-11-25 10:06:03, Laszlo Ersek wrote: > On 11/25/15 18:46, Jordan Justen wrote: > > On 2015-11-03 13:01:17, Laszlo Ersek wrote: > > > >> + qemu-system-i386 -cpu coreduo,-nx \ > > > > Sometimes we put '$' before a command prompt. I know there is no > > standard prompt, but that is the one

Re: [edk2] [patch 2/2] UefiCpuPkg/PiSmmCpu: Always set WP in CR0.

Hi Mike Thanks for the suggestion. Previously, I just want to *ADD* without touch old logic. I will use your way to do it. -Original Message- From: Kinney, Michael D Sent: Thursday, November 26, 2015 2:01 AM To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D Cc: Fan, Jeff

Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

Yes, that is good suggestion. I will update comment section before check in. -Original Message- From: Kinney, Michael D Sent: Thursday, November 26, 2015 1:50 AM To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D Cc: Yao, Jiewen; Fan, Jeff Subject: RE: [edk2] [patch 2/3]

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

On 11/25/15 18:46, Jordan Justen wrote: > On 2015-11-03 13:01:17, Laszlo Ersek wrote: >> Cc: Paolo Bonzini >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> v4: >> - update to current

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

Looks good. Reviewed-by: Wu Jiaxin -Original Message- From: Zhang, Lubo Sent: Thursday, November 26, 2015 10:19 AM To: Fu, Siyuan; edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin; Qiu, Shumin Subject: RE: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference

Re: [edk2] [patch] MdeModulePkg:Refine the comments in INF files

Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Wednesday, November 25, 2015 4:55 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Refine the comments in INF files Add comments in INF file in

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

Looks good. Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Thursday, November 26, 2015 10:19 AM To: Fu, Siyuan; edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin; Qiu, Shumin Subject: RE: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference

Re: [edk2] [PATCH] ShellPkg: Wrong return status for Ifconfig.c

Jaben, Is there any generic EFI-to-Shell status conversion routine/macro? If no, as Eugene has declared the below patch is a temporary patch and can't give the useful returned status, a formal patch is required to fix this issue. Thanks. Jiaxin -Original Message- From: edk2-devel

[edk2] [patch] UefiCpuPkg/PiSmmCpu: Move XD enable to ASM before paging enable.

There might be page table set SMM data region be XD. So we have to enable XD before enable paging. Or #PF might be generated. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan, Jeff" Cc: "Kinney, Michael D"

Re: [edk2] [patch] NetworkPkg:Fix NULL pointer dereference issues.

Yes ,the two comments is right, thanks. -Original Message- From: Fu, Siyuan Sent: Wednesday, November 25, 2015 4:39 PM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin; Qiu, Shumin Subject: RE: [patch] NetworkPkg:Fix NULL pointer dereference issues. Hi, Lubo Some

Re: [edk2] [PATCH] ShellPkg: fix RVCT warning due to CONST in typecast

Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cohen, Eugene Sent: Wednesday, November 25, 2015 3:35 AM To: edk2-devel@lists.01.org; Carsey, Jaben Subject: [edk2] [PATCH] ShellPkg: fix RVCT warning

Re: [edk2] Vlv2TbltDevicePkg/GenBiosId binary

On 2015-11-24 21:30:16, Bu, Daocheng wrote: > In my memory, GenBiosId source code isn't open source code. > There is a spec for BIOSID. You can check that for format and > organization. Oh? Where is the spec? Also, why is Vlv2TbltDevicePkg 14MB, and more than 65% of that is binaries? We moved a

Re: [edk2] [PATCH] CryptoPkg: Fix ARM RVCT 4 build

> -Original Message- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Wednesday, November 25, 2015 4:40 PM > To: Long, Qin; Cohen, Eugene; Ard Biesheuvel; Leif Lindholm; Leif Lindholm > Cc: edk2-devel@lists.01.org > Subject: Re: [PATCH] CryptoPkg: Fix ARM RVCT 4 build > > On

[edk2] [patch] NetworkPkg:Fix NULL pointer dereference issues.

Revise some errors that some Null pointers may be dereferenced. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Cc: Qiu Shumin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo

[edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

Add 2 packages required for Intel Galileo and Intel Galileo Gen 2 development boards with the Quark Soc X1000. Patch email would be a bit large, so here is link to a github branch of edk2 with the new package contents for review. https://github.com/mdkinney/edk2/tree/Quark The

[edk2] [patch] MdeModulePkg:Refine the comments in INF files

Add comments in INF file in BootMaintenanceManagerLib.inf. Refine the comments in INF file in FileExplorerLib.inf Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi ---

Re: [edk2] [PATCH v2 2/2] UefiCpuPkg/CpuS3DataDxe: Add module to initialize ACPI_CPU_DATA for S3

On 11/25/15 00:47, Michael Kinney wrote: > This module initializes the ACPI_CPU_DATA structure and registers the > address of this structure in the PcdCpuS3DataAddress PCD. This is a > generic/simple version of this module. It does not provide a machine > check handler or CPU register

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

Jordan, Paolo, any reviews or ACKs for this one? There are no changes queued for this patch in the upcoming v5. Thanks Laszlo On 11/03/15 22:01, Laszlo Ersek wrote: > Cc: Paolo Bonzini > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek

Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

Sorry, I should call you Laszlo. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, Jiewen Sent: Wednesday, November 25, 2015 7:49 PM To: Laszlo Ersek; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Fan, Jeff Subject: Re: [edk2] [patch 2/3]

Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

HI Ersek May I know when you plan to check in your SmmCpuFeaturesLib for SMM? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, November 25, 2015 7:39 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Cc: Kinney, Michael D;

Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

Sure. That would be better for me. Thanks a lot! I found Mike already replied to me to clarify API. It would not be long. I hope. :-) Thank you Yao Jiewen -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 25, 2015 8:00 PM To: Yao, Jiewen;

Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

On 11/25/15 12:50, Yao, Jiewen wrote: > Sorry, I should call you Laszlo. No problem. I still need to post v5 first, and then one or two remaining patches will need to receive reviews. I can commit the series after that, and then this series could be extended later. However, if you wouldn't want

[edk2] [patch 1/2] UefiCpuPkg/PiSmmCpu: Always set RW+P bit for page table by default.

So that we can use write-protection for code later. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan, Jeff" Cc: "Kinney, Michael D" --- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c

[edk2] [patch 3/7] MdeModulePkg/PiSmmCore: Add GetMemoryMap suppport in SmmCore.

We enhanced Paging support and record information in MemoryMap link list. Most code is from DxeCore. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zeng, Star" Cc: "Kinney, Michael D"

[edk2] [patch 4/7] MdeModulePkg/PiSmmCore: Add free SMRAM before allocated SMRAM.

In order record SMM memory map information, we need add free SMRAM at first, then allocated SMRAM. The reason is that, once a new SMRAM region is added, the memory map link list will be allocated to record such information. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [patch 6/7] MdeModulePkg/PiSmmCore: Add PiSmmMemoryAttributesTable support.

Add function declaration in header file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zeng, Star" Cc: "Kinney, Michael D" Cc: "Fan, Jeff" ---

[edk2] [patch 1/7] MdeModulePkg/PiSmmCore: Add EDKII PI SMM Memory Attribute table.

This table is to let SMM core report SMM memory layout, especially SMM PE/COFF driver information. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zeng, Star" Cc: "Kinney, Michael D"

[edk2] [patch 5/7] MdeModulePkg/PiSmmCore: Add PiSmmMemoryAttributesTable support.

Add SmmCoreInitializeMemoryAttributesTable() in PiSmmCore entrypoint. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zeng, Star" Cc: "Kinney, Michael D" Cc: "Fan, Jeff"

[edk2] [patch 7/7] MdeModulePkg/PiSmmCore: Add PiSmmMemoryAttributesTable support.

Add new file and library in INF. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zeng, Star" Cc: "Kinney, Michael D" Cc: "Fan, Jeff" ---

[edk2] [Patch 2/2] MdeModulePkg: Add PciSioSerialDxe driver to DSC

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- MdeModulePkg/MdeModulePkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index

[edk2] [patch] UefiCpuPkg/PiSmmCpu: Move XD enable to ASM before paging enable.

There might be page table set SMM data region be XD. So we have to enable XD before enable paging. Or #PF might be generated. mXdSupported is moved from C to ASM, because protected mode code can not refer global variable in long mode ASM. MSR_EFER/MSR_EFER_XD macro is moved from H to ASM as

[edk2] [Patch 2/5] UefiCpuPkg/CpuMpPei: Add CPU_VOLATILE_REGISTERS & worker functions

Add CPU_VOLATILE_REGISTERS definitions for CRx and DRx required to be restored after APs received INIT IPI. Add worker functions SaveVolatileRegisters()/RestoreVolatileRegisters() used to save/restore CRx and DRx. It also check if Debugging Extensions supported or not. Cc: Feng Tian

[edk2] [Patch 0/5] UefiCpuPkg/CpuMpPei: Sync/Save/Restore CRx/DRx register

This serial of patches will sync BSP's CRx to APs when AP initialization. PeiStartupAllAPs()/PeiStartupThisAP() will send INIT-SIPI-SIPI to wakeup APs to execute AP function. However, some registers will be reset after APs received INIT IPI. We need to restore some registers (For example,

[edk2] [Patch 4/5] UefiCpuPkg/CpuMpPei: Sync BSP's CRx to APs when initialization

Save BSP's volatile register and sync CRx register to APs when AP 1st wake up. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch 3/5] UefiCpuPkg/CpuMpPei: Set AP state to CpuStateIdle after initialization

Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/CpuMpPei.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[edk2] [Patch 1/5] UefiCpuPkg/CpuMpPei: Exchange whole CPU data in SortApicId()

Current implementation only exchanges the APIC ID and BIST, this updating is to exchange all CPU data. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch] UefiCpuPkg/CpuMpPei: Fix typo and add some comments

Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/CpuMpPei.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git