[edk2] PeiCore Exception

2016-04-08 Thread Narinder Dhillon
Hi All, On March 31 I rebased to the latest EDK2 commits and now UEFI is crashing in PeiCore. Platform: ARM64 Fast Model The reason for exception is that the value of "PcdSerialRegisterBase" is not getting picked up from its correct location because the PC relative instruction is not

Re: [edk2] TCPIP Client for UEFI

2016-04-08 Thread Jim Slaughter
Hello, The platform is an AMD based SOC. The uEFI is from Insyde. Yes I do have a uEFI shell. When I downloaded the C driver there were no instructions. I have not yet configured the card. I have not seen any instructions on how to configure. ipconfig does not work. Jim S. On Friday,

Re: [edk2] TCPIP Client for UEFI

2016-04-08 Thread Mahan, Patrick
Jim, This depends on a number of factors: 1. What platform? Who wrote the UEFI code for it? Do you have access to a EFI or UEFI shell? 2. I'm not sure about the Realtek NIC, but did they have any instructions for using the driver? UEFI supports having device specific directories that

[edk2] TCPIP Client for UEFI

2016-04-08 Thread Jim Slaughter
Hello,I downloaded and installed a NIC driver from Realtek for uEFI.I need a TCPIP client so I can do a dhcp.Where do I find this client?Do I need any other softwareJim Slaughter ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] BaseTools: Refinded Multiple Workspaces support.

2016-04-08 Thread Laszlo Ersek
On 04/08/16 21:41, Marvin Häuser wrote: > I do not want to clutter your inboxes, but there has not been any > reply to this idea from Februrary. You are extremely patient. I think pinging after one week is common. On the other hand, you only CC'd Liming on your patch, and forgot to add Yonghong

Re: [edk2] BaseTools: Refinded Multiple Workspaces support.

2016-04-08 Thread Marvin Häuser
Dear developers, I do not want to clutter your inboxes, but there has not been any reply to this idea from Februrary. Even though I lack any kind of Python skill and BaseTools knowledge, as mentioned in the original E-Mail, I would try to work on it when I can (please do not rely on me though,

Re: [edk2] [PATCH 0/1] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-08 Thread Laszlo Ersek
On 04/08/16 12:22, Laszlo Ersek wrote: > Changes in v2: please see the Notes section on patch 1/1. > > Public branch: . > > Cc: Jordan Justen > Cc: Ruiyu Ni > Cc: Jeff Fan

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-08 Thread Laszlo Ersek
On 04/08/16 21:00, Mark wrote: > Thanks for pointing that out, sorry. > > On branch ide_perf_fix_v2 > Your branch is up-to-date with 'origin/ide_perf_fix_v2'. > nothing to commit, working directory clean > > Build success, qemu command line: > qemu-system-x86_64 -enable-kvm -net none -m 1500

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:45, Ard Biesheuvel wrote: > Instead of using a constructor, which may reference a dynamic PCD which is > set by the DXE entry point of its user, defer the assignment of the global > mPciExpressBaseAddress until the first the library is actually invoked. > > Contributed-under:

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-08 Thread Mark
Thanks for pointing that out, sorry. On branch ide_perf_fix_v2 Your branch is up-to-date with 'origin/ide_perf_fix_v2'. nothing to commit, working directory clean Build success, qemu command line: qemu-system-x86_64 -enable-kvm -net none -m 1500 -pflash ~/OVMF_CODE.fd -cdrom

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-08 Thread Laszlo Ersek
On 04/08/16 20:36, Mark wrote: > I cloned your github but couldn't find the appropriate branch to build. > > [m@ornage edk2]$ git status > On branch remove_old_pci_host > Your branch is up-to-date with 'origin/remove_old_pci_host'. > nothing to commit, working directory clean > > If that is the

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-08 Thread Mark
I cloned your github but couldn't find the appropriate branch to build. [m@ornage edk2]$ git status On branch remove_old_pci_host Your branch is up-to-date with 'origin/remove_old_pci_host'. nothing to commit, working directory clean If that is the one, I built it successfully but did not solve

Re: [edk2] [PATCH v2 12/24] ArmVirtPkg/VirtFdtDxe: remove handling of fw_cfg DT node

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > Remove the handling of the fw_cfg DT node from VirtFdtDxe now that the > fw_cfg client library has been moved to the FDT client protocol, and no > longer relies on VirtFdtDxe to pass this information via dynamic PCDs. > Since the PCDs in question are now

Re: [edk2] [PATCH v2 11/24] ArmVirtPkg/QemuFwCfgLib: move to FDT client protocol

2016-04-08 Thread Laszlo Ersek
On 04/08/16 19:20, Laszlo Ersek wrote: > On 04/08/16 11:44, Ard Biesheuvel wrote: >> + if (SwapBytes64 (Reg[1]) >= 0x18) { >> +mFwCfgDmaAddress = mFwCfgDataAddress + 0x10; > > Ditto; please drop the "m" from both. > >> +FwCfgDmaSize = 0x08; >> + >> +// >> +// See

Re: [edk2] [PATCH v2 11/24] ArmVirtPkg/QemuFwCfgLib: move to FDT client protocol

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > Make this library depend on the FDT client protocol to access the > host supplied device tree directly rather than depending on VirtFdtDxe > to set them using dynamic PCDs. > > Since this library is used by several drivers (BdsDxe, SmbiosDxe and >

Re: [edk2] [PATCH v2 09/24] ArmVirtPkg: move TimerDxe to FDT client library

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > Move to the new dedicated to ArmVirtTimerFdtClientLib to populate the one "to" too many > various timer related PCDs at driver load time rather than relying on > VirtFdtDxe to do it. Since ArmPkg/TimerDxe is the only consumer of these > PCDs, which is

Re: [edk2] [PATCH v2 10/24] ArmVirtPkg/VirtFdtDxe: remove timer DT node handling

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > The timer code no longer relies on VirtFdtDxe to set the PCDs, so remove > the handling of the timer node and the references to those PCDs. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2 08/24] ArmVirtPkg: implement ArmVirtTimerFdtClientLib

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > This implements a library ArmVirtTimerFdtClientLib which is intended to > be incorporated into TimerDxe via NULL library class resolution. This > allows us to make TimerDxe depend on the FDT client protocol, and > discover the timer interrupts from the

Re: [edk2] [patch 0/4] Add EDKII SD/MMC stack to manage SD/EMMC device

2016-04-08 Thread Ard Biesheuvel
On 8 April 2016 at 06:59, Tian, Feng wrote: > Hi, Ard > > These two files are used to identify device type and set the corresponding > bus mode. It have to be in SdMmcPciHcDxe as it is not only related with cmd > execution but also related with host controller operation. >

Re: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when mv file with cwd is NULL.

2016-04-08 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Friday, April 08, 2016 3:10 AM > To: Qiu, Shumin ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > > Subject:

Re: [edk2] [PATCH v2 07/24] ArmVirtPkg/VirtFdtDxe: drop detection of PSCI method

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > The detection of the PSCI method has been moved to the EfiResetSystemLib > implementation, so drop the handling from VirtFdtDxe. Since no users > remain of gArmVirtTokenSpaceGuid.PcdArmPsciMethod, remove that as well. > > Contributed-under: TianoCore

Re: [edk2] [PATCH v2 06/24] ArmVirtPkg/ArmVirtPsciResetSystemLib: move to FDT client protocol

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > Instead of relying on VirtFdtDxe to detect the PSCI method, move our > EfiResetSystemLib to the FDT client protocol to interrogate the device > tree directly. > > Since this library is only consumed by EmbeddedPkg/ResetRuntimeDxe, and > considering that

Re: [edk2] [PATCH v2 04/24] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > Instead of relying on VirtFdtDxe to populate the GIC related PCDs, move > this handling to our implementation of ArmGicArchLib, and retrieve the > required DT info using the new FDT client protocol. > > This removes one of the reasons we need to load

Re: [edk2] [PATCH v2 03/24] ArmVirtPkg: add FdtClientDxe to the ArmVirtPkg platforms

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > Add FdtClientDxe to the various platforms under ArmVirtPkg, so that the > drivers we will update to depend on the FDT client protocol in subsequent > patches will remain in working order. > > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [PATCH v2 02/24] ArmVirtPkg/FdtClientDxe: implement new driver

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > This implements a new DXE driver FdtClientDxe to produce the FDT client > protocol based on a device tree image supplied by the virt host. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2 01/24] ArmVirtPkg: introduce FdtClientProtocol

2016-04-08 Thread Laszlo Ersek
On 04/08/16 11:44, Ard Biesheuvel wrote: > This introduces the FdtClientProtocol, which will be used to expose the > device tree provided by the host to other DXE drivers. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > ---

Re: [edk2] [PATCH 10/12] Nt32Pkg: Convert to build FatPkg from source

2016-04-08 Thread Laszlo Ersek
On 04/08/16 05:37, Ni, Ruiyu wrote: > Reviewed-by: Ruiyu Ni > > On 2016-04-06 23:14, Jordan Justen wrote: >> Now that FatPkg is open source (and therefore can be included in the >> EDK II tree) we build and use it directly. >> >> Note: Not build tested >> >>

Re: [edk2] [PATCH 07/12] DuetPkg scripts: Support building with GCC45 - GCC49

2016-04-08 Thread Laszlo Ersek
On 04/08/16 05:36, Ni, Ruiyu wrote: > Reviewed-by: Ruiyu Ni > > On 2016-04-06 23:14, Jordan Justen wrote: >> Build tested with GCC 5.3 with both IA32 and X64. Unfortunately both >> seemed to hang very early when boot tested on QEMU. >> >> Contributed-under: TianoCore

Re: [edk2] [PATCH 08/12] DuetPkg: Convert to build FatPkg from source

2016-04-08 Thread Laszlo Ersek
On 04/08/16 05:37, Ni, Ruiyu wrote: > Reviewed-by: Ruiyu Ni > > On 2016-04-06 23:14, Jordan Justen wrote: >> Now that FatPkg is open source (and therefore can be included in the >> EDK II tree) we build and use it directly. >> >> Note: Build tested with GCC 5.3 on IA32 and

Re: [edk2] [PATCH] ArmPlatformPkg/DS-5: fix 64-bit PE/COFF header parsing bug

2016-04-08 Thread Ard Biesheuvel
Ping? On 31 March 2016 at 09:36, Ard Biesheuvel wrote: > The 64-bit version of the DS-5 debug script that retrieves the debug file > path from the PE/COFF image in memory assumes that the PE/COFF header is > packed, and that the debug directory entry in the optional

Re: [edk2] [PATCH] ArmPlatformPkg: fixups for 64-bit mailbox pointers

2016-04-08 Thread Ard Biesheuvel
On 24 March 2016 at 23:33, Ard Biesheuvel wrote: > On 24 March 2016 at 21:30, Leo Duran wrote: >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Leo Duran >> --- >>

Re: [edk2] [PATCH v2 00/24] VirtFdtDxe refactoring and removal

2016-04-08 Thread Ard Biesheuvel
On 8 April 2016 at 11:44, Ard Biesheuvel wrote: > This v2 now fully gets rid of the VirtFdtDxe kludge, by moving its > functionality to its various clients that access PCDs or protocols supplied > by it. > > Changes since v1: > - merged two patches related to Pcd.inf's

Re: [edk2] build.py error (WSL Ubuntu 14.04 LTS, Python 2.7.11)

2016-04-08 Thread Gao, Liming
Marvin: Linux file system is case sensitive . Seemly, Microsoft’s new Windows Subsystem for Linux (WSL) on Windows 10 is case insensitive. EDKII BaseTools includes one python source file BaseTools\Source\Python\Common\String.py, and python build-in class is string. In the code, Printset =

Re: [edk2] [PATCH 0/1] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-08 Thread Laszlo Ersek
On 04/08/16 12:22, Laszlo Ersek wrote: > Changes in v2: please see the Notes section on patch 1/1. > > Public branch: . > > Cc: Jordan Justen > Cc: Ruiyu Ni > Cc: Jeff Fan

[edk2] [PATCH 0/1] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-08 Thread Laszlo Ersek
Changes in v2: please see the Notes section on patch 1/1. Public branch: . Cc: Jordan Justen Cc: Ruiyu Ni Cc: Jeff Fan Cc: Mark Laszlo Ersek (1):

[edk2] [PATCH 1/1] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-08 Thread Laszlo Ersek
* Short description: The CpuIoServiceRead() and CpuIoServiceWrite() functions transfer data between memory and IO ports with individual Io(Read|Write)(8|16|32) function calls, each in an appropriately set up loop. On the Ia32 and X64 platforms however, FIFO reads and writes can be

Re: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when mv file with cwd is NULL.

2016-04-08 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu >Shumin >Sent: Friday, April 8, 2016 3:54 PM >To: edk2-devel@lists.01.org >Cc: Carsey, Jaben ; Ni, Ruiyu

Re: [edk2] [PATCH 0/3] Update some S3 related modules to consume PcdAcpiS3Enable to control the code

2016-04-08 Thread Zeng, Star
On 2016/4/8 17:50, Laszlo Ersek wrote: On 04/08/16 09:09, Zeng, Star wrote: On 2016/4/8 14:55, Yao, Jiewen wrote: Thanks. 1/3 - I think this is valuable to save SMRAM size. Reviewed-by: jiewen@intel.com 2/3 - I think this is valuable to save Reserved memory size. Reviewed-by:

Re: [edk2] [PATCH v2 0/2] Update PerformanceLib not to check Identifier.

2016-04-08 Thread Zeng, Star
Series, Reviewed-by: Star Zeng On 2016/4/8 17:41, Liming Gao wrote: In V2, update function header comments not to check Identifier. In V1, update PerformanceLib instance not to check Identifier. Liming Gao (2): MdePkg: Update PerformanceLib comments not to check

Re: [edk2] [PATCH 0/3] Update some S3 related modules to consume PcdAcpiS3Enable to control the code

2016-04-08 Thread Laszlo Ersek
On 04/08/16 09:09, Zeng, Star wrote: > On 2016/4/8 14:55, Yao, Jiewen wrote: >> Thanks. >> 1/3 - I think this is valuable to save SMRAM size. Reviewed-by: >> jiewen@intel.com >> 2/3 - I think this is valuable to save Reserved memory size. >> Reviewed-by: jiewen@intel.com >> 3/3 - I have

[edk2] [PATCH v2 18/24] ArmVirtPkg/VirtFdtDxe: drop RTC handling

2016-04-08 Thread Ard Biesheuvel
The RTC driver no longer relies on VirtFdtDxe to set the pl031 RTC base address in a dynamic PCD, so drop the handling altogether. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 29

[edk2] [PATCH v2 19/24] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

2016-04-08 Thread Ard Biesheuvel
We no longer care when VirtFdtDxe executes, since the dependencies are now all resolved via protocols. So drop the A PRIORI declaration. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.fdf | 4

[edk2] [PATCH v2 17/24] ArmVirtPkg: move QEMU based platforms to ArmVirtRtcFdtClientLib

2016-04-08 Thread Ard Biesheuvel
This moves QEMU based platforms to ArmVirtRtcFdtClientLib, so that we no longer have to rely on VirtFdtDxe to execute first and set the RTC base address in a dynamic PCD. The only driver which [transitively] depends on this PcdPL031RtcBase PCD is EmbeddedPkg/RealTimeClockRuntimeDxe, so this

[edk2] [PATCH v2 10/24] ArmVirtPkg/VirtFdtDxe: remove timer DT node handling

2016-04-08 Thread Ard Biesheuvel
The timer code no longer relies on VirtFdtDxe to set the PCDs, so remove the handling of the timer node and the references to those PCDs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c |

[edk2] [PATCH v2 09/24] ArmVirtPkg: move TimerDxe to FDT client library

2016-04-08 Thread Ard Biesheuvel
Move to the new dedicated to ArmVirtTimerFdtClientLib to populate the various timer related PCDs at driver load time rather than relying on VirtFdtDxe to do it. Since ArmPkg/TimerDxe is the only consumer of these PCDs, which is the DXE driver ArmVirtTimerFdtClientLib is intended to complement,

[edk2] [PATCH v2 11/24] ArmVirtPkg/QemuFwCfgLib: move to FDT client protocol

2016-04-08 Thread Ard Biesheuvel
Make this library depend on the FDT client protocol to access the host supplied device tree directly rather than depending on VirtFdtDxe to set them using dynamic PCDs. Since this library is used by several drivers (BdsDxe, SmbiosDxe and QemuFwCfgAcpiPlatformDxe), we will end up parsing the

[edk2] [PATCH v2 16/24] ArmVirtPkg: implement ArmVirtRtcFdtClientLib

2016-04-08 Thread Ard Biesheuvel
This implements a library ArmVirtRtcFdtClientLib which is intended to be incorporated into RealTimeClockRuntimeDxe via NULL library class resolution. This allows us to make RealTimeClockRuntimeDxe depend on the FDT client protocol, and discover the RTC base address from the device tree directly

[edk2] [PATCH v2 21/24] ArmVirtPkg/VirtFdtDxe: move FDT config table installation to FdtClientDxe

2016-04-08 Thread Ard Biesheuvel
Now that FdtClientDxe is the core driver that takes ownership of the host supplied FDT, it makes sense to put it in charge of installing the FDT configuration table as well. --- ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 11 +++ ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf | 4

[edk2] [PATCH v2 24/24] ArmVirtPkg/VirtFdtDxe: remove Xenio handling and rename to VirtioFdtDxe

2016-04-08 Thread Ard Biesheuvel
Now that we have moved the handling of the xen,xen DT node to XenioFdtDxe, remove its handling from VirtFdtDxe. Since the only functionality that remains is handling the virtio,mmio DT node, rename VirtFdtDxe to VirtioFdtDxe to reflect that. Also update the platforms that use this driver.

[edk2] [PATCH v2 14/24] ArmVirtPkg/PciHostBridgeDxe: move to FDT client protocol

2016-04-08 Thread Ard Biesheuvel
Instead of relying on VirtFdtDxe to populate various dynamic PCDs with information retrieved from the host provided device tree, perform the PCI ECAM related DT node parsing directly in PciHostBridgeDxe. This means some PCI related PCDs are no longer set, such as PcdPciBusMin, PcdPciBusMax,

[edk2] [PATCH v2 15/24] ArmVirtPkg/VirtFdtDxe: drop PCI host bridge handling

2016-04-08 Thread Ard Biesheuvel
Now that the PCI host bridge driver parses the DT node that describes the PCI host bridge directly via the FDT client protocol, we can drop the handling from VirtFdtDxe completely. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-08 Thread Ard Biesheuvel
Instead of using a constructor, which may reference a dynamic PCD which is set by the DXE entry point of its user, defer the assignment of the global mPciExpressBaseAddress until the first the library is actually invoked. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard

[edk2] [PATCH v2 08/24] ArmVirtPkg: implement ArmVirtTimerFdtClientLib

2016-04-08 Thread Ard Biesheuvel
This implements a library ArmVirtTimerFdtClientLib which is intended to be incorporated into TimerDxe via NULL library class resolution. This allows us to make TimerDxe depend on the FDT client protocol, and discover the timer interrupts from the device tree directly rather than relying on

[edk2] [PATCH v2 22/24] OvmfPkg/XenIoMmioLib: add missing MemoryAllocationLib dependency to INF

2016-04-08 Thread Ard Biesheuvel
XenIoMmioLib depends on MemoryAllocationLib, and uses its header, but failed to declare the dependency in its INF. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf | 1 + 1 file

[edk2] [PATCH v2 12/24] ArmVirtPkg/VirtFdtDxe: remove handling of fw_cfg DT node

2016-04-08 Thread Ard Biesheuvel
Remove the handling of the fw_cfg DT node from VirtFdtDxe now that the fw_cfg client library has been moved to the FDT client protocol, and no longer relies on VirtFdtDxe to pass this information via dynamic PCDs. Since the PCDs in question are now no longer used, remove them from the various DEC

[edk2] [PATCH v2 06/24] ArmVirtPkg/ArmVirtPsciResetSystemLib: move to FDT client protocol

2016-04-08 Thread Ard Biesheuvel
Instead of relying on VirtFdtDxe to detect the PSCI method, move our EfiResetSystemLib to the FDT client protocol to interrogate the device tree directly. Since this library is only consumed by EmbeddedPkg/ResetRuntimeDxe, and considering that the PCD is no longer set, and even removed completely

[edk2] [PATCH v2 01/24] ArmVirtPkg: introduce FdtClientProtocol

2016-04-08 Thread Ard Biesheuvel
This introduces the FdtClientProtocol, which will be used to expose the device tree provided by the host to other DXE drivers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtPkg.dec | 3 +

[edk2] [PATCH v2 04/24] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-08 Thread Ard Biesheuvel
Instead of relying on VirtFdtDxe to populate the GIC related PCDs, move this handling to our implementation of ArmGicArchLib, and retrieve the required DT info using the new FDT client protocol. This removes one of the reasons we need to load VirtFdtDxe first using an 'A PRIORI' declaration in

[edk2] [PATCH v2 03/24] ArmVirtPkg: add FdtClientDxe to the ArmVirtPkg platforms

2016-04-08 Thread Ard Biesheuvel
Add FdtClientDxe to the various platforms under ArmVirtPkg, so that the drivers we will update to depend on the FDT client protocol in subsequent patches will remain in working order. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v2 02/24] ArmVirtPkg/FdtClientDxe: implement new driver

2016-04-08 Thread Ard Biesheuvel
This implements a new DXE driver FdtClientDxe to produce the FDT client protocol based on a device tree image supplied by the virt host. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/FdtClientDxe/FdtClientDxe.c

[edk2] [PATCH v2 00/24] VirtFdtDxe refactoring and removal

2016-04-08 Thread Ard Biesheuvel
This v2 now fully gets rid of the VirtFdtDxe kludge, by moving its functionality to its various clients that access PCDs or protocols supplied by it. Changes since v1: - merged two patches related to Pcd.inf's dependency on itself - incorporated early feedback from Laszlo - tweaked the protocol

[edk2] [PATCH v2 2/2] MdeModulePkg: Update PerformanceLib instances not to check Identifier.

2016-04-08 Thread Liming Gao
In PerformanceLib, Identifier is for single PERF, not the pair of PERF. When find the matched START and END pair, the identifier will not be checked. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

[edk2] [PATCH v2 0/2] Update PerformanceLib not to check Identifier.

2016-04-08 Thread Liming Gao
In V2, update function header comments not to check Identifier. In V1, update PerformanceLib instance not to check Identifier. Liming Gao (2): MdePkg: Update PerformanceLib comments not to check Identifier. MdeModulePkg: Update PerformanceLib instances not to check Identifier.

[edk2] [PATCH v2 1/2] MdePkg: Update PerformanceLib comments not to check Identifier.

2016-04-08 Thread Liming Gao
In PerformanceLib, Identifier is for single PERF, not the pair of PERF. When find the matched START and END pair, the identifier will not be checked. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

Re: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when mv file with cwd is NULL.

2016-04-08 Thread Laszlo Ersek
On 04/08/16 09:53, Qiu Shumin wrote: > Shell will ASSERT when doing the following operation: > "" > Shell> mv fs2:\file1 fs2:\file2 > "" > This patch add NULL pointer check to fix this issue. > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under:

Re: [edk2] [PATCH] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-08 Thread Laszlo Ersek
On 04/08/16 05:07, Ni, Ruiyu wrote: > Laszlo, > After I sent the mail to propose changing the CpuIo driver to improve IO > performance, > I now saw your patch sent earlier than my last mail. A very interesting > feeling. :) Right; after we more or less identified the problem, I dove into the

Re: [edk2] [Patch] MdeModulePkg: Update PerformanceLib instances not to check Identifier.

2016-04-08 Thread Zeng, Star
Liming, Please remember to update the comments of EndPerformanceMeasurementEx and EndGaugeEx. Thanks, Star On 2016/4/8 15:57, Liming Gao wrote: In PerformanceLib, Identifier is for single PERF, not the pair of PERF. EDKII performance library implementation dumps the duration between the

[edk2] [Patch] MdeModulePkg: Update PerformanceLib instances not to check Identifier.

2016-04-08 Thread Liming Gao
In PerformanceLib, Identifier is for single PERF, not the pair of PERF. EDKII performance library implementation dumps the duration between the matched START and END pair. When find the matched START and END pair, the identifier will not be checked. Contributed-under: TianoCore Contribution

[edk2] [Patch] Update edksetup.bat to check EDK_TOOLS_PATH before set it.

2016-04-08 Thread Liming Gao
If EDK_TOOLS_PATH is set, then not set it again. If EDK_TOOLS_PATH is not set, then set it. Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- edksetup.bat | 30 -- 1

[edk2] [PATCH] ShellPkg: Fix Shell ASSERT when mv file with cwd is NULL.

2016-04-08 Thread Qiu Shumin
Shell will ASSERT when doing the following operation: "" Shell> mv fs2:\file1 fs2:\file2 "" This patch add NULL pointer check to fix this issue. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu

Re: [edk2] [Patch] UefiCpuPkg/CpuMpPei: Fix potential AP mwait wakeup issue

2016-04-08 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, April 1, 2016 12:58 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Tian, Feng Subject: [Patch] UefiCpuPkg/CpuMpPei: Fix

Re: [edk2] [PATCH 0/3] Update some S3 related modules to consume PcdAcpiS3Enable to control the code

2016-04-08 Thread Zeng, Star
On 2016/4/8 14:55, Yao, Jiewen wrote: Thanks. 1/3 - I think this is valuable to save SMRAM size. Reviewed-by: jiewen@intel.com 2/3 - I think this is valuable to save Reserved memory size. Reviewed-by: jiewen@intel.com 3/3 - I have concern on this one, because MasterBootMode cannot be

Re: [edk2] [PATCH 0/3] Update some S3 related modules to consume PcdAcpiS3Enable to control the code

2016-04-08 Thread Yao, Jiewen
Thanks. 1/3 - I think this is valuable to save SMRAM size. Reviewed-by: jiewen@intel.com 2/3 - I think this is valuable to save Reserved memory size. Reviewed-by: jiewen@intel.com 3/3 - I have concern on this one, because MasterBootMode cannot be used as indicator for S3 mode or not. It

[edk2] [PATCH 0/3] Update some S3 related modules to consume PcdAcpiS3Enable to control the code

2016-04-08 Thread Star Zeng
Cc: Feng Tian Cc: Jiewen Yao Cc: Jeff Fan Cc: Laszlo Ersek Laszlo, I guess you have interest. Star Zeng (3): MdeModulePkg SmmS3SaveStateDxe: Consume PcdAcpiS3Enable to control the code MdeModulePkg

[edk2] [PATCH 3/3] UefiCpuPkg S3Resume2Pei: Consume PcdAcpiS3Enable to control the code

2016-04-08 Thread Star Zeng
Also add gEfiPeiMasterBootModePpiGuid to [Depex] in *.inf, that makes the producer of PcdAcpiS3Enable has more opportunity to set the PCD value before this module dispatched. According to PI spec Vol 1, gEfiPeiMasterBootModePpiGuid is required, so it should be safe to add it. Cc: Jeff Fan

[edk2] [PATCH 1/3] MdeModulePkg SmmS3SaveStateDxe: Consume PcdAcpiS3Enable to control the code

2016-04-08 Thread Star Zeng
Cc: Feng Tian Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c | 7 +--

[edk2] [PATCH 2/3] MdeModulePkg BootScriptExecutorDxe: Consume PcdAcpiS3Enable to control the code

2016-04-08 Thread Star Zeng
Cc: Feng Tian Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- .../Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.inf | 3 ++-