Re: [edk2] Edk2 uni file encoding

2018-11-07 Thread Sean Brogan via edk2-devel
Liming, That was exactly what I was looking for. Thanks Sean -Original Message- From: Gao, Liming Sent: Wednesday, November 7, 2018 10:01 PM To: Sean Brogan Cc: edk2-devel@lists.01.org Subject: RE: Edk2 uni file encoding Sean: EDKII UNI spec

Re: [edk2] [PATCH] UefiCpuPkg/SmmCpu: Block SMM read-out only when static paging is used

2018-11-07 Thread Yao, Jiewen
Yeah, there is some good resource on the web. ACPI spec defined APEI for error handling. https://www.uefi.org/sites/default/files/resources/ACPI_6_2.pdf Below ppt introduced basic info on memory technology such as spare or mirror. ftp://ftp.hp.com/pub/c-products/servers/options/c00256943.pdf

[edk2] [Patch] BaseTools: Add cache for UniToHexList

2018-11-07 Thread BobCF
From: "bob.c.f...@intel.com" https://bugzilla.tianocore.org/show_bug.cgi?id=1288 This patch is one of build tool performance improvement series patches. This patch is going to add cache for UniToHexList function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: BobCF

[edk2] [Patch] BaseTools: Customize deepcopy function.

2018-11-07 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1288 This patch is one of build tool performance improvement series patches. This patch is going to customize the deepcopy function for SkuClass, PcdClassObject and python dictionary. python deepcopy copy everything of a object, but for our current

Re: [edk2] Edk2 uni file encoding

2018-11-07 Thread Gao, Liming
Sean: EDKII UNI spec (https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Specifications) Chapter 2 defines UNI file format. EdkCompatibilityPkg is obsolete. BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1103 is submitted to delete EdkCompatibilityPkg from edk2/master. We will

Re: [edk2] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-07 Thread Gao, Liming
Star: There is no special process for Hard Feature Freeze. If the people has the comments or rejection for the bug fix in this phase, they can give their comments in review mail. Yes. I will send the mail today to announce Hard Feature Freeze. Laszlo: Thanks for your feedback. We will

Re: [edk2] [Patch] BaseTools: Replace the sqlite database with list

2018-11-07 Thread Feng, Bob C
Hi Ray, Right. No SQL dependency any more after this patch. Thanks, Bob -Original Message- From: Ni, Ruiyu Sent: Thursday, November 8, 2018 1:37 PM To: Feng, Bob C ; edk2-devel@lists.01.org Cc: Carsey, Jaben ; Gao, Liming Subject: Re: [edk2] [Patch] BaseTools: Replace the sqlite

Re: [edk2] [PATCH] EmulatorPkg: Remove PcdShellFile in DSC

2018-11-07 Thread Ni, Ruiyu
On 11/8/2018 10:28 AM, Shenglei Zhang wrote: https://bugzilla.tianocore.org/show_bug.cgi?id=1298 The change is based on the change below: https://lists.01.org/pipermail/edk2-devel/2018-November/031877.html Cc: Jordan Justen Cc: Andrew Fish Cc: Ruiyu Ni Contributed-under: TianoCore

Re: [edk2] [Patch] BaseTools: Replace the sqlite database with list

2018-11-07 Thread Ni, Ruiyu
On 11/8/2018 11:15 AM, BobCF wrote: https://bugzilla.tianocore.org/show_bug.cgi?id=1288 This patch is one of build tool performance improvement series patches. This patch is going to use python list to store the parser data instead of using sqlite database. The replacement solution is as

Re: [edk2] [PATCH] Nt32Pkg: Remove PcdShellFile in DSC

2018-11-07 Thread Wu, Hao A
> -Original Message- > From: Zhang, Shenglei > Sent: Thursday, November 08, 2018 10:28 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Wu, Hao A > Subject: [PATCH] Nt32Pkg: Remove PcdShellFile in DSC > > https://bugzilla.tianocore.org/show_bug.cgi?id=1298 > This change is based on the

Re: [edk2] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-07 Thread Zeng, Star
Has been the time to announce Hard Feature Freeze? During Hard Feature Freeze, every checkin needs to be approved by stewards, right? Thanks, Star On 2018/11/8 3:13, Laszlo Ersek wrote: On 11/07/18 16:38, Leif Lindholm wrote: Hi Laszlo, Can I inject an alternative interpretation? (feel

[edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Separate semaphore container.

2018-11-07 Thread Eric Dong
In current implementation, core level semaphore use same container with package level semaphore. This design will let the core level semaphore not works as expected in below case: 1. Feature A has CPU_FEATURE_CORE_BEFORE dependence with Feature B. 2. Feature C has CPU_FEATURE_PACKAGE_AFTER

[edk2] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Separate semaphore container.

2018-11-07 Thread Eric Dong
In current implementation, core level semaphore use same container with package level semaphore. This design will let the core level semaphore not works as expected in below case: 1. Feature A has CPU_FEATURE_CORE_BEFORE dependence with Feature B. 2. Feature C has CPU_FEATURE_PACKAGE_AFTER

[edk2] [PATCH] Nt32Pkg: Remove PcdShellFile in DSC

2018-11-07 Thread Shenglei Zhang
https://bugzilla.tianocore.org/show_bug.cgi?id=1298 This change is based on the change below: https://lists.01.org/pipermail/edk2-devel/2018-November/031875.html Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH] EmulatorPkg: Remove PcdShellFile in DSC

2018-11-07 Thread Shenglei Zhang
https://bugzilla.tianocore.org/show_bug.cgi?id=1298 The change is based on the change below: https://lists.01.org/pipermail/edk2-devel/2018-November/031877.html Cc: Jordan Justen Cc: Andrew Fish Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang

[edk2] [Patch 0/2] Separate semaphore container.

2018-11-07 Thread Eric Dong
In current implementation, core level semaphore use same container with package level semaphore. This design will let the core level semaphore not works as expected in below case: 1. Feature A has CPU_FEATURE_CORE_BEFORE dependence with Feature B. 2. Feature C has CPU_FEATURE_PACKAGE_AFTER

[edk2] [platforms: PATCH v3 6/7] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc

2018-11-07 Thread Marcin Wojtas
From: Tomasz Michalec Extend MvBoardDescSdMmcGet function to fill MV_BOARD_SDMMC_DESC with Xenon specific info obtained from ArmadaBoardDescLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 1 +

[edk2] [platforms: PATCH v3 5/7] Marvell/Armada80x0Db: Introduce board description library

2018-11-07 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH v3 3/7] SolidRun/Armada80x0McBin: Introduce board description library

2018-11-07 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH v3 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information

2018-11-07 Thread Marcin Wojtas
From: Tomasz Michalec Added fields specific for Xenon host controller and declaration of ArmadaBoardDescSdMmcGet function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 17 - 1

[edk2] [platforms: PATCH v3 1/7] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride

2018-11-07 Thread Marcin Wojtas
The newest changes in the SdMmcOverride protocol added additional arguments to the NotifyPhase and Capability routines. Update according places in the Synquacer Emmc driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH v2 0/7] Armada7k8k Xenon driver rework

2018-11-07 Thread Marcin Wojtas
Hi, The second version of the patchset simply adjust Synquacer and Xenon drivers to the modified SdMmcOverride. The details can be found in the changelog below. Patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/xenon-upstream-r20181108

[edk2] [PATCH v3 4/4] MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency

2018-11-07 Thread Marcin Wojtas
Some SdMmc host controllers are run by clocks with different frequency than it is reflected in Capabilities Register 1. It is allowed by SDHCI specification ver. 4.2 - if BaseClkFreq field value of the Capability Register 1 is zero, the clock frequency must be obtained via another method. Because

[edk2] [PATCH v3 3/4] MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride

2018-11-07 Thread Marcin Wojtas
From: Tomasz Michalec Some SD Host Controlers need to do additional opperations after clock frequency switch. This patch add new callback type to NotifyPhase of the SdMmcOverride protocol. It is called after EmmcSwitchClockFreq and SdMmcHcClockSupply. Contributed-under: TianoCore Contribution

[edk2] [PATCH v3 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-11-07 Thread Marcin Wojtas
From: Tomasz Michalec Some SD Host Controllers use different values in Host Control 2 Register to select UHS Mode. This patch adds a new UhsSignaling type routine to the NotifyPhase of the SdMmcOverride protocol. UHS signaling configuration is moved to a common, default routine

[edk2] [PATCH v3 1/4] MdeModulePkg/SdMmcPciHcDxe: Add an optional parameter in NotifyPhase

2018-11-07 Thread Marcin Wojtas
In order to ensure bigger flexibility in the NotifyPhase routine of the SdMmcOverride protocol, enable using an optional phase-specific data. This will allow to exchange more information between the protocol producer driver and SdMmcPciHcDxe in the newly added callbacks. Contributed-under:

[edk2] [PATCH v3 0/4] SdMmcOverride extension

2018-11-07 Thread Marcin Wojtas
Hi, This is the third version of the patchset, which addresses all remarks that came up during the v2 review, such as updating the bus mode related enum/macro, headers cleanup, etc. Details can be found in the changelog below. Patches are available in the github:

Re: [edk2] [PATCH v1] ShellPkg/TftpDynamicCommand: Clarify the retry count option in command.

2018-11-07 Thread Wu, Jiaxin
Hi Jaben, The patch already has been pushed after received your/Siyuan reviewed-by tag. Thanks, Jiaxin > -Original Message- > From: Carsey, Jaben > Sent: Thursday, November 8, 2018 9:09 AM > To: Fu, Siyuan ; Wu, Jiaxin ; > edk2-devel@lists.01.org > Cc: Ye, Ting > Subject: RE: [PATCH

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-07 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Bi, Dandan Sent: Wednesday, November 7, 2018 10:53 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Dong, Eric ; Zeng, Star ; Wu, Hao A Subject: [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos REF:

Re: [edk2] [PATCH v1] ShellPkg/TftpDynamicCommand: Clarify the retry count option in command.

2018-11-07 Thread Carsey, Jaben
Wu, I plan to push this patch tomorrow, but I would like to add this to the commit message. What do you think? "This fixes the bug where parameter value 0 causes failure." -Jaben > -Original Message- > From: Fu, Siyuan > Sent: Monday, November 05, 2018 10:51 PM > To: Wu, Jiaxin ;

Re: [edk2] [PATCH] ShellPkg/ShellLib: Fix potential NULL deference issue

2018-11-07 Thread Wu, Hao A
> -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, November 07, 2018 5:37 PM > To: edk2-devel@lists.01.org > Cc: Jim Dailey; Wu, Hao A > Subject: [PATCH] ShellPkg/ShellLib: Fix potential NULL deference issue > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()

2018-11-07 Thread Gao, Liming
Cc to the package maintainers. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff > Brasen > Sent: Wednesday, October 31, 2018 5:31 AM > To: edk2-devel@lists.01.org > Cc: Jeff Brasen > Subject: [edk2] [PATCH 1/2]

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-07 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Wednesday, November 7, 2018 10:53 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric ; > Zeng, Star ; Wu, Hao A > > Subject: [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check > for

[edk2] Edk2 uni file encoding

2018-11-07 Thread Sean Brogan via edk2-devel
Is there a definitive answer for the file encoding for all UNI files in edk2? If not I would like to propose one. Incorrect encoding causes tool issues and is something we can easily check for and fix. Proposal: All UNI files in edk2 should be 1. UTF-8 Or 1. Use a BOM and be UTF-16

Re: [edk2] [edk2-test][RFC PATCH 07/12] uefi-sct/SctPkg: sbbr: Add test cases for SBBR v1.0 boot services

2018-11-07 Thread Supreeth Venkatesh
On Tue, 2018-11-06 at 17:46 +, Leif Lindholm wrote: > On Tue, Nov 06, 2018 at 02:17:41PM +0530, Sakar Arora wrote: > > From: John Powell > > > > Tests SBBR requirements 3.4.1 and 3.4.4. It would be better if we add comments on how SBBR requirements 3.4.1 and 3.4.4 relate to the UEFI

Re: [edk2] [PATCH v2] MdePkg/BaseSynchronizationLib: Fix InternalSync[De|In]crement

2018-11-07 Thread Laszlo Ersek
Hi Ray, On 11/07/18 16:54, Ruiyu Ni wrote: > Today's code generates assembly code as below for > InternalSyncIncrement: > __asm__ __volatile__ ( > "movl$1, %%eax \n\t" > "lock \n\t" > "xadd%%eax, %1 \n\t" > "inc %%eax \n\t" > : "=a" (Result),

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle state

2018-11-07 Thread Supreeth Venkatesh
Eric, Could you please split these as PATCH (perhaps 3 or more) series as there are more than 10 files changed in a single patch?. Please see comments inline. On Wed, 2018-11-07 at 14:47 +0800, Eric Jin wrote: > UEFI drivers which implement the EFI_SIMPLE_TEXT_INPUT_EX protocol > are required

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:The Lun display order issue in iSCSI device path text

2018-11-07 Thread Supreeth Venkatesh
Thanks. Reviewed-by: Supreeth Venkatesh On Fri, 2018-11-02 at 03:08 -0500, Eric Jin wrote: > The LUN is an 8 byte array that is displayed in hexadecimal > format with byte 0 first (i.e., on the left) and byte 7 last > (i.e, on the right). > > Cc: Supreeth Venkatesh > Contributed-under:

Re: [edk2] [edk2-test][Patch v2] uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle state

2018-11-07 Thread Supreeth Venkatesh
Some of the same comments of PATCH v1 apply to v2. Please see comments for v1 and resend a patch v3 as a series. Thanks, Supreeth On Wed, 2018-11-07 at 07:19 +, Jin, Eric wrote: > It is the patch v2 below. > > -Original Message- > From: edk2-devel

Re: [edk2] [edk2-test][PATCH] uefi-sct/SctPkg:Add the checkpoint of Toggle state of ReadKeyStrokeEx

2018-11-07 Thread Supreeth Venkatesh
On Wed, 2018-11-07 at 06:45 +, Jin, Eric wrote: > Hi Supreeth, > > Thank for comment. The magic num 7 will be removed in the v2 patch. Thanks. > > Best Regards > Eric > > -Original Message- > From: Supreeth Venkatesh > Sent: Monday, October 15, 2018 10:18 AM > To: Jin, Eric ;

Re: [edk2] [PATCH] MdePkg/BaseIoLibIntrinsicArmVirt ARM: avoid double word loads and stores

2018-11-07 Thread Laszlo Ersek
On 11/07/18 17:47, Philippe Mathieu-Daudé wrote: > On 7/11/18 14:38, Ard Biesheuvel wrote: >> On 7 November 2018 at 14:13, Ard Biesheuvel >> wrote: >>> BaseIoLibIntrinsicArmVirt was created to prevent LTO from merging >>> accesses to MMIO regions, resulting in instructions with multiple >>>

Re: [edk2] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-07 Thread Laszlo Ersek
On 11/07/18 16:38, Leif Lindholm wrote: > Hi Laszlo, > > Can I inject an alternative interpretation? (feel free to shoot it down) > > On Wed, Nov 07, 2018 at 04:14:01PM +0100, Laszlo Ersek wrote: >> Hi, >> >> On 11/07/18 02:12, Gao, Liming wrote: >>> Hi, all >> >>>

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE: fix InternalSync[De|In]crement

2018-11-07 Thread Laszlo Ersek
On 11/07/18 16:27, Ni, Ruiyu wrote: > > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Wednesday, November 7, 2018 10:46 PM >> To: Laszlo Ersek >> Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Michael >> D >> ; Gao, Liming >> Subject: Re:

Re: [edk2] [PATCH] ShellPkg/ShellLib: Fix potential NULL deference issue

2018-11-07 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, November 07, 2018 1:37 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Jim Dailey > Subject: [edk2] [PATCH] ShellPkg/ShellLib: Fix

Re: [edk2] [PATCH 2/2] MdePkg/UefiDebugLibStdErr: Pass the correct buffer size.

2018-11-07 Thread Philippe Mathieu-Daudé
On 5/11/18 13:54, Marvin Häuser wrote: The second argument of "UnicodeVSPrintAsciiFormat" is "BufferSize", which takes the size of the buffer in bytes. Replace the currently used MAX_DEBUG_MESSAGE_LENGTH reference, which is the buffer's length, with the actual buffer size. Contributed-under:

Re: [edk2] [PATCH 1/2] MdePkg/UefiDebugLibConOut: Pass the correct buffer size.

2018-11-07 Thread Philippe Mathieu-Daudé
On 5/11/18 13:54, Marvin Häuser wrote: The second argument of "UnicodeVSPrintAsciiFormat" is "BufferSize", which takes the size of the buffer in bytes. Replace the currently used MAX_DEBUG_MESSAGE_LENGTH reference, which is the buffer's length, with the actual buffer size. Contributed-under:

Re: [edk2] [PATCH] ShellPkg/ShellLib: Fix potential NULL deference issue

2018-11-07 Thread Philippe Mathieu-Daudé
On 7/11/18 10:36, Ruiyu Ni wrote: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jim Dailey Cc: Hao A Wu Reviewed-by: Philippe Mathieu-Daudé --- ShellPkg/Library/UefiShellLib/UefiShellLib.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [edk2] [PATCH v3] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-07 Thread Laszlo Ersek
On 11/07/18 04:47, yuchen...@synology.com wrote: > From: yuchenlin > > BAR |std vga | vmsvga > - > 0| Framebuffer | I/O space > 1| Reserved | Framebuffer > 2| MMIO | FIFO > > - We cannot recognize VMW SVGA as BOCHS because

Re: [edk2] [PATCH] MdePkg/BaseIoLibIntrinsicArmVirt ARM: avoid double word loads and stores

2018-11-07 Thread Philippe Mathieu-Daudé
On 7/11/18 14:38, Ard Biesheuvel wrote: On 7 November 2018 at 14:13, Ard Biesheuvel wrote: BaseIoLibIntrinsicArmVirt was created to prevent LTO from merging accesses to MMIO regions, resulting in instructions with multiple output registers that KVM on ARM cannot emulate (since the exception

[edk2] [PATCH v2] MdePkg/BaseSynchronizationLib: Fix InternalSync[De|In]crement

2018-11-07 Thread Ruiyu Ni
Today's code generates assembly code as below for InternalSyncIncrement: __asm__ __volatile__ ( "movl$1, %%eax \n\t" "lock \n\t" "xadd%%eax, %1 \n\t" "inc %%eax \n\t" : "=a" (Result), // %0 "+m" (*Value) // %1 :

Re: [edk2] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-07 Thread Leif Lindholm
Hi Laszlo, Can I inject an alternative interpretation? (feel free to shoot it down) On Wed, Nov 07, 2018 at 04:14:01PM +0100, Laszlo Ersek wrote: > Hi, > > On 11/07/18 02:12, Gao, Liming wrote: > > Hi, all > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > >

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order.

2018-11-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: Dong, Eric > Sent: Wednesday, November 7, 2018 4:26 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Ni, Ruiyu > Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order. > > In current code logic, only adjust feature

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE: fix InternalSync[De|In]crement

2018-11-07 Thread Ni, Ruiyu
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, November 7, 2018 10:46 PM > To: Laszlo Ersek > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Michael D > ; Gao, Liming > Subject: Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE:

Re: [edk2] [PATCH edk2/ArmPkg v1 1/1] ArmPkg: Fix Gic interrupt routing modes bug

2018-11-07 Thread Ard Biesheuvel
On 7 November 2018 at 16:07, Marc Zyngier wrote: > On 07/11/18 14:48, Ard Biesheuvel wrote: >> (+ Marc) >> >> >> On 29 October 2018 at 05:57, Ming Huang wrote: >>> As GicV3 Spec, Interrupt Routing Modes should be 0 for >>> routing the SPIs to the primary CPU. >>> >>> Contributed-under: TianoCore

Re: [edk2] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-07 Thread Laszlo Ersek
Hi, On 11/07/18 02:12, Gao, Liming wrote: > Hi, all > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > lists edk2-stable201811 tag planning. Now, we enter into Soft Feature > Freeze phase. In this phase, the feature under review will not be > allowed to be pushed.

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-11-07 Thread Ard Biesheuvel
On 7 November 2018 at 16:00, Zeng, Star wrote: > On 2018/11/6 22:37, Zeng, Star wrote: >> >> On 2018/11/6 17:49, Ard Biesheuvel wrote: >>> >>> On 31 October 2018 at 05:38, Zeng, Star wrote: Good feedback. On 2018/10/30 20:50, Leif Lindholm wrote: > > > On Tue, Oct

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-11-07 Thread Zeng, Star
On 2018/11/6 22:37, Zeng, Star wrote: On 2018/11/6 17:49, Ard Biesheuvel wrote: On 31 October 2018 at 05:38, Zeng, Star wrote: Good feedback. On 2018/10/30 20:50, Leif Lindholm wrote: On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: (add back the list) Oi! Go back on

Re: [edk2] [PATCH v2] UefiCpuPkg/SmmCpu: Block access-out only when static paging is used

2018-11-07 Thread Ni, Ruiyu
I agree my 1st version commit message is too general. Because I don't know if RAS can be mentioned:) > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 7, 2018 10:46 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE: fix InternalSync[De|In]crement

2018-11-07 Thread Ni, Ruiyu
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Wednesday, November 7, 2018 10:42 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2] [PATCH]

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

2018-11-07 Thread Leif Lindholm
On Tue, Nov 06, 2018 at 10:10:16PM +, Kinney, Michael D wrote: > Hi Ard, > > Can you please add CC lines to the commit message > for the developers that have contributed to the > edk2-staging/Intel_UNDI branch? > > This would include: > > Cc: Maciej Rabeda > Cc: Kamil Kacperski Could

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE: fix InternalSync[De|In]crement

2018-11-07 Thread Ni, Ruiyu
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 7, 2018 10:32 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > ; Philippe Mathieu-Daudé ; > Andrew Fish > Subject: Re: [PATCH]

[edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-07 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1306 In function UiDisplayMenu, the NewPos ptr which used to point to the highlight menu entry. It will always point to the menu entry which need to be highlighted or the gMenuOption menu if the highlight menu is not found. So we can remove the

Re: [edk2] [PATCH edk2/ArmPkg v1 1/1] ArmPkg: Fix Gic interrupt routing modes bug

2018-11-07 Thread Ard Biesheuvel
(+ Marc) On 29 October 2018 at 05:57, Ming Huang wrote: > As GicV3 Spec, Interrupt Routing Modes should be 0 for > routing the SPIs to the primary CPU. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 2

Re: [edk2] [PATCH v2] UefiCpuPkg/SmmCpu: Block access-out only when static paging is used

2018-11-07 Thread Laszlo Ersek
On 11/07/18 09:59, Ruiyu Ni wrote: > From: Jiewen Yao > > When static paging is disabled, page table for below 4GB is created > and page table for above 4GB is created dynamically in page fault > handler. > > Today's implementation only allow SMM access-out to below types of > memory address no

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE: fix InternalSync[De|In]crement

2018-11-07 Thread Ard Biesheuvel
On 7 November 2018 at 15:31, Laszlo Ersek wrote: > (+Andrew) > > Hi Ray, > > On 11/07/18 05:03, Ruiyu Ni wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1303 >> >> XCODE disassembly code of InternalSyncDecrement with today's code is: >> >> __asm__ __volatile__ ( >> "movl

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE: fix InternalSync[De|In]crement

2018-11-07 Thread Laszlo Ersek
On 11/07/18 15:31, Laszlo Ersek wrote: > (+Andrew) > > Hi Ray, > > On 11/07/18 05:03, Ruiyu Ni wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1303 >> >> XCODE disassembly code of InternalSyncDecrement with today's code is: >> >> __asm__ __volatile__ ( >> "movl$1, %%eax

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE: fix InternalSync[De|In]crement

2018-11-07 Thread Laszlo Ersek
(+Andrew) Hi Ray, On 11/07/18 05:03, Ruiyu Ni wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1303 > > XCODE disassembly code of InternalSyncDecrement with today's code is: > > __asm__ __volatile__ ( > "movl$1, %%eax \n\t" > "lock \n\t" > "xadd

Re: [edk2] [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast

2018-11-07 Thread Philippe Mathieu-Daudé
On 6/11/18 18:58, Ard Biesheuvel wrote: Unlike Visual Studio, GCC does not permit implicit conversion between a pointer-to-void-pointer and pointer to a typed pointer. So add the explicit casts where necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order.

2018-11-07 Thread Laszlo Ersek
On 11/07/18 09:26, Eric Dong wrote: > In current code logic, only adjust feature position if current CPU > feature position not follow the request order. Just like Feature A > need to be executed before feature B, but current feature A registers > after feature B. So code will adjust the position

Re: [edk2] [PATCH] MdePkg/BaseIoLibIntrinsicArmVirt ARM: avoid double word loads and stores

2018-11-07 Thread Ard Biesheuvel
On 7 November 2018 at 14:13, Ard Biesheuvel wrote: > BaseIoLibIntrinsicArmVirt was created to prevent LTO from merging > accesses to MMIO regions, resulting in instructions with multiple > output registers that KVM on ARM cannot emulate (since the exception > syndrome information that KVM relies

Re: [edk2] [PATCH] UefiCpuPkg/SmmCpu: Block SMM read-out only when static paging is used

2018-11-07 Thread Laszlo Ersek
On 11/07/18 09:27, Yao, Jiewen wrote: > If Static paging is not used, then the SMM uses dynamic paging. > > Here dynamic paging means the page fault request on-demand. > > 2 special examples here: > 1) above 4G MMIO. By default, SMM only setup paging table for 4G memory. If > MMIO above 4G,

[edk2] [PATCH] MdePkg/BaseIoLibIntrinsicArmVirt ARM: avoid double word loads and stores

2018-11-07 Thread Ard Biesheuvel
BaseIoLibIntrinsicArmVirt was created to prevent LTO from merging accesses to MMIO regions, resulting in instructions with multiple output registers that KVM on ARM cannot emulate (since the exception syndrome information that KVM relies on can only describe a single output register) However,

Re: [edk2] [PATCH 0/2] Revert "EhciDxe/XhciDxe: Use common buffer for AsyncInterruptTransfer"

2018-11-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Tuesday, November 6, 2018 10:34 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Ni, Ruiyu ; Wu, > Hao A ; Wang, Jian J ; Yao, > Jiewen ; Leif Lindholm ; > Ard Biesheuvel > Subject: [PATCH 0/2] Revert

[edk2] [PATCH] ShellPkg/ShellLib: Fix potential NULL deference issue

2018-11-07 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jim Dailey Cc: Hao A Wu --- ShellPkg/Library/UefiShellLib/UefiShellLib.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c

[edk2] [PATCH] BaseTools: Enable Pcd Array support.

2018-11-07 Thread BobCF
From: "bob.c.f...@intel.com" https://bugzilla.tianocore.org/show_bug.cgi?id=1292 This patch is going to enable Array data type for PCD. 1. Support Pcd ARRAY as Structure PCD type including basic datatype array and structure array. For example:

Re: [edk2] [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast

2018-11-07 Thread Philippe Mathieu-Daudé
On 6/11/18 18:58, Ard Biesheuvel wrote: Unlike Visual Studio, GCC does not permit implicit conversion between a pointer-to-void-pointer and pointer to a typed pointer. So add the explicit casts where necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard

Re: [edk2] [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast

2018-11-07 Thread Philippe Mathieu-Daudé
On 6/11/18 21:35, Ard Biesheuvel wrote: On 6 November 2018 at 21:31, Philippe Mathieu-Daudé wrote: Hi Ard, On 6/11/18 18:58, Ard Biesheuvel wrote: UINT8 and CHAR8 are not the same underlying type on all architectures, so add an explicit cast where necessary. Contributed-under: TianoCore

Re: [edk2] [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables

2018-11-07 Thread Philippe Mathieu-Daudé
On 6/11/18 18:58, Ard Biesheuvel wrote: Drop variables that are assigned but never used, or move them into a conditional preprocessor block if the only references occur from such code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH v2] UefiCpuPkg/SmmCpu: Block access-out only when static paging is used

2018-11-07 Thread Yao, Jiewen
reviewed-by: jiewen@intel.com thank you! Yao, Jiewen > 在 2018年11月7日,下午4:58,Ni, Ruiyu 写道: > > From: Jiewen Yao > > When static paging is disabled, page table for below 4GB is created > and page table for above 4GB is created dynamically in page fault > handler. > > Today's

Re: [edk2] [PATCH v3 1/2] MdeModulePkg/Core: fill logic hole in MemoryProtectionCpuArchProtocolNotify

2018-11-07 Thread Wang, Jian J
Leif, Thanks for the comments. I'll push the patch after removing the change log from the commit log. Regards, Jian > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, November 07, 2018 3:53 PM > To: Wang, Jian J > Cc:

Re: [edk2] [PATCH] UefiCpuPkg/SmmCpu: Block SMM read-out only when static paging is used

2018-11-07 Thread Yao, Jiewen
If Static paging is not used, then the SMM uses dynamic paging. Here dynamic paging means the page fault request on-demand. 2 special examples here: 1) above 4G MMIO. By default, SMM only setup paging table for 4G memory. If MMIO above 4G, then SMM need use #PF handler to grant MMIO access. 2)

[edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order.

2018-11-07 Thread Eric Dong
In current code logic, only adjust feature position if current CPU feature position not follow the request order. Just like Feature A need to be executed before feature B, but current feature A registers after feature B. So code will adjust the position for feature A, move it to just before

Re: [edk2] [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers.

2018-11-07 Thread Leif Lindholm
Hi Fu Siyan, On Wed, Nov 07, 2018 at 08:12:55AM +, Fu, Siyuan wrote: > Hi, Leif and Ard > > I just realized that you may not be CCed in this email. I resent these > patches a few minutes ago, my Git Bash send-email reports it added you to CC > receiver, but the Outlook received email still

Re: [edk2] [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers.

2018-11-07 Thread Fu, Siyuan
Hi, Leif and Ard I just realized that you may not be CCed in this email. I resent these patches a few minutes ago, my Git Bash send-email reports it added you to CC receiver, but the Outlook received email still doesn't have your name in CC list. Do you have any comments for this v2 patch of

[edk2] [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers.

2018-11-07 Thread Fu Siyuan
V2: Additional fixups required for NetworkPkg migration The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. All platform DSC/FDF files should be updated to use the dual-stack drivers in NetworkPkg. The NetworkPkg driver have all the functionality compared with MdeModulePkg one,

[edk2] [PATCH v2 1/2] Platform/Hisilicon: CRLF fixups for D05.dsc

2018-11-07 Thread Fu Siyuan
From: Leif Lindholm Commit 1a13dfd37fe7 ("Hisilicon/D0x: Switch to generic PciHostBridge driver") introduced some incorrect line endings, fix those here. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif

[edk2] [PATCH v2 0/2] Update platform DSC/FDF files for NetworkPkg migration.

2018-11-07 Thread Fu Siyuan
Patch 1/2 fixes the line ending issue introduced by Ccommit 1a13dfd37fe7 ("Hisilicon/D0x: Switch to generic PciHostBridge driver"). Patch 2/2 updates all platform DSC/FDF files for NetworkPkg migration. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Fu Siyuan (1): Edk2Platforms: