On 2/22/2018 2:54 PM, Heyi Guo wrote:
This is the draft patch for the discussion posted in edk2-devel
mailing list:
https://lists.01.org/pipermail/edk2-devel/2017-December/019289.html
As discussed in the mailing list, we'd like to add support for PCI
address translation which is necessary for
On 02/20/2018 11:54 PM, Laszlo Ersek wrote:
> Hi,
>
> On 02/15/18 16:14, Haojian Zhuang wrote:
>> Add four boot options in emu variable region. They are
>> "Boot on SD", "Grub", "Android Boot" and "Android Fastboot".
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by:
On 2/22/2018 2:54 PM, Heyi Guo wrote:
This is the draft patch for the discussion posted in edk2-devel
mailing list:
https://lists.01.org/pipermail/edk2-devel/2017-December/019289.html
As discussed in the mailing list, we'd like to add support for PCI
address translation which is necessary for
On 02/21/18 19:58, Leif Lindholm wrote:
> On Wed, Feb 21, 2018 at 05:06:02PM +0100, Laszlo Ersek wrote:
>> On 02/21/18 16:46, Leif Lindholm wrote:
>>> Apologies for dropping the ball on this series during my sabbatical.
>>>
>>> For this particular patch, I would still like to see a core library
On 2/20/2018 2:18 PM, Meenakshi Aggarwal wrote:
Hi Ray,
Please share your comments.
Thanks,
Meenakshi
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, February 16, 2018 8:51 PM
To: Meenakshi Aggarwal ; Ni, Ruiyu
On Thu, Feb 22, 2018 at 05:26:58PM +0800, Ming Huang wrote:
> These two patchs are missed for 18.02. They are recommended for 18.02.
These look simple enough that I might consider cherry-picking them
into the 18.02 build, but I would also like to see some response to
On 02/22/18 07:54, Heyi Guo wrote:
> PciIo::GetBarAttributes should return CPU view address according to
> UEFI spec 2.7, so we change the implementation to follow the spec.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Heyi Guo
> Cc: Ruiyu Ni
Hello Heyi,
On 02/22/18 07:54, Heyi Guo wrote:
> This is the draft patch for the discussion posted in edk2-devel
> mailing list:
> https://lists.01.org/pipermail/edk2-devel/2017-December/019289.html
>
> As discussed in the mailing list, we'd like to add support for PCI
> address translation
On 02/22/18 09:57, Haojian Zhuang wrote:
> On 02/20/2018 11:54 PM, Laszlo Ersek wrote:
>> Hi,
>>
>> On 02/15/18 16:14, Haojian Zhuang wrote:
>>> Add four boot options in emu variable region. They are
>>> "Boot on SD", "Grub", "Android Boot" and "Android Fastboot".
>>>
>>> Contributed-under:
Thanks Ray and Laszlo; I think I'd better refine comments and commit message
first, or it is rather confusing for review.
I'll send v3 ASAP.
Regards,
Gary
On Thu, Feb 22, 2018 at 11:06:13AM +0100, Laszlo Ersek wrote:
> On 02/22/18 07:54, Heyi Guo wrote:
> > v2:
> > Changs are made according to
On 02/22/18 07:54, Heyi Guo wrote:
> v2:
> Changs are made according to the discussion on the mailing list, including:
>
> 1. PciRootBridgeIo->Configuration should return CPU view address, as well as
> PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view
> address - CPU
On Tue, Feb 20, 2018 at 05:49:38PM +, Ard Biesheuvel wrote:
> This adds support for using the random number generator in the Atmel
> AtSha204a over I2C. Other functionality of the chip is currently
> unsupported.
>
> Note that the the I2C support in this device essentially violates the
>
On Thu, Feb 22, 2018 at 01:21:37PM +, Ard Biesheuvel wrote:
> On 22 February 2018 at 13:15, Leif Lindholm wrote:
> > On Tue, Feb 20, 2018 at 05:49:39PM +, Ard Biesheuvel wrote:
> >> Introduce the mezzanine protocol and the 96boards package defining
> >> the PCDs
On Tue, Feb 20, 2018 at 05:49:39PM +, Ard Biesheuvel wrote:
> Introduce the mezzanine protocol and the 96boards package defining
> the PCDs and GUIDs that may be used by implementations of the
> protocol.
This looks really good. Comments below are all style related.
> Contributed-under:
On 22 February 2018 at 13:15, Leif Lindholm wrote:
> On Tue, Feb 20, 2018 at 05:49:39PM +, Ard Biesheuvel wrote:
>> Introduce the mezzanine protocol and the 96boards package defining
>> the PCDs and GUIDs that may be used by implementations of the
>> protocol.
>
>
On 02/22/18 12:52, Leif Lindholm wrote:
> On Thu, Feb 22, 2018 at 09:34:05AM +0100, Laszlo Ersek wrote:
>>> But that brings back the complication as to how we have a driver that
>>> needs an LE IO library to write output, and a BE IO library to
>>> manipulate the hardware.
>>
>> Can you please
On 02/22/18 12:20, Laszlo Ersek wrote:
> Hi Brijesh!
>
> (adding Paolo and Mike; more comments below)
>
> On 02/21/18 17:52, Brijesh Singh wrote:
>> When OVMF is built with SMM, SMMSaved State area (SMM_DEFAULT_SMBASE +
>> SMRAM_SAVE_STATE_MAP_OFFSET) contains data which need to be accessed by
On Thu, Feb 22, 2018 at 11:56:22AM +0100, Laszlo Ersek wrote:
> Sorry, I don't understand how this follows. Again: why is it only a
> temporary solution to implement a PlatformBootManagerLib instance for HiKey?
>
> The library class says "Platform" in the name. Platforms are supposed to
> provide
On 02/22/2018 06:56 PM, Laszlo Ersek wrote:
> On 02/22/18 09:57, Haojian Zhuang wrote:
>> On 02/20/2018 11:54 PM, Laszlo Ersek wrote:
>>> Hi,
>>>
>>> On 02/15/18 16:14, Haojian Zhuang wrote:
Add four boot options in emu variable region. They are
"Boot on SD", "Grub", "Android Boot" and
On 02/21/18 17:52, Brijesh Singh wrote:
> Commit:24e4ad7 (OvmfPkg: Add AmdSevDxe driver) added a driver which runs
> early in PEI phase and clears the C-bit from all MMIO regions (including
s/PEI/DXE/
> Qemu Flash). When SMM is enabled, we build two sets of page tables; first
> page table is
Hi Brijesh!
(adding Paolo and Mike; more comments below)
On 02/21/18 17:52, Brijesh Singh wrote:
> When OVMF is built with SMM, SMMSaved State area (SMM_DEFAULT_SMBASE +
> SMRAM_SAVE_STATE_MAP_OFFSET) contains data which need to be accessed by
> both guest and hypervisor. Since the data need to
Hi TPM expert,
The line in
https://github.com/tianocore/edk2/commit/73126ac2bd9804632255b2fddd4d7633537c9620#diff-76abe1c1ebf05982ed72eaf56f489029R192
change the byte order of Manufacture ID in Tpm2GetCapabilityManufactureID ().
I see it return "reversed" ManufactureId for two TPM vendor's
On Thu, Feb 22, 2018 at 09:34:05AM +0100, Laszlo Ersek wrote:
> >> - As long as the specs are LE-only, "endianness opposite to the
> >> executing processor" is needless complication / speculative generality
> >> in my eyes.
> >
> > HTON/NTOH?
>
> I don't understand this reference; host-to-net
Turn off PcdHiiOsRuntimeSupport to fix hanging issue while enter
shell with some mellanox net cards.The option ROM of card loads an
empty interface to the gEfiHiiConfigAccessProtocolGuid.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
These two patchs are missed for 18.02. They are recommended for 18.02.
Ming Huang (2):
Hilisicon/D03: Change DmaLib for PciHostBridgeDxe
Hisilicon/D03: Set PcdHiiOsRuntimeSupport to FALSE
Platform/Hisilicon/D03/D03.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
1.9.1
Change DmaLib from NonCoherentDmaLib to CoherentDmaLib for support
cache consistency.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wang Yue
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D03/D03.dsc | 2 +-
1 file
On 02/22/18 19:15, Ard Biesheuvel wrote:
> Introduce a variant of BaseDebugLibSerialPort that behaves correctly with
> regards to the use of the serial port after ExitBootServices(). At boot
> time, all DEBUG() prints and ASSERT() invocations are executed normally.
> At runtime, DEBUG() prints are
Introduce a variant of BaseDebugLibSerialPort that behaves correctly with
regards to the use of the serial port after ExitBootServices(). Also, it
caches PCD values in the constructor so that no calls into PcdLib are
made at runtime.
Contributed-under: TianoCore Contribution Agreement 1.1
Switch all users of ArmVirt.dsc.inc to the new DebugLib implementation
that was created especially for DXE_RUNTIME_DRIVER modules, ensuring
that DEBUG() calls do not touch the UART at runtime.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more debug
message") broke the DEBUG build for systems using a MMIO mapped UART for
DEBUG output. In other words, it broke the build for all ARM and AARCH64
systems, given that port I/O does not exist on those architectures.
Instead of
On 02/22/18 18:50, Ard Biesheuvel wrote:
> On 22 February 2018 at 17:46, Kinney, Michael D
> wrote:
>> Ard,
>>
>> The check for the runtime flag seems inconsistent.
>>
>> Since the issue being addressed is use of SerialPortLib,
>> can't the mEfiAtRuntime flag be use
On Tue, Feb 20, 2018 at 05:49:43PM +, Ard Biesheuvel wrote:
> This adds a driver that manages the 96boards LS connector, i.e, it
> installs a HII page to configure the type of mezzanine that is installed
> in the slot, and it exposes this information via the LS connector protocol.
> It is also
Hi Jaben,
I have resubmitted the updated patch and the code can be seen at
https://github.com/samimujawar/edk2/tree/188_acpiview_v3
Please see my response marked [SAMI] below:
1) Can the individual "child" libraries be placed into subdirectories
under UefiShellAcpiViewCommandLib directory
On 22 February 2018 at 16:28, Ard Biesheuvel wrote:
> Introduce a variant of BaseDebugLibSerialPort that behaves correctly with
> regards to the use of the serial port after ExitBootServices(). Also, it
> caches PCD values in the constructor so that no calls into PcdLib
Ard,
The check for the runtime flag seems inconsistent.
Since the issue being addressed is use of SerialPortLib,
can't the mEfiAtRuntime flag be use around SerialPortLib
calls only.
Mike
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday,
On 22 February 2018 at 17:46, Kinney, Michael D
wrote:
> Ard,
>
> The check for the runtime flag seems inconsistent.
>
> Since the issue being addressed is use of SerialPortLib,
> can't the mEfiAtRuntime flag be use around SerialPortLib
> calls only.
>
I take it you
On 15 December 2017 at 16:59, Leif Lindholm wrote:
> Use UefiMultiPhase.h in Vfr.vfr instead of duplicating EFI_VARIABLE_*
> definitions.
>
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif
On Tue, Feb 20, 2018 at 05:49:42PM +, Ard Biesheuvel wrote:
> Add a driver that describes the Secure96 mezzanine board, and exposes
> both the information required to describe it to the OS using a DT overlay,
> and to describe it to UEFI itself.
>
> Contributed-under: TianoCore Contribution
So, the ones I haven't commented on in this series, I'm happy with,
but since there may be non-trivial refactoring I'm not posting R-b on yet.
On Tue, Feb 20, 2018 at 05:49:37PM +, Ard Biesheuvel wrote:
> Almost a complete rewrite of the v1. I omitted the patches that add SPI
> and I2C DT
Switch all users of ArmVirt.dsc.inc to the new DebugLib implementation
that was created especially for DXE_RUNTIME_DRIVER modules, ensuring
that DEBUG() calls do not touch the UART at runtime.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more debug
message") broke the DEBUG build for systems using a MMIO mapped UART for
DEBUG output. In other words, it broke the build for all ARM and AARCH64
systems, given that port I/O does not exist on those architectures.
Instead of
On 02/22/18 17:28, Ard Biesheuvel wrote:
> Introduce a variant of BaseDebugLibSerialPort that behaves correctly with
> regards to the use of the serial port after ExitBootServices(). Also, it
> caches PCD values in the constructor so that no calls into PcdLib are
> made at runtime.
>
>
On 22 February 2018 at 19:00, Ard Biesheuvel wrote:
> On 22 February 2018 at 15:59, Leif Lindholm wrote:
>> On Tue, Feb 20, 2018 at 05:49:43PM +, Ard Biesheuvel wrote:
>>> This adds a driver that manages the 96boards LS connector, i.e, it
On 22 February 2018 at 15:59, Leif Lindholm wrote:
> On Tue, Feb 20, 2018 at 05:49:43PM +, Ard Biesheuvel wrote:
>> This adds a driver that manages the 96boards LS connector, i.e, it
>> installs a HII page to configure the type of mezzanine that is installed
>> in
Hi Star,
I lost track of this one during my sabbatical until Ard's patch
earlier today jogged my memory.
On Sun, Dec 17, 2017 at 11:23:10AM +, Zeng, Star wrote:
> You may submit a bugzilla for the long term approach as Liming
> suggested in V1 patch series, and then add the bug link in this
Ard,
In DebugAssert(), if you have deadloop or BP enabled for
the ASSERT(), then it would be good to have the message
available in the local variable Buffer.
Perhaps only the call to SerialPortWrite() should be
filtered.
Mike
> -Original Message-
> From: Ard Biesheuvel
Introduce a variant of BaseDebugLibSerialPort that behaves correctly with
regards to the use of the serial port after ExitBootServices(). At boot
time, all DEBUG() prints and ASSERT() invocations are executed normally.
At runtime, DEBUG() prints are dropped entirely, and ASSERT()s omit the
serial
Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more debug
message") broke the DEBUG build for systems using a MMIO mapped UART for
DEBUG output. In other words, it broke the build for all ARM and AARCH64
systems, given that port I/O does not exist on those architectures.
Instead of
On 22 February 2018 at 19:40, Kinney, Michael D
wrote:
>
> Ard,
>
> In DebugAssert(), if you have deadloop or BP enabled for
> the ASSERT(), then it would be good to have the message
> available in the local variable Buffer.
>
> Perhaps only the call to
Switch all users of ArmVirt.dsc.inc to the new DebugLib implementation
that was created especially for DXE_RUNTIME_DRIVER modules, ensuring
that DEBUG() calls do not touch the UART at runtime.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
On Thu, Feb 22, 2018 at 07:10:52PM +, Ard Biesheuvel wrote:
> >>> +#define MEZZANINE_NONE0x0
> >>> +#define MEZZANINE_SECURE960x1
> >>> +#define MEZZANINE_MAX 0x1
> >>
> >> Would this be simpler as an enum with a
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=877
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu
---
MdeModulePkg/Include/Guid/RecoveryDevice.h | 10 +-
1
Hi Jeremy,
This TF binaries have not been patched the latest SMCCC workaround; it is based
on v1.4 release and was only
patched with "disable/enable MMU in PSCI SMC call", as the commit in upstream TF
code:
f62ad322695d16178db464dc062fe0af592c6780
When we generated these binaries, SMCCC patches
On Thu, Feb 22, 2018 at 11:41:50AM +0100, Laszlo Ersek wrote:
> On 02/22/18 07:54, Heyi Guo wrote:
> > PciIo::GetBarAttributes should return CPU view address according to
> > UEFI spec 2.7, so we change the implementation to follow the spec.
> >
> > Contributed-under: TianoCore Contribution
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu
Sent: Friday, February 23, 2018 8:50 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Dong, Eric
Leif,
On 2018/2/23 4:09, Leif Lindholm wrote:
Hi Star,
I lost track of this one during my sabbatical until Ard's patch
earlier today jogged my memory.
On Sun, Dec 17, 2017 at 11:23:10AM +, Zeng, Star wrote:
You may submit a bugzilla for the long term approach as Liming
suggested in V1
Two minor comments, with them handled, Reviewed-by: Star Zeng
.
1. For patch 1 and 2, update 'registers' to 'registered' in the comments for
parameters DestinationX/DestinationY/Width/Height of EDKII_GET_BOOT_LOGO2?
2. For patch 3, update 'functionm' to ' function'?
For structure PCD, the field value may override in the command line,
so in the report when we print the field info we add *B Flag for those
field.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
V2: Add *B info for structure pcd field value that from build command
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
Hi Derek:
Can you specify the "reversed" ManufactureId issue? What did you get from
this interface?
The implementation follows Vendor ID registry spec. The vendor ID is octet
array. There is no endian issue here.
We haven't seen any disorder before.
From: Lin, Derek (HPS UEFI Dev)
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: zwei4
---
.../Common/Acpi/AcpiTablesPCAT/Platform.asl | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>achin.gu...@arm.com
>Sent: Thursday, February 15, 2018 9:32 PM
>To: edk2-devel@lists.01.org
>Cc: af...@apple.com; leif.lindh...@linaro.org; Yao,
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Thursday, February 22, 2018 10:32 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Add WindowsLike path in
Hi,
On 02/02/2018 05:57 AM, Heyi Guo wrote:
1 Workarounds for CVE-2017-5715 on Cortex A57/A72/A73 and A75 #1214.
I've been trying to verify spectre fixes, and I don't get a smccc
version from this firmware (see this kernel branch
On 22 February 2018 at 13:44, Leif Lindholm wrote:
> On Thu, Feb 22, 2018 at 01:21:37PM +, Ard Biesheuvel wrote:
>> On 22 February 2018 at 13:15, Leif Lindholm wrote:
>> > On Tue, Feb 20, 2018 at 05:49:39PM +, Ard Biesheuvel wrote:
>>
On 20 February 2018 at 19:22, Kinney, Michael D
wrote:
> Ard,
>
> Both FixedAtBuild and PatchableInModule are
> safe at runtime. Should not limit to only
> FixedAtBuild.
>
OK. So that means we'll need to cache the PCD values in the constructor instead.
> It is also
On Tue, Feb 20, 2018 at 05:49:41PM +, Ard Biesheuvel wrote:
> Introduce a protocol describing the presence of a 96boards LS connector,
Can you expand the LS here?
(It's used as a proper name, so I don't consider it needing expansion
below, but useful for introduction.)
> and identifying the
1. UINT64 Value {"A", "B"}, the expect value 0x420041.
2. Byte array number should less than 0xFF.
{256, 0xff} will report error because of 256 larger than 0xFF
3. comma in GUID() and DEVICE_PATH() split issue
Cc: Liming Gao
Cc: Yonghong Zhu
68 matches
Mail list logo