On Tue, Jul 24, 2018 at 03:08:46PM +0800, Ming Huang wrote:
> As the mocro of PlatformArch.h is platform special, so Separate
mocro -> macro (typo)
special -> specific (subtleties of English language :)
Separate -> separate (case)
> PlatformArch.h to Hi1610,Hi1616,Hi1620 for unifying D0x.
>
>
Could the subject be changed to "add edk2-non-osi components for D06"?
I should point out that I really like how this is done as a separate
patch.
On Tue, Jul 24, 2018 at 03:08:49PM +0800, Ming Huang wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
>
On Tue, Jul 24, 2018 at 03:08:52PM +0800, Ming Huang wrote:
> The EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE struct is used by
> UpdateAcpiTable.c and Srat aslc. The struct may be different
> according to chips, so move some macro to PlatformArch.h.
>
> Contributed-under: TianoCore Contribution
On 08/02/18 17:40, Gao, Liming wrote:
> Laszlo:
> I understand this patch set is to provide the way to append compile and
> link option for BaseTools source build.
Yes.
> If so, the extend flag name may be EXTRA_CCFLAGS
I can rename EXTRA_OPTFLAGS to EXTRA_CCFLAGS, but in that case,
On Tue, Jul 24, 2018 at 03:08:53PM +0800, Ming Huang wrote:
> From: Yan Zhang
>
> Debug serial port init driver is added to initilize debug
> serial port.
What is special about this platform that makes it require a separate
initialization function for the PL011?
/
Leif
>
On 08/02/18 15:05, Gao, Liming wrote:
> MdePkg provides the basic module type header file, such as PiPei.h,
> PiDxe.h, Uefi.h. PiPei.h and PiDxe.h will include the basic PI
> definition. They have included PiHob.h and PiFirmwareVolume.h.
> Because the module type header file is included into
On 2 August 2018 at 20:13, Leif Lindholm wrote:
> Graeme, Ard, do either of you have the stamina to go through all this,
> or will wi settle for testing it?
>
Well, without a SoC manual, it is rather difficult to review this in
great detail.
I did give it a quick skim, and the only thing that
On 2 August 2018 at 17:12, Marcin Wojtas wrote:
> czw., 2 sie 2018 o 16:59 Ard Biesheuvel
> napisał(a):
>>
>> On 2 August 2018 at 16:49, Marcin Wojtas wrote:
>> > EDK2 code uses a single 64bit write to update SBSA watchdog
>> > compare registers, however an access to mmio registers should
>> >
Marvin:
I suggest to verify this library functionality on Standalone MM driver first,
then propose how to change it to support more module type.
Thanks
Liming
> -Original Message-
> From: Marvin H?user [mailto:marvin.haeu...@outlook.com]
> Sent: Monday, July 23, 2018 9:02 PM
> To:
Thanks Andrew and Laszlo for the clarification and guidance.
About Laszlo questions
>Is the reboot automatic (from the platform firmware), or application /
>user initiated?
Yes. We just do some clean up, finish the events and "return EFI_SUCCESS;"
>Do you exit the application before the system
On 2 August 2018 at 16:49, Marcin Wojtas wrote:
> EDK2 code uses a single 64bit write to update SBSA watchdog
> compare registers, however an access to mmio registers should
> be 32bit for some SoCs. Current usage of MmioWrite64 resulted
> in an unpredicted behavior. Fix this by modifying
>
On Tue, Jul 24, 2018 at 03:08:50PM +0800, Ming Huang wrote:
> This library include BoardFeatureD06.c and OemMiscLibD06.c c file,
> use for several modules like PciHostBridgeLib and Smbios.
> Enlarge macro PCIEDEVICE_REPORT_MAX for D06.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
This version change is good to me.
Reviewed-by: Liming Gao
> -Original Message-
> From: Marvin Häuser [mailto:marvin.haeu...@outlook.com]
> Sent: Tuesday, July 24, 2018 8:10 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Zeng, Star ; Dong,
> Eric ; Ni,
On Thu, Aug 02, 2018 at 11:12:56AM +0100, Leif Lindholm wrote:
> On Thu, Aug 02, 2018 at 09:46:13AM +0800, Ming wrote:
> > I am sorry for the first issue, the modify FIRMWARE_VER patch is add
> > alone just befor send out the patchset.
> >
> > For generating acpi table, I use acpica-tools
On Tue, Jul 24, 2018 at 03:08:47PM +0800, Ming Huang wrote:
> Add several basal head file and add several build configuration
basal -> base
> for D06.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> Signed-off-by: Heyi Guo
Ah, yes - please drop the
Laszlo:
I understand this patch set is to provide the way to append compile and link
option for BaseTools source build. If so, the extend flag name may be
EXTRA_CCFLAGS and EXTRA_LDFLAGS. And, the extend flags are appended in the
tail.
Besides, Pccts is the internal tool to generate
On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming Huang wrote:
> This patch is relative to D06 SasDxe driver. The SasDxe set a
> variable to notice this libray. Here Wait for all disk ready
> for 30S at most.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
>
Graeme, Ard, do either of you have the stamina to go through all this,
or will wi settle for testing it?
On Tue, Jul 24, 2018 at 03:08:54PM +0800, Ming Huang wrote:
> From: Yan Zhang
>
> ACPI tables for D06 2P, especially,Hi1620Iort.asl is include smmu
> and Hi1620IortNoSmmu.asl is without
czw., 2 sie 2018 o 16:59 Ard Biesheuvel napisał(a):
>
> On 2 August 2018 at 16:49, Marcin Wojtas wrote:
> > EDK2 code uses a single 64bit write to update SBSA watchdog
> > compare registers, however an access to mmio registers should
> > be 32bit for some SoCs. Current usage of MmioWrite64
On Tue, Jul 24, 2018 at 03:08:48PM +0800, Ming Huang wrote:
> Add M41T83RealTimeClockLib for RTC.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> Signed-off-by: Heyi Guo
> ---
> Platform/Hisilicon/D06/D06.dsc
On 08/02/18 18:42, Rafael Machado wrote:
> Thanks Andrew and Laszlo for the clarification and guidance.
>
> About Laszlo questions
>
>> Is the reboot automatic (from the platform firmware), or application /
>> user initiated?
> Yes. We just do some clean up, finish the events and "return
On 26 July 2018 at 09:21, Marcin Wojtas wrote:
> Hi,
>
> The second version of the patchset brings minor corrections,
> that were pointed out during review. Details can be found
> int the commit logs.
>
> The patches are available in the github:
>
Currently if an invalid parameter is passed, it gives a stack trace.
This changes it to an error message.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Scripts/PatchCheck.py | 9 ++---
1 file changed, 6
Hi Laszlo
Got your point. Thanks for the comment.
I'll keep working on it.
In case someone has some other information or idea feel free to share.
Thanks
Rafael
Em qui, 2 de ago de 2018 às 14:48, Laszlo Ersek
escreveu:
> On 08/02/18 18:42, Rafael Machado wrote:
> > Thanks Andrew and Laszlo
Just found something interesting.
Based on the logs from the serial port.
This system works fine:
"PeiInstallPeiMemory MemoryBegin 0x93D5, MemoryLength 0xA2B
Temp Stack : BaseAddress=0x40 Length=0x8
Temp Heap : BaseAddress=0x48 Length=0x8
Total temporary memory:
https://bugzilla.tianocore.org/show_bug.cgi?id=1069
The ByteArray() method returns a string with the hex bytes of
a PCD value. Make sure the string is always encoded as a string,
so it can be used to build a complete PCD statement string and be
written out to a file. This change is required for
On 08/02/18 21:18, Rafael Machado wrote:
> Just found something interesting.
> Based on the logs from the serial port.
>
> This system works fine:
>
> "PeiInstallPeiMemory MemoryBegin 0x93D5, MemoryLength 0xA2B
> Temp Stack : BaseAddress=0x40 Length=0x8
> Temp Heap :
On Thu, Aug 02, 2018 at 08:32:18PM +0200, Ard Biesheuvel wrote:
> On 2 August 2018 at 17:12, Marcin Wojtas wrote:
> > czw., 2 sie 2018 o 16:59 Ard Biesheuvel
> > napisał(a):
> >>
> >> On 2 August 2018 at 16:49, Marcin Wojtas wrote:
> >> > EDK2 code uses a single 64bit write to update SBSA
According to the SBSA specification the Watchdog Compare
Register is split into two separate 32bit registers.
EDK2 code uses a single 64bit transaction to update
them, which can be problematic, depending on the SoC
implementation and could result in an unpredicted behavior.
Fix this by modifying
Tks Lazslo. And please make sure PcdLib is correctly lined in OVMF
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 2, 2018 9:14 PM
To: Zhang, Chao B ; Ricardo Araújo
; Marc-André Lureau
Cc: edk2-devel@lists.01.org; Gao, Liming ; Zeng, Star
Subject: Re: [edk2] Missing
Current code logic can't confirm CpuS3DataDxe driver start before
CpuFeaturesDxe driver. So the assumption in CpuFeaturesDxe not
valid. Add implementation for AllocateAcpiCpuData function to remove
this assumption.
Pass OS boot and resume from S3 test.
Cc: Laszlo Ersek
Cc: Ruiyu Ni
The DXE Core is one of those modules that call
ProcessLibraryConstructorList() manually.
Before DxeMain() [MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c] calls
ProcessLibraryConstructorList(), and through it, our
PlatformDebugLibIoPortConstructor() function, DxeMain() invokes the
DEBUG() macro multiple
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Kinney, Michael D
Sent: Friday, August 3, 2018 5:26 AM
To: edk2-devel@lists.01.org
Cc: Sun, Yanyan ; Zhu, Yonghong ;
Gao, Liming ; Kinney, Michael D
Subject: [Patch] BaseTools/BinToPcd: Encode string
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Kinney, Michael D
Sent: Friday, August 3, 2018 9:39 AM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming ;
Kinney, Michael D
Subject: [Patch] BaseTools/Pkcs7Sign: Add PKCS7 test key include
Thanks Jiewen
> -Original Message-
> From: Yao, Jiewen [mailto:jiewen@intel.com]
> Sent: Thursday, August 2, 2018 6:24 PM
> To: Udit Kumar ; edk2-devel@lists.01.org
> Cc: Sumit Batra
> Subject: RE: Tool to check memory leaks
>
> Please refer to
>
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Friday, August 03, 2018 11:41 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A
> Subject: [edk2] [PATCH] MdePkg/BaseLib: Add an
https://bugzilla.tianocore.org/show_bug.cgi?id=1073
Add PCD statement include files for the PKCS7 test key.
* gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer
* gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr
These include files can be used in !include statements in PCD
sections of a
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Hao A Wu
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 1 +
This commit adds an addtional check in AsciiStriCmp. It
explicitly checks the end of the sting pointed by 'SecondString' to make
the code logic easier for reading and to prevent possible mis-reports by
static code checkers.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ni, Ruiyu
> Sent: Friday, August 03, 2018 11:42 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A
> Subject: [PATCH] ShellPkg/acpi: Code cleanup to pass static code checker
>
> Contributed-under: TianoCore
> On Aug 2, 2018, at 5:39 AM, Rafael Machado
> wrote:
>
> Hi everyone
>
> After some other tasks I am back to this case :)
>
> After some debug, we detected the moment where things start to go wrong, but
> I am not sure what may cause this.
>
> What we noticed is that the following assert
On Tue, Jul 24, 2018 at 03:08:45PM +0800, Ming Huang wrote:
> This patch is to unify D0x. Add pGBL_INTERFACE struct define
> and remove useless interfece. Replace DMRC pGblData with pGblInterface;
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhou You
>
On 08/02/18 14:39, Rafael Machado wrote:
> Hi everyone
>
> After some other tasks I am back to this case :)
>
> After some debug, we detected the moment where things start to go wrong,
> but I am not sure what may cause this.
>
> What we noticed is that the following assert is reached:
>
On 08/02/18 06:06, Gao, Liming wrote:
> Laszlo:
> I have no other comments. IntelFrameworkPkg has another UefiLib library
> instance FrameworkUefiLib. Could you help update it also?
>
> For MdePkg, you can add Reviewed-by: Liming Gao
Thanks! I have now enough feedback for posting v2.
Some redundant library classes and GUIDs
have been removed in inf, .c and .h files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1044
https://bugzilla.tianocore.org/show_bug.cgi?id=1045
https://bugzilla.tianocore.org/show_bug.cgi?id=1047
https://bugzilla.tianocore.org/show_bug.cgi?id=1049
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, July 31, 2018 8:19 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [edk2] [PATCH] BaseTools: Guid.xref
Hi All
Is there some tool/debug option in edk2 to detect memory leak.
Thanks
Udit
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Shenglei,
I suggest merging this patch with
https://lists.01.org/pipermail/edk2-devel/2018-August/027883.html to one patch.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of shenglei
Sent: Thursday, August 2, 2018 4:45 PM
To:
On Thu, Aug 02, 2018 at 09:46:13AM +0800, Ming wrote:
> I am sorry for the first issue, the modify FIRMWARE_VER patch is add
> alone just befor send out the patchset.
>
> For generating acpi table, I use acpica-tools 20180508 version and it works.
> I think acpica-tools are not backward
On 08/02/18 03:20, Jiaxin Wu wrote:
> *v2: Optimize the patch by calculating AsciiStrSize() only once.
>
> In URI, the colon (:) is used to terminate the HostName path before
> a port number. However, if HostName is expressed as IPv6 format, colon
> characters in IPv6 addresses will conflict with
Please refer to
https://github.com/tianocore/tianocore.github.io/wiki/Memory-leak-detection-with-memory-profile-feature
Thank you
Yao Jiewen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Udit
> Kumar
> Sent: Thursday, August 2, 2018 5:00
MdePkg provides the basic module type header file, such as PiPei.h, PiDxe.h,
Uefi.h. PiPei.h and PiDxe.h will include the basic PI definition. They have
included PiHob.h and PiFirmwareVolume.h.
Because the module type header file is included into AutoGen.h based on the
module type. And,
On 08/02/18 04:04, Zhang, Chao B wrote:
> Hi Laszlo & Ricardo
> The patch was intended to reduce the time to read TPM interface ID register.
> The interface type should not change within boot cycle according to PTP spec.
> I agree to add some ASSERT after PCDSetxxsS.
> But It is a core solution
On Thu, Aug 02, 2018 at 01:27:16AM +, Chris Co wrote:
> > > The 'data.load.elf' statement in
> > > PeCoffLoaderRelocateImageExtraAction() is particular to Lauterbach
> >
> > Oh, right.
> >
> > That (original) code badly needs reformatting.
> >
> > Still, if that's the only difference - and
On Thu, Aug 02, 2018 at 12:05:38AM +, Chris Co wrote:
> > Hmm, I'm already slightly unhappy that we have duplication between
> > EmbeddedPkg and MdeModulePkg (not to mention the extra fork for
> > Marvell's XenonDxe).
> >
> > I'm obviously keen for the added functionality to be available to
Hi everyone
After some other tasks I am back to this case :)
After some debug, we detected the moment where things start to go wrong,
but I am not sure what may cause this.
What we noticed is that the following assert is reached:
56 matches
Mail list logo
